PCP-5482: Propagate HCP gating events (#280)

Author: jayesh-srivastava

controllers/host_maintenance_controller.go

@@ -24,6 +24,7 @@ import (
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	"k8s.io/apimachinery/pkg/runtime"
 	"k8s.io/apimachinery/pkg/types"
+	"k8s.io/client-go/tools/record"
 	clusterv1 "sigs.k8s.io/cluster-api/api/v1beta1"
 	ctrl "sigs.k8s.io/controller-runtime"
 	"sigs.k8s.io/controller-runtime/pkg/client"
@@ -41,8 +42,9 @@ import (
 // HMCMaintenanceReconciler handles host maintenance operations via ConfigMap triggers
 type HMCMaintenanceReconciler struct {
 	client.Client
-	Log    logr.Logger
-	Scheme *runtime.Scheme
+	Log      logr.Logger
+	Scheme   *runtime.Scheme
+	Recorder record.EventRecorder
 	// Namespace is the controller namespace (namespaced deployment)
 	Namespace string
 	// GenericEventChannel allows external triggers to enqueue reconcile requests
@@ -242,7 +244,7 @@ func (r *HMCMaintenanceReconciler) reconcileMaasMachine(ctx context.Context, maa
 	log.Info("Maintenance tags ensured", "host", hostSystemID, "opId", st.OpID)
 
 	// Create host maintenance service
-	hmcService, err := NewHostMaintenanceService(r.Client, maasMachine.Namespace)
+	hmcService, err := NewHostMaintenanceService(r.Client, maasMachine.Namespace, r.Recorder)
 	if err != nil {
 		log.Error(err, "failed to create host maintenance service")
 		return ctrl.Result{RequeueAfter: 10 * time.Second}, err
@@ -307,6 +309,10 @@ func (r *HMCMaintenanceReconciler) SetupWithManager(ctx context.Context, mgr ctr
 	recover := true
 	options.RecoverPanic = &recover
 
+	if r.Recorder == nil {
+		r.Recorder = mgr.GetEventRecorderFor("hmc-controller")
+	}
+
 	if r.GenericEventChannel == nil {
 		r.GenericEventChannel = make(chan event.GenericEvent)
 	}

controllers/host_maintenance_service.go

@@ -23,6 +23,8 @@ import (
 	"github.com/go-logr/logr"
 	infrav1beta1 "github.com/spectrocloud/cluster-api-provider-maas/api/v1beta1"
 	maint "github.com/spectrocloud/cluster-api-provider-maas/pkg/maas/maintenance"
+	corev1 "k8s.io/api/core/v1"
+	"k8s.io/client-go/tools/record"
 	"sigs.k8s.io/controller-runtime/pkg/client"
 )
 
@@ -40,10 +42,11 @@ type HostMaintenanceService struct {
 	namespace        string
 	tagService       maint.TagService
 	inventoryService maint.InventoryService
+	recorder         record.EventRecorder
 }
 
 // NewHostMaintenanceService creates a new host maintenance service
-func NewHostMaintenanceService(k8sClient client.Client, namespace string) (*HostMaintenanceService, error) {
+func NewHostMaintenanceService(k8sClient client.Client, namespace string, recorder record.EventRecorder) (*HostMaintenanceService, error) {
 	maasClient, err := maint.NewMAASClient(k8sClient, namespace)
 	if err != nil {
 		return nil, fmt.Errorf("failed to create MAAS client: %w", err)
@@ -53,6 +56,7 @@ func NewHostMaintenanceService(k8sClient client.Client, namespace string) (*Host
 		namespace:        namespace,
 		tagService:       maint.NewTagService(maasClient),
 		inventoryService: maint.NewInventoryService(maasClient),
+		recorder:         recorder,
 	}, nil
 }
 
@@ -79,13 +83,51 @@ func (s *HostMaintenanceService) CheckEvacuationGates(ctx context.Context, maasM
 	hostSystemID := *maasMachine.Spec.SystemID
 
 	// Gate 1: Check if host is empty (no VMs running)
-	hostEmpty, err := s.isHostEmpty(ctx, hostSystemID, log)
+	// Get VMs list first so we can include names in event if host is not empty
+	vms, err := s.inventoryService.ListHostVMs(hostSystemID)
 	if err != nil {
-		return false, fmt.Errorf("failed to check if host is empty: %w", err)
+		return false, fmt.Errorf("failed to list host VMs: %w", err)
 	}
 
-	if !hostEmpty {
-		log.Info("Host not empty, evacuation blocked", "host", hostSystemID)
+	hostEmpty := len(vms) == 0
+	if hostEmpty {
+		log.Info("Host is empty (no VMs)", "host", hostSystemID)
+	} else {
+		// Get host details to use hostname in event
+		hostDetails, err := s.inventoryService.GetHost(hostSystemID)
+		hostName := hostSystemID // fallback to systemID
+		if err == nil {
+			if hostDetails.FQDN != "" {
+				hostName = hostDetails.FQDN
+			} else if hostDetails.Hostname != "" {
+				hostName = hostDetails.Hostname
+			}
+		}
+
+		// Build list of VM names/identifiers for the event
+		vmNames := make([]string, 0, len(vms))
+		for _, vm := range vms {
+			// Prefer FQDN or Hostname, fallback to SystemID
+			vmName := vm.FQDN
+			if vmName == "" {
+				vmName = vm.Hostname
+			}
+			if vmName == "" {
+				vmName = vm.SystemID
+			}
+			vmNames = append(vmNames, vmName)
+		}
+
+		log.Info("Host not empty, evacuation blocked", "host", hostSystemID, "vmCount", len(vms), "vms", vmNames)
+
+		// Emit Kubernetes event with VM names
+		if s.recorder != nil {
+			vmNamesStr := strings.Join(vmNames, ", ")
+			s.recorder.Eventf(maasMachine, corev1.EventTypeWarning, "EvacuationBlocked",
+				"Host evacuation blocked: %d VM(s) still present on host %s: %s",
+				len(vms), hostName, vmNamesStr)
+		}
+
 		return false, nil
 	}
 
@@ -96,7 +138,25 @@ func (s *HostMaintenanceService) CheckEvacuationGates(ctx context.Context, maasM
 	}
 
 	if !wlcReady {
+		// Get host details to use hostname in event
+		hostDetails, err := s.inventoryService.GetHost(hostSystemID)
+		hostName := hostSystemID // fallback to systemID
+		if err == nil {
+			if hostDetails.FQDN != "" {
+				hostName = hostDetails.FQDN
+			} else if hostDetails.Hostname != "" {
+				hostName = hostDetails.Hostname
+			}
+		}
+
 		log.Info("WLC ready tags not met, evacuation blocked", "host", hostSystemID)
+
+		// Emit Kubernetes event
+		if s.recorder != nil {
+			s.recorder.Eventf(maasMachine, corev1.EventTypeWarning, "WLCReplacementPending",
+				"WLC evacuation blocked: waiting for replacement VMs on host %s", hostName)
+		}
+
 		return false, nil
 	}
 

pkg/maas/scope/machine.go

@@ -314,10 +314,10 @@ func (m *MachineScope) GetStaticIP() string {
 // GetStaticIPConfig returns the full static IP configuration if configured
 func (m *MachineScope) GetStaticIPConfig() *infrav1beta1.StaticIPConfig {
 	if m.MaasMachine.Spec.StaticIP == nil {
-		m.Info("StaticIPConfig: StaticIP config is nil")
+		m.V(1).Info("StaticIPConfig: StaticIP config is nil")
 		return nil
 	}
 
-	m.Info("StaticIPConfig: returning config", "ip", m.MaasMachine.Spec.StaticIP.IP)
+	m.V(1).Info("StaticIPConfig: returning config", "ip", m.MaasMachine.Spec.StaticIP.IP)
 	return m.MaasMachine.Spec.StaticIP
 }