fix(cruby): reconciliation of ns on unparented nodes #3462
+59
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Ugh, this is going to need a bit more work. JRuby is failing, and Viewpoint (downstream) is failing. Edit: fixed JRuby. |
flavorjones
force-pushed
the
flavorjones-3459-cruby-reparenting-ns
branch
from
7e38303 to
762f2fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem is this PR intended to solve?
Closes #3459
Have you included adequate test coverage?
Yes.
Does this change affect the behavior of either the C or the Java implementations?
Fixes the behavior of both implementations.