Update sprintf %lu in getFileBlock

fronders · fronders · commit 71827b73a126 · 2024-02-05T16:45:54.000+02:00
After more testing, kept only casting from size_t to unsigned long (compatible with 32-bit MCUs)
diff --git a/src/SparkFun_u-blox_SARA-R5_Arduino_Library.cpp b/src/SparkFun_u-blox_SARA-R5_Arduino_Library.cpp
@@ -5608,11 +5608,7 @@ SARA_R5_error_t SARA_R5::getFileBlock(const String& filename, char* buffer, size
   {
     return SARA_R5_ERROR_OUT_OF_MEMORY;
   }
-#ifdef ULLONG_MAX
-  sprintf(command, "%s=\"%s\",%llu,%llu", SARA_R5_FILE_SYSTEM_READ_BLOCK, filename.c_str(), (unsigned long long) offset, (unsigned long long) requestedLength);
-#else
   sprintf(command, "%s=\"%s\",%lu,%lu", SARA_R5_FILE_SYSTEM_READ_BLOCK, filename.c_str(), (unsigned long) offset, (unsigned long) requestedLength);
-#endif
 
   response = sara_r5_calloc_char(minimumResponseAllocation);
   if (response == nullptr)

Original file line number	Diff line number	Diff line change
`@@ -5608,11 +5608,7 @@ SARA_R5_error_t SARA_R5::getFileBlock(const String& filename, char* buffer, size`
`5608`	`5608`	`{`
`5609`	`5609`	`return SARA_R5_ERROR_OUT_OF_MEMORY;`
`5610`	`5610`	`}`
`5611`		`-#ifdef ULLONG_MAX`
`5612`		`- sprintf(command, "%s=\"%s\",%llu,%llu", SARA_R5_FILE_SYSTEM_READ_BLOCK, filename.c_str(), (unsigned long long) offset, (unsigned long long) requestedLength);`
`5613`		`-#else`
`5614`	`5611`	`sprintf(command, "%s=\"%s\",%lu,%lu", SARA_R5_FILE_SYSTEM_READ_BLOCK, filename.c_str(), (unsigned long) offset, (unsigned long) requestedLength);`
`5615`		`-#endif`
`5616`	`5612`
`5617`	`5613`	`response = sara_r5_calloc_char(minimumResponseAllocation);`
`5618`	`5614`	`if (response == nullptr)`