No longer running on TypeScript React files

[tylerlaprade]

Checklist

• I have searched the Sourcery documentation for the issue, and found nothing
• I have read the common issues and fixes listed in the Sourcery troubleshooting page, and found nothing
• I have checked there are no open bugs referencing the same bug or problem

Description

Code snippet that reproduces issue

Same React/Django monorepo I've always been using

Debug Information

Sourcery Version:
1.36.0

Operating system and Version:
macOS 15.4.1

[Hellebore]

Hi - thanks for reporting. Do you know which was the last release this worked for?

[tylerlaprade]

@Hellebore, unfortunately I'm not sure. I disabled the Sourcery extension a month or more ago since I noticed it was slowing down VSC, but I didn't realize it was specifically due to TypeScript back then.

[tylerlaprade]

UPDATE: it seems this only applies to TypeScript JSX files, not raw TypeScript. I added - '*.tsx' to my ignore: section of .sourcery.yaml, and the issue doesn't happen. So the fix needs to focus on .tsx files.

[Hellebore]

Hi - I can't reproduce these issues on my mac with version 1.37.0 - would you be able to send over the sourcery log file after encourtering the problem?

Or possibly a minimal reproducible example? It's possible that certain typescript syntax could cause such an error.

[tylerlaprade]

@Hellebore , I found a minimal viable repro. Interestingly, removing any single line prevents the error from happening as does renaming (!!) any of the longer variables to x or y. This leads me to believe that you're running into an infinite loop during a post-processing formatting step. There are probably two contradictory rules trying to put the JSX on a single line vs multi-line.

export function FooBar() {
  return (
  <>
          <Group>
            <AnimatedAxis
              key="axis-right"
              hideZero={!isEnrollmentZero}
              numTicks={enrollmentTicksCount}
            />
          </Group>
          <AnimatedAxis
            tickComponent={({ formattedValue }) => (
              <g>
                <text
                  transform={
                    timeAxisLabels.autoLabels ? '' : graphOptions.angleLabels
                  }
                >
                  foo
                </text>
                <text
                  fill={graphTextColor}
                  fontSize={graphOptions.fontSizeYear}
                  fontWeight={graphOptions.fontWeightBold}
                >
                  bar
                </text>
              </g>
            )}
          />
    </>          
  );
}

And for completeness, here is my sourcery.yaml

# 🪄 This is your project's Sourcery configuration file.

# You can use it to get Sourcery working in the way you want, such as
# ignoring specific refactorings, skipping directories in your project,
# or writing custom rules.

# 📚 For a complete reference to this file, see the documentation at
# https://docs.sourcery.ai/Configuration/Project-Settings/

# This file was auto-generated by Sourcery on 2023-07-17 at 13:36.

version: '1' # The schema version of this config file

ignore: # A list of paths or files which Sourcery will ignore.
  - .git
  - venv
  - .venv
  - env
  - .env
  - .tox
  - paqarina/node_modules
  - .dev-run
  - build

rule_settings:
  enable:
    - default
  disable:
    [
      low-code-quality,
      no-loop-in-tests,
      no-conditionals-in-tests,
      avoid-function-declarations-in-blocks,
      use-braces,
      hoist-if-from-if,
      extract-method,
    ]
  rule_types:
    - refactoring
    - suggestion
    - comment
  python_version: '3.12' # A string specifying the lowest Python version your project supports. Sourcery will not suggest refactorings requiring a higher Python version.

# rules:  # A list of custom rules Sourcery will include in its analysis.
# - id: no-print-statements
#   description: Do not use print statements in the test directory.
#   pattern: print(...)
#   language: python
#   replacement:
#   condition:
#   explanation:
#   paths:
#     include:
#     - test
#     exclude:
#     - conftest.py
#   tests: []
#   tags: []

# rule_tags: {} # Additional rule tags.

# metrics:
#   quality_threshold: 25.0

# github:
#   labels: []
#   ignore_labels:
#   - sourcery-ignore
#   request_review: author
#   sourcery_branch: sourcery/{base_branch}

# clone_detection:
#   min_lines: 3
#   min_duplicates: 2
#   identical_clones_only: false

# proxy:
#   url:
#   ssl_certs_file:
#   no_ssl_verify: false