From bb667bceca657cb68368e3cbe855bd20f53893dd Mon Sep 17 00:00:00 2001 From: msukkari Date: Thu, 15 Jan 2026 20:07:43 -0800 Subject: [PATCH 1/2] fix gitlab init --- packages/backend/src/ee/repoPermissionSyncer.ts | 2 +- packages/backend/src/github.ts | 2 +- packages/backend/src/gitlab.ts | 14 +++++++------- 3 files changed, 9 insertions(+), 9 deletions(-) diff --git a/packages/backend/src/ee/repoPermissionSyncer.ts b/packages/backend/src/ee/repoPermissionSyncer.ts index 802da032e..eb9edc67c 100644 --- a/packages/backend/src/ee/repoPermissionSyncer.ts +++ b/packages/backend/src/ee/repoPermissionSyncer.ts @@ -177,7 +177,7 @@ export class RepoPermissionSyncer { const accountIds = await (async () => { if (repo.external_codeHostType === 'github') { - const isGitHubCloud = credentials.hostUrl ? new URL(credentials.hostUrl).hostname === GITHUB_CLOUD_HOSTNAME : false; + const isGitHubCloud = credentials.hostUrl ? new URL(credentials.hostUrl).hostname === GITHUB_CLOUD_HOSTNAME : true; const { octokit } = await createOctokitFromToken({ token: credentials.token, url: isGitHubCloud ? undefined : credentials.hostUrl, diff --git a/packages/backend/src/github.ts b/packages/backend/src/github.ts index 85169058c..a43d81f0e 100644 --- a/packages/backend/src/github.ts +++ b/packages/backend/src/github.ts @@ -47,7 +47,7 @@ const isHttpError = (error: unknown, status: number): boolean => { } export const createOctokitFromToken = async ({ token, url }: { token?: string, url?: string }): Promise<{ octokit: Octokit, isAuthenticated: boolean }> => { - const isGitHubCloud = url ? new URL(url).hostname === GITHUB_CLOUD_HOSTNAME : false; + const isGitHubCloud = url ? new URL(url).hostname === GITHUB_CLOUD_HOSTNAME : true; const octokit = new Octokit({ auth: token, ...(url && !isGitHubCloud ? { diff --git a/packages/backend/src/gitlab.ts b/packages/backend/src/gitlab.ts index 5d07985e7..14b8702fc 100644 --- a/packages/backend/src/gitlab.ts +++ b/packages/backend/src/gitlab.ts @@ -12,9 +12,9 @@ const logger = createLogger('gitlab'); export const GITLAB_CLOUD_HOSTNAME = "gitlab.com"; export const createGitLabFromPersonalAccessToken = async ({ token, url }: { token?: string, url?: string }) => { - const isGitLabCloud = url ? new URL(url).hostname === GITLAB_CLOUD_HOSTNAME : false; + const isGitLabCloud = url ? new URL(url).hostname === GITLAB_CLOUD_HOSTNAME : true; return new Gitlab({ - token, + ...(token ? { token } : {}), ...(isGitLabCloud ? {} : { host: url, }), @@ -23,9 +23,9 @@ export const createGitLabFromPersonalAccessToken = async ({ token, url }: { toke } export const createGitLabFromOAuthToken = async ({ oauthToken, url }: { oauthToken?: string, url?: string }) => { - const isGitLabCloud = url ? new URL(url).hostname === GITLAB_CLOUD_HOSTNAME : false; + const isGitLabCloud = url ? new URL(url).hostname === GITLAB_CLOUD_HOSTNAME : true; return new Gitlab({ - oauthToken, + ...(oauthToken ? { oauthToken } : {}), ...(isGitLabCloud ? {} : { host: url, }), @@ -99,7 +99,7 @@ export const getGitLabReposFromConfig = async (config: GitlabConnectionConfig) = const status = e?.cause?.response?.status; if (status !== undefined) { const warning = `GitLab API returned ${status}` - logger.warning(warning); + logger.warn(warning); return { type: 'warning' as const, warning @@ -139,7 +139,7 @@ export const getGitLabReposFromConfig = async (config: GitlabConnectionConfig) = const status = e?.cause?.response?.status; if (status !== undefined) { const warning = `GitLab API returned ${status}` - logger.warning(warning); + logger.warn(warning); return { type: 'warning' as const, warning @@ -177,7 +177,7 @@ export const getGitLabReposFromConfig = async (config: GitlabConnectionConfig) = const status = e?.cause?.response?.status; if (status !== undefined) { const warning = `GitLab API returned ${status}` - logger.warning(warning); + logger.warn(warning); return { type: 'warning' as const, warning From bd962d933aca7ff439b33a6c34c3665200f923b4 Mon Sep 17 00:00:00 2001 From: msukkari Date: Thu, 15 Jan 2026 20:10:14 -0800 Subject: [PATCH 2/2] changelog --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index f6319fce1..cf4e9038b 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -9,6 +9,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ### Fixed - Fixed issue with filtering on generic git repo indexed from http/https [#742](https://github.com/sourcebot-dev/sourcebot/pull/742) +- Fixed auth error when trying to sync public gitlab.com project with no token [#748](https://github.com/sourcebot-dev/sourcebot/pull/748) ## [4.10.10] - 2026-01-16