Skip to content

Commit fda319c

Browse files
Fix prod build Makefile.work (#79)
1 parent b705640 commit fda319c

File tree

1 file changed

+6
-1
lines changed

1 file changed

+6
-1
lines changed

Makefile.work

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -343,6 +343,11 @@ ifneq ($(SECURE_UPGRADE_PROD_SIGNING_TOOL),)
343343
DOCKER_RUN += -v $(SECURE_UPGRADE_PROD_SIGNING_TOOL):/sonic/scripts/$(shell basename -- $(SECURE_UPGRADE_PROD_SIGNING_TOOL)):ro
344344
endif
345345

346+
# Pass the Signing prod tool arguments as environment variable to avoid make command-line parsing issues
347+
ifneq ($(SECURE_UPGRADE_PROD_TOOL_ARGS),)
348+
DOCKER_RUN += -e "SECURE_UPGRADE_PROD_TOOL_ARGS=$(SECURE_UPGRADE_PROD_TOOL_ARGS)"
349+
endif
350+
346351
ifneq ($(SONIC_DPKG_CACHE_SOURCE),)
347352
DOCKER_RUN += -v "$(SONIC_DPKG_CACHE_SOURCE):/dpkg_cache:rw"
348353
endif
@@ -561,7 +566,6 @@ SONIC_BUILD_INSTRUCTION := $(MAKE) \
561566
SECURE_UPGRADE_SIGNING_CERT=$(SECURE_UPGRADE_SIGNING_CERT) \
562567
SECURE_UPGRADE_KERNEL_CAFILE=$(SECURE_UPGRADE_KERNEL_CAFILE) \
563568
SECURE_UPGRADE_PROD_SIGNING_TOOL=$(SECURE_UPGRADE_PROD_SIGNING_TOOL) \
564-
SECURE_UPGRADE_PROD_TOOL_ARGS="\"'$(SECURE_UPGRADE_PROD_TOOL_ARGS)'\"" \
565569
SONIC_DEFAULT_CONTAINER_REGISTRY=$(DEFAULT_CONTAINER_REGISTRY) \
566570
ENABLE_HOST_SERVICE_ON_START=$(ENABLE_HOST_SERVICE_ON_START) \
567571
SLAVE_DIR=$(SLAVE_DIR) \
@@ -606,6 +610,7 @@ export MIRROR_SECURITY_URLS
606610
export MIRROR_SNAPSHOT
607611
export SONIC_VERSION_CONTROL_COMPONENTS
608612
export PIP_HTTP_TIMEOUT
613+
export SECURE_UPGRADE_PROD_TOOL_ARGS
609614

610615
%:: | sonic-build-hooks
611616
ifneq ($(filter y, $(MULTIARCH_QEMU_ENVIRON) $(CROSS_BUILD_ENVIRON)),)

0 commit comments

Comments
 (0)