diff --git a/.eslintrc.js b/.eslintrc.js index 7d74ec52157e..d0328c9b064e 100644 --- a/.eslintrc.js +++ b/.eslintrc.js @@ -158,7 +158,8 @@ module.exports = { '@typescript-eslint/no-non-null-assertion': 'error', '@typescript-eslint/switch-exhaustiveness-check': 'error', '@typescript-eslint/consistent-type-definitions': ['error', 'type'], - '@typescript-eslint/no-floating-promises': 'off', + '@typescript-eslint/no-floating-promises': 'error', + 'no-void': 'off', '@typescript-eslint/no-import-type-side-effects': 'error', '@typescript-eslint/array-type': ['error', {default: 'array-simple'}], '@typescript-eslint/max-params': ['error', {max: 10}], diff --git a/contributingGuides/philosophies/ASYNC.md b/contributingGuides/philosophies/ASYNC.md index 2c1b1b8c0479..bc305e831866 100644 --- a/contributingGuides/philosophies/ASYNC.md +++ b/contributingGuides/philosophies/ASYNC.md @@ -10,7 +10,7 @@ Async code is everywhere in our app: API calls, storage access, background tasks ## Rules -### -Use async/await for sequential flows +### - Use async/await for sequential flows When order matters, `async/await` expresses intent in a clear, linear style. Example: Upload a file → Parse it → Save results. diff --git a/src/components/AnchorForAttachmentsOnly/BaseAnchorForAttachmentsOnly.tsx b/src/components/AnchorForAttachmentsOnly/BaseAnchorForAttachmentsOnly.tsx index a87e9593504a..cba071a26633 100644 --- a/src/components/AnchorForAttachmentsOnly/BaseAnchorForAttachmentsOnly.tsx +++ b/src/components/AnchorForAttachmentsOnly/BaseAnchorForAttachmentsOnly.tsx @@ -43,7 +43,7 @@ function BaseAnchorForAttachmentsOnly({style, source = '', displayName = '', onP return; } setDownload(sourceID, true); - fileDownload(sourceURLWithAuth, displayName, '', isMobileSafari()).then(() => setDownload(sourceID, false)); + void fileDownload(sourceURLWithAuth, displayName, '', isMobileSafari()).then(() => setDownload(sourceID, false)); }} onPressIn={onPressIn} onPressOut={onPressOut} diff --git a/src/components/AttachmentModal.tsx b/src/components/AttachmentModal.tsx index b20a26152db9..7b528036caed 100644 --- a/src/components/AttachmentModal.tsx +++ b/src/components/AttachmentModal.tsx @@ -264,7 +264,7 @@ function AttachmentModal({ if (typeof sourceURL === 'string') { const fileName = type === CONST.ATTACHMENT_TYPE.SEARCH ? getFileName(`${sourceURL}`) : file?.name; - fileDownload(sourceURL, fileName ?? '', undefined, undefined, undefined, undefined, undefined, !draftTransactionID); + void fileDownload(sourceURL, fileName ?? '', undefined, undefined, undefined, undefined, undefined, !draftTransactionID); } // At ios, if the keyboard is open while opening the attachment, then after downloading @@ -437,7 +437,7 @@ function AttachmentModal({ } if (isReplaceReceipt.current) { - InteractionManager.runAfterInteractions(() => { + void InteractionManager.runAfterInteractions(() => { Navigation.navigate( ROUTES.MONEY_REQUEST_STEP_SCAN.getRoute( iouAction ?? CONST.IOU.ACTION.EDIT, diff --git a/src/components/AutoSubmitModal.tsx b/src/components/AutoSubmitModal.tsx index 54b0bc741761..f7e5e8526dde 100644 --- a/src/components/AutoSubmitModal.tsx +++ b/src/components/AutoSubmitModal.tsx @@ -35,7 +35,7 @@ function AutoSubmitModal() { const StyleUtils = useStyleUtils(); const onClose = useCallback((willShowAgain: boolean) => { - InteractionManager.runAfterInteractions(() => { + void InteractionManager.runAfterInteractions(() => { if (!willShowAgain) { dismissASAPSubmitExplanation(true); } else { diff --git a/src/components/AvatarCropModal/AvatarCropModal.tsx b/src/components/AvatarCropModal/AvatarCropModal.tsx index be14348ce897..73d635ce0f88 100644 --- a/src/components/AvatarCropModal/AvatarCropModal.tsx +++ b/src/components/AvatarCropModal/AvatarCropModal.tsx @@ -316,7 +316,7 @@ function AvatarCropModal({imageUri = '', imageName = '', imageType = '', onClose cropOrRotateImage(imageUri, [{rotate: rotation.get() % 360}, {crop}], {compress: 1, name, type}) .then((newImage) => { - InteractionManager.runAfterInteractions(() => { + void InteractionManager.runAfterInteractions(() => { onClose?.(); }); onSave?.(newImage); diff --git a/src/components/ContactPermissionModal/index.native.tsx b/src/components/ContactPermissionModal/index.native.tsx index fe873ec1df00..55194a6e88b4 100644 --- a/src/components/ContactPermissionModal/index.native.tsx +++ b/src/components/ContactPermissionModal/index.native.tsx @@ -34,7 +34,7 @@ function ContactPermissionModal({onDeny, onGrant, onFocusTextInput}: ContactPerm const handleGrantPermission = () => { setIsModalVisible(false); - InteractionManager.runAfterInteractions(() => { + void InteractionManager.runAfterInteractions(() => { requestContactPermission().then((status) => { onFocusTextInput(); if (status !== RESULTS.GRANTED) { @@ -50,7 +50,7 @@ function ContactPermissionModal({onDeny, onGrant, onFocusTextInput}: ContactPerm onDeny(RESULTS.DENIED); // Sometimes, the input gains focus when the modal closes, but the keyboard doesn't appear. // To fix this, we need to call the focus function after the modal has finished closing. - InteractionManager.runAfterInteractions(() => { + void InteractionManager.runAfterInteractions(() => { onFocusTextInput(); }); }; diff --git a/src/components/DatePicker/index.tsx b/src/components/DatePicker/index.tsx index 837ab7f8ea5e..defa147253eb 100644 --- a/src/components/DatePicker/index.tsx +++ b/src/components/DatePicker/index.tsx @@ -95,7 +95,7 @@ function DatePicker( }; useEffect(() => { - InteractionManager.runAfterInteractions(() => { + void InteractionManager.runAfterInteractions(() => { calculatePopoverPosition(); }); }, [calculatePopoverPosition, windowWidth]); @@ -105,7 +105,7 @@ function DatePicker( return; } isAutoFocused.current = true; - InteractionManager.runAfterInteractions(() => { + void InteractionManager.runAfterInteractions(() => { handlePress(); }); }, [handlePress, autoFocus]); diff --git a/src/components/DeeplinkWrapper/index.website.tsx b/src/components/DeeplinkWrapper/index.website.tsx index c5b4cb6ec59f..eb4dddc9d484 100644 --- a/src/components/DeeplinkWrapper/index.website.tsx +++ b/src/components/DeeplinkWrapper/index.website.tsx @@ -68,7 +68,7 @@ function DeeplinkWrapper({children, isAuthenticated, autoAuthState, initialUrl}: if (isAuthenticated === false) { setHasShownPrompt(false); - Navigation.isNavigationReady().then(() => { + void Navigation.isNavigationReady().then(() => { // Get initial route const initialRoute = navigationRef.current?.getCurrentRoute(); setCurrentScreen(initialRoute?.name); diff --git a/src/components/DotIndicatorMessage.tsx b/src/components/DotIndicatorMessage.tsx index 4b1d975b014b..0d5751c84689 100644 --- a/src/components/DotIndicatorMessage.tsx +++ b/src/components/DotIndicatorMessage.tsx @@ -82,7 +82,7 @@ function DotIndicatorMessage({messages = {}, style, type, textStyles, dismissErr { - fileDownload(message.source, message.filename).finally(() => dismissError()); + void fileDownload(message.source, message.filename).finally(() => dismissError()); }} > {translate('iou.error.saveFileMessage')} diff --git a/src/components/EmojiPicker/EmojiPickerMenu/index.native.tsx b/src/components/EmojiPicker/EmojiPickerMenu/index.native.tsx index 630b09c63dd4..26977de1085c 100644 --- a/src/components/EmojiPicker/EmojiPickerMenu/index.native.tsx +++ b/src/components/EmojiPicker/EmojiPickerMenu/index.native.tsx @@ -47,7 +47,7 @@ function EmojiPickerMenu({onEmojiSelected, activeEmoji, ref}: EmojiPickerMenuPro setFilteredEmojis(emojiData); setHeaderIndices(headerData); - InteractionManager.runAfterInteractions(() => { + void InteractionManager.runAfterInteractions(() => { requestAnimationFrame(() => { emojiListRef.current?.scrollToOffset({offset: 0, animated: false}); }); diff --git a/src/components/FeatureTrainingModal.tsx b/src/components/FeatureTrainingModal.tsx index d95d553d9492..a073107798dc 100644 --- a/src/components/FeatureTrainingModal.tsx +++ b/src/components/FeatureTrainingModal.tsx @@ -220,7 +220,7 @@ function FeatureTrainingModal({ const {isKeyboardActive} = useKeyboardState(); useEffect(() => { - InteractionManager.runAfterInteractions(() => { + void InteractionManager.runAfterInteractions(() => { if (!isModalDisabled) { setIsModalVisible(false); return; @@ -347,7 +347,7 @@ function FeatureTrainingModal({ Log.hmmm('[FeatureTrainingModal] Setting modal invisible'); setIsModalVisible(false); - InteractionManager.runAfterInteractions(() => { + void InteractionManager.runAfterInteractions(() => { Log.hmmm(`[FeatureTrainingModal] Running after interactions - shouldGoBack: ${shouldGoBack}, hasOnClose: ${!!onClose}`); if (shouldGoBack) { diff --git a/src/components/Form/FormProvider.tsx b/src/components/Form/FormProvider.tsx index 712e9e766dc7..1981d6e8230e 100644 --- a/src/components/Form/FormProvider.tsx +++ b/src/components/Form/FormProvider.tsx @@ -417,7 +417,7 @@ function FormProvider({ } inputProps.onBlur?.(event); if (isSafari()) { - InteractionManager.runAfterInteractions(() => { + void InteractionManager.runAfterInteractions(() => { setIsBlurred(true); }); } diff --git a/src/components/Form/FormWrapper.tsx b/src/components/Form/FormWrapper.tsx index d342d865f5a8..f89ecb13fa46 100644 --- a/src/components/Form/FormWrapper.tsx +++ b/src/components/Form/FormWrapper.tsx @@ -228,7 +228,7 @@ function FormWrapper({ if (!shouldScrollToEnd) { return; } - InteractionManager.runAfterInteractions(() => { + void InteractionManager.runAfterInteractions(() => { requestAnimationFrame(() => { formRef.current?.scrollToEnd({animated: true}); }); diff --git a/src/components/MoneyReportHeader.tsx b/src/components/MoneyReportHeader.tsx index aa2eb9cbb8d5..e842f8694175 100644 --- a/src/components/MoneyReportHeader.tsx +++ b/src/components/MoneyReportHeader.tsx @@ -413,7 +413,7 @@ function MoneyReportHeader({ showDelegateNoAccessModal(); } else if (isAnyTransactionOnHold) { if (getPlatform() === CONST.PLATFORM.IOS) { - InteractionManager.runAfterInteractions(() => setIsHoldMenuVisible(true)); + void InteractionManager.runAfterInteractions(() => setIsHoldMenuVisible(true)); } else { setIsHoldMenuVisible(true); } @@ -1388,7 +1388,7 @@ function MoneyReportHeader({ } // it's deleting transaction but not the report which leads to bug (that is actually also on staging) // Money request should be deleted when interactions are done, to not show the not found page before navigating to goBackRoute - InteractionManager.runAfterInteractions(() => { + void InteractionManager.runAfterInteractions(() => { deleteMoneyRequest(transaction?.transactionID, requestParentReportAction, duplicateTransactions, duplicateTransactionViolations); removeTransaction(transaction.transactionID); }); @@ -1429,7 +1429,7 @@ function MoneyReportHeader({ setIsDeleteReportModalVisible(false); Navigation.goBack(); - InteractionManager.runAfterInteractions(() => { + void InteractionManager.runAfterInteractions(() => { deleteAppReport(moneyRequestReport?.reportID); }); }} diff --git a/src/components/MoneyRequestConfirmationList.tsx b/src/components/MoneyRequestConfirmationList.tsx index b897ce48c572..9c67b0db86d5 100755 --- a/src/components/MoneyRequestConfirmationList.tsx +++ b/src/components/MoneyRequestConfirmationList.tsx @@ -1005,7 +1005,7 @@ function MoneyRequestConfirmationList({ useFocusEffect( useCallback(() => { focusTimeoutRef.current = setTimeout(() => { - InteractionManager.runAfterInteractions(() => { + void InteractionManager.runAfterInteractions(() => { blurActiveElement(); }); }, CONST.ANIMATED_TRANSITION); diff --git a/src/components/MoneyRequestReportView/MoneyRequestReportActionsList.tsx b/src/components/MoneyRequestReportView/MoneyRequestReportActionsList.tsx index 93c736f1469d..a273a4fb4077 100644 --- a/src/components/MoneyRequestReportView/MoneyRequestReportActionsList.tsx +++ b/src/components/MoneyRequestReportView/MoneyRequestReportActionsList.tsx @@ -263,7 +263,7 @@ function MoneyRequestReportActionsList({ return; } - InteractionManager.runAfterInteractions(() => requestAnimationFrame(() => loadOlderChats(false))); + void InteractionManager.runAfterInteractions(() => requestAnimationFrame(() => loadOlderChats(false))); }, [loadOlderChats]); const onEndReached = useCallback(() => { @@ -484,7 +484,7 @@ function MoneyRequestReportActionsList({ const scrollToBottomForCurrentUserAction = useCallback( (isFromCurrentUser: boolean, reportAction?: OnyxTypes.ReportAction) => { - InteractionManager.runAfterInteractions(() => { + void InteractionManager.runAfterInteractions(() => { setIsFloatingMessageCounterVisible(false); // If a new comment is added from the current user, scroll to the bottom, otherwise leave the user position unchanged if (!isFromCurrentUser || reportAction?.actionName !== CONST.REPORT.ACTIONS.TYPE.ADD_COMMENT) { diff --git a/src/components/MoneyRequestReportView/MoneyRequestReportView.tsx b/src/components/MoneyRequestReportView/MoneyRequestReportView.tsx index 2fb490aecf06..c3273d2aadca 100644 --- a/src/components/MoneyRequestReportView/MoneyRequestReportView.tsx +++ b/src/components/MoneyRequestReportView/MoneyRequestReportView.tsx @@ -122,7 +122,7 @@ function MoneyRequestReportView({report, policy, reportMetadata, shouldDisplayRe const dismissReportCreationError = useCallback(() => { goBackFromSearchMoneyRequest(); - InteractionManager.runAfterInteractions(() => removeFailedReport(reportID)); + void InteractionManager.runAfterInteractions(() => removeFailedReport(reportID)); }, [reportID]); // Special case handling a report that is a transaction thread diff --git a/src/components/OptionRow.tsx b/src/components/OptionRow.tsx index d856eddb536a..5bf58e7ea589 100644 --- a/src/components/OptionRow.tsx +++ b/src/components/OptionRow.tsx @@ -189,7 +189,7 @@ function OptionRow({ result = Promise.resolve(); } - InteractionManager.runAfterInteractions(() => { + void InteractionManager.runAfterInteractions(() => { result?.finally(() => setIsDisabled(isOptionDisabled)); }); }} diff --git a/src/components/Search/SearchRouter/SearchRouter.tsx b/src/components/Search/SearchRouter/SearchRouter.tsx index 3a691cceef27..b2594146404d 100644 --- a/src/components/Search/SearchRouter/SearchRouter.tsx +++ b/src/components/Search/SearchRouter/SearchRouter.tsx @@ -314,7 +314,7 @@ function SearchRouter({onRouterClose, shouldHideInputCaret, isSearchRouterDispla const setFocusAndScrollToRight = () => { try { - InteractionManager.runAfterInteractions(() => { + void InteractionManager.runAfterInteractions(() => { if (!textInputRef.current) { Log.info('[CMD_K_DEBUG] Focus skipped - no text input ref', false, { actionId, diff --git a/src/components/SidePanel/useSyncSidePanelWithHistory/index.ts b/src/components/SidePanel/useSyncSidePanelWithHistory/index.ts index 59b7d6b0c228..004adad6c0f3 100644 --- a/src/components/SidePanel/useSyncSidePanelWithHistory/index.ts +++ b/src/components/SidePanel/useSyncSidePanelWithHistory/index.ts @@ -8,7 +8,7 @@ import navigationRef from '@libs/Navigation/navigationRef'; import CONST from '@src/CONST'; function toggleSidePanelWithHistory(isVisible: boolean) { - Navigation.isNavigationReady().then(() => { + void Navigation.isNavigationReady().then(() => { navigationRef.dispatch({ type: CONST.NAVIGATION.ACTION_TYPE.TOGGLE_SIDE_PANEL_WITH_HISTORY, payload: {isVisible}, diff --git a/src/components/TestDrive/Modal/AdminTestDriveModal.tsx b/src/components/TestDrive/Modal/AdminTestDriveModal.tsx index f36543aee2fd..f8dbef060f40 100644 --- a/src/components/TestDrive/Modal/AdminTestDriveModal.tsx +++ b/src/components/TestDrive/Modal/AdminTestDriveModal.tsx @@ -16,7 +16,7 @@ function AdminTestDriveModal() { const navigate = () => { Log.hmmm('[AdminTestDriveModal] Navigate function called'); - InteractionManager.runAfterInteractions(() => { + void InteractionManager.runAfterInteractions(() => { Log.hmmm('[AdminTestDriveModal] Calling Navigation.navigate()'); Navigation.navigate(ROUTES.TEST_DRIVE_DEMO_ROOT); }); @@ -27,7 +27,7 @@ function AdminTestDriveModal() { Navigation.dismissModal(); Log.hmmm('[AdminTestDriveModal] Running after interactions'); - InteractionManager.runAfterInteractions(() => { + void InteractionManager.runAfterInteractions(() => { if (!isAdminRoom(onboardingReport)) { Log.hmmm('[AdminTestDriveModal] Not an admin room'); return; diff --git a/src/components/TestDrive/Modal/EmployeeTestDriveModal.tsx b/src/components/TestDrive/Modal/EmployeeTestDriveModal.tsx index 8fb01cef2f6a..20e9af699345 100644 --- a/src/components/TestDrive/Modal/EmployeeTestDriveModal.tsx +++ b/src/components/TestDrive/Modal/EmployeeTestDriveModal.tsx @@ -94,7 +94,7 @@ function EmployeeTestDriveModal() { Log.hmmm('[EmployeeTestDriveModal] Running after interactions'); Navigation.goBack(); - InteractionManager.runAfterInteractions(() => { + void InteractionManager.runAfterInteractions(() => { Log.hmmm('[EmployeeTestDriveModal] Calling Navigation.goBack() and Navigation.navigate()'); Navigation.navigate(ROUTES.MONEY_REQUEST_STEP_CONFIRMATION.getRoute(CONST.IOU.ACTION.CREATE, CONST.IOU.TYPE.SUBMIT, transactionID, reportID)); }); diff --git a/src/components/TestDrive/TestDriveDemo.tsx b/src/components/TestDrive/TestDriveDemo.tsx index 988758ee372b..530910837c97 100644 --- a/src/components/TestDrive/TestDriveDemo.tsx +++ b/src/components/TestDrive/TestDriveDemo.tsx @@ -34,7 +34,7 @@ function TestDriveDemo() { }); useEffect(() => { - InteractionManager.runAfterInteractions(() => { + void InteractionManager.runAfterInteractions(() => { setIsVisible(true); completeTestDriveTask(); }); @@ -46,7 +46,7 @@ function TestDriveDemo() { const closeModal = useCallback(() => { setIsVisible(false); - InteractionManager.runAfterInteractions(() => { + void InteractionManager.runAfterInteractions(() => { Navigation.goBack(); if (isAdminRoom(onboardingReport)) { diff --git a/src/components/VideoPlayerContexts/PlaybackContext/index.tsx b/src/components/VideoPlayerContexts/PlaybackContext/index.tsx index f39a9621475b..b610b64da87b 100644 --- a/src/components/VideoPlayerContexts/PlaybackContext/index.tsx +++ b/src/components/VideoPlayerContexts/PlaybackContext/index.tsx @@ -79,7 +79,7 @@ function PlaybackContextProvider({children}: ChildrenProps) { ); useEffect(() => { - Navigation.isNavigationReady().then(() => { + void Navigation.isNavigationReady().then(() => { // This logic ensures that resetVideoPlayerData is only called when currentReportID // changes from one valid value (i.e., not an empty string or '-1') to another valid value. // This prevents the video that plays when the app opens from being interrupted when currentReportID diff --git a/src/components/VideoPlayerContexts/VideoPopoverMenuContext.tsx b/src/components/VideoPlayerContexts/VideoPopoverMenuContext.tsx index ff4a349f898e..1682b0e1b869 100644 --- a/src/components/VideoPlayerContexts/VideoPopoverMenuContext.tsx +++ b/src/components/VideoPlayerContexts/VideoPopoverMenuContext.tsx @@ -32,7 +32,7 @@ function VideoPopoverMenuContextProvider({children}: ChildrenProps) { if (typeof source === 'number' || !source) { return; } - fileDownload(addEncryptedAuthTokenToURL(source)); + void fileDownload(addEncryptedAuthTokenToURL(source)); }, [source]); const menuItems = useMemo(() => { diff --git a/src/components/WideRHPContextProvider/index.tsx b/src/components/WideRHPContextProvider/index.tsx index 0835f4974aac..9d3f29516ef6 100644 --- a/src/components/WideRHPContextProvider/index.tsx +++ b/src/components/WideRHPContextProvider/index.tsx @@ -237,7 +237,7 @@ function useShowWideRHPVersion(condition: boolean) { */ useEffect(() => { return navigation.addListener('beforeRemove', () => { - InteractionManager.runAfterInteractions(() => { + void InteractionManager.runAfterInteractions(() => { cleanWideRHPRouteKey(route); }); }); diff --git a/src/hooks/useCheckIfRouteHasRemainedUnchanged.ts b/src/hooks/useCheckIfRouteHasRemainedUnchanged.ts index 22c1153c624d..019acf520839 100644 --- a/src/hooks/useCheckIfRouteHasRemainedUnchanged.ts +++ b/src/hooks/useCheckIfRouteHasRemainedUnchanged.ts @@ -49,7 +49,7 @@ function useCheckIfRouteHasRemainedUnchanged(videoUrl: string) { // Initialize and check if starting with the attachment modal useEffect(() => { - Navigation.isNavigationReady().then(() => { + void Navigation.isNavigationReady().then(() => { if (isOnInitialRenderedRouteRef.current !== undefined) { return; } diff --git a/src/hooks/useFilesValidation.tsx b/src/hooks/useFilesValidation.tsx index eed67deff167..2c935337d001 100644 --- a/src/hooks/useFilesValidation.tsx +++ b/src/hooks/useFilesValidation.tsx @@ -90,7 +90,7 @@ function useFilesValidation(proceedWithFilesAction: (files: FileObject[]) => voi const hideModalAndReset = useCallback(() => { setIsErrorModalVisible(false); - InteractionManager.runAfterInteractions(() => { + void InteractionManager.runAfterInteractions(() => { resetValidationState(); }); }, [resetValidationState]); @@ -305,7 +305,7 @@ function useFilesValidation(proceedWithFilesAction: (files: FileObject[]) => voi // the error modal is dismissed before opening the attachment modal if (!isValidatingReceipts && fileError) { setIsErrorModalVisible(false); - InteractionManager.runAfterInteractions(() => { + void InteractionManager.runAfterInteractions(() => { if (sortedFiles.length !== 0) { proceedWithFilesAction(sortedFiles); } diff --git a/src/hooks/useFirstRenderRoute.ts b/src/hooks/useFirstRenderRoute.ts index a6279a32356c..df6f3935f426 100644 --- a/src/hooks/useFirstRenderRoute.ts +++ b/src/hooks/useFirstRenderRoute.ts @@ -12,7 +12,7 @@ function useFirstRenderRoute(focusExceptionRoutes?: ((initialRoute: string | nul const initialRoute = useRef(null); useEffect(() => { - Navigation.isNavigationReady().then(() => { + void Navigation.isNavigationReady().then(() => { if (initialRoute.current) { return; } diff --git a/src/hooks/useOnboardingFlow.ts b/src/hooks/useOnboardingFlow.ts index aa3f922ee217..06286ebea3a5 100644 --- a/src/hooks/useOnboardingFlow.ts +++ b/src/hooks/useOnboardingFlow.ts @@ -49,7 +49,7 @@ function useOnboardingFlowRouter() { useEffect(() => { // This should delay opening the onboarding modal so it does not interfere with the ongoing ReportScreen params changes - InteractionManager.runAfterInteractions(() => { + void InteractionManager.runAfterInteractions(() => { // Prevent starting the onboarding flow if we are logging in as a new user with short lived token if (currentUrl?.includes(ROUTES.TRANSITION_BETWEEN_APPS) && isLoggingInAsNewSessionUser) { return; diff --git a/src/hooks/useRefreshKeyAfterInteraction/index.desktop.tsx b/src/hooks/useRefreshKeyAfterInteraction/index.desktop.tsx index 8d67020e512f..6e58c3e9239c 100644 --- a/src/hooks/useRefreshKeyAfterInteraction/index.desktop.tsx +++ b/src/hooks/useRefreshKeyAfterInteraction/index.desktop.tsx @@ -5,7 +5,7 @@ function useRefreshKeyAfterInteraction(defaultValue: string) { const [counter, setCounter] = useState(0); useEffect(() => { - InteractionManager.runAfterInteractions(() => { + void InteractionManager.runAfterInteractions(() => { setCounter((prev) => prev + 1); }); }, []); diff --git a/src/hooks/useRestoreInputFocus/index.android.ts b/src/hooks/useRestoreInputFocus/index.android.ts index a8049eb70b77..c4f76d2e435b 100644 --- a/src/hooks/useRestoreInputFocus/index.android.ts +++ b/src/hooks/useRestoreInputFocus/index.android.ts @@ -11,7 +11,7 @@ const useRestoreInputFocus = (isLostFocus: boolean) => { } if (!isLostFocus && keyboardVisibleBeforeLoosingFocusRef.current) { - InteractionManager.runAfterInteractions(() => { + void InteractionManager.runAfterInteractions(() => { KeyboardController.setFocusTo('current'); }); } diff --git a/src/hooks/useSearchHighlightAndScroll.ts b/src/hooks/useSearchHighlightAndScroll.ts index bf3883af199f..e6688b604842 100644 --- a/src/hooks/useSearchHighlightAndScroll.ts +++ b/src/hooks/useSearchHighlightAndScroll.ts @@ -132,7 +132,7 @@ function useSearchHighlightAndScroll({ triggeredByHookRef.current = true; // Trigger the search - InteractionManager.runAfterInteractions(() => { + void InteractionManager.runAfterInteractions(() => { search({queryJSON, searchKey, offset, shouldCalculateTotals}); }); diff --git a/src/hooks/useSearchSelector.native.ts b/src/hooks/useSearchSelector.native.ts index c52cca653fd9..4c2f0c49e837 100644 --- a/src/hooks/useSearchSelector.native.ts +++ b/src/hooks/useSearchSelector.native.ts @@ -23,7 +23,7 @@ function useSearchSelector(config: UseSearchSelectorConfig): UseSearchSelectorRe const initiateContactImportAndSetState = useCallback(() => { setContactPermissionState(RESULTS.GRANTED); - InteractionManager.runAfterInteractions(importAndSaveContacts); + void InteractionManager.runAfterInteractions(importAndSaveContacts); }, [importAndSaveContacts, setContactPermissionState]); // Use base hook with contact options diff --git a/src/hooks/useSingleExecution/index.native.ts b/src/hooks/useSingleExecution/index.native.ts index 3d69861d792f..0dd98ebc8e73 100644 --- a/src/hooks/useSingleExecution/index.native.ts +++ b/src/hooks/useSingleExecution/index.native.ts @@ -24,7 +24,7 @@ export default function useSingleExecution() { isExecutingRef.current = true; const execution = action(...params); - InteractionManager.runAfterInteractions(() => { + void InteractionManager.runAfterInteractions(() => { if (!(execution instanceof Promise)) { setIsExecuting(false); return; diff --git a/src/languages/IntlStore.ts b/src/languages/IntlStore.ts index 1dc260754024..5720eb621874 100644 --- a/src/languages/IntlStore.ts +++ b/src/languages/IntlStore.ts @@ -22,7 +22,7 @@ import type zhHans from './zh-hans'; // This function was added here to avoid circular dependencies function setAreTranslationsLoading(areTranslationsLoading: boolean) { // eslint-disable-next-line rulesdir/prefer-actions-set-data - Onyx.set(ONYXKEYS.ARE_TRANSLATIONS_LOADING, areTranslationsLoading); + void Onyx.set(ONYXKEYS.ARE_TRANSLATIONS_LOADING, areTranslationsLoading); } class IntlStore { diff --git a/src/libs/AttachmentModalHandler/index.ios.ts b/src/libs/AttachmentModalHandler/index.ios.ts index 26ebdfd7c0c0..392b0fa33d4d 100644 --- a/src/libs/AttachmentModalHandler/index.ios.ts +++ b/src/libs/AttachmentModalHandler/index.ios.ts @@ -8,7 +8,7 @@ const attachmentModalHandler: AttachmentModalHandler = { // The issue is tracked in https://github.com/Expensify/App/issues/52937. // `InteractionManager.runAfterInteractions` ensures that `onCloseCallback` is executed only after all interactions and animations have completed, // preventing any unintended visual delay or jarring transition when the modal is closed. - InteractionManager.runAfterInteractions(() => { + void InteractionManager.runAfterInteractions(() => { onCloseCallback?.(); }); }, diff --git a/src/libs/BootSplash/index.native.ts b/src/libs/BootSplash/index.native.ts index 8ecc5e50e068..8c04ed476ae5 100644 --- a/src/libs/BootSplash/index.native.ts +++ b/src/libs/BootSplash/index.native.ts @@ -9,7 +9,7 @@ function hide(): Promise { Log.info('[BootSplash] hiding splash screen', false); return BootSplash.hide().finally(() => { - InteractionManager.runAfterInteractions(() => { + void InteractionManager.runAfterInteractions(() => { Timing.end(CONST.TIMING.SPLASH_SCREEN); }); }); diff --git a/src/libs/BootSplash/index.ts b/src/libs/BootSplash/index.ts index 5ba0d38243a2..76bd6f29f483 100644 --- a/src/libs/BootSplash/index.ts +++ b/src/libs/BootSplash/index.ts @@ -18,7 +18,7 @@ function hide(): Promise { splash.style.opacity = '0'; } - InteractionManager.runAfterInteractions(() => { + void InteractionManager.runAfterInteractions(() => { Timing.end(CONST.TIMING.SPLASH_SCREEN); }); diff --git a/src/libs/E2E/actions/e2eLogin.ts b/src/libs/E2E/actions/e2eLogin.ts index a57aa9cb261f..90f687c19397 100644 --- a/src/libs/E2E/actions/e2eLogin.ts +++ b/src/libs/E2E/actions/e2eLogin.ts @@ -58,7 +58,7 @@ export default function (): Promise { if (!response) { return; } - Onyx.merge(ONYXKEYS.SESSION, { + void Onyx.merge(ONYXKEYS.SESSION, { authToken: response.authToken, creationDate: new Date().getTime(), email: e2eUserCredentials.email, diff --git a/src/libs/Navigation/AppNavigator/Navigators/RightModalNavigator.tsx b/src/libs/Navigation/AppNavigator/Navigators/RightModalNavigator.tsx index f4a7a441a62f..03be6c787469 100644 --- a/src/libs/Navigation/AppNavigator/Navigators/RightModalNavigator.tsx +++ b/src/libs/Navigation/AppNavigator/Navigators/RightModalNavigator.tsx @@ -45,7 +45,7 @@ function RightModalNavigator({navigation, route}: RightModalNavigatorProps) { } // Delay clearing review duplicate data till the RHP is completely closed // to avoid not found showing briefly in confirmation page when RHP is closing - InteractionManager.runAfterInteractions(() => { + void InteractionManager.runAfterInteractions(() => { abandonReviewDuplicateTransactions(); }); }, @@ -85,7 +85,7 @@ function RightModalNavigator({navigation, route}: RightModalNavigatorProps) { component={ModalStackNavigators.TwoFactorAuthenticatorStackNavigator} listeners={{ beforeRemove: () => { - InteractionManager.runAfterInteractions(clearTwoFactorAuthData); + void InteractionManager.runAfterInteractions(clearTwoFactorAuthData); }, }} /> diff --git a/src/libs/Navigation/AppNavigator/usePreloadFullScreenNavigators.ts b/src/libs/Navigation/AppNavigator/usePreloadFullScreenNavigators.ts index abdda8c14d38..651f5b191f00 100644 --- a/src/libs/Navigation/AppNavigator/usePreloadFullScreenNavigators.ts +++ b/src/libs/Navigation/AppNavigator/usePreloadFullScreenNavigators.ts @@ -114,7 +114,7 @@ function usePreloadFullScreenNavigators() { return; } navigation.reset({...navigation.getState(), preloadedRoutes: preloadedRoutes.filter((preloadedRoute) => preloadedRoute.name !== NAVIGATORS.SETTINGS_SPLIT_NAVIGATOR)}); - Navigation.isNavigationReady().then(() => setTimeout(() => preloadAccountTab(navigation, subscriptionPlan), TIMING_TO_CALL_PRELOAD)); + void Navigation.isNavigationReady().then(() => setTimeout(() => preloadAccountTab(navigation, subscriptionPlan), TIMING_TO_CALL_PRELOAD)); }, [hasSubscriptionPlanTurnedOff, navigation, preloadedRoutes, subscriptionPlan]), ); diff --git a/src/libs/Navigation/Navigation.ts b/src/libs/Navigation/Navigation.ts index ffae30974a87..05ca84ccaf8d 100644 --- a/src/libs/Navigation/Navigation.ts +++ b/src/libs/Navigation/Navigation.ts @@ -545,7 +545,7 @@ const dismissModal = (ref = navigationRef) => { isNavigationReady().then(() => { ref.dispatch({type: CONST.NAVIGATION.ACTION_TYPE.DISMISS_MODAL}); // Let React Navigation finish modal transition - InteractionManager.runAfterInteractions(() => { + void InteractionManager.runAfterInteractions(() => { fireModalDismissed(); }); }); @@ -571,7 +571,7 @@ const dismissModalWithReport = ({reportID, reportActionID, referrer, backTo}: Re return; } dismissModal(); - InteractionManager.runAfterInteractions(() => { + void InteractionManager.runAfterInteractions(() => { navigate(reportRoute); }); }); diff --git a/src/libs/Navigation/NavigationRoot.tsx b/src/libs/Navigation/NavigationRoot.tsx index fdf3bf227f59..56b78703b3ef 100644 --- a/src/libs/Navigation/NavigationRoot.tsx +++ b/src/libs/Navigation/NavigationRoot.tsx @@ -111,7 +111,7 @@ function NavigationRoot({authenticated, lastVisitedPath, initialUrl, onReady}: N const initialState = useMemo(() => { const path = initialUrl ? getPathFromURL(initialUrl) : null; if (path?.includes(ROUTES.MIGRATED_USER_WELCOME_MODAL.route) && shouldOpenLastVisitedPath(lastVisitedPath) && isOnboardingCompleted && authenticated) { - Navigation.isNavigationReady().then(() => { + void Navigation.isNavigationReady().then(() => { Navigation.navigate(ROUTES.MIGRATED_USER_WELCOME_MODAL.getRoute()); }); diff --git a/src/libs/Navigation/navigateAfterInteraction/index.ios.ts b/src/libs/Navigation/navigateAfterInteraction/index.ios.ts index 6faedf3c7616..1af46a719b49 100644 --- a/src/libs/Navigation/navigateAfterInteraction/index.ios.ts +++ b/src/libs/Navigation/navigateAfterInteraction/index.ios.ts @@ -6,7 +6,7 @@ import Navigation from '@libs/Navigation/Navigation'; * In this case we need to wait for the animation to be complete before executing the navigation */ function navigateAfterInteraction(callback: () => void) { - InteractionManager.runAfterInteractions(() => { + void InteractionManager.runAfterInteractions(() => { Navigation.setNavigationActionToMicrotaskQueue(callback); }); } diff --git a/src/libs/Notification/LocalNotification/BrowserNotifications.ts b/src/libs/Notification/LocalNotification/BrowserNotifications.ts index 302f836295d6..f06539624fa3 100644 --- a/src/libs/Notification/LocalNotification/BrowserNotifications.ts +++ b/src/libs/Notification/LocalNotification/BrowserNotifications.ts @@ -70,7 +70,7 @@ function push( tag, }); if (!silent) { - playSound(SOUNDS.RECEIVE); + void playSound(SOUNDS.RECEIVE); } notificationCache[notificationID].onclick = () => { onClick(); diff --git a/src/libs/Performance.tsx b/src/libs/Performance.tsx index 3bf45cbf61bb..f6270f166c74 100644 --- a/src/libs/Performance.tsx +++ b/src/libs/Performance.tsx @@ -45,7 +45,7 @@ function measureFailSafe(measureName: string, startOrMeasureOptions: string, end */ function measureTTI(endMark?: string): void { // Make sure TTI is captured when the app is really usable - InteractionManager.runAfterInteractions(() => { + void InteractionManager.runAfterInteractions(() => { requestAnimationFrame(() => { measureFailSafe('TTI', 'nativeLaunchStart', endMark); diff --git a/src/libs/Pusher/index.native.ts b/src/libs/Pusher/index.native.ts index 527b32da7263..2b9ce2854516 100644 --- a/src/libs/Pusher/index.native.ts +++ b/src/libs/Pusher/index.native.ts @@ -205,7 +205,7 @@ function subscribe( return initPromise.then( () => new Promise((resolve, reject) => { - InteractionManager.runAfterInteractions(() => { + void InteractionManager.runAfterInteractions(() => { // We cannot call subscribe() before init(). Prevent any attempt to do this on dev. if (!socket) { throw new Error(`[Pusher] instance not found. Pusher.subscribe() diff --git a/src/libs/Pusher/index.ts b/src/libs/Pusher/index.ts index 7fa7172676ff..0580873d45ee 100644 --- a/src/libs/Pusher/index.ts +++ b/src/libs/Pusher/index.ts @@ -200,7 +200,7 @@ function subscribe( return initPromise.then( () => new Promise((resolve, reject) => { - InteractionManager.runAfterInteractions(() => { + void InteractionManager.runAfterInteractions(() => { // We cannot call subscribe() before init(). Prevent any attempt to do this on dev. if (!socket) { throw new Error(`[Pusher] instance not found. Pusher.subscribe() diff --git a/src/libs/ReportActionItemEventHandler/index.android.ts b/src/libs/ReportActionItemEventHandler/index.android.ts index ba24fceb9899..6beefe9cf2c9 100644 --- a/src/libs/ReportActionItemEventHandler/index.android.ts +++ b/src/libs/ReportActionItemEventHandler/index.android.ts @@ -3,7 +3,7 @@ import type ReportActionItemEventHandler from './types'; const reportActionItemEventHandler: ReportActionItemEventHandler = { handleComposerLayoutChange: (reportScrollManager, index) => () => { - InteractionManager.runAfterInteractions(() => { + void InteractionManager.runAfterInteractions(() => { requestAnimationFrame(() => { reportScrollManager.scrollToIndex(index, true); }); diff --git a/src/libs/ReportUtils.ts b/src/libs/ReportUtils.ts index cad7d1244ef0..f446702532df 100644 --- a/src/libs/ReportUtils.ts +++ b/src/libs/ReportUtils.ts @@ -5720,7 +5720,7 @@ function navigateBackOnDeleteTransaction(backRoute: Route | undefined, isFromRHP if (isFromRHP) { Navigation.dismissModal(); } - Navigation.isNavigationReady().then(() => { + void Navigation.isNavigationReady().then(() => { Navigation.goBack(backRoute); }); } @@ -10432,7 +10432,7 @@ function prepareOnboardingOnyxData( assignedGuideAccountID = generateAccountID(assignedGuideEmail); isOptimisticAssignedGuide = !assignedGuidePersonalDetail; // eslint-disable-next-line rulesdir/prefer-actions-set-data - Onyx.merge(ONYXKEYS.PERSONAL_DETAILS_LIST, { + void Onyx.merge(ONYXKEYS.PERSONAL_DETAILS_LIST, { [assignedGuideAccountID]: { isOptimisticPersonalDetail: !assignedGuidePersonalDetail, login: assignedGuideEmail, diff --git a/src/libs/actions/App.ts b/src/libs/actions/App.ts index 1e8e605fe1ff..0c4bbaf1ae5b 100644 --- a/src/libs/actions/App.ts +++ b/src/libs/actions/App.ts @@ -143,9 +143,9 @@ Onyx.connectWithoutView({ return; } - Onyx.clear(KEYS_TO_PRESERVE).then(() => { + void Onyx.clear(KEYS_TO_PRESERVE).then(() => { // Set this to false to reset the flag for this client - Onyx.set(ONYXKEYS.RESET_REQUIRED, false); + void Onyx.set(ONYXKEYS.RESET_REQUIRED, false); // eslint-disable-next-line @typescript-eslint/no-use-before-define openApp(); @@ -176,7 +176,7 @@ function setLocale(locale: Locale, currentPreferredLocale: Locale | undefined) { // If user is not signed in, change just locally. if (!currentSessionData.accountID) { - Onyx.merge(ONYXKEYS.NVP_PREFERRED_LOCALE, locale); + void Onyx.merge(ONYXKEYS.NVP_PREFERRED_LOCALE, locale); return; } @@ -193,7 +193,7 @@ function setLocale(locale: Locale, currentPreferredLocale: Locale | undefined) { value: locale, }; - API.write(WRITE_COMMANDS.UPDATE_PREFERRED_LOCALE, parameters, {optimisticData}); + void API.write(WRITE_COMMANDS.UPDATE_PREFERRED_LOCALE, parameters, {optimisticData}); } function setSidebarLoaded() { @@ -201,12 +201,12 @@ function setSidebarLoaded() { return; } - Onyx.set(ONYXKEYS.IS_SIDEBAR_LOADED, true); + void Onyx.set(ONYXKEYS.IS_SIDEBAR_LOADED, true); Performance.markEnd(CONST.TIMING.SIDEBAR_LOADED); } function setAppLoading(isLoading: boolean) { - Onyx.set(ONYXKEYS.IS_LOADING_APP, isLoading); + void Onyx.set(ONYXKEYS.IS_LOADING_APP, isLoading); } /** @@ -384,7 +384,7 @@ function reconnectApp(updateIDFrom: OnyxEntry = 0) { } const isFullReconnect = !updateIDFrom; - API.writeWithNoDuplicatesConflictAction(WRITE_COMMANDS.RECONNECT_APP, params, getOnyxDataForOpenOrReconnect(false, isFullReconnect, isSidebarLoaded)); + void API.writeWithNoDuplicatesConflictAction(WRITE_COMMANDS.RECONNECT_APP, params, getOnyxDataForOpenOrReconnect(false, isFullReconnect, isSidebarLoaded)); }); }); } @@ -472,7 +472,7 @@ function createWorkspaceWithPolicyDraftAndNavigateToIt( ) { const policyIDWithDefault = policyID || generatePolicyID(); createDraftInitialWorkspace(policyOwnerEmail, policyName, policyIDWithDefault, makeMeAdmin, currency, file); - Navigation.isNavigationReady() + void Navigation.isNavigationReady() .then(() => { if (transitionFromOldDot) { // We must call goBack() to remove the /transition route from history @@ -579,7 +579,7 @@ function redirectThirdPartyDesktopSignIn() { const url = new URL(currentUrl); if (url.pathname === `/${ROUTES.GOOGLE_SIGN_IN}` || url.pathname === `/${ROUTES.APPLE_SIGN_IN}`) { - Navigation.isNavigationReady().then(() => { + void Navigation.isNavigationReady().then(() => { Navigation.goBack(); Navigation.navigate(ROUTES.DESKTOP_SIGN_IN_REDIRECT); }); @@ -605,7 +605,7 @@ function beginDeepLinkRedirect(shouldAuthenticateWithCurrentAccount = true, isMa const parameters: OpenOldDotLinkParams = {shouldRetry: false}; // eslint-disable-next-line rulesdir/no-api-side-effects-method - API.makeRequestWithSideEffects(SIDE_EFFECT_REQUEST_COMMANDS.OPEN_OLD_DOT_LINK, parameters, {}).then((response) => { + void API.makeRequestWithSideEffects(SIDE_EFFECT_REQUEST_COMMANDS.OPEN_OLD_DOT_LINK, parameters, {}).then((response) => { if (!response) { Log.alert( 'Trying to redirect via deep link, but the response is empty. User likely not authenticated.', @@ -629,23 +629,23 @@ function beginDeepLinkRedirectAfterTransition(shouldAuthenticateWithCurrentAccou function handleRestrictedEvent(eventName: string) { const parameters: HandleRestrictedEventParams = {eventName}; - API.write(WRITE_COMMANDS.HANDLE_RESTRICTED_EVENT, parameters); + void API.write(WRITE_COMMANDS.HANDLE_RESTRICTED_EVENT, parameters); } function updateLastVisitedPath(path: string) { - Onyx.merge(ONYXKEYS.LAST_VISITED_PATH, path); + void Onyx.merge(ONYXKEYS.LAST_VISITED_PATH, path); } function updateLastRoute(screen: string) { - Onyx.set(ONYXKEYS.LAST_ROUTE, screen); + void Onyx.set(ONYXKEYS.LAST_ROUTE, screen); } function setIsUsingImportedState(usingImportedState: boolean) { - Onyx.set(ONYXKEYS.IS_USING_IMPORTED_STATE, usingImportedState); + void Onyx.set(ONYXKEYS.IS_USING_IMPORTED_STATE, usingImportedState); } function setPreservedUserSession(session: OnyxTypes.Session) { - Onyx.set(ONYXKEYS.PRESERVED_USER_SESSION, session); + void Onyx.set(ONYXKEYS.PRESERVED_USER_SESSION, session); } function clearOnyxAndResetApp(shouldNavigateToHomepage?: boolean) { @@ -655,7 +655,7 @@ function clearOnyxAndResetApp(shouldNavigateToHomepage?: boolean) { rollbackOngoingRequest(); Navigation.clearPreloadedRoutes(); - Onyx.clear(KEYS_TO_PRESERVE) + void Onyx.clear(KEYS_TO_PRESERVE) .then(() => { // Network key is preserved, so when using imported state, we should stop forcing offline mode so that the app can re-fetch the network if (isStateImported) { @@ -667,8 +667,8 @@ function clearOnyxAndResetApp(shouldNavigateToHomepage?: boolean) { } if (preservedUserSession) { - Onyx.set(ONYXKEYS.SESSION, preservedUserSession); - Onyx.set(ONYXKEYS.PRESERVED_USER_SESSION, null); + void Onyx.set(ONYXKEYS.SESSION, preservedUserSession); + void Onyx.set(ONYXKEYS.PRESERVED_USER_SESSION, null); } }) .then(() => { diff --git a/src/libs/actions/AppUpdate/index.ts b/src/libs/actions/AppUpdate/index.ts index 69c80a089831..b22235eb012d 100644 --- a/src/libs/actions/AppUpdate/index.ts +++ b/src/libs/actions/AppUpdate/index.ts @@ -3,11 +3,11 @@ import ONYXKEYS from '@src/ONYXKEYS'; import updateApp from './updateApp'; function triggerUpdateAvailable() { - Onyx.set(ONYXKEYS.UPDATE_AVAILABLE, true); + void Onyx.set(ONYXKEYS.UPDATE_AVAILABLE, true); } function setIsAppInBeta(isBeta: boolean) { - Onyx.set(ONYXKEYS.IS_BETA, isBeta); + void Onyx.set(ONYXKEYS.IS_BETA, isBeta); } export {triggerUpdateAvailable, setIsAppInBeta, updateApp}; diff --git a/src/libs/actions/BankAccounts.ts b/src/libs/actions/BankAccounts.ts index bab8b15f7ecb..577b67ef756f 100644 --- a/src/libs/actions/BankAccounts.ts +++ b/src/libs/actions/BankAccounts.ts @@ -72,8 +72,8 @@ type OpenPersonalBankAccountSetupViewProps = { }; function clearPlaid(): Promise { - Onyx.set(ONYXKEYS.PLAID_LINK_TOKEN, ''); - Onyx.set(ONYXKEYS.PLAID_CURRENT_EVENT, null); + void Onyx.set(ONYXKEYS.PLAID_LINK_TOKEN, ''); + void Onyx.set(ONYXKEYS.PLAID_CURRENT_EVENT, null); return Onyx.set(ONYXKEYS.PLAID_DATA, CONST.PLAID.DEFAULT_DATA); } @@ -88,7 +88,7 @@ function openPlaidView() { } function setPlaidEvent(eventName: string | null) { - Onyx.set(ONYXKEYS.PLAID_CURRENT_EVENT, eventName); + void Onyx.set(ONYXKEYS.PLAID_CURRENT_EVENT, eventName); } /** @@ -97,13 +97,13 @@ function setPlaidEvent(eventName: string | null) { function openPersonalBankAccountSetupView({exitReportID, policyID, source, shouldSetUpUSBankAccount = false, isUserValidated = true}: OpenPersonalBankAccountSetupViewProps) { clearInternationalBankAccount().then(() => { if (exitReportID) { - Onyx.merge(ONYXKEYS.PERSONAL_BANK_ACCOUNT, {exitReportID}); + void Onyx.merge(ONYXKEYS.PERSONAL_BANK_ACCOUNT, {exitReportID}); } if (policyID) { - Onyx.merge(ONYXKEYS.PERSONAL_BANK_ACCOUNT, {policyID}); + void Onyx.merge(ONYXKEYS.PERSONAL_BANK_ACCOUNT, {policyID}); } if (source) { - Onyx.merge(ONYXKEYS.PERSONAL_BANK_ACCOUNT, {source}); + void Onyx.merge(ONYXKEYS.PERSONAL_BANK_ACCOUNT, {source}); } if (!isUserValidated) { Navigation.navigate(ROUTES.SETTINGS_CONTACT_METHOD_VERIFY_ACCOUNT.getRoute(Navigation.getActiveRoute(), ROUTES.SETTINGS_ADD_BANK_ACCOUNT.route)); @@ -123,37 +123,37 @@ function openPersonalBankAccountSetupView({exitReportID, policyID, source, shoul function openPersonalBankAccountSetupWithPlaid(exitReportID?: string) { clearPlaid().then(() => { if (exitReportID) { - Onyx.merge(ONYXKEYS.PERSONAL_BANK_ACCOUNT, {exitReportID}); + void Onyx.merge(ONYXKEYS.PERSONAL_BANK_ACCOUNT, {exitReportID}); } - Onyx.merge(ONYXKEYS.FORMS.PERSONAL_BANK_ACCOUNT_FORM_DRAFT, {setupType: CONST.BANK_ACCOUNT.SETUP_TYPE.PLAID}); + void Onyx.merge(ONYXKEYS.FORMS.PERSONAL_BANK_ACCOUNT_FORM_DRAFT, {setupType: CONST.BANK_ACCOUNT.SETUP_TYPE.PLAID}); }); } function clearPersonalBankAccountSetupType() { - Onyx.merge(ONYXKEYS.FORMS.PERSONAL_BANK_ACCOUNT_FORM_DRAFT, {setupType: null}); + void Onyx.merge(ONYXKEYS.FORMS.PERSONAL_BANK_ACCOUNT_FORM_DRAFT, {setupType: null}); } /** * Whether after adding a bank account we should continue with the KYC flow. If so, we must specify the fallback route. */ function setPersonalBankAccountContinueKYCOnSuccess(onSuccessFallbackRoute: Route) { - Onyx.merge(ONYXKEYS.PERSONAL_BANK_ACCOUNT, {onSuccessFallbackRoute}); + void Onyx.merge(ONYXKEYS.PERSONAL_BANK_ACCOUNT, {onSuccessFallbackRoute}); } function clearPersonalBankAccount() { clearPlaid(); - Onyx.set(ONYXKEYS.PERSONAL_BANK_ACCOUNT, null); - Onyx.set(ONYXKEYS.FORMS.PERSONAL_BANK_ACCOUNT_FORM_DRAFT, null); + void Onyx.set(ONYXKEYS.PERSONAL_BANK_ACCOUNT, null); + void Onyx.set(ONYXKEYS.FORMS.PERSONAL_BANK_ACCOUNT_FORM_DRAFT, null); clearPersonalBankAccountSetupType(); } function clearOnfidoToken() { - Onyx.merge(ONYXKEYS.ONFIDO_TOKEN, ''); - Onyx.merge(ONYXKEYS.ONFIDO_APPLICANT_ID, ''); + void Onyx.merge(ONYXKEYS.ONFIDO_TOKEN, ''); + void Onyx.merge(ONYXKEYS.ONFIDO_APPLICANT_ID, ''); } function updateAddPersonalBankAccountDraft(bankData: Partial) { - Onyx.merge(ONYXKEYS.FORMS.PERSONAL_BANK_ACCOUNT_FORM_DRAFT, bankData); + void Onyx.merge(ONYXKEYS.FORMS.PERSONAL_BANK_ACCOUNT_FORM_DRAFT, bankData); } /** @@ -201,7 +201,7 @@ function getVBBADataForOnyx(currentStep?: BankAccountStep, shouldShowLoading = t } function addBusinessWebsiteForDraft(websiteUrl: string) { - Onyx.merge(ONYXKEYS.FORMS.REIMBURSEMENT_ACCOUNT_FORM_DRAFT, {website: websiteUrl}); + void Onyx.merge(ONYXKEYS.FORMS.REIMBURSEMENT_ACCOUNT_FORM_DRAFT, {website: websiteUrl}); } /** @@ -240,7 +240,7 @@ function connectBankAccountWithPlaid(bankAccountID: number, selectedPlaidBankAcc }); } - API.write(WRITE_COMMANDS.CONNECT_BANK_ACCOUNT_WITH_PLAID, parameters, onyxData); + void API.write(WRITE_COMMANDS.CONNECT_BANK_ACCOUNT_WITH_PLAID, parameters, onyxData); } /** @@ -348,7 +348,7 @@ function addPersonalBankAccount(account: PlaidBankAccount, policyID?: string, so }); } - API.write(WRITE_COMMANDS.ADD_PERSONAL_BANK_ACCOUNT, parameters, onyxData); + void API.write(WRITE_COMMANDS.ADD_PERSONAL_BANK_ACCOUNT, parameters, onyxData); } function deletePaymentBankAccount(bankAccountID: number, lastUsedPaymentMethods?: LastPaymentMethod, bankAccount?: OnyxEntry) { @@ -470,7 +470,7 @@ function deletePaymentBankAccount(bankAccountID: number, lastUsedPaymentMethods? } }); - API.write(WRITE_COMMANDS.DELETE_PAYMENT_BANK_ACCOUNT, parameters, onyxData); + void API.write(WRITE_COMMANDS.DELETE_PAYMENT_BANK_ACCOUNT, parameters, onyxData); } /** @@ -486,7 +486,7 @@ function updatePersonalInformationForBankAccount(bankAccountID: number, params: if (!policyID) { return; } - API.write( + void API.write( WRITE_COMMANDS.UPDATE_PERSONAL_INFORMATION_FOR_BANK_ACCOUNT, { ...params, @@ -537,7 +537,7 @@ function validateBankAccount(bankAccountID: number, validateCode: string, policy ], }; - API.write(WRITE_COMMANDS.VALIDATE_BANK_ACCOUNT_WITH_TRANSACTIONS, parameters, onyxData); + void API.write(WRITE_COMMANDS.VALIDATE_BANK_ACCOUNT_WITH_TRANSACTIONS, parameters, onyxData); } function getCorpayBankAccountFields(country: string, currency: string) { @@ -630,6 +630,7 @@ function createCorpayBankAccount(fields: ReimbursementAccountForm, policyID: str }; return API.write(WRITE_COMMANDS.BANK_ACCOUNT_CREATE_CORPAY, parameters, onyxData); + void API.write(WRITE_COMMANDS.BANK_ACCOUNT_CREATE_CORPAY, parameters, onyxData); } function getCorpayOnboardingFields(country: Country | '') { @@ -819,7 +820,7 @@ function askForCorpaySignerInformation(parameters: AskForCorpaySignerInformation } function clearReimbursementAccount() { - Onyx.set(ONYXKEYS.REIMBURSEMENT_ACCOUNT, null); + void Onyx.set(ONYXKEYS.REIMBURSEMENT_ACCOUNT, null); } function finishCorpayBankAccountOnboarding(parameters: FinishCorpayBankAccountOnboardingParams) { @@ -937,39 +938,39 @@ function enableGlobalReimbursementsForUSDBankAccount(parameters: EnableGlobalRei } function clearEnableGlobalReimbursementsForUSDBankAccount() { - Onyx.merge(ONYXKEYS.FORMS.ENABLE_GLOBAL_REIMBURSEMENTS, {isSuccess: null, isEnablingGlobalReimbursements: null}); + void Onyx.merge(ONYXKEYS.FORMS.ENABLE_GLOBAL_REIMBURSEMENTS, {isSuccess: null, isEnablingGlobalReimbursements: null}); } function clearCorpayBankAccountFields() { - Onyx.set(ONYXKEYS.CORPAY_FIELDS, null); + void Onyx.set(ONYXKEYS.CORPAY_FIELDS, null); } function clearReimbursementAccountBankCreation() { - Onyx.merge(ONYXKEYS.REIMBURSEMENT_ACCOUNT, {isCreateCorpayBankAccount: null, isSuccess: null, isLoading: null}); + void Onyx.merge(ONYXKEYS.REIMBURSEMENT_ACCOUNT, {isCreateCorpayBankAccount: null, isSuccess: null, isLoading: null}); } function clearReimbursementAccountSaveCorpayOnboardingCompanyDetails() { - Onyx.merge(ONYXKEYS.REIMBURSEMENT_ACCOUNT, {isSuccess: null, isSavingCorpayOnboardingCompanyFields: null}); + void Onyx.merge(ONYXKEYS.REIMBURSEMENT_ACCOUNT, {isSuccess: null, isSavingCorpayOnboardingCompanyFields: null}); } function clearReimbursementAccountSaveCorpayOnboardingBeneficialOwners() { - Onyx.merge(ONYXKEYS.REIMBURSEMENT_ACCOUNT, {isSuccess: null, isSavingCorpayOnboardingBeneficialOwnersFields: null}); + void Onyx.merge(ONYXKEYS.REIMBURSEMENT_ACCOUNT, {isSuccess: null, isSavingCorpayOnboardingBeneficialOwnersFields: null}); } function clearReimbursementAccountSaveCorpayOnboardingDirectorInformation() { - Onyx.merge(ONYXKEYS.REIMBURSEMENT_ACCOUNT, {isSuccess: null, isSavingCorpayOnboardingDirectorInformation: null}); + void Onyx.merge(ONYXKEYS.REIMBURSEMENT_ACCOUNT, {isSuccess: null, isSavingCorpayOnboardingDirectorInformation: null}); } function clearReimbursementAccountFinishCorpayBankAccountOnboarding() { - Onyx.merge(ONYXKEYS.REIMBURSEMENT_ACCOUNT, {isSuccess: null, isFinishingCorpayBankAccountOnboarding: null}); + void Onyx.merge(ONYXKEYS.REIMBURSEMENT_ACCOUNT, {isSuccess: null, isFinishingCorpayBankAccountOnboarding: null}); } function clearEnterSignerInformationFormSave() { - Onyx.merge(ONYXKEYS.FORMS.ENTER_SINGER_INFO_FORM, {isSuccess: null, isSavingSignerInformation: null}); + void Onyx.merge(ONYXKEYS.FORMS.ENTER_SINGER_INFO_FORM, {isSuccess: null, isSavingSignerInformation: null}); } function clearReimbursementAccountSendReminderForCorpaySignerInformation() { - Onyx.merge(ONYXKEYS.REIMBURSEMENT_ACCOUNT, {isSuccess: null, isSendingReminderForCorpaySignerInformation: null}); + void Onyx.merge(ONYXKEYS.REIMBURSEMENT_ACCOUNT, {isSuccess: null, isSendingReminderForCorpaySignerInformation: null}); } /** @@ -1027,7 +1028,7 @@ function openReimbursementAccountPage(stepToOpen: ReimbursementAccountStep, subS * @param isConfirmPage - If we're submitting from the confirmation substep, to trigger all external checks */ function updateCompanyInformationForBankAccount(bankAccountID: number, params: Partial, policyID: string | undefined, isConfirmPage: boolean) { - API.write( + void API.write( WRITE_COMMANDS.UPDATE_COMPANY_INFORMATION_FOR_BANK_ACCOUNT, { ...params, @@ -1044,7 +1045,7 @@ function updateCompanyInformationForBankAccount(bankAccountID: number, params: P * @param params - Beneficial Owners step form params */ function updateBeneficialOwnersForBankAccount(bankAccountID: number, params: Partial, policyID: string | undefined) { - API.write( + void API.write( WRITE_COMMANDS.UPDATE_BENEFICIAL_OWNERS_FOR_BANK_ACCOUNT, { ...params, @@ -1060,7 +1061,7 @@ function updateBeneficialOwnersForBankAccount(bankAccountID: number, params: Par * @param params - Verification step form params */ function acceptACHContractForBankAccount(bankAccountID: number, params: ACHContractStepProps, policyID: string | undefined) { - API.write( + void API.write( WRITE_COMMANDS.ACCEPT_ACH_CONTRACT_FOR_BANK_ACCOUNT, { ...params, @@ -1087,7 +1088,7 @@ function connectBankAccountManually(bankAccountID: number, bankAccount: PlaidBan policyID, }; - API.write(WRITE_COMMANDS.CONNECT_BANK_ACCOUNT_MANUALLY, parameters, getVBBADataForOnyx(CONST.BANK_ACCOUNT.STEP.BANK_ACCOUNT)); + void API.write(WRITE_COMMANDS.CONNECT_BANK_ACCOUNT_MANUALLY, parameters, getVBBADataForOnyx(CONST.BANK_ACCOUNT.STEP.BANK_ACCOUNT)); } /** @@ -1100,7 +1101,7 @@ function verifyIdentityForBankAccount(bankAccountID: number, onfidoData: OnfidoD policyID, }; - API.write(WRITE_COMMANDS.VERIFY_IDENTITY_FOR_BANK_ACCOUNT, parameters, getVBBADataForOnyx()); + void API.write(WRITE_COMMANDS.VERIFY_IDENTITY_FOR_BANK_ACCOUNT, parameters, getVBBADataForOnyx()); } function openWorkspaceView(policyID: string | undefined) { @@ -1149,14 +1150,14 @@ function handlePlaidError(bankAccountID: number, error: string, errorDescription plaidRequestID, }; - API.write(WRITE_COMMANDS.BANK_ACCOUNT_HANDLE_PLAID_ERROR, parameters); + void API.write(WRITE_COMMANDS.BANK_ACCOUNT_HANDLE_PLAID_ERROR, parameters); } /** * Set the reimbursement account loading so that it happens right away, instead of when the API command is processed. */ function setReimbursementAccountLoading(isLoading: boolean) { - Onyx.merge(ONYXKEYS.REIMBURSEMENT_ACCOUNT, {isLoading}); + void Onyx.merge(ONYXKEYS.REIMBURSEMENT_ACCOUNT, {isLoading}); } function validatePlaidSelection(values: FormOnyxValues): FormInputErrors { @@ -1170,7 +1171,7 @@ function validatePlaidSelection(values: FormOnyxValues): Form } function fetchCorpayFields(bankCountry: string, bankCurrency?: string, isWithdrawal?: boolean, isBusinessBankAccount?: boolean) { - API.write( + void API.write( WRITE_COMMANDS.GET_CORPAY_BANK_ACCOUNT_FIELDS, {countryISO: bankCountry, currency: bankCurrency, isWithdrawal, isBusinessBankAccount}, { diff --git a/src/libs/actions/CanvasSize.ts b/src/libs/actions/CanvasSize.ts index 050a877eceb8..73cb50a62092 100644 --- a/src/libs/actions/CanvasSize.ts +++ b/src/libs/actions/CanvasSize.ts @@ -16,7 +16,7 @@ function retrieveMaxCanvasArea() { useWorker: false, }) .then(({width, height}) => { - Onyx.merge(ONYXKEYS.MAX_CANVAS_AREA, width * height); + void Onyx.merge(ONYXKEYS.MAX_CANVAS_AREA, width * height); }); } @@ -26,7 +26,7 @@ function retrieveMaxCanvasArea() { function retrieveMaxCanvasHeight() { canvasSize.maxHeight({ onSuccess: (width, height) => { - Onyx.merge(ONYXKEYS.MAX_CANVAS_HEIGHT, height); + void Onyx.merge(ONYXKEYS.MAX_CANVAS_HEIGHT, height); }, }); } @@ -37,7 +37,7 @@ function retrieveMaxCanvasHeight() { function retrieveMaxCanvasWidth() { canvasSize.maxWidth({ onSuccess: (width) => { - Onyx.merge(ONYXKEYS.MAX_CANVAS_WIDTH, width); + void Onyx.merge(ONYXKEYS.MAX_CANVAS_WIDTH, width); }, }); } diff --git a/src/libs/actions/Card.ts b/src/libs/actions/Card.ts index 98cc932b6c24..4e4fe542479f 100644 --- a/src/libs/actions/Card.ts +++ b/src/libs/actions/Card.ts @@ -84,7 +84,7 @@ function reportVirtualExpensifyCardFraud(card: Card, validateCode: string) { validateCode, }; - API.write(WRITE_COMMANDS.REPORT_VIRTUAL_EXPENSIFY_CARD_FRAUD, parameters, { + void API.write(WRITE_COMMANDS.REPORT_VIRTUAL_EXPENSIFY_CARD_FRAUD, parameters, { optimisticData, successData, failureData, @@ -141,7 +141,7 @@ function requestReplacementExpensifyCard(cardID: number, reason: ReplacementReas validateCode, }; - API.write(WRITE_COMMANDS.REQUEST_REPLACEMENT_EXPENSIFY_CARD, parameters, { + void API.write(WRITE_COMMANDS.REQUEST_REPLACEMENT_EXPENSIFY_CARD, parameters, { optimisticData, successData, failureData, @@ -195,7 +195,7 @@ function activatePhysicalExpensifyCard(cardLastFourDigits: string, cardID: numbe }; // eslint-disable-next-line rulesdir/no-api-side-effects-method - API.makeRequestWithSideEffects(SIDE_EFFECT_REQUEST_COMMANDS.ACTIVATE_PHYSICAL_EXPENSIFY_CARD, parameters, { + void API.makeRequestWithSideEffects(SIDE_EFFECT_REQUEST_COMMANDS.ACTIVATE_PHYSICAL_EXPENSIFY_CARD, parameters, { optimisticData, successData, failureData, @@ -204,7 +204,7 @@ function activatePhysicalExpensifyCard(cardLastFourDigits: string, cardID: numbe return; } if (response.pin) { - Onyx.set(ONYXKEYS.ACTIVATED_CARD_PIN, response.pin); + void Onyx.set(ONYXKEYS.ACTIVATED_CARD_PIN, response.pin); } }); } @@ -213,18 +213,18 @@ function activatePhysicalExpensifyCard(cardLastFourDigits: string, cardID: numbe * Clears errors for a specific cardID */ function clearCardListErrors(cardID: number) { - Onyx.merge(ONYXKEYS.CARD_LIST, {[cardID]: {errors: null, isLoading: false}}); + void Onyx.merge(ONYXKEYS.CARD_LIST, {[cardID]: {errors: null, isLoading: false}}); } /** * Clears the PIN for an activated card */ function clearActivatedCardPin() { - Onyx.set(ONYXKEYS.ACTIVATED_CARD_PIN, ''); + void Onyx.set(ONYXKEYS.ACTIVATED_CARD_PIN, ''); } function clearReportVirtualCardFraudForm() { - Onyx.merge(ONYXKEYS.FORMS.REPORT_VIRTUAL_CARD_FRAUD, {cardID: null, isLoading: false, errors: null}); + void Onyx.merge(ONYXKEYS.FORMS.REPORT_VIRTUAL_CARD_FRAUD, {cardID: null, isLoading: false, errors: null}); } /** @@ -266,7 +266,7 @@ function revealVirtualCardDetails(cardID: number, validateCode: string): Promise ]; // eslint-disable-next-line rulesdir/no-api-side-effects-method - API.makeRequestWithSideEffects(SIDE_EFFECT_REQUEST_COMMANDS.REVEAL_EXPENSIFY_CARD_DETAILS, parameters, { + void API.makeRequestWithSideEffects(SIDE_EFFECT_REQUEST_COMMANDS.REVEAL_EXPENSIFY_CARD_DETAILS, parameters, { optimisticData, successData, failureData, @@ -328,7 +328,7 @@ function updateSettlementFrequency(workspaceAccountID: number, settlementFrequen settlementFrequency, }; - API.write(WRITE_COMMANDS.UPDATE_CARD_SETTLEMENT_FREQUENCY, parameters, {optimisticData, successData, failureData}); + void API.write(WRITE_COMMANDS.UPDATE_CARD_SETTLEMENT_FREQUENCY, parameters, {optimisticData, successData, failureData}); } function updateSettlementAccount(domainName: string, workspaceAccountID: number, policyID: string, settlementBankAccountID?: number, currentSettlementBankAccountID?: number) { @@ -375,7 +375,7 @@ function updateSettlementAccount(domainName: string, workspaceAccountID: number, settlementBankAccountID, }; - API.write(WRITE_COMMANDS.UPDATE_CARD_SETTLEMENT_ACCOUNT, parameters, {optimisticData, successData, failureData}); + void API.write(WRITE_COMMANDS.UPDATE_CARD_SETTLEMENT_ACCOUNT, parameters, {optimisticData, successData, failureData}); } function getCardDefaultName(userName?: string) { @@ -386,7 +386,7 @@ function getCardDefaultName(userName?: string) { } function setIssueNewCardStepAndData({data, isEditing, step, policyID, isChangeAssigneeDisabled}: IssueNewCardFlowData) { - Onyx.merge(`${ONYXKEYS.COLLECTION.ISSUE_NEW_EXPENSIFY_CARD}${policyID}`, { + void Onyx.merge(`${ONYXKEYS.COLLECTION.ISSUE_NEW_EXPENSIFY_CARD}${policyID}`, { data, isEditing, currentStep: step, @@ -396,18 +396,18 @@ function setIssueNewCardStepAndData({data, isEditing, step, policyID, isChangeAs } function clearIssueNewCardFlow(policyID: string | undefined) { - Onyx.set(`${ONYXKEYS.COLLECTION.ISSUE_NEW_EXPENSIFY_CARD}${policyID}`, { + void Onyx.set(`${ONYXKEYS.COLLECTION.ISSUE_NEW_EXPENSIFY_CARD}${policyID}`, { currentStep: null, data: {}, }); } function clearIssueNewCardFormData() { - Onyx.set(ONYXKEYS.FORMS.ISSUE_NEW_EXPENSIFY_CARD_FORM, {}); + void Onyx.set(ONYXKEYS.FORMS.ISSUE_NEW_EXPENSIFY_CARD_FORM, {}); } function clearIssueNewCardError(policyID: string | undefined) { - Onyx.merge(`${ONYXKEYS.COLLECTION.ISSUE_NEW_EXPENSIFY_CARD}${policyID}`, {errors: null}); + void Onyx.merge(`${ONYXKEYS.COLLECTION.ISSUE_NEW_EXPENSIFY_CARD}${policyID}`, {errors: null}); } function updateExpensifyCardLimit(workspaceAccountID: number, cardID: number, newLimit: number, newAvailableSpend: number, oldLimit?: number, oldAvailableSpend?: number) { @@ -480,7 +480,7 @@ function updateExpensifyCardLimit(workspaceAccountID: number, cardID: number, ne limit: newLimit, }; - API.write(WRITE_COMMANDS.UPDATE_EXPENSIFY_CARD_LIMIT, parameters, {optimisticData, successData, failureData}); + void API.write(WRITE_COMMANDS.UPDATE_EXPENSIFY_CARD_LIMIT, parameters, {optimisticData, successData, failureData}); } function updateExpensifyCardTitle(workspaceAccountID: number, cardID: number, newCardTitle: string, oldCardTitle?: string) { @@ -548,7 +548,7 @@ function updateExpensifyCardTitle(workspaceAccountID: number, cardID: number, ne cardTitle: newCardTitle, }; - API.write(WRITE_COMMANDS.UPDATE_EXPENSIFY_CARD_TITLE, parameters, {optimisticData, successData, failureData}); + void API.write(WRITE_COMMANDS.UPDATE_EXPENSIFY_CARD_TITLE, parameters, {optimisticData, successData, failureData}); } function updateExpensifyCardLimitType(workspaceAccountID: number, cardID: number, newLimitType: CardLimitType, oldLimitType?: CardLimitType) { @@ -619,7 +619,7 @@ function updateExpensifyCardLimitType(workspaceAccountID: number, cardID: number limitType: newLimitType, }; - API.write(WRITE_COMMANDS.UPDATE_EXPENSIFY_CARD_LIMIT_TYPE, parameters, {optimisticData, successData, failureData}); + void API.write(WRITE_COMMANDS.UPDATE_EXPENSIFY_CARD_LIMIT_TYPE, parameters, {optimisticData, successData, failureData}); } function deactivateCard(workspaceAccountID: number, card?: Card) { @@ -699,7 +699,7 @@ function deactivateCard(workspaceAccountID: number, card?: Card) { cardID, }; - API.write(WRITE_COMMANDS.CARD_DEACTIVATE, parameters, {optimisticData, failureData}); + void API.write(WRITE_COMMANDS.CARD_DEACTIVATE, parameters, {optimisticData, failureData}); } function startIssueNewCardFlow(policyID: string | undefined) { @@ -777,7 +777,7 @@ function configureExpensifyCardsForPolicy(policyID: string, bankAccountID?: numb bankAccountID, }; - API.write(WRITE_COMMANDS.CONFIGURE_EXPENSIFY_CARDS_FOR_POLICY, parameters, { + void API.write(WRITE_COMMANDS.CONFIGURE_EXPENSIFY_CARDS_FOR_POLICY, parameters, { optimisticData, successData, failureData, @@ -835,7 +835,7 @@ function issueExpensifyCard(domainAccountID: number, policyID: string | undefine }; if (cardType === CONST.EXPENSIFY_CARD.CARD_TYPE.PHYSICAL) { - API.write( + void API.write( WRITE_COMMANDS.CREATE_EXPENSIFY_CARD, {...parameters, feedCountry}, { @@ -848,7 +848,7 @@ function issueExpensifyCard(domainAccountID: number, policyID: string | undefine } // eslint-disable-next-line rulesdir/no-multiple-api-calls - API.write( + void API.write( WRITE_COMMANDS.CREATE_ADMIN_ISSUED_VIRTUAL_CARD, {...parameters, policyID}, { @@ -925,7 +925,7 @@ function toggleContinuousReconciliation(workspaceAccountID: number, shouldUseCon }, ]; - API.write(WRITE_COMMANDS.TOGGLE_CARD_CONTINUOUS_RECONCILIATION, parameters, { + void API.write(WRITE_COMMANDS.TOGGLE_CARD_CONTINUOUS_RECONCILIATION, parameters, { optimisticData, successData, failureData, @@ -966,7 +966,7 @@ function queueExpensifyCardForBilling(feedCountry: string, domainAccountID: numb domainAccountID, }; - API.write(WRITE_COMMANDS.QUEUE_EXPENSIFY_CARD_FOR_BILLING, parameters); + void API.write(WRITE_COMMANDS.QUEUE_EXPENSIFY_CARD_FOR_BILLING, parameters); } export { diff --git a/src/libs/actions/Chronos.ts b/src/libs/actions/Chronos.ts index 5a54c2ee9368..03dd29104b42 100644 --- a/src/libs/actions/Chronos.ts +++ b/src/libs/actions/Chronos.ts @@ -53,7 +53,7 @@ const removeEvent = (reportID: string | undefined, reportActionID: string, event reportActionID, }; - API.write(WRITE_COMMANDS.CHRONOS_REMOVE_OOO_EVENT, parameters, {optimisticData, successData, failureData}); + void API.write(WRITE_COMMANDS.CHRONOS_REMOVE_OOO_EVENT, parameters, {optimisticData, successData, failureData}); }; export { diff --git a/src/libs/actions/CloseAccount.ts b/src/libs/actions/CloseAccount.ts index 01b115a23518..a3a91ebb93e0 100644 --- a/src/libs/actions/CloseAccount.ts +++ b/src/libs/actions/CloseAccount.ts @@ -6,14 +6,14 @@ import ONYXKEYS from '@src/ONYXKEYS'; * Clear CloseAccount error message to hide modal */ function clearError() { - Onyx.merge(ONYXKEYS.FORMS.CLOSE_ACCOUNT_FORM, {errors: null}); + void Onyx.merge(ONYXKEYS.FORMS.CLOSE_ACCOUNT_FORM, {errors: null}); } /** * Set default Onyx data */ function setDefaultData() { - Onyx.merge(ONYXKEYS.FORMS.CLOSE_ACCOUNT_FORM, {...CONST.DEFAULT_CLOSE_ACCOUNT_DATA}); + void Onyx.merge(ONYXKEYS.FORMS.CLOSE_ACCOUNT_FORM, {...CONST.DEFAULT_CLOSE_ACCOUNT_DATA}); } export { diff --git a/src/libs/actions/CompanyCards.ts b/src/libs/actions/CompanyCards.ts index 6270b666a37e..e242008baf5e 100644 --- a/src/libs/actions/CompanyCards.ts +++ b/src/libs/actions/CompanyCards.ts @@ -37,23 +37,23 @@ type AddNewCompanyCardFlowData = { }; function setAssignCardStepAndData({data, isEditing, currentStep}: Partial) { - Onyx.merge(ONYXKEYS.ASSIGN_CARD, {data, isEditing, currentStep}); + void Onyx.merge(ONYXKEYS.ASSIGN_CARD, {data, isEditing, currentStep}); } function setTransactionStartDate(startDate: string) { - Onyx.merge(ONYXKEYS.ASSIGN_CARD, {startDate}); + void Onyx.merge(ONYXKEYS.ASSIGN_CARD, {startDate}); } function clearAssignCardStepAndData() { - Onyx.set(ONYXKEYS.ASSIGN_CARD, {}); + void Onyx.set(ONYXKEYS.ASSIGN_CARD, {}); } function setAddNewCompanyCardStepAndData({data, isEditing, step}: NullishDeep) { - Onyx.merge(ONYXKEYS.ADD_NEW_COMPANY_CARD, {data, isEditing, currentStep: step}); + void Onyx.merge(ONYXKEYS.ADD_NEW_COMPANY_CARD, {data, isEditing, currentStep: step}); } function clearAddNewCardFlow() { - Onyx.set(ONYXKEYS.ADD_NEW_COMPANY_CARD, { + void Onyx.set(ONYXKEYS.ADD_NEW_COMPANY_CARD, { currentStep: null, data: {}, }); @@ -148,7 +148,7 @@ function addNewCompanyCardsFeed( statementPeriodEndDay, }; - API.write(WRITE_COMMANDS.REQUEST_FEED_SETUP, parameters, {optimisticData, failureData, successData, finallyData}); + void API.write(WRITE_COMMANDS.REQUEST_FEED_SETUP, parameters, {optimisticData, failureData, successData, finallyData}); } function setWorkspaceCompanyCardFeedName(policyID: string, domainOrWorkspaceAccountID: number, bankName: string, userDefinedName: string) { @@ -177,7 +177,7 @@ function setWorkspaceCompanyCardFeedName(policyID: string, domainOrWorkspaceAcco userDefinedName, }; - API.write(WRITE_COMMANDS.SET_COMPANY_CARD_FEED_NAME, parameters, onyxData); + void API.write(WRITE_COMMANDS.SET_COMPANY_CARD_FEED_NAME, parameters, onyxData); } function setWorkspaceCompanyCardTransactionLiability(domainOrWorkspaceAccountID: number, policyID: string, bankName: CompanyCardFeed, liabilityType: string) { @@ -205,7 +205,7 @@ function setWorkspaceCompanyCardTransactionLiability(domainOrWorkspaceAccountID: liabilityType, }; - API.write(WRITE_COMMANDS.SET_COMPANY_CARD_TRANSACTION_LIABILITY, parameters, onyxData); + void API.write(WRITE_COMMANDS.SET_COMPANY_CARD_TRANSACTION_LIABILITY, parameters, onyxData); } function deleteWorkspaceCompanyCardFeed(policyID: string, domainOrWorkspaceAccountID: number, bankName: CompanyCardFeed, cardIDs: string[], feedToOpen?: CompanyCardFeed) { @@ -299,7 +299,7 @@ function deleteWorkspaceCompanyCardFeed(policyID: string, domainOrWorkspaceAccou bankName, }; - API.write(WRITE_COMMANDS.DELETE_COMPANY_CARD_FEED, parameters, {optimisticData, successData, failureData}); + void API.write(WRITE_COMMANDS.DELETE_COMPANY_CARD_FEED, parameters, {optimisticData, successData, failureData}); } function assignWorkspaceCompanyCard(policyID: string, data?: Partial) { @@ -370,7 +370,7 @@ function assignWorkspaceCompanyCard(policyID: string, data?: Partial(onyxKey: TKey, onyxValue: OnyxMergeInput) { - Onyx.set(onyxKey, onyxValue); + void Onyx.set(onyxKey, onyxValue); } function mergeDebugData(onyxKey: TKey, onyxValue: OnyxMergeInput) { - Onyx.merge(onyxKey, onyxValue); + void Onyx.merge(onyxKey, onyxValue); } export default { diff --git a/src/libs/actions/Delegate.ts b/src/libs/actions/Delegate.ts index 234c49580c71..004c78b4d78f 100644 --- a/src/libs/actions/Delegate.ts +++ b/src/libs/actions/Delegate.ts @@ -130,8 +130,8 @@ function connect({email, delegatedAccess, isFromOldDot = false}: ConnectParams) return; } - Onyx.set(ONYXKEYS.STASHED_CREDENTIALS, credentials); - Onyx.set(ONYXKEYS.STASHED_SESSION, session); + void Onyx.set(ONYXKEYS.STASHED_CREDENTIALS, credentials); + void Onyx.set(ONYXKEYS.STASHED_SESSION, session); const previousAccountID = getCurrentUserAccountID(); @@ -268,7 +268,7 @@ function disconnect() { // We need to access the authToken directly from the response to update the session // eslint-disable-next-line rulesdir/no-api-side-effects-method - API.makeRequestWithSideEffects(SIDE_EFFECT_REQUEST_COMMANDS.DISCONNECT_AS_DELEGATE, {}, {optimisticData, successData, failureData}) + void API.makeRequestWithSideEffects(SIDE_EFFECT_REQUEST_COMMANDS.DISCONNECT_AS_DELEGATE, {}, {optimisticData, successData, failureData}) .then((response) => { if (!response?.authToken || !response?.encryptedAuthToken) { Log.alert('[Delegate] No auth token returned while disconnecting as a delegate'); @@ -287,19 +287,19 @@ function disconnect() { return SequentialQueue.waitForIdle() .then(() => Onyx.clear(KEYS_TO_PRESERVE_DELEGATE_ACCESS)) .then(() => { - Onyx.set(ONYXKEYS.CREDENTIALS, { + void Onyx.set(ONYXKEYS.CREDENTIALS, { ...stashedCredentials, accountID: response.requesterID, }); - Onyx.set(ONYXKEYS.SESSION, { + void Onyx.set(ONYXKEYS.SESSION, { ...stashedSession, accountID: response.requesterID, email: requesterEmail, authToken, encryptedAuthToken: response.encryptedAuthToken, }); - Onyx.set(ONYXKEYS.STASHED_CREDENTIALS, {}); - Onyx.set(ONYXKEYS.STASHED_SESSION, {}); + void Onyx.set(ONYXKEYS.STASHED_CREDENTIALS, {}); + void Onyx.set(ONYXKEYS.STASHED_SESSION, {}); NetworkStore.setAuthToken(response?.authToken ?? null); @@ -326,11 +326,11 @@ function clearDelegatorErrors({delegatedAccess}: ClearDelegatorErrorsParams) { if (!delegatedAccess?.delegators) { return; } - Onyx.merge(ONYXKEYS.ACCOUNT, {delegatedAccess: {delegators: delegatedAccess.delegators.map((delegator) => ({...delegator, errorFields: undefined}))}}); + void Onyx.merge(ONYXKEYS.ACCOUNT, {delegatedAccess: {delegators: delegatedAccess.delegators.map((delegator) => ({...delegator, errorFields: undefined}))}}); } function requestValidationCode() { - API.write(WRITE_COMMANDS.RESEND_VALIDATE_CODE, null); + void API.write(WRITE_COMMANDS.RESEND_VALIDATE_CODE, null); } function addDelegate({email, role, validateCode, delegatedAccess}: AddDelegateParams) { @@ -484,7 +484,7 @@ function addDelegate({email, role, validateCode, delegatedAccess}: AddDelegatePa const parameters: APIAddDelegateParams = {delegateEmail: email, validateCode, role}; - API.write(WRITE_COMMANDS.ADD_DELEGATE, parameters, {optimisticData, successData, failureData}); + void API.write(WRITE_COMMANDS.ADD_DELEGATE, parameters, {optimisticData, successData, failureData}); } function removeDelegate({email, delegatedAccess}: RemoveDelegateParams) { @@ -556,7 +556,7 @@ function removeDelegate({email, delegatedAccess}: RemoveDelegateParams) { const parameters: APIRemoveDelegateParams = {delegateEmail: email}; - API.write(WRITE_COMMANDS.REMOVE_DELEGATE, parameters, {optimisticData, successData, failureData}); + void API.write(WRITE_COMMANDS.REMOVE_DELEGATE, parameters, {optimisticData, successData, failureData}); } function clearDelegateErrorsByField({email, fieldName, delegatedAccess}: ClearDelegateErrorsByFieldParams) { @@ -564,7 +564,7 @@ function clearDelegateErrorsByField({email, fieldName, delegatedAccess}: ClearDe return; } - Onyx.merge(ONYXKEYS.ACCOUNT, { + void Onyx.merge(ONYXKEYS.ACCOUNT, { delegatedAccess: { errorFields: { [fieldName]: { @@ -660,7 +660,7 @@ function updateDelegateRole({email, role, validateCode, delegatedAccess}: Update const parameters: APIUpdateDelegateRoleParams = {delegateEmail: email, validateCode, role}; - API.write(WRITE_COMMANDS.UPDATE_DELEGATE_ROLE, parameters, {optimisticData, successData, failureData}); + void API.write(WRITE_COMMANDS.UPDATE_DELEGATE_ROLE, parameters, {optimisticData, successData, failureData}); } function clearDelegateRolePendingAction({email, delegatedAccess}: ClearDelegateRolePendingActionParams) { @@ -692,7 +692,7 @@ function clearDelegateRolePendingAction({email, delegatedAccess}: ClearDelegateR } function restoreDelegateSession(authenticateResponse: Response) { - Onyx.clear(KEYS_TO_PRESERVE_DELEGATE_ACCESS).then(() => { + void Onyx.clear(KEYS_TO_PRESERVE_DELEGATE_ACCESS).then(() => { updateSessionAuthTokens(authenticateResponse?.authToken, authenticateResponse?.encryptedAuthToken); updateSessionUser(authenticateResponse?.accountID, authenticateResponse?.email); diff --git a/src/libs/actions/Device/index.ts b/src/libs/actions/Device/index.ts index cc972ecd70ec..f4693b973410 100644 --- a/src/libs/actions/Device/index.ts +++ b/src/libs/actions/Device/index.ts @@ -43,7 +43,7 @@ function setDeviceID() { .then(generateDeviceID) .then((uniqueID: string) => { Log.info('Got new deviceID', false, uniqueID); - Onyx.set(ONYXKEYS.DEVICE_ID, uniqueID); + void Onyx.set(ONYXKEYS.DEVICE_ID, uniqueID); }) .catch((error: Error) => Log.info('Found existing deviceID', false, error.message)); } diff --git a/src/libs/actions/Download.ts b/src/libs/actions/Download.ts index 26a19ee5b8a1..d1459ecea1dc 100644 --- a/src/libs/actions/Download.ts +++ b/src/libs/actions/Download.ts @@ -9,7 +9,7 @@ function setDownload(sourceID: string, isDownloading: boolean): Promise void) { - Onyx.multiSet({ + void Onyx.multiSet({ [ONYXKEYS.FORMS.EXIT_SURVEY_REASON_FORM]: null, [ONYXKEYS.FORMS.EXIT_SURVEY_REASON_FORM_DRAFT]: null, [ONYXKEYS.FORMS.EXIT_SURVEY_RESPONSE_FORM]: null, diff --git a/src/libs/actions/FormActions.ts b/src/libs/actions/FormActions.ts index 4caf85453ef2..d6f4c7672ec0 100644 --- a/src/libs/actions/FormActions.ts +++ b/src/libs/actions/FormActions.ts @@ -4,23 +4,23 @@ import type {OnyxFormDraftKey, OnyxFormKey} from '@src/ONYXKEYS'; import type * as OnyxCommon from '@src/types/onyx/OnyxCommon'; function setIsLoading(formID: OnyxFormKey, isLoading: boolean) { - Onyx.merge(formID, {isLoading}); + void Onyx.merge(formID, {isLoading}); } function setErrors(formID: OnyxFormKey, errors: OnyxCommon.Errors) { - Onyx.merge(formID, {errors}); + void Onyx.merge(formID, {errors}); } function setErrorFields(formID: OnyxFormKey, errorFields: OnyxCommon.ErrorFields) { - Onyx.merge(formID, {errorFields}); + void Onyx.merge(formID, {errorFields}); } function clearErrors(formID: OnyxFormKey) { - Onyx.merge(formID, {errors: null}); + void Onyx.merge(formID, {errors: null}); } function clearErrorFields(formID: OnyxFormKey) { - Onyx.merge(formID, {errorFields: null}); + void Onyx.merge(formID, {errorFields: null}); } function setDraftValues(formID: OnyxFormKey, draftValues: NullishDeep>): Promise { @@ -28,7 +28,7 @@ function setDraftValues(formID: OnyxFormKey, draftValues: NullishDeep { function closeReactNativeApp({shouldSetNVP}: {shouldSetNVP: boolean}) { Navigation.clearPreloadedRoutes(); if (CONFIG.IS_HYBRID_APP) { - Onyx.merge(ONYXKEYS.HYBRID_APP, {closingReactNativeApp: true}); + void Onyx.merge(ONYXKEYS.HYBRID_APP, {closingReactNativeApp: true}); } // eslint-disable-next-line no-restricted-properties HybridAppModule.closeReactNativeApp({shouldSetNVP}); @@ -41,7 +41,7 @@ function setReadyToShowAuthScreens(readyToShowAuthScreens: boolean) { if (!CONFIG.IS_HYBRID_APP) { return; } - Onyx.merge(ONYXKEYS.HYBRID_APP, {readyToShowAuthScreens}); + void Onyx.merge(ONYXKEYS.HYBRID_APP, {readyToShowAuthScreens}); } function setUseNewDotSignInPage(useNewDotSignInPage: boolean) { @@ -57,7 +57,7 @@ function setClosingReactNativeApp(closingReactNativeApp: boolean) { if (!CONFIG.IS_HYBRID_APP) { return; } - Onyx.merge(ONYXKEYS.HYBRID_APP, {closingReactNativeApp}); + void Onyx.merge(ONYXKEYS.HYBRID_APP, {closingReactNativeApp}); } /* @@ -99,7 +99,7 @@ function migrateHybridAppToNewPartnerName() { } Log.info('[HybridApp] Migrating to new partner name'); - Onyx.merge(ONYXKEYS.HYBRID_APP, { + void Onyx.merge(ONYXKEYS.HYBRID_APP, { shouldUseNewPartnerName: true, }); } diff --git a/src/libs/actions/IOU.ts b/src/libs/actions/IOU.ts index 8e6fe31c6a72..77eaf8c42bb9 100644 --- a/src/libs/actions/IOU.ts +++ b/src/libs/actions/IOU.ts @@ -806,8 +806,8 @@ Onyx.connect({ cleanUpSetQueries[`${ONYXKEYS.COLLECTION.REPORT_DRAFT_COMMENT}${reportID}`] = null; cleanUpSetQueries[`${ONYXKEYS.COLLECTION.REPORT_ACTIONS_DRAFTS}${reportID}`] = null; }); - Onyx.mergeCollection(ONYXKEYS.COLLECTION.REPORT, cleanUpMergeQueries); - Onyx.multiSet(cleanUpSetQueries); + void Onyx.mergeCollection(ONYXKEYS.COLLECTION.REPORT, cleanUpMergeQueries); + void Onyx.multiSet(cleanUpSetQueries); delete allPolicies[key]; return; } @@ -972,7 +972,7 @@ function initMoneyRequest({ // we should keep most of the existing data by using the ONYX MERGE operation if (currentIouRequestType === newIouRequestType) { // so, we just need to update the reportID, isFromGlobalCreate, created, currency - Onyx.merge(`${ONYXKEYS.COLLECTION.TRANSACTION_DRAFT}${newTransactionID}`, { + void Onyx.merge(`${ONYXKEYS.COLLECTION.TRANSACTION_DRAFT}${newTransactionID}`, { reportID, isFromGlobalCreate, created, @@ -1041,7 +1041,7 @@ function initMoneyRequest({ // Store the transaction in Onyx and mark it as not saved so it can be cleaned up later // Use set() here so that there is no way that data will be leaked between objects when it gets reset - Onyx.set(`${ONYXKEYS.COLLECTION.TRANSACTION_DRAFT}${newTransactionID}`, newTransaction); + void Onyx.set(`${ONYXKEYS.COLLECTION.TRANSACTION_DRAFT}${newTransactionID}`, newTransaction); return newTransaction; } @@ -1055,12 +1055,12 @@ function createDraftTransaction(transaction: OnyxTypes.Transaction) { ...transaction, }; - Onyx.set(`${ONYXKEYS.COLLECTION.TRANSACTION_DRAFT}${transaction.transactionID}`, newTransaction); + void Onyx.set(`${ONYXKEYS.COLLECTION.TRANSACTION_DRAFT}${transaction.transactionID}`, newTransaction); } function clearMoneyRequest(transactionID: string, skipConfirmation = false, draftTransactions?: OnyxCollection) { removeDraftTransactions(undefined, draftTransactions); - Onyx.set(`${ONYXKEYS.COLLECTION.SKIP_CONFIRMATION}${transactionID}`, skipConfirmation); + void Onyx.set(`${ONYXKEYS.COLLECTION.SKIP_CONFIRMATION}${transactionID}`, skipConfirmation); } function startMoneyRequest( @@ -1103,44 +1103,44 @@ function startDistanceRequest(iouType: ValueOf, reportID: } function setMoneyRequestAmount(transactionID: string, amount: number, currency: string, shouldShowOriginalAmount = false) { - Onyx.merge(`${ONYXKEYS.COLLECTION.TRANSACTION_DRAFT}${transactionID}`, {amount, currency, shouldShowOriginalAmount}); + void Onyx.merge(`${ONYXKEYS.COLLECTION.TRANSACTION_DRAFT}${transactionID}`, {amount, currency, shouldShowOriginalAmount}); } function setMoneyRequestCreated(transactionID: string, created: string, isDraft: boolean) { - Onyx.merge(`${isDraft ? ONYXKEYS.COLLECTION.TRANSACTION_DRAFT : ONYXKEYS.COLLECTION.TRANSACTION}${transactionID}`, {created}); + void Onyx.merge(`${isDraft ? ONYXKEYS.COLLECTION.TRANSACTION_DRAFT : ONYXKEYS.COLLECTION.TRANSACTION}${transactionID}`, {created}); } function setMoneyRequestDateAttribute(transactionID: string, start: string, end: string) { - Onyx.merge(`${ONYXKEYS.COLLECTION.TRANSACTION_DRAFT}${transactionID}`, {comment: {customUnit: {attributes: {dates: {start, end}}}}}); + void Onyx.merge(`${ONYXKEYS.COLLECTION.TRANSACTION_DRAFT}${transactionID}`, {comment: {customUnit: {attributes: {dates: {start, end}}}}}); } function setMoneyRequestCurrency(transactionID: string, currency: string, isEditing = false) { const fieldToUpdate = isEditing ? 'modifiedCurrency' : 'currency'; - Onyx.merge(`${ONYXKEYS.COLLECTION.TRANSACTION_DRAFT}${transactionID}`, {[fieldToUpdate]: currency}); + void Onyx.merge(`${ONYXKEYS.COLLECTION.TRANSACTION_DRAFT}${transactionID}`, {[fieldToUpdate]: currency}); } function setMoneyRequestDescription(transactionID: string, comment: string, isDraft: boolean) { - Onyx.merge(`${isDraft ? ONYXKEYS.COLLECTION.TRANSACTION_DRAFT : ONYXKEYS.COLLECTION.TRANSACTION}${transactionID}`, {comment: {comment: comment.trim()}}); + void Onyx.merge(`${isDraft ? ONYXKEYS.COLLECTION.TRANSACTION_DRAFT : ONYXKEYS.COLLECTION.TRANSACTION}${transactionID}`, {comment: {comment: comment.trim()}}); } function setMoneyRequestMerchant(transactionID: string, merchant: string, isDraft: boolean) { - Onyx.merge(`${isDraft ? ONYXKEYS.COLLECTION.TRANSACTION_DRAFT : ONYXKEYS.COLLECTION.TRANSACTION}${transactionID}`, {merchant}); + void Onyx.merge(`${isDraft ? ONYXKEYS.COLLECTION.TRANSACTION_DRAFT : ONYXKEYS.COLLECTION.TRANSACTION}${transactionID}`, {merchant}); } function setMoneyRequestAttendees(transactionID: string, attendees: Attendee[], isDraft: boolean) { - Onyx.merge(`${isDraft ? ONYXKEYS.COLLECTION.TRANSACTION_DRAFT : ONYXKEYS.COLLECTION.TRANSACTION}${transactionID}`, {comment: {attendees}}); + void Onyx.merge(`${isDraft ? ONYXKEYS.COLLECTION.TRANSACTION_DRAFT : ONYXKEYS.COLLECTION.TRANSACTION}${transactionID}`, {comment: {attendees}}); } function setMoneyRequestAccountant(transactionID: string, accountant: Accountant, isDraft: boolean) { - Onyx.merge(`${isDraft ? ONYXKEYS.COLLECTION.TRANSACTION_DRAFT : ONYXKEYS.COLLECTION.TRANSACTION}${transactionID}`, {accountant}); + void Onyx.merge(`${isDraft ? ONYXKEYS.COLLECTION.TRANSACTION_DRAFT : ONYXKEYS.COLLECTION.TRANSACTION}${transactionID}`, {accountant}); } function setMoneyRequestPendingFields(transactionID: string, pendingFields: OnyxTypes.Transaction['pendingFields']) { - Onyx.merge(`${ONYXKEYS.COLLECTION.TRANSACTION_DRAFT}${transactionID}`, {pendingFields}); + void Onyx.merge(`${ONYXKEYS.COLLECTION.TRANSACTION_DRAFT}${transactionID}`, {pendingFields}); } function setMoneyRequestCategory(transactionID: string, category: string, policyID?: string) { - Onyx.merge(`${ONYXKEYS.COLLECTION.TRANSACTION_DRAFT}${transactionID}`, {category}); + void Onyx.merge(`${ONYXKEYS.COLLECTION.TRANSACTION_DRAFT}${transactionID}`, {category}); if (!policyID) { setMoneyRequestTaxRate(transactionID, ''); setMoneyRequestTaxAmount(transactionID, null); @@ -1157,15 +1157,15 @@ function setMoneyRequestCategory(transactionID: string, category: string, policy } function setMoneyRequestTag(transactionID: string, tag: string) { - Onyx.merge(`${ONYXKEYS.COLLECTION.TRANSACTION_DRAFT}${transactionID}`, {tag}); + void Onyx.merge(`${ONYXKEYS.COLLECTION.TRANSACTION_DRAFT}${transactionID}`, {tag}); } function setMoneyRequestBillable(transactionID: string, billable: boolean) { - Onyx.merge(`${ONYXKEYS.COLLECTION.TRANSACTION_DRAFT}${transactionID}`, {billable}); + void Onyx.merge(`${ONYXKEYS.COLLECTION.TRANSACTION_DRAFT}${transactionID}`, {billable}); } function setMoneyRequestReimbursable(transactionID: string, reimbursable: boolean) { - Onyx.merge(`${ONYXKEYS.COLLECTION.TRANSACTION_DRAFT}${transactionID}`, {reimbursable}); + void Onyx.merge(`${ONYXKEYS.COLLECTION.TRANSACTION_DRAFT}${transactionID}`, {reimbursable}); } function setMoneyRequestParticipants(transactionID: string, participants: Participant[] = [], isTestTransaction = false) { @@ -1178,11 +1178,11 @@ function setMoneyRequestParticipants(transactionID: string, participants: Partic } function setSplitPayer(transactionID: string, payerAccountID: number) { - Onyx.merge(`${ONYXKEYS.COLLECTION.TRANSACTION_DRAFT}${transactionID}`, {splitPayerAccountIDs: [payerAccountID]}); + void Onyx.merge(`${ONYXKEYS.COLLECTION.TRANSACTION_DRAFT}${transactionID}`, {splitPayerAccountIDs: [payerAccountID]}); } function setMoneyRequestReceipt(transactionID: string, source: string, filename: string, isDraft: boolean, type?: string, isTestReceipt = false, isTestDriveReceipt = false) { - Onyx.merge(`${isDraft ? ONYXKEYS.COLLECTION.TRANSACTION_DRAFT : ONYXKEYS.COLLECTION.TRANSACTION}${transactionID}`, { + void Onyx.merge(`${isDraft ? ONYXKEYS.COLLECTION.TRANSACTION_DRAFT : ONYXKEYS.COLLECTION.TRANSACTION}${transactionID}`, { // isTestReceipt = false and isTestDriveReceipt = false are being converted to null because we don't really need to store it in Onyx in those cases receipt: {source, filename, type: type ?? '', isTestReceipt: isTestReceipt ? true : null, isTestDriveReceipt: isTestDriveReceipt ? true : null}, filename, @@ -1194,7 +1194,7 @@ function setMoneyRequestReceipt(transactionID: string, source: string, filename: */ function setCustomUnitRateID(transactionID: string, customUnitRateID: string | undefined) { const isFakeP2PRate = customUnitRateID === CONST.CUSTOM_UNITS.FAKE_P2P_ID; - Onyx.merge(`${ONYXKEYS.COLLECTION.TRANSACTION_DRAFT}${transactionID}`, { + void Onyx.merge(`${ONYXKEYS.COLLECTION.TRANSACTION_DRAFT}${transactionID}`, { comment: { customUnit: { customUnitRateID, @@ -1217,7 +1217,7 @@ function resetDraftTransactionsCustomUnit(transactionID: string | undefined) { return; } - Onyx.merge(`${ONYXKEYS.COLLECTION.TRANSACTION_DRAFT}${transactionID}`, { + void Onyx.merge(`${ONYXKEYS.COLLECTION.TRANSACTION_DRAFT}${transactionID}`, { comment: { customUnit: originalTransaction.comment?.customUnit ?? {}, }, @@ -1228,7 +1228,7 @@ function resetDraftTransactionsCustomUnit(transactionID: string | undefined) { * Set custom unit ID for the transaction draft */ function setCustomUnitID(transactionID: string, customUnitID: string) { - Onyx.merge(`${ONYXKEYS.COLLECTION.TRANSACTION_DRAFT}${transactionID}`, {comment: {customUnit: {customUnitID}}}); + void Onyx.merge(`${ONYXKEYS.COLLECTION.TRANSACTION_DRAFT}${transactionID}`, {comment: {customUnit: {customUnitID}}}); } function removeSubrate(transaction: OnyxEntry, currentIndex: string) { @@ -1258,7 +1258,7 @@ function removeSubrate(transaction: OnyxEntry, currentInd }, }; - Onyx.set(`${ONYXKEYS.COLLECTION.TRANSACTION_DRAFT}${transaction?.transactionID}`, newTransaction); + void Onyx.set(`${ONYXKEYS.COLLECTION.TRANSACTION_DRAFT}${transaction?.transactionID}`, newTransaction); } function updateSubrate(transaction: OnyxEntry, currentIndex: string, quantity: number, id: string, name: string, rate: number) { @@ -1292,11 +1292,11 @@ function updateSubrate(transaction: OnyxEntry, currentInd }, }; - Onyx.set(`${ONYXKEYS.COLLECTION.TRANSACTION_DRAFT}${transaction?.transactionID}`, newTransaction); + void Onyx.set(`${ONYXKEYS.COLLECTION.TRANSACTION_DRAFT}${transaction?.transactionID}`, newTransaction); } function clearSubrates(transactionID: string) { - Onyx.merge(`${ONYXKEYS.COLLECTION.TRANSACTION_DRAFT}${transactionID}`, {comment: {customUnit: {subRates: []}}}); + void Onyx.merge(`${ONYXKEYS.COLLECTION.TRANSACTION_DRAFT}${transactionID}`, {comment: {customUnit: {subRates: []}}}); } function addSubrate(transaction: OnyxEntry, currentIndex: string, quantity: number, id: string, name: string, rate: number) { @@ -1330,11 +1330,11 @@ function addSubrate(transaction: OnyxEntry, currentIndex: }, }; - Onyx.set(`${ONYXKEYS.COLLECTION.TRANSACTION_DRAFT}${transaction?.transactionID}`, newTransaction); + void Onyx.set(`${ONYXKEYS.COLLECTION.TRANSACTION_DRAFT}${transaction?.transactionID}`, newTransaction); } function setMoneyRequestDistance(transactionID: string, distanceAsFloat: number, isDraft: boolean) { - Onyx.merge(`${isDraft ? ONYXKEYS.COLLECTION.TRANSACTION_DRAFT : ONYXKEYS.COLLECTION.TRANSACTION}${transactionID}`, {comment: {customUnit: {quantity: distanceAsFloat}}}); + void Onyx.merge(`${isDraft ? ONYXKEYS.COLLECTION.TRANSACTION_DRAFT : ONYXKEYS.COLLECTION.TRANSACTION}${transactionID}`, {comment: {customUnit: {quantity: distanceAsFloat}}}); } /** @@ -1343,7 +1343,7 @@ function setMoneyRequestDistance(transactionID: string, distanceAsFloat: number, */ function setMoneyRequestDistanceRate(transactionID: string, customUnitRateID: string, policy: OnyxEntry, isDraft: boolean) { if (policy) { - Onyx.merge(ONYXKEYS.NVP_LAST_SELECTED_DISTANCE_RATES, {[policy.id]: customUnitRateID}); + void Onyx.merge(ONYXKEYS.NVP_LAST_SELECTED_DISTANCE_RATES, {[policy.id]: customUnitRateID}); } const distanceRate = DistanceRequestUtils.getRateByCustomUnitRateID({policy, customUnitRateID}); @@ -1352,7 +1352,7 @@ function setMoneyRequestDistanceRate(transactionID: string, customUnitRateID: st if (distanceRate?.unit && distanceRate?.unit !== transaction?.comment?.customUnit?.distanceUnit) { newDistance = DistanceRequestUtils.convertDistanceUnit(getDistanceInMeters(transaction, transaction?.comment?.customUnit?.distanceUnit), distanceRate.unit); } - Onyx.merge(`${isDraft ? ONYXKEYS.COLLECTION.TRANSACTION_DRAFT : ONYXKEYS.COLLECTION.TRANSACTION}${transactionID}`, { + void Onyx.merge(`${isDraft ? ONYXKEYS.COLLECTION.TRANSACTION_DRAFT : ONYXKEYS.COLLECTION.TRANSACTION}${transactionID}`, { comment: { customUnit: { customUnitRateID, @@ -4709,7 +4709,7 @@ function updateMoneyRequestDate( removeTransactionFromDuplicateTransactionViolation(data.onyxData, transactionID, transactions, transactionViolations); } const {params, onyxData} = data; - API.write(WRITE_COMMANDS.UPDATE_MONEY_REQUEST_DATE, params, onyxData); + void API.write(WRITE_COMMANDS.UPDATE_MONEY_REQUEST_DATE, params, onyxData); } /** Updates the billable field of an expense */ @@ -4728,7 +4728,7 @@ function updateMoneyRequestBillable( billable: value, }; const {params, onyxData} = getUpdateMoneyRequestParams(transactionID, transactionThreadReportID, transactionChanges, policy, policyTagList, policyCategories); - API.write(WRITE_COMMANDS.UPDATE_MONEY_REQUEST_BILLABLE, params, onyxData); + void API.write(WRITE_COMMANDS.UPDATE_MONEY_REQUEST_BILLABLE, params, onyxData); } function updateMoneyRequestReimbursable( @@ -4746,7 +4746,7 @@ function updateMoneyRequestReimbursable( reimbursable: value, }; const {params, onyxData} = getUpdateMoneyRequestParams(transactionID, transactionThreadReportID, transactionChanges, policy, policyTagList, policyCategories); - API.write(WRITE_COMMANDS.UPDATE_MONEY_REQUEST_REIMBURSABLE, params, onyxData); + void API.write(WRITE_COMMANDS.UPDATE_MONEY_REQUEST_REIMBURSABLE, params, onyxData); } /** Updates the merchant field of an expense */ @@ -4770,7 +4770,7 @@ function updateMoneyRequestMerchant( data = getUpdateMoneyRequestParams(transactionID, transactionThreadReportID, transactionChanges, policy, policyTagList, policyCategories); } const {params, onyxData} = data; - API.write(WRITE_COMMANDS.UPDATE_MONEY_REQUEST_MERCHANT, params, onyxData); + void API.write(WRITE_COMMANDS.UPDATE_MONEY_REQUEST_MERCHANT, params, onyxData); } /** Updates the attendees list of an expense */ @@ -4788,7 +4788,7 @@ function updateMoneyRequestAttendees( }; const data = getUpdateMoneyRequestParams(transactionID, transactionThreadReportID, transactionChanges, policy, policyTagList, policyCategories, violations); const {params, onyxData} = data; - API.write(WRITE_COMMANDS.UPDATE_MONEY_REQUEST_ATTENDEES, params, onyxData); + void API.write(WRITE_COMMANDS.UPDATE_MONEY_REQUEST_ATTENDEES, params, onyxData); } /** Updates the tag of an expense */ @@ -4805,7 +4805,7 @@ function updateMoneyRequestTag( tag, }; const {params, onyxData} = getUpdateMoneyRequestParams(transactionID, transactionThreadReportID, transactionChanges, policy, policyTagList, policyCategories, undefined, hash); - API.write(WRITE_COMMANDS.UPDATE_MONEY_REQUEST_TAG, params, onyxData); + void API.write(WRITE_COMMANDS.UPDATE_MONEY_REQUEST_TAG, params, onyxData); } /** Updates the created tax amount of an expense */ @@ -4821,7 +4821,7 @@ function updateMoneyRequestTaxAmount( taxAmount, }; const {params, onyxData} = getUpdateMoneyRequestParams(transactionID, optimisticReportActionID, transactionChanges, policy, policyTagList, policyCategories); - API.write(WRITE_COMMANDS.UPDATE_MONEY_REQUEST_TAX_AMOUNT, params, onyxData); + void API.write(WRITE_COMMANDS.UPDATE_MONEY_REQUEST_TAX_AMOUNT, params, onyxData); } type UpdateMoneyRequestTaxRateParams = { @@ -4842,7 +4842,7 @@ function updateMoneyRequestTaxRate({transactionID, optimisticReportActionID, tax }; const {params, onyxData} = getUpdateMoneyRequestParams(transactionID, optimisticReportActionID, transactionChanges, policy, policyTagList, policyCategories); - API.write(WRITE_COMMANDS.UPDATE_MONEY_REQUEST_TAX_RATE, params, onyxData); + void API.write(WRITE_COMMANDS.UPDATE_MONEY_REQUEST_TAX_RATE, params, onyxData); } type UpdateMoneyRequestDistanceParams = { @@ -4926,7 +4926,7 @@ function updateMoneyRequestDistance({ }); } - API.write(WRITE_COMMANDS.UPDATE_MONEY_REQUEST_DISTANCE, params, onyxData); + void API.write(WRITE_COMMANDS.UPDATE_MONEY_REQUEST_DISTANCE, params, onyxData); } /** Updates the category of an expense */ @@ -4944,7 +4944,7 @@ function updateMoneyRequestCategory( }; const {params, onyxData} = getUpdateMoneyRequestParams(transactionID, transactionThreadReportID, transactionChanges, policy, policyTagList, policyCategories, undefined, hash); - API.write(WRITE_COMMANDS.UPDATE_MONEY_REQUEST_CATEGORY, params, onyxData); + void API.write(WRITE_COMMANDS.UPDATE_MONEY_REQUEST_CATEGORY, params, onyxData); } /** Updates the description of an expense */ @@ -4970,7 +4970,7 @@ function updateMoneyRequestDescription( } const {params, onyxData} = data; params.description = parsedComment; - API.write(WRITE_COMMANDS.UPDATE_MONEY_REQUEST_DESCRIPTION, params, onyxData); + void API.write(WRITE_COMMANDS.UPDATE_MONEY_REQUEST_DESCRIPTION, params, onyxData); } /** Updates the distance rate of an expense */ @@ -5012,7 +5012,7 @@ function updateMoneyRequestDistanceRate( const {params, onyxData} = data; // `taxAmount` & `taxCode` only needs to be updated in the optimistic data, so we need to remove them from the params const {taxAmount, taxCode, ...paramsWithoutTaxUpdated} = params; - API.write(WRITE_COMMANDS.UPDATE_MONEY_REQUEST_DISTANCE_RATE, paramsWithoutTaxUpdated, onyxData); + void API.write(WRITE_COMMANDS.UPDATE_MONEY_REQUEST_DISTANCE_RATE, paramsWithoutTaxUpdated, onyxData); } const getConvertTrackedExpenseInformation = ( @@ -5135,7 +5135,7 @@ type ConvertTrackedExpenseToRequestParams = { }; function addTrackedExpenseToPolicy(parameters: AddTrackedExpenseToPolicyParam, onyxData: OnyxData) { - API.write(WRITE_COMMANDS.ADD_TRACKED_EXPENSE_TO_POLICY, parameters, onyxData); + void API.write(WRITE_COMMANDS.ADD_TRACKED_EXPENSE_TO_POLICY, parameters, onyxData); } function convertTrackedExpenseToRequest(convertTrackedExpenseParams: ConvertTrackedExpenseToRequestParams) { @@ -5215,7 +5215,7 @@ function convertTrackedExpenseToRequest(convertTrackedExpenseParams: ConvertTrac modifiedExpenseReportActionID, reportPreviewReportActionID: chatParams.reportPreviewReportActionID, }; - API.write(WRITE_COMMANDS.CONVERT_TRACKED_EXPENSE_TO_REQUEST, parameters, {optimisticData, successData, failureData}); + void API.write(WRITE_COMMANDS.CONVERT_TRACKED_EXPENSE_TO_REQUEST, parameters, {optimisticData, successData, failureData}); } /** @@ -5418,7 +5418,7 @@ function categorizeTrackedExpense(trackedExpenseParams: TrackedExpenseParams) { attendees: transactionParams.attendees ? JSON.stringify(transactionParams.attendees) : undefined, }; - API.write(WRITE_COMMANDS.CATEGORIZE_TRACKED_EXPENSE, parameters, {optimisticData, successData, failureData}); + void API.write(WRITE_COMMANDS.CATEGORIZE_TRACKED_EXPENSE, parameters, {optimisticData, successData, failureData}); // If a draft policy was used, then the CategorizeTrackedExpense command will create a real one // so let's track that conversion here @@ -5524,7 +5524,7 @@ function shareTrackedExpense(trackedExpenseParams: TrackedExpenseParams) { accountantEmail, }; - API.write(WRITE_COMMANDS.SHARE_TRACKED_EXPENSE, parameters, {optimisticData, successData, failureData}); + void API.write(WRITE_COMMANDS.SHARE_TRACKED_EXPENSE, parameters, {optimisticData, successData, failureData}); } /** @@ -5634,7 +5634,7 @@ function requestMoney(requestMoneyInformation: RequestMoneyInformation) { const activeReportID = isMoneyRequestReport ? report?.reportID : chatReport.reportID; if (shouldPlaySound) { - playSound(SOUNDS.DONE); + void playSound(SOUNDS.DONE); } switch (action) { @@ -5735,12 +5735,12 @@ function requestMoney(requestMoneyInformation: RequestMoneyInformation) { testDriveCommentReportActionID, }; // eslint-disable-next-line rulesdir/no-multiple-api-calls - API.write(WRITE_COMMANDS.REQUEST_MONEY, parameters, onyxData); + void API.write(WRITE_COMMANDS.REQUEST_MONEY, parameters, onyxData); } } if (shouldHandleNavigation) { - InteractionManager.runAfterInteractions(() => removeDraftTransactions()); + void InteractionManager.runAfterInteractions(() => removeDraftTransactions()); if (!requestMoneyInformation.isRetry) { dismissModalAndOpenReportInInboxTab(backToReport ?? activeReportID); } @@ -5841,10 +5841,10 @@ function submitPerDiemExpense(submitPerDiemExpenseInformation: PerDiemExpenseInf attendees: attendees ? JSON.stringify(attendees) : undefined, }; - playSound(SOUNDS.DONE); - API.write(WRITE_COMMANDS.CREATE_PER_DIEM_REQUEST, parameters, onyxData); + void playSound(SOUNDS.DONE); + void API.write(WRITE_COMMANDS.CREATE_PER_DIEM_REQUEST, parameters, onyxData); - InteractionManager.runAfterInteractions(() => removeDraftTransaction(CONST.IOU.OPTIMISTIC_TRANSACTION_ID)); + void InteractionManager.runAfterInteractions(() => removeDraftTransaction(CONST.IOU.OPTIMISTIC_TRANSACTION_ID)); dismissModalAndOpenReportInInboxTab(activeReportID); if (activeReportID) { @@ -5919,9 +5919,9 @@ function sendInvoice( ...(invoiceChatReport?.reportID ? {receiverInvoiceRoomID: invoiceChatReport.reportID} : {receiverEmail: receiver.login ?? ''}), }; - playSound(SOUNDS.DONE); - API.write(WRITE_COMMANDS.SEND_INVOICE, parameters, onyxData); - InteractionManager.runAfterInteractions(() => removeDraftTransaction(CONST.IOU.OPTIMISTIC_TRANSACTION_ID)); + void playSound(SOUNDS.DONE); + void API.write(WRITE_COMMANDS.SEND_INVOICE, parameters, onyxData); + void InteractionManager.runAfterInteractions(() => removeDraftTransaction(CONST.IOU.OPTIMISTIC_TRANSACTION_ID)); if (isSearchTopmostFullScreenRoute()) { Navigation.dismissModal(); @@ -6082,7 +6082,7 @@ function trackExpense(params: CreateTrackExpenseParams) { const mileageRate = isCustomUnitRateIDForP2P(transaction) ? undefined : customUnitRateID; if (shouldPlaySound) { - playSound(SOUNDS.DONE); + void playSound(SOUNDS.DONE); } switch (action) { @@ -6216,12 +6216,12 @@ function trackExpense(params: CreateTrackExpenseParams) { if (actionableWhisperReportActionIDParam) { parameters.actionableWhisperReportActionID = actionableWhisperReportActionIDParam; } - API.write(WRITE_COMMANDS.TRACK_EXPENSE, parameters, onyxData); + void API.write(WRITE_COMMANDS.TRACK_EXPENSE, parameters, onyxData); } } if (shouldHandleNavigation) { - InteractionManager.runAfterInteractions(() => removeDraftTransactions()); + void InteractionManager.runAfterInteractions(() => removeDraftTransactions()); if (!params.isRetry) { dismissModalAndOpenReportInInboxTab(activeReportID); @@ -6829,9 +6829,9 @@ function splitBill({ description: parsedComment, }; - playSound(SOUNDS.DONE); - API.write(WRITE_COMMANDS.SPLIT_BILL, parameters, onyxData); - InteractionManager.runAfterInteractions(() => removeDraftTransaction(CONST.IOU.OPTIMISTIC_TRANSACTION_ID)); + void playSound(SOUNDS.DONE); + void API.write(WRITE_COMMANDS.SPLIT_BILL, parameters, onyxData); + void InteractionManager.runAfterInteractions(() => removeDraftTransaction(CONST.IOU.OPTIMISTIC_TRANSACTION_ID)); dismissModalAndOpenReportInInboxTab(existingSplitChatReportID); @@ -6907,9 +6907,9 @@ function splitBillAndOpenReport({ description: parsedComment, }; - playSound(SOUNDS.DONE); - API.write(WRITE_COMMANDS.SPLIT_BILL_AND_OPEN_REPORT, parameters, onyxData); - InteractionManager.runAfterInteractions(() => removeDraftTransaction(CONST.IOU.OPTIMISTIC_TRANSACTION_ID)); + void playSound(SOUNDS.DONE); + void API.write(WRITE_COMMANDS.SPLIT_BILL_AND_OPEN_REPORT, parameters, onyxData); + void InteractionManager.runAfterInteractions(() => removeDraftTransaction(CONST.IOU.OPTIMISTIC_TRANSACTION_ID)); dismissModalAndOpenReportInInboxTab(splitData.chatReportID); notifyNewAction(splitData.chatReportID, currentUserAccountID); @@ -7251,10 +7251,10 @@ function startSplitBill({ description: parsedComment, }; if (shouldPlaySound) { - playSound(SOUNDS.DONE); + void playSound(SOUNDS.DONE); } - API.write(WRITE_COMMANDS.START_SPLIT_BILL, parameters, {optimisticData, successData, failureData}); + void API.write(WRITE_COMMANDS.START_SPLIT_BILL, parameters, {optimisticData, successData, failureData}); Navigation.dismissModalWithReport({reportID: splitChatReport.reportID}); notifyNewAction(splitChatReport.reportID, currentUserAccountID); @@ -7523,9 +7523,9 @@ function completeSplitBill( description: parsedComment, }; - playSound(SOUNDS.DONE); - API.write(WRITE_COMMANDS.COMPLETE_SPLIT_BILL, parameters, {optimisticData, successData, failureData}); - InteractionManager.runAfterInteractions(() => removeDraftTransaction(CONST.IOU.OPTIMISTIC_TRANSACTION_ID)); + void playSound(SOUNDS.DONE); + void API.write(WRITE_COMMANDS.COMPLETE_SPLIT_BILL, parameters, {optimisticData, successData, failureData}); + void InteractionManager.runAfterInteractions(() => removeDraftTransaction(CONST.IOU.OPTIMISTIC_TRANSACTION_ID)); dismissModalAndOpenReportInInboxTab(chatReportID); notifyNewAction(chatReportID, sessionAccountID); } @@ -7550,7 +7550,7 @@ function setDraftSplitTransaction(transactionID: string | undefined, transaction }) : null; - Onyx.merge(`${ONYXKEYS.COLLECTION.SPLIT_TRANSACTION_DRAFT}${transactionID}`, updatedTransaction); + void Onyx.merge(`${ONYXKEYS.COLLECTION.SPLIT_TRANSACTION_DRAFT}${transactionID}`, updatedTransaction); } /** Requests money based on a distance (e.g. mileage from a map) */ @@ -7742,10 +7742,10 @@ function createDistanceRequest(distanceRequestInformation: CreateDistanceRequest value: recentServerValidatedWaypoints, }); - playSound(SOUNDS.DONE); + void playSound(SOUNDS.DONE); - API.write(WRITE_COMMANDS.CREATE_DISTANCE_REQUEST, parameters, onyxData); - InteractionManager.runAfterInteractions(() => removeDraftTransaction(CONST.IOU.OPTIMISTIC_TRANSACTION_ID)); + void API.write(WRITE_COMMANDS.CREATE_DISTANCE_REQUEST, parameters, onyxData); + void InteractionManager.runAfterInteractions(() => removeDraftTransaction(CONST.IOU.OPTIMISTIC_TRANSACTION_ID)); const activeReportID = isMoneyRequestReport && report?.reportID ? report.reportID : parameters.chatReportID; dismissModalAndOpenReportInInboxTab(backToReport ?? activeReportID); @@ -7798,7 +7798,7 @@ function updateMoneyRequestAmountAndCurrency({ removeTransactionFromDuplicateTransactionViolation(data.onyxData, transactionID, transactions, transactionViolations); } const {params, onyxData} = data; - API.write(WRITE_COMMANDS.UPDATE_MONEY_REQUEST_AMOUNT_AND_CURRENCY, params, onyxData); + void API.write(WRITE_COMMANDS.UPDATE_MONEY_REQUEST_AMOUNT_AND_CURRENCY, params, onyxData); } /** @@ -8154,7 +8154,7 @@ function cleanUpMoneyRequest(transactionID: string, reportAction: OnyxTypes.Repo // First, update the reportActions to ensure related actions are not displayed. Onyx.update(reportActionsOnyxUpdates).then(() => { Navigation.goBack(urlToNavigateBack); - InteractionManager.runAfterInteractions(() => { + void InteractionManager.runAfterInteractions(() => { // After navigation, update the remaining data. Onyx.update(onyxUpdates); }); @@ -8460,7 +8460,7 @@ function deleteMoneyRequest( }; // STEP 3: Make the API request - API.write(WRITE_COMMANDS.DELETE_MONEY_REQUEST, parameters, {optimisticData, successData, failureData}); + void API.write(WRITE_COMMANDS.DELETE_MONEY_REQUEST, parameters, {optimisticData, successData, failureData}); clearPdfByOnyxKey(transactionID); return urlToNavigateBack; @@ -8501,7 +8501,7 @@ function deleteTrackExpense( ); // STEP 6: Make the API request - API.write(WRITE_COMMANDS.DELETE_MONEY_REQUEST, parameters, {optimisticData, successData, failureData}); + void API.write(WRITE_COMMANDS.DELETE_MONEY_REQUEST, parameters, {optimisticData, successData, failureData}); clearPdfByOnyxKey(transactionID); // STEP 7: Navigate the user depending on which page they are on and which resources were deleted @@ -9468,8 +9468,8 @@ function getPayMoneyRequestParams( */ function sendMoneyElsewhere(report: OnyxEntry, amount: number, currency: string, comment: string, managerID: number, recipient: Participant) { const {params, optimisticData, successData, failureData} = getSendMoneyParams(report, amount, currency, comment, CONST.IOU.PAYMENT_TYPE.ELSEWHERE, managerID, recipient); - playSound(SOUNDS.DONE); - API.write(WRITE_COMMANDS.SEND_MONEY_ELSEWHERE, params, {optimisticData, successData, failureData}); + void playSound(SOUNDS.DONE); + void API.write(WRITE_COMMANDS.SEND_MONEY_ELSEWHERE, params, {optimisticData, successData, failureData}); dismissModalAndOpenReportInInboxTab(params.chatReportID); notifyNewAction(params.chatReportID, managerID); @@ -9481,8 +9481,8 @@ function sendMoneyElsewhere(report: OnyxEntry, amount: number, */ function sendMoneyWithWallet(report: OnyxEntry, amount: number, currency: string, comment: string, managerID: number, recipient: Participant | OptionData) { const {params, optimisticData, successData, failureData} = getSendMoneyParams(report, amount, currency, comment, CONST.IOU.PAYMENT_TYPE.EXPENSIFY, managerID, recipient); - playSound(SOUNDS.DONE); - API.write(WRITE_COMMANDS.SEND_MONEY_WITH_WALLET, params, {optimisticData, successData, failureData}); + void playSound(SOUNDS.DONE); + void API.write(WRITE_COMMANDS.SEND_MONEY_WITH_WALLET, params, {optimisticData, successData, failureData}); dismissModalAndOpenReportInInboxTab(params.chatReportID); notifyNewAction(params.chatReportID, managerID); @@ -9854,8 +9854,8 @@ function approveMoneyRequest(expenseReport: OnyxEntry, full?: optimisticHoldReportExpenseActionIDs, }; - playSound(SOUNDS.SUCCESS); - API.write(WRITE_COMMANDS.APPROVE_MONEY_REQUEST, parameters, {optimisticData, successData, failureData}); + void playSound(SOUNDS.SUCCESS); + void API.write(WRITE_COMMANDS.APPROVE_MONEY_REQUEST, parameters, {optimisticData, successData, failureData}); } function reopenReport(expenseReport: OnyxEntry) { @@ -9979,7 +9979,7 @@ function reopenReport(expenseReport: OnyxEntry) { reportActionID: optimisticReopenedReportAction.reportActionID, }; - API.write(WRITE_COMMANDS.REOPEN_REPORT, parameters, {optimisticData, successData, failureData}); + void API.write(WRITE_COMMANDS.REOPEN_REPORT, parameters, {optimisticData, successData, failureData}); } function retractReport(expenseReport: OnyxEntry) { @@ -10103,7 +10103,7 @@ function retractReport(expenseReport: OnyxEntry) { reportActionID: optimisticRetractReportAction.reportActionID, }; - API.write(WRITE_COMMANDS.RETRACT_REPORT, parameters, {optimisticData, successData, failureData}); + void API.write(WRITE_COMMANDS.RETRACT_REPORT, parameters, {optimisticData, successData, failureData}); } function unapproveExpenseReport(expenseReport: OnyxEntry) { @@ -10227,7 +10227,7 @@ function unapproveExpenseReport(expenseReport: OnyxEntry) { reportActionID: optimisticUnapprovedReportAction.reportActionID, }; - API.write(WRITE_COMMANDS.UNAPPROVE_EXPENSE_REPORT, parameters, {optimisticData, successData, failureData}); + void API.write(WRITE_COMMANDS.UNAPPROVE_EXPENSE_REPORT, parameters, {optimisticData, successData, failureData}); } function submitReport(expenseReport?: OnyxTypes.Report) { @@ -10365,7 +10365,7 @@ function submitReport(expenseReport?: OnyxTypes.Report) { reportActionID: optimisticSubmittedReportAction.reportActionID, }; - API.write(WRITE_COMMANDS.SUBMIT_REPORT, parameters, {optimisticData, successData, failureData}); + void API.write(WRITE_COMMANDS.SUBMIT_REPORT, parameters, {optimisticData, successData, failureData}); } function cancelPayment(expenseReport: OnyxEntry, chatReport: OnyxTypes.Report) { @@ -10510,7 +10510,7 @@ function cancelPayment(expenseReport: OnyxEntry, chatReport: O value: buildNextStep(expenseReport, CONST.REPORT.STATUS_NUM.REIMBURSED), }); - API.write( + void API.write( WRITE_COMMANDS.CANCEL_PAYMENT, { iouReportID: expenseReport.reportID, @@ -10578,8 +10578,8 @@ function payMoneyRequest(paymentType: PaymentMethodType, chatReport: OnyxTypes.R // Expensify Wallets. const apiCommand = paymentType === CONST.IOU.PAYMENT_TYPE.EXPENSIFY ? WRITE_COMMANDS.PAY_MONEY_REQUEST_WITH_WALLET : WRITE_COMMANDS.PAY_MONEY_REQUEST; - playSound(SOUNDS.SUCCESS); - API.write(apiCommand, params, {optimisticData, successData, failureData}); + void playSound(SOUNDS.SUCCESS); + void API.write(apiCommand, params, {optimisticData, successData, failureData}); notifyNewAction(Navigation.getTopmostReportId() ?? iouReport?.reportID, userAccountID); } @@ -10644,8 +10644,8 @@ function payInvoice( }; } - playSound(SOUNDS.SUCCESS); - API.write(WRITE_COMMANDS.PAY_INVOICE, params, {optimisticData, successData, failureData}); + void playSound(SOUNDS.SUCCESS); + void API.write(WRITE_COMMANDS.PAY_INVOICE, params, {optimisticData, successData, failureData}); } function detachReceipt(transactionID: string | undefined) { @@ -10767,7 +10767,7 @@ function detachReceipt(transactionID: string | undefined) { const parameters: DetachReceiptParams = {transactionID, reportActionID: updatedReportAction.reportActionID}; - API.write(WRITE_COMMANDS.DETACH_RECEIPT, parameters, {optimisticData, successData, failureData}); + void API.write(WRITE_COMMANDS.DETACH_RECEIPT, parameters, {optimisticData, successData, failureData}); } function replaceReceipt({transactionID, file, source}: ReplaceReceipt) { @@ -10883,7 +10883,7 @@ function replaceReceipt({transactionID, file, source}: ReplaceReceipt) { receipt: file, }; - API.write(WRITE_COMMANDS.REPLACE_RECEIPT, parameters, {optimisticData, successData, failureData}); + void API.write(WRITE_COMMANDS.REPLACE_RECEIPT, parameters, {optimisticData, successData, failureData}); } /** @@ -10934,11 +10934,11 @@ function setMoneyRequestParticipantsFromReport(transactionID: string, report: On } function setMoneyRequestTaxRate(transactionID: string, taxCode: string | null) { - Onyx.merge(`${ONYXKEYS.COLLECTION.TRANSACTION_DRAFT}${transactionID}`, {taxCode}); + void Onyx.merge(`${ONYXKEYS.COLLECTION.TRANSACTION_DRAFT}${transactionID}`, {taxCode}); } function setMoneyRequestTaxAmount(transactionID: string, taxAmount: number | null) { - Onyx.merge(`${ONYXKEYS.COLLECTION.TRANSACTION_DRAFT}${transactionID}`, {taxAmount}); + void Onyx.merge(`${ONYXKEYS.COLLECTION.TRANSACTION_DRAFT}${transactionID}`, {taxAmount}); } /** @@ -10975,7 +10975,7 @@ function setSplitShares(transaction: OnyxEntry, amount: n return acc; }, {}); - Onyx.merge(`${ONYXKEYS.COLLECTION.TRANSACTION_DRAFT}${transaction.transactionID}`, {splitShares}); + void Onyx.merge(`${ONYXKEYS.COLLECTION.TRANSACTION_DRAFT}${transaction.transactionID}`, {splitShares}); } function resetSplitShares(transaction: OnyxEntry, newAmount?: number, currency?: string) { @@ -10993,7 +10993,7 @@ function resetSplitShares(transaction: OnyxEntry, newAmou * Sets an individual split share of the participant accountID supplied */ function setIndividualShare(transactionID: string, participantAccountID: number, participantShare: number) { - Onyx.merge(`${ONYXKEYS.COLLECTION.TRANSACTION_DRAFT}${transactionID}`, { + void Onyx.merge(`${ONYXKEYS.COLLECTION.TRANSACTION_DRAFT}${transactionID}`, { splitShares: { [participantAccountID]: {amount: participantShare, isModified: true}, }, @@ -11032,7 +11032,7 @@ function adjustRemainingSplitShares(transaction: NonNullable notifyNewAction(currentReportID, userAccountID)); @@ -11385,7 +11385,7 @@ function unholdRequest(transactionID: string, reportID: string) { }, ]; - API.write( + void API.write( WRITE_COMMANDS.UNHOLD_MONEY_REQUEST, { transactionID, @@ -11455,7 +11455,7 @@ function savePreferredPaymentMethod( } // to make it easier to revert to the previous last payment method, we will save it to this key - Onyx.merge(`${ONYXKEYS.NVP_LAST_PAYMENT_METHOD}`, { + void Onyx.merge(`${ONYXKEYS.NVP_LAST_PAYMENT_METHOD}`, { [policyID]: type ? { [type]: {name: paymentMethod}, @@ -11717,11 +11717,11 @@ function mergeDuplicates({transactionThreadReportID: optimisticTransactionThread }); } - API.write(WRITE_COMMANDS.MERGE_DUPLICATES, {...allParams, reportActionID: optimisticReportAction.reportActionID}, {optimisticData, failureData, successData}); + void API.write(WRITE_COMMANDS.MERGE_DUPLICATES, {...allParams, reportActionID: optimisticReportAction.reportActionID}, {optimisticData, failureData, successData}); } function updateLastLocationPermissionPrompt() { - Onyx.set(ONYXKEYS.NVP_LAST_LOCATION_PERMISSION_PROMPT, new Date().toISOString()); + void Onyx.set(ONYXKEYS.NVP_LAST_LOCATION_PERMISSION_PROMPT, new Date().toISOString()); } function setMultipleMoneyRequestParticipantsFromReport(transactionIDs: string[], reportValue: OnyxEntry) { @@ -11880,7 +11880,7 @@ function resolveDuplicates(params: MergeDuplicatesParams) { dismissedViolationReportActionID: optimisticReportAction.reportActionID, }; - API.write(WRITE_COMMANDS.RESOLVE_DUPLICATES, parameters, {optimisticData, failureData}); + void API.write(WRITE_COMMANDS.RESOLVE_DUPLICATES, parameters, {optimisticData, failureData}); } const expenseReportStatusFilterMapping = { @@ -12033,7 +12033,7 @@ function dismissRejectUseExplanation() { }, ]; - API.write(WRITE_COMMANDS.SET_NAME_VALUE_PAIR, parameters, { + void API.write(WRITE_COMMANDS.SET_NAME_VALUE_PAIR, parameters, { optimisticData, }); } @@ -12481,7 +12481,7 @@ function rejectMoneyRequest(transactionID: string, reportID: string, comment: st }; // Make API call - API.write(WRITE_COMMANDS.REJECT_MONEY_REQUEST, parameters, {optimisticData, successData, failureData}); + void API.write(WRITE_COMMANDS.REJECT_MONEY_REQUEST, parameters, {optimisticData, successData, failureData}); return urlToNavigateBack as Route; } @@ -12545,7 +12545,7 @@ function markRejectViolationAsResolved(transactionID: string, reportID?: string) }; // Make API call - API.write(WRITE_COMMANDS.MARK_TRANSACTION_VIOLATION_AS_RESOLVED, parameters, { + void API.write(WRITE_COMMANDS.MARK_TRANSACTION_VIOLATION_AS_RESOLVED, parameters, { optimisticData, successData, failureData, @@ -12600,7 +12600,7 @@ function initSplitExpense(transaction: OnyxEntry, isOpenC }, }); - Onyx.set(`${ONYXKEYS.COLLECTION.SPLIT_TRANSACTION_DRAFT}${originalTransactionID}`, draftTransaction); + void Onyx.set(`${ONYXKEYS.COLLECTION.SPLIT_TRANSACTION_DRAFT}${originalTransactionID}`, draftTransaction); Navigation.navigate( ROUTES.SPLIT_EXPENSE.getRoute( @@ -12648,7 +12648,7 @@ function initSplitExpense(transaction: OnyxEntry, isOpenC }, }); - Onyx.set(`${ONYXKEYS.COLLECTION.SPLIT_TRANSACTION_DRAFT}${transaction?.transactionID}`, draftTransaction); + void Onyx.set(`${ONYXKEYS.COLLECTION.SPLIT_TRANSACTION_DRAFT}${transaction?.transactionID}`, draftTransaction); Navigation.navigate(ROUTES.SPLIT_EXPENSE.getRoute(reportID ?? String(CONST.DEFAULT_NUMBER_ID), transaction.transactionID, undefined, Navigation.getActiveRoute())); } @@ -12683,7 +12683,7 @@ function initDraftSplitExpenseDataForEdit(draftTransaction: OnyxEntry, dra const transactionDetails = getTransactionDetails(transaction); - Onyx.merge(`${ONYXKEYS.COLLECTION.SPLIT_TRANSACTION_DRAFT}${transaction.transactionID}`, { + void Onyx.merge(`${ONYXKEYS.COLLECTION.SPLIT_TRANSACTION_DRAFT}${transaction.transactionID}`, { comment: { splitExpenses: [ ...(draftTransaction.comment?.splitExpenses ?? []), @@ -12724,7 +12724,7 @@ function removeSplitExpenseField(draftTransaction: OnyxEntry item.transactionID !== splitExpenseTransactionID); - Onyx.merge(`${ONYXKEYS.COLLECTION.SPLIT_TRANSACTION_DRAFT}${originalTransactionID}`, { + void Onyx.merge(`${ONYXKEYS.COLLECTION.SPLIT_TRANSACTION_DRAFT}${originalTransactionID}`, { comment: { splitExpenses, }, @@ -12755,7 +12755,7 @@ function updateSplitExpenseField(splitExpenseDraftTransaction: OnyxEntry removeDraftSplitTransaction(originalTransactionID)); + void API.write(WRITE_COMMANDS.SPLIT_TRANSACTION, parameters, {optimisticData, successData, failureData}); + void InteractionManager.runAfterInteractions(() => removeDraftSplitTransaction(originalTransactionID)); const isSearchPageTopmostFullScreenRoute = isSearchTopmostFullScreenRoute(); const transactionThreadReportID = iouActions.at(0)?.childReportID; @@ -13091,7 +13091,7 @@ function assignReportToMe(report: OnyxTypes.Report, accountID: number) { reportActionID: takeControlReportAction.reportActionID, }; - API.write(WRITE_COMMANDS.ASSIGN_REPORT_TO_ME, params, onyxData); + void API.write(WRITE_COMMANDS.ASSIGN_REPORT_TO_ME, params, onyxData); } function addReportApprover(report: OnyxTypes.Report, newApproverEmail: string, newApproverAccountID: number, accountID: number) { @@ -13154,7 +13154,7 @@ function addReportApprover(report: OnyxTypes.Report, newApproverEmail: string, n newApproverEmail, }; - API.write(WRITE_COMMANDS.ADD_REPORT_APPROVER, params, onyxData); + void API.write(WRITE_COMMANDS.ADD_REPORT_APPROVER, params, onyxData); } export { diff --git a/src/libs/actions/InputFocus/index.desktop.ts b/src/libs/actions/InputFocus/index.desktop.ts index 07c5195cac42..a9219141b106 100644 --- a/src/libs/actions/InputFocus/index.desktop.ts +++ b/src/libs/actions/InputFocus/index.desktop.ts @@ -5,7 +5,7 @@ import ONYXKEYS from '@src/ONYXKEYS'; import type {Modal} from '@src/types/onyx'; function inputFocusChange(focus: boolean) { - Onyx.set(ONYXKEYS.INPUT_FOCUSED, focus); + void Onyx.set(ONYXKEYS.INPUT_FOCUSED, focus); } let refSave: HTMLElement | undefined; @@ -19,7 +19,7 @@ function composerFocusKeepFocusOn(ref: HTMLElement, isFocused: boolean, modal: M } if (!isFocused && !onyxFocused && !modal.willAlertModalBecomeVisible && !modal.isVisible && refSave) { if (!ReportActionComposeFocusManager.isFocused()) { - InteractionManager.runAfterInteractions(() => { + void InteractionManager.runAfterInteractions(() => { refSave?.focus(); }); } else { diff --git a/src/libs/actions/InputFocus/index.website.ts b/src/libs/actions/InputFocus/index.website.ts index da60f5867132..f72c9fb68695 100644 --- a/src/libs/actions/InputFocus/index.website.ts +++ b/src/libs/actions/InputFocus/index.website.ts @@ -6,7 +6,7 @@ import ONYXKEYS from '@src/ONYXKEYS'; import type {Modal} from '@src/types/onyx'; function inputFocusChange(focus: boolean) { - Onyx.set(ONYXKEYS.INPUT_FOCUSED, focus); + void Onyx.set(ONYXKEYS.INPUT_FOCUSED, focus); } let refSave: HTMLElement | undefined; @@ -21,7 +21,7 @@ function composerFocusKeepFocusOn(ref: HTMLElement, isFocused: boolean, modal: M if (!isFocused && !onyxFocused && !modal.willAlertModalBecomeVisible && !modal.isVisible && refSave) { if (!ReportActionComposeFocusManager.isFocused()) { // Focusing will fail when it is called immediately after closing modal so we call it after interaction. - InteractionManager.runAfterInteractions(() => { + void InteractionManager.runAfterInteractions(() => { refSave?.focus(); }); } else { diff --git a/src/libs/actions/Link.ts b/src/libs/actions/Link.ts index e70bc566d7b4..4de567887e57 100644 --- a/src/libs/actions/Link.ts +++ b/src/libs/actions/Link.ts @@ -73,7 +73,7 @@ function openOldDotLink(url: string, shouldOpenInSameTab = false) { // If shortLivedAuthToken is not accessible, fallback to opening the link without the token. asyncOpenURL( // eslint-disable-next-line rulesdir/no-api-side-effects-method - API.makeRequestWithSideEffects(SIDE_EFFECT_REQUEST_COMMANDS.OPEN_OLD_DOT_LINK, {}, {}) + void API.makeRequestWithSideEffects(SIDE_EFFECT_REQUEST_COMMANDS.OPEN_OLD_DOT_LINK, {}, {}) .then((response) => (response ? buildOldDotURL(url, response.shortLivedAuthToken) : buildOldDotURL(url))) .catch(() => buildOldDotURL(url)), (oldDotURL) => oldDotURL, @@ -113,7 +113,7 @@ function openTravelDotLink(policyID: OnyxEntry, postLoginPath?: string) asyncOpenURL( // eslint-disable-next-line rulesdir/no-api-side-effects-method - API.makeRequestWithSideEffects(SIDE_EFFECT_REQUEST_COMMANDS.GENERATE_SPOTNANA_TOKEN, parameters, {}) + void API.makeRequestWithSideEffects(SIDE_EFFECT_REQUEST_COMMANDS.GENERATE_SPOTNANA_TOKEN, parameters, {}) .then((response) => { if (!response?.spotnanaToken) { reject(error); @@ -214,7 +214,7 @@ function buildURLWithAuthToken(url: string, shortLivedAuthToken?: string) { function openExternalLinkWithToken(url: string, shouldSkipCustomSafariLogic = false) { asyncOpenURL( // eslint-disable-next-line rulesdir/no-api-side-effects-method - API.makeRequestWithSideEffects(SIDE_EFFECT_REQUEST_COMMANDS.OPEN_OLD_DOT_LINK, {}, {}) + void API.makeRequestWithSideEffects(SIDE_EFFECT_REQUEST_COMMANDS.OPEN_OLD_DOT_LINK, {}, {}) .then((response) => (response ? buildURLWithAuthToken(url, response.shortLivedAuthToken) : buildURLWithAuthToken(url))) .catch(() => buildURLWithAuthToken(url)), (link) => link, diff --git a/src/libs/actions/MapboxToken.ts b/src/libs/actions/MapboxToken.ts index 2bd1b1afcc9e..b335f9633f47 100644 --- a/src/libs/actions/MapboxToken.ts +++ b/src/libs/actions/MapboxToken.ts @@ -50,7 +50,7 @@ const hasTokenExpired = () => isAfter(new Date(), new Date(currentToken?.expirat const clearToken = () => { console.debug('[MapboxToken] Deleting the token stored in Onyx'); // Use Onyx.set() to delete the key from Onyx, which will trigger a new token to be retrieved from the API. - Onyx.set(ONYXKEYS.MAPBOX_ACCESS_TOKEN, null); + void Onyx.set(ONYXKEYS.MAPBOX_ACCESS_TOKEN, null); }; const fetchToken = () => { diff --git a/src/libs/actions/MaskOnyx.ts b/src/libs/actions/MaskOnyx.ts index f15f419f2eca..0b59f372dcbc 100644 --- a/src/libs/actions/MaskOnyx.ts +++ b/src/libs/actions/MaskOnyx.ts @@ -2,7 +2,7 @@ import Onyx from 'react-native-onyx'; import ONYXKEYS from '@src/ONYXKEYS'; function setShouldMaskOnyxState(shouldMask: boolean) { - Onyx.set(ONYXKEYS.SHOULD_MASK_ONYX_STATE, shouldMask); + void Onyx.set(ONYXKEYS.SHOULD_MASK_ONYX_STATE, shouldMask); } export { diff --git a/src/libs/actions/MergeAccounts.ts b/src/libs/actions/MergeAccounts.ts index 13e839e522f8..b9f7fa913964 100644 --- a/src/libs/actions/MergeAccounts.ts +++ b/src/libs/actions/MergeAccounts.ts @@ -54,11 +54,11 @@ function requestValidationCodeForAccountMerge(email: string, validateCodeResent email, }; - API.write(WRITE_COMMANDS.GET_VALIDATE_CODE_FOR_ACCOUNT_MERGE, parameters, {optimisticData, successData, failureData}); + void API.write(WRITE_COMMANDS.GET_VALIDATE_CODE_FOR_ACCOUNT_MERGE, parameters, {optimisticData, successData, failureData}); } function clearGetValidateCodeForAccountMerge() { - Onyx.merge(ONYXKEYS.ACCOUNT, { + void Onyx.merge(ONYXKEYS.ACCOUNT, { getValidateCodeForAccountMerge: { errors: null, validateCodeSent: false, @@ -115,11 +115,11 @@ function mergeWithValidateCode(email: string, validateCode: string) { validateCode, }; - API.write(WRITE_COMMANDS.MERGE_WITH_VALIDATE_CODE, parameters, {optimisticData, successData, failureData}); + void API.write(WRITE_COMMANDS.MERGE_WITH_VALIDATE_CODE, parameters, {optimisticData, successData, failureData}); } function clearMergeWithValidateCode() { - Onyx.merge(ONYXKEYS.ACCOUNT, { + void Onyx.merge(ONYXKEYS.ACCOUNT, { mergeWithValidateCode: { errors: null, isLoading: false, diff --git a/src/libs/actions/MergeTransaction.ts b/src/libs/actions/MergeTransaction.ts index 807d10e29d55..bfa0801d6552 100644 --- a/src/libs/actions/MergeTransaction.ts +++ b/src/libs/actions/MergeTransaction.ts @@ -16,14 +16,14 @@ import type {MergeTransaction, Policy, Report, Transaction} from '@src/types/ony * Setup merge transaction data for merging flow */ function setupMergeTransactionData(transactionID: string, values: Partial) { - Onyx.set(`${ONYXKEYS.COLLECTION.MERGE_TRANSACTION}${transactionID}`, values); + void Onyx.set(`${ONYXKEYS.COLLECTION.MERGE_TRANSACTION}${transactionID}`, values); } /** * Sets merge transaction data for a specific transaction */ function setMergeTransactionKey(transactionID: string, values: Partial) { - Onyx.merge(`${ONYXKEYS.COLLECTION.MERGE_TRANSACTION}${transactionID}`, values); + void Onyx.merge(`${ONYXKEYS.COLLECTION.MERGE_TRANSACTION}${transactionID}`, values); } /** @@ -77,7 +77,7 @@ function getTransactionsForMergingLocally(transactionID: string, targetTransacti ); }); - Onyx.merge(`${ONYXKEYS.COLLECTION.MERGE_TRANSACTION}${transactionID}`, { + void Onyx.merge(`${ONYXKEYS.COLLECTION.MERGE_TRANSACTION}${transactionID}`, { eligibleTransactions, }); } @@ -118,7 +118,7 @@ function getTransactionsForMerging({ return areTransactionsEligibleForMerge(targetTransaction, transaction); }); - Onyx.merge(`${ONYXKEYS.COLLECTION.MERGE_TRANSACTION}${transactionID}`, { + void Onyx.merge(`${ONYXKEYS.COLLECTION.MERGE_TRANSACTION}${transactionID}`, { eligibleTransactions, }); return; @@ -311,7 +311,7 @@ function mergeTransactionRequest(mergeTransactionID: string, mergeTransaction: M ...failureSourceReportActionData, ]; - API.write(WRITE_COMMANDS.MERGE_TRANSACTION, params, {optimisticData, failureData}); + void API.write(WRITE_COMMANDS.MERGE_TRANSACTION, params, {optimisticData, failureData}); } export {setupMergeTransactionData, setMergeTransactionKey, getTransactionsForMerging, mergeTransactionRequest}; diff --git a/src/libs/actions/MobileSelectionMode.ts b/src/libs/actions/MobileSelectionMode.ts index 65c6e463461b..eef3731d0a3a 100644 --- a/src/libs/actions/MobileSelectionMode.ts +++ b/src/libs/actions/MobileSelectionMode.ts @@ -2,11 +2,11 @@ import Onyx from 'react-native-onyx'; import ONYXKEYS from '@src/ONYXKEYS'; const turnOnMobileSelectionMode = () => { - Onyx.merge(ONYXKEYS.MOBILE_SELECTION_MODE, true); + void Onyx.merge(ONYXKEYS.MOBILE_SELECTION_MODE, true); }; const turnOffMobileSelectionMode = () => { - Onyx.merge(ONYXKEYS.MOBILE_SELECTION_MODE, false); + void Onyx.merge(ONYXKEYS.MOBILE_SELECTION_MODE, false); }; export {turnOnMobileSelectionMode, turnOffMobileSelectionMode}; diff --git a/src/libs/actions/Modal.ts b/src/libs/actions/Modal.ts index 4c766e11f638..008a47cca463 100644 --- a/src/libs/actions/Modal.ts +++ b/src/libs/actions/Modal.ts @@ -71,14 +71,14 @@ function onModalDidClose() { * Allows other parts of the app to know when a modal has been opened or closed */ function setModalVisibility(isVisible: boolean, type: ModalType | null = null) { - Onyx.merge(ONYXKEYS.MODAL, {isVisible, type}); + void Onyx.merge(ONYXKEYS.MODAL, {isVisible, type}); } /** * Allows other parts of the app to set whether modals should be dismissible using the Escape key */ function setDisableDismissOnEscape(disableDismissOnEscape: boolean) { - Onyx.merge(ONYXKEYS.MODAL, {disableDismissOnEscape}); + void Onyx.merge(ONYXKEYS.MODAL, {disableDismissOnEscape}); } /** @@ -90,7 +90,7 @@ function willAlertModalBecomeVisible(isVisible: boolean, isPopover = false) { // We cancel the pending and active tooltips here instead of in setModalVisibility because // we want to do it when a modal is going to show. If we do it when the modal is fully shown, // the tooltip in that modal won't show. - Onyx.merge(ONYXKEYS.MODAL, {willAlertModalBecomeVisible: isVisible, isPopover}); + void Onyx.merge(ONYXKEYS.MODAL, {willAlertModalBecomeVisible: isVisible, isPopover}); } function areAllModalsHidden() { diff --git a/src/libs/actions/Network.ts b/src/libs/actions/Network.ts index 03ffcf0ee52d..a534cd1f7475 100644 --- a/src/libs/actions/Network.ts +++ b/src/libs/actions/Network.ts @@ -5,7 +5,7 @@ import ONYXKEYS from '@src/ONYXKEYS'; import type {ConnectionChanges} from '@src/types/onyx/Network'; function setNetworkLastOffline(lastOfflineAt: string) { - Onyx.merge(ONYXKEYS.NETWORK, {lastOfflineAt}); + void Onyx.merge(ONYXKEYS.NETWORK, {lastOfflineAt}); } function setIsOffline(isNetworkOffline: boolean, reason = '') { @@ -15,43 +15,43 @@ function setIsOffline(isNetworkOffline: boolean, reason = '') { textToLog += ` because: ${reason}`; Log.info(textToLog); } - Onyx.merge(ONYXKEYS.NETWORK, {isOffline: isNetworkOffline}); + void Onyx.merge(ONYXKEYS.NETWORK, {isOffline: isNetworkOffline}); } function setNetWorkStatus(status: NetworkStatus) { - Onyx.merge(ONYXKEYS.NETWORK, {networkStatus: status}); + void Onyx.merge(ONYXKEYS.NETWORK, {networkStatus: status}); } function setTimeSkew(skew: number) { - Onyx.merge(ONYXKEYS.NETWORK, {timeSkew: skew}); + void Onyx.merge(ONYXKEYS.NETWORK, {timeSkew: skew}); } function setShouldForceOffline(shouldForceOffline: boolean) { - Onyx.merge(ONYXKEYS.NETWORK, {shouldForceOffline}); + void Onyx.merge(ONYXKEYS.NETWORK, {shouldForceOffline}); } /** * Test tool that will fail all network requests when enabled */ function setShouldFailAllRequests(shouldFailAllRequests: boolean) { - Onyx.merge(ONYXKEYS.NETWORK, {shouldFailAllRequests}); + void Onyx.merge(ONYXKEYS.NETWORK, {shouldFailAllRequests}); } function setPoorConnectionTimeoutID(poorConnectionTimeoutID: NodeJS.Timeout | undefined) { - Onyx.merge(ONYXKEYS.NETWORK, {poorConnectionTimeoutID}); + void Onyx.merge(ONYXKEYS.NETWORK, {poorConnectionTimeoutID}); } function setShouldSimulatePoorConnection(shouldSimulatePoorConnection: boolean, poorConnectionTimeoutID: NodeJS.Timeout | undefined) { if (!shouldSimulatePoorConnection) { clearTimeout(poorConnectionTimeoutID); - Onyx.merge(ONYXKEYS.NETWORK, {shouldSimulatePoorConnection, poorConnectionTimeoutID: undefined}); + void Onyx.merge(ONYXKEYS.NETWORK, {shouldSimulatePoorConnection, poorConnectionTimeoutID: undefined}); return; } - Onyx.merge(ONYXKEYS.NETWORK, {shouldSimulatePoorConnection}); + void Onyx.merge(ONYXKEYS.NETWORK, {shouldSimulatePoorConnection}); } function setConnectionChanges(connectionChanges: ConnectionChanges) { - Onyx.merge(ONYXKEYS.NETWORK, {connectionChanges}); + void Onyx.merge(ONYXKEYS.NETWORK, {connectionChanges}); } export { diff --git a/src/libs/actions/Onboarding.ts b/src/libs/actions/Onboarding.ts index 2bc087d0ccea..69cc903c4b2b 100644 --- a/src/libs/actions/Onboarding.ts +++ b/src/libs/actions/Onboarding.ts @@ -8,28 +8,28 @@ import ONYXKEYS from '@src/ONYXKEYS'; * Clear Personal Details draft */ function clearPersonalDetailsDraft() { - Onyx.set(ONYXKEYS.FORMS.ONBOARDING_PERSONAL_DETAILS_FORM_DRAFT, null); + void Onyx.set(ONYXKEYS.FORMS.ONBOARDING_PERSONAL_DETAILS_FORM_DRAFT, null); } /** * Set the personal details Onyx data */ function setPersonalDetails(firstName: string, lastName: string) { - Onyx.merge(ONYXKEYS.FORMS.ONBOARDING_PERSONAL_DETAILS_FORM, {firstName, lastName}); + void Onyx.merge(ONYXKEYS.FORMS.ONBOARDING_PERSONAL_DETAILS_FORM, {firstName, lastName}); } /** * Clear Workspace Details draft */ function clearWorkspaceDetailsDraft() { - Onyx.set(ONYXKEYS.FORMS.ONBOARDING_WORKSPACE_DETAILS_FORM_DRAFT, null); + void Onyx.set(ONYXKEYS.FORMS.ONBOARDING_WORKSPACE_DETAILS_FORM_DRAFT, null); } /** * Set the workspace currency Onyx data */ function setWorkspaceCurrency(currency: string) { - Onyx.merge(ONYXKEYS.FORMS.ONBOARDING_WORKSPACE_DETAILS_FORM_DRAFT, {currency}); + void Onyx.merge(ONYXKEYS.FORMS.ONBOARDING_WORKSPACE_DETAILS_FORM_DRAFT, {currency}); } function verifyTestDriveRecipient(email: string) { diff --git a/src/libs/actions/OnyxDerived/utils.ts b/src/libs/actions/OnyxDerived/utils.ts index 4c7f8867ff9f..a413e9e55ac0 100644 --- a/src/libs/actions/OnyxDerived/utils.ts +++ b/src/libs/actions/OnyxDerived/utils.ts @@ -21,7 +21,7 @@ const hasKeyTriggeredCompute = ) => - Onyx.set(key, value, { + void Onyx.set(key, value, { skipCacheCheck: true, }); diff --git a/src/libs/actions/OnyxUpdateManager/utils/DeferredOnyxUpdates.ts b/src/libs/actions/OnyxUpdateManager/utils/DeferredOnyxUpdates.ts index c198dd906cd2..481bcfc865f0 100644 --- a/src/libs/actions/OnyxUpdateManager/utils/DeferredOnyxUpdates.ts +++ b/src/libs/actions/OnyxUpdateManager/utils/DeferredOnyxUpdates.ts @@ -122,7 +122,7 @@ function clear(options?: ClearDeferredOnyxUpdatesOptions) { } if (options?.shouldUnpauseSequentialQueue ?? true) { - Onyx.set(ONYXKEYS.ONYX_UPDATES_FROM_SERVER, null); + void Onyx.set(ONYXKEYS.ONYX_UPDATES_FROM_SERVER, null); SequentialQueue.unpause(); } } diff --git a/src/libs/actions/OnyxUpdates.ts b/src/libs/actions/OnyxUpdates.ts index 1e25d1a46031..d2609873c08c 100644 --- a/src/libs/actions/OnyxUpdates.ts +++ b/src/libs/actions/OnyxUpdates.ts @@ -144,7 +144,7 @@ function apply({lastUpdateID, type, request, response, updates}: OnyxUpdatesFrom return Promise.resolve(); } if (lastUpdateID && (lastUpdateIDAppliedToClient === undefined || Number(lastUpdateID) > lastUpdateIDAppliedToClient)) { - Onyx.merge(ONYXKEYS.ONYX_UPDATES_LAST_UPDATE_ID_APPLIED_TO_CLIENT, Number(lastUpdateID)); + void Onyx.merge(ONYXKEYS.ONYX_UPDATES_LAST_UPDATE_ID_APPLIED_TO_CLIENT, Number(lastUpdateID)); } if (type === CONST.ONYX_UPDATE_TYPES.HTTPS && request && response) { return applyHTTPSOnyxUpdates(request, response, Number(lastUpdateID)); @@ -170,7 +170,7 @@ function saveUpdateInformation(updateParams: OnyxUpdatesFromServer) { modifiedUpdateParams = {...modifiedUpdateParams, request: {...updateParams.request, data: {apiRequestType: updateParams.request?.data?.apiRequestType}}}; } // Always use set() here so that the updateParams are never merged and always unique to the request that came in - Onyx.set(ONYXKEYS.ONYX_UPDATES_FROM_SERVER, modifiedUpdateParams); + void Onyx.set(ONYXKEYS.ONYX_UPDATES_FROM_SERVER, modifiedUpdateParams); } type DoesClientNeedToBeUpdatedParams = { diff --git a/src/libs/actions/PaymentMethods.ts b/src/libs/actions/PaymentMethods.ts index f1e817d0035c..58e35b5418e2 100644 --- a/src/libs/actions/PaymentMethods.ts +++ b/src/libs/actions/PaymentMethods.ts @@ -151,7 +151,7 @@ function makeDefaultPaymentMethod(bankAccountID: number, fundID: number, previou fundID, }; - API.write(WRITE_COMMANDS.MAKE_DEFAULT_PAYMENT_METHOD, parameters, { + void API.write(WRITE_COMMANDS.MAKE_DEFAULT_PAYMENT_METHOD, parameters, { optimisticData: getMakeDefaultPaymentOnyxData(bankAccountID, fundID, previousPaymentMethod, currentPaymentMethod, true), failureData: getMakeDefaultPaymentOnyxData(bankAccountID, fundID, previousPaymentMethod, currentPaymentMethod, false), }); @@ -200,7 +200,7 @@ function addPaymentCard(accountID: number, params: PaymentCardParams) { }, ]; - API.write(WRITE_COMMANDS.ADD_PAYMENT_CARD, parameters, { + void API.write(WRITE_COMMANDS.ADD_PAYMENT_CARD, parameters, { optimisticData, successData, failureData, @@ -267,7 +267,7 @@ function addSubscriptionPaymentCard( addPaymentCardSCA(parameters, {optimisticData, successData, failureData}); } else { // eslint-disable-next-line rulesdir/no-multiple-api-calls - API.write(WRITE_COMMANDS.ADD_PAYMENT_CARD, parameters, { + void API.write(WRITE_COMMANDS.ADD_PAYMENT_CARD, parameters, { optimisticData, successData, failureData, @@ -285,14 +285,14 @@ function addSubscriptionPaymentCard( * Updates verify3dsSubscription Onyx key with a new authentication link for 3DS. */ function addPaymentCardSCA(params: AddPaymentCardParams, onyxData: OnyxData = {}) { - API.write(WRITE_COMMANDS.ADD_PAYMENT_CARD_SCA, params, onyxData); + void API.write(WRITE_COMMANDS.ADD_PAYMENT_CARD_SCA, params, onyxData); } /** * Resets the values for the add payment card form back to their initial states */ function clearPaymentCardFormErrorAndSubmit() { - Onyx.set(ONYXKEYS.FORMS.ADD_PAYMENT_CARD_FORM, { + void Onyx.set(ONYXKEYS.FORMS.ADD_PAYMENT_CARD_FORM, { isLoading: false, errors: undefined, [INPUT_IDS.SETUP_COMPLETE]: false, @@ -313,7 +313,7 @@ function clearPaymentCardFormErrorAndSubmit() { * */ function clearPaymentCard3dsVerification() { - Onyx.set(ONYXKEYS.VERIFY_3DS_SUBSCRIPTION, ''); + void Onyx.set(ONYXKEYS.VERIFY_3DS_SUBSCRIPTION, ''); } /** @@ -321,7 +321,7 @@ function clearPaymentCard3dsVerification() { * */ function verifySetupIntent(accountID: number, isVerifying = true) { - API.write(WRITE_COMMANDS.VERIFY_SETUP_INTENT, {accountID, isVerifying}); + void API.write(WRITE_COMMANDS.VERIFY_SETUP_INTENT, {accountID, isVerifying}); } /** @@ -329,7 +329,7 @@ function verifySetupIntent(accountID: number, isVerifying = true) { * */ function setPaymentMethodCurrency(currency: ValueOf) { - Onyx.merge(ONYXKEYS.FORMS.ADD_PAYMENT_CARD_FORM, { + void Onyx.merge(ONYXKEYS.FORMS.ADD_PAYMENT_CARD_FORM, { [INPUT_IDS.CURRENCY]: currency, }); } @@ -380,7 +380,7 @@ function transferWalletBalance(paymentMethod: PaymentMethod) { }, ]; - API.write(WRITE_COMMANDS.TRANSFER_WALLET_BALANCE, parameters, { + void API.write(WRITE_COMMANDS.TRANSFER_WALLET_BALANCE, parameters, { optimisticData, successData, failureData, @@ -388,7 +388,7 @@ function transferWalletBalance(paymentMethod: PaymentMethod) { } function resetWalletTransferData() { - Onyx.merge(ONYXKEYS.WALLET_TRANSFER, { + void Onyx.merge(ONYXKEYS.WALLET_TRANSFER, { selectedAccountType: '', selectedAccountID: null, filterPaymentMethodType: null, @@ -398,7 +398,7 @@ function resetWalletTransferData() { } function saveWalletTransferAccountTypeAndID(selectedAccountType: string | undefined, selectedAccountID: string | undefined) { - Onyx.merge(ONYXKEYS.WALLET_TRANSFER, {selectedAccountType, selectedAccountID}); + void Onyx.merge(ONYXKEYS.WALLET_TRANSFER, {selectedAccountType, selectedAccountID}); } /** @@ -406,11 +406,11 @@ function saveWalletTransferAccountTypeAndID(selectedAccountType: string | undefi * */ function saveWalletTransferMethodType(filterPaymentMethodType?: FilterMethodPaymentType) { - Onyx.merge(ONYXKEYS.WALLET_TRANSFER, {filterPaymentMethodType}); + void Onyx.merge(ONYXKEYS.WALLET_TRANSFER, {filterPaymentMethodType}); } function dismissSuccessfulTransferBalancePage() { - Onyx.merge(ONYXKEYS.WALLET_TRANSFER, {shouldShowSuccess: false}); + void Onyx.merge(ONYXKEYS.WALLET_TRANSFER, {shouldShowSuccess: false}); Navigation.goBack(); } @@ -436,7 +436,7 @@ type PaymentListKey = * @param paymentMethodID */ function clearDeletePaymentMethodError(paymentListKey: PaymentListKey, paymentMethodID: number) { - Onyx.merge(paymentListKey, { + void Onyx.merge(paymentListKey, { [paymentMethodID]: { pendingAction: null, errors: null, @@ -450,7 +450,7 @@ function clearDeletePaymentMethodError(paymentListKey: PaymentListKey, paymentMe * @param paymentMethodID */ function clearAddPaymentMethodError(paymentListKey: PaymentListKey, paymentMethodID: number) { - Onyx.merge(paymentListKey, { + void Onyx.merge(paymentListKey, { [paymentMethodID]: null, }); } @@ -459,14 +459,14 @@ function clearAddPaymentMethodError(paymentListKey: PaymentListKey, paymentMetho * Clear any error(s) related to the user's wallet */ function clearWalletError() { - Onyx.merge(ONYXKEYS.USER_WALLET, {errors: null}); + void Onyx.merge(ONYXKEYS.USER_WALLET, {errors: null}); } /** * Clear any error(s) related to the user's wallet terms */ function clearWalletTermsError() { - Onyx.merge(ONYXKEYS.WALLET_TERMS, {errors: null}); + void Onyx.merge(ONYXKEYS.WALLET_TERMS, {errors: null}); } function deletePaymentCard(fundID: number) { @@ -482,7 +482,7 @@ function deletePaymentCard(fundID: number) { }, ]; - API.write(WRITE_COMMANDS.DELETE_PAYMENT_CARD, parameters, { + void API.write(WRITE_COMMANDS.DELETE_PAYMENT_CARD, parameters, { optimisticData, }); } @@ -528,7 +528,7 @@ function updateBillingCurrency(currency: ValueOf { + void Onyx.set(ONYXKEYS.PERSISTED_REQUESTS, requests).then(() => { Log.info(`[SequentialQueue] '${requestToPersist.command}' command queued. Queue length is ${getLength()}`); }); } @@ -71,7 +71,7 @@ function endRequestAndRemoveFromQueue(requestToRemove: Request) { persistedRequests = requests; - Onyx.multiSet({ + void Onyx.multiSet({ [ONYXKEYS.PERSISTED_REQUESTS]: persistedRequests, [ONYXKEYS.PERSISTED_ONGOING_REQUESTS]: null, }).then(() => { @@ -87,7 +87,7 @@ function deleteRequestsByIndices(indices: number[]) { persistedRequests = persistedRequests.filter((_, index) => !indicesSet.has(index)); // Update the persisted requests in storage or state as necessary - Onyx.set(ONYXKEYS.PERSISTED_REQUESTS, persistedRequests).then(() => { + void Onyx.set(ONYXKEYS.PERSISTED_REQUESTS, persistedRequests).then(() => { Log.info(`Multiple (${indices.length}) requests removed from the queue. Queue length is ${persistedRequests.length}`); }); } @@ -98,7 +98,7 @@ function update(oldRequestIndex: number, newRequest: Request) { Log.info('[PersistedRequests] Updating a request', false, {oldRequest, newRequest, oldRequestIndex}); requests.splice(oldRequestIndex, 1, newRequest); persistedRequests = requests; - Onyx.set(ONYXKEYS.PERSISTED_REQUESTS, requests); + void Onyx.set(ONYXKEYS.PERSISTED_REQUESTS, requests); } function updateOngoingRequest(newRequest: Request) { @@ -106,7 +106,7 @@ function updateOngoingRequest(newRequest: Request) { ongoingRequest = newRequest; if (newRequest.persistWhenOngoing) { - Onyx.set(ONYXKEYS.PERSISTED_ONGOING_REQUESTS, newRequest); + void Onyx.set(ONYXKEYS.PERSISTED_ONGOING_REQUESTS, newRequest); } } @@ -124,7 +124,7 @@ function processNextRequest(): Request | null { ongoingRequest = persistedRequests.shift() ?? null; if (ongoingRequest && ongoingRequest.persistWhenOngoing) { - Onyx.set(ONYXKEYS.PERSISTED_ONGOING_REQUESTS, ongoingRequest); + void Onyx.set(ONYXKEYS.PERSISTED_ONGOING_REQUESTS, ongoingRequest); } return ongoingRequest; diff --git a/src/libs/actions/PersonalDetails.ts b/src/libs/actions/PersonalDetails.ts index 1556f0060d5e..d9773d54e9d0 100644 --- a/src/libs/actions/PersonalDetails.ts +++ b/src/libs/actions/PersonalDetails.ts @@ -41,7 +41,7 @@ function updatePronouns(pronouns: string, currentUserAccountID: number) { const parameters: UpdatePronounsParams = {pronouns}; - API.write(WRITE_COMMANDS.UPDATE_PRONOUNS, parameters, { + void API.write(WRITE_COMMANDS.UPDATE_PRONOUNS, parameters, { optimisticData: [ { onyxMethod: Onyx.METHOD.MERGE, @@ -61,7 +61,7 @@ function setDisplayName(firstName: string, lastName: string, formatPhoneNumber: return; } - Onyx.merge(ONYXKEYS.PERSONAL_DETAILS_LIST, { + void Onyx.merge(ONYXKEYS.PERSONAL_DETAILS_LIST, { [currentUserAccountID]: { firstName, lastName, @@ -84,7 +84,7 @@ function updateDisplayName(firstName: string, lastName: string, formatPhoneNumbe const parameters: UpdateDisplayNameParams = {firstName, lastName}; - API.write(WRITE_COMMANDS.UPDATE_DISPLAY_NAME, parameters, { + void API.write(WRITE_COMMANDS.UPDATE_DISPLAY_NAME, parameters, { optimisticData: [ { onyxMethod: Onyx.METHOD.MERGE, @@ -146,7 +146,7 @@ function updateLegalName( }, }); } - API.write(WRITE_COMMANDS.UPDATE_LEGAL_NAME, parameters, { + void API.write(WRITE_COMMANDS.UPDATE_LEGAL_NAME, parameters, { optimisticData, }); Navigation.goBack(); @@ -158,7 +158,7 @@ function updateLegalName( function updateDateOfBirth({dob}: DateOfBirthForm) { const parameters: UpdateDateOfBirthParams = {dob}; - API.write(WRITE_COMMANDS.UPDATE_DATE_OF_BIRTH, parameters, { + void API.write(WRITE_COMMANDS.UPDATE_DATE_OF_BIRTH, parameters, { optimisticData: [ { onyxMethod: Onyx.METHOD.MERGE, @@ -175,7 +175,7 @@ function updateDateOfBirth({dob}: DateOfBirthForm) { function updatePhoneNumber(phoneNumber: string, currentPhoneNumber: string) { const parameters: UpdatePhoneNumberParams = {phoneNumber}; - API.write(WRITE_COMMANDS.UPDATE_PHONE_NUMBER, parameters, { + void API.write(WRITE_COMMANDS.UPDATE_PHONE_NUMBER, parameters, { optimisticData: [ { onyxMethod: Onyx.METHOD.MERGE, @@ -201,7 +201,7 @@ function updatePhoneNumber(phoneNumber: string, currentPhoneNumber: string) { } function clearPhoneNumberError() { - Onyx.merge(ONYXKEYS.PRIVATE_PERSONAL_DETAILS, { + void Onyx.merge(ONYXKEYS.PRIVATE_PERSONAL_DETAILS, { errorFields: { phoneNumber: null, }, @@ -224,7 +224,7 @@ function updateAddress(addresses: Address[], street: string, street2: string, ci parameters.addressStateLong = state; } - API.write(WRITE_COMMANDS.UPDATE_HOME_ADDRESS, parameters, { + void API.write(WRITE_COMMANDS.UPDATE_HOME_ADDRESS, parameters, { optimisticData: [ { onyxMethod: Onyx.METHOD.MERGE, @@ -263,7 +263,7 @@ function updateAutomaticTimezone(timezone: Timezone, currentUserAccountID: numbe timezone: JSON.stringify(formattedTimezone), }; - API.write(WRITE_COMMANDS.UPDATE_AUTOMATIC_TIMEZONE, parameters, { + void API.write(WRITE_COMMANDS.UPDATE_AUTOMATIC_TIMEZONE, parameters, { optimisticData: [ { onyxMethod: Onyx.METHOD.MERGE, @@ -292,7 +292,7 @@ function updateSelectedTimezone(selectedTimezone: SelectedTimezone, currentUserA }; if (currentUserAccountID) { - API.write(WRITE_COMMANDS.UPDATE_SELECTED_TIMEZONE, parameters, { + void API.write(WRITE_COMMANDS.UPDATE_SELECTED_TIMEZONE, parameters, { optimisticData: [ { onyxMethod: Onyx.METHOD.MERGE, @@ -417,7 +417,7 @@ function updateAvatar(file: File | CustomRNImageManipulatorResult, currentUserPe const parameters: UpdateUserAvatarParams = {file}; - API.write(WRITE_COMMANDS.UPDATE_USER_AVATAR, parameters, {optimisticData, successData, failureData}); + void API.write(WRITE_COMMANDS.UPDATE_USER_AVATAR, parameters, {optimisticData, successData, failureData}); } /** @@ -456,7 +456,7 @@ function deleteAvatar(currentUserPersonalDetails: Pick categoriesToUpdate[key])), }; - API.write(WRITE_COMMANDS.SET_WORKSPACE_CATEGORIES_ENABLED, parameters, onyxData); + void API.write(WRITE_COMMANDS.SET_WORKSPACE_CATEGORIES_ENABLED, parameters, onyxData); } function setPolicyCategoryDescriptionRequired(policyID: string, categoryName: string, areCommentsRequired: boolean) { @@ -474,7 +474,7 @@ function setPolicyCategoryDescriptionRequired(policyID: string, categoryName: st areCommentsRequired, }; - API.write(WRITE_COMMANDS.SET_POLICY_CATEGORY_DESCRIPTION_REQUIRED, parameters, onyxData); + void API.write(WRITE_COMMANDS.SET_POLICY_CATEGORY_DESCRIPTION_REQUIRED, parameters, onyxData); } function setPolicyCategoryReceiptsRequired(policyID: string, categoryName: string, maxAmountNoReceipt: number) { @@ -535,7 +535,7 @@ function setPolicyCategoryReceiptsRequired(policyID: string, categoryName: strin maxExpenseAmountNoReceipt: maxAmountNoReceipt, }; - API.write(WRITE_COMMANDS.SET_POLICY_CATEGORY_RECEIPTS_REQUIRED, parameters, onyxData); + void API.write(WRITE_COMMANDS.SET_POLICY_CATEGORY_RECEIPTS_REQUIRED, parameters, onyxData); } function removePolicyCategoryReceiptsRequired(policyID: string, categoryName: string) { @@ -595,7 +595,7 @@ function removePolicyCategoryReceiptsRequired(policyID: string, categoryName: st categoryName, }; - API.write(WRITE_COMMANDS.REMOVE_POLICY_CATEGORY_RECEIPTS_REQUIRED, parameters, onyxData); + void API.write(WRITE_COMMANDS.REMOVE_POLICY_CATEGORY_RECEIPTS_REQUIRED, parameters, onyxData); } function createPolicyCategory(policyID: string, categoryName: string) { @@ -606,7 +606,7 @@ function createPolicyCategory(policyID: string, categoryName: string) { categories: JSON.stringify([{name: categoryName}]), }; - API.write(WRITE_COMMANDS.CREATE_WORKSPACE_CATEGORIES, parameters, onyxData); + void API.write(WRITE_COMMANDS.CREATE_WORKSPACE_CATEGORIES, parameters, onyxData); } function importPolicyCategories(policyID: string, categories: PolicyCategory[]) { @@ -626,7 +626,7 @@ function importPolicyCategories(policyID: string, categories: PolicyCategory[]) categories: JSON.stringify([...categories.map((category) => ({name: category.name, enabled: category.enabled, 'GL Code': String(category['GL Code'])}))]), }; - API.write(WRITE_COMMANDS.IMPORT_CATEGORIES_SPREADSHEET, parameters, onyxData); + void API.write(WRITE_COMMANDS.IMPORT_CATEGORIES_SPREADSHEET, parameters, onyxData); } function renamePolicyCategory(policyID: string, policyCategory: {oldName: string; newName: string}) { @@ -753,7 +753,7 @@ function renamePolicyCategory(policyID: string, policyCategory: {oldName: string categories: JSON.stringify({[policyCategory.oldName]: policyCategory.newName}), }; - API.write(WRITE_COMMANDS.RENAME_WORKSPACE_CATEGORY, parameters, onyxData); + void API.write(WRITE_COMMANDS.RENAME_WORKSPACE_CATEGORY, parameters, onyxData); } function setPolicyCategoryPayrollCode(policyID: string, categoryName: string, payrollCode: string) { @@ -821,7 +821,7 @@ function setPolicyCategoryPayrollCode(policyID: string, categoryName: string, pa payrollCode, }; - API.write(WRITE_COMMANDS.UPDATE_POLICY_CATEGORY_PAYROLL_CODE, parameters, onyxData); + void API.write(WRITE_COMMANDS.UPDATE_POLICY_CATEGORY_PAYROLL_CODE, parameters, onyxData); } function setPolicyCategoryGLCode(policyID: string, categoryName: string, glCode: string) { @@ -889,7 +889,7 @@ function setPolicyCategoryGLCode(policyID: string, categoryName: string, glCode: glCode, }; - API.write(WRITE_COMMANDS.UPDATE_POLICY_CATEGORY_GL_CODE, parameters, onyxData); + void API.write(WRITE_COMMANDS.UPDATE_POLICY_CATEGORY_GL_CODE, parameters, onyxData); } function setWorkspaceRequiresCategory( @@ -951,7 +951,7 @@ function setWorkspaceRequiresCategory( requiresCategory, }; - API.write(WRITE_COMMANDS.SET_WORKSPACE_REQUIRES_CATEGORY, parameters, onyxData); + void API.write(WRITE_COMMANDS.SET_WORKSPACE_REQUIRES_CATEGORY, parameters, onyxData); } function clearCategoryErrors(policyID: string, categoryName: string) { @@ -962,13 +962,13 @@ function clearCategoryErrors(policyID: string, categoryName: string) { } if (category.pendingAction === CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD) { - Onyx.merge(`${ONYXKEYS.COLLECTION.POLICY_CATEGORIES}${policyID}`, { + void Onyx.merge(`${ONYXKEYS.COLLECTION.POLICY_CATEGORIES}${policyID}`, { [category.name]: null, }); return; } - Onyx.merge(`${ONYXKEYS.COLLECTION.POLICY_CATEGORIES}${policyID}`, { + void Onyx.merge(`${ONYXKEYS.COLLECTION.POLICY_CATEGORIES}${policyID}`, { [category.name]: { errors: null, }, @@ -1034,7 +1034,7 @@ function deleteWorkspaceCategories( categories: JSON.stringify(categoryNamesToDelete), }; - API.write(WRITE_COMMANDS.DELETE_WORKSPACE_CATEGORIES, parameters, onyxData); + void API.write(WRITE_COMMANDS.DELETE_WORKSPACE_CATEGORIES, parameters, onyxData); } function enablePolicyCategories( @@ -1128,7 +1128,7 @@ function enablePolicyCategories( const parameters: EnablePolicyCategoriesParams = {policyID, enabled}; - API.writeWithNoDuplicatesEnableFeatureConflicts(WRITE_COMMANDS.ENABLE_POLICY_CATEGORIES, parameters, onyxData); + void API.writeWithNoDuplicatesEnableFeatureConflicts(WRITE_COMMANDS.ENABLE_POLICY_CATEGORIES, parameters, onyxData); if (enabled && getIsNarrowLayout() && shouldGoBack) { goBackWhenEnableFeature(policyID); @@ -1187,7 +1187,7 @@ function setPolicyCustomUnitDefaultCategory(policyID: string, customUnitID: stri category, }; - API.write(WRITE_COMMANDS.SET_CUSTOM_UNIT_DEFAULT_CATEGORY, params, {optimisticData, successData, failureData}); + void API.write(WRITE_COMMANDS.SET_CUSTOM_UNIT_DEFAULT_CATEGORY, params, {optimisticData, successData, failureData}); } function downloadCategoriesCSV(policyID: string, onDownloadFailed: () => void) { @@ -1202,7 +1202,7 @@ function downloadCategoriesCSV(policyID: string, onDownloadFailed: () => void) { formData.append(key, String(value)); }); - fileDownload(ApiUtils.getCommandURL({command: WRITE_COMMANDS.EXPORT_CATEGORIES_CSV}), fileName, '', false, formData, CONST.NETWORK.METHOD.POST, onDownloadFailed); + void fileDownload(ApiUtils.getCommandURL({command: WRITE_COMMANDS.EXPORT_CATEGORIES_CSV}), fileName, '', false, formData, CONST.NETWORK.METHOD.POST, onDownloadFailed); } function setWorkspaceCategoryDescriptionHint(policyID: string, categoryName: string, commentHint: string) { @@ -1263,7 +1263,7 @@ function setWorkspaceCategoryDescriptionHint(policyID: string, categoryName: str commentHint, }; - API.write(WRITE_COMMANDS.SET_WORKSPACE_CATEGORY_DESCRIPTION_HINT, parameters, onyxData); + void API.write(WRITE_COMMANDS.SET_WORKSPACE_CATEGORY_DESCRIPTION_HINT, parameters, onyxData); } function setPolicyCategoryMaxAmount(policyID: string, categoryName: string, maxExpenseAmount: string, expenseLimitType: PolicyCategoryExpenseLimitType) { @@ -1334,7 +1334,7 @@ function setPolicyCategoryMaxAmount(policyID: string, categoryName: string, maxE expenseLimitType, }; - API.write(WRITE_COMMANDS.SET_POLICY_CATEGORY_MAX_AMOUNT, parameters, onyxData); + void API.write(WRITE_COMMANDS.SET_POLICY_CATEGORY_MAX_AMOUNT, parameters, onyxData); } function setPolicyCategoryApprover(policyID: string, categoryName: string, approver: string, approvalRules: ApprovalRule[]) { @@ -1397,7 +1397,7 @@ function setPolicyCategoryApprover(policyID: string, categoryName: string, appro approver: newApprover, }; - API.write(WRITE_COMMANDS.SET_POLICY_CATEGORY_APPROVER, parameters, onyxData); + void API.write(WRITE_COMMANDS.SET_POLICY_CATEGORY_APPROVER, parameters, onyxData); } function setPolicyCategoryTax(policyID: string, categoryName: string, taxID: string) { @@ -1464,7 +1464,7 @@ function setPolicyCategoryTax(policyID: string, categoryName: string, taxID: str taxID, }; - API.write(WRITE_COMMANDS.SET_POLICY_CATEGORY_TAX, parameters, onyxData); + void API.write(WRITE_COMMANDS.SET_POLICY_CATEGORY_TAX, parameters, onyxData); } function getPolicyCategoriesData(policyID: string | undefined) { diff --git a/src/libs/actions/Policy/DistanceRate.ts b/src/libs/actions/Policy/DistanceRate.ts index 941f1fdfccd5..933191f8e28f 100644 --- a/src/libs/actions/Policy/DistanceRate.ts +++ b/src/libs/actions/Policy/DistanceRate.ts @@ -118,7 +118,7 @@ function enablePolicyDistanceRates(policyID: string, enabled: boolean, customUni const parameters: EnablePolicyDistanceRatesParams = {policyID, enabled}; - API.writeWithNoDuplicatesEnableFeatureConflicts(WRITE_COMMANDS.ENABLE_POLICY_DISTANCE_RATES, parameters, onyxData); + void API.writeWithNoDuplicatesEnableFeatureConflicts(WRITE_COMMANDS.ENABLE_POLICY_DISTANCE_RATES, parameters, onyxData); if (enabled && getIsNarrowLayout()) { goBackWhenEnableFeature(policyID); @@ -187,11 +187,11 @@ function createPolicyDistanceRate(policyID: string, customUnitID: string, custom customUnitRate: JSON.stringify(customUnitRate), }; - API.write(WRITE_COMMANDS.CREATE_POLICY_DISTANCE_RATE, params, {optimisticData, successData, failureData}); + void API.write(WRITE_COMMANDS.CREATE_POLICY_DISTANCE_RATE, params, {optimisticData, successData, failureData}); } function clearCreateDistanceRateItemAndError(policyID: string, customUnitID: string, customUnitRateIDToClear: string) { - Onyx.merge(`${ONYXKEYS.COLLECTION.POLICY}${policyID}`, { + void Onyx.merge(`${ONYXKEYS.COLLECTION.POLICY}${policyID}`, { customUnits: { [customUnitID]: { rates: { @@ -203,7 +203,7 @@ function clearCreateDistanceRateItemAndError(policyID: string, customUnitID: str } function clearPolicyDistanceRatesErrorFields(policyID: string, customUnitID: string, updatedErrorFields: ErrorFields) { - Onyx.merge(`${ONYXKEYS.COLLECTION.POLICY}${policyID}`, { + void Onyx.merge(`${ONYXKEYS.COLLECTION.POLICY}${policyID}`, { customUnits: { [customUnitID]: { errorFields: updatedErrorFields, @@ -213,7 +213,7 @@ function clearPolicyDistanceRatesErrorFields(policyID: string, customUnitID: str } function clearDeleteDistanceRateError(policyID: string, customUnitID: string, rateID: string) { - Onyx.merge(`${ONYXKEYS.COLLECTION.POLICY}${policyID}`, { + void Onyx.merge(`${ONYXKEYS.COLLECTION.POLICY}${policyID}`, { customUnits: { [customUnitID]: { rates: { @@ -227,7 +227,7 @@ function clearDeleteDistanceRateError(policyID: string, customUnitID: string, ra } function clearPolicyDistanceRateErrorFields(policyID: string, customUnitID: string, rateID: string, updatedErrorFields: ErrorFields) { - Onyx.merge(`${ONYXKEYS.COLLECTION.POLICY}${policyID}`, { + void Onyx.merge(`${ONYXKEYS.COLLECTION.POLICY}${policyID}`, { customUnits: { [customUnitID]: { rates: { @@ -291,7 +291,7 @@ function setPolicyDistanceRatesUnit(policyID: string, currentCustomUnit: CustomU customUnit: JSON.stringify(removePendingFieldsFromCustomUnit(newCustomUnit)), }; - API.write(WRITE_COMMANDS.SET_POLICY_DISTANCE_RATES_UNIT, params, {optimisticData, successData, failureData}); + void API.write(WRITE_COMMANDS.SET_POLICY_DISTANCE_RATES_UNIT, params, {optimisticData, successData, failureData}); } function updatePolicyDistanceRateValue(policyID: string, customUnit: CustomUnit, customUnitRates: Rate[]) { @@ -303,7 +303,7 @@ function updatePolicyDistanceRateValue(policyID: string, customUnit: CustomUnit, customUnitRateArray: JSON.stringify(prepareCustomUnitRatesArray(customUnitRates)), }; - API.write(WRITE_COMMANDS.UPDATE_POLICY_DISTANCE_RATE_VALUE, params, {optimisticData, successData, failureData}); + void API.write(WRITE_COMMANDS.UPDATE_POLICY_DISTANCE_RATE_VALUE, params, {optimisticData, successData, failureData}); } function updatePolicyDistanceRateName(policyID: string, customUnit: CustomUnit, customUnitRates: Rate[]) { @@ -315,7 +315,7 @@ function updatePolicyDistanceRateName(policyID: string, customUnit: CustomUnit, customUnitRateArray: JSON.stringify(prepareCustomUnitRatesArray(customUnitRates)), }; - API.write(WRITE_COMMANDS.UPDATE_POLICY_DISTANCE_RATE_NAME, params, {optimisticData, successData, failureData}); + void API.write(WRITE_COMMANDS.UPDATE_POLICY_DISTANCE_RATE_NAME, params, {optimisticData, successData, failureData}); } function setPolicyDistanceRatesEnabled(policyID: string, customUnit: CustomUnit, customUnitRates: Rate[]) { @@ -386,7 +386,7 @@ function setPolicyDistanceRatesEnabled(policyID: string, customUnit: CustomUnit, customUnitRateArray: JSON.stringify(prepareCustomUnitRatesArray(customUnitRates)), }; - API.write(WRITE_COMMANDS.SET_POLICY_DISTANCE_RATES_ENABLED, params, {optimisticData, successData, failureData}); + void API.write(WRITE_COMMANDS.SET_POLICY_DISTANCE_RATES_ENABLED, params, {optimisticData, successData, failureData}); } function deletePolicyDistanceRates( @@ -502,7 +502,7 @@ function deletePolicyDistanceRates( customUnitRateID: rateIDsToDelete, }; - API.write(WRITE_COMMANDS.DELETE_POLICY_DISTANCE_RATES, params, {optimisticData, successData, failureData}); + void API.write(WRITE_COMMANDS.DELETE_POLICY_DISTANCE_RATES, params, {optimisticData, successData, failureData}); } function updateDistanceTaxClaimableValue(policyID: string, customUnit: CustomUnit, customUnitRates: Rate[]) { @@ -514,7 +514,7 @@ function updateDistanceTaxClaimableValue(policyID: string, customUnit: CustomUni customUnitRateArray: JSON.stringify(prepareCustomUnitRatesArray(customUnitRates)), }; - API.write(WRITE_COMMANDS.UPDATE_DISTANCE_TAX_CLAIMABLE_VALUE, params, {optimisticData, successData, failureData}); + void API.write(WRITE_COMMANDS.UPDATE_DISTANCE_TAX_CLAIMABLE_VALUE, params, {optimisticData, successData, failureData}); } function updateDistanceTaxRate(policyID: string, customUnit: CustomUnit, customUnitRates: Rate[]) { @@ -526,7 +526,7 @@ function updateDistanceTaxRate(policyID: string, customUnit: CustomUnit, customU customUnitRateArray: JSON.stringify(prepareCustomUnitRatesArray(customUnitRates)), }; - API.write(WRITE_COMMANDS.UPDATE_POLICY_DISTANCE_TAX_RATE_VALUE, params, {optimisticData, successData, failureData}); + void API.write(WRITE_COMMANDS.UPDATE_POLICY_DISTANCE_TAX_RATE_VALUE, params, {optimisticData, successData, failureData}); } export { diff --git a/src/libs/actions/Policy/Member.ts b/src/libs/actions/Policy/Member.ts index 2f43a45024fb..8554dba3a264 100644 --- a/src/libs/actions/Policy/Member.ts +++ b/src/libs/actions/Policy/Member.ts @@ -82,8 +82,8 @@ Onyx.connect({ cleanUpSetQueries[`${ONYXKEYS.COLLECTION.REPORT_DRAFT_COMMENT}${reportID}`] = null; cleanUpSetQueries[`${ONYXKEYS.COLLECTION.REPORT_ACTIONS_DRAFTS}${reportID}`] = null; }); - Onyx.mergeCollection(ONYXKEYS.COLLECTION.REPORT, cleanUpMergeQueries); - Onyx.multiSet(cleanUpSetQueries); + void Onyx.mergeCollection(ONYXKEYS.COLLECTION.REPORT, cleanUpMergeQueries); + void Onyx.multiSet(cleanUpSetQueries); delete allPolicies[key]; return; } @@ -670,7 +670,7 @@ function removeMembers(accountIDs: number[], policyID: string) { policyID, }; - API.write(WRITE_COMMANDS.DELETE_MEMBERS_FROM_WORKSPACE, params, {optimisticData, successData, failureData}); + void API.write(WRITE_COMMANDS.DELETE_MEMBERS_FROM_WORKSPACE, params, {optimisticData, successData, failureData}); } function buildUpdateWorkspaceMembersRoleOnyxData(policyID: string, accountIDs: number[], newRole: ValueOf) { @@ -793,7 +793,7 @@ function updateWorkspaceMembersRole(policyID: string, accountIDs: number[], newR employees: JSON.stringify(memberRoles.map((item) => ({email: item.email, role: item.role}))), }; - API.write(WRITE_COMMANDS.UPDATE_WORKSPACE_MEMBERS_ROLE, params, {optimisticData, successData, failureData}); + void API.write(WRITE_COMMANDS.UPDATE_WORKSPACE_MEMBERS_ROLE, params, {optimisticData, successData, failureData}); } function requestWorkspaceOwnerChange(policyID: string | undefined) { @@ -826,7 +826,7 @@ function requestWorkspaceOwnerChange(policyID: string | undefined) { ownershipChecks.shouldTransferSingleSubscription = true; } - Onyx.merge(ONYXKEYS.POLICY_OWNERSHIP_CHANGE_CHECKS, { + void Onyx.merge(ONYXKEYS.POLICY_OWNERSHIP_CHANGE_CHECKS, { [policyID]: ownershipChecks, }); } @@ -875,7 +875,7 @@ function requestWorkspaceOwnerChange(policyID: string | undefined) { ...ownershipChecks, }; - API.write(WRITE_COMMANDS.REQUEST_WORKSPACE_OWNER_CHANGE, params, {optimisticData, successData, failureData}); + void API.write(WRITE_COMMANDS.REQUEST_WORKSPACE_OWNER_CHANGE, params, {optimisticData, successData, failureData}); } function clearWorkspaceOwnerChangeFlow(policyID: string | undefined) { @@ -883,8 +883,8 @@ function clearWorkspaceOwnerChangeFlow(policyID: string | undefined) { return; } - Onyx.merge(ONYXKEYS.POLICY_OWNERSHIP_CHANGE_CHECKS, null); - Onyx.merge(`${ONYXKEYS.COLLECTION.POLICY}${policyID}`, { + void Onyx.merge(ONYXKEYS.POLICY_OWNERSHIP_CHANGE_CHECKS, null); + void Onyx.merge(`${ONYXKEYS.COLLECTION.POLICY}${policyID}`, { errorFields: null, isLoading: false, isChangeOwnerSuccessful: false, @@ -1021,7 +1021,7 @@ function addMembersToWorkspace( if (!isEmptyObject(membersChats.reportCreationData)) { params.reportCreationData = JSON.stringify(membersChats.reportCreationData); } - API.write(WRITE_COMMANDS.ADD_MEMBERS_TO_WORKSPACE, params, {optimisticData, successData, failureData}); + void API.write(WRITE_COMMANDS.ADD_MEMBERS_TO_WORKSPACE, params, {optimisticData, successData, failureData}); } type PolicyMember = { @@ -1056,7 +1056,7 @@ function importPolicyMembers(policyID: string, members: PolicyMember[]) { employees: JSON.stringify(members.map((member) => ({email: member.email, role: member.role, submitsTo: member.submitsTo, forwardsTo: member.forwardsTo}))), }; - API.write(WRITE_COMMANDS.IMPORT_MEMBERS_SPREADSHEET, parameters, onyxData); + void API.write(WRITE_COMMANDS.IMPORT_MEMBERS_SPREADSHEET, parameters, onyxData); } /** @@ -1087,7 +1087,7 @@ function inviteMemberToWorkspace(policyID: string, inviterEmail?: string) { const params = {policyID, inviterEmail}; - API.write(WRITE_COMMANDS.JOIN_POLICY_VIA_INVITE_LINK, params, {optimisticData, failureData}); + void API.write(WRITE_COMMANDS.JOIN_POLICY_VIA_INVITE_LINK, params, {optimisticData, failureData}); } /** @@ -1112,7 +1112,7 @@ function joinAccessiblePolicy(policyID: string) { }, ]; - API.write(WRITE_COMMANDS.JOIN_ACCESSIBLE_POLICY, {policyID}, {optimisticData, failureData}); + void API.write(WRITE_COMMANDS.JOIN_ACCESSIBLE_POLICY, {policyID}, {optimisticData, failureData}); } /** @@ -1137,7 +1137,7 @@ function askToJoinPolicy(policyID: string) { }, ]; - API.write(WRITE_COMMANDS.ASK_TO_JOIN_POLICY, {policyID}, {optimisticData, failureData}); + void API.write(WRITE_COMMANDS.ASK_TO_JOIN_POLICY, {policyID}, {optimisticData, failureData}); } /** @@ -1145,7 +1145,7 @@ function askToJoinPolicy(policyID: string) { */ function clearDeleteMemberError(policyID: string, accountID: number) { const email = allPersonalDetails?.[accountID]?.login ?? ''; - Onyx.merge(`${ONYXKEYS.COLLECTION.POLICY}${policyID}`, { + void Onyx.merge(`${ONYXKEYS.COLLECTION.POLICY}${policyID}`, { employeeList: { [email]: { pendingAction: null, @@ -1160,12 +1160,12 @@ function clearDeleteMemberError(policyID: string, accountID: number) { */ function clearAddMemberError(policyID: string, accountID: number) { const email = allPersonalDetails?.[accountID]?.login ?? ''; - Onyx.merge(`${ONYXKEYS.COLLECTION.POLICY}${policyID}`, { + void Onyx.merge(`${ONYXKEYS.COLLECTION.POLICY}${policyID}`, { employeeList: { [email]: null, }, }); - Onyx.merge(`${ONYXKEYS.PERSONAL_DETAILS_LIST}`, { + void Onyx.merge(`${ONYXKEYS.PERSONAL_DETAILS_LIST}`, { [accountID]: null, }); } @@ -1194,15 +1194,15 @@ function openPolicyMemberProfilePage(policyID: string, accountID: number) { } function setWorkspaceInviteMembersDraft(policyID: string, invitedEmailsToAccountIDs: InvitedEmailsToAccountIDs) { - Onyx.set(`${ONYXKEYS.COLLECTION.WORKSPACE_INVITE_MEMBERS_DRAFT}${policyID}`, invitedEmailsToAccountIDs); + void Onyx.set(`${ONYXKEYS.COLLECTION.WORKSPACE_INVITE_MEMBERS_DRAFT}${policyID}`, invitedEmailsToAccountIDs); } function setWorkspaceInviteRoleDraft(policyID: string, role: ValueOf) { - Onyx.set(`${ONYXKEYS.COLLECTION.WORKSPACE_INVITE_ROLE_DRAFT}${policyID}`, role); + void Onyx.set(`${ONYXKEYS.COLLECTION.WORKSPACE_INVITE_ROLE_DRAFT}${policyID}`, role); } function clearWorkspaceInviteRoleDraft(policyID: string) { - Onyx.set(`${ONYXKEYS.COLLECTION.WORKSPACE_INVITE_ROLE_DRAFT}${policyID}`, null); + void Onyx.set(`${ONYXKEYS.COLLECTION.WORKSPACE_INVITE_ROLE_DRAFT}${policyID}`, null); } /** @@ -1265,7 +1265,7 @@ function acceptJoinRequest(reportID: string | undefined, reportAction: OnyxEntry }), }; - API.write(WRITE_COMMANDS.ACCEPT_JOIN_REQUEST, parameters, {optimisticData, failureData, successData}); + void API.write(WRITE_COMMANDS.ACCEPT_JOIN_REQUEST, parameters, {optimisticData, failureData, successData}); } /** @@ -1327,7 +1327,7 @@ function declineJoinRequest(reportID: string | undefined, reportAction: OnyxEntr }), }; - API.write(WRITE_COMMANDS.DECLINE_JOIN_REQUEST, parameters, {optimisticData, failureData, successData}); + void API.write(WRITE_COMMANDS.DECLINE_JOIN_REQUEST, parameters, {optimisticData, failureData, successData}); } function downloadMembersCSV(policyID: string, onDownloadFailed: () => void) { @@ -1342,7 +1342,7 @@ function downloadMembersCSV(policyID: string, onDownloadFailed: () => void) { formData.append(key, String(value)); }); - fileDownload(ApiUtils.getCommandURL({command: WRITE_COMMANDS.EXPORT_MEMBERS_CSV}), fileName, '', false, formData, CONST.NETWORK.METHOD.POST, onDownloadFailed); + void fileDownload(ApiUtils.getCommandURL({command: WRITE_COMMANDS.EXPORT_MEMBERS_CSV}), fileName, '', false, formData, CONST.NETWORK.METHOD.POST, onDownloadFailed); } function clearInviteDraft(policyID: string) { @@ -1351,11 +1351,11 @@ function clearInviteDraft(policyID: string) { } function setImportedSpreadsheetMemberData(memberData: ImportedSpreadsheetMemberData[]) { - Onyx.set(ONYXKEYS.IMPORTED_SPREADSHEET_MEMBER_DATA, memberData); + void Onyx.set(ONYXKEYS.IMPORTED_SPREADSHEET_MEMBER_DATA, memberData); } function clearImportedSpreadsheetMemberData() { - Onyx.set(ONYXKEYS.IMPORTED_SPREADSHEET_MEMBER_DATA, null); + void Onyx.set(ONYXKEYS.IMPORTED_SPREADSHEET_MEMBER_DATA, null); } export { diff --git a/src/libs/actions/Policy/PerDiem.ts b/src/libs/actions/Policy/PerDiem.ts index 33bc2bef5a02..ea9c987aece0 100644 --- a/src/libs/actions/Policy/PerDiem.ts +++ b/src/libs/actions/Policy/PerDiem.ts @@ -85,7 +85,7 @@ function enablePerDiem(policyID: string, enabled: boolean, customUnitID?: string const parameters = {policyID, enabled, customUnitID: finalCustomUnitID}; - API.write(WRITE_COMMANDS.TOGGLE_POLICY_PER_DIEM, parameters, onyxData); + void API.write(WRITE_COMMANDS.TOGGLE_POLICY_PER_DIEM, parameters, onyxData); if (enabled && getIsNarrowLayout() && shouldGoBack) { goBackWhenEnableFeature(policyID); @@ -142,7 +142,7 @@ function importPerDiemRates(policyID: string, customUnitID: string, rates: Rate[ customUnitRates: JSON.stringify(rates), }; - API.write(WRITE_COMMANDS.IMPORT_PER_DIEM_RATES, parameters, onyxData); + void API.write(WRITE_COMMANDS.IMPORT_PER_DIEM_RATES, parameters, onyxData); } function downloadPerDiemCSV(policyID: string, onDownloadFailed: () => void) { @@ -157,11 +157,11 @@ function downloadPerDiemCSV(policyID: string, onDownloadFailed: () => void) { formData.append(key, String(value)); }); - fileDownload(getCommandURL({command: WRITE_COMMANDS.EXPORT_PER_DIEM_CSV}), fileName, '', false, formData, CONST.NETWORK.METHOD.POST, onDownloadFailed); + void fileDownload(getCommandURL({command: WRITE_COMMANDS.EXPORT_PER_DIEM_CSV}), fileName, '', false, formData, CONST.NETWORK.METHOD.POST, onDownloadFailed); } function clearPolicyPerDiemRatesErrorFields(policyID: string, customUnitID: string, updatedErrorFields: ErrorFields) { - Onyx.merge(`${ONYXKEYS.COLLECTION.POLICY}${policyID}`, { + void Onyx.merge(`${ONYXKEYS.COLLECTION.POLICY}${policyID}`, { customUnits: { [customUnitID]: { errorFields: updatedErrorFields, @@ -231,7 +231,7 @@ function deleteWorkspacePerDiemRates(policyID: string, customUnit: CustomUnit | customUnit: JSON.stringify(newCustomUnit), }; - API.write(WRITE_COMMANDS.UPDATE_WORKSPACE_CUSTOM_UNIT, parameters, onyxData); + void API.write(WRITE_COMMANDS.UPDATE_WORKSPACE_CUSTOM_UNIT, parameters, onyxData); } function editPerDiemRateDestination(policyID: string, rateID: string, customUnit: CustomUnit | undefined, newDestination: string) { @@ -261,7 +261,7 @@ function editPerDiemRateDestination(policyID: string, rateID: string, customUnit customUnit: JSON.stringify(newCustomUnit), }; - API.write(WRITE_COMMANDS.UPDATE_WORKSPACE_CUSTOM_UNIT, parameters, onyxData); + void API.write(WRITE_COMMANDS.UPDATE_WORKSPACE_CUSTOM_UNIT, parameters, onyxData); } function editPerDiemRateSubrate(policyID: string, rateID: string, subRateID: string, customUnit: CustomUnit | undefined, newSubrate: string) { @@ -296,7 +296,7 @@ function editPerDiemRateSubrate(policyID: string, rateID: string, subRateID: str customUnit: JSON.stringify(newCustomUnit), }; - API.write(WRITE_COMMANDS.UPDATE_WORKSPACE_CUSTOM_UNIT, parameters, onyxData); + void API.write(WRITE_COMMANDS.UPDATE_WORKSPACE_CUSTOM_UNIT, parameters, onyxData); } function editPerDiemRateAmount(policyID: string, rateID: string, subRateID: string, customUnit: CustomUnit | undefined, newAmount: number) { @@ -331,7 +331,7 @@ function editPerDiemRateAmount(policyID: string, rateID: string, subRateID: stri customUnit: JSON.stringify(newCustomUnit), }; - API.write(WRITE_COMMANDS.UPDATE_WORKSPACE_CUSTOM_UNIT, parameters, onyxData); + void API.write(WRITE_COMMANDS.UPDATE_WORKSPACE_CUSTOM_UNIT, parameters, onyxData); } function editPerDiemRateCurrency(policyID: string, rateID: string, customUnit: CustomUnit | undefined, newCurrency: string) { @@ -361,7 +361,7 @@ function editPerDiemRateCurrency(policyID: string, rateID: string, customUnit: C customUnit: JSON.stringify(newCustomUnit), }; - API.write(WRITE_COMMANDS.UPDATE_WORKSPACE_CUSTOM_UNIT, parameters, onyxData); + void API.write(WRITE_COMMANDS.UPDATE_WORKSPACE_CUSTOM_UNIT, parameters, onyxData); } export { diff --git a/src/libs/actions/Policy/Policy.ts b/src/libs/actions/Policy/Policy.ts index 6429e6bb88b5..1f1bf7895284 100644 --- a/src/libs/actions/Policy/Policy.ts +++ b/src/libs/actions/Policy/Policy.ts @@ -216,8 +216,8 @@ Onyx.connect({ cleanUpSetQueries[`${ONYXKEYS.COLLECTION.REPORT_DRAFT_COMMENT}${reportID}`] = null; cleanUpSetQueries[`${ONYXKEYS.COLLECTION.REPORT_ACTIONS_DRAFTS}${reportID}`] = null; }); - Onyx.mergeCollection(ONYXKEYS.COLLECTION.REPORT, cleanUpMergeQueries); - Onyx.multiSet(cleanUpSetQueries); + void Onyx.mergeCollection(ONYXKEYS.COLLECTION.REPORT, cleanUpMergeQueries); + void Onyx.multiSet(cleanUpSetQueries); delete allPolicies[key]; return; } @@ -295,7 +295,7 @@ Onyx.connect({ * Stores in Onyx the policy ID of the last workspace that was accessed by the user */ function updateLastAccessedWorkspace(policyID: OnyxEntry) { - Onyx.set(ONYXKEYS.LAST_ACCESSED_WORKSPACE_POLICY_ID, policyID ?? null); + void Onyx.set(ONYXKEYS.LAST_ACCESSED_WORKSPACE_POLICY_ID, policyID ?? null); } /** @@ -595,7 +595,7 @@ function deleteWorkspace( const params: DeleteWorkspaceParams = {policyID}; - API.write(WRITE_COMMANDS.DELETE_WORKSPACE, params, {optimisticData, finallyData, failureData}); + void API.write(WRITE_COMMANDS.DELETE_WORKSPACE, params, {optimisticData, finallyData, failureData}); // Reset the lastAccessedWorkspacePolicyID if (policyID === lastAccessedWorkspacePolicyID) { @@ -662,7 +662,7 @@ function setWorkspaceAutoReportingFrequency(policyID: string, frequency: ValueOf ]; const params: SetWorkspaceAutoReportingFrequencyParams = {policyID, frequency}; - API.write(WRITE_COMMANDS.SET_WORKSPACE_AUTO_REPORTING_FREQUENCY, params, {optimisticData, failureData, successData}); + void API.write(WRITE_COMMANDS.SET_WORKSPACE_AUTO_REPORTING_FREQUENCY, params, {optimisticData, failureData, successData}); } function setWorkspaceAutoReportingMonthlyOffset(policyID: string | undefined, autoReportingOffset: number | ValueOf) { @@ -708,7 +708,7 @@ function setWorkspaceAutoReportingMonthlyOffset(policyID: string | undefined, au ]; const params: SetWorkspaceAutoReportingMonthlyOffsetParams = {policyID, value}; - API.write(WRITE_COMMANDS.SET_WORKSPACE_AUTO_REPORTING_MONTHLY_OFFSET, params, {optimisticData, failureData, successData}); + void API.write(WRITE_COMMANDS.SET_WORKSPACE_AUTO_REPORTING_MONTHLY_OFFSET, params, {optimisticData, failureData, successData}); } function setWorkspaceApprovalMode(policyID: string, approver: string, approvalMode: ValueOf) { @@ -776,7 +776,7 @@ function setWorkspaceApprovalMode(policyID: string, approver: string, approvalMo isAutoApprovalEnabled: false, }), }; - API.write(WRITE_COMMANDS.SET_WORKSPACE_APPROVAL_MODE, params, {optimisticData, failureData, successData}); + void API.write(WRITE_COMMANDS.SET_WORKSPACE_APPROVAL_MODE, params, {optimisticData, failureData, successData}); } function setWorkspacePayer(policyID: string, reimburserEmail: string) { @@ -822,52 +822,52 @@ function setWorkspacePayer(policyID: string, reimburserEmail: string) { const params: SetWorkspacePayerParams = {policyID, reimburserEmail}; - API.write(WRITE_COMMANDS.SET_WORKSPACE_PAYER, params, {optimisticData, failureData, successData}); + void API.write(WRITE_COMMANDS.SET_WORKSPACE_PAYER, params, {optimisticData, failureData, successData}); } function clearPolicyErrorField(policyID: string | undefined, fieldName: string) { if (!policyID) { return; } - Onyx.merge(`${ONYXKEYS.COLLECTION.POLICY}${policyID}`, {errorFields: {[fieldName]: null}}); + void Onyx.merge(`${ONYXKEYS.COLLECTION.POLICY}${policyID}`, {errorFields: {[fieldName]: null}}); } function clearQBOErrorField(policyID: string | undefined, fieldName: string) { if (!policyID) { return; } - Onyx.merge(`${ONYXKEYS.COLLECTION.POLICY}${policyID}`, {connections: {quickbooksOnline: {config: {errorFields: {[fieldName]: null}}}}}); + void Onyx.merge(`${ONYXKEYS.COLLECTION.POLICY}${policyID}`, {connections: {quickbooksOnline: {config: {errorFields: {[fieldName]: null}}}}}); } function clearQBDErrorField(policyID: string | undefined, fieldName: string) { if (!policyID) { return; } - Onyx.merge(`${ONYXKEYS.COLLECTION.POLICY}${policyID}`, {connections: {quickbooksDesktop: {config: {errorFields: {[fieldName]: null}}}}}); + void Onyx.merge(`${ONYXKEYS.COLLECTION.POLICY}${policyID}`, {connections: {quickbooksDesktop: {config: {errorFields: {[fieldName]: null}}}}}); } function clearXeroErrorField(policyID: string | undefined, fieldName: string) { if (!policyID) { return; } - Onyx.merge(`${ONYXKEYS.COLLECTION.POLICY}${policyID}`, {connections: {xero: {config: {errorFields: {[fieldName]: null}}}}}); + void Onyx.merge(`${ONYXKEYS.COLLECTION.POLICY}${policyID}`, {connections: {xero: {config: {errorFields: {[fieldName]: null}}}}}); } function clearNetSuiteErrorField(policyID: string | undefined, fieldName: string) { if (!policyID) { return; } - Onyx.merge(`${ONYXKEYS.COLLECTION.POLICY}${policyID}`, {connections: {netsuite: {options: {config: {errorFields: {[fieldName]: null}}}}}}); + void Onyx.merge(`${ONYXKEYS.COLLECTION.POLICY}${policyID}`, {connections: {netsuite: {options: {config: {errorFields: {[fieldName]: null}}}}}}); } function clearNetSuitePendingField(policyID: string, fieldName: string) { - Onyx.merge(`${ONYXKEYS.COLLECTION.POLICY}${policyID}`, {connections: {netsuite: {options: {config: {pendingFields: {[fieldName]: null}}}}}}); + void Onyx.merge(`${ONYXKEYS.COLLECTION.POLICY}${policyID}`, {connections: {netsuite: {options: {config: {pendingFields: {[fieldName]: null}}}}}}); } function removeNetSuiteCustomFieldByIndex(allRecords: NetSuiteCustomSegment[] | NetSuiteCustomList[], policyID: string, importCustomField: string, valueIndex: number) { // We allow multiple custom list records with the same internalID. Hence it is safe to remove by index. const filteredRecords = allRecords.filter((_, index) => index !== Number(valueIndex)); - Onyx.merge(`${ONYXKEYS.COLLECTION.POLICY}${policyID}`, { + void Onyx.merge(`${ONYXKEYS.COLLECTION.POLICY}${policyID}`, { connections: { netsuite: { options: { @@ -886,15 +886,15 @@ function clearSageIntacctErrorField(policyID: string | undefined, fieldName: str if (!policyID) { return; } - Onyx.merge(`${ONYXKEYS.COLLECTION.POLICY}${policyID}`, {connections: {intacct: {config: {errorFields: {[fieldName]: null}}}}}); + void Onyx.merge(`${ONYXKEYS.COLLECTION.POLICY}${policyID}`, {connections: {intacct: {config: {errorFields: {[fieldName]: null}}}}}); } function clearNetSuiteAutoSyncErrorField(policyID: string | undefined) { - Onyx.merge(`${ONYXKEYS.COLLECTION.POLICY}${policyID}`, {connections: {netsuite: {config: {errorFields: {autoSync: null}}}}}); + void Onyx.merge(`${ONYXKEYS.COLLECTION.POLICY}${policyID}`, {connections: {netsuite: {config: {errorFields: {autoSync: null}}}}}); } function clearQuickbooksOnlineAutoSyncErrorField(policyID: string | undefined) { - Onyx.merge(`${ONYXKEYS.COLLECTION.POLICY}${policyID}`, {connections: {quickbooksOnline: {config: {errorFields: {autoSync: null}}}}}); + void Onyx.merge(`${ONYXKEYS.COLLECTION.POLICY}${policyID}`, {connections: {quickbooksOnline: {config: {errorFields: {autoSync: null}}}}}); } function setWorkspaceReimbursement({policyID, reimbursementChoice, bankAccountID, reimburserEmail}: SetWorkspaceReimbursementActionParams) { @@ -945,7 +945,7 @@ function setWorkspaceReimbursement({policyID, reimbursementChoice, bankAccountID const params: SetWorkspaceReimbursementParams = {policyID, reimbursementChoice, bankAccountID}; - API.write(WRITE_COMMANDS.SET_WORKSPACE_REIMBURSEMENT, params, {optimisticData, failureData, successData}); + void API.write(WRITE_COMMANDS.SET_WORKSPACE_REIMBURSEMENT, params, {optimisticData, failureData, successData}); } function leaveWorkspace(policyID?: string) { @@ -1040,7 +1040,7 @@ function leaveWorkspace(policyID?: string) { policyID, email: sessionEmail, }; - API.write(WRITE_COMMANDS.LEAVE_POLICY, params, {optimisticData, successData, failureData}); + void API.write(WRITE_COMMANDS.LEAVE_POLICY, params, {optimisticData, successData, failureData}); } function addBillingCardAndRequestPolicyOwnerChange( @@ -1124,7 +1124,7 @@ function addBillingCardAndRequestPolicyOwnerChange( currency: currency as ValueOf, }; // eslint-disable-next-line rulesdir/no-multiple-api-calls - API.write(WRITE_COMMANDS.ADD_BILLING_CARD_AND_REQUEST_WORKSPACE_OWNER_CHANGE, params, {optimisticData, successData, failureData}); + void API.write(WRITE_COMMANDS.ADD_BILLING_CARD_AND_REQUEST_WORKSPACE_OWNER_CHANGE, params, {optimisticData, successData, failureData}); } } @@ -1171,7 +1171,7 @@ function verifySetupIntentAndRequestPolicyOwnerChange(policyID: string) { }, }, ]; - API.write(WRITE_COMMANDS.VERIFY_SETUP_INTENT_AND_REQUEST_POLICY_OWNER_CHANGE, {accountID: sessionAccountID, policyID}, {optimisticData, successData, failureData}); + void API.write(WRITE_COMMANDS.VERIFY_SETUP_INTENT_AND_REQUEST_POLICY_OWNER_CHANGE, {accountID: sessionAccountID, policyID}, {optimisticData, successData, failureData}); } /** @@ -1394,7 +1394,7 @@ function updateWorkspaceAvatar(policyID: string, file: File) { file, }; - API.write(WRITE_COMMANDS.UPDATE_WORKSPACE_AVATAR, params, {optimisticData, finallyData, failureData}); + void API.write(WRITE_COMMANDS.UPDATE_WORKSPACE_AVATAR, params, {optimisticData, finallyData, failureData}); } /** @@ -1447,14 +1447,14 @@ function deleteWorkspaceAvatar(policyID: string) { const params: DeleteWorkspaceAvatarParams = {policyID}; - API.write(WRITE_COMMANDS.DELETE_WORKSPACE_AVATAR, params, {optimisticData, finallyData, failureData}); + void API.write(WRITE_COMMANDS.DELETE_WORKSPACE_AVATAR, params, {optimisticData, finallyData, failureData}); } /** * Clear error and pending fields for the workspace avatar */ function clearAvatarErrors(policyID: string) { - Onyx.merge(`${ONYXKEYS.COLLECTION.POLICY}${policyID}`, { + void Onyx.merge(`${ONYXKEYS.COLLECTION.POLICY}${policyID}`, { errorFields: { avatarURL: null, }, @@ -1610,7 +1610,7 @@ function updateGeneralSettings(policyID: string | undefined, name: string, curre policyName: name, }, }; - Onyx.merge(`${ONYXKEYS.COLLECTION.POLICY}${policyID}`, { + void Onyx.merge(`${ONYXKEYS.COLLECTION.POLICY}${policyID}`, { name, }); @@ -1618,7 +1618,7 @@ function updateGeneralSettings(policyID: string | undefined, name: string, curre return; } - API.write(WRITE_COMMANDS.UPDATE_WORKSPACE_GENERAL_SETTINGS, params, { + void API.write(WRITE_COMMANDS.UPDATE_WORKSPACE_GENERAL_SETTINGS, params, { optimisticData, finallyData, failureData, @@ -1674,7 +1674,7 @@ function updateWorkspaceDescription(policyID: string, description: string, curre description: parsedDescription, }; - API.write(WRITE_COMMANDS.UPDATE_WORKSPACE_DESCRIPTION, params, { + void API.write(WRITE_COMMANDS.UPDATE_WORKSPACE_DESCRIPTION, params, { optimisticData, finallyData, failureData, @@ -1686,8 +1686,8 @@ function setWorkspaceErrors(policyID: string, errors: Errors) { return; } - Onyx.merge(`${ONYXKEYS.COLLECTION.POLICY}${policyID}`, {errors: null}); - Onyx.merge(`${ONYXKEYS.COLLECTION.POLICY}${policyID}`, {errors}); + void Onyx.merge(`${ONYXKEYS.COLLECTION.POLICY}${policyID}`, {errors: null}); + void Onyx.merge(`${ONYXKEYS.COLLECTION.POLICY}${policyID}`, {errors}); } function hideWorkspaceAlertMessage(policyID: string) { @@ -1695,7 +1695,7 @@ function hideWorkspaceAlertMessage(policyID: string) { return; } - Onyx.merge(`${ONYXKEYS.COLLECTION.POLICY}${policyID}`, {alertMessage: ''}); + void Onyx.merge(`${ONYXKEYS.COLLECTION.POLICY}${policyID}`, {alertMessage: ''}); } function updateAddress(policyID: string, newAddress: CompanyAddress) { @@ -1740,7 +1740,7 @@ function updateAddress(policyID: string, newAddress: CompanyAddress) { }, ]; - API.write(WRITE_COMMANDS.UPDATE_POLICY_ADDRESS, parameters, { + void API.write(WRITE_COMMANDS.UPDATE_POLICY_ADDRESS, parameters, { optimisticData, finallyData, }); @@ -1750,7 +1750,7 @@ function updateAddress(policyID: string, newAddress: CompanyAddress) { * Removes an error after trying to delete a workspace */ function clearDeleteWorkspaceError(policyID: string) { - Onyx.merge(`${ONYXKEYS.COLLECTION.POLICY}${policyID}`, { + void Onyx.merge(`${ONYXKEYS.COLLECTION.POLICY}${policyID}`, { pendingAction: null, errors: null, }); @@ -1760,15 +1760,15 @@ function clearDeleteWorkspaceError(policyID: string) { * Removes the workspace after failure to create. */ function removeWorkspace(policyID: string) { - Onyx.set(`${ONYXKEYS.COLLECTION.POLICY}${policyID}`, null); + void Onyx.set(`${ONYXKEYS.COLLECTION.POLICY}${policyID}`, null); } function setDuplicateWorkspaceData(data: Partial) { - Onyx.merge(ONYXKEYS.DUPLICATE_WORKSPACE, {...data}); + void Onyx.merge(ONYXKEYS.DUPLICATE_WORKSPACE, {...data}); } function clearDuplicateWorkspace() { - Onyx.set(ONYXKEYS.DUPLICATE_WORKSPACE, {}); + void Onyx.set(ONYXKEYS.DUPLICATE_WORKSPACE, {}); } /** @@ -2398,7 +2398,7 @@ function createWorkspace(options: BuildPolicyDataOptions = {}): CreateWorkspaceP const {optimisticData, failureData, successData, params} = buildPolicyData(optionsWithDefaults); - API.write(WRITE_COMMANDS.CREATE_WORKSPACE, params, {optimisticData, successData, failureData}); + void API.write(WRITE_COMMANDS.CREATE_WORKSPACE, params, {optimisticData, successData, failureData}); // Publish a workspace created event if this is their first policy if (getAdminPolicies().length === 0) { @@ -2801,7 +2801,7 @@ function buildDuplicatePolicyData(policy: Policy, options: DuplicatePolicyDataOp function duplicateWorkspace(policy: Policy, options: DuplicatePolicyDataOptions): DuplicateWorkspaceParams { const {optimisticData, failureData, successData, params} = buildDuplicatePolicyData(policy, options); - API.write(WRITE_COMMANDS.DUPLICATE_POLICY, params, {optimisticData, successData, failureData}); + void API.write(WRITE_COMMANDS.DUPLICATE_POLICY, params, {optimisticData, successData, failureData}); return params; } @@ -2899,7 +2899,7 @@ function removePolicyReceiptPartnersConnection(policyID: string, partnerName: st policyID, partnerName, }; - API.write(WRITE_COMMANDS.DISCONNECT_WORKSPACE_RECEIPT_PARTNER, parameters, {optimisticData, failureData, successData}); + void API.write(WRITE_COMMANDS.DISCONNECT_WORKSPACE_RECEIPT_PARTNER, parameters, {optimisticData, failureData, successData}); } function togglePolicyUberAutoInvite(policyID: string | undefined, enabled: boolean) { @@ -2934,7 +2934,7 @@ function togglePolicyUberAutoInvite(policyID: string | undefined, enabled: boole const params: TogglePolicyUberAutoInvitePageParams = {policyID, enabled}; - API.write(WRITE_COMMANDS.TOGGLE_WORKSPACE_UBER_AUTO_INVITE, params, {optimisticData, successData, failureData}); + void API.write(WRITE_COMMANDS.TOGGLE_WORKSPACE_UBER_AUTO_INVITE, params, {optimisticData, successData, failureData}); } function togglePolicyUberAutoRemove(policyID: string | undefined, enabled: boolean) { @@ -2969,7 +2969,7 @@ function togglePolicyUberAutoRemove(policyID: string | undefined, enabled: boole const params: TogglePolicyUberAutoRemovePageParams = {policyID, enabled}; - API.write(WRITE_COMMANDS.TOGGLE_WORKSPACE_UBER_AUTO_REMOVE, params, {optimisticData, successData, failureData}); + void API.write(WRITE_COMMANDS.TOGGLE_WORKSPACE_UBER_AUTO_REMOVE, params, {optimisticData, successData, failureData}); } /** @@ -3041,7 +3041,7 @@ function inviteWorkspaceEmployeesToUber(policyID: string, emails: string[]) { }, ]; - API.write(WRITE_COMMANDS.INVITE_WORKSPACE_EMPLOYEES_TO_UBER, params, {optimisticData, successData, failureData}); + void API.write(WRITE_COMMANDS.INVITE_WORKSPACE_EMPLOYEES_TO_UBER, params, {optimisticData, successData, failureData}); } /** @@ -3164,7 +3164,7 @@ function requestExpensifyCardLimitIncrease(settlementBankAccountID?: number) { settlementBankAccountID, }; - API.write(WRITE_COMMANDS.REQUEST_EXPENSIFY_CARD_LIMIT_INCREASE, params); + void API.write(WRITE_COMMANDS.REQUEST_EXPENSIFY_CARD_LIMIT_INCREASE, params); } function updateMemberCustomField(policyID: string, login: string, customFieldType: CustomFieldType, value: string) { @@ -3208,15 +3208,15 @@ function updateMemberCustomField(policyID: string, login: string, customFieldTyp const params: UpdatePolicyMembersCustomFieldsParams = {policyID, employees: JSON.stringify([{email: login, [customFieldType]: value}])}; - API.write(WRITE_COMMANDS.UPDATE_POLICY_MEMBERS_CUSTOM_FIELDS, params, {optimisticData, successData, failureData}); + void API.write(WRITE_COMMANDS.UPDATE_POLICY_MEMBERS_CUSTOM_FIELDS, params, {optimisticData, successData, failureData}); } function setWorkspaceInviteMessageDraft(policyID: string, message: string | null) { - Onyx.set(`${ONYXKEYS.COLLECTION.WORKSPACE_INVITE_MESSAGE_DRAFT}${policyID}`, message); + void Onyx.set(`${ONYXKEYS.COLLECTION.WORKSPACE_INVITE_MESSAGE_DRAFT}${policyID}`, message); } function clearErrors(policyID: string) { - Onyx.merge(`${ONYXKEYS.COLLECTION.POLICY}${policyID}`, {errors: null}); + void Onyx.merge(`${ONYXKEYS.COLLECTION.POLICY}${policyID}`, {errors: null}); hideWorkspaceAlertMessage(policyID); } @@ -3224,7 +3224,7 @@ function clearErrors(policyID: string) { * Dismiss the informative messages about which policy members were added with primary logins when invited with their secondary login. */ function dismissAddedWithPrimaryLoginMessages(policyID: string) { - Onyx.merge(`${ONYXKEYS.COLLECTION.POLICY}${policyID}`, {primaryLoginsInvited: null}); + void Onyx.merge(`${ONYXKEYS.COLLECTION.POLICY}${policyID}`, {primaryLoginsInvited: null}); } function buildOptimisticRecentlyUsedCurrencies(currency?: string) { @@ -3705,7 +3705,7 @@ function createWorkspaceFromIOUPayment(iouReport: OnyxEntry): WorkspaceF expenseMovedReportActionID: movedIouReportAction.reportActionID, }; - API.write(WRITE_COMMANDS.CREATE_WORKSPACE_FROM_IOU_PAYMENT, params, {optimisticData, successData, failureData}); + void API.write(WRITE_COMMANDS.CREATE_WORKSPACE_FROM_IOU_PAYMENT, params, {optimisticData, successData, failureData}); return {policyID, workspaceChatReportID: memberData.workspaceChatReportID, reportPreviewReportActionID: reportPreview?.reportActionID, adminsChatReportID}; } @@ -3751,7 +3751,7 @@ function enablePolicyConnections(policyID: string, enabled: boolean) { const parameters: EnablePolicyConnectionsParams = {policyID, enabled}; - API.writeWithNoDuplicatesEnableFeatureConflicts(WRITE_COMMANDS.ENABLE_POLICY_CONNECTIONS, parameters, onyxData); + void API.writeWithNoDuplicatesEnableFeatureConflicts(WRITE_COMMANDS.ENABLE_POLICY_CONNECTIONS, parameters, onyxData); if (enabled && getIsNarrowLayout()) { goBackWhenEnableFeature(policyID); @@ -3805,7 +3805,7 @@ function enablePolicyReceiptPartners(policyID: string, enabled: boolean, shouldN const parameters: TogglePolicyReceiptPartnersParams = {policyID, enabled}; - API.write(WRITE_COMMANDS.TOGGLE_RECEIPT_PARTNERS, parameters, onyxData); + void API.write(WRITE_COMMANDS.TOGGLE_RECEIPT_PARTNERS, parameters, onyxData); if (enabled && shouldNavigateToReceiptPartnersPage) { navigateToReceiptPartnersPage(policyID); @@ -3819,7 +3819,7 @@ function enablePolicyReceiptPartners(policyID: string, enabled: boolean, shouldN /** Save the preferred export method for a policy */ function savePreferredExportMethod(policyID: string, exportMethod: ReportExportType) { - Onyx.merge(`${ONYXKEYS.LAST_EXPORT_METHOD}`, {[policyID]: exportMethod}); + void Onyx.merge(`${ONYXKEYS.LAST_EXPORT_METHOD}`, {[policyID]: exportMethod}); } function enableExpensifyCard(policyID: string, enabled: boolean, shouldNavigateToExpensifyCardPage = false) { @@ -3867,7 +3867,7 @@ function enableExpensifyCard(policyID: string, enabled: boolean, shouldNavigateT const parameters: EnablePolicyExpensifyCardsParams = {authToken, policyID, enabled}; - API.writeWithNoDuplicatesEnableFeatureConflicts(WRITE_COMMANDS.ENABLE_POLICY_EXPENSIFY_CARDS, parameters, onyxData); + void API.writeWithNoDuplicatesEnableFeatureConflicts(WRITE_COMMANDS.ENABLE_POLICY_EXPENSIFY_CARDS, parameters, onyxData); if (enabled && shouldNavigateToExpensifyCardPage) { navigateToExpensifyCardPage(policyID); @@ -3922,7 +3922,7 @@ function enableCompanyCards(policyID: string, enabled: boolean, shouldGoBack = t const parameters: EnablePolicyCompanyCardsParams = {authToken, policyID, enabled}; - API.writeWithNoDuplicatesEnableFeatureConflicts(WRITE_COMMANDS.ENABLE_POLICY_COMPANY_CARDS, parameters, onyxData); + void API.writeWithNoDuplicatesEnableFeatureConflicts(WRITE_COMMANDS.ENABLE_POLICY_COMPANY_CARDS, parameters, onyxData); if (enabled && getIsNarrowLayout() && shouldGoBack) { goBackWhenEnableFeature(policyID); @@ -3970,7 +3970,7 @@ function enablePolicyReportFields(policyID: string, enabled: boolean) { const parameters: EnablePolicyReportFieldsParams = {policyID, enabled}; - API.writeWithNoDuplicatesEnableFeatureConflicts(WRITE_COMMANDS.ENABLE_POLICY_REPORT_FIELDS, parameters, onyxData); + void API.writeWithNoDuplicatesEnableFeatureConflicts(WRITE_COMMANDS.ENABLE_POLICY_REPORT_FIELDS, parameters, onyxData); } function enablePolicyTaxes(policyID: string, enabled: boolean) { @@ -4088,7 +4088,7 @@ function enablePolicyTaxes(policyID: string, enabled: boolean) { if (shouldAddDefaultTaxRatesData) { parameters.taxFields = JSON.stringify(defaultTaxRates); } - API.writeWithNoDuplicatesEnableFeatureConflicts(WRITE_COMMANDS.ENABLE_POLICY_TAXES, parameters, onyxData); + void API.writeWithNoDuplicatesEnableFeatureConflicts(WRITE_COMMANDS.ENABLE_POLICY_TAXES, parameters, onyxData); if (enabled && getIsNarrowLayout()) { goBackWhenEnableFeature(policyID); @@ -4191,7 +4191,7 @@ function enablePolicyWorkflows(policyID: string, enabled: boolean) { setWorkspaceAutoReportingFrequency(policyID, CONST.POLICY.AUTO_REPORTING_FREQUENCIES.INSTANT); } - API.writeWithNoDuplicatesEnableFeatureConflicts(WRITE_COMMANDS.ENABLE_POLICY_WORKFLOWS, parameters, onyxData); + void API.writeWithNoDuplicatesEnableFeatureConflicts(WRITE_COMMANDS.ENABLE_POLICY_WORKFLOWS, parameters, onyxData); if (enabled && getIsNarrowLayout()) { goBackWhenEnableFeature(policyID); @@ -4264,7 +4264,7 @@ function enablePolicyRules(policyID: string, enabled: boolean, shouldGoBack = tr } const parameters: SetPolicyRulesEnabledParams = {policyID, enabled}; - API.writeWithNoDuplicatesEnableFeatureConflicts(WRITE_COMMANDS.SET_POLICY_RULES_ENABLED, parameters, onyxData); + void API.writeWithNoDuplicatesEnableFeatureConflicts(WRITE_COMMANDS.SET_POLICY_RULES_ENABLED, parameters, onyxData); if (enabled && getIsNarrowLayout() && shouldGoBack) { goBackWhenEnableFeature(policyID); @@ -4333,7 +4333,7 @@ function enableDistanceRequestTax(policyID: string, customUnitName: string, cust attributes, }), }; - API.write(WRITE_COMMANDS.ENABLE_DISTANCE_REQUEST_TAX, params, onyxData); + void API.write(WRITE_COMMANDS.ENABLE_DISTANCE_REQUEST_TAX, params, onyxData); } function enablePolicyInvoicing(policyID: string, enabled: boolean) { @@ -4377,7 +4377,7 @@ function enablePolicyInvoicing(policyID: string, enabled: boolean) { const parameters: EnablePolicyInvoicingParams = {policyID, enabled}; - API.writeWithNoDuplicatesEnableFeatureConflicts(WRITE_COMMANDS.ENABLE_POLICY_INVOICING, parameters, onyxData); + void API.writeWithNoDuplicatesEnableFeatureConflicts(WRITE_COMMANDS.ENABLE_POLICY_INVOICING, parameters, onyxData); if (enabled && getIsNarrowLayout()) { goBackWhenEnableFeature(policyID); @@ -4459,7 +4459,7 @@ function setPolicyCustomTaxName(policyID: string, customTaxName: string) { customTaxName, }; - API.write(WRITE_COMMANDS.SET_POLICY_CUSTOM_TAX_NAME, parameters, onyxData); + void API.write(WRITE_COMMANDS.SET_POLICY_CUSTOM_TAX_NAME, parameters, onyxData); } function setWorkspaceCurrencyDefault(policyID: string, taxCode: string) { @@ -4513,7 +4513,7 @@ function setWorkspaceCurrencyDefault(policyID: string, taxCode: string) { taxCode, }; - API.write(WRITE_COMMANDS.SET_POLICY_TAXES_CURRENCY_DEFAULT, parameters, onyxData); + void API.write(WRITE_COMMANDS.SET_POLICY_TAXES_CURRENCY_DEFAULT, parameters, onyxData); } function setForeignCurrencyDefault(policyID: string, taxCode: string) { @@ -4567,7 +4567,7 @@ function setForeignCurrencyDefault(policyID: string, taxCode: string) { taxCode, }; - API.write(WRITE_COMMANDS.SET_POLICY_TAXES_FOREIGN_CURRENCY_DEFAULT, parameters, onyxData); + void API.write(WRITE_COMMANDS.SET_POLICY_TAXES_FOREIGN_CURRENCY_DEFAULT, parameters, onyxData); } function upgradeToCorporate(policyID: string, featureName?: string) { @@ -4622,7 +4622,7 @@ function upgradeToCorporate(policyID: string, featureName?: string) { const parameters: UpgradeToCorporateParams = {policyID, ...(featureName ? {featureName} : {})}; - API.write(WRITE_COMMANDS.UPGRADE_TO_CORPORATE, parameters, {optimisticData, successData, failureData}); + void API.write(WRITE_COMMANDS.UPGRADE_TO_CORPORATE, parameters, {optimisticData, successData, failureData}); } function downgradeToTeam(policyID: string) { @@ -4665,7 +4665,7 @@ function downgradeToTeam(policyID: string) { const parameters: DowngradeToTeamParams = {policyID}; - API.write(WRITE_COMMANDS.DOWNGRADE_TO_TEAM, parameters, {optimisticData, successData, failureData}); + void API.write(WRITE_COMMANDS.DOWNGRADE_TO_TEAM, parameters, {optimisticData, successData, failureData}); } function setWorkspaceDefaultSpendCategory(policyID: string, groupID: string, category: string) { @@ -4731,7 +4731,7 @@ function setWorkspaceDefaultSpendCategory(policyID: string, groupID: string, cat ] : []; - API.write(WRITE_COMMANDS.SET_WORKSPACE_DEFAULT_SPEND_CATEGORY, {policyID, groupID, category}, {optimisticData, successData, failureData}); + void API.write(WRITE_COMMANDS.SET_WORKSPACE_DEFAULT_SPEND_CATEGORY, {policyID, groupID, category}, {optimisticData, successData, failureData}); } /** * Call the API to set the receipt required amount for the given policy @@ -4786,7 +4786,7 @@ function setPolicyMaxExpenseAmountNoReceipt(policyID: string, maxExpenseAmountNo maxExpenseAmountNoReceipt: parsedMaxExpenseAmountNoReceipt, }; - API.write(WRITE_COMMANDS.SET_POLICY_EXPENSE_MAX_AMOUNT_NO_RECEIPT, parameters, onyxData); + void API.write(WRITE_COMMANDS.SET_POLICY_EXPENSE_MAX_AMOUNT_NO_RECEIPT, parameters, onyxData); } /** @@ -4842,7 +4842,7 @@ function setPolicyMaxExpenseAmount(policyID: string, maxExpenseAmount: string) { maxExpenseAmount: parsedMaxExpenseAmount, }; - API.write(WRITE_COMMANDS.SET_POLICY_EXPENSE_MAX_AMOUNT, parameters, onyxData); + void API.write(WRITE_COMMANDS.SET_POLICY_EXPENSE_MAX_AMOUNT, parameters, onyxData); } /** @@ -4908,7 +4908,7 @@ function setPolicyProhibitedExpense(policyID: string, prohibitedExpense: keyof P prohibitedExpenses: JSON.stringify(prohibitedExpensesWithoutPendingFields), }; - API.write(WRITE_COMMANDS.SET_POLICY_PROHIBITED_EXPENSES, parameters, onyxData); + void API.write(WRITE_COMMANDS.SET_POLICY_PROHIBITED_EXPENSES, parameters, onyxData); } /** @@ -4965,7 +4965,7 @@ function setPolicyMaxExpenseAge(policyID: string, maxExpenseAge: string) { maxExpenseAge: parsedMaxExpenseAge, }; - API.write(WRITE_COMMANDS.SET_POLICY_EXPENSE_MAX_AGE, parameters, onyxData); + void API.write(WRITE_COMMANDS.SET_POLICY_EXPENSE_MAX_AGE, parameters, onyxData); } /** @@ -5030,7 +5030,7 @@ function updateCustomRules(policyID: string, customRules: string) { description: parsedCustomRules, }; - API.write(WRITE_COMMANDS.UPDATE_CUSTOM_RULES, parameters, onyxData); + void API.write(WRITE_COMMANDS.UPDATE_CUSTOM_RULES, parameters, onyxData); } /** @@ -5098,7 +5098,7 @@ function setPolicyBillableMode(policyID: string, defaultBillable: boolean) { }), }; - API.write(WRITE_COMMANDS.SET_POLICY_BILLABLE_MODE, parameters, onyxData); + void API.write(WRITE_COMMANDS.SET_POLICY_BILLABLE_MODE, parameters, onyxData); } function getCashExpenseReimbursableMode(policyID: string): PolicyCashExpenseMode | undefined { @@ -5191,7 +5191,7 @@ function setPolicyReimbursableMode(policyID: string, reimbursableMode: PolicyCas }), }; - API.write(WRITE_COMMANDS.SET_POLICY_REIMBURSABLE_MODE, parameters, onyxData); + void API.write(WRITE_COMMANDS.SET_POLICY_REIMBURSABLE_MODE, parameters, onyxData); } /** @@ -5246,7 +5246,7 @@ function disableWorkspaceBillableExpenses(policyID: string) { policyID, }; - API.write(WRITE_COMMANDS.DISABLE_POLICY_BILLABLE_MODE, parameters, onyxData); + void API.write(WRITE_COMMANDS.DISABLE_POLICY_BILLABLE_MODE, parameters, onyxData); } function getWorkspaceEReceiptsEnabledOnyxData(policyID: string, enabled: boolean): OnyxData { @@ -5302,7 +5302,7 @@ function setWorkspaceEReceiptsEnabled(policyID: string, enabled: boolean) { enabled, }; - API.write(WRITE_COMMANDS.SET_WORKSPACE_ERECEIPTS_ENABLED, parameters, onyxData); + void API.write(WRITE_COMMANDS.SET_WORKSPACE_ERECEIPTS_ENABLED, parameters, onyxData); } function setPolicyAttendeeTrackingEnabled(policyID: string, isAttendeeTrackingEnabled: boolean) { @@ -5355,7 +5355,7 @@ function setPolicyAttendeeTrackingEnabled(policyID: string, isAttendeeTrackingEn enabled: isAttendeeTrackingEnabled, }; - API.write(WRITE_COMMANDS.SET_POLICY_ATTENDEE_TRACKING_ENABLED, parameters, onyxData); + void API.write(WRITE_COMMANDS.SET_POLICY_ATTENDEE_TRACKING_ENABLED, parameters, onyxData); } function getAdminPolicies(): Policy[] { @@ -5438,7 +5438,7 @@ function setPolicyDefaultReportTitle(policyID: string, customName: string) { policyID, }; - API.write(WRITE_COMMANDS.SET_POLICY_DEFAULT_REPORT_TITLE, parameters, { + void API.write(WRITE_COMMANDS.SET_POLICY_DEFAULT_REPORT_TITLE, parameters, { optimisticData, successData, failureData, @@ -5506,7 +5506,7 @@ function setPolicyPreventMemberCreatedTitle(policyID: string, enforced: boolean) policyID, }; - API.write(WRITE_COMMANDS.SET_POLICY_PREVENT_MEMBER_CREATED_TITLE, parameters, { + void API.write(WRITE_COMMANDS.SET_POLICY_PREVENT_MEMBER_CREATED_TITLE, parameters, { optimisticData, successData, failureData, @@ -5574,7 +5574,7 @@ function setPolicyPreventSelfApproval(policyID: string, preventSelfApproval: boo policyID, }; - API.write(WRITE_COMMANDS.SET_POLICY_PREVENT_SELF_APPROVAL, parameters, { + void API.write(WRITE_COMMANDS.SET_POLICY_PREVENT_SELF_APPROVAL, parameters, { optimisticData, successData, failureData, @@ -5649,7 +5649,7 @@ function setPolicyAutomaticApprovalLimit(policyID: string, limit: string) { policyID, }; - API.write(WRITE_COMMANDS.SET_POLICY_AUTOMATIC_APPROVAL_LIMIT, parameters, { + void API.write(WRITE_COMMANDS.SET_POLICY_AUTOMATIC_APPROVAL_LIMIT, parameters, { optimisticData, successData, failureData, @@ -5726,7 +5726,7 @@ function setPolicyAutomaticApprovalRate(policyID: string, auditRate: string) { policyID, }; - API.write(WRITE_COMMANDS.SET_POLICY_AUTOMATIC_APPROVAL_RATE, parameters, { + void API.write(WRITE_COMMANDS.SET_POLICY_AUTOMATIC_APPROVAL_RATE, parameters, { optimisticData, successData, failureData, @@ -5804,7 +5804,7 @@ function enableAutoApprovalOptions(policyID: string, enabled: boolean) { policyID, }; - API.write(WRITE_COMMANDS.ENABLE_POLICY_AUTO_APPROVAL_OPTIONS, parameters, { + void API.write(WRITE_COMMANDS.ENABLE_POLICY_AUTO_APPROVAL_OPTIONS, parameters, { optimisticData, successData, failureData, @@ -5876,7 +5876,7 @@ function setPolicyAutoReimbursementLimit(policyID: string, limit: string) { policyID, }; - API.write(WRITE_COMMANDS.SET_POLICY_AUTO_REIMBURSEMENT_LIMIT, parameters, { + void API.write(WRITE_COMMANDS.SET_POLICY_AUTO_REIMBURSEMENT_LIMIT, parameters, { optimisticData, successData, failureData, @@ -5952,7 +5952,7 @@ function enablePolicyAutoReimbursementLimit(policyID: string, enabled: boolean) policyID, }; - API.write(WRITE_COMMANDS.ENABLE_POLICY_AUTO_REIMBURSEMENT_LIMIT, parameters, { + void API.write(WRITE_COMMANDS.ENABLE_POLICY_AUTO_REIMBURSEMENT_LIMIT, parameters, { optimisticData, successData, failureData, @@ -6027,7 +6027,7 @@ function updateInvoiceCompanyName(policyID: string, companyName: string) { companyName, }; - API.write(WRITE_COMMANDS.UPDATE_INVOICE_COMPANY_NAME, parameters, {optimisticData, successData, failureData}); + void API.write(WRITE_COMMANDS.UPDATE_INVOICE_COMPANY_NAME, parameters, {optimisticData, successData, failureData}); } function updateInvoiceCompanyWebsite(policyID: string, companyWebsite: string) { @@ -6091,7 +6091,7 @@ function updateInvoiceCompanyWebsite(policyID: string, companyWebsite: string) { companyWebsite, }; - API.write(WRITE_COMMANDS.UPDATE_INVOICE_COMPANY_WEBSITE, parameters, {optimisticData, successData, failureData}); + void API.write(WRITE_COMMANDS.UPDATE_INVOICE_COMPANY_WEBSITE, parameters, {optimisticData, successData, failureData}); } /** @@ -6132,14 +6132,14 @@ function getAccessiblePolicies(validateCode?: string) { const command = validateCode ? WRITE_COMMANDS.VALIDATE_USER_AND_GET_ACCESSIBLE_POLICIES : WRITE_COMMANDS.GET_ACCESSIBLE_POLICIES; - API.write(command, validateCode ? {validateCode} : null, {optimisticData, successData, failureData}); + void API.write(command, validateCode ? {validateCode} : null, {optimisticData, successData, failureData}); } /** * Clear the errors from the get accessible policies request */ function clearGetAccessiblePoliciesErrors() { - Onyx.merge(ONYXKEYS.VALIDATE_USER_AND_GET_ACCESSIBLE_POLICIES, {errors: null}); + void Onyx.merge(ONYXKEYS.VALIDATE_USER_AND_GET_ACCESSIBLE_POLICIES, {errors: null}); } /** @@ -6169,7 +6169,7 @@ function calculateBillNewDot() { ]; // eslint-disable-next-line rulesdir/no-api-side-effects-method - API.makeRequestWithSideEffects(SIDE_EFFECT_REQUEST_COMMANDS.CALCULATE_BILL_NEW_DOT, null, { + void API.makeRequestWithSideEffects(SIDE_EFFECT_REQUEST_COMMANDS.CALCULATE_BILL_NEW_DOT, null, { optimisticData, successData, failureData, @@ -6209,19 +6209,19 @@ function payAndDowngrade() { }, }, ]; - API.write(WRITE_COMMANDS.PAY_AND_DOWNGRADE, null, {optimisticData, successData, failureData}); + void API.write(WRITE_COMMANDS.PAY_AND_DOWNGRADE, null, {optimisticData, successData, failureData}); } function clearBillingReceiptDetailsErrors() { - Onyx.merge(ONYXKEYS.BILLING_RECEIPT_DETAILS, {errors: null}); + void Onyx.merge(ONYXKEYS.BILLING_RECEIPT_DETAILS, {errors: null}); } function setIsForcedToChangeCurrency(value: boolean) { - Onyx.set(ONYXKEYS.IS_FORCED_TO_CHANGE_CURRENCY, value); + void Onyx.set(ONYXKEYS.IS_FORCED_TO_CHANGE_CURRENCY, value); } function setIsComingFromGlobalReimbursementsFlow(value: boolean) { - Onyx.set(ONYXKEYS.IS_COMING_FROM_GLOBAL_REIMBURSEMENTS_FLOW, value); + void Onyx.set(ONYXKEYS.IS_COMING_FROM_GLOBAL_REIMBURSEMENTS_FLOW, value); } function updateFeature( @@ -6232,7 +6232,7 @@ function updateFeature( policyID: string, ) { if (request.endpoint === WRITE_COMMANDS.TOGGLE_POLICY_PER_DIEM) { - API.write(WRITE_COMMANDS.TOGGLE_POLICY_PER_DIEM, { + void API.write(WRITE_COMMANDS.TOGGLE_POLICY_PER_DIEM, { policyID, enabled: request.parameters.enabled, customUnitID: generateCustomUnitID(), @@ -6240,7 +6240,7 @@ function updateFeature( return; } // eslint-disable-next-line rulesdir/no-multiple-api-calls - API.writeWithNoDuplicatesEnableFeatureConflicts(request.endpoint, request.parameters); + void API.writeWithNoDuplicatesEnableFeatureConflicts(request.endpoint, request.parameters); } function updateInterestedFeatures(features: Feature[], policyID: string, type: string | undefined) { @@ -6279,7 +6279,7 @@ function updateInterestedFeatures(features: Feature[], policyID: string, type: s const isCorporate = type === CONST.POLICY.TYPE.CORPORATE; if (shouldUpgradeToCorporate && !isCorporate) { - API.write(WRITE_COMMANDS.UPGRADE_TO_CORPORATE, {policyID}); + void API.write(WRITE_COMMANDS.UPGRADE_TO_CORPORATE, {policyID}); } requests.forEach((request) => { @@ -6291,7 +6291,7 @@ function clearPolicyTitleFieldError(policyID: string) { if (!policyID) { return; } - Onyx.merge(`${ONYXKEYS.COLLECTION.POLICY}${policyID}`, { + void Onyx.merge(`${ONYXKEYS.COLLECTION.POLICY}${policyID}`, { errorFields: { fieldList: { [CONST.POLICY.FIELDS.FIELD_LIST_TITLE]: null, diff --git a/src/libs/actions/Policy/ReportField.ts b/src/libs/actions/Policy/ReportField.ts index 70f44d158b95..1844a1b85615 100644 --- a/src/libs/actions/Policy/ReportField.ts +++ b/src/libs/actions/Policy/ReportField.ts @@ -56,8 +56,8 @@ Onyx.connect({ cleanUpSetQueries[`${ONYXKEYS.COLLECTION.REPORT_DRAFT_COMMENT}${reportID}`] = null; cleanUpSetQueries[`${ONYXKEYS.COLLECTION.REPORT_ACTIONS_DRAFTS}${reportID}`] = null; }); - Onyx.mergeCollection(ONYXKEYS.COLLECTION.REPORT, cleanUpMergeQueries); - Onyx.multiSet(cleanUpSetQueries); + void Onyx.mergeCollection(ONYXKEYS.COLLECTION.REPORT, cleanUpMergeQueries); + void Onyx.multiSet(cleanUpSetQueries); delete allPolicies[key]; return; } @@ -113,7 +113,7 @@ function openPolicyReportFieldsPage(policyID: string) { * Sets the initial form values for the workspace report fields form. */ function setInitialCreateReportFieldsForm() { - Onyx.set(ONYXKEYS.FORMS.WORKSPACE_REPORT_FIELDS_FORM_DRAFT, { + void Onyx.set(ONYXKEYS.FORMS.WORKSPACE_REPORT_FIELDS_FORM_DRAFT, { [INPUT_IDS.INITIAL_VALUE]: '', }); } @@ -122,7 +122,7 @@ function setInitialCreateReportFieldsForm() { * Creates a new list value in the workspace report fields form. */ function createReportFieldsListValue({valueName, listValues, disabledListValues}: CreateReportFieldsListValueParams) { - Onyx.merge(ONYXKEYS.FORMS.WORKSPACE_REPORT_FIELDS_FORM_DRAFT, { + void Onyx.merge(ONYXKEYS.FORMS.WORKSPACE_REPORT_FIELDS_FORM_DRAFT, { [INPUT_IDS.LIST_VALUES]: [...listValues, valueName], [INPUT_IDS.DISABLED_LIST_VALUES]: [...disabledListValues, false], }); @@ -135,7 +135,7 @@ function renameReportFieldsListValue({valueIndex, newValueName, listValues}: Ren const listValuesCopy = [...listValues]; listValuesCopy[valueIndex] = newValueName; - Onyx.merge(ONYXKEYS.FORMS.WORKSPACE_REPORT_FIELDS_FORM_DRAFT, { + void Onyx.merge(ONYXKEYS.FORMS.WORKSPACE_REPORT_FIELDS_FORM_DRAFT, { [INPUT_IDS.LIST_VALUES]: listValuesCopy, }); } @@ -150,7 +150,7 @@ function setReportFieldsListValueEnabled({valueIndexes, enabled, disabledListVal disabledListValuesCopy[valueIndex] = !enabled; }); - Onyx.merge(ONYXKEYS.FORMS.WORKSPACE_REPORT_FIELDS_FORM_DRAFT, { + void Onyx.merge(ONYXKEYS.FORMS.WORKSPACE_REPORT_FIELDS_FORM_DRAFT, { [INPUT_IDS.DISABLED_LIST_VALUES]: disabledListValuesCopy, }); } @@ -169,7 +169,7 @@ function deleteReportFieldsListValue({valueIndexes, listValues, disabledListValu disabledListValuesCopy.splice(valueIndex, 1); }); - Onyx.merge(ONYXKEYS.FORMS.WORKSPACE_REPORT_FIELDS_FORM_DRAFT, { + void Onyx.merge(ONYXKEYS.FORMS.WORKSPACE_REPORT_FIELDS_FORM_DRAFT, { [INPUT_IDS.LIST_VALUES]: listValuesCopy, [INPUT_IDS.DISABLED_LIST_VALUES]: disabledListValuesCopy, }); @@ -267,7 +267,7 @@ function createReportField({name, type, initialValue, listValues, disabledListVa reportFields: JSON.stringify([optimisticReportFieldDataForPolicy]), }; - API.write(WRITE_COMMANDS.CREATE_WORKSPACE_REPORT_FIELD, parameters, onyxData); + void API.write(WRITE_COMMANDS.CREATE_WORKSPACE_REPORT_FIELD, parameters, onyxData); } function deleteReportFields(policyID: string, reportFieldsToUpdate: string[]) { @@ -329,7 +329,7 @@ function deleteReportFields(policyID: string, reportFieldsToUpdate: string[]) { reportFields: JSON.stringify(Object.values(updatedReportFields)), }; - API.write(WRITE_COMMANDS.DELETE_POLICY_REPORT_FIELD, parameters, onyxData); + void API.write(WRITE_COMMANDS.DELETE_POLICY_REPORT_FIELD, parameters, onyxData); } /** @@ -387,7 +387,7 @@ function updateReportFieldInitialValue(policyID: string, reportFieldID: string, reportFields: JSON.stringify([updatedReportField]), }; - API.write(WRITE_COMMANDS.UPDATE_WORKSPACE_REPORT_FIELD_INITIAL_VALUE, parameters, onyxData); + void API.write(WRITE_COMMANDS.UPDATE_WORKSPACE_REPORT_FIELD_INITIAL_VALUE, parameters, onyxData); } function updateReportFieldListValueEnabled(policyID: string, reportFieldID: string, valueIndexes: number[], enabled: boolean) { @@ -426,7 +426,7 @@ function updateReportFieldListValueEnabled(policyID: string, reportFieldID: stri reportFields: JSON.stringify([updatedReportField]), }; - API.write(WRITE_COMMANDS.ENABLE_WORKSPACE_REPORT_FIELD_LIST_VALUE, parameters, onyxData); + void API.write(WRITE_COMMANDS.ENABLE_WORKSPACE_REPORT_FIELD_LIST_VALUE, parameters, onyxData); } /** @@ -461,7 +461,7 @@ function addReportFieldListValue(policyID: string, reportFieldID: string, valueN reportFields: JSON.stringify([updatedReportField]), }; - API.write(WRITE_COMMANDS.CREATE_WORKSPACE_REPORT_FIELD_LIST_VALUE, parameters, onyxData); + void API.write(WRITE_COMMANDS.CREATE_WORKSPACE_REPORT_FIELD_LIST_VALUE, parameters, onyxData); } /** @@ -506,7 +506,7 @@ function removeReportFieldListValue(policyID: string, reportFieldID: string, val reportFields: JSON.stringify([updatedReportField]), }; - API.write(WRITE_COMMANDS.REMOVE_WORKSPACE_REPORT_FIELD_LIST_VALUE, parameters, onyxData); + void API.write(WRITE_COMMANDS.REMOVE_WORKSPACE_REPORT_FIELD_LIST_VALUE, parameters, onyxData); } export type {CreateReportFieldParams}; diff --git a/src/libs/actions/Policy/Tag.ts b/src/libs/actions/Policy/Tag.ts index e16f03f7e3c1..070eee7b6a45 100644 --- a/src/libs/actions/Policy/Tag.ts +++ b/src/libs/actions/Policy/Tag.ts @@ -182,7 +182,7 @@ function createPolicyTag(policyID: string, tagName: string) { tags: JSON.stringify([{name: newTagName}]), }; - API.write(WRITE_COMMANDS.CREATE_POLICY_TAG, parameters, onyxData); + void API.write(WRITE_COMMANDS.CREATE_POLICY_TAG, parameters, onyxData); } function importPolicyTags(policyID: string, tags: PolicyTag[]) { @@ -194,7 +194,7 @@ function importPolicyTags(policyID: string, tags: PolicyTag[]) { tags: JSON.stringify(tags.map((tag) => ({name: tag.name, enabled: tag.enabled, 'GL Code': tag['GL Code']}))), }; - API.write(WRITE_COMMANDS.IMPORT_TAGS_SPREADSHEET, parameters, onyxData); + void API.write(WRITE_COMMANDS.IMPORT_TAGS_SPREADSHEET, parameters, onyxData); } function setWorkspaceTagEnabled(policyID: string, tagsToUpdate: Record, tagListIndex: number) { @@ -292,7 +292,7 @@ function setWorkspaceTagEnabled(policyID: string, tagsToUpdate: Record) { @@ -376,7 +376,7 @@ function setWorkspaceTagRequired(policyID: string, tagListIndexes: number[], isR isRequired, }; - API.write(WRITE_COMMANDS.SET_POLICY_TAG_LISTS_REQUIRED, parameters, onyxData); + void API.write(WRITE_COMMANDS.SET_POLICY_TAG_LISTS_REQUIRED, parameters, onyxData); } function deletePolicyTags(policyID: string, tagsToDelete: string[], policyTags: OnyxEntry) { @@ -446,7 +446,7 @@ function deletePolicyTags(policyID: string, tagsToDelete: string[], policyTags: tags: JSON.stringify(tagsToDelete), }; - API.write(WRITE_COMMANDS.DELETE_POLICY_TAGS, parameters, onyxData); + void API.write(WRITE_COMMANDS.DELETE_POLICY_TAGS, parameters, onyxData); } type ClearPolicyTagErrorsProps = { @@ -464,7 +464,7 @@ function clearPolicyTagErrors({policyID, tagName, tagListIndex, policyTags}: Cle } if (tag.pendingAction === CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD) { - Onyx.merge(`${ONYXKEYS.COLLECTION.POLICY_TAGS}${policyID}`, { + void Onyx.merge(`${ONYXKEYS.COLLECTION.POLICY_TAGS}${policyID}`, { [tagListName]: { tags: { [tagName]: null, @@ -474,7 +474,7 @@ function clearPolicyTagErrors({policyID, tagName, tagListIndex, policyTags}: Cle return; } - Onyx.merge(`${ONYXKEYS.COLLECTION.POLICY_TAGS}${policyID}`, { + void Onyx.merge(`${ONYXKEYS.COLLECTION.POLICY_TAGS}${policyID}`, { [tagListName]: { tags: { [tagName]: { @@ -497,7 +497,7 @@ function clearPolicyTagListErrorField(policyID: string, tagListIndex: number, er return; } - Onyx.merge(`${ONYXKEYS.COLLECTION.POLICY_TAGS}${policyID}`, { + void Onyx.merge(`${ONYXKEYS.COLLECTION.POLICY_TAGS}${policyID}`, { [policyTag.name]: { errorFields: { [errorField]: null, @@ -517,7 +517,7 @@ function clearPolicyTagListErrors(policyID: string, tagListIndex: number) { return; } - Onyx.merge(`${ONYXKEYS.COLLECTION.POLICY_TAGS}${policyID}`, { + void Onyx.merge(`${ONYXKEYS.COLLECTION.POLICY_TAGS}${policyID}`, { [policyTag.name]: { errors: null, }, @@ -639,7 +639,7 @@ function renamePolicyTag(policyID: string, policyTag: {oldName: string; newName: tagListIndex, }; - API.write(WRITE_COMMANDS.RENAME_POLICY_TAG, parameters, onyxData); + void API.write(WRITE_COMMANDS.RENAME_POLICY_TAG, parameters, onyxData); } function enablePolicyTags(policyID: string, enabled: boolean) { @@ -737,7 +737,7 @@ function enablePolicyTags(policyID: string, enabled: boolean) { const parameters: EnablePolicyTagsParams = {policyID, enabled}; - API.writeWithNoDuplicatesEnableFeatureConflicts(WRITE_COMMANDS.ENABLE_POLICY_TAGS, parameters, onyxData); + void API.writeWithNoDuplicatesEnableFeatureConflicts(WRITE_COMMANDS.ENABLE_POLICY_TAGS, parameters, onyxData); if (enabled && getIsNarrowLayout()) { goBackWhenEnableFeature(policyID); @@ -746,27 +746,27 @@ function enablePolicyTags(policyID: string, enabled: boolean) { function cleanPolicyTags(policyID: string) { // We do not have any optimistic data or success data for this command as this action cannot be done offline - API.write(WRITE_COMMANDS.CLEAN_POLICY_TAGS, {policyID}); + void API.write(WRITE_COMMANDS.CLEAN_POLICY_TAGS, {policyID}); } function setImportedSpreadsheetIsImportingMultiLevelTags(isImportingMultiLevelTags: boolean) { - Onyx.merge(ONYXKEYS.IMPORTED_SPREADSHEET, {isImportingMultiLevelTags}); + void Onyx.merge(ONYXKEYS.IMPORTED_SPREADSHEET, {isImportingMultiLevelTags}); } function setImportedSpreadsheetIsImportingIndependentMultiLevelTags(isImportingIndependentMultiLevelTags: boolean) { - Onyx.merge(ONYXKEYS.IMPORTED_SPREADSHEET, {isImportingIndependentMultiLevelTags}); + void Onyx.merge(ONYXKEYS.IMPORTED_SPREADSHEET, {isImportingIndependentMultiLevelTags}); } function setImportedSpreadsheetIsFirstLineHeader(containsHeader: boolean) { - Onyx.merge(ONYXKEYS.IMPORTED_SPREADSHEET, {containsHeader}); + void Onyx.merge(ONYXKEYS.IMPORTED_SPREADSHEET, {containsHeader}); } function setImportedSpreadsheetIsGLAdjacent(isGLAdjacent: boolean) { - Onyx.merge(ONYXKEYS.IMPORTED_SPREADSHEET, {isGLAdjacent}); + void Onyx.merge(ONYXKEYS.IMPORTED_SPREADSHEET, {isGLAdjacent}); } function setImportedSpreadsheetFileURI(fileURI: string) { - Onyx.merge(ONYXKEYS.IMPORTED_SPREADSHEET, {fileURI}); + void Onyx.merge(ONYXKEYS.IMPORTED_SPREADSHEET, {fileURI}); } function importMultiLevelTags(policyID: string, spreadsheet: ImportedSpreadsheet | undefined) { @@ -823,7 +823,7 @@ function importMultiLevelTags(policyID: string, spreadsheet: ImportedSpreadsheet file, }; - API.write(WRITE_COMMANDS.IMPORT_MULTI_LEVEL_TAGS, parameters, onyxData); + void API.write(WRITE_COMMANDS.IMPORT_MULTI_LEVEL_TAGS, parameters, onyxData); }, () => {}, spreadsheet?.fileType ?? CONST.SHARE_FILE_MIMETYPE.CSV, @@ -877,7 +877,7 @@ function renamePolicyTagList(policyID: string, policyTagListName: {oldName: stri tagListIndex, }; - API.write(WRITE_COMMANDS.RENAME_POLICY_TAG_LIST, parameters, onyxData); + void API.write(WRITE_COMMANDS.RENAME_POLICY_TAG_LIST, parameters, onyxData); } function setPolicyRequiresTag(policyID: string, requiresTag: boolean) { @@ -949,7 +949,7 @@ function setPolicyRequiresTag(policyID: string, requiresTag: boolean) { requiresTag, }; - API.write(WRITE_COMMANDS.SET_POLICY_REQUIRES_TAG, parameters, onyxData); + void API.write(WRITE_COMMANDS.SET_POLICY_REQUIRES_TAG, parameters, onyxData); } function setPolicyTagsRequired(policyID: string, requiresTag: boolean, tagListIndex: number) { @@ -1011,7 +1011,7 @@ function setPolicyTagsRequired(policyID: string, requiresTag: boolean, tagListIn requireTagList: requiresTag, }; - API.write(WRITE_COMMANDS.SET_POLICY_TAGS_REQUIRED, parameters, onyxData); + void API.write(WRITE_COMMANDS.SET_POLICY_TAGS_REQUIRED, parameters, onyxData); } function setPolicyTagGLCode(policyID: string, tagName: string, tagListIndex: number, glCode: string) { @@ -1086,7 +1086,7 @@ function setPolicyTagGLCode(policyID: string, tagName: string, tagListIndex: num glCode, }; - API.write(WRITE_COMMANDS.UPDATE_POLICY_TAG_GL_CODE, parameters, onyxData); + void API.write(WRITE_COMMANDS.UPDATE_POLICY_TAG_GL_CODE, parameters, onyxData); } function setPolicyTagApprover(policyID: string, tag: string, approver: string) { @@ -1156,7 +1156,7 @@ function setPolicyTagApprover(policyID: string, tag: string, approver: string) { approver: toBeUnselected ? null : approver, }; - API.write(WRITE_COMMANDS.SET_POLICY_TAG_APPROVER, parameters, onyxData); + void API.write(WRITE_COMMANDS.SET_POLICY_TAG_APPROVER, parameters, onyxData); } function downloadTagsCSV(policyID: string, onDownloadFailed: () => void) { @@ -1170,7 +1170,7 @@ function downloadTagsCSV(policyID: string, onDownloadFailed: () => void) { formData.append(key, String(value)); }); - fileDownload(ApiUtils.getCommandURL({command: WRITE_COMMANDS.EXPORT_TAGS_CSV}), fileName, '', false, formData, CONST.NETWORK.METHOD.POST, onDownloadFailed); + void fileDownload(ApiUtils.getCommandURL({command: WRITE_COMMANDS.EXPORT_TAGS_CSV}), fileName, '', false, formData, CONST.NETWORK.METHOD.POST, onDownloadFailed); } function downloadMultiLevelIndependentTagsCSV(policyID: string, onDownloadFailed: () => void) { @@ -1184,7 +1184,7 @@ function downloadMultiLevelIndependentTagsCSV(policyID: string, onDownloadFailed formData.append(key, String(value)); }); - fileDownload(ApiUtils.getCommandURL({command: WRITE_COMMANDS.EXPORT_MULTI_LEVEL_TAGS_CSV}), fileName, '', false, formData, CONST.NETWORK.METHOD.POST, onDownloadFailed); + void fileDownload(ApiUtils.getCommandURL({command: WRITE_COMMANDS.EXPORT_MULTI_LEVEL_TAGS_CSV}), fileName, '', false, formData, CONST.NETWORK.METHOD.POST, onDownloadFailed); } function getPolicyTagsData(policyID: string | undefined) { diff --git a/src/libs/actions/ReimbursementAccount/errors.ts b/src/libs/actions/ReimbursementAccount/errors.ts index 20e17882345e..c2f831c9f0ae 100644 --- a/src/libs/actions/ReimbursementAccount/errors.ts +++ b/src/libs/actions/ReimbursementAccount/errors.ts @@ -6,8 +6,8 @@ import type {ErrorFields} from '@src/types/onyx/OnyxCommon'; * Set the current fields with errors. */ function setBankAccountFormValidationErrors(errorFields: ErrorFields) { - Onyx.merge(ONYXKEYS.REIMBURSEMENT_ACCOUNT, {errorFields: null}); - Onyx.merge(ONYXKEYS.REIMBURSEMENT_ACCOUNT, {errorFields}); + void Onyx.merge(ONYXKEYS.REIMBURSEMENT_ACCOUNT, {errorFields: null}); + void Onyx.merge(ONYXKEYS.REIMBURSEMENT_ACCOUNT, {errorFields}); } /** @@ -15,7 +15,7 @@ function setBankAccountFormValidationErrors(errorFields: ErrorFields) { */ function resetReimbursementAccount() { setBankAccountFormValidationErrors({}); - Onyx.merge(ONYXKEYS.REIMBURSEMENT_ACCOUNT, { + void Onyx.merge(ONYXKEYS.REIMBURSEMENT_ACCOUNT, { errors: null, pendingAction: null, }); diff --git a/src/libs/actions/ReimbursementAccount/index.ts b/src/libs/actions/ReimbursementAccount/index.ts index ac2d00b2187d..7dfb4ca7650c 100644 --- a/src/libs/actions/ReimbursementAccount/index.ts +++ b/src/libs/actions/ReimbursementAccount/index.ts @@ -25,37 +25,37 @@ function setBankAccountState(state: string): Promise { } function hideBankAccountErrors() { - Onyx.merge(ONYXKEYS.REIMBURSEMENT_ACCOUNT, {error: '', errors: null}); + void Onyx.merge(ONYXKEYS.REIMBURSEMENT_ACCOUNT, {error: '', errors: null}); } function updateReimbursementAccountDraft(bankAccountData: Partial) { - Onyx.merge(ONYXKEYS.FORMS.REIMBURSEMENT_ACCOUNT_FORM_DRAFT, bankAccountData); - Onyx.merge(ONYXKEYS.REIMBURSEMENT_ACCOUNT, {draftStep: undefined}); + void Onyx.merge(ONYXKEYS.FORMS.REIMBURSEMENT_ACCOUNT_FORM_DRAFT, bankAccountData); + void Onyx.merge(ONYXKEYS.REIMBURSEMENT_ACCOUNT, {draftStep: undefined}); } function clearReimbursementAccountDraft() { - Onyx.set(ONYXKEYS.FORMS.REIMBURSEMENT_ACCOUNT_FORM_DRAFT, {}); + void Onyx.set(ONYXKEYS.FORMS.REIMBURSEMENT_ACCOUNT_FORM_DRAFT, {}); } /** * Triggers a modal to open allowing the user to reset their bank account */ function requestResetBankAccount() { - Onyx.merge(ONYXKEYS.REIMBURSEMENT_ACCOUNT, {shouldShowResetModal: true}); + void Onyx.merge(ONYXKEYS.REIMBURSEMENT_ACCOUNT, {shouldShowResetModal: true}); } /** * Hides modal allowing the user to reset their bank account */ function cancelResetBankAccount() { - Onyx.merge(ONYXKEYS.REIMBURSEMENT_ACCOUNT, {shouldShowResetModal: false}); + void Onyx.merge(ONYXKEYS.REIMBURSEMENT_ACCOUNT, {shouldShowResetModal: false}); } /** * Sets pressed option during connecting reimbursement account */ function setReimbursementAccountOptionPressed(optionPressed: ValueOf) { - Onyx.set(ONYXKEYS.REIMBURSEMENT_ACCOUNT_OPTION_PRESSED, optionPressed); + void Onyx.set(ONYXKEYS.REIMBURSEMENT_ACCOUNT_OPTION_PRESSED, optionPressed); } export { diff --git a/src/libs/actions/ReimbursementAccount/navigation.ts b/src/libs/actions/ReimbursementAccount/navigation.ts index 9ee7c295a8d7..6cb03da9b56c 100644 --- a/src/libs/actions/ReimbursementAccount/navigation.ts +++ b/src/libs/actions/ReimbursementAccount/navigation.ts @@ -9,7 +9,7 @@ import type {BankAccountStep} from '@src/types/onyx/ReimbursementAccount'; * Navigate to a specific step in the VBA flow */ function goToWithdrawalAccountSetupStep(stepID: BankAccountStep) { - Onyx.merge(ONYXKEYS.REIMBURSEMENT_ACCOUNT, {achData: {currentStep: stepID}}); + void Onyx.merge(ONYXKEYS.REIMBURSEMENT_ACCOUNT, {achData: {currentStep: stepID}}); } /** diff --git a/src/libs/actions/ReimbursementAccount/resetNonUSDBankAccount.ts b/src/libs/actions/ReimbursementAccount/resetNonUSDBankAccount.ts index 96c664ef03f2..437847d6bab7 100644 --- a/src/libs/actions/ReimbursementAccount/resetNonUSDBankAccount.ts +++ b/src/libs/actions/ReimbursementAccount/resetNonUSDBankAccount.ts @@ -35,7 +35,7 @@ function resetNonUSDBankAccount(policyID: string | undefined, achAccount: OnyxEn return; } - API.write( + void API.write( WRITE_COMMANDS.RESET_BANK_ACCOUNT_SETUP, {policyID}, { diff --git a/src/libs/actions/ReimbursementAccount/resetUSDBankAccount.ts b/src/libs/actions/ReimbursementAccount/resetUSDBankAccount.ts index 10c62f03adb5..0f4ff4f1ebab 100644 --- a/src/libs/actions/ReimbursementAccount/resetUSDBankAccount.ts +++ b/src/libs/actions/ReimbursementAccount/resetUSDBankAccount.ts @@ -153,7 +153,7 @@ function resetUSDBankAccount( }); } - API.write( + void API.write( WRITE_COMMANDS.RESTART_BANK_ACCOUNT_SETUP, { bankAccountID, diff --git a/src/libs/actions/Report.ts b/src/libs/actions/Report.ts index 488429a228d8..e8750ace91bf 100644 --- a/src/libs/actions/Report.ts +++ b/src/libs/actions/Report.ts @@ -447,7 +447,7 @@ Onyx.connect({ cleanUpSetQueries[`${ONYXKEYS.COLLECTION.REPORT_DRAFT_COMMENT}${reportID}`] = null; cleanUpSetQueries[`${ONYXKEYS.COLLECTION.REPORT_ACTIONS_DRAFTS}${reportID}`] = null; }); - Onyx.multiSet(cleanUpSetQueries); + void Onyx.multiSet(cleanUpSetQueries); delete allPolicies[key]; return; } @@ -490,7 +490,7 @@ registerPaginationConfig({ }); function clearGroupChat() { - Onyx.set(ONYXKEYS.NEW_GROUP_CHAT_DRAFT, null); + void Onyx.set(ONYXKEYS.NEW_GROUP_CHAT_DRAFT, null); } function startNewChat() { @@ -537,7 +537,7 @@ function subscribeToReportTypingEvents(reportID: string) { } // Make sure we have a clean Typing indicator before subscribing to typing events - Onyx.set(`${ONYXKEYS.COLLECTION.REPORT_USER_IS_TYPING}${reportID}`, {}); + void Onyx.set(`${ONYXKEYS.COLLECTION.REPORT_USER_IS_TYPING}${reportID}`, {}); const pusherChannelName = getReportChannelName(reportID); Pusher.subscribe(pusherChannelName, Pusher.TYPE.USER_IS_TYPING, (typingStatus) => { @@ -559,7 +559,7 @@ function subscribeToReportTypingEvents(reportID: string) { // Use a combo of the reportID and the accountID or login as a key for holding our timers. const reportUserIdentifier = `${reportID}-${accountIDOrLogin}`; clearTimeout(typingWatchTimers[reportUserIdentifier]); - Onyx.merge(`${ONYXKEYS.COLLECTION.REPORT_USER_IS_TYPING}${reportID}`, normalizedTypingStatus); + void Onyx.merge(`${ONYXKEYS.COLLECTION.REPORT_USER_IS_TYPING}${reportID}`, normalizedTypingStatus); // Regular user typing indicators: time out after 1.5s of inactivity. // Concierge (AgentZero-initiated): use a longer 10s timeout. AgentZero sends a single typing event for Concierge, not a stream, so client holds the indicator longer. @@ -571,7 +571,7 @@ function subscribeToReportTypingEvents(reportID: string) { typingWatchTimers[reportUserIdentifier] = setTimeout(() => { const typingStoppedStatus: ReportUserIsTyping = {}; typingStoppedStatus[accountIDOrLogin] = false; - Onyx.merge(`${ONYXKEYS.COLLECTION.REPORT_USER_IS_TYPING}${reportID}`, typingStoppedStatus); + void Onyx.merge(`${ONYXKEYS.COLLECTION.REPORT_USER_IS_TYPING}${reportID}`, typingStoppedStatus); delete typingWatchTimers[reportUserIdentifier]; }, timeoutDuration); } @@ -587,7 +587,7 @@ function subscribeToReportLeavingEvents(reportID: string | undefined) { } // Make sure we have a clean Leaving indicator before subscribing to leaving events - Onyx.set(`${ONYXKEYS.COLLECTION.REPORT_USER_IS_LEAVING_ROOM}${reportID}`, false); + void Onyx.set(`${ONYXKEYS.COLLECTION.REPORT_USER_IS_LEAVING_ROOM}${reportID}`, false); const pusherChannelName = getReportChannelName(reportID); Pusher.subscribe(pusherChannelName, Pusher.TYPE.USER_IS_LEAVING_ROOM, (leavingStatus: UserIsLeavingRoomEvent) => { @@ -605,7 +605,7 @@ function subscribeToReportLeavingEvents(reportID: string | undefined) { return; } - Onyx.merge(`${ONYXKEYS.COLLECTION.REPORT_USER_IS_LEAVING_ROOM}${reportID}`, true); + void Onyx.merge(`${ONYXKEYS.COLLECTION.REPORT_USER_IS_LEAVING_ROOM}${reportID}`, true); }).catch((error: ReportError) => { Log.hmmm('[Report] Failed to initially subscribe to Pusher channel', {errorType: error.type, pusherChannelName}); }); @@ -620,7 +620,7 @@ function unsubscribeFromReportChannel(reportID: string) { } const pusherChannelName = getReportChannelName(reportID); - Onyx.set(`${ONYXKEYS.COLLECTION.REPORT_USER_IS_TYPING}${reportID}`, {}); + void Onyx.set(`${ONYXKEYS.COLLECTION.REPORT_USER_IS_TYPING}${reportID}`, {}); Pusher.unsubscribe(pusherChannelName, Pusher.TYPE.USER_IS_TYPING); } @@ -633,7 +633,7 @@ function unsubscribeFromLeavingRoomReportChannel(reportID: string | undefined) { } const pusherChannelName = getReportChannelName(reportID); - Onyx.set(`${ONYXKEYS.COLLECTION.REPORT_USER_IS_LEAVING_ROOM}${reportID}`, false); + void Onyx.set(`${ONYXKEYS.COLLECTION.REPORT_USER_IS_LEAVING_ROOM}${reportID}`, false); Pusher.unsubscribe(pusherChannelName, Pusher.TYPE.USER_IS_LEAVING_ROOM); } @@ -830,7 +830,7 @@ function addActions(reportID: string, timezoneParam: Timezone, text = '', file?: DateUtils.setTimezoneUpdated(); } - API.write(commandName, parameters, { + void API.write(commandName, parameters, { optimisticData, successData, failureData, @@ -841,7 +841,7 @@ function addActions(reportID: string, timezoneParam: Timezone, text = '', file?: /** Add an attachment and optional comment. */ function addAttachment(reportID: string, file: FileObject, timezoneParam: Timezone, text = '', shouldPlaySound?: boolean) { if (shouldPlaySound) { - playSound(SOUNDS.DONE); + void playSound(SOUNDS.DONE); } addActions(reportID, timezoneParam, text, file); } @@ -849,7 +849,7 @@ function addAttachment(reportID: string, file: FileObject, timezoneParam: Timezo /** Add a single comment to a report */ function addComment(reportID: string, text: string, timezoneParam: Timezone, shouldPlaySound?: boolean) { if (shouldPlaySound) { - playSound(SOUNDS.DONE); + void playSound(SOUNDS.DONE); } addActions(reportID, timezoneParam, text); } @@ -902,7 +902,7 @@ function updateChatName(reportID: string, reportName: string, type: typeof CONST const command = type === CONST.REPORT.CHAT_TYPE.GROUP ? WRITE_COMMANDS.UPDATE_GROUP_CHAT_NAME : WRITE_COMMANDS.UPDATE_TRIP_ROOM_NAME; const parameters: UpdateChatNameParams = {reportName, reportID}; - API.write(command, parameters, {optimisticData, successData, failureData}); + void API.write(command, parameters, {optimisticData, successData, failureData}); } function updateGroupChatAvatar(reportID: string, file?: File | CustomRNImageManipulatorResult) { @@ -949,14 +949,14 @@ function updateGroupChatAvatar(reportID: string, file?: File | CustomRNImageMani }, ]; const parameters: UpdateGroupChatAvatarParams = {file, reportID}; - API.write(WRITE_COMMANDS.UPDATE_GROUP_CHAT_AVATAR, parameters, {optimisticData, failureData, successData}); + void API.write(WRITE_COMMANDS.UPDATE_GROUP_CHAT_AVATAR, parameters, {optimisticData, failureData, successData}); } /** * Clear error and pending fields for the report avatar */ function clearAvatarErrors(reportID: string) { - Onyx.merge(`${ONYXKEYS.COLLECTION.REPORT}${reportID}`, { + void Onyx.merge(`${ONYXKEYS.COLLECTION.REPORT}${reportID}`, { errorFields: { avatar: null, }, @@ -1153,7 +1153,7 @@ function openReport( parameters.file = avatar; } - InteractionManager.runAfterInteractions(() => { + void InteractionManager.runAfterInteractions(() => { clearGroupChat(); }); } @@ -1399,7 +1399,7 @@ function navigateToAndOpenReport( } // In some cases when RHP modal gets hidden and then we navigate to report Composer focus breaks, wrapping navigation in setTimeout fixes this setTimeout(() => { - Navigation.isNavigationReady().then(() => Navigation.navigate(ROUTES.REPORT_WITH_ID.getRoute(report?.reportID))); + void Navigation.isNavigationReady().then(() => Navigation.navigate(ROUTES.REPORT_WITH_ID.getRoute(report?.reportID))); }, 0); } @@ -1456,7 +1456,7 @@ function navigateToAndOpenChildReport(childReportID: string | undefined, parentR const participantLogins = PersonalDetailsUtils.getLoginsByAccountIDs(Object.keys(newChat.participants ?? {}).map(Number)); openReport(newChat.reportID, '', participantLogins, newChat, parentReportAction.reportActionID); } else { - Onyx.merge(`${ONYXKEYS.COLLECTION.REPORT}${childReportID}`, newChat); + void Onyx.merge(`${ONYXKEYS.COLLECTION.REPORT}${childReportID}`, newChat); } Navigation.navigate(ROUTES.REPORT_WITH_ID.getRoute(newChat.reportID, undefined, undefined, Navigation.getActiveRoute())); @@ -1621,7 +1621,7 @@ function readNewestAction(reportID: string | undefined, shouldResetUnreadMarker lastReadTime, }; - API.writeWithNoDuplicatesConflictAction( + void API.writeWithNoDuplicatesConflictAction( WRITE_COMMANDS.READ_NEWEST_ACTION, parameters, {optimisticData}, @@ -1688,7 +1688,7 @@ function markAllMessagesAsRead() { reportIDList, }; - API.write(WRITE_COMMANDS.MARK_ALL_MESSAGES_AS_READ, parameters, {optimisticData, failureData}); + void API.write(WRITE_COMMANDS.MARK_ALL_MESSAGES_AS_READ, parameters, {optimisticData, failureData}); } /** @@ -1746,7 +1746,7 @@ function markCommentAsUnread(reportID: string | undefined, reportAction: ReportA reportActionID: reportAction?.reportActionID, }; - API.write(WRITE_COMMANDS.MARK_AS_UNREAD, parameters, {optimisticData}); + void API.write(WRITE_COMMANDS.MARK_AS_UNREAD, parameters, {optimisticData}); DeviceEventEmitter.emit(`unreadAction_${reportID}`, lastReadTime); } @@ -1772,7 +1772,7 @@ function togglePinnedState(reportID: string | undefined, isPinnedChat: boolean) pinnedValue, }; - API.write(WRITE_COMMANDS.TOGGLE_PINNED_CHAT, parameters, {optimisticData}); + void API.write(WRITE_COMMANDS.TOGGLE_PINNED_CHAT, parameters, {optimisticData}); } /** Saves the report draft to Onyx */ @@ -1786,7 +1786,7 @@ function saveReportDraft(reportID: string, report: Report) { * When empty string or null is passed, it will delete the draft comment from Onyx store. */ function saveReportDraftComment(reportID: string, comment: string | null, callback: () => void = () => {}) { - Onyx.merge(`${ONYXKEYS.COLLECTION.REPORT_DRAFT_COMMENT}${reportID}`, prepareDraftComment(comment)).then(callback); + void Onyx.merge(`${ONYXKEYS.COLLECTION.REPORT_DRAFT_COMMENT}${reportID}`, prepareDraftComment(comment)).then(callback); } /** Broadcasts whether or not a user is typing on a report over the report's private pusher channel. */ @@ -1817,10 +1817,10 @@ function handleReportChanged(report: OnyxEntry) { // Handle cleanup of stale optimistic IOU report and its report preview separately if (reportID && preexistingReportID && isMoneyRequestReport(report) && parentReportActionID) { - Onyx.merge(`${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${parentReportID}`, { + void Onyx.merge(`${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${parentReportID}`, { [parentReportActionID]: null, }); - Onyx.merge(`${ONYXKEYS.COLLECTION.REPORT}${reportID}`, null); + void Onyx.merge(`${ONYXKEYS.COLLECTION.REPORT}${reportID}`, null); return; } @@ -1831,15 +1831,15 @@ function handleReportChanged(report: OnyxEntry) { let callback = () => { const existingReport = allReports?.[`${ONYXKEYS.COLLECTION.REPORT}${preexistingReportID}`]; - Onyx.set(`${ONYXKEYS.COLLECTION.REPORT}${reportID}`, null); - Onyx.set(`${ONYXKEYS.COLLECTION.REPORT}${preexistingReportID}`, { + void Onyx.set(`${ONYXKEYS.COLLECTION.REPORT}${reportID}`, null); + void Onyx.set(`${ONYXKEYS.COLLECTION.REPORT}${preexistingReportID}`, { ...report, reportID: preexistingReportID, preexistingReportID: null, // Replacing the existing report's participants to avoid duplicates participants: existingReport?.participants ?? report.participants, }); - Onyx.set(`${ONYXKEYS.COLLECTION.REPORT_DRAFT_COMMENT}${reportID}`, null); + void Onyx.set(`${ONYXKEYS.COLLECTION.REPORT_DRAFT_COMMENT}${reportID}`, null); }; // Only re-route them if they are still looking at the optimistically created report if (Navigation.getActiveRoute().includes(`/r/${reportID}`)) { @@ -1997,7 +1997,7 @@ function deleteReportComment(reportID: string | undefined, reportAction: ReportA clearByKey(reportActionID); - API.write( + void API.write( WRITE_COMMANDS.DELETE_COMMENT, parameters, {optimisticData, successData, failureData}, @@ -2173,7 +2173,7 @@ function editReportComment(reportID: string | undefined, originalReportAction: O reportActionID, }; - API.write( + void API.write( WRITE_COMMANDS.UPDATE_COMMENT, parameters, {optimisticData, successData, failureData}, @@ -2192,13 +2192,13 @@ function editReportComment(reportID: string | undefined, originalReportAction: O /** Deletes the draft for a comment report action. */ function deleteReportActionDraft(reportID: string | undefined, reportAction: ReportAction) { const originalReportID = getOriginalReportID(reportID, reportAction); - Onyx.merge(`${ONYXKEYS.COLLECTION.REPORT_ACTIONS_DRAFTS}${originalReportID}`, {[reportAction.reportActionID]: null}); + void Onyx.merge(`${ONYXKEYS.COLLECTION.REPORT_ACTIONS_DRAFTS}${originalReportID}`, {[reportAction.reportActionID]: null}); } /** Saves the draft for a comment report action. This will put the comment into "edit mode" */ function saveReportActionDraft(reportID: string | undefined, reportAction: ReportAction, draftMessage: string) { const originalReportID = getOriginalReportID(reportID, reportAction); - Onyx.merge(`${ONYXKEYS.COLLECTION.REPORT_ACTIONS_DRAFTS}${originalReportID}`, {[reportAction.reportActionID]: {message: draftMessage}}); + void Onyx.merge(`${ONYXKEYS.COLLECTION.REPORT_ACTIONS_DRAFTS}${originalReportID}`, {[reportAction.reportActionID]: {message: draftMessage}}); } function updateNotificationPreference( @@ -2256,7 +2256,7 @@ function updateNotificationPreference( const parameters: UpdateReportNotificationPreferenceParams = {reportID, notificationPreference: newValue}; - API.write(WRITE_COMMANDS.UPDATE_REPORT_NOTIFICATION_PREFERENCE, parameters, {optimisticData, failureData}); + void API.write(WRITE_COMMANDS.UPDATE_REPORT_NOTIFICATION_PREFERENCE, parameters, {optimisticData, failureData}); } function updateRoomVisibility(reportID: string, previousValue: RoomVisibility | undefined, newValue: RoomVisibility) { @@ -2282,7 +2282,7 @@ function updateRoomVisibility(reportID: string, previousValue: RoomVisibility | const parameters: UpdateRoomVisibilityParams = {reportID, visibility: newValue}; - API.write(WRITE_COMMANDS.UPDATE_ROOM_VISIBILITY, parameters, {optimisticData, failureData}); + void API.write(WRITE_COMMANDS.UPDATE_ROOM_VISIBILITY, parameters, {optimisticData, failureData}); } /** @@ -2377,11 +2377,11 @@ function updateReportName(reportID: string, value: string, previousValue: string reportName: value, }; - API.write(WRITE_COMMANDS.SET_REPORT_NAME, parameters, {optimisticData, failureData, successData}); + void API.write(WRITE_COMMANDS.SET_REPORT_NAME, parameters, {optimisticData, failureData, successData}); } function clearReportFieldKeyErrors(reportID: string | undefined, fieldKey: string) { - Onyx.merge(`${ONYXKEYS.COLLECTION.REPORT}${reportID}`, { + void Onyx.merge(`${ONYXKEYS.COLLECTION.REPORT}${reportID}`, { pendingFields: { [fieldKey]: null, }, @@ -2518,7 +2518,7 @@ function updateReportField(report: Report, reportField: PolicyReportField, previ reportFieldsActionIDs: JSON.stringify({[fieldKey]: optimisticChangeFieldAction.reportActionID}), }; - API.write(WRITE_COMMANDS.SET_REPORT_FIELD, parameters, {optimisticData, failureData, successData}); + void API.write(WRITE_COMMANDS.SET_REPORT_FIELD, parameters, {optimisticData, failureData, successData}); } function deleteReportField(reportID: string, reportField: PolicyReportField) { @@ -2577,7 +2577,7 @@ function deleteReportField(reportID: string, reportField: PolicyReportField) { fieldID: fieldKey, }; - API.write(WRITE_COMMANDS.DELETE_REPORT_FIELD, parameters, {optimisticData, failureData, successData}); + void API.write(WRITE_COMMANDS.DELETE_REPORT_FIELD, parameters, {optimisticData, failureData, successData}); } function updateDescription(reportID: string, currentDescription: string, newMarkdownValue: string) { @@ -2647,7 +2647,7 @@ function updateDescription(reportID: string, currentDescription: string, newMark const parameters: UpdateRoomDescriptionParams = {reportID, description: parsedDescription, reportActionID: optimisticDescriptionUpdatedReportAction.reportActionID}; - API.write(WRITE_COMMANDS.UPDATE_ROOM_DESCRIPTION, parameters, {optimisticData, failureData, successData}); + void API.write(WRITE_COMMANDS.UPDATE_ROOM_DESCRIPTION, parameters, {optimisticData, failureData, successData}); } function updateWriteCapability(report: Report, newValue: WriteCapability) { @@ -2673,7 +2673,7 @@ function updateWriteCapability(report: Report, newValue: WriteCapability) { const parameters: UpdateReportWriteCapabilityParams = {reportID: report.reportID, writeCapability: newValue}; - API.write(WRITE_COMMANDS.UPDATE_REPORT_WRITE_CAPABILITY, parameters, {optimisticData, failureData}); + void API.write(WRITE_COMMANDS.UPDATE_REPORT_WRITE_CAPABILITY, parameters, {optimisticData, failureData}); } /** @@ -2868,7 +2868,7 @@ function createNewReport(creatorPersonalDetails: PersonalDetails, policyID?: str reportPreviewReportActionID, ); - API.write( + void API.write( WRITE_COMMANDS.CREATE_APP_REPORT, {reportName: optimisticReportName, type: CONST.REPORT.TYPE.EXPENSE, policyID, reportID: optimisticReportID, reportActionID, reportPreviewReportActionID}, {optimisticData, successData, failureData}, @@ -2884,9 +2884,9 @@ function createNewReport(creatorPersonalDetails: PersonalDetails, policyID?: str * Removes the report after failure to create. Also removes it's related report actions and next step from Onyx. */ function removeFailedReport(reportID: string | undefined) { - Onyx.set(`${ONYXKEYS.COLLECTION.REPORT}${reportID}`, null); - Onyx.set(`${ONYXKEYS.COLLECTION.NEXT_STEP}${reportID}`, null); - Onyx.set(`${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${reportID}`, null); + void Onyx.set(`${ONYXKEYS.COLLECTION.REPORT}${reportID}`, null); + void Onyx.set(`${ONYXKEYS.COLLECTION.NEXT_STEP}${reportID}`, null); + void Onyx.set(`${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${reportID}`, null); } /** Add a policy report (workspace room) optimistically and navigate to it. */ @@ -2991,7 +2991,7 @@ function addPolicyReport(policyReport: OptimisticChatReport) { description: policyReport.description, }; - API.write(WRITE_COMMANDS.ADD_WORKSPACE_ROOM, parameters, {optimisticData, successData, failureData}); + void API.write(WRITE_COMMANDS.ADD_WORKSPACE_ROOM, parameters, {optimisticData, successData, failureData}); Navigation.dismissModalWithReport({reportID: policyReport.reportID}); } @@ -3018,7 +3018,7 @@ function deleteReport(reportID: string | undefined, shouldDeleteChildReports = f onyxData[`${ONYXKEYS.COLLECTION.TRANSACTION}${transactionID}`] = null; }); - Onyx.multiSet(onyxData); + void Onyx.multiSet(onyxData); if (shouldDeleteChildReports) { Object.values(reportActionsForReport ?? {}).forEach((reportAction) => { @@ -3046,7 +3046,7 @@ function navigateToConciergeChatAndDeleteReport(reportID: string | undefined, sh Navigation.goBack(); } navigateToConciergeChat(); - InteractionManager.runAfterInteractions(() => { + void InteractionManager.runAfterInteractions(() => { deleteReport(reportID, shouldDeleteChildReports); }); } @@ -3136,14 +3136,14 @@ function updatePolicyRoomName(policyRoomReport: Report, policyRoomName: string) renamedRoomReportActionID: optimisticRenamedAction.reportActionID, }; - API.write(WRITE_COMMANDS.UPDATE_POLICY_ROOM_NAME, parameters, {optimisticData, successData, failureData}); + void API.write(WRITE_COMMANDS.UPDATE_POLICY_ROOM_NAME, parameters, {optimisticData, successData, failureData}); } /** * @param reportID The reportID of the policy room. */ function clearPolicyRoomNameErrors(reportID: string) { - Onyx.merge(`${ONYXKEYS.COLLECTION.REPORT}${reportID}`, { + void Onyx.merge(`${ONYXKEYS.COLLECTION.REPORT}${reportID}`, { errorFields: { reportName: null, }, @@ -3154,7 +3154,7 @@ function clearPolicyRoomNameErrors(reportID: string) { } function setIsComposerFullSize(reportID: string, isComposerFullSize: boolean) { - Onyx.merge(`${ONYXKEYS.COLLECTION.REPORT_IS_COMPOSER_FULL_SIZE}${reportID}`, isComposerFullSize); + void Onyx.merge(`${ONYXKEYS.COLLECTION.REPORT_IS_COMPOSER_FULL_SIZE}${reportID}`, isComposerFullSize); } /** @@ -3255,7 +3255,7 @@ function showReportActionNotification(reportID: string, reportAction: ReportActi /** Clear the errors associated with the IOUs of a given report. */ function clearIOUError(reportID: string | undefined) { - Onyx.merge(`${ONYXKEYS.COLLECTION.REPORT}${reportID}`, {errorFields: {iou: null}}); + void Onyx.merge(`${ONYXKEYS.COLLECTION.REPORT}${reportID}`, {errorFields: {iou: null}}); } /** @@ -3316,7 +3316,7 @@ function addEmojiReaction(reportID: string, reportActionID: string, emoji: Emoji createdAt, }; - API.write(WRITE_COMMANDS.ADD_EMOJI_REACTION, parameters, {optimisticData, successData, failureData}); + void API.write(WRITE_COMMANDS.ADD_EMOJI_REACTION, parameters, {optimisticData, successData, failureData}); } /** @@ -3344,7 +3344,7 @@ function removeEmojiReaction(reportID: string, reportActionID: string, emoji: Em emojiCode: emoji.name, }; - API.write(WRITE_COMMANDS.REMOVE_EMOJI_REACTION, parameters, {optimisticData}); + void API.write(WRITE_COMMANDS.REMOVE_EMOJI_REACTION, parameters, {optimisticData}); } /** @@ -3388,7 +3388,7 @@ function toggleEmojiReaction( } function doneCheckingPublicRoom() { - Onyx.set(ONYXKEYS.IS_CHECKING_PUBLIC_ROOM, false); + void Onyx.set(ONYXKEYS.IS_CHECKING_PUBLIC_ROOM, false); } function openReportFromDeepLink( @@ -3432,7 +3432,7 @@ function openReportFromDeepLink( } // Navigate to the report after sign-in/sign-up. - InteractionManager.runAfterInteractions(() => { + void InteractionManager.runAfterInteractions(() => { waitForUserSignIn().then(() => { const connection = Onyx.connect({ key: ONYXKEYS.NVP_ONBOARDING, @@ -3640,7 +3640,7 @@ function leaveGroupChat(reportID: string) { ]; navigateToMostRecentReport(report); - API.write(WRITE_COMMANDS.LEAVE_GROUP_CHAT, {reportID}, {optimisticData, successData, failureData}); + void API.write(WRITE_COMMANDS.LEAVE_GROUP_CHAT, {reportID}, {optimisticData, successData, failureData}); } /** Leave a report by setting the state to submitted and closed */ @@ -3743,7 +3743,7 @@ function leaveRoom(reportID: string, isWorkspaceMemberLeavingWorkspaceRoom = fal reportID, }; - API.write(WRITE_COMMANDS.LEAVE_ROOM, parameters, {optimisticData, successData, failureData}); + void API.write(WRITE_COMMANDS.LEAVE_ROOM, parameters, {optimisticData, successData, failureData}); // If this is the leave action from a workspace room, simply dismiss the modal, i.e., allow the user to view the room and join again immediately. // If this is the leave action from a chat thread (even if the chat thread is in a room), do not allow the user to stay in the thread after leaving. @@ -3863,7 +3863,7 @@ function inviteToRoom(reportID: string, inviteeEmailsToAccountIDs: InvitedEmails accountIDList: newAccountIDs.join(), }; - API.write(WRITE_COMMANDS.INVITE_TO_GROUP_CHAT, parameters, {optimisticData, successData, failureData}); + void API.write(WRITE_COMMANDS.INVITE_TO_GROUP_CHAT, parameters, {optimisticData, successData, failureData}); return; } @@ -3874,20 +3874,20 @@ function inviteToRoom(reportID: string, inviteeEmailsToAccountIDs: InvitedEmails }; // eslint-disable-next-line rulesdir/no-multiple-api-calls - API.write(WRITE_COMMANDS.INVITE_TO_ROOM, parameters, {optimisticData, successData, failureData}); + void API.write(WRITE_COMMANDS.INVITE_TO_ROOM, parameters, {optimisticData, successData, failureData}); } function clearAddRoomMemberError(reportID: string, invitedAccountID: string) { const reportMetadata = getReportMetadata(reportID); - Onyx.merge(`${ONYXKEYS.COLLECTION.REPORT}${reportID}`, { + void Onyx.merge(`${ONYXKEYS.COLLECTION.REPORT}${reportID}`, { participants: { [invitedAccountID]: null, }, }); - Onyx.merge(`${ONYXKEYS.COLLECTION.REPORT_METADATA}${reportID}`, { + void Onyx.merge(`${ONYXKEYS.COLLECTION.REPORT_METADATA}${reportID}`, { pendingChatMembers: reportMetadata?.pendingChatMembers?.filter((pendingChatMember) => pendingChatMember.accountID !== invitedAccountID), }); - Onyx.merge(ONYXKEYS.PERSONAL_DETAILS_LIST, { + void Onyx.merge(ONYXKEYS.PERSONAL_DETAILS_LIST, { [invitedAccountID]: null, }); } @@ -3930,7 +3930,7 @@ function updateGroupChatMemberRoles(reportID: string, accountIDList: number[], r }, ]; const parameters: UpdateGroupChatMemberRolesParams = {reportID, memberRoles: JSON.stringify(memberRoles)}; - API.write(WRITE_COMMANDS.UPDATE_GROUP_CHAT_MEMBER_ROLES, parameters, {optimisticData, successData}); + void API.write(WRITE_COMMANDS.UPDATE_GROUP_CHAT_MEMBER_ROLES, parameters, {optimisticData, successData}); } /** Invites people to a group chat */ @@ -3998,7 +3998,7 @@ function removeFromRoom(reportID: string, targetAccountIDs: number[]) { reportID, accountIDList: targetAccountIDs.join(), }; - API.write(WRITE_COMMANDS.REMOVE_FROM_GROUP_CHAT, parameters, {optimisticData, failureData, successData}); + void API.write(WRITE_COMMANDS.REMOVE_FROM_GROUP_CHAT, parameters, {optimisticData, failureData, successData}); return; } @@ -4008,7 +4008,7 @@ function removeFromRoom(reportID: string, targetAccountIDs: number[]) { }; // eslint-disable-next-line rulesdir/no-multiple-api-calls - API.write(WRITE_COMMANDS.REMOVE_FROM_ROOM, parameters, {optimisticData, failureData, successData}); + void API.write(WRITE_COMMANDS.REMOVE_FROM_ROOM, parameters, {optimisticData, failureData, successData}); } function removeFromGroupChat(reportID: string, accountIDList: number[]) { @@ -4142,7 +4142,7 @@ function flagComment(reportID: string | undefined, reportAction: OnyxEntry): boolean { /** Clears all errors associated with a given private note */ function clearPrivateNotesError(reportID: string, accountID: number) { - Onyx.merge(`${ONYXKEYS.COLLECTION.REPORT}${reportID}`, {privateNotes: {[accountID]: {errors: null}}}); + void Onyx.merge(`${ONYXKEYS.COLLECTION.REPORT}${reportID}`, {privateNotes: {[accountID]: {errors: null}}}); } function getDraftPrivateNote(reportID: string): string { @@ -4377,13 +4377,13 @@ function getDraftPrivateNote(reportID: string): string { * tab, refresh etc without worrying about loosing what they typed out. */ function savePrivateNotesDraft(reportID: string, note: string) { - Onyx.merge(`${ONYXKEYS.COLLECTION.PRIVATE_NOTES_DRAFT}${reportID}`, note); + void Onyx.merge(`${ONYXKEYS.COLLECTION.PRIVATE_NOTES_DRAFT}${reportID}`, note); } function searchForReports(searchInput: string, policyID?: string) { // We do not try to make this request while offline because it sets a loading indicator optimistically if (isNetworkOffline) { - Onyx.set(ONYXKEYS.IS_SEARCHING_FOR_REPORTS, false); + void Onyx.set(ONYXKEYS.IS_SEARCHING_FOR_REPORTS, false); return; } @@ -4419,14 +4419,14 @@ function searchForReports(searchInput: string, policyID?: string) { function searchInServer(searchInput: string, policyID?: string) { if (isNetworkOffline || !searchInput.trim().length) { - Onyx.set(ONYXKEYS.IS_SEARCHING_FOR_REPORTS, false); + void Onyx.set(ONYXKEYS.IS_SEARCHING_FOR_REPORTS, false); return; } // Why not set this in optimistic data? It won't run until the API request happens and while the API request is debounced // we want to show the loading state right away. Otherwise, we will see a flashing UI where the client options are sorted and // tell the user there are no options, then we start searching, and tell them there are no options again. - Onyx.set(ONYXKEYS.IS_SEARCHING_FOR_REPORTS, true); + void Onyx.set(ONYXKEYS.IS_SEARCHING_FOR_REPORTS, true); searchForReports(searchInput, policyID); } @@ -4434,18 +4434,18 @@ function updateLastVisitTime(reportID: string) { if (!isValidReportIDFromPath(reportID)) { return; } - Onyx.merge(`${ONYXKEYS.COLLECTION.REPORT_METADATA}${reportID}`, {lastVisitTime: DateUtils.getDBTime()}); + void Onyx.merge(`${ONYXKEYS.COLLECTION.REPORT_METADATA}${reportID}`, {lastVisitTime: DateUtils.getDBTime()}); } function updateLoadingInitialReportAction(reportID: string) { if (!isValidReportIDFromPath(reportID)) { return; } - Onyx.merge(`${ONYXKEYS.COLLECTION.REPORT_METADATA}${reportID}`, {isLoadingInitialReportActions: false}); + void Onyx.merge(`${ONYXKEYS.COLLECTION.REPORT_METADATA}${reportID}`, {isLoadingInitialReportActions: false}); } function setNewRoomFormLoading(isLoading = true) { - Onyx.merge(`${ONYXKEYS.FORMS.NEW_ROOM_FORM}`, {isLoading}); + void Onyx.merge(`${ONYXKEYS.FORMS.NEW_ROOM_FORM}`, {isLoading}); } function clearNewRoomFormError() { @@ -4568,7 +4568,7 @@ function resolveActionableMentionWhisper( resolution, }; - API.write(WRITE_COMMANDS.RESOLVE_ACTIONABLE_MENTION_WHISPER, parameters, {optimisticData, failureData}); + void API.write(WRITE_COMMANDS.RESOLVE_ACTIONABLE_MENTION_WHISPER, parameters, {optimisticData, failureData}); } function resolveActionableMentionConfirmWhisper( @@ -4650,7 +4650,7 @@ function resolveActionableReportMentionWhisper( resolution, }; - API.write(WRITE_COMMANDS.RESOLVE_ACTIONABLE_REPORT_MENTION_WHISPER, parameters, {optimisticData, failureData}); + void API.write(WRITE_COMMANDS.RESOLVE_ACTIONABLE_REPORT_MENTION_WHISPER, parameters, {optimisticData, failureData}); } function dismissTrackExpenseActionableWhisper(reportID: string | undefined, reportAction: OnyxEntry): void { @@ -4699,11 +4699,11 @@ function dismissTrackExpenseActionableWhisper(reportID: string | undefined, repo reportActionID: reportAction.reportActionID, }; - API.write(WRITE_COMMANDS.DISMISS_TRACK_EXPENSE_ACTIONABLE_WHISPER, params, {optimisticData, failureData}); + void API.write(WRITE_COMMANDS.DISMISS_TRACK_EXPENSE_ACTIONABLE_WHISPER, params, {optimisticData, failureData}); } function setGroupDraft(newGroupDraft: Partial) { - Onyx.merge(ONYXKEYS.NEW_GROUP_CHAT_DRAFT, newGroupDraft); + void Onyx.merge(ONYXKEYS.NEW_GROUP_CHAT_DRAFT, newGroupDraft); } function exportToIntegration(reportID: string, connectionName: ConnectionName) { @@ -4741,7 +4741,7 @@ function exportToIntegration(reportID: string, connectionName: ConnectionName) { }), } satisfies ReportExportParams; - API.write(WRITE_COMMANDS.REPORT_EXPORT, params, {optimisticData, failureData}); + void API.write(WRITE_COMMANDS.REPORT_EXPORT, params, {optimisticData, failureData}); } function markAsManuallyExported(reportID: string, connectionName: ConnectionName) { @@ -4794,7 +4794,7 @@ function markAsManuallyExported(reportID: string, connectionName: ConnectionName ]), } satisfies MarkAsExportedParams; - API.write(WRITE_COMMANDS.MARK_AS_EXPORTED, params, {optimisticData, successData, failureData}); + void API.write(WRITE_COMMANDS.MARK_AS_EXPORTED, params, {optimisticData, successData, failureData}); } function exportReportToCSV({reportID, transactionIDList}: ExportReportCSVParams, onDownloadFailed: () => void) { @@ -4812,7 +4812,7 @@ function exportReportToCSV({reportID, transactionIDList}: ExportReportCSVParams, } }); - fileDownload(ApiUtils.getCommandURL({command: WRITE_COMMANDS.EXPORT_REPORT_TO_CSV}), 'Expensify.csv', '', false, formData, CONST.NETWORK.METHOD.POST, onDownloadFailed); + void fileDownload(ApiUtils.getCommandURL({command: WRITE_COMMANDS.EXPORT_REPORT_TO_CSV}), 'Expensify.csv', '', false, formData, CONST.NETWORK.METHOD.POST, onDownloadFailed); } function exportReportToPDF({reportID}: ExportReportPDFParams) { @@ -4835,7 +4835,7 @@ function exportReportToPDF({reportID}: ExportReportPDFParams) { reportID, } satisfies ExportReportPDFParams; - API.write(WRITE_COMMANDS.EXPORT_REPORT_TO_PDF, params, {optimisticData, failureData}); + void API.write(WRITE_COMMANDS.EXPORT_REPORT_TO_PDF, params, {optimisticData, failureData}); } function downloadReportPDF(fileName: string, reportName: string) { @@ -4848,15 +4848,15 @@ function downloadReportPDF(fileName: string, reportName: string) { // The shouldOpenExternalLink parameter must always be set to // true to avoid CORS errors for as long as we use the OD URL. // See https://github.com/Expensify/App/issues/61937 - fileDownload(addEncryptedAuthTokenToURL(pdfURL, true), downloadFileName, '', true).then(() => setDownload(fileName, false)); + void fileDownload(addEncryptedAuthTokenToURL(pdfURL, true), downloadFileName, '', true).then(() => setDownload(fileName, false)); } function setDeleteTransactionNavigateBackUrl(url: string) { - Onyx.set(ONYXKEYS.NVP_DELETE_TRANSACTION_NAVIGATE_BACK_URL, url); + void Onyx.set(ONYXKEYS.NVP_DELETE_TRANSACTION_NAVIGATE_BACK_URL, url); } function clearDeleteTransactionNavigateBackUrl() { - Onyx.merge(ONYXKEYS.NVP_DELETE_TRANSACTION_NAVIGATE_BACK_URL, null); + void Onyx.merge(ONYXKEYS.NVP_DELETE_TRANSACTION_NAVIGATE_BACK_URL, null); } /** Deletes a report and un-reports all transactions on the report along with its reportActions, any linked reports and any linked IOU report actions. */ @@ -5177,7 +5177,7 @@ function deleteAppReport(reportID: string | undefined) { selfDMCreatedReportActionID: selfDMParameters.createdReportActionID, }; - API.write(WRITE_COMMANDS.DELETE_APP_REPORT, parameters, {optimisticData, successData, failureData}); + void API.write(WRITE_COMMANDS.DELETE_APP_REPORT, parameters, {optimisticData, successData, failureData}); } /** @@ -5371,7 +5371,7 @@ function moveIOUReportToPolicy(reportID: string, policyID: string, isFromSettlem optimisticReportID: expenseChatReportId, }; - API.write(WRITE_COMMANDS.MOVE_IOU_REPORT_TO_EXISTING_POLICY, parameters, {optimisticData, successData, failureData}); + void API.write(WRITE_COMMANDS.MOVE_IOU_REPORT_TO_EXISTING_POLICY, parameters, {optimisticData, successData, failureData}); } /** @@ -5630,7 +5630,7 @@ function moveIOUReportToPolicyAndInviteSubmitter( dmMovedReportActionID: movedReportAction.reportActionID, }; - API.write(WRITE_COMMANDS.MOVE_IOU_REPORT_TO_POLICY_AND_INVITE_SUBMITTER, parameters, {optimisticData, successData, failureData}); + void API.write(WRITE_COMMANDS.MOVE_IOU_REPORT_TO_POLICY_AND_INVITE_SUBMITTER, parameters, {optimisticData, successData, failureData}); return {policyExpenseChatReportID: optimisticPolicyExpenseChatReportID}; } @@ -5651,7 +5651,7 @@ function dismissChangePolicyModal() { }, }, ]; - API.write(WRITE_COMMANDS.DISMISS_PRODUCT_TRAINING, {name: CONST.CHANGE_POLICY_TRAINING_MODAL, dismissedMethod: 'click'}, {optimisticData}); + void API.write(WRITE_COMMANDS.DISMISS_PRODUCT_TRAINING, {name: CONST.CHANGE_POLICY_TRAINING_MODAL, dismissedMethod: 'click'}, {optimisticData}); } /** @@ -5711,7 +5711,7 @@ function navigateToTrainingModal(dismissedProductTrainingNVP: OnyxEntry { + void InteractionManager.runAfterInteractions(() => { Navigation.navigate(ROUTES.CHANGE_POLICY_EDUCATIONAL.getRoute(ROUTES.REPORT_WITH_ID.getRoute(reportID))); }); } @@ -5975,7 +5975,7 @@ function changeReportPolicy(report: Report, policy: Policy, reportNextStep?: Rep reportPreviewReportActionID: optimisticReportPreviewAction.reportActionID, changePolicyReportActionID: optimisticMovedReportAction.reportActionID, }; - API.write(WRITE_COMMANDS.CHANGE_REPORT_POLICY, params, {optimisticData, successData, failureData}); + void API.write(WRITE_COMMANDS.CHANGE_REPORT_POLICY, params, {optimisticData, successData, failureData}); // If the dismissedProductTraining.changeReportModal is not set, // navigate to CHANGE_POLICY_EDUCATIONAL and a backTo param for the report page. @@ -6036,7 +6036,7 @@ function changeReportPolicyAndInviteSubmitter( policyExpenseChatReportID: optimisticPolicyExpenseChatReportID, policyExpenseCreatedReportActionID: optimisticPolicyExpenseChatCreatedReportActionID, }; - API.write(WRITE_COMMANDS.CHANGE_REPORT_POLICY_AND_INVITE_SUBMITTER, params, {optimisticData, successData, failureData}); + void API.write(WRITE_COMMANDS.CHANGE_REPORT_POLICY_AND_INVITE_SUBMITTER, params, {optimisticData, successData, failureData}); // If the dismissedProductTraining.changeReportModal is not set, // navigate to CHANGE_POLICY_EDUCATIONAL and a backTo param for the report page. @@ -6063,7 +6063,7 @@ function resolveConciergeCategoryOptions( addComment(reportID, selectedCategory, timezoneParam); - Onyx.merge(`${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${actionReportID}`, { + void Onyx.merge(`${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${actionReportID}`, { [reportActionID]: { originalMessage: { selectedCategory, diff --git a/src/libs/actions/ReportActions.ts b/src/libs/actions/ReportActions.ts index e8d7949464d8..1e44ca654292 100644 --- a/src/libs/actions/ReportActions.ts +++ b/src/libs/actions/ReportActions.ts @@ -35,7 +35,7 @@ function clearReportActionErrors(reportID: string, reportAction: ReportAction, k if (reportAction.pendingAction === CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD || reportAction.isOptimisticAction) { // Delete the optimistic action - Onyx.merge(`${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${originalReportID}`, { + void Onyx.merge(`${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${originalReportID}`, { [reportAction.reportActionID]: null, }); @@ -43,8 +43,8 @@ function clearReportActionErrors(reportID: string, reportAction: ReportAction, k // eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing const linkedTransactionID = getLinkedTransactionID(reportAction.reportActionID, originalReportID); if (linkedTransactionID) { - Onyx.set(`${ONYXKEYS.COLLECTION.TRANSACTION}${linkedTransactionID}`, null); - Onyx.set(`${ONYXKEYS.COLLECTION.REPORT}${reportAction.childReportID}`, null); + void Onyx.set(`${ONYXKEYS.COLLECTION.TRANSACTION}${linkedTransactionID}`, null); + void Onyx.set(`${ONYXKEYS.COLLECTION.REPORT}${reportAction.childReportID}`, null); } // Delete the failed task report too @@ -62,14 +62,14 @@ function clearReportActionErrors(reportID: string, reportAction: ReportAction, k errors[key] = null; }); - Onyx.merge(`${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${originalReportID}`, { + void Onyx.merge(`${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${originalReportID}`, { [reportAction.reportActionID]: { errors, }, }); return; } - Onyx.merge(`${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${originalReportID}`, { + void Onyx.merge(`${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${originalReportID}`, { [reportAction.reportActionID]: { errors: null, }, diff --git a/src/libs/actions/RoomMembersUserSearchPhrase.ts b/src/libs/actions/RoomMembersUserSearchPhrase.ts index e057fd1487c1..a9ec02e4e0d7 100644 --- a/src/libs/actions/RoomMembersUserSearchPhrase.ts +++ b/src/libs/actions/RoomMembersUserSearchPhrase.ts @@ -2,14 +2,14 @@ import Onyx from 'react-native-onyx'; import ONYXKEYS from '@src/ONYXKEYS'; function clearUserSearchPhrase() { - Onyx.merge(ONYXKEYS.ROOM_MEMBERS_USER_SEARCH_PHRASE, ''); + void Onyx.merge(ONYXKEYS.ROOM_MEMBERS_USER_SEARCH_PHRASE, ''); } /** * Persists user search phrase from the search input across the screens. */ function updateUserSearchPhrase(value: string) { - Onyx.merge(ONYXKEYS.ROOM_MEMBERS_USER_SEARCH_PHRASE, value); + void Onyx.merge(ONYXKEYS.ROOM_MEMBERS_USER_SEARCH_PHRASE, value); } export {clearUserSearchPhrase, updateUserSearchPhrase}; diff --git a/src/libs/actions/ScheduleCall.ts b/src/libs/actions/ScheduleCall.ts index d33e57ceeb54..205fd69356c1 100644 --- a/src/libs/actions/ScheduleCall.ts +++ b/src/libs/actions/ScheduleCall.ts @@ -61,11 +61,11 @@ function getGuideCallAvailabilitySchedule(reportID: string) { } function saveBookingDraft(data: ScheduleCallDraft) { - Onyx.merge(`${ONYXKEYS.SCHEDULE_CALL_DRAFT}`, data); + void Onyx.merge(`${ONYXKEYS.SCHEDULE_CALL_DRAFT}`, data); } function clearBookingDraft() { - Onyx.set(`${ONYXKEYS.SCHEDULE_CALL_DRAFT}`, null); + void Onyx.set(`${ONYXKEYS.SCHEDULE_CALL_DRAFT}`, null); } function confirmBooking(data: Required, currentUser: PersonalDetails, timezone?: SelectedTimezone) { @@ -99,7 +99,7 @@ function sendScheduleCallNudge(accountID: number, reportID: string) { accountID, reportID, }; - API.write(WRITE_COMMANDS.SEND_SCHEDULE_CALL_NUDGE, params); + void API.write(WRITE_COMMANDS.SEND_SCHEDULE_CALL_NUDGE, params); } export {getGuideCallAvailabilitySchedule, saveBookingDraft, clearBookingDraft, confirmBooking, rescheduleBooking, cancelBooking, sendScheduleCallNudge}; diff --git a/src/libs/actions/Search.ts b/src/libs/actions/Search.ts index ead77cd4fd5c..3dccdfb803ef 100644 --- a/src/libs/actions/Search.ts +++ b/src/libs/actions/Search.ts @@ -251,7 +251,7 @@ function saveSearch({queryJSON, newName}: {queryJSON: SearchQueryJSON; newName?: }, }, ]; - API.write(WRITE_COMMANDS.SAVE_SEARCH, {jsonQuery, newName: saveSearchName}, {optimisticData, failureData, successData}); + void API.write(WRITE_COMMANDS.SAVE_SEARCH, {jsonQuery, newName: saveSearchName}, {optimisticData, failureData, successData}); } function deleteSavedSearch(hash: number) { @@ -287,7 +287,7 @@ function deleteSavedSearch(hash: number) { }, ]; - API.write(WRITE_COMMANDS.DELETE_SAVED_SEARCH, {hash}, {optimisticData, failureData, successData}); + void API.write(WRITE_COMMANDS.DELETE_SAVED_SEARCH, {hash}, {optimisticData, failureData, successData}); } function openSearchPage() { @@ -330,7 +330,7 @@ function updateSearchResultsWithTransactionThreadReportID(hash: number, transact }, }, }; - Onyx.merge(`${ONYXKEYS.COLLECTION.SNAPSHOT}${hash}`, onyxUpdate); + void Onyx.merge(`${ONYXKEYS.COLLECTION.SNAPSHOT}${hash}`, onyxUpdate); } function holdMoneyRequestOnSearch(hash: number, transactionIDList: string[], comment: string, allTransactions: OnyxCollection, allReportActions: OnyxCollection) { @@ -352,7 +352,7 @@ function holdMoneyRequestOnSearch(hash: number, transactionIDList: string[], com } }); - API.write(WRITE_COMMANDS.HOLD_MONEY_REQUEST_ON_SEARCH, {hash, transactionIDList, comment}, {optimisticData, finallyData}); + void API.write(WRITE_COMMANDS.HOLD_MONEY_REQUEST_ON_SEARCH, {hash, transactionIDList, comment}, {optimisticData, finallyData}); } function submitMoneyRequestOnSearch(hash: number, reportList: SearchReport[], policy: SearchPolicy[], transactionIDList?: string[], currentSearchKey?: SearchKey) { @@ -382,7 +382,7 @@ function submitMoneyRequestOnSearch(hash: number, reportList: SearchReport[], po // The SubmitReport command is not 1:1:1 yet, which means creating a separate SubmitMoneyRequestOnSearch command is not feasible until https://github.com/Expensify/Expensify/issues/451223 is done. // In the meantime, we'll call SubmitReport which works for a single expense only, so not bulk actions are possible. - API.write(WRITE_COMMANDS.SUBMIT_REPORT, parameters, {optimisticData, successData, failureData}); + void API.write(WRITE_COMMANDS.SUBMIT_REPORT, parameters, {optimisticData, successData, failureData}); } function approveMoneyRequestOnSearch(hash: number, reportIDList: string[], transactionIDList?: string[], currentSearchKey?: SearchKey) { @@ -406,8 +406,8 @@ function approveMoneyRequestOnSearch(hash: number, reportIDList: string[], trans const successData: OnyxUpdate[] = approveActionSuggestedSearches.includes(currentSearchKey) ? createOnyxData(null) : createOnyxData({isActionLoading: false}); - playSound(SOUNDS.SUCCESS); - API.write(WRITE_COMMANDS.APPROVE_MONEY_REQUEST_ON_SEARCH, {hash, reportIDList}, {optimisticData, failureData, successData}); + void playSound(SOUNDS.SUCCESS); + void API.write(WRITE_COMMANDS.APPROVE_MONEY_REQUEST_ON_SEARCH, {hash, reportIDList}, {optimisticData, failureData, successData}); } function exportToIntegrationOnSearch(hash: number, reportID: string, connectionName: ConnectionName, currentSearchKey?: SearchKey) { @@ -448,7 +448,7 @@ function exportToIntegrationOnSearch(hash: number, reportID: string, connectionN }), } satisfies ReportExportParams; - API.write(WRITE_COMMANDS.REPORT_EXPORT, params, {optimisticData, failureData, successData}); + void API.write(WRITE_COMMANDS.REPORT_EXPORT, params, {optimisticData, failureData, successData}); } function payMoneyRequestOnSearch(hash: number, paymentData: PaymentData[], transactionIDList?: string[], currentSearchKey?: SearchKey) { @@ -470,7 +470,7 @@ function payMoneyRequestOnSearch(hash: number, paymentData: PaymentData[], trans const successData: OnyxUpdate[] = currentSearchKey === CONST.SEARCH.SEARCH_KEYS.PAY ? createOnyxData(null) : createOnyxData({isActionLoading: false}); // eslint-disable-next-line rulesdir/no-api-side-effects-method - API.makeRequestWithSideEffects( + void API.makeRequestWithSideEffects( SIDE_EFFECT_REQUEST_COMMANDS.PAY_MONEY_REQUEST_ON_SEARCH, {hash, paymentData: JSON.stringify(paymentData)}, {optimisticData, failureData, successData}, @@ -478,14 +478,14 @@ function payMoneyRequestOnSearch(hash: number, paymentData: PaymentData[], trans if (response?.jsonCode !== CONST.JSON_CODE.SUCCESS) { return; } - playSound(SOUNDS.SUCCESS); + void playSound(SOUNDS.SUCCESS); }); } function unholdMoneyRequestOnSearch(hash: number, transactionIDList: string[]) { const {optimisticData, finallyData} = getOnyxLoadingData(hash); - API.write(WRITE_COMMANDS.UNHOLD_MONEY_REQUEST_ON_SEARCH, {hash, transactionIDList}, {optimisticData, finallyData}); + void API.write(WRITE_COMMANDS.UNHOLD_MONEY_REQUEST_ON_SEARCH, {hash, transactionIDList}, {optimisticData, finallyData}); } function deleteMoneyRequestOnSearch(hash: number, transactionIDList: string[]) { @@ -513,7 +513,7 @@ function deleteMoneyRequestOnSearch(hash: number, transactionIDList: string[]) { }, }, ]; - API.write(WRITE_COMMANDS.DELETE_MONEY_REQUEST_ON_SEARCH, {hash, transactionIDList}, {optimisticData, failureData, finallyData}); + void API.write(WRITE_COMMANDS.DELETE_MONEY_REQUEST_ON_SEARCH, {hash, transactionIDList}, {optimisticData, failureData, finallyData}); } type Params = Record; @@ -535,7 +535,7 @@ function exportSearchItemsToCSV({query, jsonQuery, reportIDList, transactionIDLi } }); - fileDownload(getCommandURL({command: WRITE_COMMANDS.EXPORT_SEARCH_ITEMS_TO_CSV}), 'Expensify.csv', '', false, formData, CONST.NETWORK.METHOD.POST, onDownloadFailed); + void fileDownload(getCommandURL({command: WRITE_COMMANDS.EXPORT_SEARCH_ITEMS_TO_CSV}), 'Expensify.csv', '', false, formData, CONST.NETWORK.METHOD.POST, onDownloadFailed); } function queueExportSearchItemsToCSV({query, jsonQuery, reportIDList, transactionIDList}: ExportSearchItemsToCSVParams) { @@ -546,7 +546,7 @@ function queueExportSearchItemsToCSV({query, jsonQuery, reportIDList, transactio transactionIDList, }) as ExportSearchItemsToCSVParams; - API.write(WRITE_COMMANDS.QUEUE_EXPORT_SEARCH_ITEMS_TO_CSV, finalParameters); + void API.write(WRITE_COMMANDS.QUEUE_EXPORT_SEARCH_ITEMS_TO_CSV, finalParameters); } function queueExportSearchWithTemplate({templateName, templateType, jsonQuery, reportIDList, transactionIDList, policyID}: ExportSearchWithTemplateParams) { @@ -559,24 +559,24 @@ function queueExportSearchWithTemplate({templateName, templateType, jsonQuery, r policyID, }) as ExportSearchWithTemplateParams; - API.write(WRITE_COMMANDS.QUEUE_EXPORT_SEARCH_WITH_TEMPLATE, finalParameters); + void API.write(WRITE_COMMANDS.QUEUE_EXPORT_SEARCH_WITH_TEMPLATE, finalParameters); } /** * Updates the form values for the advanced filters search form. */ function updateAdvancedFilters(values: Nullable>>, shouldUseOnyxSetMethod = false) { if (shouldUseOnyxSetMethod) { - Onyx.set(ONYXKEYS.FORMS.SEARCH_ADVANCED_FILTERS_FORM, values); + void Onyx.set(ONYXKEYS.FORMS.SEARCH_ADVANCED_FILTERS_FORM, values); return; } - Onyx.merge(ONYXKEYS.FORMS.SEARCH_ADVANCED_FILTERS_FORM, values); + void Onyx.merge(ONYXKEYS.FORMS.SEARCH_ADVANCED_FILTERS_FORM, values); } /** * Clears all values for the advanced filters search form. */ function clearAllFilters() { - Onyx.set(ONYXKEYS.FORMS.SEARCH_ADVANCED_FILTERS_FORM, null); + void Onyx.set(ONYXKEYS.FORMS.SEARCH_ADVANCED_FILTERS_FORM, null); } function clearAdvancedFilters() { @@ -597,7 +597,7 @@ function clearAdvancedFilters() { values[key] = null; }); - Onyx.merge(ONYXKEYS.FORMS.SEARCH_ADVANCED_FILTERS_FORM, values); + void Onyx.merge(ONYXKEYS.FORMS.SEARCH_ADVANCED_FILTERS_FORM, values); } export { diff --git a/src/libs/actions/Session/index.ts b/src/libs/actions/Session/index.ts index 619db3be8371..b9bff87dc40d 100644 --- a/src/libs/actions/Session/index.ts +++ b/src/libs/actions/Session/index.ts @@ -145,7 +145,7 @@ function isSupportAuthToken(): boolean { * Sets the SupportToken. This method will only be used on dev. */ function setSupportAuthToken(supportAuthToken: string, email: string, accountID: number) { - Onyx.merge(ONYXKEYS.SESSION, { + void Onyx.merge(ONYXKEYS.SESSION, { authTokenType: CONST.AUTH_TOKEN_TYPES.SUPPORT, authToken: supportAuthToken, email, @@ -154,7 +154,7 @@ function setSupportAuthToken(supportAuthToken: string, email: string, accountID: }).then(() => { Log.info('[Supportal] Auth token set'); }); - Onyx.set(ONYXKEYS.LAST_VISITED_PATH, ''); + void Onyx.set(ONYXKEYS.LAST_VISITED_PATH, ''); } function getShortLivedLoginParams(isSupportAuthTokenUsed = false, isSAML = false) { @@ -360,7 +360,7 @@ function signOutAndRedirectToSignIn(shouldResetToHome?: boolean, shouldStashSess Log.info('Redirecting to OldDot sign out'); asyncOpenURL( redirectToSignIn().then(() => { - Onyx.multiSet(onyxSetParams); + void Onyx.multiSet(onyxSetParams); }), `${CONFIG.EXPENSIFY.EXPENSIFY_URL}${CONST.OLDDOT_URLS.SIGN_OUT}`, true, @@ -368,7 +368,7 @@ function signOutAndRedirectToSignIn(shouldResetToHome?: boolean, shouldStashSess ); } else { redirectToSignIn().then(() => { - Onyx.multiSet(onyxSetParams); + void Onyx.multiSet(onyxSetParams); if (hasSwitchedAccountInHybridMode) { openApp(); @@ -420,7 +420,7 @@ function resendValidateCode(login = credentials.login) { const params: RequestNewValidateCodeParams = {email: login}; - API.write(WRITE_COMMANDS.REQUEST_NEW_VALIDATE_CODE, params, {optimisticData, finallyData}); + void API.write(WRITE_COMMANDS.REQUEST_NEW_VALIDATE_CODE, params, {optimisticData, finallyData}); } type OnyxData = { @@ -544,7 +544,7 @@ function signUpUser() { const params: SignUpUserParams = {email: credentials.login, preferredLocale}; - API.write(WRITE_COMMANDS.SIGN_UP_USER, params, {optimisticData, successData, failureData}); + void API.write(WRITE_COMMANDS.SIGN_UP_USER, params, {optimisticData, successData, failureData}); } function setupNewDotAfterTransitionFromOldDot(hybridAppSettings: HybridAppSettings, tryNewDot?: TryNewDot) { @@ -590,30 +590,31 @@ function setupNewDotAfterTransitionFromOldDot(hybridAppSettings: HybridAppSettin }; Log.info('[HybridApp] User switched account on OldDot side. Clearing onyx and applying delegate data'); - return Onyx.clear(KEYS_TO_PRESERVE_DELEGATE_ACCESS).then(() => - Onyx.multiSet({ - ...stashedData, - [ONYXKEYS.SESSION]: { - email: hybridApp?.delegateAccessData?.oldDotCurrentUserEmail, - authToken: hybridApp?.delegateAccessData?.oldDotCurrentAuthToken, - encryptedAuthToken: decodeURIComponent(hybridApp?.delegateAccessData?.oldDotCurrentEncryptedAuthToken ?? ''), - accountID: hybridApp?.delegateAccessData?.oldDotCurrentAccountID, - }, - // When a logged-in user opens NewDot for the first time after migrating to the new SignInPage, there will be no credentials on the NewDot side. - // After migration, NewDot is responsible for creating credentials, but this only happens during sign-in. - // To avoid blocking the transition, we fall back to credentials from OldDot in this scenario. - // The `delegateAccessData` key is misleading in this context because, in the past, this code only handled Copilot. We are reusing the same logic here for this scenario. - [ONYXKEYS.CREDENTIALS]: { - autoGeneratedLogin: credentials?.autoGeneratedLogin ?? hybridApp.delegateAccessData?.oldDotAutoGeneratedLogin, - autoGeneratedPassword: credentials?.autoGeneratedPassword ?? hybridApp.delegateAccessData?.oldDotAutoGeneratedPassword, - }, - }) - .then(() => Onyx.merge(ONYXKEYS.ACCOUNT, {primaryLogin: hybridApp?.delegateAccessData?.oldDotCurrentUserEmail})) - .then(() => { - Log.info('[HybridApp] Calling openApp to get delegate account details'); - confirmReadyToOpenApp(); - return openApp(); - }), + return Onyx.clear(KEYS_TO_PRESERVE_DELEGATE_ACCESS).then( + () => + void Onyx.multiSet({ + ...stashedData, + [ONYXKEYS.SESSION]: { + email: hybridApp?.delegateAccessData?.oldDotCurrentUserEmail, + authToken: hybridApp?.delegateAccessData?.oldDotCurrentAuthToken, + encryptedAuthToken: decodeURIComponent(hybridApp?.delegateAccessData?.oldDotCurrentEncryptedAuthToken ?? ''), + accountID: hybridApp?.delegateAccessData?.oldDotCurrentAccountID, + }, + // When a logged-in user opens NewDot for the first time after migrating to the new SignInPage, there will be no credentials on the NewDot side. + // After migration, NewDot is responsible for creating credentials, but this only happens during sign-in. + // To avoid blocking the transition, we fall back to credentials from OldDot in this scenario. + // The `delegateAccessData` key is misleading in this context because, in the past, this code only handled Copilot. We are reusing the same logic here for this scenario. + [ONYXKEYS.CREDENTIALS]: { + autoGeneratedLogin: credentials?.autoGeneratedLogin ?? hybridApp.delegateAccessData?.oldDotAutoGeneratedLogin, + autoGeneratedPassword: credentials?.autoGeneratedPassword ?? hybridApp.delegateAccessData?.oldDotAutoGeneratedPassword, + }, + }) + .then(() => Onyx.merge(ONYXKEYS.ACCOUNT, {primaryLogin: hybridApp?.delegateAccessData?.oldDotCurrentUserEmail})) + .then(() => { + Log.info('[HybridApp] Calling openApp to get delegate account details'); + confirmReadyToOpenApp(); + return openApp(); + }), ); }) .then(() => @@ -643,7 +644,7 @@ function beginAppleSignIn(idToken: string | undefined | null) { const params: BeginAppleSignInParams = {idToken, preferredLocale}; - API.write(WRITE_COMMANDS.SIGN_IN_WITH_APPLE, params, {optimisticData, successData, failureData}); + void API.write(WRITE_COMMANDS.SIGN_IN_WITH_APPLE, params, {optimisticData, successData, failureData}); } /** @@ -655,7 +656,7 @@ function beginGoogleSignIn(token: string | null) { const params: BeginGoogleSignInParams = {token, preferredLocale}; - API.write(WRITE_COMMANDS.SIGN_IN_WITH_GOOGLE, params, {optimisticData, successData, failureData}); + void API.write(WRITE_COMMANDS.SIGN_IN_WITH_GOOGLE, params, {optimisticData, successData, failureData}); } /** @@ -733,7 +734,7 @@ function signIn(validateCode: string, twoFactorAuthCode?: string) { params.validateCode = validateCode || credentials.validateCode; } - API.write(WRITE_COMMANDS.SIGN_IN_USER, params, {optimisticData, successData, failureData}); + void API.write(WRITE_COMMANDS.SIGN_IN_USER, params, {optimisticData, successData, failureData}); }); } @@ -809,7 +810,7 @@ function signInWithValidateCode(accountID: number, code: string, twoFactorAuthCo deviceInfo, }; - API.write(WRITE_COMMANDS.SIGN_IN_USER_WITH_LINK, params, {optimisticData, successData, failureData}); + void API.write(WRITE_COMMANDS.SIGN_IN_USER_WITH_LINK, params, {optimisticData, successData, failureData}); }); } @@ -824,18 +825,18 @@ function signInWithValidateCode(accountID: number, code: string, twoFactorAuthCo function initAutoAuthState(cachedAutoAuthState: AutoAuthState) { const signedInStates: AutoAuthState[] = [CONST.AUTO_AUTH_STATE.SIGNING_IN, CONST.AUTO_AUTH_STATE.JUST_SIGNED_IN]; - Onyx.merge(ONYXKEYS.SESSION, { + void Onyx.merge(ONYXKEYS.SESSION, { autoAuthState: signedInStates.includes(cachedAutoAuthState) ? CONST.AUTO_AUTH_STATE.JUST_SIGNED_IN : CONST.AUTO_AUTH_STATE.NOT_STARTED, }); } function invalidateCredentials() { - Onyx.merge(ONYXKEYS.CREDENTIALS, {autoGeneratedLogin: '', autoGeneratedPassword: ''}); + void Onyx.merge(ONYXKEYS.CREDENTIALS, {autoGeneratedLogin: '', autoGeneratedPassword: ''}); } function invalidateAuthToken() { NetworkStore.setAuthToken(INVALID_TOKEN); - Onyx.merge(ONYXKEYS.SESSION, {authToken: INVALID_TOKEN, encryptedAuthToken: INVALID_TOKEN}); + void Onyx.merge(ONYXKEYS.SESSION, {authToken: INVALID_TOKEN, encryptedAuthToken: INVALID_TOKEN}); } /** @@ -845,7 +846,7 @@ function expireSessionWithDelay() { // expires the session after 15s setTimeout(() => { NetworkStore.setAuthToken(INVALID_TOKEN); - Onyx.merge(ONYXKEYS.SESSION, {authToken: INVALID_TOKEN, encryptedAuthToken: INVALID_TOKEN, creationDate: new Date().getTime() - CONST.SESSION_EXPIRATION_TIME_MS}); + void Onyx.merge(ONYXKEYS.SESSION, {authToken: INVALID_TOKEN, encryptedAuthToken: INVALID_TOKEN, creationDate: new Date().getTime() - CONST.SESSION_EXPIRATION_TIME_MS}); }, 15000); } @@ -853,18 +854,18 @@ function expireSessionWithDelay() { * Clear the credentials and partial sign in session so the user can taken back to first Login step */ function clearSignInData() { - Onyx.multiSet({ + void Onyx.multiSet({ [ONYXKEYS.ACCOUNT]: null, [ONYXKEYS.CREDENTIALS]: null, }); - Onyx.merge(ONYXKEYS.HYBRID_APP, {signingInWithSAML: null}); + void Onyx.merge(ONYXKEYS.HYBRID_APP, {signingInWithSAML: null}); } /** * Reset navigation to a brand new state with Home as the initial screen. */ function resetNavigationState() { - Navigation.isNavigationReady().then(() => { + void Navigation.isNavigationReady().then(() => { navigationRef.resetRoot({index: 0, routes: [{name: NAVIGATORS.REPORTS_SPLIT_NAVIGATOR}]}); }); } @@ -892,7 +893,7 @@ function cleanupSession() { } function clearAccountMessages() { - Onyx.merge(ONYXKEYS.ACCOUNT, { + void Onyx.merge(ONYXKEYS.ACCOUNT, { success: '', errors: null, message: null, @@ -901,7 +902,7 @@ function clearAccountMessages() { } function setAccountError(error: string) { - Onyx.merge(ONYXKEYS.ACCOUNT, {errors: ErrorUtils.getMicroSecondOnyxErrorWithMessage(error)}); + void Onyx.merge(ONYXKEYS.ACCOUNT, {errors: ErrorUtils.getMicroSecondOnyxErrorWithMessage(error)}); } // It's necessary to throttle requests to reauthenticate since calling this multiple times will cause Pusher to @@ -1013,7 +1014,7 @@ function requestUnlinkValidationLink() { const params: RequestUnlinkValidationLinkParams = {email: credentials.login}; - API.write(WRITE_COMMANDS.REQUEST_UNLINK_VALIDATION_LINK, params, {optimisticData, successData, failureData}); + void API.write(WRITE_COMMANDS.REQUEST_UNLINK_VALIDATION_LINK, params, {optimisticData, successData, failureData}); } function unlinkLogin(accountID: number, validateCode: string) { @@ -1059,7 +1060,7 @@ function unlinkLogin(accountID: number, validateCode: string) { validateCode, }; - API.write(WRITE_COMMANDS.UNLINK_LOGIN, params, { + void API.write(WRITE_COMMANDS.UNLINK_LOGIN, params, { optimisticData, successData, failureData, @@ -1101,7 +1102,7 @@ function toggleTwoFactorAuth(enable: boolean, twoFactorAuthCode = '') { ]; if (enable) { - API.write(WRITE_COMMANDS.ENABLE_TWO_FACTOR_AUTH, null, {optimisticData, successData, failureData}); + void API.write(WRITE_COMMANDS.ENABLE_TWO_FACTOR_AUTH, null, {optimisticData, successData, failureData}); return; } @@ -1109,11 +1110,11 @@ function toggleTwoFactorAuth(enable: boolean, twoFactorAuthCode = '') { const params: DisableTwoFactorAuthParams = {twoFactorAuthCode}; // eslint-disable-next-line rulesdir/no-multiple-api-calls - API.write(WRITE_COMMANDS.DISABLE_TWO_FACTOR_AUTH, params, {optimisticData, successData, failureData}); + void API.write(WRITE_COMMANDS.DISABLE_TWO_FACTOR_AUTH, params, {optimisticData, successData, failureData}); } function clearDisableTwoFactorAuthErrors() { - Onyx.merge(ONYXKEYS.ACCOUNT, {errorFields: {requiresTwoFactorAuth: null}}); + void Onyx.merge(ONYXKEYS.ACCOUNT, {errorFields: {requiresTwoFactorAuth: null}}); } function updateAuthTokenAndOpenApp(authToken?: string, encryptedAuthToken?: string) { @@ -1162,7 +1163,7 @@ function validateTwoFactorAuth(twoFactorAuthCode: string, shouldClearData: boole const params: ValidateTwoFactorAuthParams = {twoFactorAuthCode}; // eslint-disable-next-line rulesdir/no-api-side-effects-method - API.makeRequestWithSideEffects(SIDE_EFFECT_REQUEST_COMMANDS.TWO_FACTOR_AUTH_VALIDATE, params, {optimisticData, successData, failureData}).then((response) => { + void API.makeRequestWithSideEffects(SIDE_EFFECT_REQUEST_COMMANDS.TWO_FACTOR_AUTH_VALIDATE, params, {optimisticData, successData, failureData}).then((response) => { if (!response?.authToken) { return; } @@ -1170,7 +1171,7 @@ function validateTwoFactorAuth(twoFactorAuthCode: string, shouldClearData: boole // Clear onyx data if the user has just signed in and is forced to add 2FA if (shouldClearData) { const keysToPreserveWithPrivatePersonalDetails = [...KEYS_TO_PRESERVE, ONYXKEYS.PRIVATE_PERSONAL_DETAILS]; - Onyx.clear(keysToPreserveWithPrivatePersonalDetails).then(() => updateAuthTokenAndOpenApp(response.authToken, response.encryptedAuthToken)); + void Onyx.clear(keysToPreserveWithPrivatePersonalDetails).then(() => updateAuthTokenAndOpenApp(response.authToken, response.encryptedAuthToken)); return; } @@ -1202,7 +1203,7 @@ function waitForUserSignIn(): Promise { } function handleExitToNavigation(exitTo: Route) { - InteractionManager.runAfterInteractions(() => { + void InteractionManager.runAfterInteractions(() => { waitForUserSignIn().then(() => { Navigation.waitForProtectedRoutes().then(() => { Navigation.goBack(); @@ -1288,7 +1289,7 @@ function AddWorkEmail(workEmail: string) { }, ]; - API.write( + void API.write( WRITE_COMMANDS.ADD_WORK_EMAIL, {workEmail}, { @@ -1351,7 +1352,7 @@ function MergeIntoAccountAndLogin(workEmail: string | undefined, validateCode: s ]; // eslint-disable-next-line rulesdir/no-api-side-effects-method - API.makeRequestWithSideEffects( + void API.makeRequestWithSideEffects( SIDE_EFFECT_REQUEST_COMMANDS.MERGE_INTO_ACCOUNT_AND_LOGIN, {workEmail, validateCode, accountID}, { @@ -1363,9 +1364,9 @@ function MergeIntoAccountAndLogin(workEmail: string | undefined, validateCode: s if (response?.jsonCode === CONST.JSON_CODE.EXP_ERROR) { // If the error other than invalid code, we show a blocking screen if (response?.message === CONST.MERGE_ACCOUNT_INVALID_CODE_ERROR || response?.title === CONST.MERGE_ACCOUNT_INVALID_CODE_ERROR) { - Onyx.merge(ONYXKEYS.ONBOARDING_ERROR_MESSAGE, translateLocal('contacts.genericFailureMessages.validateSecondaryLogin')); + void Onyx.merge(ONYXKEYS.ONBOARDING_ERROR_MESSAGE, translateLocal('contacts.genericFailureMessages.validateSecondaryLogin')); } else { - Onyx.merge(ONYXKEYS.NVP_ONBOARDING, {isMergingAccountBlocked: true}); + void Onyx.merge(ONYXKEYS.NVP_ONBOARDING, {isMergingAccountBlocked: true}); } return; } @@ -1425,7 +1426,7 @@ function resetSMSDeliveryFailureStatus(login: string) { }, ]; - API.write(WRITE_COMMANDS.RESET_SMS_DELIVERY_FAILURE_STATUS, params, {optimisticData, successData, failureData}); + void API.write(WRITE_COMMANDS.RESET_SMS_DELIVERY_FAILURE_STATUS, params, {optimisticData, successData, failureData}); } export { diff --git a/src/libs/actions/Session/updateSessionAuthTokens.ts b/src/libs/actions/Session/updateSessionAuthTokens.ts index 8f98cf2fc5dd..6ce8c1391f82 100644 --- a/src/libs/actions/Session/updateSessionAuthTokens.ts +++ b/src/libs/actions/Session/updateSessionAuthTokens.ts @@ -2,5 +2,5 @@ import Onyx from 'react-native-onyx'; import ONYXKEYS from '@src/ONYXKEYS'; export default function updateSessionAuthTokens(authToken?: string, encryptedAuthToken?: string) { - Onyx.merge(ONYXKEYS.SESSION, {authToken, encryptedAuthToken, creationDate: new Date().getTime()}); + void Onyx.merge(ONYXKEYS.SESSION, {authToken, encryptedAuthToken, creationDate: new Date().getTime()}); } diff --git a/src/libs/actions/Session/updateSessionUser.ts b/src/libs/actions/Session/updateSessionUser.ts index 75e888469bec..ad297fbbf940 100644 --- a/src/libs/actions/Session/updateSessionUser.ts +++ b/src/libs/actions/Session/updateSessionUser.ts @@ -2,5 +2,5 @@ import Onyx from 'react-native-onyx'; import ONYXKEYS from '@src/ONYXKEYS'; export default function updateSessionUser(accountID?: number, email?: string) { - Onyx.merge(ONYXKEYS.SESSION, {accountID, email}); + void Onyx.merge(ONYXKEYS.SESSION, {accountID, email}); } diff --git a/src/libs/actions/Share.ts b/src/libs/actions/Share.ts index 5e4b22541ab2..03d1c900f038 100644 --- a/src/libs/actions/Share.ts +++ b/src/libs/actions/Share.ts @@ -8,7 +8,7 @@ import type {Participant} from '@src/types/onyx/IOU'; Function for clearing old saved data before at the start of share-extension flow */ function clearShareData() { - Onyx.multiSet({ + void Onyx.multiSet({ [ONYXKEYS.SHARE_TEMP_FILE]: null, [ONYXKEYS.SHARE_UNKNOWN_USER_DETAILS]: null, }); @@ -21,7 +21,7 @@ function addTempShareFile(file: ShareTempFile) { * @param file shared file's object with additional props */ function addTempShareFile(file: ShareTempFile) { - Onyx.merge(ONYXKEYS.SHARE_TEMP_FILE, file); + void Onyx.merge(ONYXKEYS.SHARE_TEMP_FILE, file); } /** @@ -30,7 +30,7 @@ function addTempShareFile(file: ShareTempFile) { * @param file Array of validated file objects to be saved */ function addValidatedShareFile(file: FileObject[]) { - Onyx.set(ONYXKEYS.VALIDATED_FILE_OBJECT, file.at(0)); + void Onyx.set(ONYXKEYS.VALIDATED_FILE_OBJECT, file.at(0)); } /** @@ -39,14 +39,14 @@ Function storing selected user's details for the duration of share-extension flo * @param user selected user's details */ function saveUnknownUserDetails(user: Participant) { - Onyx.merge(ONYXKEYS.SHARE_UNKNOWN_USER_DETAILS, user); + void Onyx.merge(ONYXKEYS.SHARE_UNKNOWN_USER_DETAILS, user); } /** * Function to clear the unknown user details */ function clearUnknownUserDetails() { - Onyx.merge(ONYXKEYS.SHARE_UNKNOWN_USER_DETAILS, null); + void Onyx.merge(ONYXKEYS.SHARE_UNKNOWN_USER_DETAILS, null); } export {addTempShareFile, saveUnknownUserDetails, clearShareData, addValidatedShareFile, clearUnknownUserDetails}; diff --git a/src/libs/actions/SidePanel.ts b/src/libs/actions/SidePanel.ts index 97597d5f8566..930a6474085f 100644 --- a/src/libs/actions/SidePanel.ts +++ b/src/libs/actions/SidePanel.ts @@ -21,7 +21,7 @@ function openSidePanel(shouldOpenOnNarrowScreen: boolean) { const params: OpenSidePanelParams = {isNarrowScreen: shouldOpenOnNarrowScreen}; - API.write(WRITE_COMMANDS.OPEN_SIDE_PANEL, params, {optimisticData}); + void API.write(WRITE_COMMANDS.OPEN_SIDE_PANEL, params, {optimisticData}); } /** @@ -40,7 +40,7 @@ function closeSidePanel(shouldCloseOnNarrowScreen: boolean) { const params: CloseSidePanelParams = {isNarrowScreen: shouldCloseOnNarrowScreen}; - API.write(WRITE_COMMANDS.CLOSE_SIDE_PANEL, params, {optimisticData}); + void API.write(WRITE_COMMANDS.CLOSE_SIDE_PANEL, params, {optimisticData}); } export default {openSidePanel, closeSidePanel}; diff --git a/src/libs/actions/SignInRedirect.ts b/src/libs/actions/SignInRedirect.ts index fde33410cc57..551d8c9e6789 100644 --- a/src/libs/actions/SignInRedirect.ts +++ b/src/libs/actions/SignInRedirect.ts @@ -49,7 +49,7 @@ function clearStorageAndRedirect(errorMessage?: string): Promise { } // `Onyx.clear` reinitializes the Onyx instance with initial values so use `Onyx.merge` instead of `Onyx.set` - Onyx.merge(ONYXKEYS.SESSION, {errors: getMicroSecondOnyxErrorWithMessage(errorMessage)}); + void Onyx.merge(ONYXKEYS.SESSION, {errors: getMicroSecondOnyxErrorWithMessage(errorMessage)}); }); } diff --git a/src/libs/actions/Subscription.ts b/src/libs/actions/Subscription.ts index 6d65f7b35501..ed996f9eb8a9 100644 --- a/src/libs/actions/Subscription.ts +++ b/src/libs/actions/Subscription.ts @@ -61,7 +61,7 @@ function updateSubscriptionType(type: SubscriptionType) { type, }; - API.write(WRITE_COMMANDS.UPDATE_SUBSCRIPTION_TYPE, parameters, { + void API.write(WRITE_COMMANDS.UPDATE_SUBSCRIPTION_TYPE, parameters, { optimisticData, successData, failureData, @@ -115,7 +115,7 @@ function updateSubscriptionAutoRenew(autoRenew: boolean, disableAutoRenewReason? disableAutoRenewAdditionalNote, }; - API.write(WRITE_COMMANDS.UPDATE_SUBSCRIPTION_AUTO_RENEW, parameters, { + void API.write(WRITE_COMMANDS.UPDATE_SUBSCRIPTION_AUTO_RENEW, parameters, { optimisticData, successData, failureData, @@ -167,7 +167,7 @@ function updateSubscriptionAddNewUsersAutomatically(addNewUsersAutomatically: bo addNewUsersAutomatically, }; - API.write(WRITE_COMMANDS.UPDATE_SUBSCRIPTION_ADD_NEW_USERS_AUTOMATICALLY, parameters, { + void API.write(WRITE_COMMANDS.UPDATE_SUBSCRIPTION_ADD_NEW_USERS_AUTOMATICALLY, parameters, { optimisticData, successData, failureData, @@ -220,11 +220,11 @@ function updateSubscriptionSize(newSubscriptionSize: number, currentSubscription ], }; - API.write(WRITE_COMMANDS.UPDATE_SUBSCRIPTION_SIZE, {userCount: newSubscriptionSize}, onyxData); + void API.write(WRITE_COMMANDS.UPDATE_SUBSCRIPTION_SIZE, {userCount: newSubscriptionSize}, onyxData); } function clearUpdateSubscriptionSizeError() { - Onyx.merge(ONYXKEYS.NVP_PRIVATE_SUBSCRIPTION, { + void Onyx.merge(ONYXKEYS.NVP_PRIVATE_SUBSCRIPTION, { errorFields: { userCount: null, }, @@ -276,7 +276,7 @@ function clearOutstandingBalance() { ], }; - API.write(WRITE_COMMANDS.CLEAR_OUTSTANDING_BALANCE, null, onyxData); + void API.write(WRITE_COMMANDS.CLEAR_OUTSTANDING_BALANCE, null, onyxData); } function cancelBillingSubscription(cancellationReason: FeedbackSurveyOptionID, cancellationNote: string) { @@ -285,11 +285,11 @@ function cancelBillingSubscription(cancellationReason: FeedbackSurveyOptionID, c cancellationNote, }; - API.write(WRITE_COMMANDS.CANCEL_BILLING_SUBSCRIPTION, parameters); + void API.write(WRITE_COMMANDS.CANCEL_BILLING_SUBSCRIPTION, parameters); } function requestTaxExempt() { - API.write(WRITE_COMMANDS.REQUEST_TAX_EXEMPTION, null); + void API.write(WRITE_COMMANDS.REQUEST_TAX_EXEMPTION, null); } export { diff --git a/src/libs/actions/Tab.ts b/src/libs/actions/Tab.ts index 109cf590363c..fa87ae2e30f0 100644 --- a/src/libs/actions/Tab.ts +++ b/src/libs/actions/Tab.ts @@ -6,7 +6,7 @@ import type {SelectedTabRequest} from '@src/types/onyx'; * Sets the selected tab for a given tab ID */ function setSelectedTab(id: string, index: SelectedTabRequest) { - Onyx.merge(`${ONYXKEYS.COLLECTION.SELECTED_TAB}${id}`, index); + void Onyx.merge(`${ONYXKEYS.COLLECTION.SELECTED_TAB}${id}`, index); } export default { diff --git a/src/libs/actions/Task.ts b/src/libs/actions/Task.ts index 6c6ed18b79b7..c937258fc2be 100644 --- a/src/libs/actions/Task.ts +++ b/src/libs/actions/Task.ts @@ -106,9 +106,9 @@ Onyx.connect({ */ function clearOutTaskInfo(skipConfirmation = false) { if (skipConfirmation) { - Onyx.set(ONYXKEYS.TASK, {skipConfirmation: true}); + void Onyx.set(ONYXKEYS.TASK, {skipConfirmation: true}); } else { - Onyx.set(ONYXKEYS.TASK, null); + void Onyx.set(ONYXKEYS.TASK, null); } } @@ -348,11 +348,11 @@ function createTaskAndNavigate( assigneeChatCreatedReportActionID: assigneeChatReportOnyxData?.optimisticChatCreatedReportAction?.reportActionID, }; - playSound(SOUNDS.DONE); - API.write(WRITE_COMMANDS.CREATE_TASK, parameters, {optimisticData, successData, failureData}); + void playSound(SOUNDS.DONE); + void API.write(WRITE_COMMANDS.CREATE_TASK, parameters, {optimisticData, successData, failureData}); if (!isCreatedUsingMarkdown) { - InteractionManager.runAfterInteractions(() => { + void InteractionManager.runAfterInteractions(() => { clearOutTaskInfo(); }); Navigation.dismissModalWithReport({reportID: parentReportID}); @@ -475,8 +475,8 @@ function completeTask(taskReport: OnyxEntry, reportIDFromActio const {optimisticData, successData, failureData, parameters} = buildTaskData(taskReport, taskReportID); - playSound(SOUNDS.SUCCESS); - API.write(WRITE_COMMANDS.COMPLETE_TASK, parameters, {optimisticData, successData, failureData}); + void playSound(SOUNDS.SUCCESS); + void API.write(WRITE_COMMANDS.COMPLETE_TASK, parameters, {optimisticData, successData, failureData}); return {optimisticData, successData, failureData}; } @@ -563,7 +563,7 @@ function reopenTask(taskReport: OnyxEntry, reportIDFromAction? reopenedTaskReportActionID: reopenedTaskReportAction.reportActionID, }; - API.write(WRITE_COMMANDS.REOPEN_TASK, parameters, {optimisticData, successData, failureData}); + void API.write(WRITE_COMMANDS.REOPEN_TASK, parameters, {optimisticData, successData, failureData}); } function editTask(report: OnyxTypes.Report, {title, description}: OnyxTypes.Task) { @@ -643,7 +643,7 @@ function editTask(report: OnyxTypes.Report, {title, description}: OnyxTypes.Task editedTaskReportActionID: editTaskReportAction.reportActionID, }; - API.write(WRITE_COMMANDS.EDIT_TASK, parameters, {optimisticData, successData, failureData}); + void API.write(WRITE_COMMANDS.EDIT_TASK, parameters, {optimisticData, successData, failureData}); } function editTaskAssignee(report: OnyxTypes.Report, sessionAccountID: number, assigneeEmail: string, assigneeAccountID: number | null = 0, assigneeChatReport?: OnyxEntry) { @@ -782,14 +782,14 @@ function editTaskAssignee(report: OnyxTypes.Report, sessionAccountID: number, as assigneeChatCreatedReportActionID: assigneeChatReportOnyxData?.optimisticChatCreatedReportAction?.reportActionID, }; - API.write(WRITE_COMMANDS.EDIT_TASK_ASSIGNEE, parameters, {optimisticData, successData, failureData}); + void API.write(WRITE_COMMANDS.EDIT_TASK_ASSIGNEE, parameters, {optimisticData, successData, failureData}); } /** * Sets the report info for the task being viewed */ function setTaskReport(report: OnyxEntry) { - Onyx.merge(ONYXKEYS.TASK, {report}); + void Onyx.merge(ONYXKEYS.TASK, {report}); } /** @@ -797,21 +797,21 @@ function setTaskReport(report: OnyxEntry) { */ function setDetailsValue(title: string, description: string) { // This is only needed for creation of a new task and so it should only be stored locally - Onyx.merge(ONYXKEYS.TASK, {title: title.trim(), description: description.trim()}); + void Onyx.merge(ONYXKEYS.TASK, {title: title.trim(), description: description.trim()}); } /** * Sets the title value for the task */ function setTitleValue(title: string) { - Onyx.merge(ONYXKEYS.TASK, {title: title.trim()}); + void Onyx.merge(ONYXKEYS.TASK, {title: title.trim()}); } /** * Sets the description value for the task */ function setDescriptionValue(description: string) { - Onyx.merge(ONYXKEYS.TASK, {description: description.trim()}); + void Onyx.merge(ONYXKEYS.TASK, {description: description.trim()}); } /** @@ -819,16 +819,16 @@ function setDescriptionValue(description: string) { */ function setShareDestinationValue(shareDestination: string | undefined) { // This is only needed for creation of a new task and so it should only be stored locally - Onyx.merge(ONYXKEYS.TASK, {shareDestination}); + void Onyx.merge(ONYXKEYS.TASK, {shareDestination}); } /* Sets the assigneeChatReport details for the task */ function setAssigneeChatReport(chatReport: OnyxTypes.Report, isOptimisticReport = false) { - Onyx.merge(ONYXKEYS.TASK, {assigneeChatReport: chatReport}); + void Onyx.merge(ONYXKEYS.TASK, {assigneeChatReport: chatReport}); if (isOptimisticReport) { - Onyx.merge(`${ONYXKEYS.COLLECTION.REPORT_METADATA}${chatReport.reportID}`, {isOptimisticReport}); + void Onyx.merge(`${ONYXKEYS.COLLECTION.REPORT_METADATA}${chatReport.reportID}`, {isOptimisticReport}); } } @@ -841,7 +841,7 @@ function setNewOptimisticAssignee(assigneeLogin: string, assigneeAccountID: numb notificationPreference: CONST.REPORT.NOTIFICATION_PREFERENCE.HIDDEN, }); - Onyx.set(`${ONYXKEYS.COLLECTION.REPORT}${report.reportID}`, report); + void Onyx.set(`${ONYXKEYS.COLLECTION.REPORT}${report.reportID}`, report); const optimisticPersonalDetailsListAction: OnyxTypes.PersonalDetails = { accountID: assigneeAccountID, @@ -849,7 +849,7 @@ function setNewOptimisticAssignee(assigneeLogin: string, assigneeAccountID: numb displayName: allPersonalDetails?.[assigneeAccountID]?.displayName ?? assigneeLogin, login: assigneeLogin, }; - Onyx.merge(ONYXKEYS.PERSONAL_DETAILS_LIST, {[assigneeAccountID]: optimisticPersonalDetailsListAction}); + void Onyx.merge(ONYXKEYS.PERSONAL_DETAILS_LIST, {[assigneeAccountID]: optimisticPersonalDetailsListAction}); return {assignee: optimisticPersonalDetailsListAction, assigneeReport: report}; } @@ -904,7 +904,7 @@ function setAssigneeValue( } // This is only needed for creation of a new task and so it should only be stored locally - Onyx.merge(ONYXKEYS.TASK, {assignee: assigneeEmail, assigneeAccountID}); + void Onyx.merge(ONYXKEYS.TASK, {assignee: assigneeEmail, assigneeAccountID}); // When we're editing the assignee, we immediately call editTaskAssignee. Since setting the assignee is async, // the chatReport is not yet set when editTaskAssignee is called. So we return the chatReport here so that @@ -917,7 +917,7 @@ function setAssigneeValue( */ function setParentReportID(parentReportID: string) { // This is only needed for creation of a new task and so it should only be stored locally - Onyx.merge(ONYXKEYS.TASK, {parentReportID}); + void Onyx.merge(ONYXKEYS.TASK, {parentReportID}); } /** @@ -1203,7 +1203,7 @@ function deleteTask(report: OnyxEntry, isReportArchived: boole taskReportID: report.reportID, }; - API.write(WRITE_COMMANDS.CANCEL_TASK, parameters, {optimisticData, successData, failureData}); + void API.write(WRITE_COMMANDS.CANCEL_TASK, parameters, {optimisticData, successData, failureData}); notifyNewAction(report.reportID, currentUserAccountID); const urlToNavigateBack = getNavigationUrlOnTaskDelete(report); @@ -1300,13 +1300,13 @@ function clearTaskErrors(reportID: string | undefined) { // Delete the task preview in the parent report if (report?.pendingFields?.createChat === CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD) { - Onyx.merge(`${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${report.parentReportID}`, report.parentReportActionID ? {[report.parentReportActionID]: null} : {}); + void Onyx.merge(`${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${report.parentReportID}`, report.parentReportActionID ? {[report.parentReportActionID]: null} : {}); navigateToConciergeChatAndDeleteReport(reportID); return; } - Onyx.merge(`${ONYXKEYS.COLLECTION.REPORT}${reportID}`, { + void Onyx.merge(`${ONYXKEYS.COLLECTION.REPORT}${reportID}`, { pendingFields: null, errorFields: null, }); diff --git a/src/libs/actions/TaxRate.ts b/src/libs/actions/TaxRate.ts index a35e10d0b0de..aa5586014c9c 100644 --- a/src/libs/actions/TaxRate.ts +++ b/src/libs/actions/TaxRate.ts @@ -169,11 +169,11 @@ function createPolicyTax(policyID: string, taxRate: TaxRate) { }), } satisfies CreatePolicyTaxParams; - API.write(WRITE_COMMANDS.CREATE_POLICY_TAX, parameters, onyxData); + void API.write(WRITE_COMMANDS.CREATE_POLICY_TAX, parameters, onyxData); } function clearTaxRateFieldError(policyID: string, taxID: string, field: keyof TaxRate) { - Onyx.merge(`${ONYXKEYS.COLLECTION.POLICY}${policyID}`, { + void Onyx.merge(`${ONYXKEYS.COLLECTION.POLICY}${policyID}`, { taxRates: { taxes: { [taxID]: { @@ -191,7 +191,7 @@ function clearTaxRateFieldError(policyID: string, taxID: string, field: keyof Ta function clearTaxRateError(policyID: string, taxID: string, pendingAction?: OnyxCommon.PendingAction) { if (pendingAction === CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD) { - Onyx.merge(`${ONYXKEYS.COLLECTION.POLICY}${policyID}`, { + void Onyx.merge(`${ONYXKEYS.COLLECTION.POLICY}${policyID}`, { taxRates: { taxes: { [taxID]: null, @@ -200,7 +200,7 @@ function clearTaxRateError(policyID: string, taxID: string, pendingAction?: Onyx }); return; } - Onyx.merge(`${ONYXKEYS.COLLECTION.POLICY}${policyID}`, { + void Onyx.merge(`${ONYXKEYS.COLLECTION.POLICY}${policyID}`, { taxRates: { taxes: { [taxID]: {pendingAction: null, errors: null, errorFields: null}, @@ -278,7 +278,7 @@ function setPolicyTaxesEnabled(policy: OnyxEntry, taxesIDsToUpdate: stri taxFieldsArray: JSON.stringify(taxesIDsToUpdate.map((taxID) => ({taxCode: taxID, enabled: isEnabled}))), } satisfies SetPolicyTaxesEnabledParams; - API.write(WRITE_COMMANDS.SET_POLICY_TAXES_ENABLED, parameters, onyxData); + void API.write(WRITE_COMMANDS.SET_POLICY_TAXES_ENABLED, parameters, onyxData); } type TaxRateDeleteMap = Record< @@ -411,7 +411,7 @@ function deletePolicyTaxes(policy: OnyxEntry, taxesToDelete: string[], l taxNames: JSON.stringify(taxesToDelete.map((taxID) => policyTaxRates[taxID].name)), } satisfies DeletePolicyTaxesParams; - API.write(WRITE_COMMANDS.DELETE_POLICY_TAXES, parameters, onyxData); + void API.write(WRITE_COMMANDS.DELETE_POLICY_TAXES, parameters, onyxData); } function updatePolicyTaxValue(policyID: string, taxID: string, taxValue: number, originalTaxRate: TaxRate) { @@ -475,7 +475,7 @@ function updatePolicyTaxValue(policyID: string, taxID: string, taxValue: number, taxRate: stringTaxValue, } satisfies UpdatePolicyTaxValueParams; - API.write(WRITE_COMMANDS.UPDATE_POLICY_TAX_VALUE, parameters, onyxData); + void API.write(WRITE_COMMANDS.UPDATE_POLICY_TAX_VALUE, parameters, onyxData); } function renamePolicyTax(policyID: string, taxID: string, newName: string, originalTaxRate: TaxRate) { @@ -537,7 +537,7 @@ function renamePolicyTax(policyID: string, taxID: string, newName: string, origi newName, } satisfies RenamePolicyTaxParams; - API.write(WRITE_COMMANDS.RENAME_POLICY_TAX, parameters, onyxData); + void API.write(WRITE_COMMANDS.RENAME_POLICY_TAX, parameters, onyxData); } function setPolicyTaxCode( @@ -647,7 +647,7 @@ function setPolicyTaxCode( taxID: originalTaxRate.name ?? '', }; - API.write(WRITE_COMMANDS.UPDATE_POLICY_TAX_CODE, parameters, onyxData); + void API.write(WRITE_COMMANDS.UPDATE_POLICY_TAX_CODE, parameters, onyxData); } export { diff --git a/src/libs/actions/TeachersUnite.ts b/src/libs/actions/TeachersUnite.ts index c6e4e6fadfc4..e7e646eeb553 100644 --- a/src/libs/actions/TeachersUnite.ts +++ b/src/libs/actions/TeachersUnite.ts @@ -56,7 +56,7 @@ function referTeachersUniteVolunteer(partnerUserID: string, firstName: string, l partnerUserID, }; - API.write(WRITE_COMMANDS.REFER_TEACHERS_UNITE_VOLUNTEER, parameters, {optimisticData}); + void API.write(WRITE_COMMANDS.REFER_TEACHERS_UNITE_VOLUNTEER, parameters, {optimisticData}); Navigation.dismissModalWithReport({reportID: publicRoomReportID}); } @@ -198,7 +198,7 @@ function addSchoolPrincipal( reportCreationData: JSON.stringify(reportCreationData), }; - API.write(WRITE_COMMANDS.ADD_SCHOOL_PRINCIPAL, parameters, {optimisticData, successData, failureData}); + void API.write(WRITE_COMMANDS.ADD_SCHOOL_PRINCIPAL, parameters, {optimisticData, successData, failureData}); Navigation.dismissModalWithReport({reportID: expenseChatReportID}); } diff --git a/src/libs/actions/Tour.ts b/src/libs/actions/Tour.ts index 6873ee3d5163..5f83a6cb5765 100644 --- a/src/libs/actions/Tour.ts +++ b/src/libs/actions/Tour.ts @@ -11,7 +11,7 @@ function startTestDrive( hasUserBeenAddedToNudgeMigration: boolean, isUserPaidPolicyMember: boolean, ) { - InteractionManager.runAfterInteractions(() => { + void InteractionManager.runAfterInteractions(() => { if ( hasUserBeenAddedToNudgeMigration || isUserPaidPolicyMember || diff --git a/src/libs/actions/Transaction.ts b/src/libs/actions/Transaction.ts index daa1fedd0f3a..a00d477a5706 100644 --- a/src/libs/actions/Transaction.ts +++ b/src/libs/actions/Transaction.ts @@ -111,7 +111,7 @@ function isViolationWithName(violation: unknown): violation is {name: string} { } function saveWaypoint(transactionID: string, index: string, waypoint: RecentWaypoint | null, isDraft = false) { - Onyx.merge(`${isDraft ? ONYXKEYS.COLLECTION.TRANSACTION_DRAFT : ONYXKEYS.COLLECTION.TRANSACTION}${transactionID}`, { + void Onyx.merge(`${isDraft ? ONYXKEYS.COLLECTION.TRANSACTION_DRAFT : ONYXKEYS.COLLECTION.TRANSACTION}${transactionID}`, { comment: { waypoints: { [`waypoint${index}`]: waypoint, @@ -157,7 +157,7 @@ function saveWaypoint(transactionID: string, index: string, waypoint: RecentWayp const clonedWaypoints = lodashClone(recentWaypoints); const updatedWaypoint = {...waypoint, pendingAction: CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD}; clonedWaypoints.unshift(updatedWaypoint); - Onyx.merge(ONYXKEYS.NVP_RECENT_WAYPOINTS, clonedWaypoints.slice(0, CONST.RECENT_WAYPOINTS_NUMBER)); + void Onyx.merge(ONYXKEYS.NVP_RECENT_WAYPOINTS, clonedWaypoints.slice(0, CONST.RECENT_WAYPOINTS_NUMBER)); } } @@ -486,7 +486,7 @@ function dismissDuplicateTransactionViolation(transactionIDs: string[], dismisse reportActionIDList: optimisticDismissedViolationReportActions.map(() => NumberUtils.rand64()).join(','), }; - API.write(WRITE_COMMANDS.DISMISS_VIOLATION, params, { + void API.write(WRITE_COMMANDS.DISMISS_VIOLATION, params, { optimisticData, successData, failureData, @@ -494,17 +494,17 @@ function dismissDuplicateTransactionViolation(transactionIDs: string[], dismisse } function setReviewDuplicatesKey(values: Partial) { - Onyx.merge(`${ONYXKEYS.REVIEW_DUPLICATES}`, { + void Onyx.merge(`${ONYXKEYS.REVIEW_DUPLICATES}`, { ...values, }); } function abandonReviewDuplicateTransactions() { - Onyx.set(ONYXKEYS.REVIEW_DUPLICATES, null); + void Onyx.set(ONYXKEYS.REVIEW_DUPLICATES, null); } function clearError(transactionID: string) { - Onyx.merge(`${ONYXKEYS.COLLECTION.TRANSACTION}${transactionID}`, {errors: null, errorFields: {route: null, waypoints: null, routes: null}}); + void Onyx.merge(`${ONYXKEYS.COLLECTION.TRANSACTION}${transactionID}`, {errors: null, errorFields: {route: null, waypoints: null, routes: null}}); } function getLastModifiedExpense(reportID?: string): OriginalMessageModifiedExpense | undefined { @@ -518,7 +518,7 @@ function revert(transaction?: OnyxEntry, originalMessage?: Original return; } - Onyx.merge(`${ONYXKEYS.COLLECTION.TRANSACTION}${transaction.transactionID}`, { + void Onyx.merge(`${ONYXKEYS.COLLECTION.TRANSACTION}${transaction.transactionID}`, { modifiedAmount: transaction?.amount && transaction?.amount < 0 ? -Math.abs(originalMessage.oldAmount) : originalMessage.oldAmount, modifiedCurrency: originalMessage.oldCurrency, }); @@ -602,7 +602,7 @@ function generateTransactionID(): string { } function setTransactionReport(transactionID: string, transaction: Partial, isDraft: boolean) { - Onyx.merge(`${isDraft ? ONYXKEYS.COLLECTION.TRANSACTION_DRAFT : ONYXKEYS.COLLECTION.TRANSACTION}${transactionID}`, transaction); + void Onyx.merge(`${isDraft ? ONYXKEYS.COLLECTION.TRANSACTION_DRAFT : ONYXKEYS.COLLECTION.TRANSACTION}${transactionID}`, transaction); } function changeTransactionsReport( @@ -1182,7 +1182,7 @@ function changeTransactionsReport( transactionIDToReportActionAndThreadData: JSON.stringify(transactionIDToReportActionAndThreadData), }; - API.write(WRITE_COMMANDS.CHANGE_TRANSACTIONS_REPORT, parameters, { + void API.write(WRITE_COMMANDS.CHANGE_TRANSACTIONS_REPORT, parameters, { optimisticData, successData, failureData, diff --git a/src/libs/actions/TransactionEdit.ts b/src/libs/actions/TransactionEdit.ts index ce71ad919d5e..23b97fbdfbfd 100644 --- a/src/libs/actions/TransactionEdit.ts +++ b/src/libs/actions/TransactionEdit.ts @@ -31,11 +31,11 @@ function createBackupTransaction(transaction: OnyxEntry, isDraft: b if (transactionBackup) { // If the transactionBackup exists it means we haven't properly restored original value on unmount // such as on page refresh, so we will just restore the transaction from the transactionBackup here. - Onyx.set(`${isDraft ? ONYXKEYS.COLLECTION.TRANSACTION_DRAFT : ONYXKEYS.COLLECTION.TRANSACTION}${transaction.transactionID}`, transactionBackup); + void Onyx.set(`${isDraft ? ONYXKEYS.COLLECTION.TRANSACTION_DRAFT : ONYXKEYS.COLLECTION.TRANSACTION}${transaction.transactionID}`, transactionBackup); return; } // Use set so that it will always fully overwrite any backup transaction that could have existed before - Onyx.set(`${ONYXKEYS.COLLECTION.TRANSACTION_BACKUP}${transaction.transactionID}`, newTransaction); + void Onyx.set(`${ONYXKEYS.COLLECTION.TRANSACTION_BACKUP}${transaction.transactionID}`, newTransaction); }, }); } @@ -48,7 +48,7 @@ function removeBackupTransaction(transactionID: string | undefined) { return; } - Onyx.set(`${ONYXKEYS.COLLECTION.TRANSACTION_BACKUP}${transactionID}`, null); + void Onyx.set(`${ONYXKEYS.COLLECTION.TRANSACTION_BACKUP}${transactionID}`, null); } function restoreOriginalTransactionFromBackup(transactionID: string | undefined, isDraft: boolean) { @@ -62,7 +62,7 @@ function restoreOriginalTransactionFromBackup(transactionID: string | undefined, Onyx.disconnect(connection); // Use set to completely overwrite the original transaction - Onyx.set(`${isDraft ? ONYXKEYS.COLLECTION.TRANSACTION_DRAFT : ONYXKEYS.COLLECTION.TRANSACTION}${transactionID}`, backupTransaction ?? null); + void Onyx.set(`${isDraft ? ONYXKEYS.COLLECTION.TRANSACTION_DRAFT : ONYXKEYS.COLLECTION.TRANSACTION}${transactionID}`, backupTransaction ?? null); removeBackupTransaction(transactionID); }, }); @@ -78,7 +78,7 @@ function createDraftTransaction(transaction: OnyxEntry) { }; // Use set so that it will always fully overwrite any backup transaction that could have existed before - Onyx.set(`${ONYXKEYS.COLLECTION.TRANSACTION_DRAFT}${transaction.transactionID}`, newTransaction); + void Onyx.set(`${ONYXKEYS.COLLECTION.TRANSACTION_DRAFT}${transaction.transactionID}`, newTransaction); } function removeDraftTransaction(transactionID: string | undefined) { @@ -86,7 +86,7 @@ function removeDraftTransaction(transactionID: string | undefined) { return; } - Onyx.set(`${ONYXKEYS.COLLECTION.TRANSACTION_DRAFT}${transactionID}`, null); + void Onyx.set(`${ONYXKEYS.COLLECTION.TRANSACTION_DRAFT}${transactionID}`, null); } function removeDraftSplitTransaction(transactionID: string | undefined) { @@ -94,7 +94,7 @@ function removeDraftSplitTransaction(transactionID: string | undefined) { return; } - Onyx.set(`${ONYXKEYS.COLLECTION.SPLIT_TRANSACTION_DRAFT}${transactionID}`, null); + void Onyx.set(`${ONYXKEYS.COLLECTION.SPLIT_TRANSACTION_DRAFT}${transactionID}`, null); } function removeDraftTransactions(shouldExcludeInitialTransaction = false, allTransactionDrafts?: OnyxCollection) { @@ -109,7 +109,7 @@ function removeDraftTransactions(shouldExcludeInitialTransaction = false, allTra }, {} as Record, ); - Onyx.multiSet(draftTransactionsSet); + void Onyx.multiSet(draftTransactionsSet); } function replaceDefaultDraftTransaction(transaction: OnyxEntry) { @@ -138,7 +138,7 @@ function removeTransactionReceipt(transactionID: string | undefined) { if (!transactionID) { return; } - Onyx.merge(`${ONYXKEYS.COLLECTION.TRANSACTION_DRAFT}${transactionID}`, {receipt: null}); + void Onyx.merge(`${ONYXKEYS.COLLECTION.TRANSACTION_DRAFT}${transactionID}`, {receipt: null}); } type BuildOptimisticTransactionParams = { diff --git a/src/libs/actions/Travel.ts b/src/libs/actions/Travel.ts index f915f0505380..332f58052022 100644 --- a/src/libs/actions/Travel.ts +++ b/src/libs/actions/Travel.ts @@ -51,7 +51,7 @@ function acceptSpotnanaTerms(domain?: string) { const params: AcceptSpotnanaTermsParams = {domain}; - API.write(WRITE_COMMANDS.ACCEPT_SPOTNANA_TERMS, params, {optimisticData, successData, failureData}); + void API.write(WRITE_COMMANDS.ACCEPT_SPOTNANA_TERMS, params, {optimisticData, successData, failureData}); } function requestTravelAccess() { @@ -64,11 +64,11 @@ function requestTravelAccess() { }, }, ]; - API.write(WRITE_COMMANDS.TRAVEL_SIGNUP_REQUEST, null, {optimisticData}); + void API.write(WRITE_COMMANDS.TRAVEL_SIGNUP_REQUEST, null, {optimisticData}); } function cleanupTravelProvisioningSession() { - Onyx.merge(ONYXKEYS.TRAVEL_PROVISIONING, null); + void Onyx.merge(ONYXKEYS.TRAVEL_PROVISIONING, null); } export {acceptSpotnanaTerms, cleanupTravelProvisioningSession, requestTravelAccess}; diff --git a/src/libs/actions/Troubleshoot.ts b/src/libs/actions/Troubleshoot.ts index 8f149d09d132..b2259c1ecb0f 100644 --- a/src/libs/actions/Troubleshoot.ts +++ b/src/libs/actions/Troubleshoot.ts @@ -6,7 +6,7 @@ import ONYXKEYS from '@src/ONYXKEYS'; * @param shouldRecord Whether or not to record troubleshoot data */ function setShouldRecordTroubleshootData(shouldRecord: boolean) { - Onyx.set(ONYXKEYS.SHOULD_RECORD_TROUBLESHOOT_DATA, shouldRecord); + void Onyx.set(ONYXKEYS.SHOULD_RECORD_TROUBLESHOOT_DATA, shouldRecord); } // eslint-disable-next-line import/prefer-default-export diff --git a/src/libs/actions/TwoFactorAuthActions.ts b/src/libs/actions/TwoFactorAuthActions.ts index 5e205954607a..414fd8812492 100644 --- a/src/libs/actions/TwoFactorAuthActions.ts +++ b/src/libs/actions/TwoFactorAuthActions.ts @@ -8,16 +8,16 @@ import type {Route} from '@src/ROUTES'; * Clear 2FA data if the flow is interrupted without finishing */ function clearTwoFactorAuthData() { - Onyx.merge(ONYXKEYS.ACCOUNT, {recoveryCodes: null, twoFactorAuthSecretKey: null, codesAreCopied: false}); + void Onyx.merge(ONYXKEYS.ACCOUNT, {recoveryCodes: null, twoFactorAuthSecretKey: null, codesAreCopied: false}); } function setCodesAreCopied() { - Onyx.merge(ONYXKEYS.ACCOUNT, {codesAreCopied: true}); + void Onyx.merge(ONYXKEYS.ACCOUNT, {codesAreCopied: true}); } function quitAndNavigateBack(backTo?: Route) { Navigation.goBack(backTo); - InteractionManager.runAfterInteractions(clearTwoFactorAuthData); + void InteractionManager.runAfterInteractions(clearTwoFactorAuthData); } export {clearTwoFactorAuthData, quitAndNavigateBack, setCodesAreCopied}; diff --git a/src/libs/actions/UpdateRequired.ts b/src/libs/actions/UpdateRequired.ts index 078bcc41fd71..c3c080dfe3ce 100644 --- a/src/libs/actions/UpdateRequired.ts +++ b/src/libs/actions/UpdateRequired.ts @@ -2,7 +2,7 @@ import Onyx from 'react-native-onyx'; import ONYXKEYS from '@src/ONYXKEYS'; function alertUser() { - Onyx.set(ONYXKEYS.UPDATE_REQUIRED, true); + void Onyx.set(ONYXKEYS.UPDATE_REQUIRED, true); } export { diff --git a/src/libs/actions/User.ts b/src/libs/actions/User.ts index 2e0c8797a13a..87341e5a07d9 100644 --- a/src/libs/actions/User.ts +++ b/src/libs/actions/User.ts @@ -114,7 +114,7 @@ function closeAccount(reason: string) { const parameters: CloseAccountParams = {message: reason}; - API.write(WRITE_COMMANDS.CLOSE_ACCOUNT, parameters, { + void API.write(WRITE_COMMANDS.CLOSE_ACCOUNT, parameters, { optimisticData, failureData, }); @@ -191,7 +191,7 @@ function requestContactMethodValidateCode(contactMethod: string) { const parameters: RequestContactMethodValidateCodeParams = {email: contactMethod}; - API.write(WRITE_COMMANDS.REQUEST_CONTACT_METHOD_VALIDATE_CODE, parameters, {optimisticData, successData, failureData}); + void API.write(WRITE_COMMANDS.REQUEST_CONTACT_METHOD_VALIDATE_CODE, parameters, {optimisticData, successData, failureData}); } /** @@ -215,7 +215,7 @@ function updateNewsletterSubscription(isSubscribed: boolean) { const parameters: UpdateNewsletterSubscriptionParams = {isSubscribed}; - API.write(WRITE_COMMANDS.UPDATE_NEWSLETTER_SUBSCRIPTION, parameters, { + void API.write(WRITE_COMMANDS.UPDATE_NEWSLETTER_SUBSCRIPTION, parameters, { optimisticData, failureData, }); @@ -274,7 +274,7 @@ function deleteContactMethod(contactMethod: string, loginList: Record, autom automatic, }; - API.write(WRITE_COMMANDS.UPDATE_CHAT_PRIORITY_MODE, parameters, {optimisticData}); + void API.write(WRITE_COMMANDS.UPDATE_CHAT_PRIORITY_MODE, parameters, {optimisticData}); if (!autoSwitchedToFocusMode) { Navigation.goBack(); @@ -1022,7 +1022,7 @@ function setShouldUseStagingServer(shouldUseStagingServer: boolean) { if (CONFIG.IS_HYBRID_APP) { HybridAppModule.shouldUseStaging(shouldUseStagingServer); } - Onyx.set(ONYXKEYS.SHOULD_USE_STAGING_SERVER, shouldUseStagingServer); + void Onyx.set(ONYXKEYS.SHOULD_USE_STAGING_SERVER, shouldUseStagingServer); } function togglePlatformMute(platform: Platform, mutedPlatforms: Partial>) { @@ -1047,7 +1047,7 @@ function togglePlatformMute(platform: Platform, mutedPlatforms: Partial) { value: theme, }; - API.write(WRITE_COMMANDS.UPDATE_THEME, parameters, {optimisticData}); + void API.write(WRITE_COMMANDS.UPDATE_THEME, parameters, {optimisticData}); Navigation.goBack(); } @@ -1304,7 +1304,7 @@ function updateCustomStatus(status: Status) { const parameters: UpdateStatusParams = {text: status.text, emojiCode: status.emojiCode, clearAfter: status.clearAfter}; - API.write(WRITE_COMMANDS.UPDATE_STATUS, parameters, { + void API.write(WRITE_COMMANDS.UPDATE_STATUS, parameters, { optimisticData, }); } @@ -1324,7 +1324,7 @@ function clearCustomStatus() { }, }, ]; - API.write(WRITE_COMMANDS.CLEAR_STATUS, null, {optimisticData}); + void API.write(WRITE_COMMANDS.CLEAR_STATUS, null, {optimisticData}); } /** @@ -1335,14 +1335,14 @@ function clearCustomStatus() { * @param status.clearAfter - ISO 8601 format string, which represents the time when the status should be cleared */ function updateDraftCustomStatus(status: CustomStatusDraft) { - Onyx.merge(ONYXKEYS.CUSTOM_STATUS_DRAFT, status); + void Onyx.merge(ONYXKEYS.CUSTOM_STATUS_DRAFT, status); } /** * Clear the custom draft status */ function clearDraftCustomStatus() { - Onyx.merge(ONYXKEYS.CUSTOM_STATUS_DRAFT, {text: '', emojiCode: '', clearAfter: ''}); + void Onyx.merge(ONYXKEYS.CUSTOM_STATUS_DRAFT, {text: '', emojiCode: '', clearAfter: ''}); } function dismissReferralBanner(type: ValueOf) { @@ -1355,7 +1355,7 @@ function dismissReferralBanner(type: ValueOf, chatReportID = '') { - Onyx.merge(ONYXKEYS.WALLET_TERMS, {source, chatReportID}); + void Onyx.merge(ONYXKEYS.WALLET_TERMS, {source, chatReportID}); } /** @@ -84,7 +84,7 @@ function updatePersonalDetails(personalDetails: UpdatePersonalDetailsForWalletPa }, ]; - API.write(WRITE_COMMANDS.UPDATE_PERSONAL_DETAILS_FOR_WALLET, personalDetails, { + void API.write(WRITE_COMMANDS.UPDATE_PERSONAL_DETAILS_FOR_WALLET, personalDetails, { optimisticData, finallyData, }); @@ -137,7 +137,7 @@ function verifyIdentity(parameters: VerifyIdentityParams) { }, }, ]; - API.write(WRITE_COMMANDS.VERIFY_IDENTITY, parameters, { + void API.write(WRITE_COMMANDS.VERIFY_IDENTITY, parameters, { optimisticData, successData, failureData, @@ -191,7 +191,7 @@ function acceptWalletTerms(parameters: AcceptWalletTermsParams) { const requestParams: AcceptWalletTermsParams = {hasAcceptedTerms: parameters.hasAcceptedTerms, reportID: parameters.reportID}; - API.write(WRITE_COMMANDS.ACCEPT_WALLET_TERMS, requestParams, {optimisticData, successData, failureData}); + void API.write(WRITE_COMMANDS.ACCEPT_WALLET_TERMS, requestParams, {optimisticData, successData, failureData}); } /** @@ -209,7 +209,7 @@ function openEnablePaymentsPage() { } function updateCurrentStep(currentStep: ValueOf | null) { - Onyx.merge(ONYXKEYS.USER_WALLET, {currentStep}); + void Onyx.merge(ONYXKEYS.USER_WALLET, {currentStep}); } function answerQuestionsForWallet(answers: WalletQuestionAnswer[], idNumber: string) { @@ -240,14 +240,14 @@ function answerQuestionsForWallet(answers: WalletQuestionAnswer[], idNumber: str idNumber, }; - API.write(WRITE_COMMANDS.ANSWER_QUESTIONS_FOR_WALLET, requestParams, { + void API.write(WRITE_COMMANDS.ANSWER_QUESTIONS_FOR_WALLET, requestParams, { optimisticData, finallyData, }); } function resetWalletAdditionalDetailsDraft() { - Onyx.set(ONYXKEYS.FORMS.WALLET_ADDITIONAL_DETAILS_DRAFT, null); + void Onyx.set(ONYXKEYS.FORMS.WALLET_ADDITIONAL_DETAILS_DRAFT, null); } function issuerEncryptPayloadCallback(nonce: string, nonceSignature: string, certificates: string[]): Promise { diff --git a/src/libs/actions/Welcome/OnboardingFlow.ts b/src/libs/actions/Welcome/OnboardingFlow.ts index 2620906324eb..e1aef934ee4e 100644 --- a/src/libs/actions/Welcome/OnboardingFlow.ts +++ b/src/libs/actions/Welcome/OnboardingFlow.ts @@ -116,15 +116,15 @@ function getOnboardingInitialPath(getOnboardingInitialPathParams: GetOnboardingI } if (isVsb) { - Onyx.set(ONYXKEYS.ONBOARDING_PURPOSE_SELECTED, CONST.ONBOARDING_CHOICES.MANAGE_TEAM); - Onyx.set(ONYXKEYS.ONBOARDING_COMPANY_SIZE, CONST.ONBOARDING_COMPANY_SIZE.MICRO); + void Onyx.set(ONYXKEYS.ONBOARDING_PURPOSE_SELECTED, CONST.ONBOARDING_CHOICES.MANAGE_TEAM); + void Onyx.set(ONYXKEYS.ONBOARDING_COMPANY_SIZE, CONST.ONBOARDING_COMPANY_SIZE.MICRO); } if (isSmb) { - Onyx.set(ONYXKEYS.ONBOARDING_PURPOSE_SELECTED, CONST.ONBOARDING_CHOICES.MANAGE_TEAM); + void Onyx.set(ONYXKEYS.ONBOARDING_PURPOSE_SELECTED, CONST.ONBOARDING_CHOICES.MANAGE_TEAM); } if (isIndividual) { - Onyx.set(ONYXKEYS.ONBOARDING_CUSTOM_CHOICES, [CONST.ONBOARDING_CHOICES.PERSONAL_SPEND, CONST.ONBOARDING_CHOICES.EMPLOYER, CONST.ONBOARDING_CHOICES.CHAT_SPLIT]); + void Onyx.set(ONYXKEYS.ONBOARDING_CUSTOM_CHOICES, [CONST.ONBOARDING_CHOICES.PERSONAL_SPEND, CONST.ONBOARDING_CHOICES.EMPLOYER, CONST.ONBOARDING_CHOICES.CHAT_SPLIT]); } if (isUserFromPublicDomain && !onboardingValuesParam?.isMergeAccountStepCompleted) { return `/${ROUTES.ONBOARDING_WORK_EMAIL.route}`; diff --git a/src/libs/actions/Welcome/index.ts b/src/libs/actions/Welcome/index.ts index 6f7fb6221b04..e3cde79882a6 100644 --- a/src/libs/actions/Welcome/index.ts +++ b/src/libs/actions/Welcome/index.ts @@ -89,35 +89,35 @@ function checkOnboardingDataReady() { } function setOnboardingPurposeSelected(value: OnboardingPurpose) { - Onyx.set(ONYXKEYS.ONBOARDING_PURPOSE_SELECTED, value ?? null); + void Onyx.set(ONYXKEYS.ONBOARDING_PURPOSE_SELECTED, value ?? null); } function setOnboardingCompanySize(value: OnboardingCompanySize) { - Onyx.set(ONYXKEYS.ONBOARDING_COMPANY_SIZE, value); + void Onyx.set(ONYXKEYS.ONBOARDING_COMPANY_SIZE, value); } function setOnboardingUserReportedIntegration(value: OnboardingAccounting | null) { - Onyx.set(ONYXKEYS.ONBOARDING_USER_REPORTED_INTEGRATION, value); + void Onyx.set(ONYXKEYS.ONBOARDING_USER_REPORTED_INTEGRATION, value); } function setOnboardingErrorMessage(value: string) { - Onyx.set(ONYXKEYS.ONBOARDING_ERROR_MESSAGE, value ?? null); + void Onyx.set(ONYXKEYS.ONBOARDING_ERROR_MESSAGE, value ?? null); } function setOnboardingAdminsChatReportID(adminsChatReportID?: string) { - Onyx.set(ONYXKEYS.ONBOARDING_ADMINS_CHAT_REPORT_ID, adminsChatReportID ?? null); + void Onyx.set(ONYXKEYS.ONBOARDING_ADMINS_CHAT_REPORT_ID, adminsChatReportID ?? null); } function setOnboardingPolicyID(policyID?: string) { - Onyx.set(ONYXKEYS.ONBOARDING_POLICY_ID, policyID ?? null); + void Onyx.set(ONYXKEYS.ONBOARDING_POLICY_ID, policyID ?? null); } function updateOnboardingLastVisitedPath(path: string) { - Onyx.merge(ONYXKEYS.ONBOARDING_LAST_VISITED_PATH, path); + void Onyx.merge(ONYXKEYS.ONBOARDING_LAST_VISITED_PATH, path); } function updateOnboardingValuesAndNavigation(onboardingValues: Onboarding | undefined) { - Onyx.set(ONYXKEYS.NVP_ONBOARDING, {...onboardingValues, shouldValidate: undefined}); + void Onyx.set(ONYXKEYS.NVP_ONBOARDING, {...onboardingValues, shouldValidate: undefined}); // We need to have the Onyx values updated before navigating back // Because we navigate based no useEffect logic and we need to clear `shouldValidate` value before going back @@ -127,11 +127,11 @@ function updateOnboardingValuesAndNavigation(onboardingValues: Onboarding | unde } function setOnboardingMergeAccountStepValue(value: boolean, skipped = false) { - Onyx.merge(ONYXKEYS.NVP_ONBOARDING, {isMergeAccountStepCompleted: value, isMergeAccountStepSkipped: skipped}); + void Onyx.merge(ONYXKEYS.NVP_ONBOARDING, {isMergeAccountStepCompleted: value, isMergeAccountStepSkipped: skipped}); } function setOnboardingTestDriveModalDismissed() { - Onyx.merge(ONYXKEYS.NVP_ONBOARDING, {testDriveModalDismissed: true}); + void Onyx.merge(ONYXKEYS.NVP_ONBOARDING, {testDriveModalDismissed: true}); } function completeHybridAppOnboarding() { @@ -152,7 +152,7 @@ function completeHybridAppOnboarding() { ]; // eslint-disable-next-line rulesdir/no-api-side-effects-method - API.makeRequestWithSideEffects(SIDE_EFFECT_REQUEST_COMMANDS.COMPLETE_HYBRID_APP_ONBOARDING, {}, {optimisticData}).then((response) => { + void API.makeRequestWithSideEffects(SIDE_EFFECT_REQUEST_COMMANDS.COMPLETE_HYBRID_APP_ONBOARDING, {}, {optimisticData}).then((response) => { if (!response) { return; } @@ -197,7 +197,7 @@ function resetAllChecks() { function setSelfTourViewed(shouldUpdateOnyxDataOnlyLocally = false) { if (shouldUpdateOnyxDataOnlyLocally) { - Onyx.merge(ONYXKEYS.NVP_ONBOARDING, {selfTourViewed: true}); + void Onyx.merge(ONYXKEYS.NVP_ONBOARDING, {selfTourViewed: true}); return; } @@ -211,7 +211,7 @@ function setSelfTourViewed(shouldUpdateOnyxDataOnlyLocally = false) { }, ]; - API.write(WRITE_COMMANDS.SELF_TOUR_VIEWED, null, {optimisticData}); + void API.write(WRITE_COMMANDS.SELF_TOUR_VIEWED, null, {optimisticData}); } function dismissProductTraining(elementName: string, isDismissedUsingCloseButton = false) { @@ -229,7 +229,7 @@ function dismissProductTraining(elementName: string, isDismissedUsingCloseButton }, }, ]; - API.write(WRITE_COMMANDS.DISMISS_PRODUCT_TRAINING, {name: elementName, dismissedMethod}, {optimisticData}); + void API.write(WRITE_COMMANDS.DISMISS_PRODUCT_TRAINING, {name: elementName, dismissedMethod}, {optimisticData}); } export { diff --git a/src/libs/actions/Workflow.ts b/src/libs/actions/Workflow.ts index c6fdac3e0c7d..aef9083133f4 100644 --- a/src/libs/actions/Workflow.ts +++ b/src/libs/actions/Workflow.ts @@ -104,7 +104,7 @@ function createApprovalWorkflow(policyID: string, approvalWorkflow: ApprovalWork ]; const parameters: CreateWorkspaceApprovalParams = {policyID, authToken, employees: JSON.stringify(Object.values(updatedEmployees))}; - API.write(WRITE_COMMANDS.CREATE_WORKSPACE_APPROVAL, parameters, {optimisticData, failureData, successData}); + void API.write(WRITE_COMMANDS.CREATE_WORKSPACE_APPROVAL, parameters, {optimisticData, failureData, successData}); } function updateApprovalWorkflow(policyID: string, approvalWorkflow: ApprovalWorkflow, membersToRemove: Member[], approversToRemove: Approver[]) { @@ -174,7 +174,7 @@ function updateApprovalWorkflow(policyID: string, approvalWorkflow: ApprovalWork employees: JSON.stringify(Object.values(updatedEmployees)), defaultApprover: newDefaultApprover, }; - API.write(WRITE_COMMANDS.UPDATE_WORKSPACE_APPROVAL, parameters, {optimisticData, failureData, successData}); + void API.write(WRITE_COMMANDS.UPDATE_WORKSPACE_APPROVAL, parameters, {optimisticData, failureData, successData}); } function removeApprovalWorkflow(policyID: string, approvalWorkflow: ApprovalWorkflow) { @@ -230,12 +230,12 @@ function removeApprovalWorkflow(policyID: string, approvalWorkflow: ApprovalWork ]; const parameters: RemoveWorkspaceApprovalParams = {policyID, authToken, employees: JSON.stringify(Object.values(updatedEmployees))}; - API.write(WRITE_COMMANDS.REMOVE_WORKSPACE_APPROVAL, parameters, {optimisticData, failureData, successData}); + void API.write(WRITE_COMMANDS.REMOVE_WORKSPACE_APPROVAL, parameters, {optimisticData, failureData, successData}); } /** Set the members of the approval workflow that is currently edited */ function setApprovalWorkflowMembers(members: Member[]) { - Onyx.merge(ONYXKEYS.APPROVAL_WORKFLOW, {members, errors: null}); + void Onyx.merge(ONYXKEYS.APPROVAL_WORKFLOW, {members, errors: null}); } /** @@ -282,7 +282,7 @@ function setApprovalWorkflowApprover({approver, approverIndex, policyID, current }; }); - Onyx.merge(ONYXKEYS.APPROVAL_WORKFLOW, {approvers: updatedApprovers, errors}); + void Onyx.merge(ONYXKEYS.APPROVAL_WORKFLOW, {approvers: updatedApprovers, errors}); } /** Clear one approver at the specified index in the approval workflow that is currently edited */ @@ -294,20 +294,20 @@ function clearApprovalWorkflowApprover({approverIndex, currentApprovalWorkflow}: const approvers: Array = [...currentApprovalWorkflow.approvers]; approvers[approverIndex] = undefined; - Onyx.merge(ONYXKEYS.APPROVAL_WORKFLOW, {approvers: lodashDropRightWhile(approvers, (approver) => !approver), errors: null}); + void Onyx.merge(ONYXKEYS.APPROVAL_WORKFLOW, {approvers: lodashDropRightWhile(approvers, (approver) => !approver), errors: null}); } /** Clear all approvers of the approval workflow that is currently edited */ function clearApprovalWorkflowApprovers() { - Onyx.merge(ONYXKEYS.APPROVAL_WORKFLOW, {approvers: []}); + void Onyx.merge(ONYXKEYS.APPROVAL_WORKFLOW, {approvers: []}); } function setApprovalWorkflow(approvalWorkflow: NullishDeep) { - Onyx.set(ONYXKEYS.APPROVAL_WORKFLOW, approvalWorkflow); + void Onyx.set(ONYXKEYS.APPROVAL_WORKFLOW, approvalWorkflow); } function clearApprovalWorkflow() { - Onyx.set(ONYXKEYS.APPROVAL_WORKFLOW, null); + void Onyx.set(ONYXKEYS.APPROVAL_WORKFLOW, null); } type ApprovalWorkflowOnyxValidated = Omit & {approvers: Approver[]}; @@ -338,7 +338,7 @@ function validateApprovalWorkflow(approvalWorkflow: ApprovalWorkflowOnyx): appro errors.additionalApprover = 'common.error.fieldRequired'; } - Onyx.merge(ONYXKEYS.APPROVAL_WORKFLOW, {errors}); + void Onyx.merge(ONYXKEYS.APPROVAL_WORKFLOW, {errors}); return isEmptyObject(errors); } diff --git a/src/libs/actions/__mocks__/OnyxUpdates.ts b/src/libs/actions/__mocks__/OnyxUpdates.ts index e54b423259f1..1d16fbb46cad 100644 --- a/src/libs/actions/__mocks__/OnyxUpdates.ts +++ b/src/libs/actions/__mocks__/OnyxUpdates.ts @@ -21,7 +21,7 @@ Onyx.connectWithoutView({ const apply = jest.fn(({lastUpdateID, request, response}: OnyxUpdatesFromServer): Promise | undefined => { if (lastUpdateID && (lastUpdateIDAppliedToClient === undefined || Number(lastUpdateID) > lastUpdateIDAppliedToClient)) { - Onyx.merge(ONYXKEYS.ONYX_UPDATES_LAST_UPDATE_ID_APPLIED_TO_CLIENT, Number(lastUpdateID)); + void Onyx.merge(ONYXKEYS.ONYX_UPDATES_LAST_UPDATE_ID_APPLIED_TO_CLIENT, Number(lastUpdateID)); } if (request && response) { diff --git a/src/libs/actions/connections/NetSuiteCommands.ts b/src/libs/actions/connections/NetSuiteCommands.ts index 087c7bd7777b..7c6241e33cd6 100644 --- a/src/libs/actions/connections/NetSuiteCommands.ts +++ b/src/libs/actions/connections/NetSuiteCommands.ts @@ -29,7 +29,7 @@ function connectPolicyToNetSuite(policyID: string, credentials: Omit( @@ -323,7 +323,7 @@ function updateNetSuiteSubsidiary( policyID, ...newSubsidiary, }; - API.write(WRITE_COMMANDS.UPDATE_NETSUITE_SUBSIDIARY, params, onyxData); + void API.write(WRITE_COMMANDS.UPDATE_NETSUITE_SUBSIDIARY, params, onyxData); } function updateNetSuiteImportMapping( @@ -445,7 +445,7 @@ function updateNetSuiteImportMapping, oldDate?: ValueOf) { @@ -639,7 +639,7 @@ function updateNetSuiteExportDate(policyID: string, date: ValueOf( @@ -382,7 +382,7 @@ function updateQuickbooksDesktopShouldAutoCreateVendor( @@ -396,7 +396,7 @@ function updateQuickbooksDesktopMarkChecksToBePrinted( @@ -411,7 +411,7 @@ function updateQuickbooksDesktopReimbursableExpensesAccount(policyID: string, settingValue: TSettingValue) { @@ -422,7 +422,7 @@ function updateQuickbooksDesktopEnableNewCategories( @@ -439,7 +439,7 @@ function updateQuickbooksDesktopSyncClasses( @@ -456,7 +456,7 @@ function updateQuickbooksDesktopSyncCustomers( @@ -470,7 +470,7 @@ function updateQuickbooksDesktopSyncItems( @@ -485,7 +485,7 @@ function updateQuickbooksDesktopPreferredExporter( @@ -500,7 +500,7 @@ function updateQuickbooksDesktopNonReimbursableExpensesAccount( @@ -518,7 +518,7 @@ function updateQuickbooksDesktopNonReimbursableBillDefaultVendor( @@ -533,7 +533,7 @@ function updateQuickbooksDesktopExportDate(policyID: string, settingValue: TSettingValue) { @@ -544,7 +544,7 @@ function updateQuickbooksDesktopAutoSync(policyID: string, settingValue: TSettingValue) { @@ -200,7 +200,7 @@ function updateQuickbooksOnlineEnableNewCategories>( @@ -220,7 +220,7 @@ function updateQuickbooksOnlineAutoCreateVendor(policyID: string | undefined, settingValue: TSettingValue) { @@ -234,7 +234,7 @@ function updateQuickbooksOnlineSyncPeople( @@ -249,7 +249,7 @@ function updateQuickbooksOnlineReimbursableExpensesAccount( @@ -267,7 +267,7 @@ function updateQuickbooksOnlineSyncLocations( @@ -285,7 +285,7 @@ function updateQuickbooksOnlineSyncCustomers( @@ -302,7 +302,7 @@ function updateQuickbooksOnlineSyncClasses( @@ -320,7 +320,7 @@ function updateQuickbooksOnlineNonReimbursableBillDefaultVendor( @@ -338,7 +338,7 @@ function updateQuickbooksOnlineReceivableAccount(policyID: string, settingValue: TSettingValue, oldSettingValue?: TSettingValue) { @@ -349,7 +349,7 @@ function updateQuickbooksOnlineExportDate( @@ -369,7 +369,7 @@ function updateQuickbooksOnlineNonReimbursableExpensesAccount( @@ -388,7 +388,7 @@ function updateQuickbooksOnlineCollectionAccountID(policyID: string, settingValue: TSettingValue) { @@ -417,7 +417,7 @@ function updateQuickbooksOnlineSyncTax( @@ -438,7 +438,7 @@ function updateQuickbooksOnlineReimbursementAccountID( @@ -456,7 +456,7 @@ function updateQuickbooksOnlinePreferredExporter) { @@ -146,7 +146,7 @@ function updateSageIntacctMappingValue(policyID: string | undefined, mappingName } const onyxData = prepareOnyxDataForMappingUpdate(policyID, mappingName, mappingValue, oldMappingValue); - API.write( + void API.write( command, { policyID, @@ -241,7 +241,7 @@ function UpdateSageIntacctTaxSolutionID(policyID: string | undefined, taxSolutio }, ]; - API.write(WRITE_COMMANDS.UPDATE_SAGE_INTACCT_TAX_SOLUTION_ID, {policyID, taxSolutionID}, {optimisticData, failureData, successData}); + void API.write(WRITE_COMMANDS.UPDATE_SAGE_INTACCT_TAX_SOLUTION_ID, {policyID, taxSolutionID}, {optimisticData, failureData, successData}); } function updateSageIntacctSyncTaxConfiguration(policyID: string | undefined, enabled: boolean) { @@ -316,7 +316,7 @@ function updateSageIntacctSyncTaxConfiguration(policyID: string | undefined, ena }, }, ]; - API.write(WRITE_COMMANDS.UPDATE_SAGE_INTACCT_SYNC_TAX_CONFIGURATION, {policyID, enabled}, {optimisticData, failureData, successData}); + void API.write(WRITE_COMMANDS.UPDATE_SAGE_INTACCT_SYNC_TAX_CONFIGURATION, {policyID, enabled}, {optimisticData, failureData, successData}); } function prepareOnyxDataForUserDimensionUpdate( @@ -402,7 +402,7 @@ function addSageIntacctUserDimensions( ) { const newDimensions = [...existingUserDimensions, {mapping, dimension: dimensionName}]; - API.write( + void API.write( WRITE_COMMANDS.UPDATE_SAGE_INTACCT_USER_DIMENSION, {policyID, dimensions: JSON.stringify(newDimensions)}, prepareOnyxDataForUserDimensionUpdate(policyID, dimensionName, newDimensions, newDimensions, dimensionName, CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD), @@ -423,7 +423,7 @@ function editSageIntacctUserDimensions( return userDimension; }); - API.write( + void API.write( WRITE_COMMANDS.UPDATE_SAGE_INTACCT_USER_DIMENSION, {policyID, dimensions: JSON.stringify(newDimensions)}, prepareOnyxDataForUserDimensionUpdate(policyID, name, newDimensions, existingUserDimensions, previousName, CONST.RED_BRICK_ROAD_PENDING_ACTION.UPDATE), @@ -433,7 +433,7 @@ function editSageIntacctUserDimensions( function removeSageIntacctUserDimensions(policyID: string, dimensionName: string, existingUserDimensions: SageIntacctDimension[]) { const newDimensions = existingUserDimensions.filter((userDimension) => dimensionName !== userDimension.dimension); - API.write( + void API.write( WRITE_COMMANDS.UPDATE_SAGE_INTACCT_USER_DIMENSION, {policyID, dimensions: JSON.stringify(newDimensions)}, prepareOnyxDataForUserDimensionUpdate(policyID, dimensionName, newDimensions, existingUserDimensions, dimensionName, CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE), @@ -525,7 +525,7 @@ function updateSageIntacctExporter(policyID: string, exporter: string, oldExport email: exporter, }; - API.write(WRITE_COMMANDS.UPDATE_SAGE_INTACCT_EXPORTER, parameters, {optimisticData, failureData, successData}); + void API.write(WRITE_COMMANDS.UPDATE_SAGE_INTACCT_EXPORTER, parameters, {optimisticData, failureData, successData}); } function updateSageIntacctExportDate(policyID: string, date: ValueOf, oldDate?: ValueOf) { @@ -535,7 +535,7 @@ function updateSageIntacctExportDate(policyID: string, date: ValueOf dimension.dimension !== dimensionName); - Onyx.merge(`${ONYXKEYS.COLLECTION.POLICY}${policyID}`, {connections: {intacct: {config: {mappings: {dimensions: Dimensions}}}}}); + void Onyx.merge(`${ONYXKEYS.COLLECTION.POLICY}${policyID}`, {connections: {intacct: {config: {mappings: {dimensions: Dimensions}}}}}); } function prepareOnyxDataForConfigUpdate(policyID: string, settingName: keyof SageIntacctConnectionsConfig, settingValue: string | boolean | null, oldSettingValue?: string | boolean | null) { @@ -860,7 +860,7 @@ function updateSageIntacctAutoSync(policyID: string | undefined, enabled: boolea enabled, }; - API.write(WRITE_COMMANDS.UPDATE_SAGE_INTACCT_AUTO_SYNC, parameters, {optimisticData, failureData, successData}); + void API.write(WRITE_COMMANDS.UPDATE_SAGE_INTACCT_AUTO_SYNC, parameters, {optimisticData, failureData, successData}); } function updateSageIntacctImportEmployees(policyID: string | undefined, enabled: boolean) { @@ -874,7 +874,7 @@ function updateSageIntacctImportEmployees(policyID: string | undefined, enabled: enabled, }; - API.write(WRITE_COMMANDS.UPDATE_SAGE_INTACCT_IMPORT_EMPLOYEES, parameters, {optimisticData, failureData, successData}); + void API.write(WRITE_COMMANDS.UPDATE_SAGE_INTACCT_IMPORT_EMPLOYEES, parameters, {optimisticData, failureData, successData}); } function updateSageIntacctApprovalMode(policyID: string | undefined, enabled: boolean) { @@ -895,7 +895,7 @@ function updateSageIntacctApprovalMode(policyID: string | undefined, enabled: bo value: approvalModeSettingValue, }; - API.write(WRITE_COMMANDS.UPDATE_SAGE_INTACCT_APPROVAL_MODE, parameters, {optimisticData, failureData, successData}); + void API.write(WRITE_COMMANDS.UPDATE_SAGE_INTACCT_APPROVAL_MODE, parameters, {optimisticData, failureData, successData}); } function updateSageIntacctSyncReimbursedReports(policyID: string | undefined, enabled: boolean) { @@ -909,7 +909,7 @@ function updateSageIntacctSyncReimbursedReports(policyID: string | undefined, en enabled, }; - API.write(WRITE_COMMANDS.UPDATE_SAGE_INTACCT_SYNC_REIMBURSED_REPORTS, parameters, {optimisticData, failureData, successData}); + void API.write(WRITE_COMMANDS.UPDATE_SAGE_INTACCT_SYNC_REIMBURSED_REPORTS, parameters, {optimisticData, failureData, successData}); } function updateSageIntacctSyncReimbursementAccountID(policyID: string | undefined, vendorID: string | undefined, oldVendorID?: string) { @@ -923,7 +923,7 @@ function updateSageIntacctSyncReimbursementAccountID(policyID: string | undefine vendorID, }; - API.write(WRITE_COMMANDS.UPDATE_SAGE_INTACCT_SYNC_REIMBURSEMENT_ACCOUNT_ID, parameters, {optimisticData, failureData, successData}); + void API.write(WRITE_COMMANDS.UPDATE_SAGE_INTACCT_SYNC_REIMBURSEMENT_ACCOUNT_ID, parameters, {optimisticData, failureData, successData}); } function updateSageIntacctEntity(policyID: string | undefined, entity: string, oldEntity: string) { @@ -934,7 +934,7 @@ function updateSageIntacctEntity(policyID: string | undefined, entity: string, o policyID, entity, }; - API.write(WRITE_COMMANDS.UPDATE_SAGE_INTACCT_ENTITY, parameters, prepareOnyxDataForConfigUpdate(policyID, CONST.SAGE_INTACCT_CONFIG.ENTITY, entity, oldEntity)); + void API.write(WRITE_COMMANDS.UPDATE_SAGE_INTACCT_ENTITY, parameters, prepareOnyxDataForConfigUpdate(policyID, CONST.SAGE_INTACCT_CONFIG.ENTITY, entity, oldEntity)); } function updateSageIntacctAccountingMethod( @@ -953,7 +953,7 @@ function updateSageIntacctAccountingMethod( const {optimisticData, failureData, successData} = prepareOnyxDataForExportUpdate(policyID, CONST.SAGE_INTACCT_CONFIG.ACCOUNTING_METHOD, accountingMethod, oldAccountingMethod); - API.write(WRITE_COMMANDS.UPDATE_SAGE_INTACCT_ACCOUNTING_METHOD, parameters, {optimisticData, failureData, successData}); + void API.write(WRITE_COMMANDS.UPDATE_SAGE_INTACCT_ACCOUNTING_METHOD, parameters, {optimisticData, failureData, successData}); } export { diff --git a/src/libs/actions/connections/Xero.ts b/src/libs/actions/connections/Xero.ts index 788eadf93acb..16479819aa92 100644 --- a/src/libs/actions/connections/Xero.ts +++ b/src/libs/actions/connections/Xero.ts @@ -337,7 +337,7 @@ function updateXeroImportTrackingCategories( oldImportTrackingCategories, ); - API.write(WRITE_COMMANDS.UPDATE_XERO_IMPORT_TRACKING_CATEGORIES, parameters, {optimisticData, failureData, successData}); + void API.write(WRITE_COMMANDS.UPDATE_XERO_IMPORT_TRACKING_CATEGORIES, parameters, {optimisticData, failureData, successData}); } function updateXeroImportTaxRates( @@ -353,7 +353,7 @@ function updateXeroImportTaxRates( const {optimisticData, failureData, successData} = prepareXeroOptimisticData(policyID, CONST.XERO_CONFIG.IMPORT_TAX_RATES, importTaxesRate, oldImportTaxesRate); - API.write(WRITE_COMMANDS.UPDATE_XERO_IMPORT_TAX_RATES, parameters, {optimisticData, failureData, successData}); + void API.write(WRITE_COMMANDS.UPDATE_XERO_IMPORT_TAX_RATES, parameters, {optimisticData, failureData, successData}); } function updateXeroTenantID(policyID: string | undefined, settingValue: string, oldSettingValue?: string) { @@ -368,7 +368,7 @@ function updateXeroTenantID(policyID: string | undefined, settingValue: string, const {optimisticData, successData, failureData} = prepareXeroOptimisticData(policyID, CONST.XERO_CONFIG.TENANT_ID, settingValue, oldSettingValue); - API.write(WRITE_COMMANDS.UPDATE_XERO_TENANT_ID, parameters, {optimisticData, successData, failureData}); + void API.write(WRITE_COMMANDS.UPDATE_XERO_TENANT_ID, parameters, {optimisticData, successData, failureData}); } function updateXeroMappings(policyID: string, mappingValue: Partial, oldMappingValue?: Partial) { @@ -380,7 +380,7 @@ function updateXeroMappings(policyID: string, mappingValue: Partial, oldAutoSync?: Partial) { @@ -428,7 +428,7 @@ function updateXeroAutoSync(policyID: string | undefined, autoSync: Partial, connectionName: PolicyConnectionName, isSyncInProgress: boolean): boolean { @@ -274,7 +274,7 @@ function isConnectionUnverified(policy: OnyxEntry, connectionName: Polic } function setConnectionError(policyID: string, connectionName: PolicyConnectionName, errorMessage?: string) { - Onyx.merge(`${ONYXKEYS.COLLECTION.POLICY}${policyID}`, { + void Onyx.merge(`${ONYXKEYS.COLLECTION.POLICY}${policyID}`, { connections: { [connectionName]: { lastSync: { @@ -312,7 +312,7 @@ function copyExistingPolicyConnection(connectedPolicyID: string, targetPolicyID: }, }, ]; - API.write( + void API.write( WRITE_COMMANDS.COPY_EXISTING_POLICY_CONNECTION, { policyID: connectedPolicyID, diff --git a/src/libs/actions/setFullscreenVisibility.ts b/src/libs/actions/setFullscreenVisibility.ts index db2be3123a1f..6339bc2ed142 100644 --- a/src/libs/actions/setFullscreenVisibility.ts +++ b/src/libs/actions/setFullscreenVisibility.ts @@ -2,5 +2,5 @@ import Onyx from 'react-native-onyx'; import ONYXKEYS from '@src/ONYXKEYS'; export default function setFullscreenVisibility(isVisible: boolean) { - Onyx.merge(ONYXKEYS.FULLSCREEN_VISIBILITY, isVisible); + void Onyx.merge(ONYXKEYS.FULLSCREEN_VISIBILITY, isVisible); } diff --git a/src/libs/desktopLoginRedirect/index.desktop.ts b/src/libs/desktopLoginRedirect/index.desktop.ts index ccc442346dc1..1ecde0a8c1cb 100644 --- a/src/libs/desktopLoginRedirect/index.desktop.ts +++ b/src/libs/desktopLoginRedirect/index.desktop.ts @@ -9,7 +9,7 @@ function desktopLoginRedirect(autoAuthState: AutoAuthState, isSignedIn: boolean) const shouldPopToTop = (autoAuthState === CONST.AUTO_AUTH_STATE.NOT_STARTED || autoAuthState === CONST.AUTO_AUTH_STATE.JUST_SIGNED_IN) && !isSignedIn; if (shouldPopToTop) { - Navigation.isNavigationReady().then(() => Navigation.resetToHome()); + void Navigation.isNavigationReady().then(() => Navigation.resetToHome()); } } diff --git a/src/libs/focusEditAfterCancelDelete/index.native.ts b/src/libs/focusEditAfterCancelDelete/index.native.ts index 17bafabc5790..2166a4a79ef2 100755 --- a/src/libs/focusEditAfterCancelDelete/index.native.ts +++ b/src/libs/focusEditAfterCancelDelete/index.native.ts @@ -2,7 +2,7 @@ import {InteractionManager} from 'react-native'; import type FocusEditAfterCancelDelete from './types'; const focusEditAfterCancelDelete: FocusEditAfterCancelDelete = (textInputRef) => { - InteractionManager.runAfterInteractions(() => textInputRef?.focus()); + void InteractionManager.runAfterInteractions(() => textInputRef?.focus()); }; export default focusEditAfterCancelDelete; diff --git a/src/libs/migrations/MoveIsOptimisticReportToMetadata.ts b/src/libs/migrations/MoveIsOptimisticReportToMetadata.ts index 8b46109e3a0d..ffe419b2fb99 100644 --- a/src/libs/migrations/MoveIsOptimisticReportToMetadata.ts +++ b/src/libs/migrations/MoveIsOptimisticReportToMetadata.ts @@ -32,9 +32,9 @@ export default function (): Promise { Promise.all([ // @ts-expect-error isOptimisticReport is not a valid property of Report anymore // eslint-disable-next-line rulesdir/prefer-actions-set-data - Onyx.merge(`${ONYXKEYS.COLLECTION.REPORT}${reportID}`, {isOptimisticReport: null}), + void Onyx.merge(`${ONYXKEYS.COLLECTION.REPORT}${reportID}`, {isOptimisticReport: null}), // eslint-disable-next-line rulesdir/prefer-actions-set-data - Onyx.merge(`${ONYXKEYS.COLLECTION.REPORT_METADATA}${reportID}`, {isOptimisticReport: report.isOptimisticReport}), + void Onyx.merge(`${ONYXKEYS.COLLECTION.REPORT_METADATA}${reportID}`, {isOptimisticReport: report.isOptimisticReport}), ]).then(() => { Log.info(`[Migrate Onyx] Successfully moved isOptimisticReport to reportMetadata for ${reportID}`); }), diff --git a/src/libs/migrations/PendingMembersToMetadata.ts b/src/libs/migrations/PendingMembersToMetadata.ts index d71dc0d17e83..717ca1184d73 100644 --- a/src/libs/migrations/PendingMembersToMetadata.ts +++ b/src/libs/migrations/PendingMembersToMetadata.ts @@ -33,9 +33,9 @@ export default function (): Promise { Promise.all([ // @ts-expect-error pendingChatMembers is not a valid property of Report anymore // eslint-disable-next-line rulesdir/prefer-actions-set-data - Onyx.merge(reportID, {pendingChatMembers: null}), + void Onyx.merge(reportID, {pendingChatMembers: null}), // eslint-disable-next-line rulesdir/prefer-actions-set-data - Onyx.merge(`${ONYXKEYS.COLLECTION.REPORT_METADATA}${report.reportID}`, {pendingChatMembers: report.pendingChatMembers}), + void Onyx.merge(`${ONYXKEYS.COLLECTION.REPORT_METADATA}${report.reportID}`, {pendingChatMembers: report.pendingChatMembers}), ]).then(() => { Log.info(`[Migrate Onyx] Successfully moved pendingChatMembers to reportMetadata for ${reportID}`); }), diff --git a/src/libs/migrations/RenameCardIsVirtual.ts b/src/libs/migrations/RenameCardIsVirtual.ts index 5238b05bb3b9..5eee9c2c6f65 100644 --- a/src/libs/migrations/RenameCardIsVirtual.ts +++ b/src/libs/migrations/RenameCardIsVirtual.ts @@ -46,7 +46,7 @@ export default function () { ); // eslint-disable-next-line rulesdir/prefer-actions-set-data - Onyx.merge(ONYXKEYS.CARD_LIST, dataToSave).then(() => { + void Onyx.merge(ONYXKEYS.CARD_LIST, dataToSave).then(() => { Log.info(`[Migrate Onyx] Ran migration RenameCardIsVirtual and renamed ${Object.keys(dataToSave)?.length} properties`); resolve(); }); diff --git a/src/libs/migrations/RenameReceiptFilename.ts b/src/libs/migrations/RenameReceiptFilename.ts index 5f71dec3db0d..2cc733b34f3e 100644 --- a/src/libs/migrations/RenameReceiptFilename.ts +++ b/src/libs/migrations/RenameReceiptFilename.ts @@ -46,7 +46,7 @@ export default function () { ); // eslint-disable-next-line rulesdir/prefer-actions-set-data - Onyx.mergeCollection(ONYXKEYS.COLLECTION.TRANSACTION, dataToSave).then(() => { + void Onyx.mergeCollection(ONYXKEYS.COLLECTION.TRANSACTION, dataToSave).then(() => { Log.info(`[Migrate Onyx] Ran migration RenameReceiptFilename and renamed ${Object.keys(dataToSave)?.length} properties`); resolve(); }); diff --git a/src/libs/navigateAfterOnboarding.ts b/src/libs/navigateAfterOnboarding.ts index 7c02ad4d5ced..fbf2960ac9df 100644 --- a/src/libs/navigateAfterOnboarding.ts +++ b/src/libs/navigateAfterOnboarding.ts @@ -45,7 +45,7 @@ const navigateAfterOnboarding = ( // We're using Navigation.isNavigationReady here because without it, on iOS, // Navigation.dismissModal runs after Navigation.navigate(ROUTES.TEST_DRIVE_MODAL_ROOT.route) // And dismisses the modal before it even shows - Navigation.isNavigationReady().then(() => { + void Navigation.isNavigationReady().then(() => { Navigation.navigate(ROUTES.TEST_DRIVE_MODAL_ROOT.route); }); }; diff --git a/src/pages/AddUnreportedExpense.tsx b/src/pages/AddUnreportedExpense.tsx index 20cf2cb16715..42ec6e83e95d 100644 --- a/src/pages/AddUnreportedExpense.tsx +++ b/src/pages/AddUnreportedExpense.tsx @@ -207,7 +207,7 @@ function AddUnreportedExpense({route}: AddUnreportedExpensePageType) { return; } Navigation.dismissModal(); - InteractionManager.runAfterInteractions(() => { + void InteractionManager.runAfterInteractions(() => { if (report && isIOUReport(report)) { convertBulkTrackedExpensesToIOU([...selectedIds], report.reportID); } else { diff --git a/src/pages/ConciergePage.tsx b/src/pages/ConciergePage.tsx index 7233d3fc6d66..b859dc7c0039 100644 --- a/src/pages/ConciergePage.tsx +++ b/src/pages/ConciergePage.tsx @@ -27,7 +27,7 @@ function ConciergePage() { useCallback(() => { if (session && 'authToken' in session) { confirmReadyToOpenApp(); - Navigation.isNavigationReady().then(() => { + void Navigation.isNavigationReady().then(() => { if (isUnmounted.current || isLoadingReportData === undefined || !!isLoadingReportData) { return; } diff --git a/src/pages/Debug/ReportAction/DebugReportActionPage.tsx b/src/pages/Debug/ReportAction/DebugReportActionPage.tsx index fe7f0444e349..b1ea916cd0cd 100644 --- a/src/pages/Debug/ReportAction/DebugReportActionPage.tsx +++ b/src/pages/Debug/ReportAction/DebugReportActionPage.tsx @@ -50,7 +50,7 @@ function DebugReportActionPage({ Navigation.goBack(); // We need to wait for navigation animations to finish before deleting an action, // otherwise the user will see a not found page briefly. - InteractionManager.runAfterInteractions(() => { + void InteractionManager.runAfterInteractions(() => { Debug.mergeDebugData(`${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${reportID}`, {[reportActionID]: null}); }); }} diff --git a/src/pages/Debug/Transaction/DebugTransactionPage.tsx b/src/pages/Debug/Transaction/DebugTransactionPage.tsx index 2fa510378213..5bf942880787 100644 --- a/src/pages/Debug/Transaction/DebugTransactionPage.tsx +++ b/src/pages/Debug/Transaction/DebugTransactionPage.tsx @@ -61,7 +61,7 @@ function DebugTransactionPage({ Navigation.goBack(); // We need to wait for navigation animations to finish before deleting a transaction, // otherwise the user will see a not found page briefly. - InteractionManager.runAfterInteractions(() => { + void InteractionManager.runAfterInteractions(() => { Debug.setDebugData(`${ONYXKEYS.COLLECTION.TRANSACTION}${transactionID}`, null); }); }} diff --git a/src/pages/Debug/TransactionViolation/DebugTransactionViolationPage.tsx b/src/pages/Debug/TransactionViolation/DebugTransactionViolationPage.tsx index f062195e807d..a0a0ece33a65 100644 --- a/src/pages/Debug/TransactionViolation/DebugTransactionViolationPage.tsx +++ b/src/pages/Debug/TransactionViolation/DebugTransactionViolationPage.tsx @@ -49,7 +49,7 @@ function DebugTransactionViolationPage({ Navigation.goBack(); // We need to wait for navigation animations to finish before deleting a violation, // otherwise the user will see a not found page briefly. - InteractionManager.runAfterInteractions(() => { + void InteractionManager.runAfterInteractions(() => { Debug.setDebugData(`${ONYXKEYS.COLLECTION.TRANSACTION_VIOLATIONS}${transactionID}`, updatedTransactionViolations); }); }, [index, transactionID, transactionViolations]); diff --git a/src/pages/LogInWithShortLivedAuthTokenPage.tsx b/src/pages/LogInWithShortLivedAuthTokenPage.tsx index 1accb44cb44a..ee860273bdd7 100644 --- a/src/pages/LogInWithShortLivedAuthTokenPage.tsx +++ b/src/pages/LogInWithShortLivedAuthTokenPage.tsx @@ -31,7 +31,7 @@ function LogInWithShortLivedAuthTokenPage({route}: LogInWithShortLivedAuthTokenP if (!account?.isLoading && authTokenType === CONST.AUTH_TOKEN_TYPES.SUPPORT) { signInWithSupportAuthToken(shortLivedAuthToken); - Navigation.isNavigationReady().then(() => { + void Navigation.isNavigationReady().then(() => { // We must call goBack() to remove the /transition route from history Navigation.goBack(); Navigation.navigate(ROUTES.HOME); @@ -52,7 +52,7 @@ function LogInWithShortLivedAuthTokenPage({route}: LogInWithShortLivedAuthTokenP } if (exitTo) { - Navigation.isNavigationReady().then(() => { + void Navigation.isNavigationReady().then(() => { // We must call goBack() to remove the /transition route from history Navigation.goBack(); Navigation.navigate(exitTo as Route); diff --git a/src/pages/LogOutPreviousUserPage.tsx b/src/pages/LogOutPreviousUserPage.tsx index b9b153da4f64..7c45b0945a0f 100644 --- a/src/pages/LogOutPreviousUserPage.tsx +++ b/src/pages/LogOutPreviousUserPage.tsx @@ -41,7 +41,7 @@ function LogOutPreviousUserPage({route}: LogOutPreviousUserPageProps) { if (isSupportalLogin) { signInWithSupportAuthToken(shortLivedAuthToken); - Navigation.isNavigationReady().then(() => { + void Navigation.isNavigationReady().then(() => { // We must call goBack() to remove the /transition route from history Navigation.goBack(); Navigation.navigate(ROUTES.HOME); @@ -66,7 +66,7 @@ function LogOutPreviousUserPage({route}: LogOutPreviousUserPageProps) { // which is already called when AuthScreens mounts. // For HybridApp we have separate logic to handle transitions. if (!CONFIG.IS_HYBRID_APP && exitTo !== ROUTES.WORKSPACE_NEW && !isAccountLoading && !isLoggingInAsNewUser) { - Navigation.isNavigationReady().then(() => { + void Navigation.isNavigationReady().then(() => { // remove this screen and navigate to exit route Navigation.goBack(); if (exitTo) { diff --git a/src/pages/NewChatSelectorPage.tsx b/src/pages/NewChatSelectorPage.tsx index 811ea8be9c0c..3f82f5f8bc68 100755 --- a/src/pages/NewChatSelectorPage.tsx +++ b/src/pages/NewChatSelectorPage.tsx @@ -43,7 +43,7 @@ function NewChatSelectorPage() { const onTabSelectFocusHandler = ({index}: {index: number}) => { // We runAfterInteractions since the function is called in the animate block on web-based // implementation, this fixes an animation glitch and matches the native internal delay - InteractionManager.runAfterInteractions(() => { + void InteractionManager.runAfterInteractions(() => { // Chat tab (0) / Room tab (1) according to OnyxTabNavigator (see below) if (index === 0) { chatPageInputRef.current?.focus(); diff --git a/src/pages/OnboardingInterestedFeatures/BaseOnboardingInterestedFeatures.tsx b/src/pages/OnboardingInterestedFeatures/BaseOnboardingInterestedFeatures.tsx index 54c35a548870..f6434b7123f8 100644 --- a/src/pages/OnboardingInterestedFeatures/BaseOnboardingInterestedFeatures.tsx +++ b/src/pages/OnboardingInterestedFeatures/BaseOnboardingInterestedFeatures.tsx @@ -222,7 +222,7 @@ function BaseOnboardingInterestedFeatures({shouldUseNativeStyles}: BaseOnboardin } // Avoid creating new WS because onboardingPolicyID is cleared before unmounting - InteractionManager.runAfterInteractions(() => { + void InteractionManager.runAfterInteractions(() => { setOnboardingAdminsChatReportID(); setOnboardingPolicyID(); }); diff --git a/src/pages/OnboardingPurpose/BaseOnboardingPurpose.tsx b/src/pages/OnboardingPurpose/BaseOnboardingPurpose.tsx index 683bb4956a74..c5daec6c39a7 100644 --- a/src/pages/OnboardingPurpose/BaseOnboardingPurpose.tsx +++ b/src/pages/OnboardingPurpose/BaseOnboardingPurpose.tsx @@ -98,7 +98,7 @@ function BaseOnboardingPurpose({shouldUseNativeStyles, shouldEnableMaxHeight, ro onboardingPolicyID, }); - InteractionManager.runAfterInteractions(() => { + void InteractionManager.runAfterInteractions(() => { Navigation.navigate(ROUTES.TEST_DRIVE_MODAL_ROOT.route); }); diff --git a/src/pages/ProcessMoneyRequestHoldPage.tsx b/src/pages/ProcessMoneyRequestHoldPage.tsx index b82ab11db521..8ba702f34f45 100644 --- a/src/pages/ProcessMoneyRequestHoldPage.tsx +++ b/src/pages/ProcessMoneyRequestHoldPage.tsx @@ -12,7 +12,7 @@ function ProcessMoneyRequestHoldPage() { useFocusEffect( useCallback(() => { focusTimeoutRef.current = setTimeout(() => { - InteractionManager.runAfterInteractions(() => { + void InteractionManager.runAfterInteractions(() => { blurActiveElement(); }); }, CONST.ANIMATED_TRANSITION); diff --git a/src/pages/ReportDetailsPage.tsx b/src/pages/ReportDetailsPage.tsx index e92bd8984394..0995bdcdbfb8 100644 --- a/src/pages/ReportDetailsPage.tsx +++ b/src/pages/ReportDetailsPage.tsx @@ -301,7 +301,7 @@ function ReportDetailsPage({policy, report, route, reportMetadata}: ReportDetail const leaveChat = useCallback(() => { Navigation.dismissModal(); - Navigation.isNavigationReady().then(() => { + void Navigation.isNavigationReady().then(() => { if (isRootGroupChat) { leaveGroupChat(report.reportID); return; diff --git a/src/pages/ReportParticipantsPage.tsx b/src/pages/ReportParticipantsPage.tsx index 270b2afe43fd..e5a4572b2c51 100755 --- a/src/pages/ReportParticipantsPage.tsx +++ b/src/pages/ReportParticipantsPage.tsx @@ -242,7 +242,7 @@ function ReportParticipantsPage({report, route}: ReportParticipantsPageProps) { removeFromGroupChat(report.reportID, accountIDsToRemove); setSearchValue(''); setRemoveMembersConfirmModalVisible(false); - InteractionManager.runAfterInteractions(() => { + void InteractionManager.runAfterInteractions(() => { setSelectedMembers([]); clearUserSearchPhrase(); }); @@ -428,7 +428,7 @@ function ReportParticipantsPage({report, route}: ReportParticipantsPageProps) { confirmText={translate('common.remove')} cancelText={translate('common.cancel')} onModalHide={() => { - InteractionManager.runAfterInteractions(() => { + void InteractionManager.runAfterInteractions(() => { if (!textInputRef.current) { return; } diff --git a/src/pages/RoomMembersPage.tsx b/src/pages/RoomMembersPage.tsx index c1d44bbe4d15..49735b5971bf 100644 --- a/src/pages/RoomMembersPage.tsx +++ b/src/pages/RoomMembersPage.tsx @@ -135,7 +135,7 @@ function RoomMembersPage({report, policy}: RoomMembersPageProps) { } setSearchValue(''); setRemoveMembersConfirmModalVisible(false); - InteractionManager.runAfterInteractions(() => { + void InteractionManager.runAfterInteractions(() => { setSelectedMembers([]); clearUserSearchPhrase(); }); diff --git a/src/pages/Search/SavedSearchRenamePage.tsx b/src/pages/Search/SavedSearchRenamePage.tsx index efd671104acd..47348eb486db 100644 --- a/src/pages/Search/SavedSearchRenamePage.tsx +++ b/src/pages/Search/SavedSearchRenamePage.tsx @@ -26,7 +26,7 @@ function SavedSearchRenamePage({route}: {route: {params: {q: string; name: strin const applyFiltersAndNavigate = () => { clearAdvancedFilters(); Navigation.dismissModal(); - Navigation.isNavigationReady().then(() => { + void Navigation.isNavigationReady().then(() => { Navigation.navigate( ROUTES.SEARCH_ROOT.getRoute({ query: q, diff --git a/src/pages/Search/SearchPage.tsx b/src/pages/Search/SearchPage.tsx index 6307ac662813..80d9b96f6e28 100644 --- a/src/pages/Search/SearchPage.tsx +++ b/src/pages/Search/SearchPage.tsx @@ -335,7 +335,7 @@ function SearchPage({route}: SearchPageProps) { ? Object.values(selectedTransactions).map((transaction) => transaction.reportID) : (selectedReports?.filter((report) => !!report).map((report) => report.reportID) ?? []); approveMoneyRequestOnSearch(hash, reportIDList, transactionIDList); - InteractionManager.runAfterInteractions(() => { + void InteractionManager.runAfterInteractions(() => { clearSelectedTransactions(); }); }, @@ -414,7 +414,7 @@ function SearchPage({route}: SearchPageProps) { ) as PaymentData[]; payMoneyRequestOnSearch(hash, paymentData, transactionIDList); - InteractionManager.runAfterInteractions(() => { + void InteractionManager.runAfterInteractions(() => { clearSelectedTransactions(); }); }, @@ -457,7 +457,7 @@ function SearchPage({route}: SearchPageProps) { } unholdMoneyRequestOnSearch(hash, selectedTransactionsKeys); - InteractionManager.runAfterInteractions(() => { + void InteractionManager.runAfterInteractions(() => { clearSelectedTransactions(); }); }, @@ -494,7 +494,7 @@ function SearchPage({route}: SearchPageProps) { } // Use InteractionManager to ensure this runs after the dropdown modal closes - InteractionManager.runAfterInteractions(() => { + void InteractionManager.runAfterInteractions(() => { setIsDeleteExpensesConfirmModalVisible(true); }); }, @@ -551,7 +551,7 @@ function SearchPage({route}: SearchPageProps) { // Translations copy for delete modal depends on amount of selected items, // We need to wait for modal to fully disappear before clearing them to avoid translation flicker between singular vs plural - InteractionManager.runAfterInteractions(() => { + void InteractionManager.runAfterInteractions(() => { deleteMoneyRequestOnSearch(hash, selectedTransactionsKeys); clearSelectedTransactions(); }); diff --git a/src/pages/Search/SearchTransactionsChangeReport.tsx b/src/pages/Search/SearchTransactionsChangeReport.tsx index 965a08464a84..00ffd6a552ff 100644 --- a/src/pages/Search/SearchTransactionsChangeReport.tsx +++ b/src/pages/Search/SearchTransactionsChangeReport.tsx @@ -70,7 +70,7 @@ function SearchTransactionsChangeReport() { allPolicies?.[`${ONYXKEYS.COLLECTION.POLICY}${item.policyID}`], reportNextStep, ); - InteractionManager.runAfterInteractions(() => { + void InteractionManager.runAfterInteractions(() => { clearSelectedTransactions(); }); diff --git a/src/pages/Share/ShareRootPage.tsx b/src/pages/Share/ShareRootPage.tsx index 9d0ff406972b..3701173c8ae7 100644 --- a/src/pages/Share/ShareRootPage.tsx +++ b/src/pages/Share/ShareRootPage.tsx @@ -158,7 +158,7 @@ function ShareRootPage() { const onTabSelectFocusHandler = ({index}: {index: number}) => { // We runAfterInteractions since the function is called in the animate block on web-based // implementation, this fixes an animation glitch and matches the native internal delay - InteractionManager.runAfterInteractions(() => { + void InteractionManager.runAfterInteractions(() => { // Chat tab (0) / Room tab (1) according to OnyxTabNavigator (see below) if (index === 0) { shareTabInputRef.current?.focus(); diff --git a/src/pages/SubmitExpensePage.tsx b/src/pages/SubmitExpensePage.tsx index f4f6ea623c34..93cce7ddc84a 100644 --- a/src/pages/SubmitExpensePage.tsx +++ b/src/pages/SubmitExpensePage.tsx @@ -24,7 +24,7 @@ function SubmitExpensePage() { useFocusEffect(() => { interceptAnonymousUser(() => { App.confirmReadyToOpenApp(); - Navigation.isNavigationReady().then(() => { + void Navigation.isNavigationReady().then(() => { if (isUnmounted.current) { return; } diff --git a/src/pages/TrackExpensePage.tsx b/src/pages/TrackExpensePage.tsx index b5baa567be1f..8e18578f024a 100644 --- a/src/pages/TrackExpensePage.tsx +++ b/src/pages/TrackExpensePage.tsx @@ -32,7 +32,7 @@ function TrackExpensePage() { useFocusEffect(() => { interceptAnonymousUser(() => { App.confirmReadyToOpenApp(); - Navigation.isNavigationReady().then(() => { + void Navigation.isNavigationReady().then(() => { if (isUnmounted.current || isLoadingHasSeenTrackTraining) { return; } diff --git a/src/pages/Travel/ManageTrips.tsx b/src/pages/Travel/ManageTrips.tsx index 024d5ae37f72..a674f56f3655 100644 --- a/src/pages/Travel/ManageTrips.tsx +++ b/src/pages/Travel/ManageTrips.tsx @@ -39,7 +39,7 @@ function ManageTrips() { const scrollViewRef = useRef(null); const scrollToBottom = () => { - InteractionManager.runAfterInteractions(() => { + void InteractionManager.runAfterInteractions(() => { scrollViewRef.current?.scrollToEnd({animated: true}); }); }; diff --git a/src/pages/ValidateLoginPage/index.tsx b/src/pages/ValidateLoginPage/index.tsx index a26221a689dc..734952cc8953 100644 --- a/src/pages/ValidateLoginPage/index.tsx +++ b/src/pages/ValidateLoginPage/index.tsx @@ -16,7 +16,7 @@ function ValidateLoginPage({ useEffect(() => { // Wait till navigation becomes available - Navigation.isNavigationReady().then(() => { + void Navigation.isNavigationReady().then(() => { if (session?.authToken && session?.authTokenType !== CONST.AUTH_TOKEN_TYPES.ANONYMOUS) { // If already signed in, do not show the validate code if not on web, // because we don't want to block the user with the interstitial page. @@ -37,7 +37,7 @@ function ValidateLoginPage({ return; } // Go back to initial route if validation fails - Navigation.isNavigationReady().then(() => { + void Navigation.isNavigationReady().then(() => { Navigation.goBack(); }); }, [session?.autoAuthState]); diff --git a/src/pages/ValidateLoginPage/index.website.tsx b/src/pages/ValidateLoginPage/index.website.tsx index 5220f97f9da2..5c7760b5997e 100644 --- a/src/pages/ValidateLoginPage/index.website.tsx +++ b/src/pages/ValidateLoginPage/index.website.tsx @@ -40,7 +40,7 @@ function ValidateLoginPage({ useEffect(() => { if (isUserClickedSignIn) { // The user clicked the option to sign in the current tab - Navigation.isNavigationReady().then(() => { + void Navigation.isNavigationReady().then(() => { Navigation.goBack(); }); return; @@ -73,7 +73,7 @@ function ValidateLoginPage({ } // The user clicked the option to sign in the current tab - Navigation.isNavigationReady().then(() => { + void Navigation.isNavigationReady().then(() => { Navigation.goBack(); }); }, [login, cachedAccountID, is2FARequired, exitTo]); diff --git a/src/pages/home/ReportScreen.tsx b/src/pages/home/ReportScreen.tsx index e8a29dfae74f..97756cad296c 100644 --- a/src/pages/home/ReportScreen.tsx +++ b/src/pages/home/ReportScreen.tsx @@ -182,7 +182,7 @@ function ReportScreen({route, navigation}: ReportScreenProps) { const reportActionID = route?.params?.reportActionID; const isValidReportActionID = reportActionID && isNumeric(reportActionID); if (reportActionID && !isValidReportActionID) { - Navigation.isNavigationReady().then(() => navigation.setParams({reportActionID: ''})); + void Navigation.isNavigationReady().then(() => navigation.setParams({reportActionID: ''})); } return; } @@ -436,7 +436,7 @@ function ReportScreen({route, navigation}: ReportScreenProps) { return; } // Clear the URL after all interactions are processed to ensure all updates are completed before hiding the skeleton - InteractionManager.runAfterInteractions(() => { + void InteractionManager.runAfterInteractions(() => { requestAnimationFrame(() => { clearDeleteTransactionNavigateBackUrl(); }); @@ -650,7 +650,7 @@ function ReportScreen({route, navigation}: ReportScreenProps) { } Navigation.dismissModal(); if (Navigation.getTopmostReportId() === prevOnyxReportID) { - Navigation.isNavigationReady().then(() => { + void Navigation.isNavigationReady().then(() => { Navigation.popToSidebar(); }); } @@ -659,13 +659,13 @@ function ReportScreen({route, navigation}: ReportScreenProps) { if (isMoneyRequestReportPendingDeletion(prevReport.parentReportID)) { return; } - Navigation.isNavigationReady().then(() => { + void Navigation.isNavigationReady().then(() => { Navigation.navigate(ROUTES.REPORT_WITH_ID.getRoute(prevReport.parentReportID)); }); return; } - Navigation.isNavigationReady().then(() => { + void Navigation.isNavigationReady().then(() => { navigateToConciergeChat(); }); return; @@ -730,7 +730,7 @@ function ReportScreen({route, navigation}: ReportScreenProps) { // This helps in tracking from the moment 'route' triggers useMemo until isLoadingInitialReportActions becomes true. It prevents blinking when loading reportActions from cache. useEffect(() => { - InteractionManager.runAfterInteractions(() => { + void InteractionManager.runAfterInteractions(() => { setIsLinkingToMessage(false); }); }, [reportMetadata?.isLoadingInitialReportActions]); @@ -765,7 +765,7 @@ function ReportScreen({route, navigation}: ReportScreenProps) { if (!isLinkedActionInaccessibleWhisper) { return; } - Navigation.isNavigationReady().then(() => { + void Navigation.isNavigationReady().then(() => { Navigation.setParams({reportActionID: ''}); }); }, [isLinkedActionInaccessibleWhisper]); diff --git a/src/pages/home/report/ContextMenu/BaseReportActionContextMenu.tsx b/src/pages/home/report/ContextMenu/BaseReportActionContextMenu.tsx index fc13ee633673..8694a165669c 100755 --- a/src/pages/home/report/ContextMenu/BaseReportActionContextMenu.tsx +++ b/src/pages/home/report/ContextMenu/BaseReportActionContextMenu.tsx @@ -273,7 +273,7 @@ function BaseReportActionContextMenu({ if (isAnonymousUser() && !isAnonymousAction) { hideContextMenu(false); - InteractionManager.runAfterInteractions(() => { + void InteractionManager.runAfterInteractions(() => { signOutAndRedirectToSignIn(); }); } else { diff --git a/src/pages/home/report/ContextMenu/ContextMenuActions.tsx b/src/pages/home/report/ContextMenu/ContextMenuActions.tsx index 31bc60c43492..59a95736844f 100644 --- a/src/pages/home/report/ContextMenu/ContextMenuActions.tsx +++ b/src/pages/home/report/ContextMenu/ContextMenuActions.tsx @@ -812,7 +812,7 @@ const ContextMenuActions: ContextMenuAction[] = [ setDownload(sourceID, true); const anchorRegex = CONST.REGEX_LINK_IN_ANCHOR; const isAnchorTag = anchorRegex.test(html); - fileDownload(sourceURLWithAuth, originalFileName ?? '', '', isAnchorTag && isMobileSafari()).then(() => setDownload(sourceID, false)); + void fileDownload(sourceURLWithAuth, originalFileName ?? '', '', isAnchorTag && isMobileSafari()).then(() => setDownload(sourceID, false)); if (closePopover) { hideContextMenu(true, ReportActionComposeFocusManager.focus); } diff --git a/src/pages/home/report/ContextMenu/PopoverReportActionContextMenu.tsx b/src/pages/home/report/ContextMenu/PopoverReportActionContextMenu.tsx index 77c9a626c168..3bd45615d920 100644 --- a/src/pages/home/report/ContextMenu/PopoverReportActionContextMenu.tsx +++ b/src/pages/home/report/ContextMenu/PopoverReportActionContextMenu.tsx @@ -302,7 +302,7 @@ function PopoverReportActionContextMenu(_props: unknown, ref: ForwardedRef { + void InteractionManager.runAfterInteractions(() => { deleteReportComment(reportIDRef.current, reportAction, isReportArchived); }); } diff --git a/src/pages/home/report/PureReportActionItem.tsx b/src/pages/home/report/PureReportActionItem.tsx index c2d6cbef6f63..6e6d4b1c9d3d 100644 --- a/src/pages/home/report/PureReportActionItem.tsx +++ b/src/pages/home/report/PureReportActionItem.tsx @@ -1413,7 +1413,7 @@ function PureReportActionItem({ if (isAnonymousUser()) { hideContextMenu(false); - InteractionManager.runAfterInteractions(() => { + void InteractionManager.runAfterInteractions(() => { signOutAndRedirectToSignIn(); }); } else { diff --git a/src/pages/home/report/ReportActionCompose/ComposerWithSuggestions/ComposerWithSuggestions.tsx b/src/pages/home/report/ReportActionCompose/ComposerWithSuggestions/ComposerWithSuggestions.tsx index 3d8805f9f619..81a984d1019d 100644 --- a/src/pages/home/report/ReportActionCompose/ComposerWithSuggestions/ComposerWithSuggestions.tsx +++ b/src/pages/home/report/ReportActionCompose/ComposerWithSuggestions/ComposerWithSuggestions.tsx @@ -509,7 +509,7 @@ function ComposerWithSuggestions( syncSelectionWithOnChangeTextRef.current = null; // ensure that selection is set imperatively after all state changes are effective - InteractionManager.runAfterInteractions(() => { + void InteractionManager.runAfterInteractions(() => { // note: this implementation is only available on non-web RN, thus the wrapping // 'if' block contains a redundant (since the ref is only used on iOS) platform check textInputRef.current?.setSelection(positionSnapshot, positionSnapshot); diff --git a/src/pages/home/report/ReportActionItemMessageEdit.tsx b/src/pages/home/report/ReportActionItemMessageEdit.tsx index 82e3f7279295..c80154a92e1e 100644 --- a/src/pages/home/report/ReportActionItemMessageEdit.tsx +++ b/src/pages/home/report/ReportActionItemMessageEdit.tsx @@ -257,7 +257,7 @@ function ReportActionItemMessageEdit( if (isActive()) { ReportActionComposeFocusManager.clear(true); // Wait for report action compose re-mounting on mWeb - InteractionManager.runAfterInteractions(() => ReportActionComposeFocusManager.focus()); + void InteractionManager.runAfterInteractions(() => ReportActionComposeFocusManager.focus()); } // Scroll to the last comment after editing to make sure the whole comment is clearly visible in the report. @@ -484,7 +484,7 @@ function ReportActionItemMessageEdit( ReportActionComposeFocusManager.editComposerRef.current = textInputRef.current; } startScrollBlock(); - InteractionManager.runAfterInteractions(() => { + void InteractionManager.runAfterInteractions(() => { requestAnimationFrame(() => { reportScrollManager.scrollToIndex(index, true); endScrollBlock(); diff --git a/src/pages/home/report/ReportActionsList.tsx b/src/pages/home/report/ReportActionsList.tsx index c79ea033bf31..e83411a224c1 100644 --- a/src/pages/home/report/ReportActionsList.tsx +++ b/src/pages/home/report/ReportActionsList.tsx @@ -457,7 +457,7 @@ function ReportActionsList({ return; } - InteractionManager.runAfterInteractions(() => { + void InteractionManager.runAfterInteractions(() => { setIsFloatingMessageCounterVisible(false); if (!shouldFocusToTopOnMount) { scrollToBottom(); @@ -474,7 +474,7 @@ function ReportActionsList({ } const prevSorted = lastAction?.reportActionID ? prevSortedVisibleReportActionsObjects[lastAction?.reportActionID] : null; if (lastAction?.actionName === CONST.REPORT.ACTIONS.TYPE.ACTIONABLE_TRACK_EXPENSE_WHISPER && !prevSorted) { - InteractionManager.runAfterInteractions(() => { + void InteractionManager.runAfterInteractions(() => { scrollToBottom(); }); } @@ -482,7 +482,7 @@ function ReportActionsList({ const scrollToBottomForCurrentUserAction = useCallback( (isFromCurrentUser: boolean, action?: OnyxTypes.ReportAction) => { - InteractionManager.runAfterInteractions(() => { + void InteractionManager.runAfterInteractions(() => { // If a new comment is added and it's from the current user scroll to the bottom otherwise leave the user positioned where // they are now in the list. if (!isFromCurrentUser || (!isReportTopmostSplitNavigator() && !Navigation.getReportRHPActiveRoute())) { @@ -572,7 +572,7 @@ function ReportActionsList({ if (lastIOUActionWithError?.reportActionID === prevLastIOUActionWithError?.reportActionID) { return; } - InteractionManager.runAfterInteractions(() => { + void InteractionManager.runAfterInteractions(() => { scrollToBottom(); }); // eslint-disable-next-line react-compiler/react-compiler, react-hooks/exhaustive-deps @@ -833,7 +833,7 @@ function ReportActionsList({ return; } - InteractionManager.runAfterInteractions(() => requestAnimationFrame(() => loadNewerChats(false))); + void InteractionManager.runAfterInteractions(() => requestAnimationFrame(() => loadNewerChats(false))); }, [loadNewerChats]); const onEndReached = useCallback(() => { diff --git a/src/pages/home/report/ReportActionsView.tsx b/src/pages/home/report/ReportActionsView.tsx index 3ea79bf352bd..cc61f17d3f50 100755 --- a/src/pages/home/report/ReportActionsView.tsx +++ b/src/pages/home/report/ReportActionsView.tsx @@ -264,7 +264,7 @@ function ReportActionsView({ } else { // After navigating to the linked reportAction, apply this to correctly set // `autoscrollToTopThreshold` prop when linking to a specific reportAction. - InteractionManager.runAfterInteractions(() => { + void InteractionManager.runAfterInteractions(() => { // Using a short delay to ensure the view is updated after interactions timerID = setTimeout(() => setNavigatingToLinkedMessage(false), 10); }); diff --git a/src/pages/home/report/UserTypingEventListener.tsx b/src/pages/home/report/UserTypingEventListener.tsx index 6c07732cdc36..04cc97678197 100644 --- a/src/pages/home/report/UserTypingEventListener.tsx +++ b/src/pages/home/report/UserTypingEventListener.tsx @@ -29,7 +29,7 @@ function UserTypingEventListener({report}: UserTypingEventListenerProps) { // unsubscribe from report typing events when the component unmounts didSubscribeToReportTypingEvents.current = false; - InteractionManager.runAfterInteractions(() => { + void InteractionManager.runAfterInteractions(() => { Report.unsubscribeFromReportChannel(reportID); }); }, @@ -61,7 +61,7 @@ function UserTypingEventListener({report}: UserTypingEventListenerProps) { if (topmostReportId !== reportID && didSubscribeToReportTypingEvents.current) { didSubscribeToReportTypingEvents.current = false; - InteractionManager.runAfterInteractions(() => { + void InteractionManager.runAfterInteractions(() => { Report.unsubscribeFromReportChannel(reportID); }); } diff --git a/src/pages/iou/RejectReasonPage.tsx b/src/pages/iou/RejectReasonPage.tsx index ebe0caa045f9..cf3c41a2cece 100644 --- a/src/pages/iou/RejectReasonPage.tsx +++ b/src/pages/iou/RejectReasonPage.tsx @@ -25,7 +25,7 @@ function RejectReasonPage({route}: RejectReasonPageProps) { const urlToNavigateBack = rejectMoneyRequest(transactionID, reportID, values.comment); Navigation.dismissModal(); if (urlToNavigateBack) { - Navigation.isNavigationReady().then(() => Navigation.goBack(urlToNavigateBack)); + void Navigation.isNavigationReady().then(() => Navigation.goBack(urlToNavigateBack)); } }; diff --git a/src/pages/iou/SplitExpensePage.tsx b/src/pages/iou/SplitExpensePage.tsx index a060584f9986..6bfe7a13884f 100644 --- a/src/pages/iou/SplitExpensePage.tsx +++ b/src/pages/iou/SplitExpensePage.tsx @@ -240,7 +240,7 @@ function SplitExpensePage({route}: SplitExpensePageProps) { )} onSelectRow={(item) => { Keyboard.dismiss(); - InteractionManager.runAfterInteractions(() => { + void InteractionManager.runAfterInteractions(() => { initDraftSplitExpenseDataForEdit(draftTransaction, item.transactionID, reportID); }); }} diff --git a/src/pages/iou/request/IOURequestStartPage.tsx b/src/pages/iou/request/IOURequestStartPage.tsx index 2d0456a48f6a..05952121fa6c 100644 --- a/src/pages/iou/request/IOURequestStartPage.tsx +++ b/src/pages/iou/request/IOURequestStartPage.tsx @@ -201,7 +201,7 @@ function IOURequestStartPage({ const onTabSelectFocusHandler = ({index}: {index: number}) => { // We runAfterInteractions since the function is called in the animate block on web-based // implementation, this fixes an animation glitch and matches the native internal delay - InteractionManager.runAfterInteractions(() => { + void InteractionManager.runAfterInteractions(() => { // 0 - Amount, 3 - PerDiem if (index === 0) { amountInputRef.current?.focus(); diff --git a/src/pages/iou/request/MoneyRequestParticipantsSelector.tsx b/src/pages/iou/request/MoneyRequestParticipantsSelector.tsx index 506716199402..3f4a25e8dcb0 100644 --- a/src/pages/iou/request/MoneyRequestParticipantsSelector.tsx +++ b/src/pages/iou/request/MoneyRequestParticipantsSelector.tsx @@ -463,7 +463,7 @@ function MoneyRequestParticipantsSelector( const initiateContactImportAndSetState = useCallback(() => { setContactPermissionState(RESULTS.GRANTED); - InteractionManager.runAfterInteractions(importAndSaveContacts); + void InteractionManager.runAfterInteractions(importAndSaveContacts); }, [importAndSaveContacts, setContactPermissionState]); const footerContent = useMemo(() => { diff --git a/src/pages/iou/request/step/IOURequestStepCategory.tsx b/src/pages/iou/request/step/IOURequestStepCategory.tsx index b549595aeee1..518db54bd7da 100644 --- a/src/pages/iou/request/step/IOURequestStepCategory.tsx +++ b/src/pages/iou/request/step/IOURequestStepCategory.tsx @@ -181,7 +181,7 @@ function IOURequestStepCategory({ if (!policy.areCategoriesEnabled) { enablePolicyCategories(policy.id, true, policyTagLists, allTransactionViolations, false); } - InteractionManager.runAfterInteractions(() => { + void InteractionManager.runAfterInteractions(() => { Navigation.navigate( ROUTES.SETTINGS_CATEGORIES_ROOT.getRoute( policy.id, diff --git a/src/pages/iou/request/step/IOURequestStepDescription.tsx b/src/pages/iou/request/step/IOURequestStepDescription.tsx index c7e7f00cf396..d2d9321a0369 100644 --- a/src/pages/iou/request/step/IOURequestStepDescription.tsx +++ b/src/pages/iou/request/step/IOURequestStepDescription.tsx @@ -171,7 +171,7 @@ function IOURequestStepDescription({ { - InteractionManager.runAfterInteractions(() => { + void InteractionManager.runAfterInteractions(() => { inputRef.current?.focus(); }); }} diff --git a/src/pages/iou/request/step/IOURequestStepDestination.tsx b/src/pages/iou/request/step/IOURequestStepDestination.tsx index 576f92d884fa..b16a9cc506db 100644 --- a/src/pages/iou/request/step/IOURequestStepDestination.tsx +++ b/src/pages/iou/request/step/IOURequestStepDestination.tsx @@ -163,7 +163,7 @@ function IOURequestStepDestination({ success style={[styles.w100]} onPress={() => { - InteractionManager.runAfterInteractions(() => { + void InteractionManager.runAfterInteractions(() => { Navigation.navigate(ROUTES.WORKSPACE_PER_DIEM.getRoute(policy.id, Navigation.getActiveRoute())); }); }} diff --git a/src/pages/iou/request/step/IOURequestStepMerchant.tsx b/src/pages/iou/request/step/IOURequestStepMerchant.tsx index 70c5cd0e14a8..08c79eb7b5ae 100644 --- a/src/pages/iou/request/step/IOURequestStepMerchant.tsx +++ b/src/pages/iou/request/step/IOURequestStepMerchant.tsx @@ -145,7 +145,7 @@ function IOURequestStepMerchant({ { - InteractionManager.runAfterInteractions(() => { + void InteractionManager.runAfterInteractions(() => { inputRef.current?.focus(); }); }} diff --git a/src/pages/iou/request/step/IOURequestStepReport.tsx b/src/pages/iou/request/step/IOURequestStepReport.tsx index afa921964541..ec50682be035 100644 --- a/src/pages/iou/request/step/IOURequestStepReport.tsx +++ b/src/pages/iou/request/step/IOURequestStepReport.tsx @@ -97,7 +97,7 @@ function IOURequestStepReport({route, transaction}: IOURequestStepReportProps) { } handleGoBack(); - InteractionManager.runAfterInteractions(() => { + void InteractionManager.runAfterInteractions(() => { setTransactionReport( transaction.transactionID, { @@ -147,7 +147,7 @@ function IOURequestStepReport({route, transaction}: IOURequestStepReportProps) { return; } Navigation.dismissModal(); - InteractionManager.runAfterInteractions(() => { + void InteractionManager.runAfterInteractions(() => { changeTransactionsReport( [transaction.transactionID], CONST.REPORT.UNREPORTED_REPORT_ID, diff --git a/src/pages/iou/request/step/IOURequestStepScan/ReceiptView/index.tsx b/src/pages/iou/request/step/IOURequestStepScan/ReceiptView/index.tsx index 276cb06c59c5..2ec599853016 100644 --- a/src/pages/iou/request/step/IOURequestStepScan/ReceiptView/index.tsx +++ b/src/pages/iou/request/step/IOURequestStepScan/ReceiptView/index.tsx @@ -66,7 +66,7 @@ function ReceiptView({route}: ReceiptViewProps) { return; } - InteractionManager.runAfterInteractions(() => { + void InteractionManager.runAfterInteractions(() => { if (currentReceipt.transactionID === CONST.IOU.OPTIMISTIC_TRANSACTION_ID) { if (receipts.length === 1) { removeTransactionReceipt(currentReceipt.transactionID); diff --git a/src/pages/iou/request/step/IOURequestStepScan/index.native.tsx b/src/pages/iou/request/step/IOURequestStepScan/index.native.tsx index b63b301fe5f3..1901da545ae1 100644 --- a/src/pages/iou/request/step/IOURequestStepScan/index.native.tsx +++ b/src/pages/iou/request/step/IOURequestStepScan/index.native.tsx @@ -233,7 +233,7 @@ function IOURequestStepScan({ .catch(() => setCameraPermissionStatus(RESULTS.UNAVAILABLE)); }; - InteractionManager.runAfterInteractions(() => { + void InteractionManager.runAfterInteractions(() => { // Check initial camera permission status refreshCameraPermissionStatus(); }); @@ -559,7 +559,7 @@ function IOURequestStepScan({ }, [initialTransactionID, isEditing, navigateToConfirmationStep]); const dismissMultiScanEducationalPopup = () => { - InteractionManager.runAfterInteractions(() => { + void InteractionManager.runAfterInteractions(() => { dismissProductTraining(CONST.PRODUCT_TRAINING_TOOLTIP_NAMES.MULTI_SCAN_EDUCATIONAL_MODAL); setShouldShowMultiScanEducationalPopup(false); }); diff --git a/src/pages/iou/request/step/IOURequestStepScan/index.tsx b/src/pages/iou/request/step/IOURequestStepScan/index.tsx index b70768a40c31..86ebb64d8a6b 100644 --- a/src/pages/iou/request/step/IOURequestStepScan/index.tsx +++ b/src/pages/iou/request/step/IOURequestStepScan/index.tsx @@ -813,7 +813,7 @@ function IOURequestStepScan({ ); const dismissMultiScanEducationalPopup = () => { - InteractionManager.runAfterInteractions(() => { + void InteractionManager.runAfterInteractions(() => { dismissProductTraining(CONST.PRODUCT_TRAINING_TOOLTIP_NAMES.MULTI_SCAN_EDUCATIONAL_MODAL); setShouldShowMultiScanEducationalPopup(false); }); diff --git a/src/pages/iou/request/step/IOURequestStepSubrate.tsx b/src/pages/iou/request/step/IOURequestStepSubrate.tsx index f84143569a79..26a1e9d7eafd 100644 --- a/src/pages/iou/request/step/IOURequestStepSubrate.tsx +++ b/src/pages/iou/request/step/IOURequestStepSubrate.tsx @@ -229,7 +229,7 @@ function IOURequestStepSubrate({ items={validOptions} onValueChange={(value) => { setSubrateValue(value as string); - InteractionManager.runAfterInteractions(() => { + void InteractionManager.runAfterInteractions(() => { textInputRef.current?.focus(); }); }} diff --git a/src/pages/media/AttachmentModalScreen/AttachmentModalBaseContent/index.tsx b/src/pages/media/AttachmentModalScreen/AttachmentModalBaseContent/index.tsx index 244233b0f2a4..979a6ff50091 100644 --- a/src/pages/media/AttachmentModalScreen/AttachmentModalBaseContent/index.tsx +++ b/src/pages/media/AttachmentModalScreen/AttachmentModalBaseContent/index.tsx @@ -169,7 +169,7 @@ function AttachmentModalBaseContent({ if (typeof sourceURL === 'string') { const fileName = type === CONST.ATTACHMENT_TYPE.SEARCH ? getFileName(`${sourceURL}`) : file?.name; - fileDownload(sourceURL, fileName ?? '', undefined, undefined, undefined, undefined, undefined, !draftTransactionID); + void fileDownload(sourceURL, fileName ?? '', undefined, undefined, undefined, undefined, undefined, !draftTransactionID); } // At ios, if the keyboard is open while opening the attachment, then after downloading @@ -233,7 +233,7 @@ function AttachmentModalBaseContent({ text: translate('common.replace'), onSelected: () => { const goToScanScreen = () => { - InteractionManager.runAfterInteractions(() => { + void InteractionManager.runAfterInteractions(() => { Navigation.navigate( ROUTES.MONEY_REQUEST_STEP_SCAN.getRoute( iouAction ?? CONST.IOU.ACTION.EDIT, diff --git a/src/pages/media/AttachmentModalScreen/routes/ReportAttachmentModalContent.tsx b/src/pages/media/AttachmentModalScreen/routes/ReportAttachmentModalContent.tsx index 9b49c044395b..930ab8f08e1f 100644 --- a/src/pages/media/AttachmentModalScreen/routes/ReportAttachmentModalContent.tsx +++ b/src/pages/media/AttachmentModalScreen/routes/ReportAttachmentModalContent.tsx @@ -222,7 +222,7 @@ function ReportAttachmentModalContent({route, navigation}: AttachmentModalScreen return; } - Navigation.isNavigationReady().then(() => { + void Navigation.isNavigationReady().then(() => { if (reportID) { Navigation.goBack(ROUTES.REPORT_WITH_ID.getRoute(reportID)); } else { diff --git a/src/pages/settings/Profile/Contacts/ContactMethodDetailsPage.tsx b/src/pages/settings/Profile/Contacts/ContactMethodDetailsPage.tsx index 21215875c607..1d7625712337 100644 --- a/src/pages/settings/Profile/Contacts/ContactMethodDetailsPage.tsx +++ b/src/pages/settings/Profile/Contacts/ContactMethodDetailsPage.tsx @@ -133,7 +133,7 @@ function ContactMethodDetailsPage({route}: ContactMethodDetailsPageProps) { */ const toggleDeleteModal = useCallback((isOpen: boolean) => { if (canUseTouchScreen() && isOpen) { - InteractionManager.runAfterInteractions(() => { + void InteractionManager.runAfterInteractions(() => { setIsDeleteModalOpen(isOpen); }); Keyboard.dismiss(); @@ -217,7 +217,7 @@ function ContactMethodDetailsPage({route}: ContactMethodDetailsPageProps) { onConfirm={confirmDeleteAndHideModal} onCancel={() => toggleDeleteModal(false)} onModalHide={() => { - InteractionManager.runAfterInteractions(() => { + void InteractionManager.runAfterInteractions(() => { validateCodeFormRef.current?.focusLastSelected?.(); }); }} @@ -280,7 +280,7 @@ function ContactMethodDetailsPage({route}: ContactMethodDetailsPageProps) { { - InteractionManager.runAfterInteractions(() => { + void InteractionManager.runAfterInteractions(() => { validateCodeFormRef.current?.focus?.(); }); }} diff --git a/src/pages/settings/Security/MergeAccounts/MergeResultPage.tsx b/src/pages/settings/Security/MergeAccounts/MergeResultPage.tsx index 0624a3793d90..700d3fa68f1d 100644 --- a/src/pages/settings/Security/MergeAccounts/MergeResultPage.tsx +++ b/src/pages/settings/Security/MergeAccounts/MergeResultPage.tsx @@ -193,7 +193,7 @@ function MergeResultPage() { return; } - InteractionManager.runAfterInteractions(() => { + void InteractionManager.runAfterInteractions(() => { Navigation.removeScreenFromNavigationState(SCREENS.SETTINGS.MERGE_ACCOUNTS.ACCOUNT_DETAILS); }); }, [result]); diff --git a/src/pages/settings/Security/TwoFactorAuth/VerifyPage.tsx b/src/pages/settings/Security/TwoFactorAuth/VerifyPage.tsx index 8324d5482585..6721b5ceddbb 100644 --- a/src/pages/settings/Security/TwoFactorAuth/VerifyPage.tsx +++ b/src/pages/settings/Security/TwoFactorAuth/VerifyPage.tsx @@ -75,7 +75,7 @@ function VerifyPage({route}: VerifyPageProps) { const scrollViewRef = useRef(null); const handleInputFocus = useCallback(() => { - InteractionManager.runAfterInteractions(() => { + void InteractionManager.runAfterInteractions(() => { requestAnimationFrame(() => { scrollViewRef.current?.scrollToEnd({animated: true}); }); diff --git a/src/pages/signin/LoginForm/BaseLoginForm.tsx b/src/pages/signin/LoginForm/BaseLoginForm.tsx index 0975fb9a224e..322282a9bd17 100644 --- a/src/pages/signin/LoginForm/BaseLoginForm.tsx +++ b/src/pages/signin/LoginForm/BaseLoginForm.tsx @@ -216,7 +216,7 @@ function BaseLoginForm({blurOnSubmit = false, isVisible, ref}: BaseLoginFormProp // On mobile WebKit browsers, when an input field gains focus, the keyboard appears and the virtual viewport is resized and scrolled to make the input field visible. // This occurs even when there is enough space to display both the input field and the submit button in the current view. // so this change to correct the scroll position when the input field gains focus. - InteractionManager.runAfterInteractions(() => { + void InteractionManager.runAfterInteractions(() => { htmlDivElementRef(submitContainerRef).current?.scrollIntoView?.({behavior: 'smooth', block: 'end'}); }); }, []); diff --git a/src/pages/signin/SAMLSignInPage/index.native.tsx b/src/pages/signin/SAMLSignInPage/index.native.tsx index 77baf3565713..c8215f573369 100644 --- a/src/pages/signin/SAMLSignInPage/index.native.tsx +++ b/src/pages/signin/SAMLSignInPage/index.native.tsx @@ -76,7 +76,7 @@ function SAMLSignInPage() { clearSignInData(); setAccountError(searchParams.get('error') ?? ''); - Navigation.isNavigationReady().then(() => { + void Navigation.isNavigationReady().then(() => { // We must call goBack() to remove the /transition route from history Navigation.goBack(); Navigation.navigate(ROUTES.HOME); @@ -97,7 +97,7 @@ function SAMLSignInPage() { title="" onBackButtonPress={() => { clearSignInData(); - Navigation.isNavigationReady().then(() => { + void Navigation.isNavigationReady().then(() => { Navigation.goBack(); }); }} diff --git a/src/pages/signin/SignInModal.tsx b/src/pages/signin/SignInModal.tsx index 778f57ce847e..a59ebdfc6540 100644 --- a/src/pages/signin/SignInModal.tsx +++ b/src/pages/signin/SignInModal.tsx @@ -35,7 +35,7 @@ function SignInModal() { const isAnonymousUser = session?.authTokenType === CONST.AUTH_TOKEN_TYPES.ANONYMOUS; if (!isAnonymousUser) { // Signing in RHP is only for anonymous users - Navigation.isNavigationReady().then(() => { + void Navigation.isNavigationReady().then(() => { Navigation.dismissModal(); }); diff --git a/src/pages/signin/SignInPage.tsx b/src/pages/signin/SignInPage.tsx index c28a411b6c92..2bf7f105c64b 100644 --- a/src/pages/signin/SignInPage.tsx +++ b/src/pages/signin/SignInPage.tsx @@ -221,7 +221,7 @@ function SignInPage({ref}: SignInPageProps) { if (shouldInitiateSAMLLogin) { setHasInitiatedSAMLLogin(true); - Navigation.isNavigationReady().then(() => Navigation.navigate(ROUTES.SAML_SIGN_IN)); + void Navigation.isNavigationReady().then(() => Navigation.navigate(ROUTES.SAML_SIGN_IN)); } let welcomeHeader = ''; diff --git a/src/pages/tasks/NewTaskPage.tsx b/src/pages/tasks/NewTaskPage.tsx index f056ae8ba3a9..0b60084a718a 100644 --- a/src/pages/tasks/NewTaskPage.tsx +++ b/src/pages/tasks/NewTaskPage.tsx @@ -59,7 +59,7 @@ function NewTaskPage({route}: NewTaskPageProps) { useFocusEffect( useCallback(() => { focusTimeoutRef.current = setTimeout(() => { - InteractionManager.runAfterInteractions(() => { + void InteractionManager.runAfterInteractions(() => { blurActiveElement(); }); }, CONST.ANIMATED_TRANSITION); diff --git a/src/pages/tasks/TaskAssigneeSelectorModal.tsx b/src/pages/tasks/TaskAssigneeSelectorModal.tsx index 9cb534b63914..7716c8a96c61 100644 --- a/src/pages/tasks/TaskAssigneeSelectorModal.tsx +++ b/src/pages/tasks/TaskAssigneeSelectorModal.tsx @@ -124,7 +124,7 @@ function TaskAssigneeSelectorModal() { } const reportOnyx = reports?.[`${ONYXKEYS.COLLECTION.REPORT}${route.params?.reportID}`]; if (reportOnyx && !isTaskReport(reportOnyx)) { - Navigation.isNavigationReady().then(() => { + void Navigation.isNavigationReady().then(() => { Navigation.dismissModalWithReport({reportID: reportOnyx.reportID}); }); } @@ -196,7 +196,7 @@ function TaskAssigneeSelectorModal() { // Pass through the selected assignee editTaskAssignee(report, session?.accountID ?? CONST.DEFAULT_NUMBER_ID, option?.login ?? '', option?.accountID, assigneeChatReport); } - InteractionManager.runAfterInteractions(() => { + void InteractionManager.runAfterInteractions(() => { Navigation.dismissModalWithReport({reportID: report?.reportID}); }); // If there's no report, we're creating a new task @@ -208,7 +208,7 @@ function TaskAssigneeSelectorModal() { undefined, // passing null as report is null in this condition isCurrentUser({...option, accountID: option?.accountID ?? CONST.DEFAULT_NUMBER_ID, login: option?.login ?? undefined}), ); - InteractionManager.runAfterInteractions(() => { + void InteractionManager.runAfterInteractions(() => { Navigation.goBack(ROUTES.NEW_TASK.getRoute(backTo)); }); } diff --git a/src/pages/tasks/TaskDescriptionPage.tsx b/src/pages/tasks/TaskDescriptionPage.tsx index e513cf56ec31..944a3b11b89b 100644 --- a/src/pages/tasks/TaskDescriptionPage.tsx +++ b/src/pages/tasks/TaskDescriptionPage.tsx @@ -65,7 +65,7 @@ function TaskDescriptionPage({report, currentUserPersonalDetails}: TaskDescripti ); if (!isTaskReport(report)) { - Navigation.isNavigationReady().then(() => { + void Navigation.isNavigationReady().then(() => { Navigation.dismissModalWithReport({reportID: report?.reportID}); }); } diff --git a/src/pages/tasks/TaskTitlePage.tsx b/src/pages/tasks/TaskTitlePage.tsx index b12f17abf276..1cc843bb5a23 100644 --- a/src/pages/tasks/TaskTitlePage.tsx +++ b/src/pages/tasks/TaskTitlePage.tsx @@ -70,7 +70,7 @@ function TaskTitlePage({report, currentUserPersonalDetails}: TaskTitlePageProps) ); if (!isTaskReport(report)) { - Navigation.isNavigationReady().then(() => { + void Navigation.isNavigationReady().then(() => { Navigation.dismissModalWithReport({reportID: report?.reportID}); }); } diff --git a/src/pages/wallet/WalletStatementPage.tsx b/src/pages/wallet/WalletStatementPage.tsx index e6208ebe7cf0..365b5df13930 100644 --- a/src/pages/wallet/WalletStatementPage.tsx +++ b/src/pages/wallet/WalletStatementPage.tsx @@ -56,7 +56,7 @@ function WalletStatementPage({route}: WalletStatementPageProps) { const downloadFileName = `Expensify_Statement_${yearMonth}.pdf`; const fileName = walletStatement[yearMonth]; const pdfURL = `${baseURL}secure?secureType=pdfreport&filename=${fileName}&downloadName=${downloadFileName}`; - fileDownload(pdfURL, downloadFileName).finally(() => setIsDownloading(false)); + void fileDownload(pdfURL, downloadFileName).finally(() => setIsDownloading(false)); return; } diff --git a/src/pages/workspace/AccessOrNotFoundWrapper.tsx b/src/pages/workspace/AccessOrNotFoundWrapper.tsx index ec084674ec1a..c2f642f12032 100644 --- a/src/pages/workspace/AccessOrNotFoundWrapper.tsx +++ b/src/pages/workspace/AccessOrNotFoundWrapper.tsx @@ -184,7 +184,7 @@ function AccessOrNotFoundWrapper({ } // When a workspace feature linked to the current page is disabled we will navigate to the More Features page. - Navigation.isNavigationReady().then(() => Navigation.goBack(ROUTES.WORKSPACE_MORE_FEATURES.getRoute(policyID))); + void Navigation.isNavigationReady().then(() => Navigation.goBack(ROUTES.WORKSPACE_MORE_FEATURES.getRoute(policyID))); // We don't need to run the effect on policyID change as we only use it to get the route to navigate to. // eslint-disable-next-line react-compiler/react-compiler // eslint-disable-next-line react-hooks/exhaustive-deps diff --git a/src/pages/workspace/WorkspaceInitialPage.tsx b/src/pages/workspace/WorkspaceInitialPage.tsx index 492d7f864910..a30183fd8c7b 100644 --- a/src/pages/workspace/WorkspaceInitialPage.tsx +++ b/src/pages/workspace/WorkspaceInitialPage.tsx @@ -432,7 +432,7 @@ function WorkspaceInitialPage({policyDraft, policy: policyProp, route}: Workspac } wasRendered.current = true; // We are dismissing any modals that are open when the NotFound view is shown - Navigation.isNavigationReady().then(() => { + void Navigation.isNavigationReady().then(() => { Navigation.closeRHPFlow(); }); }, [canAccessRoute, shouldShowNotFoundPage]); diff --git a/src/pages/workspace/WorkspaceInviteMessagePage.tsx b/src/pages/workspace/WorkspaceInviteMessagePage.tsx index 9d5a15af0114..b569dfa5ebc3 100644 --- a/src/pages/workspace/WorkspaceInviteMessagePage.tsx +++ b/src/pages/workspace/WorkspaceInviteMessagePage.tsx @@ -121,7 +121,7 @@ function WorkspaceInviteMessagePage({policy, route, currentUserPersonalDetails}: Navigation.setNavigationActionToMicrotaskQueue(() => { Navigation.dismissModal(); - InteractionManager.runAfterInteractions(() => { + void InteractionManager.runAfterInteractions(() => { Navigation.navigate(ROUTES.WORKSPACE_MEMBERS.getRoute(route.params.policyID)); }); }); diff --git a/src/pages/workspace/WorkspaceJoinUserPage.tsx b/src/pages/workspace/WorkspaceJoinUserPage.tsx index a0e0890aa38f..35e35d59eebf 100644 --- a/src/pages/workspace/WorkspaceJoinUserPage.tsx +++ b/src/pages/workspace/WorkspaceJoinUserPage.tsx @@ -31,7 +31,7 @@ function WorkspaceJoinUserPage({route}: WorkspaceJoinUserPageProps) { return; } if (!isEmptyObject(policy) && !policy?.isJoinRequestPending && !isPendingDeletePolicy(policy)) { - Navigation.isNavigationReady().then(() => { + void Navigation.isNavigationReady().then(() => { if (Navigation.getShouldPopToSidebar()) { Navigation.popToSidebar(); } else { @@ -42,7 +42,7 @@ function WorkspaceJoinUserPage({route}: WorkspaceJoinUserPageProps) { return; } inviteMemberToWorkspace(policyID, inviterEmail); - Navigation.isNavigationReady().then(() => { + void Navigation.isNavigationReady().then(() => { if (isUnmounted.current) { return; } diff --git a/src/pages/workspace/WorkspaceMembersPage.tsx b/src/pages/workspace/WorkspaceMembersPage.tsx index 5f2361cac286..9648546caa0b 100644 --- a/src/pages/workspace/WorkspaceMembersPage.tsx +++ b/src/pages/workspace/WorkspaceMembersPage.tsx @@ -293,7 +293,7 @@ function WorkspaceMembersPage({personalDetails, route, policy}: WorkspaceMembers } setRemoveMembersConfirmModalVisible(false); - InteractionManager.runAfterInteractions(() => { + void InteractionManager.runAfterInteractions(() => { setSelectedEmployees([]); removeMembers(accountIDsToRemove, route.params.policyID); }); @@ -775,7 +775,7 @@ function WorkspaceMembersPage({personalDetails, route, policy}: WorkspaceMembers confirmText={translate('common.remove')} cancelText={translate('common.cancel')} onModalHide={() => { - InteractionManager.runAfterInteractions(() => { + void InteractionManager.runAfterInteractions(() => { if (!textInputRef.current) { return; } diff --git a/src/pages/workspace/WorkspaceNewRoomPage.tsx b/src/pages/workspace/WorkspaceNewRoomPage.tsx index aed3473f6a19..4b652e3186c3 100644 --- a/src/pages/workspace/WorkspaceNewRoomPage.tsx +++ b/src/pages/workspace/WorkspaceNewRoomPage.tsx @@ -125,7 +125,7 @@ function WorkspaceNewRoomPage(_: unknown, ref: React.Ref { + void InteractionManager.runAfterInteractions(() => { requestAnimationFrame(() => { addPolicyReport(policyReport); }); diff --git a/src/pages/workspace/WorkspacesListPage.tsx b/src/pages/workspace/WorkspacesListPage.tsx index fb30eae0ac76..5d47fac38054 100755 --- a/src/pages/workspace/WorkspacesListPage.tsx +++ b/src/pages/workspace/WorkspacesListPage.tsx @@ -447,7 +447,7 @@ function WorkspacesListPage() { const duplicateWorkspaceIndex = filteredWorkspaces.findIndex((workspace) => workspace.policyID === duplicateWorkspace.policyID); if (duplicateWorkspaceIndex > 0) { flatlistRef.current?.scrollToIndex({index: duplicateWorkspaceIndex, animated: false}); - InteractionManager.runAfterInteractions(() => { + void InteractionManager.runAfterInteractions(() => { clearDuplicateWorkspace(); }); } diff --git a/src/pages/workspace/accounting/intacct/SageIntacctPrerequisitesPage.tsx b/src/pages/workspace/accounting/intacct/SageIntacctPrerequisitesPage.tsx index b6ed63611c64..c55d8e3d6589 100644 --- a/src/pages/workspace/accounting/intacct/SageIntacctPrerequisitesPage.tsx +++ b/src/pages/workspace/accounting/intacct/SageIntacctPrerequisitesPage.tsx @@ -41,7 +41,7 @@ function SageIntacctPrerequisitesPage({route}: SageIntacctPrerequisitesPageProps iconRight: Expensicons.NewWindow, shouldShowRightIcon: true, onPress: () => { - fileDownload(CONST.EXPENSIFY_PACKAGE_FOR_SAGE_INTACCT, CONST.EXPENSIFY_PACKAGE_FOR_SAGE_INTACCT_FILE_NAME, '', true); + void fileDownload(CONST.EXPENSIFY_PACKAGE_FOR_SAGE_INTACCT, CONST.EXPENSIFY_PACKAGE_FOR_SAGE_INTACCT_FILE_NAME, '', true); }, onSecondaryInteraction: (event: GestureResponderEvent | MouseEvent) => showContextMenu({ diff --git a/src/pages/workspace/categories/WorkspaceCategoriesPage.tsx b/src/pages/workspace/categories/WorkspaceCategoriesPage.tsx index f4ecc1c4fe45..601c49603c5d 100644 --- a/src/pages/workspace/categories/WorkspaceCategoriesPage.tsx +++ b/src/pages/workspace/categories/WorkspaceCategoriesPage.tsx @@ -258,7 +258,7 @@ function WorkspaceCategoriesPage({route}: WorkspaceCategoriesPageProps) { deleteWorkspaceCategories(policyId, selectedCategories, policyTagLists, allTransactionViolations); setDeleteCategoriesConfirmModalVisible(false); - InteractionManager.runAfterInteractions(() => { + void InteractionManager.runAfterInteractions(() => { setSelectedCategories([]); }); }; diff --git a/src/pages/workspace/categories/WorkspaceCategoriesSettingsPage.tsx b/src/pages/workspace/categories/WorkspaceCategoriesSettingsPage.tsx index 7025a640453d..ce65cb844f54 100644 --- a/src/pages/workspace/categories/WorkspaceCategoriesSettingsPage.tsx +++ b/src/pages/workspace/categories/WorkspaceCategoriesSettingsPage.tsx @@ -90,7 +90,7 @@ function WorkspaceCategoriesSettingsPage({policy, route}: WorkspaceCategoriesSet } Keyboard.dismiss(); - InteractionManager.runAfterInteractions(() => { + void InteractionManager.runAfterInteractions(() => { setIsSelectorModalVisible(false); }); }; diff --git a/src/pages/workspace/companyCards/WorkspaceCompanyCardsSettingsPage.tsx b/src/pages/workspace/companyCards/WorkspaceCompanyCardsSettingsPage.tsx index ce792ff17364..69640b2a8037 100644 --- a/src/pages/workspace/companyCards/WorkspaceCompanyCardsSettingsPage.tsx +++ b/src/pages/workspace/companyCards/WorkspaceCompanyCardsSettingsPage.tsx @@ -83,7 +83,7 @@ function WorkspaceCompanyCardsSettingsPage({ const feedToOpen = (Object.keys(companyFeeds) as CompanyCardFeed[]) .filter((feed) => feed !== selectedFeed && companyFeeds[feed]?.pendingAction !== CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE) .at(0); - InteractionManager.runAfterInteractions(() => { + void InteractionManager.runAfterInteractions(() => { deleteWorkspaceCompanyCardFeed(policyID, domainOrWorkspaceAccountID, selectedFeed, cardIDs, feedToOpen); }); } diff --git a/src/pages/workspace/companyCards/addNew/PlaidConnectionStep.tsx b/src/pages/workspace/companyCards/addNew/PlaidConnectionStep.tsx index bdfd6e5ed48f..3f8e19e0f9ab 100644 --- a/src/pages/workspace/companyCards/addNew/PlaidConnectionStep.tsx +++ b/src/pages/workspace/companyCards/addNew/PlaidConnectionStep.tsx @@ -132,7 +132,7 @@ function PlaidConnectionStep({feed, policyID}: {feed?: CompanyCardFeed; policyID addNewCard.data.statementPeriodEnd, addNewCard.data.statementPeriodEndDay, ); - InteractionManager.runAfterInteractions(() => { + void InteractionManager.runAfterInteractions(() => { setAssignCardStepAndData({ data: { plaidAccessToken: publicToken, diff --git a/src/pages/workspace/companyCards/assignCard/ConfirmationStep.tsx b/src/pages/workspace/companyCards/assignCard/ConfirmationStep.tsx index 87bd0d0e8ff8..5aca93fa1ec7 100644 --- a/src/pages/workspace/companyCards/assignCard/ConfirmationStep.tsx +++ b/src/pages/workspace/companyCards/assignCard/ConfirmationStep.tsx @@ -65,7 +65,7 @@ function ConfirmationStep({policyID, feed, backTo}: ConfirmationStepProps) { } else { Navigation.navigate(ROUTES.WORKSPACE_COMPANY_CARDS.getRoute(policyID), {forceReplace: true}); } - InteractionManager.runAfterInteractions(() => clearAssignCardStepAndData()); + void InteractionManager.runAfterInteractions(() => clearAssignCardStepAndData()); }, [assignCard, backTo, policyID, currentFullScreenRoute?.state?.routes]); const submit = () => { diff --git a/src/pages/workspace/distanceRates/PolicyDistanceRatesPage.tsx b/src/pages/workspace/distanceRates/PolicyDistanceRatesPage.tsx index 117c56927ad9..84e75d29d954 100644 --- a/src/pages/workspace/distanceRates/PolicyDistanceRatesPage.tsx +++ b/src/pages/workspace/distanceRates/PolicyDistanceRatesPage.tsx @@ -323,7 +323,7 @@ function PolicyDistanceRatesPage({ deletePolicyDistanceRates(policyID, customUnit, selectedDistanceRates, transactionIDsAffected, transactionViolations); setIsDeleteModalVisible(false); - InteractionManager.runAfterInteractions(() => { + void InteractionManager.runAfterInteractions(() => { setSelectedDistanceRates([]); }); }; diff --git a/src/pages/workspace/distanceRates/PolicyDistanceRatesSettingsPage.tsx b/src/pages/workspace/distanceRates/PolicyDistanceRatesSettingsPage.tsx index 6705569cbbed..45e7aa4e77c4 100644 --- a/src/pages/workspace/distanceRates/PolicyDistanceRatesSettingsPage.tsx +++ b/src/pages/workspace/distanceRates/PolicyDistanceRatesSettingsPage.tsx @@ -159,7 +159,7 @@ function PolicyDistanceRatesSettingsPage({route}: PolicyDistanceRatesSettingsPag { Navigation.dismissModal(); - Navigation.isNavigationReady().then(() => { + void Navigation.isNavigationReady().then(() => { Navigation.goBack(ROUTES.WORKSPACE_MORE_FEATURES.getRoute(policyID)); }); }} diff --git a/src/pages/workspace/members/ImportedMembersPage.tsx b/src/pages/workspace/members/ImportedMembersPage.tsx index 012036bd0bc1..bb8e92d37952 100644 --- a/src/pages/workspace/members/ImportedMembersPage.tsx +++ b/src/pages/workspace/members/ImportedMembersPage.tsx @@ -189,7 +189,7 @@ function ImportedMembersPage({route}: ImportedMembersPageProps) { shouldShowCancelButton={false} shouldHandleNavigationBack onModalHide={() => { - InteractionManager.runAfterInteractions(() => Navigation.goBack(ROUTES.WORKSPACE_MEMBERS.getRoute(policyID))); + void InteractionManager.runAfterInteractions(() => Navigation.goBack(ROUTES.WORKSPACE_MEMBERS.getRoute(policyID))); }} /> diff --git a/src/pages/workspace/perDiem/WorkspacePerDiemPage.tsx b/src/pages/workspace/perDiem/WorkspacePerDiemPage.tsx index 242a2cc79c05..7be83ef27622 100644 --- a/src/pages/workspace/perDiem/WorkspacePerDiemPage.tsx +++ b/src/pages/workspace/perDiem/WorkspacePerDiemPage.tsx @@ -261,7 +261,7 @@ function WorkspacePerDiemPage({route}: WorkspacePerDiemPageProps) { deleteWorkspacePerDiemRates(policyID, customUnit, selectedPerDiem); setDeletePerDiemConfirmModalVisible(false); - InteractionManager.runAfterInteractions(() => { + void InteractionManager.runAfterInteractions(() => { setSelectedPerDiem([]); }); }; diff --git a/src/pages/workspace/reports/ReportFieldsListValuesPage.tsx b/src/pages/workspace/reports/ReportFieldsListValuesPage.tsx index 8f740f12f6f8..30897f00d4ad 100644 --- a/src/pages/workspace/reports/ReportFieldsListValuesPage.tsx +++ b/src/pages/workspace/reports/ReportFieldsListValuesPage.tsx @@ -190,7 +190,7 @@ function ReportFieldsListValuesPage({ setDeleteValuesConfirmModalVisible(false); - InteractionManager.runAfterInteractions(() => { + void InteractionManager.runAfterInteractions(() => { setSelectedValues({}); }); }; diff --git a/src/pages/workspace/tags/WorkspaceTagsPage.tsx b/src/pages/workspace/tags/WorkspaceTagsPage.tsx index 2f8f7892747e..ddcfd18fb8e2 100644 --- a/src/pages/workspace/tags/WorkspaceTagsPage.tsx +++ b/src/pages/workspace/tags/WorkspaceTagsPage.tsx @@ -374,7 +374,7 @@ function WorkspaceTagsPage({route}: WorkspaceTagsPageProps) { deletePolicyTags(policyID, selectedTags, policyTags); setIsDeleteTagsConfirmModalVisible(false); - InteractionManager.runAfterInteractions(() => { + void InteractionManager.runAfterInteractions(() => { setSelectedTags([]); if (isMobileSelectionModeEnabled && selectedTags.length === Object.keys(policyTagLists.at(0)?.tags ?? {}).length) { turnOffMobileSelectionMode(); diff --git a/src/pages/workspace/tags/WorkspaceViewTagsPage.tsx b/src/pages/workspace/tags/WorkspaceViewTagsPage.tsx index 1403c4fa91ae..ade3cd493b27 100644 --- a/src/pages/workspace/tags/WorkspaceViewTagsPage.tsx +++ b/src/pages/workspace/tags/WorkspaceViewTagsPage.tsx @@ -215,7 +215,7 @@ function WorkspaceViewTagsPage({route}: WorkspaceViewTagsProps) { deletePolicyTags(policyID, selectedTags, policyTags); setIsDeleteTagsConfirmModalVisible(false); - InteractionManager.runAfterInteractions(() => { + void InteractionManager.runAfterInteractions(() => { setSelectedTags([]); }); }; diff --git a/src/pages/workspace/taxes/WorkspaceTaxesPage.tsx b/src/pages/workspace/taxes/WorkspaceTaxesPage.tsx index 7e9d0d3d1ada..6e9fba24285d 100644 --- a/src/pages/workspace/taxes/WorkspaceTaxesPage.tsx +++ b/src/pages/workspace/taxes/WorkspaceTaxesPage.tsx @@ -246,7 +246,7 @@ function WorkspaceTaxesPage({ deletePolicyTaxes(policy, selectedTaxesIDs, localeCompare); setIsDeleteModalVisible(false); - InteractionManager.runAfterInteractions(() => { + void InteractionManager.runAfterInteractions(() => { setSelectedTaxesIDs([]); }); }, [policy, selectedTaxesIDs, localeCompare]); diff --git a/src/pages/workspace/upgrade/UpgradeConfirmation.tsx b/src/pages/workspace/upgrade/UpgradeConfirmation.tsx index 35563e701353..f268dea9e085 100644 --- a/src/pages/workspace/upgrade/UpgradeConfirmation.tsx +++ b/src/pages/workspace/upgrade/UpgradeConfirmation.tsx @@ -32,7 +32,7 @@ function UpgradeConfirmation({policyName, afterUpgradeAcknowledged, isReporting, }, [environmentURL]); useEffect(() => { - Navigation.isNavigationReady().then(() => updateSubscriptionLink()); + void Navigation.isNavigationReady().then(() => updateSubscriptionLink()); }, [updateSubscriptionLink]); const description = useMemo(() => { diff --git a/src/pages/workspace/workflows/WorkspaceWorkflowsPage.tsx b/src/pages/workspace/workflows/WorkspaceWorkflowsPage.tsx index c379c6ec3055..5cc708a3b9ec 100644 --- a/src/pages/workspace/workflows/WorkspaceWorkflowsPage.tsx +++ b/src/pages/workspace/workflows/WorkspaceWorkflowsPage.tsx @@ -142,7 +142,7 @@ function WorkspaceWorkflowsPage({policy, route}: WorkspaceWorkflowsPageProps) { const {isAccountLocked, showLockedAccountModal} = useContext(LockedAccountContext); useEffect(() => { - InteractionManager.runAfterInteractions(() => { + void InteractionManager.runAfterInteractions(() => { fetchData(); }); // eslint-disable-next-line react-compiler/react-compiler diff --git a/src/pages/workspace/workflows/approvals/WorkspaceWorkflowsApprovalsEditPage.tsx b/src/pages/workspace/workflows/approvals/WorkspaceWorkflowsApprovalsEditPage.tsx index d949409ff2a8..3defcd75a9b1 100644 --- a/src/pages/workspace/workflows/approvals/WorkspaceWorkflowsApprovalsEditPage.tsx +++ b/src/pages/workspace/workflows/approvals/WorkspaceWorkflowsApprovalsEditPage.tsx @@ -53,7 +53,7 @@ function WorkspaceWorkflowsApprovalsEditPage({policy, isLoadingReportData = true const membersToRemove = initialApprovalWorkflow.members.filter((initialMember) => !approvalWorkflow.members.some((member) => member.email === initialMember.email)); const approversToRemove = initialApprovalWorkflow.approvers.filter((initialApprover) => !approvalWorkflow.approvers.some((approver) => approver.email === initialApprover.email)); Navigation.dismissModal(); - InteractionManager.runAfterInteractions(() => { + void InteractionManager.runAfterInteractions(() => { updateApprovalWorkflow(route.params.policyID, approvalWorkflow, membersToRemove, approversToRemove); }); }, [approvalWorkflow, initialApprovalWorkflow, route.params.policyID]); @@ -65,7 +65,7 @@ function WorkspaceWorkflowsApprovalsEditPage({policy, isLoadingReportData = true setIsDeleteModalVisible(false); Navigation.dismissModal(); - InteractionManager.runAfterInteractions(() => { + void InteractionManager.runAfterInteractions(() => { // Remove the approval workflow using the initial data as it could be already edited removeApprovalWorkflow(route.params.policyID, initialApprovalWorkflow); }); diff --git a/src/stories/EReceipt.stories.tsx b/src/stories/EReceipt.stories.tsx index 1bbd39e1fda8..3e939cc63052 100644 --- a/src/stories/EReceipt.stories.tsx +++ b/src/stories/EReceipt.stories.tsx @@ -153,8 +153,8 @@ const transactionData = { }, } as CollectionDataSet; -Onyx.mergeCollection(ONYXKEYS.COLLECTION.TRANSACTION, transactionData); -Onyx.merge('cardList', { +void Onyx.mergeCollection(ONYXKEYS.COLLECTION.TRANSACTION, transactionData); +void Onyx.merge('cardList', { 4: {bank: 'Expensify Card', lastFourPAN: '1000'}, 5: {bank: 'Expensify Card', lastFourPAN: '4444'}, }); diff --git a/tests/actions/AppTest.ts b/tests/actions/AppTest.ts index c611df934800..9863ca14b93e 100644 --- a/tests/actions/AppTest.ts +++ b/tests/actions/AppTest.ts @@ -72,7 +72,7 @@ describe('actions/App', () => { expect(await getOnyxValue(ONYXKEYS.LAST_FULL_RECONNECT_TIME)).toBeTruthy(); // And when a new reconnectAppIfFullReconnectBefore is received - Onyx.set(ONYXKEYS.NVP_RECONNECT_APP_IF_FULL_RECONNECT_BEFORE, DateUtils.getDBTime()); + void Onyx.set(ONYXKEYS.NVP_RECONNECT_APP_IF_FULL_RECONNECT_BEFORE, DateUtils.getDBTime()); await waitForBatchedUpdates(); // Then ReconnectApp should get called with no updateIDFrom to perform a full reconnect @@ -94,7 +94,7 @@ describe('actions/App', () => { // And when a reconnectAppIfFullReconnectBefore is received with a timestamp in the past const yesterday = new Date(); yesterday.setDate(yesterday.getDate() - 1); - Onyx.set(ONYXKEYS.NVP_RECONNECT_APP_IF_FULL_RECONNECT_BEFORE, DateUtils.getDBTime(yesterday.toISOString())); + void Onyx.set(ONYXKEYS.NVP_RECONNECT_APP_IF_FULL_RECONNECT_BEFORE, DateUtils.getDBTime(yesterday.toISOString())); await waitForBatchedUpdates(); // Then ReconnectApp should NOT get called diff --git a/tests/actions/IOUTest.ts b/tests/actions/IOUTest.ts index 44dcaa4fe06d..7ce788a32d7b 100644 --- a/tests/actions/IOUTest.ts +++ b/tests/actions/IOUTest.ts @@ -266,7 +266,7 @@ describe('actions/IOU', () => { // When the transaction is saved to draft before being submitted await Onyx.set(`${ONYXKEYS.COLLECTION.TRANSACTION_DRAFT}${fakeTransaction.transactionID}`, fakeTransaction); - mockFetch?.pause?.(); + void mockFetch?.pause?.(); // When the user submits the transaction to the selfDM report trackExpense({ @@ -478,7 +478,7 @@ describe('actions/IOU', () => { const linkedTrackedExpenseReportAction = Object.values(selfDMReportActionsOnyx ?? {}).find((reportAction) => isMoneyRequestAction(reportAction)); const reportActionableTrackExpense = Object.values(selfDMReportActionsOnyx ?? {}).find((reportAction) => isActionableTrackExpense(reportAction)); - mockFetch?.pause?.(); + void mockFetch?.pause?.(); // Share the tracked expense with an accountant trackExpense({ @@ -598,7 +598,7 @@ describe('actions/IOU', () => { const linkedTrackedExpenseReportAction = Object.values(selfDMReportActionsOnyx ?? {}).find((reportAction) => isMoneyRequestAction(reportAction)); const reportActionableTrackExpense = Object.values(selfDMReportActionsOnyx ?? {}).find((reportAction) => isActionableTrackExpense(reportAction)); - mockFetch?.pause?.(); + void mockFetch?.pause?.(); // Share the tracked expense with an accountant trackExpense({ @@ -671,7 +671,7 @@ describe('actions/IOU', () => { let transactionID: string | undefined; let transactionThread: OnyxEntry; let transactionThreadCreatedAction: OnyxEntry; - mockFetch?.pause?.(); + void mockFetch?.pause?.(); requestMoney({ report: {reportID: ''}, participantParams: { @@ -911,12 +911,13 @@ describe('actions/IOU', () => { let iouAction: OnyxEntry>; let iouCreatedAction: OnyxEntry; let transactionID: string | undefined; - mockFetch?.pause?.(); + void mockFetch?.pause?.(); return Onyx.set(`${ONYXKEYS.COLLECTION.REPORT}${chatReport.reportID}`, chatReport) - .then(() => - Onyx.set(`${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${chatReport.reportID}`, { - [createdAction.reportActionID]: createdAction, - }), + .then( + () => + void Onyx.set(`${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${chatReport.reportID}`, { + [createdAction.reportActionID]: createdAction, + }), ) .then(() => { requestMoney({ @@ -1127,14 +1128,15 @@ describe('actions/IOU', () => { }; let newIOUAction: OnyxEntry>; let newTransaction: OnyxEntry; - mockFetch?.pause?.(); + void mockFetch?.pause?.(); return Onyx.set(`${ONYXKEYS.COLLECTION.REPORT}${chatReportID}`, chatReport) .then(() => Onyx.set(`${ONYXKEYS.COLLECTION.REPORT}${iouReportID}`, iouReport ?? null)) - .then(() => - Onyx.set(`${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${iouReportID}`, { - [createdAction.reportActionID]: createdAction, - [iouAction.reportActionID]: iouAction, - }), + .then( + () => + void Onyx.set(`${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${iouReportID}`, { + [createdAction.reportActionID]: createdAction, + [iouAction.reportActionID]: iouAction, + }), ) .then(() => Onyx.set(`${ONYXKEYS.COLLECTION.TRANSACTION}${existingTransaction.transactionID}`, existingTransaction)) .then(() => { @@ -1292,7 +1294,7 @@ describe('actions/IOU', () => { let transactionID: string | undefined; let transactionThreadReport: OnyxEntry; let transactionThreadAction: OnyxEntry; - mockFetch?.pause?.(); + void mockFetch?.pause?.(); requestMoney({ report: {reportID: ''}, participantParams: { @@ -1420,7 +1422,7 @@ describe('actions/IOU', () => { }), ) .then((): Promise => { - mockFetch?.fail?.(); + void mockFetch?.fail?.(); return mockFetch?.resume?.() as Promise; }) .then( @@ -1924,17 +1926,18 @@ describe('actions/IOU', () => { return Onyx.mergeCollection(ONYXKEYS.COLLECTION.REPORT, { ...reportCollectionDataSet, }) - .then(() => - Onyx.mergeCollection(ONYXKEYS.COLLECTION.REPORT_ACTIONS, { - ...carlosActionsCollectionDataSet, - ...julesCreatedActionsCollectionDataSet, - ...julesActionsCollectionDataSet, - }), + .then( + () => + void Onyx.mergeCollection(ONYXKEYS.COLLECTION.REPORT_ACTIONS, { + ...carlosActionsCollectionDataSet, + ...julesCreatedActionsCollectionDataSet, + ...julesActionsCollectionDataSet, + }), ) .then(() => Onyx.set(`${ONYXKEYS.COLLECTION.TRANSACTION}${julesExistingTransaction?.transactionID}`, julesExistingTransaction)) .then(() => { // When we split a bill offline - mockFetch?.pause?.(); + void mockFetch?.pause?.(); splitBill( // TODO: Migrate after the backend accepts accountIDs { @@ -2801,7 +2804,7 @@ describe('actions/IOU', () => { }), ) .then(() => { - mockFetch?.pause?.(); + void mockFetch?.pause?.(); if (chatReport && iouReport) { payMoneyRequest(CONST.IOU.PAYMENT_TYPE.ELSEWHERE, chatReport, iouReport); } @@ -2911,15 +2914,15 @@ describe('actions/IOU', () => { const merchant = 'NASDAQ'; afterEach(() => { - mockFetch?.resume?.(); + void mockFetch?.resume?.(); }); it('updates the expense request and expense report when paid while offline', () => { let expenseReport: OnyxEntry; let chatReport: OnyxEntry; - mockFetch?.pause?.(); - Onyx.set(ONYXKEYS.SESSION, {email: CARLOS_EMAIL, accountID: CARLOS_ACCOUNT_ID}); + void mockFetch?.pause?.(); + void Onyx.set(ONYXKEYS.SESSION, {email: CARLOS_EMAIL, accountID: CARLOS_ACCOUNT_ID}); return waitForBatchedUpdates() .then(() => { createWorkspace({ @@ -3052,7 +3055,7 @@ describe('actions/IOU', () => { let expenseReport: OnyxEntry; let chatReport: OnyxEntry; - Onyx.set(ONYXKEYS.SESSION, {email: CARLOS_EMAIL, accountID: CARLOS_ACCOUNT_ID}); + void Onyx.set(ONYXKEYS.SESSION, {email: CARLOS_EMAIL, accountID: CARLOS_ACCOUNT_ID}); return waitForBatchedUpdates() .then(() => { createWorkspace({ @@ -3115,7 +3118,7 @@ describe('actions/IOU', () => { }), ) .then(() => { - mockFetch?.fail?.(); + void mockFetch?.fail?.(); if (chatReport && expenseReport) { payMoneyRequest('ACH', chatReport, expenseReport, undefined); } @@ -3153,7 +3156,7 @@ describe('actions/IOU', () => { type: CONST.REPORT.TYPE.IOU, total: 10, }; - mockFetch?.pause?.(); + void mockFetch?.pause?.(); jest.advanceTimersByTime(10); @@ -3208,7 +3211,7 @@ describe('actions/IOU', () => { }); }); - mockFetch?.resume?.(); + void mockFetch?.resume?.(); }); it('calls notifyNewAction for the top most report', () => { @@ -3273,7 +3276,7 @@ describe('actions/IOU', () => { const merchant = 'NASDAQ'; afterEach(() => { - mockFetch?.resume?.(); + void mockFetch?.resume?.(); }); it("has an iouReportID of the cancelled payment's expense report", () => { @@ -3281,7 +3284,7 @@ describe('actions/IOU', () => { let chatReport: OnyxEntry; // Given a signed in account, which owns a workspace, and has a policy expense chat - Onyx.set(ONYXKEYS.SESSION, {email: CARLOS_EMAIL, accountID: CARLOS_ACCOUNT_ID}); + void Onyx.set(ONYXKEYS.SESSION, {email: CARLOS_EMAIL, accountID: CARLOS_ACCOUNT_ID}); return waitForBatchedUpdates() .then(() => { // Which owns a workspace @@ -3503,7 +3506,7 @@ describe('actions/IOU', () => { it('delete an expense (IOU Action and transaction) successfully', async () => { // Given the fetch operations are paused and an expense is initiated - mockFetch?.pause?.(); + void mockFetch?.pause?.(); if (transaction && createIOUAction) { // When the expense is deleted @@ -3545,7 +3548,7 @@ describe('actions/IOU', () => { expect(t?.pendingAction).toBe(CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE); // Given fetch operations are resumed - mockFetch?.resume?.(); + void mockFetch?.resume?.(); await waitForBatchedUpdates(); // Then we recheck the IOU report action from the report actions collection @@ -3582,7 +3585,7 @@ describe('actions/IOU', () => { it('delete the IOU report when there are no expenses left in the IOU report', async () => { // Given an IOU report and a paused fetch state - mockFetch?.pause?.(); + void mockFetch?.pause?.(); if (transaction && createIOUAction) { // When the IOU expense is deleted @@ -3605,7 +3608,7 @@ describe('actions/IOU', () => { expect(report).toBeTruthy(); // Given the resumed fetch state - mockFetch?.resume?.(); + void mockFetch?.resume?.(); await waitForBatchedUpdates(); report = await new Promise>((resolve) => { @@ -3646,7 +3649,7 @@ describe('actions/IOU', () => { await waitForBatchedUpdates(); // When we attempt to delete an expense from the IOU report - mockFetch?.pause?.(); + void mockFetch?.pause?.(); if (transaction && createIOUAction) { deleteMoneyRequest(transaction?.transactionID, createIOUAction, {}, {}); } @@ -3738,7 +3741,7 @@ describe('actions/IOU', () => { await waitForBatchedUpdates(); // Given Fetch is paused and timers have advanced - mockFetch?.pause?.(); + void mockFetch?.pause?.(); jest.advanceTimersByTime(10); if (transaction && createIOUAction) { @@ -3760,7 +3763,7 @@ describe('actions/IOU', () => { }); expect(report?.reportID).toBeFalsy(); - mockFetch?.resume?.(); + void mockFetch?.resume?.(); // Then After resuming fetch, the report for the given thread ID still does not exist report = await new Promise>((resolve) => { @@ -3938,7 +3941,7 @@ describe('actions/IOU', () => { const resultActionAfter = reportActionID ? reportActions?.[reportActionID] : undefined; expect(resultActionAfter?.pendingAction).toBeUndefined(); - mockFetch?.pause?.(); + void mockFetch?.pause?.(); if (transaction && createIOUAction) { // When deleting expense @@ -3961,7 +3964,7 @@ describe('actions/IOU', () => { // When fetch resumes // Then the transaction thread report should still exist - mockFetch?.resume?.(); + void mockFetch?.resume?.(); await new Promise((resolve) => { const connection = Onyx.connect({ key: `${ONYXKEYS.COLLECTION.REPORT}${thread.reportID}`, @@ -4090,7 +4093,7 @@ describe('actions/IOU', () => { // Verify that our action is no longer in the loading state expect(resultActionAfterUpdate?.pendingAction).toBeUndefined(); - mockFetch?.pause?.(); + void mockFetch?.pause?.(); if (transaction && createIOUAction) { // When we delete the expense deleteMoneyRequest(transaction.transactionID, createIOUAction, {}, {}); @@ -4115,7 +4118,7 @@ describe('actions/IOU', () => { }); // When we resume fetch - mockFetch?.resume?.(); + void mockFetch?.resume?.(); // Then we expect the moneyRequestPreview to show [Deleted expense] @@ -4182,7 +4185,7 @@ describe('actions/IOU', () => { expect(getReportActionText(iouPreview)).toBe('rory@expensifail.com owes $300.00'); // When we delete the first expense - mockFetch?.pause?.(); + void mockFetch?.pause?.(); jest.advanceTimersByTime(10); if (transaction && createIOUAction) { deleteMoneyRequest(transaction.transactionID, createIOUAction, {}, {}); @@ -4197,7 +4200,7 @@ describe('actions/IOU', () => { expect(iouReport?.total).toBe(20000); // When we resume - mockFetch?.resume?.(); + void mockFetch?.resume?.(); // Then we expect the IOU report and reportPreview to update with new totals expect(iouReport).toBeTruthy(); @@ -4257,7 +4260,7 @@ describe('actions/IOU', () => { expect(createIOUAction?.childReportID).toBe(thread.reportID); // When we delete the expense, we should not delete the IOU report - mockFetch?.pause?.(); + void mockFetch?.pause?.(); let navigateToAfterDelete; if (transaction && createIOUAction) { @@ -4387,7 +4390,7 @@ describe('actions/IOU', () => { callback: (allReports) => { Onyx.disconnect(connection); expenseReport = Object.values(allReports ?? {}).find((report) => report?.type === CONST.REPORT.TYPE.EXPENSE); - Onyx.merge(`report_${expenseReport?.reportID}`, { + void Onyx.merge(`report_${expenseReport?.reportID}`, { statusNum: 0, stateNum: 0, }); @@ -4519,7 +4522,7 @@ describe('actions/IOU', () => { Onyx.disconnect(connection); expenseReport = Object.values(allReports ?? {}).find((report) => report?.type === CONST.REPORT.TYPE.EXPENSE); - Onyx.merge(`report_${expenseReport?.reportID}`, { + void Onyx.merge(`report_${expenseReport?.reportID}`, { statusNum: 0, stateNum: 0, }); @@ -4692,7 +4695,7 @@ describe('actions/IOU', () => { Onyx.disconnect(connection); expenseReport = Object.values(allReports ?? {}).find((report) => report?.type === CONST.REPORT.TYPE.EXPENSE); - Onyx.merge(`report_${expenseReport?.reportID}`, { + void Onyx.merge(`report_${expenseReport?.reportID}`, { statusNum: 0, stateNum: 0, }); @@ -4725,7 +4728,7 @@ describe('actions/IOU', () => { }), ) .then(() => { - mockFetch?.fail?.(); + void mockFetch?.fail?.(); if (expenseReport) { submitReport(expenseReport); } @@ -5049,8 +5052,8 @@ describe('actions/IOU', () => { return waitForBatchedUpdates(); }) .then(() => { - mockFetch.fail(); - mockFetch?.resume?.(); + void mockFetch.fail(); + void mockFetch?.resume?.(); unholdRequest(transaction.transactionID, transactionThread.reportID); return waitForBatchedUpdates(); }) @@ -5105,12 +5108,12 @@ describe('actions/IOU', () => { it('should not clear transaction pending action when send invoice fails', async () => { // Given a send invoice request - mockFetch?.pause?.(); + void mockFetch?.pause?.(); sendInvoice(1, createRandomTransaction(1)); // When the request fails - mockFetch?.fail?.(); - mockFetch?.resume?.(); + void mockFetch?.fail?.(); + void mockFetch?.resume?.(); await waitForBatchedUpdates(); // Then the pending action of the optimistic transaction shouldn't be cleared @@ -5877,7 +5880,7 @@ describe('actions/IOU', () => { const fakeTransaction: Transaction = { ...createRandomTransaction(1), }; - Onyx.multiSet({ + void Onyx.multiSet({ [ONYXKEYS.COLLECTION.REPORT]: fakeReport, [ONYXKEYS.COLLECTION.TRANSACTION]: fakeTransaction, }); @@ -6160,7 +6163,7 @@ describe('actions/IOU', () => { await Onyx.set(`${ONYXKEYS.COLLECTION.TRANSACTION}${fakeTransaction.transactionID}`, fakeTransaction); - mockFetch?.pause?.(); + void mockFetch?.pause?.(); updateMoneyRequestAmountAndCurrency({ transactionID: fakeTransaction.transactionID, @@ -6185,7 +6188,7 @@ describe('actions/IOU', () => { }); await waitForBatchedUpdates(); - mockFetch?.succeed?.(); + void mockFetch?.succeed?.(); await mockFetch?.resume?.(); const updatedTransaction = await new Promise>((resolve) => { @@ -6220,7 +6223,7 @@ describe('actions/IOU', () => { await Onyx.set(`${ONYXKEYS.COLLECTION.TRANSACTION}${fakeTransaction.transactionID}`, fakeTransaction); - mockFetch?.pause?.(); + void mockFetch?.pause?.(); updateMoneyRequestAmountAndCurrency({ transactionID: fakeTransaction.transactionID, @@ -6245,7 +6248,7 @@ describe('actions/IOU', () => { }); await waitForBatchedUpdates(); - mockFetch?.fail?.(); + void mockFetch?.fail?.(); await mockFetch?.resume?.(); const updatedTransaction = await new Promise>((resolve) => { @@ -6269,7 +6272,7 @@ describe('actions/IOU', () => { const merchant = 'NASDAQ'; afterEach(() => { - mockFetch?.resume?.(); + void mockFetch?.resume?.(); }); it('pendingAction is not null after canceling the payment failed', async () => { @@ -6277,7 +6280,7 @@ describe('actions/IOU', () => { let chatReport: OnyxEntry; // Given a signed in account, which owns a workspace, and has a policy expense chat - Onyx.set(ONYXKEYS.SESSION, {email: CARLOS_EMAIL, accountID: CARLOS_ACCOUNT_ID}); + void Onyx.set(ONYXKEYS.SESSION, {email: CARLOS_EMAIL, accountID: CARLOS_ACCOUNT_ID}); // Which owns a workspace await waitForBatchedUpdates(); createWorkspace({ @@ -6328,13 +6331,13 @@ describe('actions/IOU', () => { }); if (chatReport && expenseReport) { - mockFetch?.pause?.(); + void mockFetch?.pause?.(); // And when the payment is cancelled cancelPayment(expenseReport, chatReport); } await waitForBatchedUpdates(); - mockFetch?.fail?.(); + void mockFetch?.fail?.(); await mockFetch?.resume?.(); @@ -6354,7 +6357,7 @@ describe('actions/IOU', () => { const merchant = 'NASDAQ'; afterEach(() => { - mockFetch?.resume?.(); + void mockFetch?.resume?.(); }); it('pendingAction is not null after paying the money request', async () => { @@ -6362,7 +6365,7 @@ describe('actions/IOU', () => { let chatReport: OnyxEntry; // Given a signed in account, which owns a workspace, and has a policy expense chat - Onyx.set(ONYXKEYS.SESSION, {email: CARLOS_EMAIL, accountID: CARLOS_ACCOUNT_ID}); + void Onyx.set(ONYXKEYS.SESSION, {email: CARLOS_EMAIL, accountID: CARLOS_ACCOUNT_ID}); // Which owns a workspace await waitForBatchedUpdates(); createWorkspace({ @@ -6414,12 +6417,12 @@ describe('actions/IOU', () => { // When the expense report is paid elsewhere (but really, any payment option would work) if (chatReport && expenseReport) { - mockFetch?.pause?.(); + void mockFetch?.pause?.(); payMoneyRequest(CONST.IOU.PAYMENT_TYPE.ELSEWHERE, chatReport, expenseReport); } await waitForBatchedUpdates(); - mockFetch?.fail?.(); + void mockFetch?.fail?.(); await mockFetch?.resume?.(); @@ -6717,7 +6720,7 @@ describe('actions/IOU', () => { let transaction: OnyxEntry; // Given a signed in account, which owns a workspace, and has a policy expense chat - Onyx.set(ONYXKEYS.SESSION, {email: CARLOS_EMAIL, accountID: CARLOS_ACCOUNT_ID}); + void Onyx.set(ONYXKEYS.SESSION, {email: CARLOS_EMAIL, accountID: CARLOS_ACCOUNT_ID}); const creatorPersonalDetails = personalDetailsList?.[CARLOS_ACCOUNT_ID] ?? {accountID: CARLOS_ACCOUNT_ID}; const policyID = generatePolicyID(); @@ -7130,9 +7133,9 @@ describe('actions/IOU', () => { if (options?.optimisticData) { options.optimisticData.forEach((update) => { if (update.onyxMethod === Onyx.METHOD.MERGE) { - Onyx.merge(update.key, update.value); + void Onyx.merge(update.key, update.value); } else if (update.onyxMethod === Onyx.METHOD.SET) { - Onyx.set(update.key, update.value); + void Onyx.set(update.key, update.value); } }); } @@ -7396,9 +7399,9 @@ describe('actions/IOU', () => { if (options?.optimisticData) { options.optimisticData.forEach((update) => { if (update.onyxMethod === Onyx.METHOD.MERGE) { - Onyx.merge(update.key, update.value); + void Onyx.merge(update.key, update.value); } else if (update.onyxMethod === Onyx.METHOD.SET) { - Onyx.set(update.key, update.value); + void Onyx.set(update.key, update.value); } }); } diff --git a/tests/actions/MergeTransactionTest.ts b/tests/actions/MergeTransactionTest.ts index 8498a188b2f3..25a8c5a6ac39 100644 --- a/tests/actions/MergeTransactionTest.ts +++ b/tests/actions/MergeTransactionTest.ts @@ -82,7 +82,7 @@ describe('mergeTransactionRequest', () => { await Onyx.set(`${ONYXKEYS.COLLECTION.REPORT}${sourceExpenseReport.reportID}`, sourceExpenseReport); await Onyx.set(`${ONYXKEYS.COLLECTION.MERGE_TRANSACTION}${mergeTransactionID}`, mergeTransaction); - mockFetch?.pause?.(); + void mockFetch?.pause?.(); // When: The merge transaction request is initiated // This should immediately update the UI with optimistic values @@ -183,7 +183,7 @@ describe('mergeTransactionRequest', () => { const mockViolations = createMockViolations(); - mockFetch?.pause?.(); + void mockFetch?.pause?.(); // Set up initial state in Onyx await Onyx.set(`${ONYXKEYS.COLLECTION.TRANSACTION}${targetTransaction.transactionID}`, targetTransaction); @@ -195,7 +195,7 @@ describe('mergeTransactionRequest', () => { await waitForBatchedUpdates(); // When: The merge request is executed but the API will return an error - mockFetch?.fail?.(); + void mockFetch?.fail?.(); mergeTransactionRequest(mergeTransactionID, mergeTransaction, targetTransaction, sourceTransaction); @@ -278,7 +278,7 @@ describe('mergeTransactionRequest', () => { await Onyx.set(`${ONYXKEYS.COLLECTION.TRANSACTION_VIOLATIONS}${targetTransaction.transactionID}`, mockViolations); await Onyx.set(`${ONYXKEYS.COLLECTION.TRANSACTION_VIOLATIONS}${sourceTransaction.transactionID}`, mockViolations); - mockFetch?.pause?.(); + void mockFetch?.pause?.(); // When: The merge request is executed, which should handle violation updates // - Optimistically remove DUPLICATED_TRANSACTION violations since transactions are being merged @@ -348,7 +348,7 @@ describe('mergeTransactionRequest', () => { await Onyx.set(`${ONYXKEYS.COLLECTION.REPORT}${sourceReport.reportID}`, sourceReport); await Onyx.set(`${ONYXKEYS.COLLECTION.MERGE_TRANSACTION}${mergeTransactionID}`, mergeTransaction); - mockFetch?.pause?.(); + void mockFetch?.pause?.(); // When: The merge request is executed mergeTransactionRequest(mergeTransactionID, mergeTransaction, targetTransaction, sourceTransaction); diff --git a/tests/actions/PolicyCategoryTest.ts b/tests/actions/PolicyCategoryTest.ts index 351adaf8e982..3a2a521906b7 100644 --- a/tests/actions/PolicyCategoryTest.ts +++ b/tests/actions/PolicyCategoryTest.ts @@ -29,8 +29,8 @@ describe('actions/PolicyCategory', () => { const fakePolicy = createRandomPolicy(0); fakePolicy.requiresCategory = false; - mockFetch?.pause?.(); - Onyx.set(`${ONYXKEYS.COLLECTION.POLICY}${fakePolicy.id}`, fakePolicy); + void mockFetch?.pause?.(); + void Onyx.set(`${ONYXKEYS.COLLECTION.POLICY}${fakePolicy.id}`, fakePolicy); Category.setWorkspaceRequiresCategory(fakePolicy.id, true); await waitForBatchedUpdates(); await new Promise((resolve) => { @@ -68,9 +68,9 @@ describe('actions/PolicyCategory', () => { const fakePolicy = createRandomPolicy(0); const fakeCategories = createRandomPolicyCategories(3); const newCategoryName = 'New category'; - mockFetch?.pause?.(); - Onyx.set(`${ONYXKEYS.COLLECTION.POLICY}${fakePolicy.id}`, fakePolicy); - Onyx.set(`${ONYXKEYS.COLLECTION.POLICY_CATEGORIES}${fakePolicy.id}`, fakeCategories); + void mockFetch?.pause?.(); + void Onyx.set(`${ONYXKEYS.COLLECTION.POLICY}${fakePolicy.id}`, fakePolicy); + void Onyx.set(`${ONYXKEYS.COLLECTION.POLICY_CATEGORIES}${fakePolicy.id}`, fakeCategories); Category.createPolicyCategory(fakePolicy.id, newCategoryName); await waitForBatchedUpdates(); await new Promise((resolve) => { @@ -113,9 +113,9 @@ describe('actions/PolicyCategory', () => { const fakeCategories = createRandomPolicyCategories(3); const oldCategoryName = Object.keys(fakeCategories).at(0); const newCategoryName = 'Updated category'; - mockFetch?.pause?.(); - Onyx.set(`${ONYXKEYS.COLLECTION.POLICY}${fakePolicy.id}`, fakePolicy); - Onyx.set(`${ONYXKEYS.COLLECTION.POLICY_CATEGORIES}${fakePolicy.id}`, fakeCategories); + void mockFetch?.pause?.(); + void Onyx.set(`${ONYXKEYS.COLLECTION.POLICY}${fakePolicy.id}`, fakePolicy); + void Onyx.set(`${ONYXKEYS.COLLECTION.POLICY_CATEGORIES}${fakePolicy.id}`, fakeCategories); Category.renamePolicyCategory(fakePolicy.id, { oldName: oldCategoryName ?? '', newName: newCategoryName, @@ -166,9 +166,9 @@ describe('actions/PolicyCategory', () => { enabled: true, }, }; - mockFetch?.pause?.(); - Onyx.set(`${ONYXKEYS.COLLECTION.POLICY}${fakePolicy.id}`, fakePolicy); - Onyx.set(`${ONYXKEYS.COLLECTION.POLICY_CATEGORIES}${fakePolicy.id}`, fakeCategories); + void mockFetch?.pause?.(); + void Onyx.set(`${ONYXKEYS.COLLECTION.POLICY}${fakePolicy.id}`, fakePolicy); + void Onyx.set(`${ONYXKEYS.COLLECTION.POLICY_CATEGORIES}${fakePolicy.id}`, fakeCategories); Category.setWorkspaceCategoryEnabled(fakePolicy.id, categoriesToUpdate); await waitForBatchedUpdates(); await new Promise((resolve) => { @@ -211,9 +211,9 @@ describe('actions/PolicyCategory', () => { const fakeCategories = createRandomPolicyCategories(3); const categoryNameToDelete = Object.keys(fakeCategories).at(0) ?? ''; const categoriesToDelete = [categoryNameToDelete]; - mockFetch?.pause?.(); - Onyx.set(`${ONYXKEYS.COLLECTION.POLICY}${fakePolicy.id}`, fakePolicy); - Onyx.set(`${ONYXKEYS.COLLECTION.POLICY_CATEGORIES}${fakePolicy.id}`, fakeCategories); + void mockFetch?.pause?.(); + void Onyx.set(`${ONYXKEYS.COLLECTION.POLICY}${fakePolicy.id}`, fakePolicy); + void Onyx.set(`${ONYXKEYS.COLLECTION.POLICY_CATEGORIES}${fakePolicy.id}`, fakeCategories); Category.deleteWorkspaceCategories(fakePolicy.id, categoriesToDelete); await waitForBatchedUpdates(); await new Promise((resolve) => { diff --git a/tests/actions/PolicyMemberTest.ts b/tests/actions/PolicyMemberTest.ts index 92f4fe6e2fec..4ed90c2b4fad 100644 --- a/tests/actions/PolicyMemberTest.ts +++ b/tests/actions/PolicyMemberTest.ts @@ -45,10 +45,10 @@ describe('actions/PolicyMember', () => { actionName: CONST.REPORT.ACTIONS.TYPE.ACTIONABLE_JOIN_REQUEST, } as ReportAction; - mockFetch?.pause?.(); - Onyx.set(`${ONYXKEYS.COLLECTION.POLICY}${fakePolicy.id}`, fakePolicy); - Onyx.set(`${ONYXKEYS.COLLECTION.REPORT}${fakeReport.reportID}`, fakeReport); - Onyx.merge(`${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${fakeReport.reportID}`, { + void mockFetch?.pause?.(); + void Onyx.set(`${ONYXKEYS.COLLECTION.POLICY}${fakePolicy.id}`, fakePolicy); + void Onyx.set(`${ONYXKEYS.COLLECTION.REPORT}${fakeReport.reportID}`, fakeReport); + void Onyx.merge(`${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${fakeReport.reportID}`, { [fakeReportAction.reportActionID]: fakeReportAction, }); Member.acceptJoinRequest(fakeReport.reportID, fakeReportAction); @@ -104,10 +104,10 @@ describe('actions/PolicyMember', () => { }; const adminRoom: Report = {...createRandomReport(1), chatType: CONST.REPORT.CHAT_TYPE.POLICY_ADMINS, policyID: fakePolicy.id}; - mockFetch?.pause?.(); - Onyx.set(`${ONYXKEYS.COLLECTION.POLICY}${fakePolicy.id}`, fakePolicy); - Onyx.set(`${ONYXKEYS.COLLECTION.REPORT}${adminRoom.reportID}`, adminRoom); - Onyx.set(`${ONYXKEYS.PERSONAL_DETAILS_LIST}`, {[fakeUser2.accountID]: fakeUser2}); + void mockFetch?.pause?.(); + void Onyx.set(`${ONYXKEYS.COLLECTION.POLICY}${fakePolicy.id}`, fakePolicy); + void Onyx.set(`${ONYXKEYS.COLLECTION.REPORT}${adminRoom.reportID}`, adminRoom); + void Onyx.set(`${ONYXKEYS.PERSONAL_DETAILS_LIST}`, {[fakeUser2.accountID]: fakeUser2}); await waitForBatchedUpdates(); // When a user's role is set as admin on a policy Member.updateWorkspaceMembersRole(fakePolicy.id, [fakeUser2.accountID], CONST.POLICY.ROLE.ADMIN); @@ -187,9 +187,9 @@ describe('actions/PolicyMember', () => { const fakeEmail = 'fake@gmail.com'; const fakeAccountID = 1; - mockFetch?.pause?.(); - Onyx.set(`${ONYXKEYS.COLLECTION.POLICY}${fakePolicy.id}`, fakePolicy); - Onyx.merge(ONYXKEYS.SESSION, {email: fakeEmail, accountID: fakeAccountID}); + void mockFetch?.pause?.(); + void Onyx.set(`${ONYXKEYS.COLLECTION.POLICY}${fakePolicy.id}`, fakePolicy); + void Onyx.merge(ONYXKEYS.SESSION, {email: fakeEmail, accountID: fakeAccountID}); Member.requestWorkspaceOwnerChange(fakePolicy.id); await waitForBatchedUpdates(); await new Promise((resolve) => { @@ -238,9 +238,9 @@ describe('actions/PolicyMember', () => { }; const fakeAccountID = 1; - mockFetch?.pause?.(); - Onyx.set(`${ONYXKEYS.COLLECTION.POLICY}${fakePolicy.id}`, fakePolicy); - Onyx.merge(ONYXKEYS.SESSION, {email: fakeEmail, accountID: fakeAccountID}); + void mockFetch?.pause?.(); + void Onyx.set(`${ONYXKEYS.COLLECTION.POLICY}${fakePolicy.id}`, fakePolicy); + void Onyx.merge(ONYXKEYS.SESSION, {email: fakeEmail, accountID: fakeAccountID}); Policy.addBillingCardAndRequestPolicyOwnerChange(fakePolicy.id, fakeCard); await waitForBatchedUpdates(); await new Promise((resolve) => { @@ -286,7 +286,7 @@ describe('actions/PolicyMember', () => { approver: defaultApprover, }); - mockFetch?.pause?.(); + void mockFetch?.pause?.(); Member.addMembersToWorkspace({[newUserEmail]: 1234}, 'Welcome', policyID, [], CONST.POLICY.ROLE.USER, TestHelper.formatPhoneNumber); await waitForBatchedUpdates(); @@ -458,7 +458,7 @@ describe('actions/PolicyMember', () => { }); // When removing am admin, auditor, and user members - mockFetch?.pause?.(); + void mockFetch?.pause?.(); Member.removeMembers([adminAccountID, auditorAccountID, userAccountID], policyID); await waitForBatchedUpdates(); @@ -517,7 +517,7 @@ describe('actions/PolicyMember', () => { }); // When removing a member from the workspace - mockFetch?.pause?.(); + void mockFetch?.pause?.(); Member.removeMembers([userAccountID], policyID); await waitForBatchedUpdates(); diff --git a/tests/actions/PolicyProfileTest.ts b/tests/actions/PolicyProfileTest.ts index 7232ed33227f..870ad8f18d83 100644 --- a/tests/actions/PolicyProfileTest.ts +++ b/tests/actions/PolicyProfileTest.ts @@ -31,8 +31,8 @@ describe('actions/PolicyProfile', () => { const oldDescription = fakePolicy.description ?? ''; const newDescription = 'Updated description'; const parsedDescription = ReportUtils.getParsedComment(newDescription); - mockFetch?.pause?.(); - Onyx.set(`${ONYXKEYS.COLLECTION.POLICY}${fakePolicy.id}`, fakePolicy); + void mockFetch?.pause?.(); + void Onyx.set(`${ONYXKEYS.COLLECTION.POLICY}${fakePolicy.id}`, fakePolicy); Policy.updateWorkspaceDescription(fakePolicy.id, newDescription, oldDescription); await waitForBatchedUpdates(); await new Promise((resolve) => { diff --git a/tests/actions/PolicyTagTest.ts b/tests/actions/PolicyTagTest.ts index 0093cda73023..3587d6956c12 100644 --- a/tests/actions/PolicyTagTest.ts +++ b/tests/actions/PolicyTagTest.ts @@ -32,7 +32,7 @@ describe('actions/Policy', () => { const fakePolicy = createRandomPolicy(0); fakePolicy.requiresTag = false; - mockFetch?.pause?.(); + void mockFetch?.pause?.(); return Onyx.set(`${ONYXKEYS.COLLECTION.POLICY}${fakePolicy.id}`, fakePolicy) .then(() => { @@ -79,7 +79,7 @@ describe('actions/Policy', () => { const fakePolicy = createRandomPolicy(0); fakePolicy.requiresTag = true; - mockFetch?.pause?.(); + void mockFetch?.pause?.(); return Onyx.set(`${ONYXKEYS.COLLECTION.POLICY}${fakePolicy.id}`, fakePolicy) .then(() => { @@ -126,11 +126,11 @@ describe('actions/Policy', () => { const fakePolicy = createRandomPolicy(0); fakePolicy.requiresTag = true; - mockFetch?.pause?.(); + void mockFetch?.pause?.(); return Onyx.set(`${ONYXKEYS.COLLECTION.POLICY}${fakePolicy.id}`, fakePolicy) .then(() => { - mockFetch?.fail?.(); + void mockFetch?.fail?.(); setPolicyRequiresTag(fakePolicy.id, false); return waitForBatchedUpdates(); }) @@ -187,11 +187,11 @@ describe('actions/Policy', () => { const newTagListName = 'New tag list name'; const fakePolicyTags = createRandomPolicyTags(oldTagListName); - mockFetch?.pause?.(); + void mockFetch?.pause?.(); return Onyx.set(`${ONYXKEYS.COLLECTION.POLICY}${fakePolicy.id}`, fakePolicy) .then(() => { - Onyx.set(`${ONYXKEYS.COLLECTION.POLICY_TAGS}${fakePolicy.id}`, fakePolicyTags); + void Onyx.set(`${ONYXKEYS.COLLECTION.POLICY_TAGS}${fakePolicy.id}`, fakePolicyTags); }) .then(() => { renamePolicyTagList( @@ -253,14 +253,14 @@ describe('actions/Policy', () => { const newTagListName = 'New tag list name'; const fakePolicyTags = createRandomPolicyTags(oldTagListName); - mockFetch?.pause?.(); + void mockFetch?.pause?.(); return Onyx.set(`${ONYXKEYS.COLLECTION.POLICY}${fakePolicy.id}`, fakePolicy) .then(() => { - Onyx.set(`${ONYXKEYS.COLLECTION.POLICY_TAGS}${fakePolicy.id}`, fakePolicyTags); + void Onyx.set(`${ONYXKEYS.COLLECTION.POLICY_TAGS}${fakePolicy.id}`, fakePolicyTags); }) .then(() => { - mockFetch?.fail?.(); + void mockFetch?.fail?.(); renamePolicyTagList( fakePolicy.id, @@ -305,11 +305,11 @@ describe('actions/Policy', () => { const newTagName = 'new tag'; const fakePolicyTags = createRandomPolicyTags(tagListName); - mockFetch?.pause?.(); + void mockFetch?.pause?.(); return Onyx.set(`${ONYXKEYS.COLLECTION.POLICY}${fakePolicy.id}`, fakePolicy) .then(() => { - Onyx.set(`${ONYXKEYS.COLLECTION.POLICY_TAGS}${fakePolicy.id}`, fakePolicyTags); + void Onyx.set(`${ONYXKEYS.COLLECTION.POLICY_TAGS}${fakePolicy.id}`, fakePolicyTags); }) .then(() => { createPolicyTag(fakePolicy.id, newTagName); @@ -365,14 +365,14 @@ describe('actions/Policy', () => { const newTagName = 'new tag'; const fakePolicyTags = createRandomPolicyTags(tagListName); - mockFetch?.pause?.(); + void mockFetch?.pause?.(); return Onyx.set(`${ONYXKEYS.COLLECTION.POLICY}${fakePolicy.id}`, fakePolicy) .then(() => { - Onyx.set(`${ONYXKEYS.COLLECTION.POLICY_TAGS}${fakePolicy.id}`, fakePolicyTags); + void Onyx.set(`${ONYXKEYS.COLLECTION.POLICY_TAGS}${fakePolicy.id}`, fakePolicyTags); }) .then(() => { - mockFetch?.fail?.(); + void mockFetch?.fail?.(); createPolicyTag(fakePolicy.id, newTagName); return waitForBatchedUpdates(); @@ -414,11 +414,11 @@ describe('actions/Policy', () => { return acc; }, {}); - mockFetch?.pause?.(); + void mockFetch?.pause?.(); return Onyx.set(`${ONYXKEYS.COLLECTION.POLICY}${fakePolicy.id}`, fakePolicy) .then(() => { - Onyx.set(`${ONYXKEYS.COLLECTION.POLICY_TAGS}${fakePolicy.id}`, fakePolicyTags); + void Onyx.set(`${ONYXKEYS.COLLECTION.POLICY_TAGS}${fakePolicy.id}`, fakePolicyTags); }) .then(() => { setWorkspaceTagEnabled(fakePolicy.id, tagsToUpdate, 0); @@ -485,14 +485,14 @@ describe('actions/Policy', () => { return acc; }, {}); - mockFetch?.pause?.(); + void mockFetch?.pause?.(); return Onyx.set(`${ONYXKEYS.COLLECTION.POLICY}${fakePolicy.id}`, fakePolicy) .then(() => { - Onyx.set(`${ONYXKEYS.COLLECTION.POLICY_TAGS}${fakePolicy.id}`, fakePolicyTags); + void Onyx.set(`${ONYXKEYS.COLLECTION.POLICY_TAGS}${fakePolicy.id}`, fakePolicyTags); }) .then(() => { - mockFetch?.fail?.(); + void mockFetch?.fail?.(); setWorkspaceTagEnabled(fakePolicy.id, tagsToUpdate, 0); return waitForBatchedUpdates(); @@ -533,11 +533,11 @@ describe('actions/Policy', () => { const oldTagName = Object.keys(fakePolicyTags?.[tagListName]?.tags).at(0); const newTagName = 'New tag'; - mockFetch?.pause?.(); + void mockFetch?.pause?.(); return Onyx.set(`${ONYXKEYS.COLLECTION.POLICY}${fakePolicy.id}`, fakePolicy) .then(() => { - Onyx.set(`${ONYXKEYS.COLLECTION.POLICY_TAGS}${fakePolicy.id}`, fakePolicyTags); + void Onyx.set(`${ONYXKEYS.COLLECTION.POLICY_TAGS}${fakePolicy.id}`, fakePolicyTags); }) .then(() => { renamePolicyTag( @@ -601,14 +601,14 @@ describe('actions/Policy', () => { const oldTagName = Object.keys(fakePolicyTags?.[tagListName]?.tags).at(0) ?? ''; const newTagName = 'New tag'; - mockFetch?.pause?.(); + void mockFetch?.pause?.(); return Onyx.set(`${ONYXKEYS.COLLECTION.POLICY}${fakePolicy.id}`, fakePolicy) .then(() => { - Onyx.set(`${ONYXKEYS.COLLECTION.POLICY_TAGS}${fakePolicy.id}`, fakePolicyTags); + void Onyx.set(`${ONYXKEYS.COLLECTION.POLICY_TAGS}${fakePolicy.id}`, fakePolicyTags); }) .then(() => { - mockFetch?.fail?.(); + void mockFetch?.fail?.(); renamePolicyTag( fakePolicy.id, @@ -655,7 +655,7 @@ describe('actions/Policy', () => { orderWeight: 1, }; - mockFetch?.pause?.(); + void mockFetch?.pause?.(); const emptyPolicyTags = {}; const tagsToDelete = ['tag1', 'tag2']; @@ -694,7 +694,7 @@ describe('actions/Policy', () => { const tagsToDelete = ['NonExistentTag1', 'NonExistentTag2', 'NonExistentTag3']; - mockFetch?.pause?.(); + void mockFetch?.pause?.(); await Onyx.set(`${ONYXKEYS.COLLECTION.POLICY_TAGS}${fakePolicy.id}`, existingPolicyTags); @@ -725,7 +725,7 @@ describe('actions/Policy', () => { const fakePolicyTags = createRandomPolicyTags(tagListName, 2); const tagsToDelete = Object.keys(fakePolicyTags?.[tagListName]?.tags ?? {}); - mockFetch?.pause?.(); + void mockFetch?.pause?.(); await Onyx.set(`${ONYXKEYS.COLLECTION.POLICY}${fakePolicy.id}`, fakePolicy); await Onyx.set(`${ONYXKEYS.COLLECTION.POLICY_TAGS}${fakePolicy.id}`, fakePolicyTags); @@ -766,12 +766,12 @@ describe('actions/Policy', () => { const fakePolicyTags = createRandomPolicyTags(tagListName, 2); const tagsToDelete = Object.keys(fakePolicyTags?.[tagListName]?.tags ?? {}); - mockFetch?.pause?.(); + void mockFetch?.pause?.(); await Onyx.set(`${ONYXKEYS.COLLECTION.POLICY}${fakePolicy.id}`, fakePolicy); await Onyx.set(`${ONYXKEYS.COLLECTION.POLICY_TAGS}${fakePolicy.id}`, fakePolicyTags); - mockFetch?.fail?.(); + void mockFetch?.fail?.(); deletePolicyTags(fakePolicy.id, tagsToDelete, fakePolicyTags); await waitForBatchedUpdates(); diff --git a/tests/actions/PolicyTaxTest.ts b/tests/actions/PolicyTaxTest.ts index 198b5896eb3a..e15bd8de8879 100644 --- a/tests/actions/PolicyTaxTest.ts +++ b/tests/actions/PolicyTaxTest.ts @@ -51,7 +51,7 @@ describe('actions/PolicyTax', () => { describe('SetPolicyCustomTaxName', () => { it('Set policy`s custom tax name', () => { const customTaxName = 'Custom tag name'; - mockFetch?.pause?.(); + void mockFetch?.pause?.(); Policy.setPolicyCustomTaxName(fakePolicy.id, customTaxName); return waitForBatchedUpdates() .then( @@ -92,7 +92,7 @@ describe('actions/PolicyTax', () => { const customTaxName = 'Custom tag name'; const originalCustomTaxName = fakePolicy?.taxRates?.name; - mockFetch?.pause?.(); + void mockFetch?.pause?.(); Policy.setPolicyCustomTaxName(fakePolicy.id, customTaxName); return waitForBatchedUpdates() .then( @@ -112,7 +112,7 @@ describe('actions/PolicyTax', () => { }), ) .then(() => { - mockFetch?.fail?.(); + void mockFetch?.fail?.(); return mockFetch?.resume?.() as Promise; }) .then(waitForBatchedUpdates) @@ -139,7 +139,7 @@ describe('actions/PolicyTax', () => { it('Set policy`s currency default tax', () => { const taxCode = 'id_TAX_RATE_1'; - mockFetch?.pause?.(); + void mockFetch?.pause?.(); Policy.setWorkspaceCurrencyDefault(fakePolicy.id, taxCode); return waitForBatchedUpdates() .then( @@ -180,7 +180,7 @@ describe('actions/PolicyTax', () => { const taxCode = 'id_TAX_RATE_1'; const originalDefaultExternalID = fakePolicy?.taxRates?.defaultExternalID; - mockFetch?.pause?.(); + void mockFetch?.pause?.(); Policy.setWorkspaceCurrencyDefault(fakePolicy.id, taxCode); return waitForBatchedUpdates() .then( @@ -200,7 +200,7 @@ describe('actions/PolicyTax', () => { }), ) .then(() => { - mockFetch?.fail?.(); + void mockFetch?.fail?.(); return mockFetch?.resume?.() as Promise; }) .then(waitForBatchedUpdates) @@ -226,7 +226,7 @@ describe('actions/PolicyTax', () => { it('Set policy`s foreign currency default', () => { const taxCode = 'id_TAX_RATE_1'; - mockFetch?.pause?.(); + void mockFetch?.pause?.(); Policy.setForeignCurrencyDefault(fakePolicy.id, taxCode); return waitForBatchedUpdates() .then( @@ -268,7 +268,7 @@ describe('actions/PolicyTax', () => { const taxCode = 'id_TAX_RATE_1'; const originalDefaultForeignCurrencyID = fakePolicy?.taxRates?.foreignTaxDefault; - mockFetch?.pause?.(); + void mockFetch?.pause?.(); Policy.setForeignCurrencyDefault(fakePolicy.id, taxCode); return waitForBatchedUpdates() .then( @@ -289,7 +289,7 @@ describe('actions/PolicyTax', () => { ) .then(() => { - mockFetch?.fail?.(); + void mockFetch?.fail?.(); return mockFetch?.resume?.() as Promise; }) .then(waitForBatchedUpdates) @@ -320,7 +320,7 @@ describe('actions/PolicyTax', () => { code: 'id_TAX_RATE_2', }; - mockFetch?.pause?.(); + void mockFetch?.pause?.(); createPolicyTax(fakePolicy.id, newTaxRate); return waitForBatchedUpdates() .then( @@ -368,7 +368,7 @@ describe('actions/PolicyTax', () => { code: 'id_TAX_RATE_2', }; - mockFetch?.pause?.(); + void mockFetch?.pause?.(); createPolicyTax(fakePolicy.id, newTaxRate); return waitForBatchedUpdates() .then( @@ -390,7 +390,7 @@ describe('actions/PolicyTax', () => { }), ) .then(() => { - mockFetch?.fail?.(); + void mockFetch?.fail?.(); return mockFetch?.resume?.() as Promise; }) .then(waitForBatchedUpdates) @@ -414,7 +414,7 @@ describe('actions/PolicyTax', () => { describe('SetPolicyTaxesEnabled', () => { it('Disable policy`s taxes', () => { const disableTaxID = 'id_TAX_RATE_1'; - mockFetch?.pause?.(); + void mockFetch?.pause?.(); setPolicyTaxesEnabled(fakePolicy, [disableTaxID], false); return waitForBatchedUpdates() .then( @@ -457,7 +457,7 @@ describe('actions/PolicyTax', () => { it('Disable policy`s taxes but API returns an error, then enable policy`s taxes again', () => { const disableTaxID = 'id_TAX_RATE_1'; - mockFetch?.pause?.(); + void mockFetch?.pause?.(); setPolicyTaxesEnabled(fakePolicy, [disableTaxID], false); const originalTaxes = {...fakePolicy?.taxRates?.taxes}; return waitForBatchedUpdates() @@ -480,7 +480,7 @@ describe('actions/PolicyTax', () => { }), ) .then(() => { - mockFetch?.fail?.(); + void mockFetch?.fail?.(); return mockFetch?.resume?.() as Promise; }) .then(waitForBatchedUpdates) @@ -508,7 +508,7 @@ describe('actions/PolicyTax', () => { it('Rename tax', () => { const taxID = 'id_TAX_RATE_1'; const newTaxName = 'Tax rate 1 updated'; - mockFetch?.pause?.(); + void mockFetch?.pause?.(); // @ts-expect-error - we can send undefined tax rate here for testing renamePolicyTax(fakePolicy.id, taxID, newTaxName, fakePolicy?.taxRates?.taxes[taxID]); return waitForBatchedUpdates() @@ -554,7 +554,7 @@ describe('actions/PolicyTax', () => { const taxID = 'id_TAX_RATE_1'; const newTaxName = 'Tax rate 1 updated'; const originalTaxRate = {...fakePolicy?.taxRates?.taxes[taxID]}; - mockFetch?.pause?.(); + void mockFetch?.pause?.(); // @ts-expect-error - we can send undefined tax rate here for testing renamePolicyTax(fakePolicy.id, taxID, newTaxName, fakePolicy?.taxRates?.taxes[taxID]); return waitForBatchedUpdates() @@ -577,7 +577,7 @@ describe('actions/PolicyTax', () => { }), ) .then(() => { - mockFetch?.fail?.(); + void mockFetch?.fail?.(); return mockFetch?.resume?.() as Promise; }) .then(waitForBatchedUpdates) @@ -605,7 +605,7 @@ describe('actions/PolicyTax', () => { const taxID = 'id_TAX_RATE_1'; const newTaxValue = 10; const stringTaxValue = `${newTaxValue}%`; - mockFetch?.pause?.(); + void mockFetch?.pause?.(); // @ts-expect-error - we can send undefined tax rate here for testing updatePolicyTaxValue(fakePolicy.id, taxID, newTaxValue, fakePolicy?.taxRates?.taxes[taxID]); return waitForBatchedUpdates() @@ -652,7 +652,7 @@ describe('actions/PolicyTax', () => { const newTaxValue = 10; const originalTaxRate = {...fakePolicy?.taxRates?.taxes[taxID]}; const stringTaxValue = `${newTaxValue}%`; - mockFetch?.pause?.(); + void mockFetch?.pause?.(); // @ts-expect-error - we can send undefined tax rate here for testing updatePolicyTaxValue(fakePolicy.id, taxID, newTaxValue, fakePolicy?.taxRates?.taxes[taxID]); return waitForBatchedUpdates() @@ -675,7 +675,7 @@ describe('actions/PolicyTax', () => { }), ) .then(() => { - mockFetch?.fail?.(); + void mockFetch?.fail?.(); return mockFetch?.resume?.() as Promise; }) .then(waitForBatchedUpdates) @@ -703,7 +703,7 @@ describe('actions/PolicyTax', () => { const foreignTaxDefault = fakePolicy?.taxRates?.foreignTaxDefault; const taxID = 'id_TAX_RATE_1'; - mockFetch?.pause?.(); + void mockFetch?.pause?.(); deletePolicyTaxes(fakePolicy, [taxID], TestHelper.localeCompare); return waitForBatchedUpdates() .then( @@ -757,7 +757,7 @@ describe('actions/PolicyTax', () => { foreignTaxDefault: 'id_TAX_RATE_1', }, }; - mockFetch?.pause?.(); + void mockFetch?.pause?.(); deletePolicyTaxes(fakePolicyWithForeignTaxDefault, [taxID], TestHelper.localeCompare); return waitForBatchedUpdates() .then( @@ -804,7 +804,7 @@ describe('actions/PolicyTax', () => { const foreignTaxDefault = fakePolicy?.taxRates?.foreignTaxDefault; const taxID = 'id_TAX_RATE_1'; - mockFetch?.pause?.(); + void mockFetch?.pause?.(); deletePolicyTaxes(fakePolicy, [taxID], TestHelper.localeCompare); return waitForBatchedUpdates() .then( @@ -827,7 +827,7 @@ describe('actions/PolicyTax', () => { }), ) .then(() => { - mockFetch?.fail?.(); + void mockFetch?.fail?.(); return mockFetch?.resume?.() as Promise; }) .then(waitForBatchedUpdates) @@ -857,7 +857,7 @@ describe('actions/PolicyTax', () => { const oldTaxRateName = fakePolicy?.taxRates?.taxes[oldTaxCode]?.name; it('Set policy`s tax code', () => { - mockFetch?.pause?.(); + void mockFetch?.pause?.(); const distanceRateCustomUnit = fakePolicy?.customUnits?.[CONST.CUSTOM_UNITS.NAME_DISTANCE]; setPolicyTaxCode( diff --git a/tests/actions/PolicyTest.ts b/tests/actions/PolicyTest.ts index fc530e8be50d..d459e1b26949 100644 --- a/tests/actions/PolicyTest.ts +++ b/tests/actions/PolicyTest.ts @@ -44,7 +44,7 @@ describe('actions/Policy', () => { describe('createWorkspace', () => { afterEach(() => { - mockFetch?.resume?.(); + void mockFetch?.resume?.(); }); it('creates a new workspace', async () => { @@ -753,13 +753,13 @@ describe('actions/Policy', () => { describe('enablePolicyRules', () => { it('should disable preventSelfApproval when the rule feature is turned off', async () => { (fetch as MockFetch)?.pause?.(); - Onyx.set(ONYXKEYS.SESSION, {email: ESH_EMAIL, accountID: ESH_ACCOUNT_ID}); + void Onyx.set(ONYXKEYS.SESSION, {email: ESH_EMAIL, accountID: ESH_ACCOUNT_ID}); const fakePolicy: PolicyType = { ...createRandomPolicy(0, CONST.POLICY.TYPE.TEAM), areRulesEnabled: true, preventSelfApproval: true, }; - Onyx.set(`${ONYXKEYS.COLLECTION.POLICY}${fakePolicy.id}`, fakePolicy); + void Onyx.set(`${ONYXKEYS.COLLECTION.POLICY}${fakePolicy.id}`, fakePolicy); await waitForBatchedUpdates(); // Disable the rule feature @@ -816,7 +816,7 @@ describe('actions/Policy', () => { await Onyx.merge(ONYXKEYS.REIMBURSEMENT_ACCOUNT, fakeReimbursementAccount); // When deleting a workspace fails - mockFetch?.fail?.(); + void mockFetch?.fail?.(); Policy.deleteWorkspace(fakePolicy.id, fakePolicy.name, undefined, undefined); await waitForBatchedUpdates(); @@ -999,7 +999,7 @@ describe('actions/Policy', () => { describe('generateDefaultWorkspaceName', () => { beforeAll(() => { - Onyx.set(ONYXKEYS.COLLECTION.POLICY, {}); + void Onyx.set(ONYXKEYS.COLLECTION.POLICY, {}); }); it('should generate a workspace name based on the email domain when the domain is not public', () => { @@ -1105,14 +1105,14 @@ describe('actions/Policy', () => { describe('enablePolicyWorkflows', () => { it('should update delayed submission to instant when disabling the workflows feature', async () => { (fetch as MockFetch)?.pause?.(); - Onyx.set(ONYXKEYS.SESSION, {email: ESH_EMAIL, accountID: ESH_ACCOUNT_ID}); + void Onyx.set(ONYXKEYS.SESSION, {email: ESH_EMAIL, accountID: ESH_ACCOUNT_ID}); const fakePolicy: PolicyType = { ...createRandomPolicy(0, CONST.POLICY.TYPE.TEAM), areWorkflowsEnabled: true, autoReporting: true, autoReportingFrequency: CONST.POLICY.AUTO_REPORTING_FREQUENCIES.IMMEDIATE, }; - Onyx.set(`${ONYXKEYS.COLLECTION.POLICY}${fakePolicy.id}`, fakePolicy); + void Onyx.set(`${ONYXKEYS.COLLECTION.POLICY}${fakePolicy.id}`, fakePolicy); await waitForBatchedUpdates(); // Disable the workflow feature diff --git a/tests/actions/ReimbursementAccountTest.ts b/tests/actions/ReimbursementAccountTest.ts index 7e1a2cbda1f4..97096e38ea2d 100644 --- a/tests/actions/ReimbursementAccountTest.ts +++ b/tests/actions/ReimbursementAccountTest.ts @@ -30,7 +30,7 @@ describe('ReimbursementAccount', () => { }); describe('resetUSDBankAccount', () => { afterEach(() => { - mockFetch?.resume?.(); + void mockFetch?.resume?.(); }); it('should reset the USDBankAccount', async () => { diff --git a/tests/actions/ReportFieldTest.ts b/tests/actions/ReportFieldTest.ts index ecf3ae18a2ae..510a51ff4a7d 100644 --- a/tests/actions/ReportFieldTest.ts +++ b/tests/actions/ReportFieldTest.ts @@ -49,8 +49,8 @@ describe('actions/ReportField', () => { describe('createReportField', () => { it('creates a new text report field of a workspace', async () => { - mockFetch.pause(); - Onyx.set(ONYXKEYS.FORMS.WORKSPACE_REPORT_FIELDS_FORM_DRAFT, {}); + void mockFetch.pause(); + void Onyx.set(ONYXKEYS.FORMS.WORKSPACE_REPORT_FIELDS_FORM_DRAFT, {}); await waitForBatchedUpdates(); const policyID = Policy.generatePolicyID(); @@ -92,7 +92,7 @@ describe('actions/ReportField', () => { }); // Check for success data - mockFetch.resume(); + void mockFetch.resume(); await waitForBatchedUpdates(); policy = await connectToFetchPolicy(policyID); @@ -102,8 +102,8 @@ describe('actions/ReportField', () => { }); it('creates a new date report field of a workspace', async () => { - mockFetch.pause(); - Onyx.set(ONYXKEYS.FORMS.WORKSPACE_REPORT_FIELDS_FORM_DRAFT, {}); + void mockFetch.pause(); + void Onyx.set(ONYXKEYS.FORMS.WORKSPACE_REPORT_FIELDS_FORM_DRAFT, {}); await waitForBatchedUpdates(); const policyID = Policy.generatePolicyID(); @@ -146,7 +146,7 @@ describe('actions/ReportField', () => { }); // Check for success data - mockFetch.resume(); + void mockFetch.resume(); await waitForBatchedUpdates(); policy = await connectToFetchPolicy(policyID); @@ -156,8 +156,8 @@ describe('actions/ReportField', () => { }); it('creates a new list report field of a workspace', async () => { - mockFetch.pause(); - Onyx.set(ONYXKEYS.FORMS.WORKSPACE_REPORT_FIELDS_FORM_DRAFT, { + void mockFetch.pause(); + void Onyx.set(ONYXKEYS.FORMS.WORKSPACE_REPORT_FIELDS_FORM_DRAFT, { [INPUT_IDS.LIST_VALUES]: ['Value 1', 'Value 2'], [INPUT_IDS.DISABLED_LIST_VALUES]: [false, true], }); @@ -202,7 +202,7 @@ describe('actions/ReportField', () => { }); // Check for success data - mockFetch.resume(); + void mockFetch.resume(); await waitForBatchedUpdates(); policy = await connectToFetchPolicy(policyID); @@ -236,7 +236,7 @@ describe('actions/ReportField', () => { fakePolicy.fieldList = { [reportFieldKey]: fakeReportField, }; - Onyx.set(`${ONYXKEYS.COLLECTION.POLICY}${fakePolicy.id}`, fakePolicy); + void Onyx.set(`${ONYXKEYS.COLLECTION.POLICY}${fakePolicy.id}`, fakePolicy); await waitForBatchedUpdates(); let policy: OnyxEntry = await connectToFetchPolicy(fakePolicy.id); @@ -250,7 +250,7 @@ describe('actions/ReportField', () => { await waitForBatchedUpdates(); // Check for success data - mockFetch.resume(); + void mockFetch.resume(); await waitForBatchedUpdates(); policy = await connectToFetchPolicy(fakePolicy.id); @@ -282,7 +282,7 @@ describe('actions/ReportField', () => { fakePolicy.fieldList = { [reportFieldKey]: fakeReportField, }; - Onyx.set(`${ONYXKEYS.COLLECTION.POLICY}${policyID}`, fakePolicy); + void Onyx.set(`${ONYXKEYS.COLLECTION.POLICY}${policyID}`, fakePolicy); await waitForBatchedUpdates(); let policy: OnyxEntry = await connectToFetchPolicy(policyID); @@ -293,11 +293,11 @@ describe('actions/ReportField', () => { }); // Check for failure data - mockFetch.fail(); + void mockFetch.fail(); ReportField.deleteReportFields(policyID, [reportFieldKey]); await waitForBatchedUpdates(); - mockFetch.resume(); + void mockFetch.resume(); await waitForBatchedUpdates(); policy = await connectToFetchPolicy(policyID); @@ -311,7 +311,7 @@ describe('actions/ReportField', () => { describe('updateReportFieldInitialValue', () => { it('updates the initial value of a text report field', async () => { - mockFetch.pause(); + void mockFetch.pause(); const policyID = Policy.generatePolicyID(); const reportFieldName = 'Test Field'; @@ -334,7 +334,7 @@ describe('actions/ReportField', () => { }; const fakePolicy = createRandomPolicy(Number(policyID)); - Onyx.set(`${ONYXKEYS.COLLECTION.POLICY}${policyID}`, {...fakePolicy, fieldList: {[reportFieldKey]: reportField}}); + void Onyx.set(`${ONYXKEYS.COLLECTION.POLICY}${policyID}`, {...fakePolicy, fieldList: {[reportFieldKey]: reportField}}); await waitForBatchedUpdates(); ReportField.updateReportFieldInitialValue(policyID, reportFieldID, newInitialValue); @@ -352,7 +352,7 @@ describe('actions/ReportField', () => { }); // Check for success data - mockFetch.resume(); + void mockFetch.resume(); await waitForBatchedUpdates(); policy = await connectToFetchPolicy(policyID); @@ -362,7 +362,7 @@ describe('actions/ReportField', () => { }); it('updates the initial value of a text report field when api returns an error', async () => { - mockFetch.pause(); + void mockFetch.pause(); const policyID = Policy.generatePolicyID(); const reportFieldName = 'Test Field'; @@ -385,7 +385,7 @@ describe('actions/ReportField', () => { }; const fakePolicy = createRandomPolicy(Number(policyID)); - Onyx.set(`${ONYXKEYS.COLLECTION.POLICY}${policyID}`, {...fakePolicy, fieldList: {[reportFieldKey]: reportField}}); + void Onyx.set(`${ONYXKEYS.COLLECTION.POLICY}${policyID}`, {...fakePolicy, fieldList: {[reportFieldKey]: reportField}}); await waitForBatchedUpdates(); ReportField.updateReportFieldInitialValue(policyID, reportFieldID, newInitialValue); @@ -403,8 +403,8 @@ describe('actions/ReportField', () => { }); // Check for failure data - mockFetch.fail(); - mockFetch.resume(); + void mockFetch.fail(); + void mockFetch.resume(); await waitForBatchedUpdates(); policy = await connectToFetchPolicy(policyID); @@ -420,7 +420,7 @@ describe('actions/ReportField', () => { describe('updateReportFieldListValueEnabled', () => { it('updates the enabled flag of report field list values', async () => { - mockFetch.pause(); + void mockFetch.pause(); const policyID = Policy.generatePolicyID(); const reportFieldName = 'Test Field'; @@ -443,7 +443,7 @@ describe('actions/ReportField', () => { }; const fakePolicy = createRandomPolicy(Number(policyID)); - Onyx.set(`${ONYXKEYS.COLLECTION.POLICY}${policyID}`, {...fakePolicy, fieldList: {[reportFieldKey]: reportField}}); + void Onyx.set(`${ONYXKEYS.COLLECTION.POLICY}${policyID}`, {...fakePolicy, fieldList: {[reportFieldKey]: reportField}}); await waitForBatchedUpdates(); ReportField.updateReportFieldListValueEnabled(policyID, reportFieldID, valueIndexesTpUpdate, false); @@ -464,7 +464,7 @@ describe('actions/ReportField', () => { describe('addReportFieldListValue', () => { it('adds a new value to a report field list', async () => { - mockFetch.pause(); + void mockFetch.pause(); const policyID = Policy.generatePolicyID(); const reportFieldName = 'Test Field'; @@ -487,7 +487,7 @@ describe('actions/ReportField', () => { const fakePolicy = createRandomPolicy(Number(policyID)); const newListValueName = 'Value 4'; - Onyx.set(`${ONYXKEYS.COLLECTION.POLICY}${policyID}`, {...fakePolicy, fieldList: {[reportFieldKey]: reportField}}); + void Onyx.set(`${ONYXKEYS.COLLECTION.POLICY}${policyID}`, {...fakePolicy, fieldList: {[reportFieldKey]: reportField}}); await waitForBatchedUpdates(); ReportField.addReportFieldListValue(policyID, reportFieldID, newListValueName); @@ -507,7 +507,7 @@ describe('actions/ReportField', () => { describe('removeReportFieldListValue', () => { it('removes list values from a report field list', async () => { - mockFetch.pause(); + void mockFetch.pause(); const policyID = Policy.generatePolicyID(); const reportFieldName = 'Test Field'; @@ -529,7 +529,7 @@ describe('actions/ReportField', () => { }; const fakePolicy = createRandomPolicy(Number(policyID)); - Onyx.set(`${ONYXKEYS.COLLECTION.POLICY}${policyID}`, {...fakePolicy, fieldList: {[reportFieldKey]: reportField}}); + void Onyx.set(`${ONYXKEYS.COLLECTION.POLICY}${policyID}`, {...fakePolicy, fieldList: {[reportFieldKey]: reportField}}); await waitForBatchedUpdates(); ReportField.removeReportFieldListValue(policyID, reportFieldID, [1, 2]); diff --git a/tests/actions/ReportPreviewActionUtilsTest.ts b/tests/actions/ReportPreviewActionUtilsTest.ts index 394d2fee6775..724b634f1e27 100644 --- a/tests/actions/ReportPreviewActionUtilsTest.ts +++ b/tests/actions/ReportPreviewActionUtilsTest.ts @@ -55,7 +55,7 @@ describe('getReportPreviewAction', () => { }); beforeEach(async () => { - Onyx.clear(); + void Onyx.clear(); await Onyx.merge(ONYXKEYS.SESSION, SESSION); await Onyx.set(ONYXKEYS.PERSONAL_DETAILS_LIST, {[CURRENT_USER_ACCOUNT_ID]: PERSONAL_DETAILS}); }); diff --git a/tests/actions/ReportTest.ts b/tests/actions/ReportTest.ts index 9da644f57ed3..b99d4c848596 100644 --- a/tests/actions/ReportTest.ts +++ b/tests/actions/ReportTest.ts @@ -203,8 +203,8 @@ describe('actions/Report', () => { const REPORT: OnyxTypes.Report = {...createRandomReport(1), errorFields: {createChat: {error: 'error'}}}; const REPORT_METADATA: OnyxTypes.ReportMetadata = {isOptimisticReport: false}; - Onyx.set(`${ONYXKEYS.COLLECTION.REPORT}${REPORT.reportID}`, REPORT); - Onyx.set(`${ONYXKEYS.COLLECTION.REPORT_METADATA}${REPORT.reportID}`, REPORT_METADATA); + void Onyx.set(`${ONYXKEYS.COLLECTION.REPORT}${REPORT.reportID}`, REPORT); + void Onyx.set(`${ONYXKEYS.COLLECTION.REPORT_METADATA}${REPORT.reportID}`, REPORT_METADATA); return waitForBatchedUpdates() .then(() => { @@ -895,7 +895,7 @@ describe('actions/Report', () => { const TEN_MINUTES_AGO = subMinutes(new Date(), 10); const created = format(addSeconds(TEN_MINUTES_AGO, 10), CONST.DATE.FNS_DB_FORMAT_STRING); - Onyx.set(ONYXKEYS.NETWORK, {isOffline: true}); + void Onyx.set(ONYXKEYS.NETWORK, {isOffline: true}); Report.addComment(REPORT_ID, 'Testing a comment', CONST.DEFAULT_TIME_ZONE); // Need the reportActionID to delete the comments @@ -950,7 +950,7 @@ describe('actions/Report', () => { }, }); - Onyx.set(ONYXKEYS.NETWORK, {isOffline: false}); + void Onyx.set(ONYXKEYS.NETWORK, {isOffline: false}); await waitForBatchedUpdates(); // Checking no requests were or will be made @@ -998,7 +998,7 @@ describe('actions/Report', () => { await waitForBatchedUpdates(); expect(PersistedRequests.getAll().length).toBe(1); - Onyx.set(ONYXKEYS.NETWORK, {isOffline: false}); + void Onyx.set(ONYXKEYS.NETWORK, {isOffline: false}); await waitForBatchedUpdates(); // Checking no requests were or will be made @@ -1119,7 +1119,7 @@ describe('actions/Report', () => { }, }); - Onyx.set(ONYXKEYS.NETWORK, {isOffline: false}); + void Onyx.set(ONYXKEYS.NETWORK, {isOffline: false}); await waitForBatchedUpdates(); // Checking no requests were or will be made @@ -1188,7 +1188,7 @@ describe('actions/Report', () => { }, }); - Onyx.set(ONYXKEYS.NETWORK, {isOffline: false}); + void Onyx.set(ONYXKEYS.NETWORK, {isOffline: false}); await waitForBatchedUpdates(); // Checking no requests were or will be made @@ -1285,7 +1285,7 @@ describe('actions/Report', () => { }, }); - Onyx.set(ONYXKEYS.NETWORK, {isOffline: false}); + void Onyx.set(ONYXKEYS.NETWORK, {isOffline: false}); await waitForBatchedUpdates(); // Checking no requests were or will be made @@ -1358,7 +1358,7 @@ describe('actions/Report', () => { await waitForBatchedUpdates(); expect(PersistedRequests.getAll().length).toBe(1); - Onyx.set(ONYXKEYS.NETWORK, {isOffline: false}); + void Onyx.set(ONYXKEYS.NETWORK, {isOffline: false}); await waitForBatchedUpdates(); // Checking no requests were or will be made @@ -1418,7 +1418,7 @@ describe('actions/Report', () => { }); }); - Onyx.set(ONYXKEYS.NETWORK, {isOffline: false}); + void Onyx.set(ONYXKEYS.NETWORK, {isOffline: false}); await waitForBatchedUpdates(); // Checking no requests were or will be made @@ -1435,7 +1435,7 @@ describe('actions/Report', () => { const TEN_MINUTES_AGO = subMinutes(new Date(), 10); const created = format(addSeconds(TEN_MINUTES_AGO, 10), CONST.DATE.FNS_DB_FORMAT_STRING); - Onyx.set(ONYXKEYS.NETWORK, {isOffline: true}); + void Onyx.set(ONYXKEYS.NETWORK, {isOffline: true}); Report.addComment(REPORT_ID, 'Testing a comment', CONST.DEFAULT_TIME_ZONE); // Need the reportActionID to delete the comments @@ -1462,7 +1462,7 @@ describe('actions/Report', () => { await waitForBatchedUpdates(); expect(PersistedRequests.getAll().length).toBe(1); - Onyx.set(ONYXKEYS.NETWORK, {isOffline: false}); + void Onyx.set(ONYXKEYS.NETWORK, {isOffline: false}); await waitForBatchedUpdates(); // Checking no requests were or will be made @@ -1560,7 +1560,7 @@ describe('actions/Report', () => { }; await Onyx.merge(`${ONYXKEYS.COLLECTION.POLICY}${policyID}`, policy); - mockFetchData.pause(); + void mockFetchData.pause(); const reportID = Report.createNewReport({accountID}, policyID); const parentReport = ReportUtils.getPolicyExpenseChat(accountID, policyID); @@ -1598,7 +1598,7 @@ describe('actions/Report', () => { }); // When the request fails - mockFetchData.fail(); + void mockFetchData.fail(); await mockFetchData.resume(); await waitForBatchedUpdates(); @@ -1760,7 +1760,7 @@ describe('actions/Report', () => { await Onyx.set(`${ONYXKEYS.COLLECTION.REPORT}${report.reportID}`, report); - mockFetch?.fail?.(); + void mockFetch?.fail?.(); Report.updateDescription('1', '

test

', '# test1'); await waitForBatchedUpdates(); @@ -1771,7 +1771,7 @@ describe('actions/Report', () => { callback: (val) => (updateReport = val), }); expect(updateReport?.description).toBe('

test

'); - mockFetch.mockReset(); + void mockFetch.mockReset(); }); }); diff --git a/tests/actions/WorkflowTest.ts b/tests/actions/WorkflowTest.ts index 6e8314005ad8..0403cb9f06e5 100644 --- a/tests/actions/WorkflowTest.ts +++ b/tests/actions/WorkflowTest.ts @@ -53,7 +53,7 @@ describe('actions/Workflow', () => { describe('clearApprovalWorkflowApprover', () => { it('should clear an approver', async () => { - mockFetch.pause(); + void mockFetch.pause(); const currentApprovalWorkflow: ApprovalWorkflowOnyx = { ...INITIAL_APPROVAL_WORKFLOW, @@ -65,7 +65,7 @@ describe('actions/Workflow', () => { }, ], }; - Onyx.merge(ONYXKEYS.APPROVAL_WORKFLOW, currentApprovalWorkflow); + void Onyx.merge(ONYXKEYS.APPROVAL_WORKFLOW, currentApprovalWorkflow); await waitForBatchedUpdates(); clearApprovalWorkflowApprover({approverIndex: 0, currentApprovalWorkflow}); @@ -82,7 +82,7 @@ describe('actions/Workflow', () => { describe('setApprovalWorkflowApprover', () => { it('should add an approver at an empty index', async () => { - mockFetch.pause(); + void mockFetch.pause(); const policyID = generatePolicyID(); const newApprover: Approver = { @@ -96,14 +96,14 @@ describe('actions/Workflow', () => { approvers: [], errors: undefined, }; - Onyx.merge(ONYXKEYS.APPROVAL_WORKFLOW, currentApprovalWorkflow); + void Onyx.merge(ONYXKEYS.APPROVAL_WORKFLOW, currentApprovalWorkflow); const fakePolicy: PolicyType = { ...createRandomPolicy(1), id: policyID, employeeList: {}, }; - Onyx.set(`${ONYXKEYS.COLLECTION.POLICY}${policyID}`, fakePolicy); + void Onyx.set(`${ONYXKEYS.COLLECTION.POLICY}${policyID}`, fakePolicy); await waitForBatchedUpdates(); setApprovalWorkflowApprover({approver: newApprover, approverIndex, policyID, currentApprovalWorkflow}); diff --git a/tests/perf-test/ModifiedExpenseMessage.perf-test.ts b/tests/perf-test/ModifiedExpenseMessage.perf-test.ts index 478a3b99680d..063372f9c417 100644 --- a/tests/perf-test/ModifiedExpenseMessage.perf-test.ts +++ b/tests/perf-test/ModifiedExpenseMessage.perf-test.ts @@ -20,7 +20,7 @@ beforeAll(() => // Clear out Onyx after each test so that each test starts with a clean state afterEach(() => { - Onyx.clear(); + void Onyx.clear(); }); const getMockedReports = (length = 500) => diff --git a/tests/perf-test/OptimisticReportNames.perf-test.ts b/tests/perf-test/OptimisticReportNames.perf-test.ts index 8add5f932bed..d28ea589db2b 100644 --- a/tests/perf-test/OptimisticReportNames.perf-test.ts +++ b/tests/perf-test/OptimisticReportNames.perf-test.ts @@ -80,7 +80,7 @@ describe('[OptimisticReportNames] Performance Tests', () => { }); afterAll(() => { - Onyx.clear(); + void Onyx.clear(); }); describe('Single Report Name Computation', () => { diff --git a/tests/perf-test/OptionsListUtils.perf-test.ts b/tests/perf-test/OptionsListUtils.perf-test.ts index 108408156aa1..c05ea28cd778 100644 --- a/tests/perf-test/OptionsListUtils.perf-test.ts +++ b/tests/perf-test/OptionsListUtils.perf-test.ts @@ -94,14 +94,14 @@ describe('OptionsListUtils', () => { keys: ONYXKEYS, }); - Onyx.multiSet({ + void Onyx.multiSet({ ...mockedReportsMap, ...mockedPersonalDetailsMap, }); }); afterAll(() => { - Onyx.clear(); + void Onyx.clear(); }); /* Testing getSearchOptions */ diff --git a/tests/perf-test/ReportActionCompose.perf-test.tsx b/tests/perf-test/ReportActionCompose.perf-test.tsx index e69f853ee784..fdc5a6f2c47a 100644 --- a/tests/perf-test/ReportActionCompose.perf-test.tsx +++ b/tests/perf-test/ReportActionCompose.perf-test.tsx @@ -74,7 +74,7 @@ beforeAll(() => // Initialize the network key for OfflineWithFeedback beforeEach(() => { - Onyx.merge(ONYXKEYS.NETWORK, {isOffline: false}); + void Onyx.merge(ONYXKEYS.NETWORK, {isOffline: false}); }); function ReportActionComposeWrapper() { diff --git a/tests/perf-test/ReportActionsList.perf-test.tsx b/tests/perf-test/ReportActionsList.perf-test.tsx index 8695f6aa33f2..00345b594203 100644 --- a/tests/perf-test/ReportActionsList.perf-test.tsx +++ b/tests/perf-test/ReportActionsList.perf-test.tsx @@ -84,13 +84,13 @@ const parentReportAction = createRandomReportAction(1); beforeEach(() => { // Initialize the network key for OfflineWithFeedback - Onyx.merge(ONYXKEYS.NETWORK, {isOffline: false}); + void Onyx.merge(ONYXKEYS.NETWORK, {isOffline: false}); wrapOnyxWithWaitForBatchedUpdates(Onyx); signUpWithTestUser(); }); afterEach(() => { - Onyx.clear(); + void Onyx.clear(); }); function ReportActionsListWrapper() { diff --git a/tests/perf-test/ReportActionsUtils.perf-test.ts b/tests/perf-test/ReportActionsUtils.perf-test.ts index 494345c483ce..e289b73fa314 100644 --- a/tests/perf-test/ReportActionsUtils.perf-test.ts +++ b/tests/perf-test/ReportActionsUtils.perf-test.ts @@ -42,13 +42,13 @@ describe('ReportActionsUtils', () => { evictableKeys: [ONYXKEYS.COLLECTION.REPORT_ACTIONS], }); - Onyx.multiSet({ + void Onyx.multiSet({ ...mockedReportActionsMap, }); }); afterAll(() => { - Onyx.clear(); + void Onyx.clear(); }); /** diff --git a/tests/perf-test/ReportUtils.perf-test.ts b/tests/perf-test/ReportUtils.perf-test.ts index 67b33740f497..53f6bee2d337 100644 --- a/tests/perf-test/ReportUtils.perf-test.ts +++ b/tests/perf-test/ReportUtils.perf-test.ts @@ -70,7 +70,7 @@ describe('ReportUtils', () => { }); afterAll(() => { - Onyx.clear(); + void Onyx.clear(); }); test('[ReportUtils] findLastAccessedReport on 2k reports and policies', async () => { diff --git a/tests/perf-test/SearchRouter.perf-test.tsx b/tests/perf-test/SearchRouter.perf-test.tsx index 6be4addeec94..fa0b49a00a50 100644 --- a/tests/perf-test/SearchRouter.perf-test.tsx +++ b/tests/perf-test/SearchRouter.perf-test.tsx @@ -102,12 +102,12 @@ beforeAll(() => beforeEach(() => { global.fetch = TestHelper.getGlobalFetchMock(); wrapOnyxWithWaitForBatchedUpdates(Onyx); - Onyx.merge(ONYXKEYS.NETWORK, {isOffline: false}); + void Onyx.merge(ONYXKEYS.NETWORK, {isOffline: false}); }); // Clear out Onyx after each test so that each test starts with a clean state afterEach(() => { - Onyx.clear(); + void Onyx.clear(); }); const mockOnClose = jest.fn(); @@ -142,13 +142,14 @@ test('[SearchRouter] should render list with cached options', async () => { }; return waitForBatchedUpdates() - .then(() => - Onyx.multiSet({ - ...mockedReports, - [ONYXKEYS.PERSONAL_DETAILS_LIST]: mockedPersonalDetails, - [ONYXKEYS.BETAS]: mockedBetas, - [ONYXKEYS.IS_SEARCHING_FOR_REPORTS]: true, - }), + .then( + () => + void Onyx.multiSet({ + ...mockedReports, + [ONYXKEYS.PERSONAL_DETAILS_LIST]: mockedPersonalDetails, + [ONYXKEYS.BETAS]: mockedBetas, + [ONYXKEYS.IS_SEARCHING_FOR_REPORTS]: true, + }), ) .then(() => measureRenders(, {scenario})); }); @@ -162,13 +163,14 @@ test('[SearchRouter] should react to text input changes', async () => { }; return waitForBatchedUpdates() - .then(() => - Onyx.multiSet({ - ...mockedReports, - [ONYXKEYS.PERSONAL_DETAILS_LIST]: mockedPersonalDetails, - [ONYXKEYS.BETAS]: mockedBetas, - [ONYXKEYS.IS_SEARCHING_FOR_REPORTS]: true, - }), + .then( + () => + void Onyx.multiSet({ + ...mockedReports, + [ONYXKEYS.PERSONAL_DETAILS_LIST]: mockedPersonalDetails, + [ONYXKEYS.BETAS]: mockedBetas, + [ONYXKEYS.IS_SEARCHING_FOR_REPORTS]: true, + }), ) .then(() => measureRenders(, {scenario})); }); diff --git a/tests/perf-test/SidebarLinks.perf-test.tsx b/tests/perf-test/SidebarLinks.perf-test.tsx index c7cad32c3591..742eeaa271e3 100644 --- a/tests/perf-test/SidebarLinks.perf-test.tsx +++ b/tests/perf-test/SidebarLinks.perf-test.tsx @@ -63,12 +63,12 @@ describe('SidebarLinks', () => { wrapOnyxWithWaitForBatchedUpdates(Onyx); // Initialize the network key for OfflineWithFeedback - Onyx.merge(ONYXKEYS.NETWORK, {isOffline: false}); + void Onyx.merge(ONYXKEYS.NETWORK, {isOffline: false}); TestHelper.signInWithTestUser(1, 'email1@test.com', undefined, undefined, 'One').then(waitForBatchedUpdates); }); afterEach(() => { - Onyx.clear(); + void Onyx.clear(); }); test('[SidebarLinks] should render Sidebar with 500 reports stored', async () => { @@ -81,7 +81,7 @@ describe('SidebarLinks', () => { await waitForBatchedUpdates(); - Onyx.multiSet({ + void Onyx.multiSet({ [ONYXKEYS.PERSONAL_DETAILS_LIST]: LHNTestUtils.fakePersonalDetails, [ONYXKEYS.BETAS]: [CONST.BETAS.DEFAULT_ROOMS], [ONYXKEYS.NVP_PRIORITY_MODE]: CONST.PRIORITY_MODE.GSD, diff --git a/tests/perf-test/SidebarUtils.perf-test.ts b/tests/perf-test/SidebarUtils.perf-test.ts index 50610542f9d7..a6f4988b15df 100644 --- a/tests/perf-test/SidebarUtils.perf-test.ts +++ b/tests/perf-test/SidebarUtils.perf-test.ts @@ -57,14 +57,14 @@ describe('SidebarUtils', () => { evictableKeys: [ONYXKEYS.COLLECTION.REPORT_ACTIONS], }); - Onyx.multiSet({ + void Onyx.multiSet({ [ONYXKEYS.PERSONAL_DETAILS_LIST]: personalDetails, [ONYXKEYS.NVP_PREFERRED_LOCALE]: 'en', }); }); afterAll(() => { - Onyx.clear(); + void Onyx.clear(); }); test('[SidebarUtils] getOptionData', async () => { diff --git a/tests/ui/AddressPageTest.tsx b/tests/ui/AddressPageTest.tsx index 2e222780ae5c..bf6a6d23a3cf 100644 --- a/tests/ui/AddressPageTest.tsx +++ b/tests/ui/AddressPageTest.tsx @@ -52,7 +52,7 @@ describe('AddressPageTest', () => { Onyx.init({ keys: ONYXKEYS, }); - Onyx.set(ONYXKEYS.NVP_PREFERRED_LOCALE, CONST.LOCALES.EN); + void Onyx.set(ONYXKEYS.NVP_PREFERRED_LOCALE, CONST.LOCALES.EN); }); it('should not reset state', async () => { await TestHelper.signInWithTestUser(); diff --git a/tests/ui/BottomTabBarTest.tsx b/tests/ui/BottomTabBarTest.tsx index d09ec07fd0ad..a8317c75cf9c 100644 --- a/tests/ui/BottomTabBarTest.tsx +++ b/tests/ui/BottomTabBarTest.tsx @@ -18,15 +18,15 @@ describe('NavigationTabBar', () => { beforeAll(() => { Onyx.init({keys: ONYXKEYS}); initOnyxDerivedValues(); - Onyx.set(ONYXKEYS.NVP_PREFERRED_LOCALE, CONST.LOCALES.EN); + void Onyx.set(ONYXKEYS.NVP_PREFERRED_LOCALE, CONST.LOCALES.EN); }); beforeEach(() => { - Onyx.clear([ONYXKEYS.NVP_PREFERRED_LOCALE]); + void Onyx.clear([ONYXKEYS.NVP_PREFERRED_LOCALE]); }); describe('Home tab', () => { describe('Debug mode enabled', () => { beforeEach(() => { - Onyx.set(ONYXKEYS.IS_DEBUG_MODE_ENABLED, true); + void Onyx.set(ONYXKEYS.IS_DEBUG_MODE_ENABLED, true); }); describe('Has GBR', () => { it('renders DebugTabView', async () => { @@ -81,7 +81,7 @@ describe('NavigationTabBar', () => { describe('Settings tab', () => { describe('Debug mode enabled', () => { beforeEach(() => { - Onyx.set(ONYXKEYS.IS_DEBUG_MODE_ENABLED, true); + void Onyx.set(ONYXKEYS.IS_DEBUG_MODE_ENABLED, true); }); describe('Has GBR', () => { it('renders DebugTabView', async () => { diff --git a/tests/ui/DebugReportActionsTest.tsx b/tests/ui/DebugReportActionsTest.tsx index 679d5b4c386f..ef41b83692ba 100644 --- a/tests/ui/DebugReportActionsTest.tsx +++ b/tests/ui/DebugReportActionsTest.tsx @@ -31,7 +31,7 @@ describe('DebugReportActions', () => { keys: ONYXKEYS, evictableKeys: [ONYXKEYS.COLLECTION.REPORT_ACTIONS], }); - Onyx.set(ONYXKEYS.NVP_PREFERRED_LOCALE, CONST.LOCALES.EN); + void Onyx.set(ONYXKEYS.NVP_PREFERRED_LOCALE, CONST.LOCALES.EN); }); afterEach(async () => { diff --git a/tests/ui/GroupChatNameTests.tsx b/tests/ui/GroupChatNameTests.tsx index 1e86f602473a..6e664691d07d 100644 --- a/tests/ui/GroupChatNameTests.tsx +++ b/tests/ui/GroupChatNameTests.tsx @@ -89,7 +89,7 @@ function signInAndGetApp(reportName = '', participantAccountIDs?: number[]): Pro .then(async () => { // Simulate setting an unread report and personal details await Promise.all([ - Onyx.merge(`${ONYXKEYS.COLLECTION.REPORT}${REPORT_ID}`, { + void Onyx.merge(`${ONYXKEYS.COLLECTION.REPORT}${REPORT_ID}`, { reportID: REPORT_ID, reportName, lastMessageText: 'Test', @@ -98,7 +98,7 @@ function signInAndGetApp(reportName = '', participantAccountIDs?: number[]): Pro type: CONST.REPORT.TYPE.CHAT, chatType: CONST.REPORT.CHAT_TYPE.GROUP, }), - Onyx.merge(ONYXKEYS.PERSONAL_DETAILS_LIST, { + void Onyx.merge(ONYXKEYS.PERSONAL_DETAILS_LIST, { [USER_A_ACCOUNT_ID]: TestHelper.buildPersonalDetails(USER_A_EMAIL, USER_A_ACCOUNT_ID, 'A'), [USER_B_ACCOUNT_ID]: TestHelper.buildPersonalDetails(USER_B_EMAIL, USER_B_ACCOUNT_ID, 'B'), [USER_C_ACCOUNT_ID]: TestHelper.buildPersonalDetails(USER_C_EMAIL, USER_C_ACCOUNT_ID, 'C'), diff --git a/tests/ui/IOURequestEditReportCommonTest.tsx b/tests/ui/IOURequestEditReportCommonTest.tsx index 11b61f5fe964..f30e4b4265f6 100644 --- a/tests/ui/IOURequestEditReportCommonTest.tsx +++ b/tests/ui/IOURequestEditReportCommonTest.tsx @@ -70,7 +70,7 @@ describe('IOURequestEditReportCommon', () => { }); beforeEach(() => { - Onyx.multiSet({ + void Onyx.multiSet({ [`${ONYXKEYS.COLLECTION.POLICY}${FAKE_POLICY_ID}` as const]: createRandomPolicy(Number(FAKE_POLICY_ID), CONST.POLICY.TYPE.TEAM), [`${ONYXKEYS.COLLECTION.REPORT}${FAKE_REPORT_ID}` as const]: { reportID: FAKE_REPORT_ID, @@ -86,7 +86,7 @@ describe('IOURequestEditReportCommon', () => { }); afterEach(() => { - Onyx.clear(); + void Onyx.clear(); jest.clearAllMocks(); return waitForBatchedUpdates(); }); @@ -100,7 +100,7 @@ describe('IOURequestEditReportCommon', () => { policyID: FAKE_POLICY_ID, }; - Onyx.set(`${ONYXKEYS.COLLECTION.REPORT}${mockTransactionReport.reportID}`, mockTransactionReport); + void Onyx.set(`${ONYXKEYS.COLLECTION.REPORT}${mockTransactionReport.reportID}`, mockTransactionReport); await waitForBatchedUpdates(); // When the component is rendered with the transaction reports @@ -129,7 +129,7 @@ describe('IOURequestEditReportCommon', () => { }); beforeEach(() => { - Onyx.multiSet({ + void Onyx.multiSet({ [`${ONYXKEYS.COLLECTION.POLICY}${FAKE_POLICY_ID}` as const]: { ...createRandomPolicy(Number(FAKE_POLICY_ID), CONST.POLICY.TYPE.TEAM), role: CONST.POLICY.ROLE.USER, @@ -148,7 +148,7 @@ describe('IOURequestEditReportCommon', () => { }); afterEach(() => { - Onyx.clear(); + void Onyx.clear(); jest.clearAllMocks(); return waitForBatchedUpdates(); }); @@ -164,7 +164,7 @@ describe('IOURequestEditReportCommon', () => { statusNum: CONST.REPORT.STATUS_NUM.OPEN, }; - Onyx.set(`${ONYXKEYS.COLLECTION.REPORT}${mockTransactionReport.reportID}`, mockTransactionReport); + void Onyx.set(`${ONYXKEYS.COLLECTION.REPORT}${mockTransactionReport.reportID}`, mockTransactionReport); await waitForBatchedUpdates(); // When the component is rendered with the transaction reports diff --git a/tests/ui/LHNItemsPresence.tsx b/tests/ui/LHNItemsPresence.tsx index 95374059dd7f..b83c1acfe345 100644 --- a/tests/ui/LHNItemsPresence.tsx +++ b/tests/ui/LHNItemsPresence.tsx @@ -126,8 +126,8 @@ describe('SidebarLinksData', () => { beforeEach(() => { wrapOnyxWithWaitForBatchedUpdates(Onyx); // Initialize the network key for OfflineWithFeedback - Onyx.merge(ONYXKEYS.NETWORK, {isOffline: false}); - Onyx.set(ONYXKEYS.NVP_PREFERRED_LOCALE, CONST.LOCALES.EN); + void Onyx.merge(ONYXKEYS.NETWORK, {isOffline: false}); + void Onyx.set(ONYXKEYS.NVP_PREFERRED_LOCALE, CONST.LOCALES.EN); signUpWithTestUser(); }); @@ -139,7 +139,7 @@ describe('SidebarLinksData', () => { describe('Report that should be included in the LHN', () => { it('should display the current active report', async () => { // Given the SidebarLinks are rendered without a specified report ID. - LHNTestUtils.getDefaultRenderedSidebarLinks(); + void LHNTestUtils.getDefaultRenderedSidebarLinks(); const report = createReport(); // When the Onyx state is initialized with a report. @@ -163,7 +163,7 @@ describe('SidebarLinksData', () => { it('should display draft report', async () => { // Given SidebarLinks are rendered initially. - LHNTestUtils.getDefaultRenderedSidebarLinks(); + void LHNTestUtils.getDefaultRenderedSidebarLinks(); const draftReport = { ...createReport(false, [1, 2], 0), writeCapability: CONST.REPORT.WRITE_CAPABILITIES.ALL, @@ -188,7 +188,7 @@ describe('SidebarLinksData', () => { it('should display pinned report', async () => { // Given the SidebarLinks are rendered. - LHNTestUtils.getDefaultRenderedSidebarLinks(); + void LHNTestUtils.getDefaultRenderedSidebarLinks(); const report = createReport(false); // When the report is initialized in Onyx. @@ -212,7 +212,7 @@ describe('SidebarLinksData', () => { it('should display the report with violations', async () => { // Given the SidebarLinks are rendered. - LHNTestUtils.getDefaultRenderedSidebarLinks(); + void LHNTestUtils.getDefaultRenderedSidebarLinks(); // When the report is initialized in Onyx. const report: Report = { @@ -255,7 +255,7 @@ describe('SidebarLinksData', () => { it('should display the report awaiting user action', async () => { // Given the SidebarLinks are rendered. - LHNTestUtils.getDefaultRenderedSidebarLinks(); + void LHNTestUtils.getDefaultRenderedSidebarLinks(); const report: Report = { ...createReport(false), hasOutstandingChildRequest: true, @@ -277,7 +277,7 @@ describe('SidebarLinksData', () => { it('should display the archived report in the default mode', async () => { // Given the SidebarLinks are rendered. - LHNTestUtils.getDefaultRenderedSidebarLinks(); + void LHNTestUtils.getDefaultRenderedSidebarLinks(); const archivedReport: Report = { ...createReport(false), }; @@ -302,7 +302,7 @@ describe('SidebarLinksData', () => { it('should display the selfDM report by default', async () => { // Given the SidebarLinks are rendered. - LHNTestUtils.getDefaultRenderedSidebarLinks(); + void LHNTestUtils.getDefaultRenderedSidebarLinks(); const report = createReport(true, undefined, undefined, undefined, CONST.REPORT.CHAT_TYPE.SELF_DM, undefined); // When the selfDM is initialized in Onyx @@ -318,7 +318,7 @@ describe('SidebarLinksData', () => { it('should display the unread report in the focus mode with the bold text', async () => { // Given the SidebarLinks are rendered. - LHNTestUtils.getDefaultRenderedSidebarLinks(); + void LHNTestUtils.getDefaultRenderedSidebarLinks(); const report: Report = { ...createReport(undefined, undefined, undefined, undefined, undefined, true), lastMessageText: 'fake last message', @@ -356,7 +356,7 @@ describe('SidebarLinksData', () => { describe('Report that should NOT be included in the LHN', () => { it('should not display report with no participants', async () => { // Given the SidebarLinks are rendered. - LHNTestUtils.getDefaultRenderedSidebarLinks(); + void LHNTestUtils.getDefaultRenderedSidebarLinks(); const report = LHNTestUtils.getFakeReport([]); // When a report with no participants is initialized in Onyx. @@ -370,7 +370,7 @@ describe('SidebarLinksData', () => { it('should not display empty chat', async () => { // Given the SidebarLinks are rendered. - LHNTestUtils.getDefaultRenderedSidebarLinks(); + void LHNTestUtils.getDefaultRenderedSidebarLinks(); const report = LHNTestUtils.getFakeReport([1, 2], 0); // When a report with no messages is initialized in Onyx @@ -384,7 +384,7 @@ describe('SidebarLinksData', () => { it('should not display the report marked as hidden', async () => { // Given the SidebarLinks are rendered - LHNTestUtils.getDefaultRenderedSidebarLinks(); + void LHNTestUtils.getDefaultRenderedSidebarLinks(); const report: Report = { ...createReport(), participants: { @@ -405,7 +405,7 @@ describe('SidebarLinksData', () => { it('should not display the report has empty notification preference', async () => { // Given the SidebarLinks are rendered - LHNTestUtils.getDefaultRenderedSidebarLinks(); + void LHNTestUtils.getDefaultRenderedSidebarLinks(); const report = createReport(false, [2]); // When a report with empty notification preference is initialized in Onyx @@ -419,7 +419,7 @@ describe('SidebarLinksData', () => { it('should not display the report the user cannot access due to policy restrictions', async () => { // Given the SidebarLinks are rendered - LHNTestUtils.getDefaultRenderedSidebarLinks(); + void LHNTestUtils.getDefaultRenderedSidebarLinks(); const report: Report = { ...createReport(), chatType: CONST.REPORT.CHAT_TYPE.DOMAIN_ALL, @@ -440,7 +440,7 @@ describe('SidebarLinksData', () => { it('should not display the single transaction thread', async () => { // Given the SidebarLinks are rendered - LHNTestUtils.getDefaultRenderedSidebarLinks(); + void LHNTestUtils.getDefaultRenderedSidebarLinks(); const expenseReport = buildOptimisticExpenseReport(chatReportR14932.reportID, '123', 100, 122, 'USD'); const expenseTransaction = buildOptimisticTransaction({ transactionParams: { @@ -478,7 +478,7 @@ describe('SidebarLinksData', () => { it('should not display the report with parent message is pending removal', async () => { // Given the SidebarLinks are rendered - LHNTestUtils.getDefaultRenderedSidebarLinks(); + void LHNTestUtils.getDefaultRenderedSidebarLinks(); const parentReport = createReport(); const report = createReport(); const parentReportAction: ReportAction = { @@ -516,7 +516,7 @@ describe('SidebarLinksData', () => { it('should not display the read report in the focus mode', async () => { // Given the SidebarLinks are rendered - LHNTestUtils.getDefaultRenderedSidebarLinks(); + void LHNTestUtils.getDefaultRenderedSidebarLinks(); const report: Report = { ...createReport(), lastMessageText: 'fake last message', @@ -547,7 +547,7 @@ describe('SidebarLinksData', () => { it('should not display an empty submitted report having only a CREATED action', async () => { // Given the SidebarLinks are rendered - LHNTestUtils.getDefaultRenderedSidebarLinks(); + void LHNTestUtils.getDefaultRenderedSidebarLinks(); // When creating a report with total = 0, stateNum = SUBMITTED, statusNum = SUBMITTED const report = { diff --git a/tests/ui/PureReportActionItemTest.tsx b/tests/ui/PureReportActionItemTest.tsx index 1a56787d1345..a5a7d5c40c32 100644 --- a/tests/ui/PureReportActionItemTest.tsx +++ b/tests/ui/PureReportActionItemTest.tsx @@ -56,20 +56,21 @@ describe('PureReportActionItem', () => { beforeEach(() => { wrapOnyxWithWaitForBatchedUpdates(Onyx); - return Onyx.merge(ONYXKEYS.NETWORK, {isOffline: false}).then(() => - Onyx.merge(`${ONYXKEYS.PERSONAL_DETAILS_LIST}`, { - [ACTOR_ACCOUNT_ID]: { - accountID: ACTOR_ACCOUNT_ID, - avatar: 'https://d2k5nsl2zxldvw.cloudfront.net/images/avatars/default-avatar_9.png', - displayName: actorEmail, - login: actorEmail, - }, - }), + return Onyx.merge(ONYXKEYS.NETWORK, {isOffline: false}).then( + () => + void Onyx.merge(`${ONYXKEYS.PERSONAL_DETAILS_LIST}`, { + [ACTOR_ACCOUNT_ID]: { + accountID: ACTOR_ACCOUNT_ID, + avatar: 'https://d2k5nsl2zxldvw.cloudfront.net/images/avatars/default-avatar_9.png', + displayName: actorEmail, + login: actorEmail, + }, + }), ); }); afterEach(() => { - Onyx.clear(); + void Onyx.clear(); }); function renderItemWithAction(action: ReportAction) { diff --git a/tests/ui/ReportAttachments.tsx b/tests/ui/ReportAttachments.tsx index 6fabbf317bc0..1a24fa47a4b4 100644 --- a/tests/ui/ReportAttachments.tsx +++ b/tests/ui/ReportAttachments.tsx @@ -154,7 +154,7 @@ describe('ReportAttachments', () => { beforeEach(async () => { global.fetch = getGlobalFetchMock(); wrapOnyxWithWaitForBatchedUpdates(Onyx); - Onyx.merge(ONYXKEYS.IS_LOADING_APP, false); + void Onyx.merge(ONYXKEYS.IS_LOADING_APP, false); // Given a test user is signed in with Onyx setup and some initial data await signInWithTestUser(TEST_USER_ACCOUNT_ID, TEST_USER_LOGIN); diff --git a/tests/ui/SessionTest.tsx b/tests/ui/SessionTest.tsx index 287043bc6e47..1aa4260719e9 100644 --- a/tests/ui/SessionTest.tsx +++ b/tests/ui/SessionTest.tsx @@ -65,25 +65,25 @@ describe('Deep linking', () => { }); jest.spyOn(Session, 'signInWithShortLivedAuthToken').mockImplementation(() => { - Onyx.merge(ONYXKEYS.CREDENTIALS, { + void Onyx.merge(ONYXKEYS.CREDENTIALS, { login: TEST_USER_LOGIN_1, autoGeneratedLogin: Str.guid('expensify.cash-'), autoGeneratedPassword: Str.guid(), }); - Onyx.merge(ONYXKEYS.ACCOUNT, { + void Onyx.merge(ONYXKEYS.ACCOUNT, { validated: true, isUsingExpensifyCard: false, }); - Onyx.merge(ONYXKEYS.PERSONAL_DETAILS_LIST, { + void Onyx.merge(ONYXKEYS.PERSONAL_DETAILS_LIST, { [TEST_USER_ACCOUNT_ID_1]: TestHelper.buildPersonalDetails(TEST_USER_LOGIN_1, TEST_USER_ACCOUNT_ID_1, 'Test'), }); - Onyx.merge(ONYXKEYS.SESSION, { + void Onyx.merge(ONYXKEYS.SESSION, { authToken: TEST_AUTH_TOKEN_1, accountID: TEST_USER_ACCOUNT_ID_1, email: TEST_USER_LOGIN_1, encryptedAuthToken: TEST_AUTH_TOKEN_1, }); - Onyx.merge(ONYXKEYS.NVP_PRIVATE_PUSH_NOTIFICATION_ID, 'randomID'); + void Onyx.merge(ONYXKEYS.NVP_PRIVATE_PUSH_NOTIFICATION_ID, 'randomID'); return originalSignInWithShortLivedAuthToken(TEST_AUTH_TOKEN_1); }); diff --git a/tests/ui/SwitchToExpensifyClassicTest.tsx b/tests/ui/SwitchToExpensifyClassicTest.tsx index d5570fcfb3da..6ee575b3c4f7 100644 --- a/tests/ui/SwitchToExpensifyClassicTest.tsx +++ b/tests/ui/SwitchToExpensifyClassicTest.tsx @@ -67,7 +67,7 @@ function signInAppAndEnterTestFlow(dismissedValue?: boolean): Promise { describe('Switch to Expensify Classic flow', () => { beforeEach(() => { jest.clearAllMocks(); - Onyx.clear(); + void Onyx.clear(); // Unsubscribe to pusher channels PusherHelper.teardown(); diff --git a/tests/ui/TransactionItemRowRBRTest.tsx b/tests/ui/TransactionItemRowRBRTest.tsx index 7b9e807a2a9c..4b5f202d505f 100644 --- a/tests/ui/TransactionItemRowRBRTest.tsx +++ b/tests/ui/TransactionItemRowRBRTest.tsx @@ -97,7 +97,7 @@ describe('TransactionItemRowRBRWithOnyx', () => { keys: ONYXKEYS, evictableKeys: [ONYXKEYS.COLLECTION.REPORT_ACTIONS], }); - Onyx.set(ONYXKEYS.NVP_PREFERRED_LOCALE, CONST.LOCALES.DEFAULT); + void Onyx.set(ONYXKEYS.NVP_PREFERRED_LOCALE, CONST.LOCALES.DEFAULT); }); beforeEach(() => { diff --git a/tests/ui/UnreadIndicatorsTest.tsx b/tests/ui/UnreadIndicatorsTest.tsx index 3aca315eefc0..554f0bc3f507 100644 --- a/tests/ui/UnreadIndicatorsTest.tsx +++ b/tests/ui/UnreadIndicatorsTest.tsx @@ -45,7 +45,7 @@ TestHelper.setupApp(); TestHelper.setupGlobalFetchMock(); beforeEach(() => { - Onyx.set(ONYXKEYS.NVP_ONBOARDING, {hasCompletedGuidedSetupFlow: true}); + void Onyx.set(ONYXKEYS.NVP_ONBOARDING, {hasCompletedGuidedSetupFlow: true}); }); function scrollUpToRevealNewMessagesBadge() { @@ -519,7 +519,7 @@ describe.skip('Unread Indicators', () => { .then(() => { // Simulate the response from the server so that the comment can be deleted in this test lastReportAction = reportActions ? lastItem(reportActions) : undefined; - Onyx.merge(`${ONYXKEYS.COLLECTION.REPORT}${REPORT_ID}`, { + void Onyx.merge(`${ONYXKEYS.COLLECTION.REPORT}${REPORT_ID}`, { lastMessageText: getReportActionText(lastReportAction), lastActorAccountID: lastReportAction?.actorAccountID, reportID: REPORT_ID, diff --git a/tests/ui/ValidateLoginPageTest.tsx b/tests/ui/ValidateLoginPageTest.tsx index 2a6f4ecfd2b9..8c767d2045a8 100644 --- a/tests/ui/ValidateLoginPageTest.tsx +++ b/tests/ui/ValidateLoginPageTest.tsx @@ -28,7 +28,7 @@ const renderPage = (initialParams: PublicScreensParamList[typeof SCREENS.VALIDAT describe('ValidateLoginPage', () => { beforeEach(() => { jest.clearAllMocks(); - Onyx.clear(); + void Onyx.clear(); }); it('Should show not found view when the magic code is invalid and there is an exitTo param', async () => { diff --git a/tests/ui/WorkspacePageWithSectionsTest.tsx b/tests/ui/WorkspacePageWithSectionsTest.tsx index 5eedddad6b67..fffd9fcf15a4 100644 --- a/tests/ui/WorkspacePageWithSectionsTest.tsx +++ b/tests/ui/WorkspacePageWithSectionsTest.tsx @@ -76,7 +76,7 @@ describe('WorkspacePageWithSections', () => { Onyx.init({ keys: ONYXKEYS, }); - Onyx.merge(`${ONYXKEYS.COLLECTION.POLICY}${POLICY_ID}`, mockPolicy); + void Onyx.merge(`${ONYXKEYS.COLLECTION.POLICY}${POLICY_ID}`, mockPolicy); return waitForBatchedUpdates(); }); diff --git a/tests/ui/components/EmptySearchViewTest.tsx b/tests/ui/components/EmptySearchViewTest.tsx index 22c0b07011d6..6df852f8b1b6 100644 --- a/tests/ui/components/EmptySearchViewTest.tsx +++ b/tests/ui/components/EmptySearchViewTest.tsx @@ -97,7 +97,7 @@ describe('EmptySearchView', () => { }); afterEach(() => { - Onyx.clear(); + void Onyx.clear(); }); it('should display "Create Report" button when user has a paid group policy with expense chat enabled', async () => { diff --git a/tests/ui/components/OnboardingHelpDropdownButtonTest.tsx b/tests/ui/components/OnboardingHelpDropdownButtonTest.tsx index d375be78b19e..9f7b93c4920d 100644 --- a/tests/ui/components/OnboardingHelpDropdownButtonTest.tsx +++ b/tests/ui/components/OnboardingHelpDropdownButtonTest.tsx @@ -86,13 +86,13 @@ describe('OnboardingHelpDropdownButton', () => { }); beforeEach(() => { - Onyx.merge(ONYXKEYS.SESSION, {accountID: currentUserAccountID}); + void Onyx.merge(ONYXKEYS.SESSION, {accountID: currentUserAccountID}); return waitForBatchedUpdates(); }); afterEach(() => { jest.clearAllMocks(); - Onyx.clear(); + void Onyx.clear(); return waitForBatchedUpdates(); }); @@ -193,7 +193,7 @@ describe('OnboardingHelpDropdownButton', () => { hasActiveScheduledCall: true, }; beforeEach(() => { - Onyx.merge(`${ONYXKEYS.COLLECTION.REPORT_NAME_VALUE_PAIRS}${props.reportID}`, { + void Onyx.merge(`${ONYXKEYS.COLLECTION.REPORT_NAME_VALUE_PAIRS}${props.reportID}`, { calendlyCalls: [mockScheduledCall], }); return waitForBatchedUpdates(); diff --git a/tests/ui/components/ProductTrainingContextProvider.tsx b/tests/ui/components/ProductTrainingContextProvider.tsx index e05bea0fc7bb..773e7d1a1276 100644 --- a/tests/ui/components/ProductTrainingContextProvider.tsx +++ b/tests/ui/components/ProductTrainingContextProvider.tsx @@ -64,8 +64,8 @@ describe('ProductTrainingContextProvider', () => { beforeEach(() => { // Set up test environment before each test wrapOnyxWithWaitForBatchedUpdates(Onyx); - Onyx.merge(ONYXKEYS.NETWORK, {isOffline: false}); - Onyx.merge(ONYXKEYS.IS_LOADING_APP, false); + void Onyx.merge(ONYXKEYS.NETWORK, {isOffline: false}); + void Onyx.merge(ONYXKEYS.IS_LOADING_APP, false); signUpWithTestUser(); }); @@ -81,7 +81,7 @@ describe('ProductTrainingContextProvider', () => { describe('Basic Tooltip Registration', () => { it('should not register tooltips when app is loading', async () => { // When app is loading - Onyx.merge(ONYXKEYS.IS_LOADING_APP, true); + void Onyx.merge(ONYXKEYS.IS_LOADING_APP, true); await waitForBatchedUpdatesWithAct(); const testTooltip = CONST.PRODUCT_TRAINING_TOOLTIP_NAMES.SCAN_TEST_TOOLTIP; @@ -93,7 +93,7 @@ describe('ProductTrainingContextProvider', () => { it('should not register tooltips when onboarding is not completed', async () => { // When onboarding is not completed - Onyx.merge(ONYXKEYS.NVP_ONBOARDING, {hasCompletedGuidedSetupFlow: false}); + void Onyx.merge(ONYXKEYS.NVP_ONBOARDING, {hasCompletedGuidedSetupFlow: false}); await waitForBatchedUpdatesWithAct(); const testTooltip = CONST.PRODUCT_TRAINING_TOOLTIP_NAMES.SCAN_TEST_TOOLTIP; @@ -105,7 +105,7 @@ describe('ProductTrainingContextProvider', () => { it('should register tooltips when onboarding is completed and user is not migrated', async () => { // When onboarding is completed - Onyx.merge(ONYXKEYS.NVP_ONBOARDING, {hasCompletedGuidedSetupFlow: true}); + void Onyx.merge(ONYXKEYS.NVP_ONBOARDING, {hasCompletedGuidedSetupFlow: true}); await waitForBatchedUpdatesWithAct(); const testTooltip = CONST.PRODUCT_TRAINING_TOOLTIP_NAMES.SCAN_TEST_TOOLTIP; @@ -164,8 +164,8 @@ describe('ProductTrainingContextProvider', () => { describe('Migrated User Scenarios', () => { it('should not show tooltips for migrated users before welcome modal dismissal', async () => { // When user is a migrated user and welcome modal is not dismissed - Onyx.merge(ONYXKEYS.NVP_ONBOARDING, {hasCompletedGuidedSetupFlow: true}); - Onyx.merge(ONYXKEYS.NVP_TRY_NEW_DOT, {nudgeMigration: {timestamp: new Date()}}); + void Onyx.merge(ONYXKEYS.NVP_ONBOARDING, {hasCompletedGuidedSetupFlow: true}); + void Onyx.merge(ONYXKEYS.NVP_TRY_NEW_DOT, {nudgeMigration: {timestamp: new Date()}}); await waitForBatchedUpdatesWithAct(); // Then tooltips should not show @@ -178,10 +178,10 @@ describe('ProductTrainingContextProvider', () => { it('should show tooltips for migrated users after welcome modal dismissal', async () => { // When migrated user has dismissed welcome modal - Onyx.merge(ONYXKEYS.NVP_ONBOARDING, {hasCompletedGuidedSetupFlow: true}); - Onyx.merge(ONYXKEYS.NVP_TRY_NEW_DOT, {nudgeMigration: {timestamp: new Date()}}); + void Onyx.merge(ONYXKEYS.NVP_ONBOARDING, {hasCompletedGuidedSetupFlow: true}); + void Onyx.merge(ONYXKEYS.NVP_TRY_NEW_DOT, {nudgeMigration: {timestamp: new Date()}}); const date = new Date(); - Onyx.set(ONYXKEYS.NVP_DISMISSED_PRODUCT_TRAINING, { + void Onyx.set(ONYXKEYS.NVP_DISMISSED_PRODUCT_TRAINING, { migratedUserWelcomeModal: { timestamp: DateUtils.getDBTime(date.valueOf()), }, @@ -200,9 +200,9 @@ describe('ProductTrainingContextProvider', () => { it('should not show dismissed tooltips', async () => { // When a tooltip has been dismissed const date = new Date(); - Onyx.merge(ONYXKEYS.NVP_ONBOARDING, {hasCompletedGuidedSetupFlow: true}); + void Onyx.merge(ONYXKEYS.NVP_ONBOARDING, {hasCompletedGuidedSetupFlow: true}); const testTooltip = CONST.PRODUCT_TRAINING_TOOLTIP_NAMES.SCAN_TEST_TOOLTIP; - Onyx.merge(ONYXKEYS.NVP_DISMISSED_PRODUCT_TRAINING, { + void Onyx.merge(ONYXKEYS.NVP_DISMISSED_PRODUCT_TRAINING, { migratedUserWelcomeModal: { timestamp: DateUtils.getDBTime(date.valueOf()), }, @@ -219,9 +219,9 @@ describe('ProductTrainingContextProvider', () => { }); it('should hide tooltip when hideProductTrainingTooltip is called', async () => { // When migrated user has dismissed welcome modal - Onyx.merge(ONYXKEYS.NVP_ONBOARDING, {hasCompletedGuidedSetupFlow: true}); + void Onyx.merge(ONYXKEYS.NVP_ONBOARDING, {hasCompletedGuidedSetupFlow: true}); const date = new Date(); - Onyx.set(ONYXKEYS.NVP_DISMISSED_PRODUCT_TRAINING, { + void Onyx.set(ONYXKEYS.NVP_DISMISSED_PRODUCT_TRAINING, { migratedUserWelcomeModal: { timestamp: DateUtils.getDBTime(date.valueOf()), }, @@ -254,7 +254,7 @@ describe('ProductTrainingContextProvider', () => { // When narrow layout is true mockUseResponsiveLayout.mockReturnValue({...DEFAULT_USE_RESPONSIVE_LAYOUT_VALUE, shouldUseNarrowLayout: true}); - Onyx.merge(ONYXKEYS.NVP_ONBOARDING, {hasCompletedGuidedSetupFlow: true}); + void Onyx.merge(ONYXKEYS.NVP_ONBOARDING, {hasCompletedGuidedSetupFlow: true}); await waitForBatchedUpdatesWithAct(); const testTooltip = CONST.PRODUCT_TRAINING_TOOLTIP_NAMES.RENAME_SAVED_SEARCH; @@ -275,9 +275,9 @@ describe('ProductTrainingContextProvider', () => { describe('Priority Handling', () => { it('should show only highest priority tooltip when multiple are active', async () => { // When multiple tooltips are registered and no tooltips are dismissed - Onyx.merge(ONYXKEYS.NVP_ONBOARDING, {hasCompletedGuidedSetupFlow: true}); + void Onyx.merge(ONYXKEYS.NVP_ONBOARDING, {hasCompletedGuidedSetupFlow: true}); const date = new Date(); - Onyx.merge(ONYXKEYS.NVP_DISMISSED_PRODUCT_TRAINING, { + void Onyx.merge(ONYXKEYS.NVP_DISMISSED_PRODUCT_TRAINING, { migratedUserWelcomeModal: { timestamp: DateUtils.getDBTime(date.valueOf()), }, @@ -303,12 +303,12 @@ describe('ProductTrainingContextProvider', () => { it('should show lower priority tooltip when higher priority is dismissed', async () => { // When higher priority tooltip is dismissed - Onyx.merge(ONYXKEYS.NVP_ONBOARDING, {hasCompletedGuidedSetupFlow: true}); + void Onyx.merge(ONYXKEYS.NVP_ONBOARDING, {hasCompletedGuidedSetupFlow: true}); const date = new Date(); const highPriorityTooltip = CONST.PRODUCT_TRAINING_TOOLTIP_NAMES.SCAN_TEST_TOOLTIP_MANAGER; const lowPriorityTooltip = CONST.PRODUCT_TRAINING_TOOLTIP_NAMES.SCAN_TEST_TOOLTIP; - Onyx.merge(ONYXKEYS.NVP_DISMISSED_PRODUCT_TRAINING, { + void Onyx.merge(ONYXKEYS.NVP_DISMISSED_PRODUCT_TRAINING, { migratedUserWelcomeModal: { timestamp: DateUtils.getDBTime(date.valueOf()), }, @@ -334,9 +334,9 @@ describe('ProductTrainingContextProvider', () => { it('should transition to next priority tooltip when current is dismissed', async () => { // When starting with all tooltips visible - Onyx.merge(ONYXKEYS.NVP_ONBOARDING, {hasCompletedGuidedSetupFlow: true}); + void Onyx.merge(ONYXKEYS.NVP_ONBOARDING, {hasCompletedGuidedSetupFlow: true}); const date = new Date(); - Onyx.merge(ONYXKEYS.NVP_DISMISSED_PRODUCT_TRAINING, { + void Onyx.merge(ONYXKEYS.NVP_DISMISSED_PRODUCT_TRAINING, { migratedUserWelcomeModal: { timestamp: DateUtils.getDBTime(date.valueOf()), }, @@ -359,7 +359,7 @@ describe('ProductTrainingContextProvider', () => { expect(result.current.lower.shouldShowProductTrainingTooltip).toBe(false); // When dismissing higher priority tooltip - Onyx.merge(ONYXKEYS.NVP_DISMISSED_PRODUCT_TRAINING, { + void Onyx.merge(ONYXKEYS.NVP_DISMISSED_PRODUCT_TRAINING, { [highPriorityTooltip]: { timestamp: DateUtils.getDBTime(date.valueOf()), }, diff --git a/tests/unit/APITest.ts b/tests/unit/APITest.ts index 4de2b79a862c..fb9a4f418c2d 100644 --- a/tests/unit/APITest.ts +++ b/tests/unit/APITest.ts @@ -74,9 +74,9 @@ describe('APITests', () => { return Onyx.set(ONYXKEYS.NETWORK, {isOffline: true}) .then(() => { // When API Writes and Reads are called - API.write('mock command' as WriteCommand, {param1: 'value1'} as ApiRequestCommandParameters[WriteCommand]); + void API.write('mock command' as WriteCommand, {param1: 'value1'} as ApiRequestCommandParameters[WriteCommand]); API.read('mock command' as ReadCommand, {param2: 'value2'} as unknown as ApiRequestCommandParameters[ReadCommand]); - API.write('mock command' as WriteCommand, {param3: 'value3'} as ApiRequestCommandParameters[WriteCommand]); + void API.write('mock command' as WriteCommand, {param3: 'value3'} as ApiRequestCommandParameters[WriteCommand]); return waitForBatchedUpdates(); }) .then(() => { @@ -102,41 +102,39 @@ describe('APITests', () => { const xhr = jest.spyOn(HttpUtils, 'xhr').mockResolvedValue({jsonCode: CONST.JSON_CODE.SUCCESS}); // Given we have some requests made while we're offline - return ( - Onyx.multiSet({ - [ONYXKEYS.NETWORK]: {isOffline: true}, - [ONYXKEYS.CREDENTIALS]: {autoGeneratedLogin: 'test', autoGeneratedPassword: 'passwd'}, - [ONYXKEYS.SESSION]: {authToken: 'testToken'}, + return void Onyx.multiSet({ + [ONYXKEYS.NETWORK]: {isOffline: true}, + [ONYXKEYS.CREDENTIALS]: {autoGeneratedLogin: 'test', autoGeneratedPassword: 'passwd'}, + [ONYXKEYS.SESSION]: {authToken: 'testToken'}, + }) + .then(() => { + // When API Write commands are made + void API.write('mock command' as WriteCommand, {param1: 'value1'} as ApiRequestCommandParameters[WriteCommand]); + void API.write('mock command' as WriteCommand, {param2: 'value2'} as ApiRequestCommandParameters[WriteCommand]); + return waitForBatchedUpdates(); + }) + .then(() => { + const persisted = PersistedRequests.getAll(); + expect(persisted).toHaveLength(2); }) - .then(() => { - // When API Write commands are made - API.write('mock command' as WriteCommand, {param1: 'value1'} as ApiRequestCommandParameters[WriteCommand]); - API.write('mock command' as WriteCommand, {param2: 'value2'} as ApiRequestCommandParameters[WriteCommand]); - return waitForBatchedUpdates(); - }) - .then(() => { - const persisted = PersistedRequests.getAll(); - expect(persisted).toHaveLength(2); - }) - // When we resume connectivity - .then(() => Onyx.set(ONYXKEYS.NETWORK, {isOffline: false})) - .then(waitForBatchedUpdates) - .then(() => { - expect(NetworkStore.isOffline()).toBe(false); - expect(SequentialQueue.isRunning()).toBe(false); - - // Then `xhr` should be called with expected data, and the persisted queue should be empty - expect(xhr).toHaveBeenCalledTimes(2); - expect(xhr.mock.calls).toEqual([ - expect.arrayContaining(['mock command', expect.objectContaining({param1: 'value1'})]), - expect.arrayContaining(['mock command', expect.objectContaining({param2: 'value2'})]), - ]); - - const persisted = PersistedRequests.getAll(); - expect(persisted).toEqual([]); - }) - ); + // When we resume connectivity + .then(() => Onyx.set(ONYXKEYS.NETWORK, {isOffline: false})) + .then(waitForBatchedUpdates) + .then(() => { + expect(NetworkStore.isOffline()).toBe(false); + expect(SequentialQueue.isRunning()).toBe(false); + + // Then `xhr` should be called with expected data, and the persisted queue should be empty + expect(xhr).toHaveBeenCalledTimes(2); + expect(xhr.mock.calls).toEqual([ + expect.arrayContaining(['mock command', expect.objectContaining({param1: 'value1'})]), + expect.arrayContaining(['mock command', expect.objectContaining({param2: 'value2'})]), + ]); + + const persisted = PersistedRequests.getAll(); + expect(persisted).toEqual([]); + }); }); test('Write request should not be cleared until a backend response occurs', () => { @@ -159,54 +157,52 @@ describe('APITests', () => { }); // Given we have some requests made while we're offline - return ( - Onyx.set(ONYXKEYS.NETWORK, {isOffline: true}) - .then(() => { - // When API Write commands are made - API.write('mock command' as WriteCommand, {param1: 'value1'} as ApiRequestCommandParameters[WriteCommand]); - API.write('mock command' as WriteCommand, {param2: 'value2'} as ApiRequestCommandParameters[WriteCommand]); - return waitForBatchedUpdates(); - }) + return void Onyx.set(ONYXKEYS.NETWORK, {isOffline: true}) + .then(() => { + // When API Write commands are made + void API.write('mock command' as WriteCommand, {param1: 'value1'} as ApiRequestCommandParameters[WriteCommand]); + void API.write('mock command' as WriteCommand, {param2: 'value2'} as ApiRequestCommandParameters[WriteCommand]); + return waitForBatchedUpdates(); + }) - // When we resume connectivity - .then(() => Onyx.set(ONYXKEYS.NETWORK, {isOffline: false})) - .then(waitForBatchedUpdates) - .then(() => { - // Then requests should remain persisted until the xhr call is resolved - expect(PersistedRequests.getAll().length).toEqual(1); + // When we resume connectivity + .then(() => Onyx.set(ONYXKEYS.NETWORK, {isOffline: false})) + .then(waitForBatchedUpdates) + .then(() => { + // Then requests should remain persisted until the xhr call is resolved + expect(PersistedRequests.getAll().length).toEqual(1); - xhrCalls.at(0)?.resolve({jsonCode: CONST.JSON_CODE.SUCCESS}); - return waitForBatchedUpdates(); - }) - .then(waitForBatchedUpdates) - .then(() => { - expect(PersistedRequests.getAll().length).toEqual(0); - expect(PersistedRequests.getOngoingRequest()).toEqual(expect.objectContaining({command: 'mock command', data: expect.objectContaining({param2: 'value2'})})); + xhrCalls.at(0)?.resolve({jsonCode: CONST.JSON_CODE.SUCCESS}); + return waitForBatchedUpdates(); + }) + .then(waitForBatchedUpdates) + .then(() => { + expect(PersistedRequests.getAll().length).toEqual(0); + expect(PersistedRequests.getOngoingRequest()).toEqual(expect.objectContaining({command: 'mock command', data: expect.objectContaining({param2: 'value2'})})); - // When a request fails it should be retried - xhrCalls.at(1)?.reject(new Error(CONST.ERROR.FAILED_TO_FETCH)); - return waitForBatchedUpdates(); - }) - .then(() => { - // The ongoingRequest it is moving back to the persistedRequests queue - expect(PersistedRequests.getAll().length).toEqual(1); - expect(PersistedRequests.getAll()).toEqual([expect.objectContaining({command: 'mock command', data: expect.objectContaining({param2: 'value2'})})]); - // We need to advance past the request throttle back off timer because the request won't be retried until then - return new Promise((resolve) => { - setTimeout(resolve, CONST.NETWORK.MAX_RANDOM_RETRY_WAIT_TIME_MS); - }).then(waitForBatchedUpdates); - }) - .then(() => { - // A new promise is created after the back off timer - // Finally, after it succeeds the queue should be empty - xhrCalls.at(2)?.resolve({jsonCode: CONST.JSON_CODE.SUCCESS}); - return waitForBatchedUpdates(); - }) - .then(() => { - expect(PersistedRequests.getAll().length).toEqual(0); - expect(PersistedRequests.getOngoingRequest()).toBeNull(); - }) - ); + // When a request fails it should be retried + xhrCalls.at(1)?.reject(new Error(CONST.ERROR.FAILED_TO_FETCH)); + return waitForBatchedUpdates(); + }) + .then(() => { + // The ongoingRequest it is moving back to the persistedRequests queue + expect(PersistedRequests.getAll().length).toEqual(1); + expect(PersistedRequests.getAll()).toEqual([expect.objectContaining({command: 'mock command', data: expect.objectContaining({param2: 'value2'})})]); + // We need to advance past the request throttle back off timer because the request won't be retried until then + return new Promise((resolve) => { + setTimeout(resolve, CONST.NETWORK.MAX_RANDOM_RETRY_WAIT_TIME_MS); + }).then(waitForBatchedUpdates); + }) + .then(() => { + // A new promise is created after the back off timer + // Finally, after it succeeds the queue should be empty + xhrCalls.at(2)?.resolve({jsonCode: CONST.JSON_CODE.SUCCESS}); + return waitForBatchedUpdates(); + }) + .then(() => { + expect(PersistedRequests.getAll().length).toEqual(0); + expect(PersistedRequests.getOngoingRequest()).toBeNull(); + }); }); // Given a retry response create a mock and run some expectations for retrying requests @@ -223,51 +219,49 @@ describe('APITests', () => { global.fetch = jest.fn().mockResolvedValueOnce(response).mockResolvedValueOnce(response).mockResolvedValueOnce(successfulResponse); // Given we have a request made while we're offline - return ( - Onyx.set(ONYXKEYS.NETWORK, {isOffline: true}) - .then(() => { - // When API Write commands are made - API.write('mock command' as WriteCommand, {param1: 'value1'} as ApiRequestCommandParameters[WriteCommand]); - return waitForNetworkPromises(); - }) + return void Onyx.set(ONYXKEYS.NETWORK, {isOffline: true}) + .then(() => { + // When API Write commands are made + void API.write('mock command' as WriteCommand, {param1: 'value1'} as ApiRequestCommandParameters[WriteCommand]); + return waitForNetworkPromises(); + }) - // When we resume connectivity - .then(() => Onyx.set(ONYXKEYS.NETWORK, {isOffline: false})) - .then(waitForBatchedUpdates) - .then(() => { - // Then there has only been one request so far - expect(global.fetch).toHaveBeenCalledTimes(1); + // When we resume connectivity + .then(() => Onyx.set(ONYXKEYS.NETWORK, {isOffline: false})) + .then(waitForBatchedUpdates) + .then(() => { + // Then there has only been one request so far + expect(global.fetch).toHaveBeenCalledTimes(1); - // And we still have 1 persisted request since it failed - expect(PersistedRequests.getAll().length).toEqual(1); - expect(PersistedRequests.getAll()).toEqual([expect.objectContaining({command: 'mock command', data: expect.objectContaining({param1: 'value1'})})]); + // And we still have 1 persisted request since it failed + expect(PersistedRequests.getAll().length).toEqual(1); + expect(PersistedRequests.getAll()).toEqual([expect.objectContaining({command: 'mock command', data: expect.objectContaining({param1: 'value1'})})]); - // We let the SequentialQueue process again after its wait time - return new Promise((resolve) => { - setTimeout(resolve, sequentialQueueRequestThrottle.getLastRequestWaitTime()); - }); - }) - .then(() => { - // Then we have retried the failing request - expect(global.fetch).toHaveBeenCalledTimes(2); + // We let the SequentialQueue process again after its wait time + return new Promise((resolve) => { + setTimeout(resolve, sequentialQueueRequestThrottle.getLastRequestWaitTime()); + }); + }) + .then(() => { + // Then we have retried the failing request + expect(global.fetch).toHaveBeenCalledTimes(2); - // And we still have 1 persisted request since it failed - expect(PersistedRequests.getAll().length).toEqual(1); - expect(PersistedRequests.getAll()).toEqual([expect.objectContaining({command: 'mock command', data: expect.objectContaining({param1: 'value1'})})]); + // And we still have 1 persisted request since it failed + expect(PersistedRequests.getAll().length).toEqual(1); + expect(PersistedRequests.getAll()).toEqual([expect.objectContaining({command: 'mock command', data: expect.objectContaining({param1: 'value1'})})]); - // We let the SequentialQueue process again after its wait time - return new Promise((resolve) => { - setTimeout(resolve, sequentialQueueRequestThrottle.getLastRequestWaitTime()); - }).then(waitForBatchedUpdates); - }) - .then(() => { - // Then the request is retried again - expect(global.fetch).toHaveBeenCalledTimes(3); + // We let the SequentialQueue process again after its wait time + return new Promise((resolve) => { + setTimeout(resolve, sequentialQueueRequestThrottle.getLastRequestWaitTime()); + }).then(waitForBatchedUpdates); + }) + .then(() => { + // Then the request is retried again + expect(global.fetch).toHaveBeenCalledTimes(3); - // The request succeeds so the queue is empty - expect(PersistedRequests.getAll().length).toEqual(0); - }) - ); + // The request succeeds so the queue is empty + expect(PersistedRequests.getAll().length).toEqual(0); + }); }; test.each([CONST.HTTP_STATUS.INTERNAL_SERVER_ERROR, CONST.HTTP_STATUS.BAD_GATEWAY, CONST.HTTP_STATUS.GATEWAY_TIMEOUT, CONST.HTTP_STATUS.UNKNOWN_ERROR])( @@ -308,12 +302,12 @@ describe('APITests', () => { .mockResolvedValueOnce({jsonCode: CONST.JSON_CODE.SUCCESS}); // Original command return 200 // Given we have a request made while we're offline and we have credentials available to reauthenticate - Onyx.merge(ONYXKEYS.CREDENTIALS, {autoGeneratedLogin: 'test', autoGeneratedPassword: 'passwd'}); + void Onyx.merge(ONYXKEYS.CREDENTIALS, {autoGeneratedLogin: 'test', autoGeneratedPassword: 'passwd'}); return ( waitForBatchedUpdates() .then(() => Onyx.set(ONYXKEYS.NETWORK, {isOffline: true})) .then(() => { - API.write('Mock' as WriteCommand, {param1: 'value1'} as ApiRequestCommandParameters[WriteCommand]); + void API.write('Mock' as WriteCommand, {param1: 'value1'} as ApiRequestCommandParameters[WriteCommand]); return waitForBatchedUpdates(); }) @@ -346,13 +340,13 @@ describe('APITests', () => { }) .then(() => { // When we queue 6 persistable commands and one not persistable - API.write('MockCommand' as WriteCommand, {content: 'value1'} as ApiRequestCommandParameters[WriteCommand]); - API.write('MockCommand' as WriteCommand, {content: 'value2'} as ApiRequestCommandParameters[WriteCommand]); - API.write('MockCommand' as WriteCommand, {content: 'value3'} as ApiRequestCommandParameters[WriteCommand]); + void API.write('MockCommand' as WriteCommand, {content: 'value1'} as ApiRequestCommandParameters[WriteCommand]); + void API.write('MockCommand' as WriteCommand, {content: 'value2'} as ApiRequestCommandParameters[WriteCommand]); + void API.write('MockCommand' as WriteCommand, {content: 'value3'} as ApiRequestCommandParameters[WriteCommand]); API.read('MockCommand' as ReadCommand, {content: 'not-persisted'} as unknown as ApiRequestCommandParameters[ReadCommand]); - API.write('MockCommand' as WriteCommand, {content: 'value4'} as ApiRequestCommandParameters[WriteCommand]); - API.write('MockCommand' as WriteCommand, {content: 'value5'} as ApiRequestCommandParameters[WriteCommand]); - API.write('MockCommand' as WriteCommand, {content: 'value6'} as ApiRequestCommandParameters[WriteCommand]); + void API.write('MockCommand' as WriteCommand, {content: 'value4'} as ApiRequestCommandParameters[WriteCommand]); + void API.write('MockCommand' as WriteCommand, {content: 'value5'} as ApiRequestCommandParameters[WriteCommand]); + void API.write('MockCommand' as WriteCommand, {content: 'value6'} as ApiRequestCommandParameters[WriteCommand]); return waitForBatchedUpdates(); }) @@ -383,12 +377,12 @@ describe('APITests', () => { }) .then(() => { // When we queue 6 persistable commands - API.write('MockCommand' as WriteCommand, {content: 'value1'} as ApiRequestCommandParameters[WriteCommand]); - API.write('MockCommand' as WriteCommand, {content: 'value2'} as ApiRequestCommandParameters[WriteCommand]); - API.write('MockCommand' as WriteCommand, {content: 'value3'} as ApiRequestCommandParameters[WriteCommand]); - API.write('MockCommand' as WriteCommand, {content: 'value4'} as ApiRequestCommandParameters[WriteCommand]); - API.write('MockCommand' as WriteCommand, {content: 'value5'} as ApiRequestCommandParameters[WriteCommand]); - API.write('MockCommand' as WriteCommand, {content: 'value6'} as ApiRequestCommandParameters[WriteCommand]); + void API.write('MockCommand' as WriteCommand, {content: 'value1'} as ApiRequestCommandParameters[WriteCommand]); + void API.write('MockCommand' as WriteCommand, {content: 'value2'} as ApiRequestCommandParameters[WriteCommand]); + void API.write('MockCommand' as WriteCommand, {content: 'value3'} as ApiRequestCommandParameters[WriteCommand]); + void API.write('MockCommand' as WriteCommand, {content: 'value4'} as ApiRequestCommandParameters[WriteCommand]); + void API.write('MockCommand' as WriteCommand, {content: 'value5'} as ApiRequestCommandParameters[WriteCommand]); + void API.write('MockCommand' as WriteCommand, {content: 'value6'} as ApiRequestCommandParameters[WriteCommand]); return waitForBatchedUpdates(); }) .then(() => Onyx.set(ONYXKEYS.NETWORK, {isOffline: false})) @@ -426,7 +420,7 @@ describe('APITests', () => { }) .then(() => { // When we queue both non-persistable and persistable commands that will trigger reauthentication and go offline at the same time - API.makeRequestWithSideEffects('AuthenticatePusher', { + void API.makeRequestWithSideEffects('AuthenticatePusher', { // eslint-disable-next-line @typescript-eslint/naming-convention socket_id: 'socket_id', // eslint-disable-next-line @typescript-eslint/naming-convention @@ -435,13 +429,13 @@ describe('APITests', () => { forceNetworkRequest: false, }); - Onyx.set(ONYXKEYS.NETWORK, {isOffline: true}); + void Onyx.set(ONYXKEYS.NETWORK, {isOffline: true}); expect(NetworkStore.isOffline()).toBe(false); expect(NetworkStore.isAuthenticating()).toBe(false); return waitForBatchedUpdates(); }) .then(() => { - API.write('MockCommand' as WriteCommand, {}); + void API.write('MockCommand' as WriteCommand, {}); expect(PersistedRequests.getAll().length).toBe(1); expect(NetworkStore.isOffline()).toBe(true); expect(SequentialQueue.isRunning()).toBe(false); @@ -453,7 +447,7 @@ describe('APITests', () => { waitForBatchedUpdates(); // Come back from offline to trigger the sequential queue flush - Onyx.set(ONYXKEYS.NETWORK, {isOffline: false}); + void Onyx.set(ONYXKEYS.NETWORK, {isOffline: false}); }) .then(() => { // When we wait for the sequential queue to finish @@ -510,7 +504,7 @@ describe('APITests', () => { NetworkStore.resetHasReadRequiredDataFromStorage(); // And queue a Write request while offline - API.write('MockCommand' as WriteCommand, {content: 'value1'} as ApiRequestCommandParameters[WriteCommand]); + void API.write('MockCommand' as WriteCommand, {content: 'value1'} as ApiRequestCommandParameters[WriteCommand]); // Then we should expect the request to get persisted expect(PersistedRequests.getAll().length).toBe(1); @@ -546,9 +540,9 @@ describe('APITests', () => { expect(NetworkStore.isOffline()).toBe(false); // WHEN we make a request that should be retried, one that should not, and another that should - API.write('MockCommandOne' as WriteCommand, {}); + void API.write('MockCommandOne' as WriteCommand, {}); API.read('MockCommandTwo' as ReadCommand, null); - API.write('MockCommandThree' as WriteCommand, {}); + void API.write('MockCommandThree' as WriteCommand, {}); // THEN the retryable requests should immediately be added to the persisted requests expect(PersistedRequests.getAll().length).toBe(2); @@ -592,9 +586,9 @@ describe('APITests', () => { }) .then(() => { // When we queue 3 persistable commands and two of them are the same - API.write('MockCommand' as WriteCommand, {content: 'value1'} as ApiRequestCommandParameters[WriteCommand]); - API.write('MockCommand' as WriteCommand, {content: 'value2'} as ApiRequestCommandParameters[WriteCommand]); - API.write('MockCommand' as WriteCommand, {content: 'value1'} as ApiRequestCommandParameters[WriteCommand]); + void API.write('MockCommand' as WriteCommand, {content: 'value1'} as ApiRequestCommandParameters[WriteCommand]); + void API.write('MockCommand' as WriteCommand, {content: 'value2'} as ApiRequestCommandParameters[WriteCommand]); + void API.write('MockCommand' as WriteCommand, {content: 'value1'} as ApiRequestCommandParameters[WriteCommand]); return waitForBatchedUpdates(); }) @@ -612,8 +606,8 @@ describe('APITests', () => { test('Read request should not stuck when SequentialQueue is paused and resumed', async () => { // Given 2 WRITE requests and 1 READ request where the first write request pauses the SequentialQueue const xhr = jest.spyOn(HttpUtils, 'xhr').mockResolvedValueOnce({previousUpdateID: 1}); - API.write('MockWriteCommandOne' as WriteCommand, {}); - API.write('MockWriteCommandTwo' as WriteCommand, {}); + void API.write('MockWriteCommandOne' as WriteCommand, {}); + void API.write('MockWriteCommandTwo' as WriteCommand, {}); API.read('MockReadCommand' as ReadCommand, null); await waitForBatchedUpdates(); @@ -637,9 +631,9 @@ describe('APITests', () => { }) .then(() => { // When we queue 3 duplicate persistable commands - API.writeWithNoDuplicatesConflictAction('MockCommand' as WriteCommand, {content: 'value1'} as ApiRequestCommandParameters[WriteCommand]); - API.writeWithNoDuplicatesConflictAction('MockCommand' as WriteCommand, {content: 'value2'} as ApiRequestCommandParameters[WriteCommand]); - API.writeWithNoDuplicatesConflictAction('MockCommand' as WriteCommand, {content: 'value3'} as ApiRequestCommandParameters[WriteCommand]); + void API.writeWithNoDuplicatesConflictAction('MockCommand' as WriteCommand, {content: 'value1'} as ApiRequestCommandParameters[WriteCommand]); + void API.writeWithNoDuplicatesConflictAction('MockCommand' as WriteCommand, {content: 'value2'} as ApiRequestCommandParameters[WriteCommand]); + void API.writeWithNoDuplicatesConflictAction('MockCommand' as WriteCommand, {content: 'value3'} as ApiRequestCommandParameters[WriteCommand]); return waitForBatchedUpdates(); }) .then(() => Onyx.set(ONYXKEYS.NETWORK, {isOffline: false})) @@ -660,9 +654,9 @@ describe('APITests', () => { }) .then(() => { // When we queue 3 different persistable commands - API.writeWithNoDuplicatesConflictAction('MockCommandOne' as WriteCommand, {content: 'value1'} as ApiRequestCommandParameters[WriteCommand]); - API.writeWithNoDuplicatesConflictAction('MockCommandTwo' as WriteCommand, {content: 'value2'} as ApiRequestCommandParameters[WriteCommand]); - API.writeWithNoDuplicatesConflictAction('MockCommandThree' as WriteCommand, {content: 'value3'} as ApiRequestCommandParameters[WriteCommand]); + void API.writeWithNoDuplicatesConflictAction('MockCommandOne' as WriteCommand, {content: 'value1'} as ApiRequestCommandParameters[WriteCommand]); + void API.writeWithNoDuplicatesConflictAction('MockCommandTwo' as WriteCommand, {content: 'value2'} as ApiRequestCommandParameters[WriteCommand]); + void API.writeWithNoDuplicatesConflictAction('MockCommandThree' as WriteCommand, {content: 'value3'} as ApiRequestCommandParameters[WriteCommand]); return waitForBatchedUpdates(); }) .then(() => Onyx.set(ONYXKEYS.NETWORK, {isOffline: false})) @@ -685,15 +679,15 @@ describe('APITests', () => { }) .then(() => { // When we queue 3 duplicate persistable commands with same policyID and different enabled values - API.writeWithNoDuplicatesEnableFeatureConflicts( + void API.writeWithNoDuplicatesEnableFeatureConflicts( 'MockCommand' as EnablePolicyFeatureCommand, {policyID: '1', enabled: true} as ApiRequestCommandParameters[EnablePolicyFeatureCommand], ); - API.writeWithNoDuplicatesEnableFeatureConflicts( + void API.writeWithNoDuplicatesEnableFeatureConflicts( 'MockCommand' as EnablePolicyFeatureCommand, {policyID: '1', enabled: false} as ApiRequestCommandParameters[EnablePolicyFeatureCommand], ); - API.writeWithNoDuplicatesEnableFeatureConflicts( + void API.writeWithNoDuplicatesEnableFeatureConflicts( 'MockCommand' as EnablePolicyFeatureCommand, {policyID: '1', enabled: true} as ApiRequestCommandParameters[EnablePolicyFeatureCommand], ); @@ -717,11 +711,11 @@ describe('APITests', () => { }) .then(() => { // When we queue 2 duplicate persistable commands with same policyID and true and false enabled values - API.writeWithNoDuplicatesEnableFeatureConflicts( + void API.writeWithNoDuplicatesEnableFeatureConflicts( 'MockCommand' as EnablePolicyFeatureCommand, {policyID: '1', enabled: true} as ApiRequestCommandParameters[EnablePolicyFeatureCommand], ); - API.writeWithNoDuplicatesEnableFeatureConflicts( + void API.writeWithNoDuplicatesEnableFeatureConflicts( 'MockCommand' as EnablePolicyFeatureCommand, {policyID: '1', enabled: false} as ApiRequestCommandParameters[EnablePolicyFeatureCommand], ); @@ -744,15 +738,15 @@ describe('APITests', () => { }) .then(() => { // When we queue 3 different persistable commands with different policyIDs - API.writeWithNoDuplicatesEnableFeatureConflicts( + void API.writeWithNoDuplicatesEnableFeatureConflicts( 'MockCommand' as EnablePolicyFeatureCommand, {policyID: '1', enabled: true} as ApiRequestCommandParameters[EnablePolicyFeatureCommand], ); - API.writeWithNoDuplicatesEnableFeatureConflicts( + void API.writeWithNoDuplicatesEnableFeatureConflicts( 'MockCommand' as EnablePolicyFeatureCommand, {policyID: '2', enabled: false} as ApiRequestCommandParameters[EnablePolicyFeatureCommand], ); - API.writeWithNoDuplicatesEnableFeatureConflicts( + void API.writeWithNoDuplicatesEnableFeatureConflicts( 'MockCommand' as EnablePolicyFeatureCommand, {policyID: '3', enabled: true} as ApiRequestCommandParameters[EnablePolicyFeatureCommand], ); @@ -778,15 +772,15 @@ describe('APITests', () => { }) .then(() => { // When we queue 3 different persistable commands with only 2 policyIDs - API.writeWithNoDuplicatesEnableFeatureConflicts( + void API.writeWithNoDuplicatesEnableFeatureConflicts( 'MockCommand' as EnablePolicyFeatureCommand, {policyID: '1', enabled: true} as ApiRequestCommandParameters[EnablePolicyFeatureCommand], ); - API.writeWithNoDuplicatesEnableFeatureConflicts( + void API.writeWithNoDuplicatesEnableFeatureConflicts( 'MockCommand' as EnablePolicyFeatureCommand, {policyID: '2', enabled: false} as ApiRequestCommandParameters[EnablePolicyFeatureCommand], ); - API.writeWithNoDuplicatesEnableFeatureConflicts( + void API.writeWithNoDuplicatesEnableFeatureConflicts( 'MockCommand' as EnablePolicyFeatureCommand, {policyID: '1', enabled: false} as ApiRequestCommandParameters[EnablePolicyFeatureCommand], ); diff --git a/tests/unit/ContactMethodDetailsPageTest.tsx b/tests/unit/ContactMethodDetailsPageTest.tsx index 42ef271cc88d..a3a8b03edd69 100644 --- a/tests/unit/ContactMethodDetailsPageTest.tsx +++ b/tests/unit/ContactMethodDetailsPageTest.tsx @@ -64,7 +64,7 @@ describe('ContactMethodDetailsPage', () => { it('should not call resetContactMethodValidateCodeSentState when we got a delete pending field', async () => { // Given a login list with a validated contact method - Onyx.merge(ONYXKEYS.LOGIN_LIST, mockLoginList); + void Onyx.merge(ONYXKEYS.LOGIN_LIST, mockLoginList); await waitForBatchedUpdates(); // Given the page is rendered @@ -75,9 +75,9 @@ describe('ContactMethodDetailsPage', () => { await waitForBatchedUpdatesWithAct(); // When the deletion is successful - mockFetch?.succeed(); + void mockFetch?.succeed(); await waitForBatchedUpdates(); - mockFetch?.resume(); + void mockFetch?.resume(); await waitForBatchedUpdates(); // Then resetContactMethodValidateCodeSentState should not be called @@ -86,7 +86,7 @@ describe('ContactMethodDetailsPage', () => { it('should not call resetContactMethodValidateCodeSentState when the login data has no partnerUserID', async () => { // Given a login list with a contact method that has no partnerUserID - Onyx.merge(ONYXKEYS.LOGIN_LIST, { + void Onyx.merge(ONYXKEYS.LOGIN_LIST, { [fakeEmail]: { partnerName: 'expensify.com', partnerUserID: '', diff --git a/tests/unit/DateUtilsTest.ts b/tests/unit/DateUtilsTest.ts index e300f2cb440e..4ab77c973327 100644 --- a/tests/unit/DateUtilsTest.ts +++ b/tests/unit/DateUtilsTest.ts @@ -45,7 +45,7 @@ describe('DateUtils', () => { afterEach(() => { jest.restoreAllMocks(); jest.useRealTimers(); - Onyx.clear(); + void Onyx.clear(); }); const datetime = '2022-11-07 00:00:00'; @@ -104,7 +104,7 @@ describe('DateUtils', () => { resolvedOptions: () => ({timeZone: 'America/Chicago'}), }) as Intl.DateTimeFormat, ); - Onyx.set(ONYXKEYS.PERSONAL_DETAILS_LIST, {'999': {accountID: 999, timezone: {selected: 'Europe/London', automatic: true}}}); + void Onyx.set(ONYXKEYS.PERSONAL_DETAILS_LIST, {'999': {accountID: 999, timezone: {selected: 'Europe/London', automatic: true}}}); await waitForBatchedUpdates(); const result = DateUtils.getCurrentTimezone({selected: 'Europe/London', automatic: true}); expect(result).toEqual({ @@ -120,7 +120,7 @@ describe('DateUtils', () => { resolvedOptions: () => ({timeZone: UTC}), }) as Intl.DateTimeFormat, ); - Onyx.set(ONYXKEYS.PERSONAL_DETAILS_LIST, {'999': {accountID: 999, timezone: {selected: 'Europe/London', automatic: true}}}); + void Onyx.set(ONYXKEYS.PERSONAL_DETAILS_LIST, {'999': {accountID: 999, timezone: {selected: 'Europe/London', automatic: true}}}); await waitForBatchedUpdates(); const result = DateUtils.getCurrentTimezone({selected: 'Europe/London', automatic: true}); expect(result).toEqual({ diff --git a/tests/unit/DebugUtilsTest.ts b/tests/unit/DebugUtilsTest.ts index c3346c726922..de8d2de0981d 100644 --- a/tests/unit/DebugUtilsTest.ts +++ b/tests/unit/DebugUtilsTest.ts @@ -732,7 +732,7 @@ describe('DebugUtils', () => { }); }); beforeEach(() => { - Onyx.clear(); + void Onyx.clear(); }); it('returns null when report is not defined', () => { const reason = DebugUtils.getReasonForShowingRowInLHN({report: undefined, chatReport: chatReportR14932, doesReportHaveViolations: false}); @@ -956,7 +956,7 @@ describe('DebugUtils', () => { }); }); beforeEach(() => { - Onyx.clear(); + void Onyx.clear(); }); it('returns undefined reason when report is not defined', () => { const {reason} = DebugUtils.getReasonAndReportActionForGBRInLHNRow(undefined) ?? {}; @@ -1132,7 +1132,7 @@ describe('DebugUtils', () => { }); describe('reportAction', () => { beforeEach(() => { - Onyx.clear(); + void Onyx.clear(); }); it('returns undefined when report has no RBR', () => { const {reportAction} = diff --git a/tests/unit/LocalePhoneNumberTest.ts b/tests/unit/LocalePhoneNumberTest.ts index 99f53e7f980a..d2b4b8092d4c 100644 --- a/tests/unit/LocalePhoneNumberTest.ts +++ b/tests/unit/LocalePhoneNumberTest.ts @@ -16,11 +16,12 @@ describe('LocalePhoneNumber utils', () => { ); describe('formatPhoneNumber function', () => { - beforeEach(() => - Onyx.multiSet({ - [ONYXKEYS.SESSION]: {email: 'current@user.com'}, - [ONYXKEYS.COUNTRY_CODE]: 1, - }).then(waitForBatchedUpdates), + beforeEach( + () => + void Onyx.multiSet({ + [ONYXKEYS.SESSION]: {email: 'current@user.com'}, + [ONYXKEYS.COUNTRY_CODE]: 1, + }).then(waitForBatchedUpdates), ); afterEach(() => Onyx.clear()); diff --git a/tests/unit/LoginUtilsTest.ts b/tests/unit/LoginUtilsTest.ts index 3b0d788d6591..3253fde60026 100644 --- a/tests/unit/LoginUtilsTest.ts +++ b/tests/unit/LoginUtilsTest.ts @@ -16,7 +16,7 @@ describe('LoginUtils', () => { afterEach(() => { jest.useRealTimers(); - Onyx.clear(); + void Onyx.clear(); }); describe('getPhoneNumberWithoutSpecialChars', () => { it('Should return valid phone number', () => { diff --git a/tests/unit/MigrationTest.ts b/tests/unit/MigrationTest.ts index f184d2c40e2e..7431ca347c4b 100644 --- a/tests/unit/MigrationTest.ts +++ b/tests/unit/MigrationTest.ts @@ -22,7 +22,7 @@ describe('Migrations', () => { beforeEach(() => { jest.clearAllMocks(); - Onyx.clear(); + void Onyx.clear(); return waitForBatchedUpdates(); }); diff --git a/tests/unit/NetworkTest.tsx b/tests/unit/NetworkTest.tsx index 6eb87f9cdb2f..beb4eae29f4d 100644 --- a/tests/unit/NetworkTest.tsx +++ b/tests/unit/NetworkTest.tsx @@ -283,8 +283,8 @@ describe('NetworkTests', () => { expect(spyHttpUtilsXhr).not.toHaveBeenCalled(); // Once credentials are set and we wait for promises to resolve - Onyx.merge(ONYXKEYS.CREDENTIALS, {login: 'test-login'}); - Onyx.merge(ONYXKEYS.SESSION, {authToken: 'test-auth-token'}); + void Onyx.merge(ONYXKEYS.CREDENTIALS, {login: 'test-login'}); + void Onyx.merge(ONYXKEYS.SESSION, {authToken: 'test-auth-token'}); return waitForBatchedUpdates().then(() => { // Then we should expect the request to have been made since the network is now ready expect(spyHttpUtilsXhr).not.toHaveBeenCalled(); @@ -294,7 +294,7 @@ describe('NetworkTests', () => { test('Non-retryable request will not be retried if connection is lost in flight', () => { // Given a xhr mock that will fail as if network connection dropped const xhr = jest.spyOn(HttpUtils, 'xhr').mockImplementationOnce(() => { - Onyx.merge(ONYXKEYS.NETWORK, {isOffline: true}); + void Onyx.merge(ONYXKEYS.NETWORK, {isOffline: true}); return Promise.reject(new Error(CONST.ERROR.FAILED_TO_FETCH)); }); @@ -304,7 +304,7 @@ describe('NetworkTests', () => { return waitForBatchedUpdates() .then(() => { // When network connection is recovered - Onyx.merge(ONYXKEYS.NETWORK, {isOffline: false}); + void Onyx.merge(ONYXKEYS.NETWORK, {isOffline: false}); return waitForBatchedUpdates(); }) .then(() => { @@ -429,7 +429,7 @@ describe('NetworkTests', () => { const logSpy = jest.spyOn(Log, 'info'); // Given tracked connection changes started at least an hour ago - Onyx.merge(ONYXKEYS.NETWORK, {connectionChanges: {amount: 5, startTime: dateSubtract(new Date(), {hours: 1}).getTime()}}); + void Onyx.merge(ONYXKEYS.NETWORK, {connectionChanges: {amount: 5, startTime: dateSubtract(new Date(), {hours: 1}).getTime()}}); await waitForBatchedUpdates(); // When the connection is changed one more time diff --git a/tests/unit/NextStepUtilsTest.ts b/tests/unit/NextStepUtilsTest.ts index 74c8828143a6..304eb88e6636 100644 --- a/tests/unit/NextStepUtilsTest.ts +++ b/tests/unit/NextStepUtilsTest.ts @@ -43,7 +43,7 @@ describe('libs/NextStepUtils', () => { beforeAll(() => { const policyCollectionDataSet = toCollectionDataSet(ONYXKEYS.COLLECTION.POLICY, [policy], (item) => item.id); - Onyx.multiSet({ + void Onyx.multiSet({ [ONYXKEYS.SESSION]: {email: currentUserEmail, accountID: currentUserAccountID}, [ONYXKEYS.PERSONAL_DETAILS_LIST]: { [strangeAccountID]: { @@ -72,7 +72,7 @@ describe('libs/NextStepUtils', () => { optimisticNextStep.icon = CONST.NEXT_STEP.ICONS.HOURGLASS; optimisticNextStep.message = []; - Onyx.merge(`${ONYXKEYS.COLLECTION.POLICY}${policyID}`, policy).then(waitForBatchedUpdates); + void Onyx.merge(`${ONYXKEYS.COLLECTION.POLICY}${policyID}`, policy).then(waitForBatchedUpdates); }); describe('it generates and optimistic nextStep once a report has been created', () => { @@ -513,7 +513,7 @@ describe('libs/NextStepUtils', () => { expect(result).toMatchObject(optimisticNextStep); // restore to previous state - Onyx.merge(`${ONYXKEYS.COLLECTION.POLICY}${policyID}`, { + void Onyx.merge(`${ONYXKEYS.COLLECTION.POLICY}${policyID}`, { achAccount: null, }); }); diff --git a/tests/unit/OnyxUpdateManagerTest.ts b/tests/unit/OnyxUpdateManagerTest.ts index a5b620b62ce7..14ba4adcb01b 100644 --- a/tests/unit/OnyxUpdateManagerTest.ts +++ b/tests/unit/OnyxUpdateManagerTest.ts @@ -68,9 +68,9 @@ describe('OnyxUpdateManager', () => { }); it('should fetch missing Onyx updates once, defer updates and apply after missing updates', () => { - OnyxUpdateManager.handleMissingOnyxUpdates(update3); - OnyxUpdateManager.handleMissingOnyxUpdates(update4); - OnyxUpdateManager.handleMissingOnyxUpdates(update5); + void OnyxUpdateManager.handleMissingOnyxUpdates(update3); + void OnyxUpdateManager.handleMissingOnyxUpdates(update4); + void OnyxUpdateManager.handleMissingOnyxUpdates(update5); return OnyxUpdateManager.queryPromise.then(() => { // After all missing and deferred updates have been applied, the lastUpdateIDAppliedToClient should be 6. @@ -99,9 +99,9 @@ describe('OnyxUpdateManager', () => { }); it('should only apply deferred updates that are newer than the last locally applied update (pending deferred updates)', async () => { - OnyxUpdateManager.handleMissingOnyxUpdates(update4); - OnyxUpdateManager.handleMissingOnyxUpdates(update5); - OnyxUpdateManager.handleMissingOnyxUpdates(update6); + void OnyxUpdateManager.handleMissingOnyxUpdates(update4); + void OnyxUpdateManager.handleMissingOnyxUpdates(update5); + void OnyxUpdateManager.handleMissingOnyxUpdates(update6); OnyxUpdateManagerUtils.mockValues.beforeValidateAndApplyDeferredUpdates = async () => { // We manually update the lastUpdateIDAppliedToClient to 5, to simulate local updates being applied, @@ -142,9 +142,9 @@ describe('OnyxUpdateManager', () => { }); it('should re-fetch missing updates if the deferred updates have a gap', async () => { - OnyxUpdateManager.handleMissingOnyxUpdates(update3); - OnyxUpdateManager.handleMissingOnyxUpdates(update5); - OnyxUpdateManager.handleMissingOnyxUpdates(update6); + void OnyxUpdateManager.handleMissingOnyxUpdates(update3); + void OnyxUpdateManager.handleMissingOnyxUpdates(update5); + void OnyxUpdateManager.handleMissingOnyxUpdates(update6); return OnyxUpdateManager.queryPromise.then(() => { // After all missing and deferred updates have been applied, the lastUpdateIDAppliedToClient should be 6. @@ -183,10 +183,10 @@ describe('OnyxUpdateManager', () => { }); it('should re-fetch missing deferred updates only once per batch', async () => { - OnyxUpdateManager.handleMissingOnyxUpdates(update3); - OnyxUpdateManager.handleMissingOnyxUpdates(update4); - OnyxUpdateManager.handleMissingOnyxUpdates(update6); - OnyxUpdateManager.handleMissingOnyxUpdates(update8); + void OnyxUpdateManager.handleMissingOnyxUpdates(update3); + void OnyxUpdateManager.handleMissingOnyxUpdates(update4); + void OnyxUpdateManager.handleMissingOnyxUpdates(update6); + void OnyxUpdateManager.handleMissingOnyxUpdates(update8); return OnyxUpdateManager.queryPromise.then(() => { // After all missing and deferred updates have been applied, the lastUpdateIDAppliedToClient should be 6. @@ -221,10 +221,10 @@ describe('OnyxUpdateManager', () => { }); it('should not re-fetch missing updates if the lastUpdateIDFromClient has been updated', async () => { - OnyxUpdateManager.handleMissingOnyxUpdates(update3); - OnyxUpdateManager.handleMissingOnyxUpdates(update5); - OnyxUpdateManager.handleMissingOnyxUpdates(update6); - OnyxUpdateManager.handleMissingOnyxUpdates(update7); + void OnyxUpdateManager.handleMissingOnyxUpdates(update3); + void OnyxUpdateManager.handleMissingOnyxUpdates(update5); + void OnyxUpdateManager.handleMissingOnyxUpdates(update6); + void OnyxUpdateManager.handleMissingOnyxUpdates(update7); ApplyUpdates.mockValues.beforeApplyUpdates = async () => { // We manually update the lastUpdateIDAppliedToClient to 5, to simulate local updates being applied, @@ -268,8 +268,8 @@ describe('OnyxUpdateManager', () => { }); it('should re-fetch missing updates if the lastUpdateIDFromClient has increased, but there are still gaps after the locally applied update', async () => { - OnyxUpdateManager.handleMissingOnyxUpdates(update3); - OnyxUpdateManager.handleMissingOnyxUpdates(update7); + void OnyxUpdateManager.handleMissingOnyxUpdates(update3); + void OnyxUpdateManager.handleMissingOnyxUpdates(update7); ApplyUpdates.mockValues.beforeApplyUpdates = async () => { // We manually update the lastUpdateIDAppliedToClient to 4, to simulate local updates being applied, @@ -318,8 +318,8 @@ describe('OnyxUpdateManager', () => { }); it('should only fetch missing updates that are not outdated (older than already locally applied update)', () => { - OnyxUpdateManager.handleMissingOnyxUpdates(offsetUpdate3); - OnyxUpdateManager.handleMissingOnyxUpdates(update4); + void OnyxUpdateManager.handleMissingOnyxUpdates(offsetUpdate3); + void OnyxUpdateManager.handleMissingOnyxUpdates(update4); return OnyxUpdateManager.queryPromise.then(() => { // After all missing and deferred updates have been applied, the lastUpdateIDAppliedToClient should be 4. @@ -350,7 +350,7 @@ describe('OnyxUpdateManager', () => { it('should fetch a single pending update if `hasPendingOnyxUpdates flag is true`', () => { App.mockValues.missingOnyxUpdatesToBeApplied = [update2]; - OnyxUpdateManager.handleMissingOnyxUpdates(pendingUpdateUpTo2); + void OnyxUpdateManager.handleMissingOnyxUpdates(pendingUpdateUpTo2); return OnyxUpdateManager.queryPromise.then(() => { // After all the pending update has been applied, the lastUpdateIDAppliedToClient should be 2. @@ -376,7 +376,7 @@ describe('OnyxUpdateManager', () => { it('should fetch multiple pending updates if `hasPendingOnyxUpdates flag is true`', () => { App.mockValues.missingOnyxUpdatesToBeApplied = [update2, update3]; - OnyxUpdateManager.handleMissingOnyxUpdates(pendingUpdateUpTo3); + void OnyxUpdateManager.handleMissingOnyxUpdates(pendingUpdateUpTo3); return OnyxUpdateManager.queryPromise.then(() => { // After all the pending update has been applied, the lastUpdateIDAppliedToClient should be 3. @@ -402,8 +402,8 @@ describe('OnyxUpdateManager', () => { it('should apply deferred updates after fetching pending updates', () => { App.mockValues.missingOnyxUpdatesToBeApplied = [update2, update3]; - OnyxUpdateManager.handleMissingOnyxUpdates(pendingUpdateUpTo3); - OnyxUpdateManager.handleMissingOnyxUpdates(update4); + void OnyxUpdateManager.handleMissingOnyxUpdates(pendingUpdateUpTo3); + void OnyxUpdateManager.handleMissingOnyxUpdates(update4); return OnyxUpdateManager.queryPromise.then(() => { // After all missing and deferred updates have been applied, the lastUpdateIDAppliedToClient should be 4. diff --git a/tests/unit/OptionsListUtilsTest.tsx b/tests/unit/OptionsListUtilsTest.tsx index 106351717887..b9a40d583057 100644 --- a/tests/unit/OptionsListUtilsTest.tsx +++ b/tests/unit/OptionsListUtilsTest.tsx @@ -822,13 +822,14 @@ describe('OptionsListUtils', () => { it('should exclude Manager McTest from results if user dismissed the tooltip', () => { return waitForBatchedUpdates() - .then(() => - // Given that the user has dismissed the tooltip - Onyx.set(ONYXKEYS.NVP_DISMISSED_PRODUCT_TRAINING, { - [CONST.PRODUCT_TRAINING_TOOLTIP_NAMES.SCAN_TEST_TOOLTIP]: { - timestamp: DateUtils.getDBTime(new Date().valueOf()), - }, - }), + .then( + () => + // Given that the user has dismissed the tooltip + void Onyx.set(ONYXKEYS.NVP_DISMISSED_PRODUCT_TRAINING, { + [CONST.PRODUCT_TRAINING_TOOLTIP_NAMES.SCAN_TEST_TOOLTIP]: { + timestamp: DateUtils.getDBTime(new Date().valueOf()), + }, + }), ) .then(() => { // When we call getValidOptions() diff --git a/tests/unit/PerDiemRequestUtilsTest.ts b/tests/unit/PerDiemRequestUtilsTest.ts index e6d6b3f94138..7cf856996e78 100644 --- a/tests/unit/PerDiemRequestUtilsTest.ts +++ b/tests/unit/PerDiemRequestUtilsTest.ts @@ -28,7 +28,7 @@ describe('PerDiemRequestUtils', () => { ); beforeEach(() => { - Onyx.clear(); + void Onyx.clear(); }); it('getDestinationListSections()', () => { diff --git a/tests/unit/PersistedRequests.ts b/tests/unit/PersistedRequests.ts index 1c1b3c552c15..d555c33c1b8e 100644 --- a/tests/unit/PersistedRequests.ts +++ b/tests/unit/PersistedRequests.ts @@ -27,7 +27,7 @@ beforeEach(() => { afterEach(() => { PersistedRequests.clear(); - Onyx.clear(); + void Onyx.clear(); }); describe('PersistedRequests', () => { diff --git a/tests/unit/PolicyUtilsTest.ts b/tests/unit/PolicyUtilsTest.ts index 21a1f484b300..2ae206d117f2 100644 --- a/tests/unit/PolicyUtilsTest.ts +++ b/tests/unit/PolicyUtilsTest.ts @@ -283,7 +283,7 @@ describe('PolicyUtils', () => { describe('getSubmitToAccountID', () => { beforeEach(() => { wrapOnyxWithWaitForBatchedUpdates(Onyx); - Onyx.set(ONYXKEYS.PERSONAL_DETAILS_LIST, personalDetails); + void Onyx.set(ONYXKEYS.PERSONAL_DETAILS_LIST, personalDetails); }); afterEach(async () => { await Onyx.clear(); @@ -575,7 +575,7 @@ describe('PolicyUtils', () => { describe('getManagerAccountID', () => { beforeEach(() => { wrapOnyxWithWaitForBatchedUpdates(Onyx); - Onyx.set(ONYXKEYS.PERSONAL_DETAILS_LIST, personalDetails); + void Onyx.set(ONYXKEYS.PERSONAL_DETAILS_LIST, personalDetails); }); afterEach(async () => { await Onyx.clear(); @@ -656,7 +656,7 @@ describe('PolicyUtils', () => { describe('isWorkspaceEligibleForReportChange', () => { beforeEach(() => { wrapOnyxWithWaitForBatchedUpdates(Onyx); - Onyx.set(ONYXKEYS.PERSONAL_DETAILS_LIST, personalDetails); + void Onyx.set(ONYXKEYS.PERSONAL_DETAILS_LIST, personalDetails); }); afterEach(async () => { await Onyx.clear(); @@ -899,7 +899,7 @@ describe('PolicyUtils', () => { describe('getPolicyEmployeeAccountIDs', () => { beforeEach(() => { wrapOnyxWithWaitForBatchedUpdates(Onyx); - Onyx.set(ONYXKEYS.PERSONAL_DETAILS_LIST, personalDetails); + void Onyx.set(ONYXKEYS.PERSONAL_DETAILS_LIST, personalDetails); }); afterEach(async () => { await Onyx.clear(); diff --git a/tests/unit/ReportActionItemSingleTest.ts b/tests/unit/ReportActionItemSingleTest.ts index 02e5ba0f5aaa..55842311481c 100644 --- a/tests/unit/ReportActionItemSingleTest.ts +++ b/tests/unit/ReportActionItemSingleTest.ts @@ -25,7 +25,7 @@ describe('ReportActionItemSingle', () => { // Clear out Onyx after each test so that each test starts with a clean slate afterEach(() => { - Onyx.clear(); + void Onyx.clear(); }); describe('when the Report is a DM chat', () => { @@ -47,20 +47,21 @@ describe('ReportActionItemSingle', () => { function setup() { const policyCollectionDataSet = toCollectionDataSet(ONYXKEYS.COLLECTION.POLICY, [fakePolicy], (item) => item.id); return waitForBatchedUpdates() - .then(() => - Onyx.multiSet({ - [ONYXKEYS.PERSONAL_DETAILS_LIST]: fakePersonalDetails, - [ONYXKEYS.IS_LOADING_REPORT_DATA]: false, - [ONYXKEYS.COLLECTION.REPORT_ACTIONS]: { - [`${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${fakeReport.reportID}`]: { - [fakeReportAction.reportActionID]: fakeReportAction, + .then( + () => + void Onyx.multiSet({ + [ONYXKEYS.PERSONAL_DETAILS_LIST]: fakePersonalDetails, + [ONYXKEYS.IS_LOADING_REPORT_DATA]: false, + [ONYXKEYS.COLLECTION.REPORT_ACTIONS]: { + [`${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${fakeReport.reportID}`]: { + [fakeReportAction.reportActionID]: fakeReportAction, + }, }, - }, - [ONYXKEYS.COLLECTION.REPORT]: { - [fakeReport.reportID]: fakeReport, - }, - ...policyCollectionDataSet, - }), + [ONYXKEYS.COLLECTION.REPORT]: { + [fakeReport.reportID]: fakeReport, + }, + ...policyCollectionDataSet, + }), ) .then(() => { LHNTestUtils.getDefaultRenderedReportActionItemSingle(fakeReport, fakeReportAction); diff --git a/tests/unit/ReportActionsUtilsTest.ts b/tests/unit/ReportActionsUtilsTest.ts index 54e835ce9544..7fde22447694 100644 --- a/tests/unit/ReportActionsUtilsTest.ts +++ b/tests/unit/ReportActionsUtilsTest.ts @@ -27,13 +27,13 @@ describe('ReportActionsUtils', () => { wrapOnyxWithWaitForBatchedUpdates(Onyx); IntlStore.load(CONST.LOCALES.DEFAULT); // Initialize the network key for OfflineWithFeedback - Onyx.merge(ONYXKEYS.NETWORK, {isOffline: false}); + void Onyx.merge(ONYXKEYS.NETWORK, {isOffline: false}); return waitForBatchedUpdates(); }); // Clear out Onyx after each test so that each test starts with a clean slate afterEach(() => { - Onyx.clear(); + void Onyx.clear(); }); describe('getSortedReportActions', () => { @@ -912,7 +912,7 @@ describe('ReportActionsUtils', () => { }; beforeEach(() => { - Onyx.multiSet({ + void Onyx.multiSet({ [`${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${deletedIOUReportID}`]: {[deletedIOUReportAction.reportActionID]: deletedIOUReportAction}, [`${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${activeIOUReportID}`]: {[activeIOUReportAction.reportActionID]: activeIOUReportAction}, } as unknown as KeyValueMapping); @@ -959,11 +959,12 @@ describe('ReportActionsUtils', () => { return ( waitForBatchedUpdates() // When Onyx is updated with the data and the sidebar re-renders - .then(() => - Onyx.multiSet({ - [`${ONYXKEYS.COLLECTION.REPORT}${report.reportID}`]: report, - [`${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${report.reportID}`]: {[action.reportActionID]: action, [action2.reportActionID]: action2}, - } as unknown as KeyValueMapping), + .then( + () => + void Onyx.multiSet({ + [`${ONYXKEYS.COLLECTION.REPORT}${report.reportID}`]: report, + [`${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${report.reportID}`]: {[action.reportActionID]: action, [action2.reportActionID]: action2}, + } as unknown as KeyValueMapping), ) .then( () => diff --git a/tests/unit/ReportPrimaryActionUtilsTest.ts b/tests/unit/ReportPrimaryActionUtilsTest.ts index 2d7c77290a70..e0a133847109 100644 --- a/tests/unit/ReportPrimaryActionUtilsTest.ts +++ b/tests/unit/ReportPrimaryActionUtilsTest.ts @@ -39,7 +39,7 @@ describe('getPrimaryAction', () => { beforeEach(async () => { jest.clearAllMocks(); - Onyx.clear(); + void Onyx.clear(); await Onyx.merge(ONYXKEYS.SESSION, SESSION); await Onyx.set(ONYXKEYS.PERSONAL_DETAILS_LIST, {[CURRENT_USER_ACCOUNT_ID]: PERSONAL_DETAILS}); }); @@ -612,7 +612,7 @@ describe('isReviewDuplicatesAction', () => { beforeEach(async () => { jest.clearAllMocks(); - Onyx.clear(); + void Onyx.clear(); await Onyx.merge(ONYXKEYS.SESSION, SESSION); await Onyx.set(ONYXKEYS.PERSONAL_DETAILS_LIST, {[CURRENT_USER_ACCOUNT_ID]: PERSONAL_DETAILS}); }); @@ -697,7 +697,7 @@ describe('getTransactionThreadPrimaryAction', () => { beforeEach(async () => { jest.clearAllMocks(); - Onyx.clear(); + void Onyx.clear(); await Onyx.merge(ONYXKEYS.SESSION, SESSION); await Onyx.set(ONYXKEYS.PERSONAL_DETAILS_LIST, {[CURRENT_USER_ACCOUNT_ID]: PERSONAL_DETAILS}); }); @@ -929,7 +929,7 @@ describe('getTransactionThreadPrimaryAction', () => { beforeEach(async () => { jest.clearAllMocks(); - Onyx.clear(); + void Onyx.clear(); await Onyx.merge(ONYXKEYS.SESSION, {accountID: submitterAccountID}); }); @@ -1036,7 +1036,7 @@ describe('getTransactionThreadPrimaryAction', () => { beforeEach(async () => { jest.clearAllMocks(); - Onyx.clear(); + void Onyx.clear(); await Onyx.merge(ONYXKEYS.SESSION, {accountID: submitterAccountID}); }); diff --git a/tests/unit/ReportSecondaryActionUtilsTest.ts b/tests/unit/ReportSecondaryActionUtilsTest.ts index f47d3b0329ea..a39f3a13cf47 100644 --- a/tests/unit/ReportSecondaryActionUtilsTest.ts +++ b/tests/unit/ReportSecondaryActionUtilsTest.ts @@ -39,7 +39,7 @@ describe('getSecondaryAction', () => { beforeEach(async () => { jest.clearAllMocks(); - Onyx.clear(); + void Onyx.clear(); await Onyx.merge(ONYXKEYS.SESSION, SESSION); await Onyx.set(ONYXKEYS.PERSONAL_DETAILS_LIST, {[EMPLOYEE_ACCOUNT_ID]: PERSONAL_DETAILS, [APPROVER_ACCOUNT_ID]: {accountID: APPROVER_ACCOUNT_ID, login: APPROVER_EMAIL}}); }); @@ -1148,7 +1148,7 @@ describe('getSecondaryExportReportActions', () => { beforeEach(async () => { jest.clearAllMocks(); - Onyx.clear(); + void Onyx.clear(); await Onyx.merge(ONYXKEYS.SESSION, SESSION); await Onyx.set(ONYXKEYS.PERSONAL_DETAILS_LIST, {[EMPLOYEE_ACCOUNT_ID]: PERSONAL_DETAILS}); }); @@ -1342,7 +1342,7 @@ describe('getSecondaryTransactionThreadActions', () => { beforeEach(async () => { jest.clearAllMocks(); - Onyx.clear(); + void Onyx.clear(); await Onyx.merge(ONYXKEYS.SESSION, SESSION); await Onyx.set(ONYXKEYS.PERSONAL_DETAILS_LIST, {[EMPLOYEE_ACCOUNT_ID]: PERSONAL_DETAILS}); }); diff --git a/tests/unit/ReportUtilsTest.ts b/tests/unit/ReportUtilsTest.ts index 0def65b26a89..cb9a7699034d 100644 --- a/tests/unit/ReportUtilsTest.ts +++ b/tests/unit/ReportUtilsTest.ts @@ -326,7 +326,7 @@ describe('ReportUtils', () => { Onyx.init({keys: ONYXKEYS}); const policyCollectionDataSet = toCollectionDataSet(ONYXKEYS.COLLECTION.POLICY, [policy], (current) => current.id); - Onyx.multiSet({ + void Onyx.multiSet({ [ONYXKEYS.PERSONAL_DETAILS_LIST]: participantsPersonalDetails, [ONYXKEYS.SESSION]: {email: currentUserEmail, accountID: currentUserAccountID}, [ONYXKEYS.COUNTRY_CODE]: 1, @@ -1968,7 +1968,7 @@ describe('ReportUtils', () => { beforeAll(() => { const reportCollectionDataSet = toCollectionDataSet(ONYXKEYS.COLLECTION.REPORT, reports, (report) => report.reportID); - Onyx.multiSet({ + void Onyx.multiSet({ ...reportCollectionDataSet, }); return waitForBatchedUpdates(); @@ -2010,7 +2010,7 @@ describe('ReportUtils', () => { ...LHNTestUtils.getFakeReport(), iouReportID: '1', }; - Onyx.merge(`${ONYXKEYS.COLLECTION.REPORT}1`, { + void Onyx.merge(`${ONYXKEYS.COLLECTION.REPORT}1`, { reportID: '1', ownerAccountID: 99, }).then(() => { @@ -2237,7 +2237,7 @@ describe('ReportUtils', () => { const participantsAccountIDs = Object.keys(participantsPersonalDetails).map(Number); beforeAll(() => { - Onyx.merge(ONYXKEYS.PERSONAL_DETAILS_LIST, { + void Onyx.merge(ONYXKEYS.PERSONAL_DETAILS_LIST, { [currentUserAccountID]: { accountID: currentUserAccountID, login: currentUserEmail, @@ -2327,7 +2327,7 @@ describe('ReportUtils', () => { }); it('it is an expense report tied to a policy expense chat user does not own', () => { - Onyx.merge(`${ONYXKEYS.COLLECTION.REPORT}100`, { + void Onyx.merge(`${ONYXKEYS.COLLECTION.REPORT}100`, { reportID: '100', isOwnPolicyExpenseChat: false, }).then(() => { @@ -2436,7 +2436,7 @@ describe('ReportUtils', () => { describe('return only submit expense and track expense options if', () => { it("it is an expense report tied to user's own policy expense chat", () => { - Onyx.merge(`${ONYXKEYS.COLLECTION.REPORT}102`, { + void Onyx.merge(`${ONYXKEYS.COLLECTION.REPORT}102`, { reportID: '102', chatType: CONST.REPORT.CHAT_TYPE.POLICY_EXPENSE_CHAT, isOwnPolicyExpenseChat: true, @@ -2456,7 +2456,7 @@ describe('ReportUtils', () => { }); it("it is an open expense report tied to user's own policy expense chat", () => { - Onyx.merge(`${ONYXKEYS.COLLECTION.REPORT}103`, { + void Onyx.merge(`${ONYXKEYS.COLLECTION.REPORT}103`, { reportID: '103', chatType: CONST.REPORT.CHAT_TYPE.POLICY_EXPENSE_CHAT, isOwnPolicyExpenseChat: true, @@ -2531,8 +2531,8 @@ describe('ReportUtils', () => { }, }; Promise.all([ - Onyx.merge(`${ONYXKEYS.COLLECTION.POLICY}${paidPolicy.id}`, paidPolicy), - Onyx.merge(`${ONYXKEYS.COLLECTION.REPORT}101`, { + void Onyx.merge(`${ONYXKEYS.COLLECTION.POLICY}${paidPolicy.id}`, paidPolicy), + void Onyx.merge(`${ONYXKEYS.COLLECTION.REPORT}101`, { reportID: '101', chatType: CONST.REPORT.CHAT_TYPE.POLICY_EXPENSE_CHAT, isOwnPolicyExpenseChat: true, @@ -2584,8 +2584,8 @@ describe('ReportUtils', () => { isPolicyExpenseChatEnabled: false, }; Promise.all([ - Onyx.merge(`${ONYXKEYS.COLLECTION.POLICY}${paidPolicy.id}`, paidPolicy), - Onyx.merge(`${ONYXKEYS.COLLECTION.REPORT}101`, { + void Onyx.merge(`${ONYXKEYS.COLLECTION.POLICY}${paidPolicy.id}`, paidPolicy), + void Onyx.merge(`${ONYXKEYS.COLLECTION.REPORT}101`, { reportID: '101', chatType: CONST.REPORT.CHAT_TYPE.POLICY_EXPENSE_CHAT, isOwnPolicyExpenseChat: true, @@ -2953,7 +2953,7 @@ describe('ReportUtils', () => { reportActions.map((reportAction) => ({[reportAction.reportActionID]: reportAction})), (actions) => Object.values(actions).at(0)?.reportActionID, ); - Onyx.multiSet({ + void Onyx.multiSet({ ...reportCollectionDataSet, ...reportActionCollectionDataSet, }); @@ -4414,7 +4414,7 @@ describe('ReportUtils', () => { ownerAccountID: employeeAccountID, type: CONST.REPORT.TYPE.EXPENSE, }; - Onyx.set(ONYXKEYS.PERSONAL_DETAILS_LIST, personalDetails).then(() => { + void Onyx.set(ONYXKEYS.PERSONAL_DETAILS_LIST, personalDetails).then(() => { const result = ['owner@test.com']; expect(getApprovalChain(policyTest, expenseReport)).toStrictEqual(result); }); @@ -4433,7 +4433,7 @@ describe('ReportUtils', () => { ownerAccountID: employeeAccountID, type: CONST.REPORT.TYPE.EXPENSE, }; - Onyx.set(ONYXKEYS.PERSONAL_DETAILS_LIST, personalDetails).then(() => { + void Onyx.set(ONYXKEYS.PERSONAL_DETAILS_LIST, personalDetails).then(() => { const result = ['admin@test.com']; expect(getApprovalChain(policyTest, expenseReport)).toStrictEqual(result); }); @@ -4472,7 +4472,7 @@ describe('ReportUtils', () => { created: DateUtils.subtractMillisecondsFromDateTime(testDate, 1), reportID: expenseReport.reportID, }; - Onyx.multiSet({ + void Onyx.multiSet({ [ONYXKEYS.PERSONAL_DETAILS_LIST]: personalDetails, [ONYXKEYS.COLLECTION.TRANSACTION]: { [transaction1.transactionID]: transaction1, @@ -4533,7 +4533,7 @@ describe('ReportUtils', () => { inserted: DateUtils.subtractMillisecondsFromDateTime(testDate, 2), }; - Onyx.mergeCollection(ONYXKEYS.COLLECTION.TRANSACTION, { + void Onyx.mergeCollection(ONYXKEYS.COLLECTION.TRANSACTION, { transactions_1: transaction1, transactions_2: transaction2, transactions_3: transaction3, @@ -6741,7 +6741,7 @@ describe('ReportUtils', () => { ...createRandomReport(40002), participants: buildParticipantsFromAccountIDs([currentUserAccountID, 8]), }; - Onyx.set(ONYXKEYS.PERSONAL_DETAILS_LIST, personalDetails).then(() => { + void Onyx.set(ONYXKEYS.PERSONAL_DETAILS_LIST, personalDetails).then(() => { expect(canSeeDefaultRoom(report, betas, false)).toBe(true); }); }); @@ -6751,7 +6751,7 @@ describe('ReportUtils', () => { ...createRandomReport(40002), chatType: CONST.REPORT.CHAT_TYPE.POLICY_ADMINS, }; - Onyx.set(ONYXKEYS.PERSONAL_DETAILS_LIST, personalDetails).then(() => { + void Onyx.set(ONYXKEYS.PERSONAL_DETAILS_LIST, personalDetails).then(() => { expect(canSeeDefaultRoom(report, betas, false)).toBe(true); }); }); diff --git a/tests/unit/Search/SearchUIUtilsTest.ts b/tests/unit/Search/SearchUIUtilsTest.ts index 69eab20718a7..cef0bf69dc33 100644 --- a/tests/unit/Search/SearchUIUtilsTest.ts +++ b/tests/unit/Search/SearchUIUtilsTest.ts @@ -1638,7 +1638,7 @@ describe('SearchUIUtils', () => { expect(action).toStrictEqual(CONST.SEARCH.ACTION_TYPES.REVIEW); }); test('Should return `Pay` action for an IOU report ready to be paid', async () => { - Onyx.merge(ONYXKEYS.SESSION, {accountID: adminAccountID}); + void Onyx.merge(ONYXKEYS.SESSION, {accountID: adminAccountID}); await waitForBatchedUpdates(); const iouReportKey = `report_${reportID3}`; const action = SearchUIUtils.getActions(searchResults.data, {}, iouReportKey, CONST.SEARCH.SEARCH_KEYS.EXPENSES, adminAccountID).at(0); @@ -2273,7 +2273,7 @@ describe('SearchUIUtils', () => { }); test('Should show `View` to overlimit approver', () => { - Onyx.merge(ONYXKEYS.SESSION, {accountID: overlimitApproverAccountID}); + void Onyx.merge(ONYXKEYS.SESSION, {accountID: overlimitApproverAccountID}); searchResults.data[`policy_${policyID}`].role = CONST.POLICY.ROLE.USER; return waitForBatchedUpdates().then(() => { let action = SearchUIUtils.getActions(searchResults.data, allViolations, `report_${reportID2}`, CONST.SEARCH.SEARCH_KEYS.EXPENSES, overlimitApproverAccountID).at(0); @@ -2285,7 +2285,7 @@ describe('SearchUIUtils', () => { }); test('Should show `Approve` for report', () => { - Onyx.merge(ONYXKEYS.SESSION, {accountID: adminAccountID}); + void Onyx.merge(ONYXKEYS.SESSION, {accountID: adminAccountID}); const result: OnyxTypes.SearchResults = { data: { diff --git a/tests/unit/Search/handleActionButtonPressTest.ts b/tests/unit/Search/handleActionButtonPressTest.ts index 78e2c92eb7ed..698d522768ab 100644 --- a/tests/unit/Search/handleActionButtonPressTest.ts +++ b/tests/unit/Search/handleActionButtonPressTest.ts @@ -246,12 +246,12 @@ const mockLastPaymentMethod: OnyxEntry = { describe('handleActionButtonPress', () => { const searchHash = 1; beforeAll(() => { - Onyx.merge( + void Onyx.merge( `${ONYXKEYS.COLLECTION.SNAPSHOT}${searchHash}`, // @ts-expect-error: Allow partial record in snapshot update for testing mockSnapshotForItem, ); - Onyx.merge(ONYXKEYS.NVP_LAST_PAYMENT_METHOD, mockLastPaymentMethod); + void Onyx.merge(ONYXKEYS.NVP_LAST_PAYMENT_METHOD, mockLastPaymentMethod); }); const snapshotReport = mockSnapshotForItem?.data?.[`${ONYXKEYS.COLLECTION.REPORT}${mockReportItemWithHold.reportID}`] ?? {}; diff --git a/tests/unit/SequentialQueueTest.ts b/tests/unit/SequentialQueueTest.ts index d2896dc1ba7e..187d0af50de2 100644 --- a/tests/unit/SequentialQueueTest.ts +++ b/tests/unit/SequentialQueueTest.ts @@ -248,7 +248,7 @@ describe('SequentialQueue', () => { it('should get the ongoing request from onyx and start processing it', async () => { const persistedRequest = {...request, persistWhenOngoing: true, initiatedOffline: false}; - Onyx.set(ONYXKEYS.PERSISTED_ONGOING_REQUESTS, persistedRequest); + void Onyx.set(ONYXKEYS.PERSISTED_ONGOING_REQUESTS, persistedRequest); SequentialQueue.push({command: 'OpenReport'}); await Promise.resolve(); diff --git a/tests/unit/SidebarFilterTest.ts b/tests/unit/SidebarFilterTest.ts index f2b3078994c1..966dd79f8007 100644 --- a/tests/unit/SidebarFilterTest.ts +++ b/tests/unit/SidebarFilterTest.ts @@ -50,7 +50,7 @@ xdescribe('Sidebar', () => { describe('in default (most recent) mode', () => { it('excludes a report with no participants', () => { - LHNTestUtils.getDefaultRenderedSidebarLinks(); + void LHNTestUtils.getDefaultRenderedSidebarLinks(); // Given a report with no participants const report = LHNTestUtils.getFakeReport([]); @@ -73,7 +73,7 @@ xdescribe('Sidebar', () => { }); it('excludes an empty chat report', () => { - LHNTestUtils.getDefaultRenderedSidebarLinks(); + void LHNTestUtils.getDefaultRenderedSidebarLinks(); // Given a new report const report = LHNTestUtils.getFakeReport([1, 2], 0); @@ -85,11 +85,12 @@ xdescribe('Sidebar', () => { return ( waitForBatchedUpdates() // When Onyx is updated to contain that report - .then(() => - Onyx.multiSet({ - [ONYXKEYS.IS_LOADING_APP]: false, - ...reportCollectionDataSet, - }), + .then( + () => + void Onyx.multiSet({ + [ONYXKEYS.IS_LOADING_APP]: false, + ...reportCollectionDataSet, + }), ) // Then no reports are rendered in the LHN @@ -102,7 +103,7 @@ xdescribe('Sidebar', () => { }); it('includes an empty chat report if it has a draft', () => { - LHNTestUtils.getDefaultRenderedSidebarLinks(); + void LHNTestUtils.getDefaultRenderedSidebarLinks(); // Given a new report with a draft text const report: Report = { @@ -116,13 +117,14 @@ xdescribe('Sidebar', () => { return ( waitForBatchedUpdates() // When Onyx is updated to contain that report - .then(() => - Onyx.multiSet({ - [ONYXKEYS.PERSONAL_DETAILS_LIST]: LHNTestUtils.fakePersonalDetails, - [ONYXKEYS.IS_LOADING_APP]: false, - [`${ONYXKEYS.COLLECTION.REPORT_DRAFT_COMMENT}${report.reportID}`]: 'This is a draft message', - ...reportCollectionDataSet, - }), + .then( + () => + void Onyx.multiSet({ + [ONYXKEYS.PERSONAL_DETAILS_LIST]: LHNTestUtils.fakePersonalDetails, + [ONYXKEYS.IS_LOADING_APP]: false, + [`${ONYXKEYS.COLLECTION.REPORT_DRAFT_COMMENT}${report.reportID}`]: 'This is a draft message', + ...reportCollectionDataSet, + }), ) // Then the report should be rendered in the LHN since it has a draft @@ -135,7 +137,7 @@ xdescribe('Sidebar', () => { }); it('includes or excludes user created policy rooms depending on the beta', () => { - LHNTestUtils.getDefaultRenderedSidebarLinks(); + void LHNTestUtils.getDefaultRenderedSidebarLinks(); // Given a user created policy room report // and the user not being in any betas @@ -151,13 +153,14 @@ xdescribe('Sidebar', () => { return ( waitForBatchedUpdates() // When Onyx is updated to contain that data and the sidebar re-renders - .then(() => - Onyx.multiSet({ - [ONYXKEYS.BETAS]: [], - [ONYXKEYS.PERSONAL_DETAILS_LIST]: LHNTestUtils.fakePersonalDetails, - [ONYXKEYS.IS_LOADING_APP]: false, - ...reportCollectionDataSet, - }), + .then( + () => + void Onyx.multiSet({ + [ONYXKEYS.BETAS]: [], + [ONYXKEYS.PERSONAL_DETAILS_LIST]: LHNTestUtils.fakePersonalDetails, + [ONYXKEYS.IS_LOADING_APP]: false, + ...reportCollectionDataSet, + }), ) // Then the report appears in the LHN @@ -169,7 +172,7 @@ xdescribe('Sidebar', () => { }); it('includes or excludes default policy rooms depending on the beta', () => { - LHNTestUtils.getDefaultRenderedSidebarLinks(); + void LHNTestUtils.getDefaultRenderedSidebarLinks(); // Given three reports with the three different types of default policy rooms // and the user not being in any betas @@ -195,13 +198,14 @@ xdescribe('Sidebar', () => { return ( waitForBatchedUpdates() // When Onyx is updated to contain that data and the sidebar re-renders - .then(() => - Onyx.multiSet({ - [ONYXKEYS.BETAS]: [], - [ONYXKEYS.PERSONAL_DETAILS_LIST]: LHNTestUtils.fakePersonalDetails, - [ONYXKEYS.IS_LOADING_APP]: false, - ...reportCollectionDataSet, - }), + .then( + () => + void Onyx.multiSet({ + [ONYXKEYS.BETAS]: [], + [ONYXKEYS.PERSONAL_DETAILS_LIST]: LHNTestUtils.fakePersonalDetails, + [ONYXKEYS.IS_LOADING_APP]: false, + ...reportCollectionDataSet, + }), ) // Then all non-domain rooms are rendered in the LHN @@ -211,10 +215,11 @@ xdescribe('Sidebar', () => { }) // When the user is added to the default policy rooms beta and the sidebar re-renders - .then(() => - Onyx.multiSet({ - [ONYXKEYS.BETAS]: [CONST.BETAS.DEFAULT_ROOMS], - }), + .then( + () => + void Onyx.multiSet({ + [ONYXKEYS.BETAS]: [CONST.BETAS.DEFAULT_ROOMS], + }), ) // Then all three reports are showing in the LHN @@ -226,7 +231,7 @@ xdescribe('Sidebar', () => { }); it('includes default policy rooms for free policies, regardless of the beta', () => { - LHNTestUtils.getDefaultRenderedSidebarLinks(); + void LHNTestUtils.getDefaultRenderedSidebarLinks(); // Given a default policy room report on a free policy // and the user not being in any betas @@ -247,14 +252,15 @@ xdescribe('Sidebar', () => { return ( waitForBatchedUpdates() // When Onyx is updated to contain that data and the sidebar re-renders - .then(() => - Onyx.multiSet({ - [ONYXKEYS.BETAS]: [], - [ONYXKEYS.PERSONAL_DETAILS_LIST]: LHNTestUtils.fakePersonalDetails, - [ONYXKEYS.IS_LOADING_APP]: false, - [`${ONYXKEYS.COLLECTION.POLICY}${policy.policyID}`]: policy, - ...reportCollectionDataSet, - }), + .then( + () => + void Onyx.multiSet({ + [ONYXKEYS.BETAS]: [], + [ONYXKEYS.PERSONAL_DETAILS_LIST]: LHNTestUtils.fakePersonalDetails, + [ONYXKEYS.IS_LOADING_APP]: false, + [`${ONYXKEYS.COLLECTION.POLICY}${policy.policyID}`]: policy, + ...reportCollectionDataSet, + }), ) // Then the report is rendered in the LHN @@ -289,7 +295,7 @@ xdescribe('Sidebar', () => { }, }; const report3: Report = LHNTestUtils.getFakeReport(); - LHNTestUtils.getDefaultRenderedSidebarLinks(report1.reportID); + void LHNTestUtils.getDefaultRenderedSidebarLinks(report1.reportID); const reportCollectionDataSet: ReportCollectionDataSet = { [`${ONYXKEYS.COLLECTION.REPORT}${report1.reportID}`]: report1, [`${ONYXKEYS.COLLECTION.REPORT}${report2.reportID}`]: report2, @@ -360,7 +366,7 @@ xdescribe('Sidebar', () => { ...LHNTestUtils.getAdvancedFakeReport(isArchived, isUserCreatedPolicyRoom, hasAddWorkspaceError, isUnread, isPinned), policyID: policy.policyID, }; - LHNTestUtils.getDefaultRenderedSidebarLinks(report1.reportID); + void LHNTestUtils.getDefaultRenderedSidebarLinks(report1.reportID); const reportCollectionDataSet: ReportCollectionDataSet = { [`${ONYXKEYS.COLLECTION.REPORT}${report1.reportID}`]: report1, @@ -370,15 +376,16 @@ xdescribe('Sidebar', () => { return ( waitForBatchedUpdates() // When Onyx is updated to contain that data and the sidebar re-renders - .then(() => - Onyx.multiSet({ - [ONYXKEYS.NVP_PRIORITY_MODE]: CONST.PRIORITY_MODE.GSD, - [ONYXKEYS.BETAS]: betas, - [ONYXKEYS.PERSONAL_DETAILS_LIST]: LHNTestUtils.fakePersonalDetails, - [ONYXKEYS.IS_LOADING_APP]: false, - [`${ONYXKEYS.COLLECTION.POLICY}${policy.policyID}`]: policy, - ...reportCollectionDataSet, - }), + .then( + () => + void Onyx.multiSet({ + [ONYXKEYS.NVP_PRIORITY_MODE]: CONST.PRIORITY_MODE.GSD, + [ONYXKEYS.BETAS]: betas, + [ONYXKEYS.PERSONAL_DETAILS_LIST]: LHNTestUtils.fakePersonalDetails, + [ONYXKEYS.IS_LOADING_APP]: false, + [`${ONYXKEYS.COLLECTION.POLICY}${policy.policyID}`]: policy, + ...reportCollectionDataSet, + }), ) // Then depending on the outcome, either one or two reports are visible .then(() => { @@ -408,7 +415,7 @@ xdescribe('Sidebar', () => { const report1 = LHNTestUtils.getFakeReport([1, 2], 0, true); const report2 = LHNTestUtils.getFakeReport([3, 4], 0, true); const report3 = LHNTestUtils.getFakeReport([5, 6]); - LHNTestUtils.getDefaultRenderedSidebarLinks(report1.reportID); + void LHNTestUtils.getDefaultRenderedSidebarLinks(report1.reportID); const reportCollectionDataSet: ReportCollectionDataSet = { [`${ONYXKEYS.COLLECTION.REPORT}${report1.reportID}`]: report1, @@ -419,13 +426,14 @@ xdescribe('Sidebar', () => { return ( waitForBatchedUpdates() // When Onyx is updated to contain that data and the sidebar re-renders - .then(() => - Onyx.multiSet({ - [ONYXKEYS.NVP_PRIORITY_MODE]: CONST.PRIORITY_MODE.GSD, - [ONYXKEYS.PERSONAL_DETAILS_LIST]: LHNTestUtils.fakePersonalDetails, - [ONYXKEYS.IS_LOADING_APP]: false, - ...reportCollectionDataSet, - }), + .then( + () => + void Onyx.multiSet({ + [ONYXKEYS.NVP_PRIORITY_MODE]: CONST.PRIORITY_MODE.GSD, + [ONYXKEYS.PERSONAL_DETAILS_LIST]: LHNTestUtils.fakePersonalDetails, + [ONYXKEYS.IS_LOADING_APP]: false, + ...reportCollectionDataSet, + }), ) // Then the reports 1 and 2 are shown and 3 is not @@ -459,7 +467,7 @@ xdescribe('Sidebar', () => { // When report 2 becomes the active report .then(() => { - LHNTestUtils.getDefaultRenderedSidebarLinks(report2.reportID); + void LHNTestUtils.getDefaultRenderedSidebarLinks(report2.reportID); return waitForBatchedUpdates(); }) @@ -480,7 +488,7 @@ xdescribe('Sidebar', () => { ...LHNTestUtils.getFakeReport([3, 4]), isPinned: true, }; - LHNTestUtils.getDefaultRenderedSidebarLinks(draftReport.reportID); + void LHNTestUtils.getDefaultRenderedSidebarLinks(draftReport.reportID); const reportCollectionDataSet: ReportCollectionDataSet = { [`${ONYXKEYS.COLLECTION.REPORT}${draftReport.reportID}`]: draftReport, @@ -490,14 +498,15 @@ xdescribe('Sidebar', () => { return ( waitForBatchedUpdates() // When Onyx is updated to contain that data and the sidebar re-renders - .then(() => - Onyx.multiSet({ - [ONYXKEYS.NVP_PRIORITY_MODE]: CONST.PRIORITY_MODE.GSD, - [ONYXKEYS.PERSONAL_DETAILS_LIST]: LHNTestUtils.fakePersonalDetails, - [ONYXKEYS.IS_LOADING_APP]: false, - [`${ONYXKEYS.COLLECTION.REPORT_DRAFT_COMMENT}${draftReport.reportID}`]: 'draft report message', - ...reportCollectionDataSet, - }), + .then( + () => + void Onyx.multiSet({ + [ONYXKEYS.NVP_PRIORITY_MODE]: CONST.PRIORITY_MODE.GSD, + [ONYXKEYS.PERSONAL_DETAILS_LIST]: LHNTestUtils.fakePersonalDetails, + [ONYXKEYS.IS_LOADING_APP]: false, + [`${ONYXKEYS.COLLECTION.REPORT_DRAFT_COMMENT}${draftReport.reportID}`]: 'draft report message', + ...reportCollectionDataSet, + }), ) // Then both reports are visible @@ -531,7 +540,7 @@ xdescribe('Sidebar', () => { statusNum: CONST.REPORT.STATUS_NUM.CLOSED, stateNum: CONST.REPORT.STATE_NUM.APPROVED, }; - LHNTestUtils.getDefaultRenderedSidebarLinks(); + void LHNTestUtils.getDefaultRenderedSidebarLinks(); const betas = [CONST.BETAS.DEFAULT_ROOMS]; @@ -544,14 +553,15 @@ xdescribe('Sidebar', () => { return ( waitForBatchedUpdates() // When Onyx is updated to contain that data and the sidebar re-renders - .then(() => - Onyx.multiSet({ - [ONYXKEYS.NVP_PRIORITY_MODE]: CONST.PRIORITY_MODE.GSD, - [ONYXKEYS.BETAS]: betas, - [ONYXKEYS.PERSONAL_DETAILS_LIST]: LHNTestUtils.fakePersonalDetails, - [ONYXKEYS.IS_LOADING_APP]: false, - ...reportCollectionDataSet, - }), + .then( + () => + void Onyx.multiSet({ + [ONYXKEYS.NVP_PRIORITY_MODE]: CONST.PRIORITY_MODE.GSD, + [ONYXKEYS.BETAS]: betas, + [ONYXKEYS.PERSONAL_DETAILS_LIST]: LHNTestUtils.fakePersonalDetails, + [ONYXKEYS.IS_LOADING_APP]: false, + ...reportCollectionDataSet, + }), ) // Then neither reports are visible @@ -568,15 +578,17 @@ xdescribe('Sidebar', () => { lastVisibleActionCreated: DateUtils.getDBTime(), }); }) - .then(() => - Onyx.merge(`${ONYXKEYS.COLLECTION.REPORT}${archivedPolicyRoomReport.reportID}`, { - lastVisibleActionCreated: DateUtils.getDBTime(), - }), + .then( + () => + void Onyx.merge(`${ONYXKEYS.COLLECTION.REPORT}${archivedPolicyRoomReport.reportID}`, { + lastVisibleActionCreated: DateUtils.getDBTime(), + }), ) - .then(() => - Onyx.merge(`${ONYXKEYS.COLLECTION.REPORT}${archivedUserCreatedPolicyRoomReport.reportID}`, { - lastVisibleActionCreated: DateUtils.getDBTime(), - }), + .then( + () => + void Onyx.merge(`${ONYXKEYS.COLLECTION.REPORT}${archivedUserCreatedPolicyRoomReport.reportID}`, { + lastVisibleActionCreated: DateUtils.getDBTime(), + }), ) // Then they are all visible @@ -598,7 +610,7 @@ xdescribe('Sidebar', () => { ...LHNTestUtils.getFakeReport([1, 2]), chatType: CONST.REPORT.CHAT_TYPE.POLICY_ROOM, }; - LHNTestUtils.getDefaultRenderedSidebarLinks(); + void LHNTestUtils.getDefaultRenderedSidebarLinks(); const betas = [CONST.BETAS.DEFAULT_ROOMS]; @@ -610,14 +622,15 @@ xdescribe('Sidebar', () => { return ( waitForBatchedUpdates() // When Onyx is updated to contain that data and the sidebar re-renders - .then(() => - Onyx.multiSet({ - [ONYXKEYS.NVP_PRIORITY_MODE]: CONST.PRIORITY_MODE.GSD, - [ONYXKEYS.BETAS]: betas, - [ONYXKEYS.PERSONAL_DETAILS_LIST]: LHNTestUtils.fakePersonalDetails, - [ONYXKEYS.IS_LOADING_APP]: false, - ...reportCollectionDataSet, - }), + .then( + () => + void Onyx.multiSet({ + [ONYXKEYS.NVP_PRIORITY_MODE]: CONST.PRIORITY_MODE.GSD, + [ONYXKEYS.BETAS]: betas, + [ONYXKEYS.PERSONAL_DETAILS_LIST]: LHNTestUtils.fakePersonalDetails, + [ONYXKEYS.IS_LOADING_APP]: false, + ...reportCollectionDataSet, + }), ) // Then neither reports are visible @@ -634,10 +647,11 @@ xdescribe('Sidebar', () => { lastVisibleActionCreated: DateUtils.getDBTime(), }); }) - .then(() => - Onyx.merge(`${ONYXKEYS.COLLECTION.REPORT}${userCreatedPolicyRoomReport.reportID}`, { - lastVisibleActionCreated: DateUtils.getDBTime(), - }), + .then( + () => + void Onyx.merge(`${ONYXKEYS.COLLECTION.REPORT}${userCreatedPolicyRoomReport.reportID}`, { + lastVisibleActionCreated: DateUtils.getDBTime(), + }), ) // Then both rooms are visible @@ -702,7 +716,7 @@ xdescribe('Sidebar', () => { ...LHNTestUtils.getAdvancedFakeReport(isArchived, isUserCreatedPolicyRoom, hasAddWorkspaceError, isUnread, isPinned), policyID: policy.policyID, }; - LHNTestUtils.getDefaultRenderedSidebarLinks(report1.reportID); + void LHNTestUtils.getDefaultRenderedSidebarLinks(report1.reportID); const reportCollectionDataSet: ReportCollectionDataSet = { [`${ONYXKEYS.COLLECTION.REPORT}${report1.reportID}`]: report1, @@ -712,16 +726,17 @@ xdescribe('Sidebar', () => { return ( waitForBatchedUpdates() // When Onyx is updated to contain that data and the sidebar re-renders - .then(() => - Onyx.multiSet({ - [ONYXKEYS.NVP_PRIORITY_MODE]: CONST.PRIORITY_MODE.GSD, - [ONYXKEYS.BETAS]: betas, - [ONYXKEYS.PERSONAL_DETAILS_LIST]: LHNTestUtils.fakePersonalDetails, - [ONYXKEYS.IS_LOADING_APP]: false, - [`${ONYXKEYS.COLLECTION.POLICY}${policy.policyID}`]: policy, - [`${ONYXKEYS.COLLECTION.REPORT_DRAFT_COMMENT}${report2.reportID}`]: hasDraft ? 'report2 draft' : null, - ...reportCollectionDataSet, - }), + .then( + () => + void Onyx.multiSet({ + [ONYXKEYS.NVP_PRIORITY_MODE]: CONST.PRIORITY_MODE.GSD, + [ONYXKEYS.BETAS]: betas, + [ONYXKEYS.PERSONAL_DETAILS_LIST]: LHNTestUtils.fakePersonalDetails, + [ONYXKEYS.IS_LOADING_APP]: false, + [`${ONYXKEYS.COLLECTION.POLICY}${policy.policyID}`]: policy, + [`${ONYXKEYS.COLLECTION.REPORT_DRAFT_COMMENT}${report2.reportID}`]: hasDraft ? 'report2 draft' : null, + ...reportCollectionDataSet, + }), ) // Then depending on the outcome, either one or two reports are visible @@ -747,7 +762,7 @@ xdescribe('Sidebar', () => { describe('Archived chat', () => { describe('in default (most recent) mode', () => { it('is shown regardless if it has comments or not', () => { - LHNTestUtils.getDefaultRenderedSidebarLinks(); + void LHNTestUtils.getDefaultRenderedSidebarLinks(); // Given an archived report with no comments const report: Report = { @@ -767,14 +782,15 @@ xdescribe('Sidebar', () => { return ( waitForBatchedUpdates() // When Onyx is updated to contain that data and the sidebar re-renders - .then(() => - Onyx.multiSet({ - [ONYXKEYS.NVP_PRIORITY_MODE]: CONST.PRIORITY_MODE.DEFAULT, - [ONYXKEYS.BETAS]: betas, - [ONYXKEYS.PERSONAL_DETAILS_LIST]: LHNTestUtils.fakePersonalDetails, - [ONYXKEYS.IS_LOADING_APP]: false, - ...reportCollectionDataSet, - }), + .then( + () => + void Onyx.multiSet({ + [ONYXKEYS.NVP_PRIORITY_MODE]: CONST.PRIORITY_MODE.DEFAULT, + [ONYXKEYS.BETAS]: betas, + [ONYXKEYS.PERSONAL_DETAILS_LIST]: LHNTestUtils.fakePersonalDetails, + [ONYXKEYS.IS_LOADING_APP]: false, + ...reportCollectionDataSet, + }), ) // Then the report is rendered in the LHN @@ -784,10 +800,11 @@ xdescribe('Sidebar', () => { }) // When the report has comments - .then(() => - Onyx.merge(`${ONYXKEYS.COLLECTION.REPORT}${report.reportID}`, { - lastVisibleActionCreated: DateUtils.getDBTime(), - }), + .then( + () => + void Onyx.merge(`${ONYXKEYS.COLLECTION.REPORT}${report.reportID}`, { + lastVisibleActionCreated: DateUtils.getDBTime(), + }), ) // Then the report is rendered in the LHN @@ -801,7 +818,7 @@ xdescribe('Sidebar', () => { describe('in GSD (focus) mode', () => { it('is shown when it is unread', () => { - LHNTestUtils.getDefaultRenderedSidebarLinks(); + void LHNTestUtils.getDefaultRenderedSidebarLinks(); // Given an archived report that has all comments read const report: Report = { @@ -820,14 +837,15 @@ xdescribe('Sidebar', () => { return ( waitForBatchedUpdates() // When Onyx is updated to contain that data and the sidebar re-renders - .then(() => - Onyx.multiSet({ - [ONYXKEYS.NVP_PRIORITY_MODE]: CONST.PRIORITY_MODE.GSD, - [ONYXKEYS.BETAS]: betas, - [ONYXKEYS.PERSONAL_DETAILS_LIST]: LHNTestUtils.fakePersonalDetails, - [ONYXKEYS.IS_LOADING_APP]: false, - ...reportCollectionDataSet, - }), + .then( + () => + void Onyx.multiSet({ + [ONYXKEYS.NVP_PRIORITY_MODE]: CONST.PRIORITY_MODE.GSD, + [ONYXKEYS.BETAS]: betas, + [ONYXKEYS.PERSONAL_DETAILS_LIST]: LHNTestUtils.fakePersonalDetails, + [ONYXKEYS.IS_LOADING_APP]: false, + ...reportCollectionDataSet, + }), ) // Then the report is not rendered in the LHN @@ -851,7 +869,7 @@ xdescribe('Sidebar', () => { }); it('is shown when it is pinned', () => { - LHNTestUtils.getDefaultRenderedSidebarLinks(); + void LHNTestUtils.getDefaultRenderedSidebarLinks(); // Given an archived report that is not pinned const report: Report = { @@ -871,14 +889,15 @@ xdescribe('Sidebar', () => { return ( waitForBatchedUpdates() // When Onyx is updated to contain that data and the sidebar re-renders - .then(() => - Onyx.multiSet({ - [ONYXKEYS.NVP_PRIORITY_MODE]: CONST.PRIORITY_MODE.GSD, - [ONYXKEYS.BETAS]: betas, - [ONYXKEYS.PERSONAL_DETAILS_LIST]: LHNTestUtils.fakePersonalDetails, - [ONYXKEYS.IS_LOADING_APP]: false, - ...reportCollectionDataSet, - }), + .then( + () => + void Onyx.multiSet({ + [ONYXKEYS.NVP_PRIORITY_MODE]: CONST.PRIORITY_MODE.GSD, + [ONYXKEYS.BETAS]: betas, + [ONYXKEYS.PERSONAL_DETAILS_LIST]: LHNTestUtils.fakePersonalDetails, + [ONYXKEYS.IS_LOADING_APP]: false, + ...reportCollectionDataSet, + }), ) // Then the report is not rendered in the LHN @@ -899,7 +918,7 @@ xdescribe('Sidebar', () => { }); it('is shown when it is the active report', () => { - LHNTestUtils.getDefaultRenderedSidebarLinks(); + void LHNTestUtils.getDefaultRenderedSidebarLinks(); // Given an archived report that is not the active report const report: Report = { @@ -918,14 +937,15 @@ xdescribe('Sidebar', () => { return ( waitForBatchedUpdates() // When Onyx is updated to contain that data and the sidebar re-renders - .then(() => - Onyx.multiSet({ - [ONYXKEYS.NVP_PRIORITY_MODE]: CONST.PRIORITY_MODE.GSD, - [ONYXKEYS.BETAS]: betas, - [ONYXKEYS.PERSONAL_DETAILS_LIST]: LHNTestUtils.fakePersonalDetails, - [ONYXKEYS.IS_LOADING_APP]: false, - ...reportCollectionDataSet, - }), + .then( + () => + void Onyx.multiSet({ + [ONYXKEYS.NVP_PRIORITY_MODE]: CONST.PRIORITY_MODE.GSD, + [ONYXKEYS.BETAS]: betas, + [ONYXKEYS.PERSONAL_DETAILS_LIST]: LHNTestUtils.fakePersonalDetails, + [ONYXKEYS.IS_LOADING_APP]: false, + ...reportCollectionDataSet, + }), ) // Then the report is not rendered in the LHN @@ -936,7 +956,7 @@ xdescribe('Sidebar', () => { // When sidebar is rendered with the active report ID matching the archived report in Onyx .then(() => { - LHNTestUtils.getDefaultRenderedSidebarLinks(report.reportID); + void LHNTestUtils.getDefaultRenderedSidebarLinks(report.reportID); return waitForBatchedUpdates(); }) @@ -950,17 +970,18 @@ xdescribe('Sidebar', () => { it('display empty state', () => { const reportCollectionDataSet: ReportCollectionDataSet = {}; - LHNTestUtils.getDefaultRenderedSidebarLinks(); + void LHNTestUtils.getDefaultRenderedSidebarLinks(); return ( waitForBatchedUpdates() // When Onyx is updated to contain that data and the sidebar re-renders - .then(() => - Onyx.multiSet({ - [ONYXKEYS.NVP_PRIORITY_MODE]: CONST.PRIORITY_MODE.GSD, - [ONYXKEYS.PERSONAL_DETAILS_LIST]: LHNTestUtils.fakePersonalDetails, - [ONYXKEYS.IS_LOADING_APP]: false, - ...reportCollectionDataSet, - }), + .then( + () => + void Onyx.multiSet({ + [ONYXKEYS.NVP_PRIORITY_MODE]: CONST.PRIORITY_MODE.GSD, + [ONYXKEYS.PERSONAL_DETAILS_LIST]: LHNTestUtils.fakePersonalDetails, + [ONYXKEYS.IS_LOADING_APP]: false, + ...reportCollectionDataSet, + }), ) .then(() => { diff --git a/tests/unit/SidebarOrderTest.ts b/tests/unit/SidebarOrderTest.ts index bc9fb2a22eb5..da44829fdbd1 100644 --- a/tests/unit/SidebarOrderTest.ts +++ b/tests/unit/SidebarOrderTest.ts @@ -61,14 +61,14 @@ describe('Sidebar', () => { // Clear out Onyx after each test so that each test starts with a clean slate afterEach(() => { - Onyx.clear(); + void Onyx.clear(); }); describe('in default mode', () => { it('is rendered with empty state when no reports are available', () => { // Given all the default props are passed to SidebarLinks // When it is rendered - LHNTestUtils.getDefaultRenderedSidebarLinks(); + void LHNTestUtils.getDefaultRenderedSidebarLinks(); // Then it should render with the empty state message and not show the reports list expect(screen.getByText(translateLocal('common.emptyLHN.title'))).toBeOnTheScreen(); @@ -81,11 +81,12 @@ describe('Sidebar', () => { .then(() => LHNTestUtils.getDefaultRenderedSidebarLinks()) // When Onyx is updated with some personal details - .then(() => - Onyx.multiSet({ - [ONYXKEYS.PERSONAL_DETAILS_LIST]: LHNTestUtils.fakePersonalDetails, - [ONYXKEYS.IS_LOADING_APP]: false, - }), + .then( + () => + void Onyx.multiSet({ + [ONYXKEYS.PERSONAL_DETAILS_LIST]: LHNTestUtils.fakePersonalDetails, + [ONYXKEYS.IS_LOADING_APP]: false, + }), ) // Then the component should be rendered with an empty list since it will get past the early return @@ -107,13 +108,14 @@ describe('Sidebar', () => { .then(() => LHNTestUtils.getDefaultRenderedSidebarLinks(report.reportID)) // When Onyx is updated with the data and the sidebar re-renders - .then(() => - Onyx.multiSet({ - [ONYXKEYS.NVP_PRIORITY_MODE]: CONST.PRIORITY_MODE.DEFAULT, - [ONYXKEYS.PERSONAL_DETAILS_LIST]: LHNTestUtils.fakePersonalDetails, - [ONYXKEYS.IS_LOADING_APP]: false, - ...reportCollectionDataSet, - }), + .then( + () => + void Onyx.multiSet({ + [ONYXKEYS.NVP_PRIORITY_MODE]: CONST.PRIORITY_MODE.DEFAULT, + [ONYXKEYS.PERSONAL_DETAILS_LIST]: LHNTestUtils.fakePersonalDetails, + [ONYXKEYS.IS_LOADING_APP]: false, + ...reportCollectionDataSet, + }), ) // Then the component should be rendered with an item for the report @@ -145,13 +147,14 @@ describe('Sidebar', () => { .then(() => LHNTestUtils.getDefaultRenderedSidebarLinks()) // When Onyx is updated with the data and the sidebar re-renders - .then(() => - Onyx.multiSet({ - [ONYXKEYS.NVP_PRIORITY_MODE]: CONST.PRIORITY_MODE.DEFAULT, - [ONYXKEYS.PERSONAL_DETAILS_LIST]: LHNTestUtils.fakePersonalDetails, - [ONYXKEYS.IS_LOADING_APP]: false, - ...reportCollectionDataSet, - }), + .then( + () => + void Onyx.multiSet({ + [ONYXKEYS.NVP_PRIORITY_MODE]: CONST.PRIORITY_MODE.DEFAULT, + [ONYXKEYS.PERSONAL_DETAILS_LIST]: LHNTestUtils.fakePersonalDetails, + [ONYXKEYS.IS_LOADING_APP]: false, + ...reportCollectionDataSet, + }), ) // Then the component should be rendered with the mostly recently updated report first @@ -194,14 +197,15 @@ describe('Sidebar', () => { .then(() => LHNTestUtils.getDefaultRenderedSidebarLinks(currentReportId)) // When Onyx is updated with the data and the sidebar re-renders - .then(() => - Onyx.multiSet({ - [ONYXKEYS.NVP_PRIORITY_MODE]: CONST.PRIORITY_MODE.DEFAULT, - [ONYXKEYS.PERSONAL_DETAILS_LIST]: LHNTestUtils.fakePersonalDetails, - [ONYXKEYS.IS_LOADING_APP]: false, - [`${ONYXKEYS.COLLECTION.REPORT_DRAFT_COMMENT}${report1.reportID}`]: 'report1 draft', - ...reportCollectionDataSet, - }), + .then( + () => + void Onyx.multiSet({ + [ONYXKEYS.NVP_PRIORITY_MODE]: CONST.PRIORITY_MODE.DEFAULT, + [ONYXKEYS.PERSONAL_DETAILS_LIST]: LHNTestUtils.fakePersonalDetails, + [ONYXKEYS.IS_LOADING_APP]: false, + [`${ONYXKEYS.COLLECTION.REPORT_DRAFT_COMMENT}${report1.reportID}`]: 'report1 draft', + ...reportCollectionDataSet, + }), ) // Then there should be a pencil icon and report one should be the first one because putting a draft on the active report should change its location @@ -242,20 +246,22 @@ describe('Sidebar', () => { .then(() => LHNTestUtils.getDefaultRenderedSidebarLinks()) // When Onyx is updated with the data and the sidebar re-renders - .then(() => - Onyx.multiSet({ - [ONYXKEYS.NVP_PRIORITY_MODE]: CONST.PRIORITY_MODE.DEFAULT, - [ONYXKEYS.PERSONAL_DETAILS_LIST]: LHNTestUtils.fakePersonalDetails, - [ONYXKEYS.IS_LOADING_APP]: false, - ...reportCollectionDataSet, - }), + .then( + () => + void Onyx.multiSet({ + [ONYXKEYS.NVP_PRIORITY_MODE]: CONST.PRIORITY_MODE.DEFAULT, + [ONYXKEYS.PERSONAL_DETAILS_LIST]: LHNTestUtils.fakePersonalDetails, + [ONYXKEYS.IS_LOADING_APP]: false, + ...reportCollectionDataSet, + }), ) // When a new comment is added to report 1 (eg. it's lastVisibleActionCreated is updated) - .then(() => - Onyx.merge(`${ONYXKEYS.COLLECTION.REPORT}${report1.reportID}`, { - lastVisibleActionCreated: DateUtils.getDBTime(), - }), + .then( + () => + void Onyx.merge(`${ONYXKEYS.COLLECTION.REPORT}${report1.reportID}`, { + lastVisibleActionCreated: DateUtils.getDBTime(), + }), ) // Then the order of the reports should be 1 > 3 > 2 @@ -305,13 +311,14 @@ describe('Sidebar', () => { .then(() => LHNTestUtils.getDefaultRenderedSidebarLinks(taskReport.reportID)) // When Onyx is updated with the data and the sidebar re-renders - .then(() => - Onyx.multiSet({ - [ONYXKEYS.NVP_PRIORITY_MODE]: CONST.PRIORITY_MODE.DEFAULT, - [ONYXKEYS.PERSONAL_DETAILS_LIST]: LHNTestUtils.fakePersonalDetails, - [ONYXKEYS.IS_LOADING_APP]: false, - ...reportCollectionDataSet, - }), + .then( + () => + void Onyx.multiSet({ + [ONYXKEYS.NVP_PRIORITY_MODE]: CONST.PRIORITY_MODE.DEFAULT, + [ONYXKEYS.PERSONAL_DETAILS_LIST]: LHNTestUtils.fakePersonalDetails, + [ONYXKEYS.IS_LOADING_APP]: false, + ...reportCollectionDataSet, + }), ) // Then the order of the reports should be 4 > 3 > 2 > 1 @@ -379,13 +386,14 @@ describe('Sidebar', () => { .then(() => LHNTestUtils.getDefaultRenderedSidebarLinks(iouReport.reportID)) // When Onyx is updated with the data and the sidebar re-renders - .then(() => - Onyx.multiSet({ - [ONYXKEYS.NVP_PRIORITY_MODE]: CONST.PRIORITY_MODE.DEFAULT, - [ONYXKEYS.PERSONAL_DETAILS_LIST]: LHNTestUtils.fakePersonalDetails, - [ONYXKEYS.IS_LOADING_APP]: false, - ...reportCollectionDataSet, - }), + .then( + () => + void Onyx.multiSet({ + [ONYXKEYS.NVP_PRIORITY_MODE]: CONST.PRIORITY_MODE.DEFAULT, + [ONYXKEYS.PERSONAL_DETAILS_LIST]: LHNTestUtils.fakePersonalDetails, + [ONYXKEYS.IS_LOADING_APP]: false, + ...reportCollectionDataSet, + }), ) // Then the order of the reports should be 4 > 3 > 2 > 1 @@ -458,14 +466,15 @@ describe('Sidebar', () => { .then(() => LHNTestUtils.getDefaultRenderedSidebarLinks(expenseReport.reportID)) // When Onyx is updated with the data and the sidebar re-renders - .then(() => - Onyx.multiSet({ - [ONYXKEYS.NVP_PRIORITY_MODE]: CONST.PRIORITY_MODE.DEFAULT, - [ONYXKEYS.PERSONAL_DETAILS_LIST]: LHNTestUtils.fakePersonalDetails, - [ONYXKEYS.IS_LOADING_APP]: false, - [`${ONYXKEYS.COLLECTION.POLICY}${fakeReport.policyID}`]: fakePolicy, - ...reportCollectionDataSet, - }), + .then( + () => + void Onyx.multiSet({ + [ONYXKEYS.NVP_PRIORITY_MODE]: CONST.PRIORITY_MODE.DEFAULT, + [ONYXKEYS.PERSONAL_DETAILS_LIST]: LHNTestUtils.fakePersonalDetails, + [ONYXKEYS.IS_LOADING_APP]: false, + [`${ONYXKEYS.COLLECTION.POLICY}${fakeReport.policyID}`]: fakePolicy, + ...reportCollectionDataSet, + }), ) // Then the order of the reports should be 4 > 3 > 2 > 1 @@ -509,21 +518,22 @@ describe('Sidebar', () => { .then(() => LHNTestUtils.getDefaultRenderedSidebarLinks(currentReportId)) // When Onyx is updated with the data and the sidebar re-renders - .then(() => - Onyx.multiSet({ - [ONYXKEYS.NVP_PRIORITY_MODE]: CONST.PRIORITY_MODE.DEFAULT, - [ONYXKEYS.PERSONAL_DETAILS_LIST]: LHNTestUtils.fakePersonalDetails, - [ONYXKEYS.IS_LOADING_APP]: false, - [ONYXKEYS.COLLECTION.REPORT_DRAFT_COMMENT + report2.reportID]: 'This is a draft', - ...reportCollectionDataSet, - }), + .then( + () => + void Onyx.multiSet({ + [ONYXKEYS.NVP_PRIORITY_MODE]: CONST.PRIORITY_MODE.DEFAULT, + [ONYXKEYS.PERSONAL_DETAILS_LIST]: LHNTestUtils.fakePersonalDetails, + [ONYXKEYS.IS_LOADING_APP]: false, + [ONYXKEYS.COLLECTION.REPORT_DRAFT_COMMENT + report2.reportID]: 'This is a draft', + ...reportCollectionDataSet, + }), ) // When the currently active chat is switched to report 1 (the one on the bottom) .then(() => { // The changing of a route itself will re-render the component in the App, but since we are not performing this test // inside the navigator and it has no access to the routes we need to trigger an update to the SidebarLinks manually. - LHNTestUtils.getDefaultRenderedSidebarLinks(report1.reportID); + void LHNTestUtils.getDefaultRenderedSidebarLinks(report1.reportID); return waitForBatchedUpdates(); }) @@ -556,14 +566,15 @@ describe('Sidebar', () => { .then(() => LHNTestUtils.getDefaultRenderedSidebarLinks()) // When Onyx is updated with the data and the sidebar re-renders - .then(() => - Onyx.multiSet({ - [ONYXKEYS.NVP_PRIORITY_MODE]: CONST.PRIORITY_MODE.DEFAULT, - [ONYXKEYS.PERSONAL_DETAILS_LIST]: LHNTestUtils.fakePersonalDetails, - [ONYXKEYS.IS_LOADING_APP]: false, - [`${ONYXKEYS.COLLECTION.REPORT_DRAFT_COMMENT}${report.reportID}`]: 'This is a draft', - ...reportCollectionDataSet, - }), + .then( + () => + void Onyx.multiSet({ + [ONYXKEYS.NVP_PRIORITY_MODE]: CONST.PRIORITY_MODE.DEFAULT, + [ONYXKEYS.PERSONAL_DETAILS_LIST]: LHNTestUtils.fakePersonalDetails, + [ONYXKEYS.IS_LOADING_APP]: false, + [`${ONYXKEYS.COLLECTION.REPORT_DRAFT_COMMENT}${report.reportID}`]: 'This is a draft', + ...reportCollectionDataSet, + }), ) // Then there should be a pencil icon showing @@ -598,13 +609,14 @@ describe('Sidebar', () => { .then(() => LHNTestUtils.getDefaultRenderedSidebarLinks()) // When Onyx is updated with the data and the sidebar re-renders - .then(() => - Onyx.multiSet({ - [ONYXKEYS.NVP_PRIORITY_MODE]: CONST.PRIORITY_MODE.DEFAULT, - [ONYXKEYS.PERSONAL_DETAILS_LIST]: LHNTestUtils.fakePersonalDetails, - [ONYXKEYS.IS_LOADING_APP]: false, - ...reportCollectionDataSet, - }), + .then( + () => + void Onyx.multiSet({ + [ONYXKEYS.NVP_PRIORITY_MODE]: CONST.PRIORITY_MODE.DEFAULT, + [ONYXKEYS.PERSONAL_DETAILS_LIST]: LHNTestUtils.fakePersonalDetails, + [ONYXKEYS.IS_LOADING_APP]: false, + ...reportCollectionDataSet, + }), ) // Then there should be a pencil icon showing @@ -682,14 +694,15 @@ describe('Sidebar', () => { .then(() => LHNTestUtils.getDefaultRenderedSidebarLinks(currentReportId)) // When Onyx is updated with the data and the sidebar re-renders - .then(() => - Onyx.multiSet({ - [ONYXKEYS.NVP_PRIORITY_MODE]: CONST.PRIORITY_MODE.DEFAULT, - [ONYXKEYS.PERSONAL_DETAILS_LIST]: LHNTestUtils.fakePersonalDetails, - [ONYXKEYS.IS_LOADING_APP]: false, - [`${ONYXKEYS.COLLECTION.REPORT_DRAFT_COMMENT}${report2.reportID}`]: 'Report2 draft comment', - ...reportCollectionDataSet, - }), + .then( + () => + void Onyx.multiSet({ + [ONYXKEYS.NVP_PRIORITY_MODE]: CONST.PRIORITY_MODE.DEFAULT, + [ONYXKEYS.PERSONAL_DETAILS_LIST]: LHNTestUtils.fakePersonalDetails, + [ONYXKEYS.IS_LOADING_APP]: false, + [`${ONYXKEYS.COLLECTION.REPORT_DRAFT_COMMENT}${report2.reportID}`]: 'Report2 draft comment', + ...reportCollectionDataSet, + }), ) // Then the reports are ordered by Pinned / GBR > Draft > Rest @@ -740,13 +753,14 @@ describe('Sidebar', () => { .then(() => LHNTestUtils.getDefaultRenderedSidebarLinks('0')) // When Onyx is updated with the data and the sidebar re-renders - .then(() => - Onyx.multiSet({ - [ONYXKEYS.NVP_PRIORITY_MODE]: CONST.PRIORITY_MODE.DEFAULT, - [ONYXKEYS.PERSONAL_DETAILS_LIST]: LHNTestUtils.fakePersonalDetails, - [ONYXKEYS.IS_LOADING_APP]: false, - ...reportCollectionDataSet, - }), + .then( + () => + void Onyx.multiSet({ + [ONYXKEYS.NVP_PRIORITY_MODE]: CONST.PRIORITY_MODE.DEFAULT, + [ONYXKEYS.PERSONAL_DETAILS_LIST]: LHNTestUtils.fakePersonalDetails, + [ONYXKEYS.IS_LOADING_APP]: false, + ...reportCollectionDataSet, + }), ) // Then the reports are in alphabetical order @@ -802,14 +816,15 @@ describe('Sidebar', () => { .then(() => LHNTestUtils.getDefaultRenderedSidebarLinks('0')) // When Onyx is updated with the data and the sidebar re-renders - .then(() => - Onyx.multiSet({ - [ONYXKEYS.NVP_PRIORITY_MODE]: CONST.PRIORITY_MODE.DEFAULT, - [ONYXKEYS.PERSONAL_DETAILS_LIST]: LHNTestUtils.fakePersonalDetails, - [ONYXKEYS.IS_LOADING_APP]: false, - ...reportDraftCommentCollectionDataSet, - ...reportCollectionDataSet, - }), + .then( + () => + void Onyx.multiSet({ + [ONYXKEYS.NVP_PRIORITY_MODE]: CONST.PRIORITY_MODE.DEFAULT, + [ONYXKEYS.PERSONAL_DETAILS_LIST]: LHNTestUtils.fakePersonalDetails, + [ONYXKEYS.IS_LOADING_APP]: false, + ...reportDraftCommentCollectionDataSet, + ...reportCollectionDataSet, + }), ) // Then the reports are in alphabetical order @@ -823,13 +838,14 @@ describe('Sidebar', () => { }) // When a new report is added - .then(() => - Onyx.multiSet({ - ...reportDraftCommentCollectionDataSet, - [`${ONYXKEYS.COLLECTION.REPORT_DRAFT_COMMENT}${report4.reportID}`]: 'report4 draft', - [`${ONYXKEYS.COLLECTION.REPORT}${report4.reportID}`]: report4, - ...reportCollectionDataSet, - }), + .then( + () => + void Onyx.multiSet({ + ...reportDraftCommentCollectionDataSet, + [`${ONYXKEYS.COLLECTION.REPORT_DRAFT_COMMENT}${report4.reportID}`]: 'report4 draft', + [`${ONYXKEYS.COLLECTION.REPORT}${report4.reportID}`]: report4, + ...reportCollectionDataSet, + }), ) // Then they are still in alphabetical order @@ -873,15 +889,16 @@ describe('Sidebar', () => { .then(() => LHNTestUtils.getDefaultRenderedSidebarLinks('0')) // When Onyx is updated with the data and the sidebar re-renders - .then(() => - Onyx.multiSet({ - [ONYXKEYS.BETAS]: betas, - [ONYXKEYS.NVP_PRIORITY_MODE]: CONST.PRIORITY_MODE.DEFAULT, - [ONYXKEYS.PERSONAL_DETAILS_LIST]: LHNTestUtils.fakePersonalDetails, - [ONYXKEYS.IS_LOADING_APP]: false, - ...reportNameValuePairsCollectionDataSet, - ...reportCollectionDataSet, - }), + .then( + () => + void Onyx.multiSet({ + [ONYXKEYS.BETAS]: betas, + [ONYXKEYS.NVP_PRIORITY_MODE]: CONST.PRIORITY_MODE.DEFAULT, + [ONYXKEYS.PERSONAL_DETAILS_LIST]: LHNTestUtils.fakePersonalDetails, + [ONYXKEYS.IS_LOADING_APP]: false, + ...reportNameValuePairsCollectionDataSet, + ...reportCollectionDataSet, + }), ) // Then the first report is in last position @@ -918,13 +935,14 @@ describe('Sidebar', () => { .then(() => LHNTestUtils.getDefaultRenderedSidebarLinks('0')) // When Onyx is updated with the data and the sidebar re-renders - .then(() => - Onyx.multiSet({ - [ONYXKEYS.NVP_PRIORITY_MODE]: CONST.PRIORITY_MODE.DEFAULT, - [ONYXKEYS.PERSONAL_DETAILS_LIST]: LHNTestUtils.fakePersonalDetails, - [ONYXKEYS.IS_LOADING_APP]: false, - ...reportCollectionDataSet, - }), + .then( + () => + void Onyx.multiSet({ + [ONYXKEYS.NVP_PRIORITY_MODE]: CONST.PRIORITY_MODE.DEFAULT, + [ONYXKEYS.PERSONAL_DETAILS_LIST]: LHNTestUtils.fakePersonalDetails, + [ONYXKEYS.IS_LOADING_APP]: false, + ...reportCollectionDataSet, + }), ) // Then the reports are ordered alphabetically since their lastVisibleActionCreated are the same @@ -959,12 +977,13 @@ describe('Sidebar', () => { .then(() => LHNTestUtils.getDefaultRenderedSidebarLinks('0')) // Given the sidebar is rendered in #focus mode (hides read chats) // with all reports having unread comments - .then(() => - Onyx.multiSet({ - [ONYXKEYS.NVP_PRIORITY_MODE]: CONST.PRIORITY_MODE.GSD, - [ONYXKEYS.IS_LOADING_APP]: false, - ...reportCollectionDataSet, - }), + .then( + () => + void Onyx.multiSet({ + [ONYXKEYS.NVP_PRIORITY_MODE]: CONST.PRIORITY_MODE.GSD, + [ONYXKEYS.IS_LOADING_APP]: false, + ...reportCollectionDataSet, + }), ) // Then the reports are in alphabetical order @@ -1020,15 +1039,16 @@ describe('Sidebar', () => { .then(() => LHNTestUtils.getDefaultRenderedSidebarLinks('0')) // When Onyx is updated with the data and the sidebar re-renders - .then(() => - Onyx.multiSet({ - [ONYXKEYS.BETAS]: betas, - [ONYXKEYS.NVP_PRIORITY_MODE]: CONST.PRIORITY_MODE.GSD, - [ONYXKEYS.PERSONAL_DETAILS_LIST]: LHNTestUtils.fakePersonalDetails, - [ONYXKEYS.IS_LOADING_APP]: false, - ...reportNameValuePairsCollectionDataSet, - ...reportCollectionDataSet, - }), + .then( + () => + void Onyx.multiSet({ + [ONYXKEYS.BETAS]: betas, + [ONYXKEYS.NVP_PRIORITY_MODE]: CONST.PRIORITY_MODE.GSD, + [ONYXKEYS.PERSONAL_DETAILS_LIST]: LHNTestUtils.fakePersonalDetails, + [ONYXKEYS.IS_LOADING_APP]: false, + ...reportNameValuePairsCollectionDataSet, + ...reportCollectionDataSet, + }), ) // Then the first report is in last position diff --git a/tests/unit/SidebarTest.ts b/tests/unit/SidebarTest.ts index 92dd3dc1e49f..3ea7783e093a 100644 --- a/tests/unit/SidebarTest.ts +++ b/tests/unit/SidebarTest.ts @@ -34,14 +34,14 @@ describe('Sidebar', () => { beforeEach(() => { // Wrap Onyx each onyx action with waitForBatchedUpdates wrapOnyxWithWaitForBatchedUpdates(Onyx); - Onyx.set(ONYXKEYS.NVP_PREFERRED_LOCALE, CONST.LOCALES.EN); + void Onyx.set(ONYXKEYS.NVP_PREFERRED_LOCALE, CONST.LOCALES.EN); // Initialize the network key for OfflineWithFeedback return TestHelper.signInWithTestUser(TEST_USER_ACCOUNT_ID, TEST_USER_LOGIN).then(() => Onyx.merge(ONYXKEYS.NETWORK, {isOffline: false})); }); // Clear out Onyx after each test so that each test starts with a clean slate afterEach(() => { - Onyx.clear(); + void Onyx.clear(); }); describe('archived chats', () => { diff --git a/tests/unit/SidebarUtilsTest.ts b/tests/unit/SidebarUtilsTest.ts index 7d9909c32dc9..2835ab641ddf 100644 --- a/tests/unit/SidebarUtilsTest.ts +++ b/tests/unit/SidebarUtilsTest.ts @@ -59,7 +59,7 @@ describe('SidebarUtils', () => { }); afterAll(async () => { - Onyx.clear(); + void Onyx.clear(); await waitForBatchedUpdates(); }); @@ -756,10 +756,11 @@ describe('SidebarUtils', () => { return ( waitForBatchedUpdates() // When Onyx is updated to contain that report - .then(() => - Onyx.multiSet({ - [ONYXKEYS.PERSONAL_DETAILS_LIST]: LHNTestUtils.fakePersonalDetails, - }), + .then( + () => + void Onyx.multiSet({ + [ONYXKEYS.PERSONAL_DETAILS_LIST]: LHNTestUtils.fakePersonalDetails, + }), ) .then(() => { const result = SidebarUtils.getWelcomeMessage(MOCK_REPORT, undefined, participantPersonalDetailList, localeCompare); @@ -946,7 +947,7 @@ describe('SidebarUtils', () => { describe('Alternative text', () => { afterEach(async () => { - Onyx.clear(); + void Onyx.clear(); await waitForBatchedUpdates(); }); it('The text should not contain the policy name at prefix if the report is not related to a workspace', async () => { diff --git a/tests/unit/TransactionPreviewUtils.test.ts b/tests/unit/TransactionPreviewUtils.test.ts index e64678081776..56a6d37a72dd 100644 --- a/tests/unit/TransactionPreviewUtils.test.ts +++ b/tests/unit/TransactionPreviewUtils.test.ts @@ -221,10 +221,10 @@ describe('TransactionPreviewUtils', () => { describe('createTransactionPreviewConditionals', () => { beforeAll(() => { - Onyx.merge(ONYXKEYS.SESSION, {accountID: 999}); + void Onyx.merge(ONYXKEYS.SESSION, {accountID: 999}); }); afterAll(() => { - Onyx.clear([ONYXKEYS.SESSION]); + void Onyx.clear([ONYXKEYS.SESSION]); }); it('should determine RBR visibility according to violation and hold conditions', () => { diff --git a/tests/unit/WorkspacesSettingsUtilsTest.ts b/tests/unit/WorkspacesSettingsUtilsTest.ts index 83177cd50487..975927454213 100644 --- a/tests/unit/WorkspacesSettingsUtilsTest.ts +++ b/tests/unit/WorkspacesSettingsUtilsTest.ts @@ -22,7 +22,7 @@ describe('WorkspacesSettingsUtils', () => { beforeEach(() => { global.fetch = TestHelper.getGlobalFetchMock(); - Onyx.clear([ONYXKEYS.NVP_PREFERRED_LOCALE]).then(waitForBatchedUpdates); + void Onyx.clear([ONYXKEYS.NVP_PREFERRED_LOCALE]).then(waitForBatchedUpdates); IntlStore.load(CONST.LOCALES.EN); return waitForBatchedUpdates(); }); diff --git a/tests/unit/canEditFieldOfMoneyRequestTest.ts b/tests/unit/canEditFieldOfMoneyRequestTest.ts index dd684124ff5c..21f3b2549b9d 100644 --- a/tests/unit/canEditFieldOfMoneyRequestTest.ts +++ b/tests/unit/canEditFieldOfMoneyRequestTest.ts @@ -31,7 +31,7 @@ describe('canEditFieldOfMoneyRequest', () => { Onyx.init({keys: ONYXKEYS}); const policyCollectionDataSet = toCollectionDataSet(ONYXKEYS.COLLECTION.POLICY, [policy], (current) => current.id); - Onyx.multiSet({ + void Onyx.multiSet({ [ONYXKEYS.SESSION]: {email: currentUserEmail, accountID: currentUserAccountID}, ...policyCollectionDataSet, }); @@ -91,15 +91,15 @@ describe('canEditFieldOfMoneyRequest', () => { }; beforeEach(() => { - Onyx.merge(`${ONYXKEYS.COLLECTION.TRANSACTION}${IOUTransactionID}`, moneyRequestTransaction); - Onyx.merge(`${ONYXKEYS.COLLECTION.REPORT}${IOUReportID}`, invoiceReport); - Onyx.merge(`${ONYXKEYS.COLLECTION.REPORT}${483}`, outstandingExpenseReport); - Onyx.merge(`${ONYXKEYS.COLLECTION.POLICY}${policyID}`, policy1); + void Onyx.merge(`${ONYXKEYS.COLLECTION.TRANSACTION}${IOUTransactionID}`, moneyRequestTransaction); + void Onyx.merge(`${ONYXKEYS.COLLECTION.REPORT}${IOUReportID}`, invoiceReport); + void Onyx.merge(`${ONYXKEYS.COLLECTION.REPORT}${483}`, outstandingExpenseReport); + void Onyx.merge(`${ONYXKEYS.COLLECTION.POLICY}${policyID}`, policy1); return waitForBatchedUpdates(); }); afterEach(() => { - Onyx.clear(); + void Onyx.clear(); return waitForBatchedUpdates(); }); @@ -184,7 +184,7 @@ describe('canEditFieldOfMoneyRequest', () => { beforeEach(() => { const policyCollectionDataSet = toCollectionDataSet(ONYXKEYS.COLLECTION.POLICY, [expensePolicy], (current) => current.id); - Onyx.multiSet({ + void Onyx.multiSet({ [`${ONYXKEYS.COLLECTION.TRANSACTION}${IOUTransactionID}`]: moneyRequestTransaction, ...policyCollectionDataSet, }); @@ -192,7 +192,7 @@ describe('canEditFieldOfMoneyRequest', () => { }); afterEach(() => { - Onyx.clear(); + void Onyx.clear(); return waitForBatchedUpdates(); }); diff --git a/tests/unit/enhanceParametersTest.ts b/tests/unit/enhanceParametersTest.ts index 799e80e381da..f5c2952b95b0 100644 --- a/tests/unit/enhanceParametersTest.ts +++ b/tests/unit/enhanceParametersTest.ts @@ -13,7 +13,7 @@ test('Enhance parameters adds correct parameters for Log command with no authTok const parameters = {testParameter: 'test'}; const email = 'test-user@test.com'; const authToken = 'test-token'; - Onyx.merge(ONYXKEYS.SESSION, {email, authToken}); + void Onyx.merge(ONYXKEYS.SESSION, {email, authToken}); return waitForBatchedUpdates().then(() => { const finalParameters = enhanceParameters(command, parameters); expect(finalParameters).toEqual({ @@ -34,7 +34,7 @@ test('Enhance parameters adds correct parameters for a command that requires aut const parameters = {testParameter: 'test'}; const email = 'test-user@test.com'; const authToken = 'test-token'; - Onyx.merge(ONYXKEYS.SESSION, {email, authToken}); + void Onyx.merge(ONYXKEYS.SESSION, {email, authToken}); return waitForBatchedUpdates().then(() => { const finalParameters = enhanceParameters(command, parameters); expect(finalParameters).toEqual({ diff --git a/tests/unit/useCurrentReportIDTest.tsx b/tests/unit/useCurrentReportIDTest.tsx index c4620ca5eaa1..9b919efa7dd5 100644 --- a/tests/unit/useCurrentReportIDTest.tsx +++ b/tests/unit/useCurrentReportIDTest.tsx @@ -30,12 +30,12 @@ describe('useCurrentReportID', () => { beforeEach(() => { jest.clearAllMocks(); - Onyx.clear(); + void Onyx.clear(); return waitForBatchedUpdates(); }); afterAll(async () => { - Onyx.clear(); + void Onyx.clear(); await waitForBatchedUpdates(); }); diff --git a/tests/unit/useIOUUtilsTest.ts b/tests/unit/useIOUUtilsTest.ts index fd02258e02dc..be4334ebebbf 100644 --- a/tests/unit/useIOUUtilsTest.ts +++ b/tests/unit/useIOUUtilsTest.ts @@ -32,7 +32,7 @@ describe('useIOUUtils', () => { }); it('returns true when lastLocationPermissionPrompt is null', async () => { - Onyx.set(ONYXKEYS.NVP_LAST_LOCATION_PERMISSION_PROMPT, null); + void Onyx.set(ONYXKEYS.NVP_LAST_LOCATION_PERMISSION_PROMPT, null); await waitForBatchedUpdatesWithAct(); const {result} = renderHook(() => useIOUUtils()); @@ -42,7 +42,7 @@ describe('useIOUUtils', () => { }); it('returns true when lastLocationPermissionPrompt is empty string', async () => { - Onyx.set(ONYXKEYS.NVP_LAST_LOCATION_PERMISSION_PROMPT, ''); + void Onyx.set(ONYXKEYS.NVP_LAST_LOCATION_PERMISSION_PROMPT, ''); await waitForBatchedUpdatesWithAct(); const {result} = renderHook(() => useIOUUtils()); @@ -53,7 +53,7 @@ describe('useIOUUtils', () => { it('returns false when lastLocationPermissionPrompt is a valid date string within threshold', async () => { const recentDate = daysAgo(CONST.IOU.LOCATION_PERMISSION_PROMPT_THRESHOLD_DAYS - 1); - Onyx.set(ONYXKEYS.NVP_LAST_LOCATION_PERMISSION_PROMPT, recentDate); + void Onyx.set(ONYXKEYS.NVP_LAST_LOCATION_PERMISSION_PROMPT, recentDate); await waitForBatchedUpdatesWithAct(); const {result} = renderHook(() => useIOUUtils()); @@ -64,7 +64,7 @@ describe('useIOUUtils', () => { it('returns true when lastLocationPermissionPrompt is a valid date string outside threshold', async () => { const oldDate = daysAgo(CONST.IOU.LOCATION_PERMISSION_PROMPT_THRESHOLD_DAYS + 1); - Onyx.set(ONYXKEYS.NVP_LAST_LOCATION_PERMISSION_PROMPT, oldDate); + void Onyx.set(ONYXKEYS.NVP_LAST_LOCATION_PERMISSION_PROMPT, oldDate); await waitForBatchedUpdatesWithAct(); const {result} = renderHook(() => useIOUUtils()); @@ -74,7 +74,7 @@ describe('useIOUUtils', () => { }); it('returns false when lastLocationPermissionPrompt is an invalid date string', async () => { - Onyx.set(ONYXKEYS.NVP_LAST_LOCATION_PERMISSION_PROMPT, 'not-a-date'); + void Onyx.set(ONYXKEYS.NVP_LAST_LOCATION_PERMISSION_PROMPT, 'not-a-date'); await waitForBatchedUpdatesWithAct(); const {result} = renderHook(() => useIOUUtils()); @@ -85,7 +85,7 @@ describe('useIOUUtils', () => { it('returns false when lastLocationPermissionPrompt is exactly at threshold', async () => { const thresholdDate = daysAgo(CONST.IOU.LOCATION_PERMISSION_PROMPT_THRESHOLD_DAYS); - Onyx.set(ONYXKEYS.NVP_LAST_LOCATION_PERMISSION_PROMPT, thresholdDate); + void Onyx.set(ONYXKEYS.NVP_LAST_LOCATION_PERMISSION_PROMPT, thresholdDate); await waitForBatchedUpdatesWithAct(); const {result} = renderHook(() => useIOUUtils()); @@ -101,13 +101,13 @@ describe('useIOUUtils', () => { expect(result.current.shouldStartLocationPermissionFlow()).toBe(true); const recentDate = daysAgo(CONST.IOU.LOCATION_PERMISSION_PROMPT_THRESHOLD_DAYS - 1); - Onyx.set(ONYXKEYS.NVP_LAST_LOCATION_PERMISSION_PROMPT, recentDate); + void Onyx.set(ONYXKEYS.NVP_LAST_LOCATION_PERMISSION_PROMPT, recentDate); await waitForBatchedUpdatesWithAct(); expect(result.current.shouldStartLocationPermissionFlow()).toBe(false); const oldDate = daysAgo(CONST.IOU.LOCATION_PERMISSION_PROMPT_THRESHOLD_DAYS + 1); - Onyx.set(ONYXKEYS.NVP_LAST_LOCATION_PERMISSION_PROMPT, oldDate); + void Onyx.set(ONYXKEYS.NVP_LAST_LOCATION_PERMISSION_PROMPT, oldDate); await waitForBatchedUpdatesWithAct(); expect(result.current.shouldStartLocationPermissionFlow()).toBe(true); diff --git a/tests/unit/useParticipantsInvoiceReportTest.ts b/tests/unit/useParticipantsInvoiceReportTest.ts index c3a8673a3fe6..a359c5c9548e 100644 --- a/tests/unit/useParticipantsInvoiceReportTest.ts +++ b/tests/unit/useParticipantsInvoiceReportTest.ts @@ -50,7 +50,7 @@ describe('useParticipantsInvoiceReport', () => { }); afterEach(() => { - Onyx.clear(); + void Onyx.clear(); }); it('should return the invoice report when there is an active individual invoice report', async () => { @@ -104,7 +104,7 @@ describe('useParticipantsInvoiceReport', () => { }); afterAll(() => { - Onyx.clear(); + void Onyx.clear(); }); it('should return the invoice report when there is an active business invoice report', async () => { diff --git a/tests/unit/usePermissionsTest.tsx b/tests/unit/usePermissionsTest.tsx index 445250839a81..6f3a86cfcc5b 100644 --- a/tests/unit/usePermissionsTest.tsx +++ b/tests/unit/usePermissionsTest.tsx @@ -26,7 +26,7 @@ describe('usePermissions', () => { }); it('should handle empty betas gracefully via Onyx', async () => { - Onyx.set(ONYXKEYS.BETAS, []); + void Onyx.set(ONYXKEYS.BETAS, []); await waitForBatchedUpdatesWithAct(); const {result} = renderHook(() => usePermissions(), {wrapper: Wrapper}); @@ -39,7 +39,7 @@ describe('usePermissions', () => { it('should return correct permissions when betas are provided via Onyx', async () => { const mockBetas = [CONST.BETAS.ALL]; - Onyx.set(ONYXKEYS.BETAS, mockBetas); + void Onyx.set(ONYXKEYS.BETAS, mockBetas); await waitForBatchedUpdatesWithAct(); const {result} = renderHook(() => usePermissions(), {wrapper: Wrapper}); @@ -55,7 +55,7 @@ describe('usePermissions', () => { const initialBetas = [CONST.BETAS.DEFAULT_ROOMS, CONST.BETAS.PER_DIEM, CONST.BETAS.PREVENT_SPOTNANA_TRAVEL]; const updatedBetas = [CONST.BETAS.ALL]; - Onyx.set(ONYXKEYS.BETAS, initialBetas); + void Onyx.set(ONYXKEYS.BETAS, initialBetas); await waitForBatchedUpdatesWithAct(); const {result} = renderHook(() => usePermissions(), {wrapper: Wrapper}); @@ -67,7 +67,7 @@ describe('usePermissions', () => { expect(result.current.isBetaEnabled(CONST.BETAS.PREVENT_SPOTNANA_TRAVEL)).toBe(true); expect(result.current.isBetaEnabled(CONST.BETAS.ALL)).toBe(false); - Onyx.merge(ONYXKEYS.BETAS, updatedBetas); + void Onyx.merge(ONYXKEYS.BETAS, updatedBetas); await waitForBatchedUpdatesWithAct(); @@ -87,8 +87,8 @@ describe('usePermissions', () => { // Test explicit only beta behavior // Given: Account with 'all' beta enabled, but not the explicit only beta - Onyx.set(ONYXKEYS.BETAS, [CONST.BETAS.ALL]); - Onyx.set(ONYXKEYS.BETA_CONFIGURATION, betaConfiguration); + void Onyx.set(ONYXKEYS.BETAS, [CONST.BETAS.ALL]); + void Onyx.set(ONYXKEYS.BETA_CONFIGURATION, betaConfiguration); await waitForBatchedUpdatesWithAct(); const {result} = renderHook(() => usePermissions(), {wrapper: Wrapper}); @@ -99,7 +99,7 @@ describe('usePermissions', () => { expect(result.current.isBetaEnabled(explicitOnlyBeta)).toBe(false); // Given: The explicit only beta is explicitly enabled - Onyx.set(ONYXKEYS.BETAS, [CONST.BETAS.ALL, explicitOnlyBeta]); + void Onyx.set(ONYXKEYS.BETAS, [CONST.BETAS.ALL, explicitOnlyBeta]); await waitForBatchedUpdatesWithAct(); // When: Checking if the account is in the explicit only beta @@ -108,7 +108,7 @@ describe('usePermissions', () => { // Test exclusion beta behavior // Given: Account with 'all' beta enabled, but not the exclusion beta - Onyx.set(ONYXKEYS.BETAS, [CONST.BETAS.ALL]); + void Onyx.set(ONYXKEYS.BETAS, [CONST.BETAS.ALL]); await waitForBatchedUpdatesWithAct(); // When: Checking if the account is in the exclusion beta @@ -116,7 +116,7 @@ describe('usePermissions', () => { expect(result.current.isBetaEnabled(exclusionBeta)).toBe(false); // Given: The exclusion beta is explicitly enabled - Onyx.set(ONYXKEYS.BETAS, [CONST.BETAS.ALL, exclusionBeta]); + void Onyx.set(ONYXKEYS.BETAS, [CONST.BETAS.ALL, exclusionBeta]); await waitForBatchedUpdatesWithAct(); // When: Checking if the account is in the exclusion beta @@ -124,7 +124,7 @@ describe('usePermissions', () => { expect(result.current.isBetaEnabled(exclusionBeta)).toBe(true); // Given: Neither 'all' nor the exclusion beta are enabled - Onyx.set(ONYXKEYS.BETAS, []); + void Onyx.set(ONYXKEYS.BETAS, []); await waitForBatchedUpdatesWithAct(); // When: Checking if the account is in the exclusion beta diff --git a/tests/unit/useReportPreviewSenderIDTest.ts b/tests/unit/useReportPreviewSenderIDTest.ts index 95b81efc6a7e..2f1b617ff398 100644 --- a/tests/unit/useReportPreviewSenderIDTest.ts +++ b/tests/unit/useReportPreviewSenderIDTest.ts @@ -46,7 +46,7 @@ describe('useReportPreviewSenderID', () => { }); beforeEach(() => { - Onyx.multiSet({ + void Onyx.multiSet({ ...reportActionCollectionDataSet, ...transactionCollectionDataSet, }); @@ -54,7 +54,7 @@ describe('useReportPreviewSenderID', () => { }); afterEach(() => { - Onyx.clear(); + void Onyx.clear(); return waitForBatchedUpdates(); }); diff --git a/tests/unit/useSidebarOrderedReportsTest.tsx b/tests/unit/useSidebarOrderedReportsTest.tsx index 4f660b3861e0..c4b9c368f3bc 100644 --- a/tests/unit/useSidebarOrderedReportsTest.tsx +++ b/tests/unit/useSidebarOrderedReportsTest.tsx @@ -41,7 +41,7 @@ describe('useSidebarOrderedReports', () => { beforeEach(async () => { jest.clearAllMocks(); - Onyx.clear(); + void Onyx.clear(); // Set up basic session data for each test await Onyx.set(ONYXKEYS.SESSION, { @@ -71,7 +71,7 @@ describe('useSidebarOrderedReports', () => { }); afterAll(async () => { - Onyx.clear(); + void Onyx.clear(); await waitForBatchedUpdates(); }); diff --git a/tests/utils/TestHelper.ts b/tests/utils/TestHelper.ts index e476fafbf72f..b214c55275ae 100644 --- a/tests/utils/TestHelper.ts +++ b/tests/utils/TestHelper.ts @@ -311,7 +311,7 @@ function expectAPICommandToHaveBeenCalledWith(comma } function setPersonalDetails(login: string, accountID: number) { - Onyx.merge(ONYXKEYS.PERSONAL_DETAILS_LIST, { + void Onyx.merge(ONYXKEYS.PERSONAL_DETAILS_LIST, { [accountID]: buildPersonalDetails(login, accountID), }); return waitForBatchedUpdates();