Skip to content

Implement erlang:system_time/0 nif #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: old-swm
Choose a base branch
from
Open

Implement erlang:system_time/0 nif #158

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion libs/estdlib/src/erlang.erl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,8 @@
localtime/0,
unique_integer/0,
unique_integer/1,
bump_reductions/1
bump_reductions/1,
system_time/0
]).

-export_type([
Expand Down Expand Up @@ -1414,3 +1415,12 @@ module_loaded(_Module) ->
-spec bump_reductions(pos_integer()) -> true.
bump_reductions(Reductions) when is_integer(Reductions), Reductions > 1 ->
erlang:nif_error(undefined).

%%-----------------------------------------------------------------------------
%% @returns An integer representing system time.
%% @doc Returns the current OS system time in nanoseconds.
%% @end
%%-----------------------------------------------------------------------------
-spec system_time() -> integer().
system_time() ->
erlang:nif_error(undefined).
12 changes: 7 additions & 5 deletions src/libAtomVM/nifs.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ static term nif_erlang_setelement_3(Context *ctx, int argc, term argv[]);
static term nif_erlang_spawn_opt(Context *ctx, int argc, term argv[]);
static term nif_erlang_spawn_fun_opt(Context *ctx, int argc, term argv[]);
static term nif_erlang_whereis_1(Context *ctx, int argc, term argv[]);
static term nif_erlang_system_time_1(Context *ctx, int argc, term argv[]);
static term nif_erlang_system_time(Context *ctx, int argc, term argv[]);
static term nif_erlang_tuple_to_list_1(Context *ctx, int argc, term argv[]);
static term nif_erlang_list_to_tuple_1(Context *ctx, int argc, term argv[]);
static term nif_erlang_universaltime_0(Context *ctx, int argc, term argv[]);
Expand Down Expand Up @@ -574,7 +574,7 @@ static const struct Nif monotonic_time_nif =
static const struct Nif system_time_nif =
{
.base.type = NIFFunctionType,
.nif_ptr = nif_erlang_system_time_1
.nif_ptr = nif_erlang_system_time
};

static const struct Nif universaltime_nif =
Expand Down Expand Up @@ -1748,13 +1748,15 @@ term nif_erlang_monotonic_time_1(Context *ctx, int argc, term argv[])
}
}

term nif_erlang_system_time_1(Context *ctx, int argc, term argv[])
term nif_erlang_system_time(Context *ctx, int argc, term argv[])
{
UNUSED(argc);

struct timespec ts;
sys_time(&ts);

if (argc == 0) {
return make_maybe_boxed_int64(ctx, ((int64_t) ts.tv_sec) * 1000000000ULL + ts.tv_nsec);
}

if (argv[0] == SECOND_ATOM) {
return make_maybe_boxed_int64(ctx, ts.tv_sec);

Expand Down
1 change: 1 addition & 0 deletions src/libAtomVM/nifs.gperf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,7 @@ erlang:whereis/1, &whereis_nif
erlang:++/2, &concat_nif
erlang:--/2, &erlang_lists_subtract_nif
erlang:monotonic_time/1, &monotonic_time_nif
erlang:system_time/0, &system_time_nif
erlang:system_time/1, &system_time_nif
erlang:tuple_to_list/1, &tuple_to_list_nif
erlang:universaltime/0, &universaltime_nif
Expand Down
20 changes: 15 additions & 5 deletions tests/erlang_tests/test_system_time.erl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,18 +23,28 @@
-export([start/0]).

start() ->
ok = test_system_time(second, 1001),
ok = test_system_time(millisecond, 10),
ok = test_system_time(microsecond, 1),
ok = test_system_time(native, 1),
ok = test_system_time(10),
ok = test_system_time(1),

ok = test_system_time_unit(second, 1001),
ok = test_system_time_unit(millisecond, 10),
ok = test_system_time_unit(microsecond, 1),
ok = test_system_time_unit(native, 1),

ok = expect(fun() -> erlang:system_time(not_a_time_unit) end, badarg),

ok = test_system_time_to_universal_time(),

0.

test_system_time(Unit, SleepMs) ->
test_system_time(SleepMs) ->
Before = verify_system_time_value(erlang:system_time()),
sleep(SleepMs),
After = verify_system_time_value(erlang:system_time()),
true = (After > Before),
ok.

test_system_time_unit(Unit, SleepMs) ->
Before = verify_system_time_value(erlang:system_time(Unit)),
sleep(SleepMs),
After = verify_system_time_value(erlang:system_time(Unit)),
Expand Down