Refactor hardware detail bandwidth allocation and add more unit test.

Author: Fernando Ojeda

SoftLayer/CLI/hardware/detail.py

@@ -99,12 +99,10 @@ def _bw_table(bw_data):
         allotment = 'N/A'
         if bw_point['type']['alias'] == 'PUBLIC_SERVER_BW':
             bw_type = 'Public'
-            if bw_data.get('allotment') is None:
+            if not bw_data.get('allotment'):
                 allotment = '-'
             else:
                 allotment = utils.lookup(bw_data, 'allotment', 'amount')
-                if allotment is None:
-                    allotment = '-'
 
         table.add_row([bw_type, bw_point['amountIn'], bw_point['amountOut'], allotment])
     return table

SoftLayer/managers/hardware.py

@@ -698,10 +698,9 @@ def get_bandwidth_allocation(self, instance_id):
         allotment = self.client.call('Hardware_Server', 'getBandwidthAllotmentDetail', id=instance_id, mask=a_mask)
         u_mask = "mask[amountIn,amountOut,type]"
         usage = self.client.call('Hardware_Server', 'getBillingCycleBandwidthUsage', id=instance_id, mask=u_mask)
-        allotment_bandwidth = None
-        if allotment is not "":
-            allotment_bandwidth = allotment.get('allocation')
-        return {'allotment': allotment_bandwidth, 'usage': usage}
+        if allotment:
+            return {'allotment': allotment.get('allocation'), 'usage': usage}
+        return {'allotment': allotment, 'usage': usage}
 
 
 def _get_extra_price_id(items, key_name, hourly, location):

tests/CLI/modules/server_tests.py

@@ -127,6 +127,17 @@ def test_detail_vs_empty_tag(self):
             ['example-tag'],
         )
 
+    def test_detail_empty_allotment(self):
+        mock = self.set_mock('SoftLayer_Hardware_Server', 'getBandwidthAllotmentDetail')
+        mock.return_value = None
+        result = self.run_command(['server', 'detail', '100'])
+
+        self.assert_no_fail(result)
+        self.assertEqual(
+            json.loads(result.output)['Bandwidth'][0]['Allotment'],
+            '-',
+        )
+
     def test_list_servers(self):
         result = self.run_command(['server', 'list', '--tag=openstack'])
 

tests/managers/hardware_tests.py

@@ -8,14 +8,11 @@
 
 import mock
 
-
 import SoftLayer
-
 from SoftLayer import fixtures
 from SoftLayer import managers
 from SoftLayer import testing
 
-
 MINIMAL_TEST_CREATE_ARGS = {
     'size': 'S1270_8GB_2X1TBSATA_NORAID',
     'hostname': 'unicorn',
@@ -448,17 +445,23 @@ def test_get_bandwidth_allocation(self):
         self.assertEqual(result['allotment']['amount'], '250')
         self.assertEqual(result['usage'][0]['amountIn'], '.448')
 
-    def test_get_bandwidth_allocation_no_allotment(self):
+    def test_get_bandwidth_allocation_with_allotment(self):
         mock = self.set_mock('SoftLayer_Hardware_Server', 'getBandwidthAllotmentDetail')
-        mock.return_value = {}
+        mock.return_value = {
+            "allocationId": 11111,
+            "id": 22222,
+            "allocation": {
+                "amount": "2000"
+            }
+        }
 
         result = self.hardware.get_bandwidth_allocation(1234)
 
-        self.assertEqual(None, result['allotment'])
+        self.assertEqual(2000, int(result['allotment']['amount']))
 
-    def test_get_bandwidth_allocation_empty_allotment(self):
+    def test_get_bandwidth_allocation_no_allotment(self):
         mock = self.set_mock('SoftLayer_Hardware_Server', 'getBandwidthAllotmentDetail')
-        mock.return_value = ""
+        mock.return_value = None
 
         result = self.hardware.get_bandwidth_allocation(1234)