Merge pull request #1201 from allmightyspiff/toxFixes

fixing new flask8 errors that show up out of nowhere

Author: allmightyspiff

SoftLayer/__init__.py

@@ -29,7 +29,7 @@
 __author__ = 'SoftLayer Technologies, Inc.'
 __license__ = 'MIT'
 __copyright__ = 'Copyright 2016 SoftLayer Technologies, Inc.'
-__all__ = [
+__all__ = [   # noqa: F405
     'BaseClient',
     'create_client_from_env',
     'Client',

SoftLayer/shell/core.py

@@ -81,7 +81,7 @@ def cli(ctx, env):
                 return
             except ShellExit:
                 return
-            except Exception as ex:
+            except Exception:
                 env.vars['last_exit_code'] = 1
                 traceback.print_exc(file=sys.stderr)
 

SoftLayer/testing/xmlrpc.py

@@ -83,7 +83,7 @@ def do_POST(self):
                                                 allow_none=True,
                                                 methodresponse=True)
             self.wfile.write(response_body.encode('utf-8'))
-        except Exception as ex:
+        except Exception:
             self.send_response(500)
             logging.exception("Error while handling request")
 

tests/CLI/helper_tests.py

@@ -154,29 +154,29 @@ def test_sort(self):
 
 class FormattedListTests(testing.TestCase):
     def test_init(self):
-        l = formatting.listing([1, 'two'], separator=':')
-        self.assertEqual([1, 'two'], list(l))
-        self.assertEqual(':', l.separator)
+        listing = formatting.listing([1, 'two'], separator=':')
+        self.assertEqual([1, 'two'], list(listing))
+        self.assertEqual(':', listing.separator)
 
-        l = formatting.listing([])
-        self.assertEqual(',', l.separator)
+        listing = formatting.listing([])
+        self.assertEqual(',', listing.separator)
 
     def test_to_python(self):
-        l = formatting.listing([1, 'two'])
-        result = l.to_python()
+        listing = formatting.listing([1, 'two'])
+        result = listing.to_python()
         self.assertEqual([1, 'two'], result)
 
-        l = formatting.listing(x for x in [1, 'two'])
-        result = l.to_python()
+        listing = formatting.listing(x for x in [1, 'two'])
+        result = listing.to_python()
         self.assertEqual([1, 'two'], result)
 
     def test_str(self):
-        l = formatting.listing([1, 'two'])
-        result = str(l)
+        listing = formatting.listing([1, 'two'])
+        result = str(listing)
         self.assertEqual('1,two', result)
 
-        l = formatting.listing((x for x in [1, 'two']), separator=':')
-        result = str(l)
+        listing = formatting.listing((x for x in [1, 'two']), separator=':')
+        result = str(listing)
         self.assertEqual('1:two', result)
 
 

tests/managers/hardware_tests.py

@@ -281,8 +281,7 @@ def test_cancel_hardware(self):
 
     def test_cancel_hardware_no_billing_item(self):
         mock = self.set_mock('SoftLayer_Hardware_Server', 'getObject')
-        mock.return_value = {'id': 987, 'openCancellationTicket': {'id': 1234},
-                             'openCancellationTicket': {'id': 1234}}
+        mock.return_value = {'id': 987, 'openCancellationTicket': {'id': 1234}}
 
         ex = self.assertRaises(SoftLayer.SoftLayerError,
                                self.hardware.cancel_hardware,

tests/managers/vs/vs_capacity_tests.py

@@ -132,7 +132,6 @@ def test_create_guest(self):
             'maxMemory': None,
             'hostname': 'A1538172419',
             'domain': 'test.com',
-            'localDiskFlag': None,
             'hourlyBillingFlag': True,
             'supplementalCreateObjectOptions': {
                 'bootMode': None,