Skip to content

Commit 04d3e4b

Browse files
allmightyspiffGitHub Enterprise
authored andcommitted
Merge pull request #914 from SoftLayer/issues896
Added Direct Link network space to vlan list
2 parents f86bd27 + 7fb3239 commit 04d3e4b

File tree

2 files changed

+8
-6
lines changed

2 files changed

+8
-6
lines changed

plugin/commands/vlan/list.go

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -118,22 +118,24 @@ func (cmd *ListCommand) Run(args []string) error {
118118
table := cmd.UI.Table(headers)
119119

120120
for _, vlan := range vlans {
121-
var premium string
121+
premium := T("No")
122122
if vlan.BillingItem != nil {
123123
premium = T("Yes")
124-
} else {
125-
premium = T("No")
126124
}
127125
datacenterName := ""
128126
if vlan.Datacenter != nil && vlan.Datacenter.Name != nil {
129127
datacenterName = utils.FormatStringPointer(vlan.Datacenter.Name)
130128
}
129+
networkSpace := "Direct Link"
130+
if vlan.NetworkSpace != nil {
131+
networkSpace = cases.Title(language.Und).String(utils.FormatStringPointer(vlan.NetworkSpace))
132+
}
131133
table.Add(
132134
utils.FormatIntPointer(vlan.Id),
133135
utils.FormatIntPointer(vlan.VlanNumber),
134136
utils.FormatStringPointer(vlan.FullyQualifiedName),
135137
utils.FormatStringPointer(vlan.Name),
136-
cases.Title(language.Und).String(utils.FormatStringPointer(vlan.NetworkSpace)),
138+
networkSpace,
137139
datacenterName,
138140
getPodWithClosedAnnouncement(vlan, pods),
139141
getFirewallGateway(vlan),

plugin/managers/network.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -462,10 +462,10 @@ destinationIpAddress[ipAddress,virtualGuest.fullyQualifiedDomainName,hardware.fu
462462
func (n networkManager) ListVlans(datacenter string, vlanNum int, name string, orderId int, mask string) ([]datatypes.Network_Vlan, error) {
463463
DEFAULT_VLAN_MASK := `mask[
464464
id, vlanNumber, fullyQualifiedName, name, networkSpace, datacenter[name], podName,
465-
firewallInterfaces, billingItem, tagReferences[tag[name]],
465+
firewallInterfaces, billingItem[id], tagReferences[tag[name]],
466466
hardwareCount,subnetCount,totalPrimaryIpAddressCount,virtualGuestCount,
467467
networkVlanFirewall[id,fullyQualifiedDomainName,primaryIpAddress],
468-
attachedNetworkGateway[id,name,networkFirewall]
468+
attachedNetworkGateway[id,name]
469469
]`
470470

471471
filters := filter.New()

0 commit comments

Comments
 (0)