Skip to content

Commit ea93e69

Browse files
committed
Merge branch 'development'
* development: fix insert invoked twice add , to disconnect update changelog Fix #923 update reconnect documentation update starscream Fix #894
2 parents 1025c80 + 4ec634c commit ea93e69

File tree

6 files changed

+18
-13
lines changed

6 files changed

+18
-13
lines changed

CHANGELOG.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,8 @@
1+
# 13.1.1
2+
3+
- Fix [#923](https://github.com/socketio/socket.io-client-swift/issues/923)
4+
- Fix [#894](https://github.com/socketio/socket.io-client-swift/issues/894)
5+
16
# v13.1.0
27

38
- Allow setting `SocketEngineSpec.extraHeaders` after init.

Package.resolved

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Socket.IO-Client-Swift.podspec

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
Pod::Spec.new do |s|
22
s.name = "Socket.IO-Client-Swift"
33
s.module_name = "SocketIO"
4-
s.version = "13.1.0"
4+
s.version = "13.1.1"
55
s.summary = "Socket.IO-client for iOS and OS X"
66
s.description = <<-DESC
77
Socket.IO-client for iOS and OS X.
@@ -18,7 +18,7 @@ Pod::Spec.new do |s|
1818
s.requires_arc = true
1919
s.source = {
2020
:git => "https://github.com/socketio/socket.io-client-swift.git",
21-
:tag => 'v13.1.0',
21+
:tag => 'v13.1.1',
2222
:submodules => true
2323
}
2424
s.pod_target_xcconfig = {

Source/SocketIO/Manager/SocketManager.swift

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -139,8 +139,6 @@ open class SocketManager : NSObject, SocketManagerSpec, SocketParsable, SocketDa
139139
self._config.insert(.secure(true))
140140
}
141141

142-
self._config.insert(.path("/socket.io/"), replacing: false)
143-
144142
super.init()
145143

146144
setConfigs(_config)
@@ -205,7 +203,7 @@ open class SocketManager : NSObject, SocketManagerSpec, SocketParsable, SocketDa
205203
return
206204
}
207205

208-
engine?.send("0\(socket.nsp)", withData: [])
206+
engine?.send("0\(socket.nsp),", withData: [])
209207
}
210208

211209
/// Called when the manager has disconnected from socket.io.
@@ -233,7 +231,8 @@ open class SocketManager : NSObject, SocketManagerSpec, SocketParsable, SocketDa
233231
///
234232
/// - parameter socket: The socket to disconnect.
235233
open func disconnectSocket(_ socket: SocketIOClient) {
236-
engine?.send("1\(socket.nsp)", withData: [])
234+
engine?.send("1\(socket.nsp),", withData: [])
235+
237236
socket.didDisconnect(reason: "Namespace leave")
238237
}
239238

@@ -414,7 +413,8 @@ open class SocketManager : NSObject, SocketManagerSpec, SocketParsable, SocketDa
414413

415414
/// Tries to reconnect to the server.
416415
///
417-
/// This will cause a `disconnect` event to be emitted, as well as an `reconnectAttempt` event.
416+
/// This will cause a `SocketClientEvent.reconnect` event to be emitted, as well as
417+
/// `SocketClientEvent.reconnectAttempt` events.
418418
open func reconnect() {
419419
guard !reconnecting else { return }
420420

Source/SocketIO/Util/SocketExtensions.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ extension Array {
3838

3939
extension CharacterSet {
4040
static var allowedURLCharacterSet: CharacterSet {
41-
return CharacterSet(charactersIn: "!*'();:@&=+$,/?%#[]\" {}").inverted
41+
return CharacterSet(charactersIn: "!*'();:@&=+$,/?%#[]\" {}^").inverted
4242
}
4343
}
4444

Tests/TestSocketIO/SocketEngineTest.swift

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -87,11 +87,11 @@ class SocketEngineTest: XCTestCase {
8787
XCTAssertEqual(engine.urlWebSocket.query, "transport=websocket&created=2016-05-04T18%3A31%3A15%2B0200")
8888

8989
engine.connectParams = [
90-
"forbidden": "!*'();:@&=+$,/?%#[]\" {}"
90+
"forbidden": "!*'();:@&=+$,/?%#[]\" {}^"
9191
]
9292

93-
XCTAssertEqual(engine.urlPolling.query, "transport=polling&b64=1&forbidden=%21%2A%27%28%29%3B%3A%40%26%3D%2B%24%2C%2F%3F%25%23%5B%5D%22%20%7B%7D")
94-
XCTAssertEqual(engine.urlWebSocket.query, "transport=websocket&forbidden=%21%2A%27%28%29%3B%3A%40%26%3D%2B%24%2C%2F%3F%25%23%5B%5D%22%20%7B%7D")
93+
XCTAssertEqual(engine.urlPolling.query, "transport=polling&b64=1&forbidden=%21%2A%27%28%29%3B%3A%40%26%3D%2B%24%2C%2F%3F%25%23%5B%5D%22%20%7B%7D%5E")
94+
XCTAssertEqual(engine.urlWebSocket.query, "transport=websocket&forbidden=%21%2A%27%28%29%3B%3A%40%26%3D%2B%24%2C%2F%3F%25%23%5B%5D%22%20%7B%7D%5E")
9595
}
9696

9797
func testBase64Data() {

0 commit comments

Comments
 (0)