Commit 7eec7e2
committed
chore: don't disable acc test KMS keys
When applying acceptance test terraform for AWS KMS key resources, we
often see errors of the form: `Failed to set KMS key ... status to
false: "NotFoundException: Key '...' does not exist"`. Our current
theory is that setting is_enabled=false (as we currently do) is causing
terraform to have to perform 2 API operations: create the key, then
disable it. Due to the "eventualy consistency" of this API we see this
flaking quite often.
We don't actually need to disable the keys, so let's not, in an attempt
to improve the reliability of this test.1 parent 7f729dc commit 7eec7e2
File tree
2 files changed
+4
-8
lines changed- pkg/resource/aws/testdata/acc
- aws_kms_alias
- aws_kms_key
2 files changed
+4
-8
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
13 | | - | |
14 | 13 | | |
15 | 14 | | |
16 | 15 | | |
| |||
19 | 18 | | |
20 | 19 | | |
21 | 20 | | |
22 | | - | |
| 21 | + | |
23 | 22 | | |
24 | 23 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
13 | | - | |
14 | | - | |
| 13 | + | |
15 | 14 | | |
16 | 15 | | |
17 | 16 | | |
18 | 17 | | |
19 | 18 | | |
20 | | - | |
21 | | - | |
| 19 | + | |
22 | 20 | | |
23 | | - | |
| 21 | + | |
24 | 22 | | |
25 | 23 | | |
26 | 24 | | |
27 | 25 | | |
28 | 26 | | |
29 | | - | |
30 | 27 | | |
31 | 28 | | |
32 | 29 | | |
| |||
0 commit comments