Merge pull request #1502 from snyk/fix/aws_route_with_prefix_broken

fix: crash in deep mode on aws_route

Author: eliecharra

pkg/resource/aws/aws_route.go

@@ -20,6 +20,9 @@ func initAwsRouteMetaData(resourceSchemaRepository resource.SchemaRepositoryInte
 		if ipv6 := res.Attributes().GetString("destination_ipv6_cidr_block"); ipv6 != nil && *ipv6 != "" {
 			attributes["destination_ipv6_cidr_block"] = *ipv6
 		}
+		if prefixes := res.Attributes().GetString("destination_prefix_list_id"); prefixes != nil && *prefixes != "" {
+			attributes["destination_prefix_list_id"] = *prefixes
+		}
 		return attributes
 	})
 	resourceSchemaRepository.SetNormalizeFunc(AwsRouteResourceType, func(res *resource.Resource) {
@@ -30,6 +33,7 @@ func initAwsRouteMetaData(resourceSchemaRepository resource.SchemaRepositoryInte
 		val.DeleteIfDefault("local_gateway_id")
 		val.DeleteIfDefault("destination_cidr_block")
 		val.DeleteIfDefault("destination_ipv6_cidr_block")
+		val.DeleteIfDefault("destination_prefix_list_id")
 		val.DeleteIfDefault("egress_only_gateway_id")
 		val.DeleteIfDefault("nat_gateway_id")
 		val.DeleteIfDefault("instance_id")

pkg/resource/aws/aws_route_test.go

@@ -34,3 +34,31 @@ func TestAcc_Aws_Route(t *testing.T) {
 		},
 	})
 }
+
+// Splitted that case because it required a lot of unrelated resources
+func TestAcc_Aws_Route_With_PrefixListId(t *testing.T) {
+	acceptance.Run(t, acceptance.AccTestCase{
+		TerraformVersion: "0.15.5",
+		Paths:            []string{"./testdata/acc/aws_route_with_prefix_list_id"},
+		Args:             []string{"scan", "--deep"},
+		RetryDestroy: acceptance.RetryConfig{
+			Attempts: 3,
+			Delay:    5 * time.Second,
+		},
+		Checks: []acceptance.AccCheck{
+			{
+				Env: map[string]string{
+					"AWS_REGION": "us-east-1",
+				},
+				ShouldRetry: acceptance.LinearBackoff(10 * time.Minute),
+				Check: func(result *test.ScanResult, stdout string, err error) {
+					if err != nil {
+						t.Fatal(err)
+					}
+					result.AssertInfrastructureIsInSync()
+					result.AssertManagedCount(1)
+				},
+			},
+		},
+	})
+}

pkg/resource/aws/testdata/acc/aws_route_with_prefix_list_id/.driftignore

@@ -0,0 +1,3 @@
+*
+!aws_route
+

pkg/resource/aws/testdata/acc/aws_route_with_prefix_list_id/.terraform.lock.hcl

@@ -0,0 +1,39 @@
+provider "aws" {
+    region = "us-east-1"
+}
+
+terraform {
+    required_providers {
+        aws = "3.75.1"
+    }
+}
+
+resource "aws_vpc" "example" {
+    cidr_block                       = "10.1.0.0/16"
+}
+
+resource "aws_ec2_managed_prefix_list" "example" {
+    name           = "example"
+    address_family = "IPv4"
+    max_entries    = 5
+}
+
+resource "aws_route_table" "example" {
+    vpc_id = aws_vpc.example.id
+}
+
+resource "aws_subnet" "example" {
+    vpc_id     = aws_vpc.example.id
+    cidr_block = "10.1.1.0/24"
+}
+
+resource "aws_nat_gateway" "example" {
+    connectivity_type = "private"
+    subnet_id         = aws_subnet.example.id
+}
+
+resource "aws_route" "r" {
+    route_table_id              = aws_route_table.example.id
+    nat_gateway_id = aws_nat_gateway.example.id
+    destination_prefix_list_id = aws_ec2_managed_prefix_list.example.id
+}