remove symlink

Author: james-snyk

pkg/ecosystems/discovery/README.md

@@ -11,7 +11,6 @@ Efficient file discovery utilities for finding manifest and configuration files
 - **Exclude Patterns**: Skip directories and files using glob patterns
 - **Context Support**: Cancellable operations for long-running searches
 - **Efficient Traversal**: Uses `filepath.WalkDir` for optimal performance
-- **Symlink Handling**: Optional symlink following
 - **Structured Logging**: `slog` integration for debugging
 
 ## Usage
@@ -96,14 +95,6 @@ results, err := discovery.FindFiles(ctx, "/path/to/project",
     discovery.WithExcludes("node_modules", ".*", "__pycache__"))
 ```
 
-### Follow Symlinks
-
-```go
-results, err := discovery.FindFiles(ctx, "/path/to/project",
-    discovery.WithInclude("*.txt"),
-    discovery.WithFollowSymlinks(true))
-```
-
 ### Common Exclude Patterns
 
 ```go

pkg/ecosystems/discovery/files.go

@@ -19,10 +19,9 @@ const (
 
 // findOptions configures file discovery behavior.
 type findOptions struct {
-	targetFiles    []string
-	includeGlobs   []string
-	excludeGlobs   []string
-	followSymlinks bool
+	targetFiles  []string
+	includeGlobs []string
+	excludeGlobs []string
 }
 
 // FindOption is a functional option for configuring file discovery.
@@ -70,13 +69,6 @@ func WithExcludes(patterns ...string) FindOption {
 	}
 }
 
-// WithFollowSymlinks enables or disables following symbolic links.
-func WithFollowSymlinks(follow bool) FindOption {
-	return func(o *findOptions) {
-		o.followSymlinks = follow
-	}
-}
-
 // FindResult represents a discovered file.
 type FindResult struct {
 	Path    string // Absolute path to the file
@@ -241,11 +233,6 @@ func walkDirectory(ctx context.Context, absRoot string, opts *findOptions) ([]Fi
 			return handleDirectory(d, relPath, opts.excludeGlobs)
 		}
 
-		// Handle symlinks
-		if d.Type()&fs.ModeSymlink != 0 && !shouldFollowSymlink(path, relPath, opts.followSymlinks) {
-			return nil
-		}
-
 		// Check exclusions and pattern match for files
 		if shouldIncludeFile(d, relPath, opts) {
 			results = append(results, FindResult{
@@ -298,22 +285,6 @@ func handleDirectory(d fs.DirEntry, relPath string, excludePatterns []string) er
 	return nil
 }
 
-// shouldFollowSymlink determines if a symlink should be followed.
-func shouldFollowSymlink(path, relPath string, followSymlinks bool) bool {
-	if !followSymlinks {
-		slog.Debug("Skipping symlink", slog.String(logKeyPath, relPath))
-		return false
-	}
-
-	// Resolve symlink and check if it's a file
-	targetInfo, err := os.Stat(path)
-	if err != nil || targetInfo.IsDir() {
-		return false
-	}
-
-	return true
-}
-
 // shouldIncludeFile determines if a file should be included in results.
 // Returns true if the file matches any of the include globs and is not excluded.
 func shouldIncludeFile(d fs.DirEntry, relPath string, opts *findOptions) bool {