Change iglucentral to use https #1567
Closed
+148
−148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Missing SEO metadataThe following markdown files are missing required metadata fields:
Required fieldsThe file metadata is important for SEO and marketing. All markdown files, except for those with filenames starting with
Please add the missing metadata. |
✅ Deploy Preview for snowplow-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Style Guide ReviewThank you for updating the Iglu Central URLs to HTTPS! The technical changes look correct. I found a few writing quality issues to address according to our style guide: Issues to fix1. Use "Snowplow" not "Snowplow Analytics"
2. Avoid marketing language: "easily"
3. Typo: "publically" should be "publicly"
4. Inconsistent connection type in Ruby example
SummaryThe HTTPS migration is well-executed across all files. The main actionable items are:
All other URL changes follow the correct pattern. Nice work on the comprehensive update! |
Contributor
|
@Andy-Hay can you please resolve the conflicts for this one? I can then approve this |
Contributor
Author
|
@claude can you review please |
Contributor
Author
|
@stanch would you be able to review this and hit merge if all good please ? |
stanch
requested changes
Jan 9, 2026
|
|
||
| ```json | ||
| { | ||
| "$schema": "http://iglucentral.com/schemas/com.snowplowanalytics.self-desc/schema/jsonschema/1-0-0#", |
Collaborator
There was a problem hiding this comment.
@istreeter Will this work? I am under the impression that this is hardcoded and can’t be changed in customer schemas?
Contributor
Author
There was a problem hiding this comment.
Okay i may have gone too far and change more than the resolvers. Probably easier to create a new PR if thats the case 😢
| incorporating the aforementioned `self` property. | ||
|
|
||
| Notice that we also changed the `$schema` property to [our own JSON Schema](http://iglucentral.com/schemas/com.snowplowanalytics.self-desc/schema/jsonschema/1-0-0#) which enforces the `self` property. | ||
| Notice that we also changed the `$schema` property to [our own JSON Schema](https://iglucentral.com/schemas/com.snowplowanalytics.self-desc/schema/jsonschema/1-0-0#) which enforces the `self` property. |
| :data => { | ||
| :cacheSize => 500, | ||
| :repositories => [{:name => "Iglu Central", :priority => 0, :vendorPrefixes => ["com.snowplowanalytics"], :connection => {:http => {:uri => "http://iglucentral.com"}}}] | ||
| :repositories => [{:name => "Iglu Central", :priority => 0, :vendorPrefixes => ["com.snowplowanalytics"], :connection => {:https => {:uri => "https://iglucentral.com"}}}] |
Collaborator
There was a problem hiding this comment.
Suggested change
| :repositories => [{:name => "Iglu Central", :priority => 0, :vendorPrefixes => ["com.snowplowanalytics"], :connection => {:https => {:uri => "https://iglucentral.com"}}}] | |
| :repositories => [{:name => "Iglu Central", :priority => 0, :vendorPrefixes => ["com.snowplowanalytics"], :connection => {:http => {:uri => "https://iglucentral.com"}}}] |
Not an expert on Ruby, but sounds like http is a fixed name of the setting?
Contributor
Author
There was a problem hiding this comment.
Not done Ruby for a long time, so i asked Claude and queried what it should be. It said it should be https. But it could be wrong.
Collaborator
There was a problem hiding this comment.
I see the Ruby client is archived and not touched in 9 years. I suggest just deleting the whole thing from the docs. But it’s definitely http: https://github.com/snowplow-archive/iglu-ruby-client/blob/master/lib/iglu-client/resolver.rb#L94
Contributor
Author
There was a problem hiding this comment.
I'm going to move back to draft and redo in two weeks - it's wrong, sorry for wasting your time.
|
|
||
| ```json | ||
| { | ||
| "$schema": "http://iglucentral.com/schemas/com.snowplowanalytics.self-desc/schema/jsonschema/1-0-0#", |
Collaborator
There was a problem hiding this comment.
Same comment about hardcoded schema (throughout this file)
|
|
||
| - JSON Schema has inconsistent self-describing information and path on filesystem | ||
| - JSON Schema has invalid `$schema` keyword. It should be always set to [iglu-specific](http://iglucentral.com/schemas/com.snowplowanalytics.self-desc/schema/jsonschema/1-0-0#), while users tend to set it to Draft v4 or even to self-referencing Iglu URI | ||
| - JSON Schema has invalid `$schema` keyword. It should be always set to [iglu-specific](https://iglucentral.com/schemas/com.snowplowanalytics.self-desc/schema/jsonschema/1-0-0#), while users tend to set it to Draft v4 or even to self-referencing Iglu URI |
|
|
||
| ```json | ||
| { | ||
| "$schema": "http://iglucentral.com/schemas/com.snowplowanalytics.self-desc/schema/jsonschema/1-0-0#", |
|
|
||
| ```json | ||
| { | ||
| "$schema":"http://iglucentral.com/schemas/com.snowplowanalytics.self-desc/schema/jsonschema/1-0-0#", |
| "required": [ | ||
| "example_field_1" | ||
| ], | ||
| "$schema": "http://iglucentral.com/schemas/com.snowplowanalytics.self-desc/schema/jsonschema/1-0-0#", |
Collaborator
There was a problem hiding this comment.
Ok I will stop commenting on this :)
Contributor
Author
|
Closing in favour of targeted #1574 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Change references to iglucentral from http to https.
Why?
We will be turning off the http access in February 2026
Reviewer guidance
Changed references and any code snippets.
AI reviews
Claude will automatically review this PR against the docs style guide.
If you have questions or want it to look again at something specific, tag
@claudein a comment.