Additional test case, clear several Sonar warnings

Signed-off-by: Michael Edgar <[email protected]>

Author: MikeEdgar

core/src/test/java/io/smallrye/openapi/runtime/scanner/PropertyNamingStrategyTest.java

@@ -50,21 +50,21 @@ void testJacksonNamingOverridesConfig() throws Exception {
     }
 
     @Test
-    void testInvalidNamingStrategyClass() throws Exception {
+    void testInvalidNamingStrategyClass() {
         Config config = config(SmallRyeOASConfig.SMALLRYE_PROPERTY_NAMING_STRATEGY,
                 "com.fasterxml.jackson.databind.PropertyNamingStrategies$InvalidStrategy");
         assertThrows(OpenApiRuntimeException.class, () -> scan(config, NameStrategyKebab.class));
     }
 
     @Test
-    void testNoValidTranslationMethods() throws Exception {
+    void testNoValidTranslationMethods() {
         Config config = config(SmallRyeOASConfig.SMALLRYE_PROPERTY_NAMING_STRATEGY,
                 NoValidTranslationMethods.class.getName());
         assertThrows(OpenApiRuntimeException.class, () -> scan(config, NameStrategyKebab.class));
     }
 
     @Test
-    void testInvalidPropertyNameTranslationAttempt() throws Exception {
+    void testInvalidPropertyNameTranslationAttempt() {
         Config config = config(SmallRyeOASConfig.SMALLRYE_PROPERTY_NAMING_STRATEGY,
                 TranslationThrowsException.class.getName());
         assertThrows(OpenApiRuntimeException.class, () -> scan(config, NameStrategyBean3.class));
@@ -79,7 +79,7 @@ void testInvalidPropertyNameTranslationAttempt() throws Exception {
             JsonbConstants.UPPER_CAMEL_CASE_WITH_SPACES + ", Simple String One|Another Field|Y|Z|SOME Value",
             JsonbConstants.CASE_INSENSITIVE + ", simpleStringOne|anotherField|Y|z|SOMEValue"
     })
-    void testJsonbConstantStrategy(String strategy, String expectedNames) throws Exception {
+    void testJsonbConstantStrategy(String strategy, String expectedNames) {
         OpenAPI result = scan(config(SmallRyeOASConfig.SMALLRYE_PROPERTY_NAMING_STRATEGY, strategy), NameStrategyBean3.class);
         List<String> expectedNameList = Arrays.asList(expectedNames.split("\\|"));
         Collections.sort(expectedNameList, String::compareToIgnoreCase);
@@ -92,6 +92,12 @@ void testJsonbConstantStrategy(String strategy, String expectedNames) throws Exc
         assertEquals(expectedNameList, actualNameList);
     }
 
+    @Test
+    void testMethodNamePreserved() throws Exception {
+        OpenAPI result = scan(NameStrategyBean4.class);
+        assertJsonEquals("components.schemas.method-name-preserved.json", result);
+    }
+
     @Schema
     static class NameStrategyBean1 {
         String simpleStringValue;
@@ -119,9 +125,9 @@ static class NameStrategyKebab {
     static class NameStrategyBean3 {
         String simpleStringOne;
         Integer anotherField;
-        BigDecimal Y;
+        BigDecimal Y; // NOSONAR - naming intentional
         double z;
-        String SOMEValue;
+        String SOMEValue; // NOSONAR - naming intentional
 
         public String getSimpleStringOne() {
             return simpleStringOne;
@@ -144,14 +150,35 @@ public String getSOMEValue() {
         }
     }
 
-    public static class NoValidTranslationMethods {
-        public NoValidTranslationMethods() {
+    @Schema
+    static class NameStrategyBean4 {
+        @Schema(name = "TESTValue", title = "Test Value")
+        Integer TestValue; // NOSONAR - naming intentional
+
+        @Schema(name = "eValue", title = "e-Value")
+        String EValue; // NOSONAR - naming intentional
+
+        @Schema(description = "Property for TestValue")
+        public Integer getTESTValue() {
+            return TestValue;
+        }
+
+        @Schema(description = "Property for e-Value")
+        public String geteValue() {
+            return EValue;
         }
 
+    }
+
+    public static class NoValidTranslationMethods {
         public String translate() {
             return null;
         }
 
+        /**
+         * @param v1 unused, demonstrated unsuitable translate method signature
+         * @param v2 unused, demonstrated unsuitable translate method signature
+         */
         public String translate(String v1, String v2) {
             return null;
         }

core/src/test/resources/io/smallrye/openapi/runtime/scanner/components.schemas.method-name-preserved.json

@@ -0,0 +1,23 @@
+{
+  "openapi" : "3.1.0",
+  "components" : {
+    "schemas" : {
+      "NameStrategyBean4" : {
+        "type" : "object",
+        "properties" : {
+          "TESTValue" : {
+            "type" : "integer",
+            "format" : "int32",
+            "description" : "Property for TestValue",
+            "title" : "Test Value"
+          },
+          "eValue" : {
+            "type" : "string",
+            "description" : "Property for e-Value",
+            "title" : "e-Value"
+          }
+        }
+      }
+    }
+  }
+}