Skip to content

Commit 42d39e8

Browse files
authored
✨ enhance selection loading logic to check for bookmarkBriefInfo before loading (#137)
1 parent 94582fc commit 42d39e8

File tree

3 files changed

+9
-3
lines changed

3 files changed

+9
-3
lines changed

apps/slax-reader-extensions/src/components/Selection/manager.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -411,7 +411,7 @@ export class MarkManager extends Base {
411411
}
412412

413413
getApproxText(range: Range): HighlightRangeInfo | undefined {
414-
if (!range) {
414+
if (!range || range.collapsed || range.toString().trim().length === 0) {
415415
return undefined
416416
}
417417

apps/slax-reader-extensions/src/components/SidePanel.vue

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -177,7 +177,7 @@ watch(
177177
}
178178
179179
loadBriefDetail().then(() => {
180-
loadSelection()
180+
bookmarkBriefInfo.value && loadSelection()
181181
})
182182
}
183183
)
@@ -211,7 +211,7 @@ props.browser.runtime.onMessage.addListener(
211211
onMounted(() => {
212212
updateBookmarkStatus()
213213
loadBriefDetail().then(() => {
214-
loadSelection()
214+
bookmarkBriefInfo.value && loadSelection()
215215
})
216216
217217
tryGetUserInfo(true).then(res => {

apps/slax-reader-extensions/src/entrypoints/content/index.ts

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,12 @@ export default defineContentScript({
5858
html{
5959
z-index: 99999999999 !important;
6060
}
61+
62+
@media print {
63+
:host, html {
64+
display: none !important;
65+
}
66+
}
6167
`,
6268
onMount: container => {
6369
const app = createApp(SidePanel, {

0 commit comments

Comments
 (0)