SK-2291: add constants in unit test cases

Author: saileshwar-skyflow

v3/src/test/java/com/skyflow/vault/controller/VaultControllerTests.java

@@ -19,7 +19,6 @@
 import java.lang.reflect.Method;
 import java.util.ArrayList;
 import java.util.HashMap;
-import java.util.Scanner;
 
 import static org.junit.Assert.*;
 
@@ -249,7 +248,7 @@ public void testBatchSizeExceedsMax() throws Exception {
             //  Ignore, Testing concurrency/batch config
         }
 
-        assertEquals(1000, getPrivateInt(controller, "insertBatchSize"));
+        assertEquals(Constants.MAX_INSERT_BATCH_SIZE.intValue(), getPrivateInt(controller, "insertBatchSize"));
     }
 
     @Test
@@ -265,7 +264,7 @@ public void testConcurrencyExceedsMax() throws Exception {
             // Ignore, Testing concurrency/batch config
         }
 
-        assertEquals(1, getPrivateInt(controller, "insertConcurrencyLimit"));
+        assertEquals(Constants.INSERT_CONCURRENCY_LIMIT.intValue(), getPrivateInt(controller, "insertConcurrencyLimit"));
     }
 
     @Test
@@ -280,7 +279,7 @@ public void testBatchSizeZeroOrNegative() throws Exception {
             // Ignore, Testing concurrency/batch config
         }
 
-        assertEquals(50, getPrivateInt(controller, "insertBatchSize"));
+        assertEquals(Constants.INSERT_BATCH_SIZE.intValue(), getPrivateInt(controller, "insertBatchSize"));
 
         writeEnv("INSERT_BATCH_SIZE=-5");
 
@@ -290,7 +289,7 @@ public void testBatchSizeZeroOrNegative() throws Exception {
             // Ignore, Testing concurrency/batch config
         }
 
-        assertEquals(50, getPrivateInt(controller, "insertBatchSize"));
+        assertEquals(Constants.INSERT_BATCH_SIZE.intValue(), getPrivateInt(controller, "insertBatchSize"));
     }
 
     @Test
@@ -369,7 +368,7 @@ public void testHighConcurrencyForLowRecords() throws Exception {
 
         // Only 10 batches needed, so concurrency should be clamped to 10
         assertEquals(1000, getPrivateInt(controller, "insertBatchSize"));
-        assertEquals(10, getPrivateInt(controller, "insertConcurrencyLimit"));
+        assertEquals(Constants.MAX_INSERT_CONCURRENCY_LIMIT.intValue(), getPrivateInt(controller, "insertConcurrencyLimit"));
     }
 
 
@@ -386,7 +385,7 @@ public void testFractionalLastBatch() throws Exception {
 
         // Last batch should have 50 records, concurrency should be 101
         assertEquals(100, getPrivateInt(controller, "insertBatchSize"));
-        assertEquals(10, getPrivateInt(controller, "insertConcurrencyLimit"));
+        assertEquals(Constants.INSERT_CONCURRENCY_LIMIT.intValue(), getPrivateInt(controller, "insertConcurrencyLimit"));
     }
 
     private int getPrivateInt(Object obj, String field) throws Exception {

v3/src/test/java/com/skyflow/vault/data/DetokenizeRequestTests.java

@@ -3,8 +3,6 @@
 import com.skyflow.errors.ErrorCode;
 import com.skyflow.errors.ErrorMessage;
 import com.skyflow.errors.SkyflowException;
-import com.skyflow.utils.Constants;
-import com.skyflow.utils.Utils;
 import com.skyflow.utils.validations.Validations;
 import org.junit.Assert;
 import org.junit.Test;