Downgrade circleci image to PHP 5.6 (#86)

Author: sirbrillig

.circleci/config.yml

@@ -2,8 +2,8 @@ version: 2
 jobs:
   build:
     docker:
-      - image: circleci/php:7.0-apache-stretch-node-browsers
+      - image: circleci/php:5.6.40-zts-stretch-node-browsers-legacy
     steps:
       - checkout
-      - run: composer install
-      - run: composer test
+      - run: COMPOSER=composer.circleci.json composer install
+      - run: COMPOSER=composer.circleci.json composer test

VariableAnalysis/Sniffs/CodeAnalysis/VariableAnalysisSniff.php

@@ -1059,7 +1059,12 @@ protected function processScopeCloseForVariable($phpcsFile, $varInfo, $scopeInfo
       // the purposes of "unused variable" warnings.
       return;
     }
-    $stackPtr = $varInfo->firstDeclared ?? $varInfo->firstInitialized ?? null;
+    $stackPtr = null;
+    if (!empty($varInfo->firstDeclared)) {
+      $stackPtr = $varInfo->firstDeclared;
+    } elseif (!empty($varInfo->firstInitialized)) {
+      $stackPtr = $varInfo->firstInitialized;
+    }
     if ($stackPtr) {
       Helpers::debug("variable {$varInfo->name} at end of scope looks undefined");
       $phpcsFile->addWarning(

VariableAnalysis/Tests/BaseTestCase.php

@@ -8,7 +8,7 @@
 
 class BaseTestCase extends TestCase {
   public function prepareLocalFileForSniffs($sniffFiles, $fixtureFile) {
-    $config = new Config();
+    $config = new Config(['--standard=VariableAnalysis']);
     $ruleset = new Ruleset($config);
     if (! is_array($sniffFiles)) {
       $sniffFiles = [$sniffFiles];

composer.circleci.json

@@ -0,0 +1,41 @@
+{
+    "name": "sirbrillig/phpcs-variable-analysis",
+    "description": "A PHPCS sniff to detect problems with variables.",
+    "type": "phpcodesniffer-standard",
+    "license": "BSD-2-Clause",
+    "authors": [
+        {
+            "name": "Sam Graham",
+            "email": "[email protected]"
+        },
+        {
+            "name": "Payton Swick",
+            "email": "[email protected]"
+        }
+    ],
+    "support"    : {
+        "issues": "https://github.com/sirbrillig/phpcs-variable-analysis/issues",
+        "wiki"  : "https://github.com/sirbrillig/phpcs-variable-analysis/wiki",
+        "source": "https://github.com/sirbrillig/phpcs-variable-analysis"
+    },
+    "config": {
+        "sort-order": true
+    },
+    "autoload": {
+        "psr-4": {
+            "VariableAnalysis\\": "VariableAnalysis/"
+        }
+    },
+    "minimum-stability": "dev",
+    "prefer-stable": true,
+    "scripts": {
+        "test": "./vendor/bin/phpunit --configuration phpunit.circleci.xml"
+    },
+    "require" : {
+        "php" : ">=5.6.0"
+    },
+    "require-dev": {
+        "phpunit/phpunit": "^5.0",
+        "squizlabs/php_codesniffer": "^3.1"
+    }
+}

composer.json

@@ -33,7 +33,7 @@
         "lint": "./vendor/bin/phpcs -s -p VariableAnalysis/Sniffs VariableAnalysis/Lib"
     },
     "require" : {
-        "php" : ">=5.4.0"
+        "php" : ">=5.6.0"
     },
     "require-dev": {
         "dealerdirect/phpcodesniffer-composer-installer": "^0.4.4",

phpunit.circleci.xml

@@ -0,0 +1,9 @@
+<phpunit
+	bootstrap="VariableAnalysis/Tests/bootstrap.php"
+	>
+	<testsuites>
+		<testsuite>
+			<directory>VariableAnalysis/Tests</directory>
+		</testsuite>
+	</testsuites>
+</phpunit>