Skip to content

Conversation

@jonnyreeves
Copy link
Contributor

My first commit to SinonJS; please let me know if this is what you were thinking / if there are any style issues I need to correct.

Thanks again for this excellent library.

@mantoni
Copy link
Member

mantoni commented Apr 26, 2013

Thanks a lot, that looks very good.

Regarding the styling: Could you put the opening { on the same line as the function ()? And then you've put blanks in the empty function bodies. function () {} is what I've found elsewhere in the codebase.

mantoni added a commit that referenced this pull request Apr 26, 2013
Added sinon.restore(), Fixes #270
@mantoni mantoni merged commit c479f69 into sinonjs:master Apr 26, 2013
@mantoni
Copy link
Member

mantoni commented Apr 26, 2013

Cool, thanks!

@mantoni
Copy link
Member

mantoni commented Apr 29, 2013

Would you care to add a line or two to the documentation?
It's here: https://github.com/cjohansen/sinon-web

@jonnyreeves
Copy link
Contributor Author

Already done ;) cjohansen/sinon-web#24

@mantoni
Copy link
Member

mantoni commented Apr 29, 2013

Oh. Even merged. I'll go back to sleep then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants