Change autocommit=True by default; release v0.3.0

Author: kesmit13

docs/src/whatsnew.rst

@@ -4,6 +4,10 @@ What's New
 
 This document outlines features and improvements from each release.
 
+v0.3.0 - September 9, 2022
+--------------------------
+* Changed autocommit=True by default
+
 v0.2.0 - Pre-Release
 --------------------
 * Changed to pure Python driver

setup.cfg

@@ -1,6 +1,6 @@
 [metadata]
 name = singlestoredb
-version = 0.2.0
+version = 0.3.0
 description = Interface to the SingleStore database and cluster management APIs
 long_description = file: README.md
 long_description_content_type = text/markdown

singlestoredb/__init__.py

@@ -14,7 +14,7 @@
 """
 from __future__ import annotations
 
-__version__ = '0.2.0'
+__version__ = '0.3.0'
 
 from .config import options, get_option, set_option, describe_option
 from .connection import connect, apilevel, threadsafety, paramstyle

singlestoredb/config.py

@@ -136,6 +136,12 @@
     environ='SINGLESTOREDB_SSO_BROWSER',
 )
 
+register_option(
+    'autocommit', 'bool', check_bool, True,
+    'Enable autocommits',
+    environ='SINGLESTOREDB_AUTOCOMMIT',
+)
+
 #
 # Query results options
 #

singlestoredb/connection.py

@@ -1109,6 +1109,7 @@ def connect(
     converters: Optional[Dict[int, Callable[..., Any]]] = None,
     results_format: Optional[str] = None,
     credential_type: Optional[str] = None,
+    autocommit: Optional[bool] = None,
 ) -> Connection:
     """
     Return a SingleStoreDB connection.
@@ -1156,6 +1157,8 @@ def connect(
         Format of query results: tuple, namedtuple, dict, or dataframe
     credential_type : str, optional
         Type of authentication to use: auth.PASSWORD, auth.JWT, or auth.BROWSER_SSO
+    autocommit : bool, optional
+        Enable autocommits
 
     Examples
     --------

singlestoredb/drivers/pymysql.py

@@ -12,7 +12,6 @@
 from .base import Driver
 from ..converters import converters as convs
 
-
 converters: Dict[Any, Callable[..., Any]] = dict(convs)
 converters.update(encoders)
 

singlestoredb/drivers/pyodbc.py

@@ -59,5 +59,9 @@ def remap_params(self, params: Dict[str, Any]) -> Dict[str, Any]:
 
         return out
 
+    def after_connect(self, conn: Any, params: Dict[str, Any]) -> None:
+        if params.get('autocommit'):
+            conn.autocommit(True)
+
     def is_connected(self, conn: Any, reconnect: bool = False) -> bool:
         return not conn.closed

singlestoredb/tests/test.sql

@@ -41,14 +41,21 @@ COMMIT;
 CREATE TABLE IF NOT EXISTS alltypes (
     `id` INT(11),
     `tinyint` TINYINT,
+    `unsigned_tinyint` TINYINT UNSIGNED,
     `bool` BOOL,
     `boolean` BOOLEAN,
     `smallint` SMALLINT,
+    `unsigned_smallint` SMALLINT UNSIGNED,
     `mediumint` MEDIUMINT,
+    `unsigned_mediumint` MEDIUMINT UNSIGNED,
     `int24` MEDIUMINT,
+    `unsigned_int24` MEDIUMINT UNSIGNED,
     `int` INT,
+    `unsigned_int` INT UNSIGNED,
     `integer` INTEGER,
+    `unsigned_integer` INTEGER UNSIGNED,
     `bigint` BIGINT,
+    `unsigned_bigint` BIGINT UNSIGNED,
     `float` FLOAT,
     `double` DOUBLE,
     `real` REAL,
@@ -88,14 +95,21 @@ COLLATE='utf8_unicode_ci';
 INSERT INTO alltypes SET
     `id`=0,
     `tinyint`=80,
+    `unsigned_tinyint`=85,
     `bool`=0,
     `boolean`=1,
     `smallint`=-27897,
+    `unsigned_smallint`=27897,
     `mediumint`=104729,
+    `unsigned_mediumint`=120999,
     `int24`=-200899,
+    `unsigned_int24`=407709,
     `int`=-1295369311,
+    `unsigned_int`=3872362332,
     `integer`=-1741727421,
+    `unsigned_integer`=3198387363,
     `bigint`=-266883847,
+    `unsigned_bigint`=980007287362,
     `float`=-146486683.754744,
     `double`=-474646154.719356,
     `real`=-901409776.279346,
@@ -158,7 +172,6 @@ INSERT INTO alltypes SET
     `char_100`=NULL,
     `binary_100`=NULL,
     `varchar_200`=NULL,
-    `varbinary_200`=NULL,
     `longtext`=NULL,
     `mediumtext`=NULL,
     `text`=NULL,

singlestoredb/tests/test_basics.py

@@ -587,11 +587,11 @@ def otype(x):
 
         # Same as above
         if self.driver == 'pyodbc':
-            assert row['time'] == datetime.time(0, 7, 0), row['time']
+            assert row['time_6'] == datetime.time(0, 7, 0), row['time_6']
         else:
             assert row['time_6'] == datetime.timedelta(
                 hours=1, minutes=10, microseconds=2,
-            ), row['time']
+            ), row['time_6']
         assert typ['time_6'] == 11, typ['time_6']
 
         assert row['datetime'] == datetime.datetime(
@@ -602,7 +602,7 @@ def otype(x):
         assert row['datetime_6'] == datetime.datetime(
             1756, 10, 29, 2, 2, 42, 8,
         ), row['datetime_6']
-        assert typ['datetime'] == 12, typ['datetime']
+        assert typ['datetime_6'] == 12, typ['datetime_6']
 
         assert row['timestamp'] == datetime.datetime(
             1980, 12, 31, 1, 10, 23,

singlestoredb/tests/test_connection.py

@@ -586,6 +586,9 @@ def otype(x):
         assert row['tinyint'] == 80, row['tinyint']
         assert typ['tinyint'] == otype(1), typ['tinyint']
 
+        assert row['unsigned_tinyint'] == 85, row['unsigned_tinyint']
+        assert typ['unsigned_tinyint'] == otype(1), typ['unsigned_tinyint']
+
         assert row['bool'] == 0, row['bool']
         assert typ['bool'] == otype(1), typ['bool']
 
@@ -595,21 +598,39 @@ def otype(x):
         assert row['smallint'] == -27897, row['smallint']
         assert typ['smallint'] == otype(2), typ['smallint']
 
+        assert row['unsigned_smallint'] == 27897, row['unsigned_smallint']
+        assert typ['unsigned_smallint'] == otype(2), typ['unsigned_smallint']
+
         assert row['mediumint'] == 104729, row['mediumint']
         assert typ['mediumint'] == otype(9), typ['mediumint']
 
+        assert row['unsigned_mediumint'] == 120999, row['unsigned_mediumint']
+        assert typ['unsigned_mediumint'] == otype(9), typ['unsigned_mediumint']
+
         assert row['int24'] == -200899, row['int24']
         assert typ['int24'] == otype(9), typ['int24']
 
+        assert row['unsigned_int24'] == 407709, row['unsigned_int24']
+        assert typ['unsigned_int24'] == otype(9), typ['unsigned_int24']
+
         assert row['int'] == -1295369311, row['int']
         assert typ['int'] == otype(3), typ['int']
 
+        assert row['unsigned_int'] == 3872362332, row['unsigned_int']
+        assert typ['unsigned_int'] == otype(3), typ['unsigned_int']
+
         assert row['integer'] == -1741727421, row['integer']
         assert typ['integer'] == otype(3), typ['integer']
 
+        assert row['unsigned_integer'] == 3198387363, row['unsigned_integer']
+        assert typ['unsigned_integer'] == otype(3), typ['unsigned_integer']
+
         assert row['bigint'] == -266883847, row['bigint']
         assert typ['bigint'] == otype(8), typ['bigint']
 
+        assert row['unsigned_bigint'] == 980007287362, row['unsigned_bigint']
+        assert typ['unsigned_bigint'] == otype(8), typ['unsigned_bigint']
+
         assert row['float'] == -146487000.0, row['float']
         assert typ['float'] == otype(4), typ['float']
 
@@ -658,7 +679,7 @@ def otype(x):
         assert row['datetime_6'] == datetime.datetime(
             1756, 10, 29, 2, 2, 42, 8,
         ), row['datetime_6']
-        assert typ['datetime'] == 12, typ['datetime']
+        assert typ['datetime_6'] == 12, typ['datetime_6']
 
         assert row['timestamp'] == datetime.datetime(
             1980, 12, 31, 1, 10, 23,
@@ -1455,13 +1476,16 @@ def upper(x):
 
     def test_results_format(self):
         columns = [
-            'id', 'tinyint', 'bool', 'boolean', 'smallint', 'mediumint',
-            'int24', 'int', 'integer', 'bigint', 'float', 'double', 'real',
-            'decimal', 'dec', 'fixed', 'numeric', 'date', 'time', 'time_6',
-            'datetime', 'datetime_6', 'timestamp', 'timestamp_6', 'year',
-            'char_100', 'binary_100', 'varchar_200', 'varbinary_200',
-            'longtext', 'mediumtext', 'text', 'tinytext', 'longblob',
-            'mediumblob', 'blob', 'tinyblob', 'json', 'enum', 'set', 'bit',
+            'id', 'tinyint', 'unsigned_tinyint', 'bool', 'boolean',
+            'smallint', 'unsigned_smallint', 'mediumint', 'unsigned_mediumint',
+            'int24', 'unsigned_int24', 'int', 'unsigned_int',
+            'integer', 'unsigned_integer', 'bigint', 'unsigned_bigint',
+            'float', 'double', 'real', 'decimal', 'dec', 'fixed', 'numeric',
+            'date', 'time', 'time_6', 'datetime', 'datetime_6', 'timestamp',
+            'timestamp_6', 'year', 'char_100', 'binary_100', 'varchar_200',
+            'varbinary_200', 'longtext', 'mediumtext', 'text', 'tinytext',
+            'longblob', 'mediumblob', 'blob', 'tinyblob', 'json', 'enum',
+            'set', 'bit',
         ]
 
         with s2.connect(database=type(self).dbname, results_format='tuple') as conn: