PR comments/fixes

Author: ktsitsi

.github/workflows/ci-r-python-interop.yml

@@ -125,7 +125,6 @@ jobs:
           fi
 
       - name: Install tiledbsoma
-        # TILEDB_REMOVE_DEPRECATIONS is already set to ON in pyproject.toml
         run: pip -v install -e apis/python[all]
 
       - name: Show Python package versions

.github/workflows/python-dependency-variation.yml

@@ -102,7 +102,6 @@ jobs:
           fi
 
       - name: Install tiledbsoma
-        # TILEDB_REMOVE_DEPRECATIONS is already set to ON in pyproject.toml
         run: pip -v install -e apis/python[all]
         env:
           CC: ${{ matrix.cc }}

.github/workflows/python-remote-storage.yml

@@ -96,14 +96,7 @@ jobs:
         # If you'reiterating on the testing framework itself, install from PyPI to avoid the
         # time-consuming build. If you're trying to evaluate the code modified by a PR,
         # install from source.
-        #
-        # From PyPI:
-        # run: pip install tiledbsoma==1.15.7
-        #
-        # From source:
-        # TILEDB_REMOVE_DEPRECATIONS is already set to ON in pyproject.toml
         run: pip -v install -e apis/python[all]
-        #
         env:
           CC: ${{ matrix.cc }}
 

.github/workflows/test-python.yml

@@ -91,7 +91,6 @@ jobs:
         uses: actions/download-artifact@v4
         with:
           name: cpp-build-release-${{ inputs.os }}
-        continue-on-error: true
 
       - name: Set up test data
         run: make data
@@ -104,7 +103,6 @@ jobs:
           cache-dependency-path: ./apis/python/pyproject.toml
 
       - name: Install tiledbsoma
-        # TILEDB_REMOVE_DEPRECATIONS is already set to ON in pyproject.toml
         run: pip -v install -e apis/python[all]
         env:
           CC: ${{ inputs.cc }}

apis/python/CMakeLists.txt

@@ -37,17 +37,15 @@ if(EXISTS "${CMAKE_CURRENT_SOURCE_DIR}/tiledbsoma/_version.py")
         set(VERSION_STRING "${CMAKE_MATCH_1}")
         message(STATUS "Package version (from setuptools_scm): ${VERSION_STRING}")
     else()
-        set(VERSION_STRING "0.0.0.dev0")
-        message(WARNING "Could not parse version from _version.py, using default")
+        message(FATAL_ERROR "Could not parse version from _version.py")
     endif()
 elseif(EXISTS "${CMAKE_CURRENT_SOURCE_DIR}/RELEASE-VERSION")
     # Fallback to RELEASE-VERSION file if it exists (matches version.py convention)
     file(READ "${CMAKE_CURRENT_SOURCE_DIR}/RELEASE-VERSION" VERSION_STRING)
     string(STRIP "${VERSION_STRING}" VERSION_STRING)
     message(STATUS "Package version (from RELEASE-VERSION file): ${VERSION_STRING}")
 else()
-    set(VERSION_STRING "0.0.0.dev0")
-    message(WARNING "No version file found, using default version")
+    message(FATAL_ERROR "No version file found, using default version")
 endif()
 
 # Build libtiledbsoma using ExternalProject
@@ -304,11 +302,6 @@ elseif(UNIX)
             message(FATAL_ERROR \"Could not find libtiledbsoma.so in ${LIBTILEDBSOMA_INSTALL_PREFIX}/lib or ${LIBTILEDBSOMA_INSTALL_PREFIX}/lib64\")
         endif()
     ")
-elseif(WIN32)
-    install(FILES ${LIBTILEDBSOMA_INSTALL_PREFIX}/bin/tiledbsoma.dll
-        DESTINATION tiledbsoma
-        OPTIONAL
-    )
 endif()
 
 # Install TileDB shared libraries if not provided externally
@@ -333,10 +326,5 @@ if(NOT DEFINED ENV{TILEDB_PATH})
                 message(FATAL_ERROR \"Could not find libtiledb.so in ${LIBTILEDBSOMA_INSTALL_PREFIX}/lib or ${LIBTILEDBSOMA_INSTALL_PREFIX}/lib64\")
             endif()
         ")
-    elseif(WIN32)
-        install(FILES ${LIBTILEDBSOMA_INSTALL_PREFIX}/bin/tiledb.dll
-            DESTINATION tiledbsoma
-        )
-    endif()
 endif()