disabled searchable dropdown shows "Type to search..." where the field is disabled

[sunnysideup]

Module version(s) affected

5-x.dev

Description

For a disabled dropdown that contains enough records to be "searchable", the field shows Type to search ... where you clearly can not search:

How to reproduce

As above. Basically create a dropdown for a list with MANY entries and the above will happen.

Possible Solution

When setting to readonly (setReadonly method), we should remove that phrase. We should also check if the search is not longer available as this would be a security risk (i.e. you can search all members, where the intention may have been to not show all the members by making it readonly).

Additional Context

No response

Validations

PRs

• FIX remove placeholder search text on readonly field #11419

• Check that there isn't already an issue that reports the same bug

• Double check that your reproduction steps work in a fresh installation of silverstripe/installer (with any code examples you've provided)

[andrewandante]

Hi @sunnysideup I'm actually having trouble reproducing this, mine keep defaulting to (none) - can you please add some specific reproduction steps?

For reference, I'm doing:

        public function getCMSFields()
        {
            $fields = parent::getCMSFields();

            $fields->addFieldToTab(
                'Root.Main',
                SearchableDropdownField::create(
                    'Thing',
                    'Thing',
                    SiteTree::get()
                )
                ->setIsLazyLoaded(true)
                ->performReadonlyTransformation()
            );

            return $fields;
        }

on a clean install