FIX remove placeholder search text on readonly field

Author: andrewandante

src/Forms/SearchableDropdownTrait.php

@@ -139,7 +139,6 @@ public function getPlaceholder(): string
                 return $emptyString;
             }
         }
-        $name = $this->getName();
         if ($this->getUseDynamicPlaceholder()) {
             if ($this->getIsSearchable()) {
                 if (!$this->getIsLazyLoaded()) {
@@ -598,6 +597,9 @@ public function performReadonlyTransformation()
         $field->setSource($this->sourceList);
         $field->setReadonly(true);
 
+        // Remove the text "Type to search..." on a read-only field
+        $field->setPlaceholder('');
+
         return $field;
     }
 }

tests/php/Forms/SearchableDropdownTraitTest.php

@@ -73,6 +73,8 @@ public function testPlaceholder(): void
         $this->assertSame('My empty string', $field->getPlaceholder());
         $field->setPlaceholder('My placeholder');
         $this->assertSame('My placeholder', $field->getPlaceholder());
+        $readonlyField = $field->performReadonlyTransformation();
+        $this->assertSame('', $readonlyField->getPlaceholder());
     }
 
     public function testSeachContext(): void