Clang-Format discussion

[jtxa]

Doing auto-formatting would help in keeping the source consistent.

But it's not possible (today) to make a configuration that matches exactly the current way. Sometimes because the current way is not consistent itself.

If I did not mixed up, this is the file I hand-crafted some time ago:

---
Language:        Cpp

BasedOnStyle:    GNU
Standard:        c++11

# Basic line settings
ColumnLimit:     80
MaxEmptyLinesToKeep: 2

# Basic indentation settings
AccessModifierOffset: -4
IndentAccessModifiers: false
IndentWidth:     4

# Basic space and newline settings
AlignOperands: AlignAfterOperator
BreakBeforeBinaryOperators: NonAssignment
BreakBeforeBraces: Custom
BraceWrapping:
  AfterCaseLabel:  true
  AfterClass:      true
  AfterControlStatement: Always
  AfterEnum:       true
  AfterFunction:   true
  AfterNamespace:  true
  AfterStruct:     true
  AfterUnion:      true
  AfterExternBlock: true
  BeforeCatch:     true
  BeforeElse:      true
  BeforeLambdaBody: true
  BeforeWhile:     true
  IndentBraces:    false
  SplitEmptyFunction: true
  SplitEmptyRecord: true
  SplitEmptyNamespace: true
PointerAlignment: Right
SpaceBeforeParens: ControlStatements


# Single line does not work, because of AlwaysBreakAfterReturnType=AllDefinitions
AllowShortFunctionsOnASingleLine: InlineOnly
AlwaysBreakAfterReturnType: AllDefinitions

AlignAfterOpenBracket: BlockIndent

BinPackArguments: false
BinPackParameters: false

BreakConstructorInitializers: AfterColon
BreakInheritanceList: AfterColon
PackConstructorInitializers: Never

[jtxa]

ColumnLimit:     80

I don't think I like this setting. It does not only force a limit of 80, but it will try to fill up until as much as possible 80.
Effectively removing nice formatting of function declaration/calls with 1 argument per line by 2-5 arguments per line.

I suggest to not enforce a limit on auto-formatting itself.

[SeanAlling-DojoFive]

I agree a hard limit of 80 is not ideal. With modern displays is 80 may even be restricting.

A format that I have enjoyed is Micrium RTOS function formatting, an excerpt below:

OS_OBJ_QTY  OSMutexDel (OS_MUTEX  *p_mutex,
                        OS_OPT     opt,
                        OS_ERR    *p_err)

For all functions each parameter is on its own line and lined up.

Relevant configs:

AllowAllArgumentsOnNextLine: false
AllowAllParametersOfDeclarationOnNextLine: false