Option to skip worker node checks

[Joe-Bresee]

Some provider users have been complaining about node health check issues. It has been described on the issue board that some want a way to skip some node checks, so they can focus on ensuring the cluster endpoint, is healthy. I'm thinking this gives a way for users to focus on desired health statuses and not get lost in worker node status reports.

Since you can't directly change the behaviour of health checks since they are written in talos/, I thought instead you could simply pass workerNodes as empty, therefore not checking any of the workerNodes.

[frezbo]

do we really need this? isn't it easier to just not pass in worker nodes?

[Joe-Bresee]

Hey, the implementation may be wrong, but I think it's needed to be able to disable health checks on the workerNodes. it doesn't seem to work to not pass in worker nodes

[frezbo]

Hey, the implementation may be wrong, but I think it's needed to be able to disable health checks on the workerNodes. it doesn't seem to work to not pass in worker nodes

if you don't pass the worker nodes it'll skip the worker node checks

[Joe-Bresee]

Hey @frezbo,
I appreciate you helping with this pull request. I found that the main issue on my side when using the provider and trying to skip worker nodes is that even when we try not passing in any worker nodes, we see:
unexpected nodes with IPs ["Ips"].
My goal with this PR is to be able to find a clean way to perform a health check, and not see this information.

[frezbo]

Hey @frezbo, I appreciate you helping with this pull request. I found that the main issue on my side when using the provider and trying to skip worker nodes is that even when we try not passing in any worker nodes, we see: unexpected nodes with IPs ["Ips"]. My goal with this PR is to be able to find a clean way to perform a health check, and not see this information.

even when you pass an empty list as []?

[Joe-Bresee]

Yes, and same reaction if you don't define the variable at all