chore: fixes from review

Author: fsgh42

README.md

@@ -16,6 +16,7 @@ libvirt:
 ### Using Docker
 
 copy the provider credentials created in omni to an `.env` file
+
 ```env
 # your omni instance URL
 OMNI_ENDPOINT=https://<OMNI_INSTANCE_NAME>.<REGION>.omni.siderolabs.io
@@ -24,6 +25,7 @@ OMNI_SERVICE_ACCOUNT_KEY=<PROVIDER_KEY>
 ```
 
 example for using the above `ssh` based connection method:
+
 ```bash
 docker run --name omni-infra-provider-libvirt --rm -it -e USER=user --env-file /tmp/omni-provider-libvirt.env -v /tmp/omni-provider-libvirt.yaml:/config.yaml -v /home/user/.ssh:/.ssh:ro ghcr.io/siderolabs/omni-infra-provider-libvirt --config-file /config.yaml
 ```
@@ -37,6 +39,7 @@ see [test/](./test/) for some examples
 see `make help` for general build info.
 
 build an image:
+
 ```shell
 make generate image-omni-infra-provider-libvirt-linux-amd64
 ```

api/specs/specs.pb.go

@@ -1,7 +1,7 @@
 syntax = "proto3";
 package emuspecs;
 
-option go_package = "github.com/siderolabs/omni-infra-provider-proxmox/api/specs";
+option go_package = "github.com/siderolabs/omni-infra-provider-libvirt/api/specs";
 
 // MachineSpec is stored in Omni in the infra provisioner state.
 message MachineSpec {

api/specs/specs.proto

@@ -8,12 +8,12 @@
     "memory": {
       "type": "integer",
       "minimum": 2048,
-      "description": "In MB"
+      "description": "In MiB"
     },
     "disk_size": {
       "type": "integer",
       "minimum": 10,
-      "description": "In GB"
+      "description": "In GiB"
     },
     "storage_pool": {
       "type": "string",

cmd/omni-infra-provider-libvirt/data/schema.json

@@ -70,9 +70,13 @@ var rootCmd = &cobra.Command{
 
 		libvirtConfig := config.LibVirt
 
+		//nolint:errcheck
 		uri, _ := url.Parse(string(libvirt.QEMUSystem))
 		if libvirtConfig.URI != "" {
-			uri, _ = url.Parse(string(libvirtConfig.URI))
+			uri, err = url.Parse(libvirtConfig.URI)
+			if err != nil {
+				return fmt.Errorf("bad libvirt connection URI: %s", libvirtConfig.URI)
+			}
 		}
 
 		logger.Info("libvirt URI", zap.String("URI", uri.String()))
@@ -85,7 +89,8 @@ var rootCmd = &cobra.Command{
 		if !libvirtClient.IsConnected() {
 			return errors.New("client is not connected")
 		}
-		if ver, err := libvirtClient.ConnectGetVersion(); err != nil {
+		ver, err := libvirtClient.ConnectGetVersion()
+		if err != nil {
 			return fmt.Errorf("error fetching version: %w", err)
 		} else {
 			logger.Info(fmt.Sprintf("libvirtVersion: %d", ver))

cmd/omni-infra-provider-libvirt/main.go

@@ -1,6 +1,6 @@
 module github.com/siderolabs/omni-infra-provider-libvirt
 
-go 1.25.0
+go 1.25.3
 
 // forked go-yaml that introduces RawYAML interface, which can be used to populate YAML fields using bytes
 // which are then encoded as a valid YAML blocks with proper indentation
@@ -11,10 +11,10 @@ require (
 	github.com/digitalocean/go-libvirt v0.0.0-20251014225438-3d9fc6d90050
 	github.com/google/uuid v1.6.0
 	github.com/planetscale/vtprotobuf v0.6.1-0.20241121165744-79df5c4772f2
-	github.com/siderolabs/omni/client v0.51.0-beta.1.0.20250903122553-faf5432552c3
+	github.com/siderolabs/omni/client v1.2.0-beta.3.0.20251030232529-3f2021b05f62
 	github.com/spf13/cobra v1.10.1
 	go.uber.org/zap v1.27.0
-	google.golang.org/protobuf v1.36.9
+	google.golang.org/protobuf v1.36.10
 	gopkg.in/yaml.v3 v3.0.3
 	libvirt.org/go/libvirtxml v1.11008.0
 )
@@ -26,63 +26,61 @@ require (
 	github.com/ProtonMail/gopenpgp/v2 v2.9.0 // indirect
 	github.com/adrg/xdg v0.5.3 // indirect
 	github.com/antlr4-go/antlr/v4 v4.13.1 // indirect
-	github.com/blang/semver v3.5.1+incompatible // indirect
 	github.com/blang/semver/v4 v4.0.0 // indirect
 	github.com/cenkalti/backoff/v4 v4.3.0 // indirect
 	github.com/cloudflare/circl v1.6.1 // indirect
-	github.com/containerd/go-cni v1.1.12 // indirect
+	github.com/containerd/go-cni v1.1.13 // indirect
 	github.com/containernetworking/cni v1.3.0 // indirect
 	github.com/dustin/go-humanize v1.0.1 // indirect
 	github.com/gertd/go-pluralize v0.2.1 // indirect
 	github.com/google/btree v1.1.3 // indirect
-	github.com/google/cel-go v0.26.0 // indirect
+	github.com/google/cel-go v0.26.1 // indirect
 	github.com/google/go-cmp v0.7.0 // indirect
-	github.com/grpc-ecosystem/grpc-gateway/v2 v2.27.2 // indirect
+	github.com/grpc-ecosystem/grpc-gateway/v2 v2.27.3 // indirect
 	github.com/hashicorp/errwrap v1.1.0 // indirect
 	github.com/hashicorp/go-multierror v1.1.1 // indirect
 	github.com/inconshreveable/mousetrap v1.1.0 // indirect
-	github.com/josharian/native v1.1.0 // indirect
 	github.com/jsimonetti/rtnetlink/v2 v2.0.5 // indirect
 	github.com/jxskiss/base62 v1.1.0 // indirect
 	github.com/klauspost/compress v1.18.0 // indirect
-	github.com/mdlayher/ethtool v0.4.0 // indirect
+	github.com/mdlayher/ethtool v0.5.0 // indirect
 	github.com/mdlayher/genetlink v1.3.2 // indirect
-	github.com/mdlayher/netlink v1.7.3-0.20250113171957-fbb4dce95f42 // indirect
+	github.com/mdlayher/netlink v1.8.0 // indirect
 	github.com/mdlayher/socket v0.5.1 // indirect
 	github.com/onsi/ginkgo/v2 v2.22.0 // indirect
 	github.com/onsi/gomega v1.36.1 // indirect
 	github.com/opencontainers/runtime-spec v1.2.1 // indirect
-	github.com/petermattis/goid v0.0.0-20250721140440-ea1c0173183e // indirect
+	github.com/petermattis/goid v0.0.0-20250904145737-900bdf8bb490 // indirect
 	github.com/pkg/browser v0.0.0-20240102092130-5ac0b6a4141c // indirect
 	github.com/pkg/errors v0.9.1 // indirect
 	github.com/ryanuber/go-glob v1.0.0 // indirect
-	github.com/sasha-s/go-deadlock v0.3.5 // indirect
-	github.com/siderolabs/crypto v0.6.3 // indirect
+	github.com/sasha-s/go-deadlock v0.3.6 // indirect
+	github.com/siderolabs/crypto v0.6.4 // indirect
 	github.com/siderolabs/gen v0.8.5 // indirect
-	github.com/siderolabs/go-api-signature v0.3.8 // indirect
+	github.com/siderolabs/go-api-signature v0.3.9 // indirect
 	github.com/siderolabs/go-pointer v1.0.1 // indirect
 	github.com/siderolabs/image-factory v0.8.4 // indirect
 	github.com/siderolabs/net v0.4.0 // indirect
 	github.com/siderolabs/proto-codec v0.1.2 // indirect
-	github.com/siderolabs/protoenc v0.2.3 // indirect
+	github.com/siderolabs/protoenc v0.2.4 // indirect
 	github.com/siderolabs/siderolink v0.3.15 // indirect
-	github.com/siderolabs/talos/pkg/machinery v1.11.1 // indirect
+	github.com/siderolabs/talos/pkg/machinery v1.12.0-alpha.2 // indirect
 	github.com/spf13/pflag v1.0.10 // indirect
 	github.com/stoewer/go-strcase v1.3.1 // indirect
 	github.com/stretchr/objx v0.5.2 // indirect
 	go.uber.org/multierr v1.11.0 // indirect
 	go4.org/netipx v0.0.0-20231129151722-fdeea329fbba // indirect
 	golang.org/x/crypto v0.43.0 // indirect
-	golang.org/x/exp v0.0.0-20250718183923-645b1fa84792 // indirect
-	golang.org/x/net v0.45.0 // indirect
+	golang.org/x/exp v0.0.0-20251009144603-d2f985daa21b // indirect
+	golang.org/x/net v0.46.0 // indirect
 	golang.org/x/sync v0.17.0 // indirect
 	golang.org/x/sys v0.37.0 // indirect
 	golang.org/x/text v0.30.0 // indirect
-	golang.org/x/time v0.13.0 // indirect
+	golang.org/x/time v0.14.0 // indirect
 	golang.zx2c4.com/wintun v0.0.0-20230126152724-0fa3db229ce2 // indirect
 	golang.zx2c4.com/wireguard v0.0.0-20250521234502-f333402bd9cb // indirect
 	golang.zx2c4.com/wireguard/wgctrl v0.0.0-20241231184526-a9ab2273dd10 // indirect
-	google.golang.org/genproto/googleapis/api v0.0.0-20250818200422-3122310a409c // indirect
-	google.golang.org/genproto/googleapis/rpc v0.0.0-20250908214217-97024824d090 // indirect
-	google.golang.org/grpc v1.75.1 // indirect
+	google.golang.org/genproto/googleapis/api v0.0.0-20251020155222-88f65dc88635 // indirect
+	google.golang.org/genproto/googleapis/rpc v0.0.0-20251020155222-88f65dc88635 // indirect
+	google.golang.org/grpc v1.76.0 // indirect
 )