fix(download): always send User-Agent and Accept headers (fix glibc and libtirpc build) #211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gilbsgilbs
force-pushed
the
http-send-headers
branch
from
e3fc6a4 to
bde0fae
Compare
gilbsgilbs
changed the title
Member
|
Thanks for the fix. Extensions now use ubuntu mirrors since fedora project uses shasums in url which makes it not at all possible to update via automation |
Contributor
Author
|
I needed to build glibc for v1.11 which still use fedora mirrors, unfortunately. I guess sending UA and Accept header is good practice regardless? |
Member
Yes, I was just pointing out the change we made |
smira
force-pushed
the
http-send-headers
branch
from
bde0fae to
5d6ff9a
Compare
When downloading files, src.fedoraproject.org now requires the Accept header to be present. If the header is missing, it returns an HTML page instead of the requested file, causing a checksum mismatch. This change adds the "Accept: */*" and "User-Agent: BLDR/<version>" headers to all HTTP downloads to prevent this issue. This was discovered when glibc and libtirpc packages started to fail recently in the extensions repository[1]. [1] https://github.com/siderolabs/extensions/ Signed-off-by: Gilbert Gilb's <[email protected]> Signed-off-by: Andrey Smirnov <[email protected]>
smira
force-pushed
the
http-send-headers
branch
from
5d6ff9a to
33e25e2
Compare
Member
|
/m |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When downloading files, src.fedoraproject.org now requires the Accept header to be present. If the header is missing, it returns an HTML page instead of the requested file, causing a checksum mismatch.
This change adds the
Accept: */*andUser-Agent: BLDR/<version>headers to all HTTP downloads to prevent this issue.This was discovered when glibc and libtirpc packages started to fail recently in the extensions repository[1].
[1] https://github.com/siderolabs/extensions/