Skip to content

Fix: Restore result-encoding in detect-invalid-ci-commands workflow #2199

@justin808

Description

@justin808

Summary

The result-encoding: string parameter was accidentally removed from .github/workflows/detect-invalid-ci-commands.yml in commit 4970d21 ("Fix JSON parsing error in detect-invalid-ci-commands workflow").

This removal may cause issues with the workflow's JSON parsing logic.

Current State (on master)

The workflow has:

- name: Check for similar commands
  id: check_command
  uses: actions/github-script@v7
  with:
    script: |
      // ... script content ...
      return { shouldRespond: false };
    result-encoding: string

What was removed

In branch jg/swc-detection-fix, commit 4970d21 removed the result-encoding: string line.

Fix Required

Restore the result-encoding: string parameter if it's needed for proper JSON parsing, or verify that the workflow works correctly without it.

Context

This change was bundled with an unrelated SWC detection feature PR. It should be handled separately.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions