Merge pull request #315 from icylogic/hotfix/repeated_iv

icylogic · icylogic · commit 86bf0b3b2c77 · 2015-09-19T15:53:01.000+08:00
no repeat random number generator by GangZhuo
diff --git a/shadowsocks-csharp/Encryption/IVEncryptor.cs b/shadowsocks-csharp/Encryption/IVEncryptor.cs
@@ -88,7 +88,8 @@ protected void bytesToKey(byte[] password, byte[] key)
         protected static void randBytes(byte[] buf, int length)
         {
             byte[] temp = new byte[length];
-            new Random().NextBytes(temp);
+            RNGCryptoServiceProvider rngServiceProvider = new RNGCryptoServiceProvider();
+            rngServiceProvider.GetBytes(temp);
             temp.CopyTo(buf, 0);
         }
 

Original file line number	Diff line number	Diff line change
`@@ -88,7 +88,8 @@ protected void bytesToKey(byte[] password, byte[] key)`
`88`	`88`	`protected static void randBytes(byte[] buf, int length)`
`89`	`89`	`{`
`90`	`90`	`byte[] temp = new byte[length];`
`91`		`- new Random().NextBytes(temp);`
	`91`	`+ RNGCryptoServiceProvider rngServiceProvider = new RNGCryptoServiceProvider();`
	`92`	`+ rngServiceProvider.GetBytes(temp);`
`92`	`93`	`temp.CopyTo(buf, 0);`
`93`	`94`	`}`
`94`	`95`