LED notification

[ete31]

I had to go back to ver. 1.14 because with 1.16 the notifications via led light doesn't work anymore.
With ver. 1.16 this Session setting is no longer present and with only the standard android settings it doesn't work.
Please put this notification mode back in session settings!

Steps to reproduce the behavior: all the notifications

Smartphone:

• Device: Cubot Kingkong Mini 2
• OS: 10
• Version of Session: 1.16.4

[hjubb]

I think this one might be in the AbstractNotificationBuilder's setLed() function. We are reading in the prefs value for the selected theme primary colour which might be returning a R.color resource identifier instead of the actual colour value. Probably setting a breakpoint in that setLed() function to debug what the colour is actually being represented as (checking ledColor == R.color.whatever in a breakpoint evaluation to see if we then need to do a ContextCompat.getColor(context, ledColor) instead of just using that value directly.

After that we just need to test it is what we expect it to be if anyone has a device with coloured LED for notifications or if there's an easy way to test it with the emulator I can look as well 😅