fix: user-data template

Fix functions used in the template framework.

Signed-off-by: Serge Logvinov <[email protected]>

Author: sergelogvinov

docs/functions.md

@@ -87,6 +87,18 @@ The Cloud-Init provider supports several template functions that can be used to
   {{ trimPrefix "hello" "he" }} -> llo
   ```
 
+* `split` - the function to split the string by the given separator and return a slice of strings.
+
+  ```yaml
+  {{ split "a,b,c" "," }} -> [a b c]
+  ```
+
+* `join` - the function to join a slice of strings with the given separator.
+
+  ```yaml
+  {{ join (list "a" "b" "c") "," }} -> a,b,c
+  ```
+
 * `replace` - the function to replace all occurrences of the old string with the new string.
 
   ```yaml

pkg/providers/instance/cloudinit/functions.go

@@ -50,6 +50,8 @@ var genericMap = map[string]interface{}{
 	"trim":       strings.TrimSpace,
 	"trimSuffix": func(a, b string) string { return strings.TrimSuffix(b, a) },
 	"trimPrefix": func(a, b string) string { return strings.TrimPrefix(b, a) },
+	"split":      strings.Split,
+	"join":       strings.Join,
 
 	"replace":         func(o, n, s string) string { return strings.ReplaceAll(s, o, n) },
 	"regexFind":       regexFind,
@@ -191,7 +193,7 @@ func toYamlPretty(v any) string {
 }
 
 // hasKey returns true if the given map has the given key.
-func hasKey(m map[string]interface{}, key string) bool {
+func hasKey(m map[string]any, key string) bool {
 	if empty(m) {
 		return false
 	}
@@ -271,7 +273,7 @@ func regexFind(regex string, s string) (string, error) {
 }
 
 // get returns the value for the given key in the given map, or an empty string if the key does not exist.
-func get(m map[string]interface{}, key string) interface{} {
+func get(m map[string]string, key string) string {
 	if val, ok := m[key]; ok {
 		return val
 	}

pkg/providers/instance/cloudinit/userdata.go

@@ -29,7 +29,7 @@ users:
     shell: /bin/bash
     {{- with get .Values "SSHAuthorizedKeys" }}
     ssh_authorized_keys:
-      {{- toYaml . | nindent 6 }}
+      {{- toYaml (split . ",") | nindent 6 }}
     {{- end }}
 
 write_files:

pkg/providers/instance/cloudinit/userdata_test.go

@@ -44,7 +44,7 @@ write_files:
     permissions: 0o600
     defer: true
     content: |
-      {{- .Metadata.Tags | toYamlPretty | nindent 6 }}
+      {{- join .Metadata.Tags "," | nindent 6 }}
 {{- end }}
 `
 )
@@ -57,7 +57,7 @@ func TestUserData(t *testing.T) {
 	data := struct {
 		Metadata             cloudinit.MetaData
 		KubeletConfiguration *instance.KubeletConfiguration
-		Values               map[string]interface{}
+		Values               map[string]string
 	}{
 		Metadata: cloudinit.MetaData{
 			Hostname:     "hostname-1",
@@ -74,8 +74,8 @@ func TestUserData(t *testing.T) {
 			TopologyManagerPolicy: "best-effort",
 			ProviderID:            provider.GetProviderID(region, 100),
 		},
-		Values: map[string]interface{}{
-			"SSHAuthorizedKeys": []string{"ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABAQCu..."},
+		Values: map[string]string{
+			"SSHAuthorizedKeys": "ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABAQCu...,ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABAQDk...",
 		},
 	}
 
@@ -101,6 +101,7 @@ users:
     shell: /bin/bash
     ssh_authorized_keys:
       - ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABAQCu...
+      - ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABAQDk...
 
 write_files:
   - path: /etc/karpenter.yaml
@@ -124,8 +125,7 @@ write_files:
           - kernel.shmmax
         providerID: proxmox://test-region/100
       values:
-        SSHAuthorizedKeys:
-          - ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABAQCu...
+        SSHAuthorizedKeys: ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABAQCu...,ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABAQDk...
     owner: root:root
 `,
 		},
@@ -153,8 +153,7 @@ write_files:
     permissions: 0o600
     defer: true
     content: |
-      - tag1
-      - tag2
+      tag1,tag2
 `,
 		},
 	}

pkg/providers/instance/instance_cloudinit.go

@@ -25,6 +25,7 @@ import (
 
 	"github.com/luthermonson/go-proxmox"
 
+	goproxmox "github.com/sergelogvinov/go-proxmox"
 	"github.com/sergelogvinov/karpenter-provider-proxmox/pkg/apis/v1alpha1"
 	"github.com/sergelogvinov/karpenter-provider-proxmox/pkg/providers/cloudcapacity"
 	"github.com/sergelogvinov/karpenter-provider-proxmox/pkg/providers/instance/cloudinit"
@@ -205,10 +206,14 @@ func (p *DefaultProvider) generateCloudInitVars(
 		return "", "", "", "", fmt.Errorf("failed to create bootstrap token: %v", err)
 	}
 
+	smbios1 := goproxmox.VMSMBIOS{}
+	smbios1.UnmarshalString(vm.VirtualMachineConfig.SMBios1)
+
 	metadataValues := cloudinit.MetaData{
 		Hostname:     nodeClaim.Name,
 		InstanceID:   fmt.Sprintf("%d", vm.VMID),
 		InstanceType: instanceType.Name,
+		InstanceUUID: smbios1.UUID,
 		ProviderID:   provider.GetProviderID(region, int(vm.VMID)),
 		Region:       region,
 		Zone:         zone,