Skip to content

Property selected should include PropTypes.number to allow integer values #1625

@ADTC

Description

@ADTC

const SelectedPropType = PropTypes.oneOfType([PropTypes.string, PropTypes.arrayOf(PropTypes.string)])

Please allow PropTypes.number here. Sometimes the value is numeric - quite common when display label is a string, but internal value is an int.

Although the application works, this throws error in the console.

Warning: Failed prop type: Invalid prop `selected` supplied to `SelectMenu`, expected one of type [string].
SelectMenu@webpack-internal:///./node_modules/evergreen-ui/esm/select-menu/src/SelectMenu.js:39:15
▽ React 6
        printWarning
        error
        checkPropTypes
        validatePropTypes
        jsxWithValidation
        jsxWithValidationDynamic

Right now I'm overriding the propTypes to fix the error:

SelectMenu.propTypes = {
  ...SelectMenu.propTypes,
  selected: PropTypes.oneOfType([
    PropTypes.string,
    PropTypes.arrayOf(PropTypes.string),
    PropTypes.number,
  ]),
};

Activity

AbhiJain2196

AbhiJain2196 commented on Apr 6, 2023

@AbhiJain2196

Added type number to proptypes #1627

linked a pull request that will close this issue on Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      Participants

      @ADTC@brandongregoryscott@AbhiJain2196

      Issue actions

        Property `selected` should include `PropTypes.number` to allow integer values · Issue #1625 · segmentio/evergreen