fix(webpush): improve iOS push subscription endpoint cleanup #2140
+129
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
0xSysR3ll
force-pushed
the
0xsysr3ll/fix/push-subscription-cleanup
branch
from
95f189f to
ebeceed
Compare
0xSysR3ll
force-pushed
the
0xsysr3ll/fix/push-subscription-cleanup
branch
from
af36d28 to
b13b68d
Compare
Signed-off-by: 0xsysr3ll <[email protected]>
Signed-off-by: 0xsysr3ll <[email protected]>
Signed-off-by: 0xsysr3ll <[email protected]>
Signed-off-by: 0xsysr3ll <[email protected]>
Signed-off-by: 0xsysr3ll <[email protected]>
0xSysR3ll
force-pushed
the
0xsysr3ll/fix/push-subscription-cleanup
branch
from
b13b68d to
0972263
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Following sct/overseerr#4222, this PR tries to improve push subscription handling for iOS devices where endpoints can refresh periodically.
It also adds proper error handling based on RFC 8030 by clearly separating permanent errors from temporary ones.
Screenshot (if UI-related)
To-Dos
pnpm buildpnpm i18n:extractIssues Fixed or Closed