Skip to content

Commit 2384329

Browse files
committed
fix: hardcoded constants
Signed-off-by: Gregory Edison <[email protected]>
1 parent 659aab3 commit 2384329

File tree

2 files changed

+8
-5
lines changed

2 files changed

+8
-5
lines changed

crates/scroll/node/src/args.rs

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,17 @@
11
use crate::builder::payload::SCROLL_DEFAULT_PAYLOAD_SIZE_LIMIT;
22

3+
use reth_scroll_rpc::eth::DEFAULT_MIN_SUGGESTED_PRIORITY_FEE;
4+
35
/// Rollup arguments for the Scroll node.
46
#[derive(Debug, Clone, clap::Args)]
57
pub struct ScrollRollupArgs {
68
/// Endpoint for the sequencer mempool (can be both HTTP and WS)
79
#[arg(long = "scroll.sequencer")]
810
pub sequencer: Option<String>,
911

10-
/// Minimum suggested priority fee (tip) in wei, default `1_000_000`
11-
#[arg(long = "scroll.min-suggested-priority-fee", default_value_t = 1_000_000)]
12+
/// Minimum suggested priority fee (tip) in wei, default to
13+
/// [`DEFAULT_MIN_SUGGESTED_PRIORITY_FEE`].
14+
#[arg(long = "scroll.min-suggested-priority-fee", default_value_t = DEFAULT_MIN_SUGGESTED_PRIORITY_FEE)]
1215
pub min_suggested_priority_fee: u64,
1316

1417
/// Payload size limit, default to `122kB`.
@@ -20,7 +23,7 @@ impl Default for ScrollRollupArgs {
2023
fn default() -> Self {
2124
Self {
2225
sequencer: None,
23-
min_suggested_priority_fee: 1_000_000,
26+
min_suggested_priority_fee: DEFAULT_MIN_SUGGESTED_PRIORITY_FEE,
2427
payload_size_limit: SCROLL_DEFAULT_PAYLOAD_SIZE_LIMIT,
2528
}
2629
}

crates/scroll/rpc/src/eth/mod.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -301,10 +301,10 @@ pub type ScrollRpcConvert<N, NetworkT> = RpcConverter<
301301
>;
302302

303303
/// The default suggested priority fee for the gas price oracle.
304-
const DEFAULT_MIN_SUGGESTED_PRIORITY_FEE: u64 = 100;
304+
pub const DEFAULT_MIN_SUGGESTED_PRIORITY_FEE: u64 = 100;
305305

306306
/// The default payload size limit in bytes for the sequencer.
307-
const DEFAULT_PAYLOAD_SIZE_LIMIT: u64 = 122_880;
307+
pub const DEFAULT_PAYLOAD_SIZE_LIMIT: u64 = 122_880;
308308

309309
/// A type that knows how to build a [`ScrollEthApi`].
310310
#[derive(Debug)]

0 commit comments

Comments
 (0)