Can't wait longer than 2147483.647 seconds

[ericrosenbaum]

Expected Behavior

Any number of seconds entered into e.g. a "say" or "wait" block should cause the block to wait that number of seconds.

Actual Behavior

Numbers of seconds over a certain large threshold cause the wait time to be zero. We often see kids typing in very large numbers like this.

With help from @rschamp, we found the exact threshold, which is 2147483.647 (1/1000 of max int, presumably because it is converted to milliseconds). So, waiting for 2147483.647 seconds seems to work (though we didn't actually wait for 24.8 days to find out), but waiting for 2147483.648 seconds waits for 0 instead:

Steps to Reproduce

See gif

[apple502j]

In some programming languages, the max value of integers is 2147483647.
Inside the code, the block calculates 1000 times the seconds,
so 2147483.647 * 1000 = 2147483647
2147483.648 * 1000 = -2147483648

[thisandagain]

Adding 'help-wanted' to this. I would recommend modifying the math utilities to include a call to Number.isSafeInteger. If it fails, the result should be 253 - 1 (maximum double precision number as per IEEE-754).

[apple502j]

Or use unsigned int for seconds?

[Kenny2github]

@apple502j unsigned int just means the limit is higher, not gone. I would recommend an equivalent to Python 2's long integer type, if such a thing exists in JS.

[kchadha]

Sort of related, I noticed that we use two different number fields (and therefore different validation as to what characters can be typed in) for the wait (n) seconds block vs. the say/think [hello] for (n) seconds blocks. Should they be the same? The wait block does not allow typing in negative numbers while the say/think blocks do.

[thisandagain]

@kchadha Good catch! That should be fixed. The say/think and glide blocks should use the same validation as the wait block.

[Kenny2github]

@kchadha but do the number inputs in the say/think blocks have this problem as well?

[kchadha]

@Kenny2github yeah, the say/think blocks are the ones mentioned in the original bug report above.

[towerofnix]

(This is tagged with "help-wanted", not "help wanted"; probably a mistake since the vast majority of other issues are tagged "help wanted", and GitHub only recognizes issues labeled "help wanted".)