Let Issue take a node as input

Author: Gallaecio

flake8_scrapy/finders/settings.py

@@ -154,7 +154,7 @@ def check_name(
             27,
             "unknown setting",
             detail=detail,
-            line=resolved_node.lineno,
+            node=resolved_node,
             column=column,
         )
 
@@ -319,8 +319,7 @@ def check_assignment_redefinition(
                         7,
                         "redefined setting",
                         detail=f"seen first at line {seen[name]}",
-                        line=node.lineno,
-                        column=node.col_offset,
+                        node=node,
                     )
                 )
                 continue
@@ -336,7 +335,7 @@ def check_import_statement(self, node: Import | ImportFrom) -> None:
                 Issue(
                     12,
                     "imported setting",
-                    line=node.lineno,
+                    node=node,
                     column=import_column(node, import_alias),
                 )
             )
@@ -355,7 +354,7 @@ def check_all_nodes_issues(self, node: Module) -> None:
                     Issue(
                         11,
                         "improper setting definition",
-                        line=child.lineno,
+                        node=child,
                         column=definition_column(child),
                     )
                 )

flake8_scrapy/issues.py

@@ -11,6 +11,20 @@ class Issue:
     line: int = 1
     column: int = 0
 
+    def __init__(self, code, summary, detail=None, line=None, column=None, node=None):  # noqa: PLR0913
+        if node is not None:
+            node_line = getattr(node, "lineno", None)
+            node_col = getattr(node, "col_offset", None)
+            if line is None:
+                line = node_line
+            if column is None:
+                column = node_col
+        self.code = code
+        self.summary = summary
+        self.detail = detail
+        self.line = line if line is not None else 1
+        self.column = column if column is not None else 0
+
     def __iter__(self):
         message = f"SCP{self.code:02} {self.summary}"
         if self.detail: