Skip to content

Commit c618e45

Browse files
authored
Task/update dependencies (#5)
* remove package json lock * update project config * update pr template * update project config * apply lint rules
1 parent 2a73b52 commit c618e45

File tree

12 files changed

+64
-5405
lines changed

12 files changed

+64
-5405
lines changed

.github/PULL_REQUEST_TEMPLATE.md

Lines changed: 13 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -1,28 +1,18 @@
1-
# Background
1+
## Description
2+
<!--- Explain why this PR has to be merged, what originated this feature, ... -->
23

3-
X
4+
## Solves ticket/s
5+
<!--- Optionally, add the tickets (jira, mantis, trello, ...) that are related to this PR -->
46

5-
# Goal
7+
## Expected behavior
8+
<!--- Add information of what's expected to happen when this is merged -->
69

7-
X
10+
## Review steps
11+
<!--- Nice to have, add the steps you've reproduced for a visual test in your development environment, or loc, consider adding screenshots ... -->
812

9-
# Implementation
10-
11-
X
12-
13-
# Further considerations
14-
15-
X
16-
17-
# Checklist
18-
19-
- [ ] The PR relates to *only* one subject with a clear title.
20-
- [ ] I have performed a self-review of my own code
21-
- [ ] Wrote [good commit messages](http://chris.beams.io/posts/git-commit/)
22-
- [ ] My code is readable by someone else, and I commented the hard-to-understand areas
23-
- [ ] I have made corresponding changes to the documentation
24-
25-
# Visual Description
26-
27-
![]()
13+
## Further considerations
14+
<!--- If applies, add information of breaking changes, agreed deploy timings, ... -->
2815

16+
## Memetized description
17+
<!--- Mandatory gif, try https://giphy.com/ -->
18+
![mandatory]()

.gitignore

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,4 +57,5 @@ typings/
5757
# dotenv environment variables file
5858
.env
5959

60-
dist
60+
dist
61+
package-lock.json

.npmignore

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
11
src
22
.travis.yml
3-
.idea
3+
.idea
4+
versiona.js
5+
.github

.travis.yml

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,13 @@
1+
dist: trusty
12
language: node_js
23
node_js:
3-
- "7"
4+
- "8"
45
cache:
56
directories:
6-
- node_modules
7+
- node_modules
8+
9+
before_install:
10+
- npm config set //registry.npmjs.org/:_authToken=$NPM_TOKEN
11+
712
script:
8-
- npm run lint
13+
- npm run check && npm run versiona

README.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,8 @@
11
# OpenAds-ConnectorAPI
22

3+
![npm](https://img.shields.io/npm/v/@schibstedspain/openads-connector-api)
4+
[![Build status](https://travis-ci.org/scm-spain/OpenAds-ConnectorAPI.svg?branch=master)](https://travis-ci.org/scm-spain/OpenAds-ConnectorAPI)
5+
36
Compliant interfaces to be implemented to develop an OpenAds connector.
47

58
## AdViewable

0 commit comments

Comments
 (0)