Add OpenShift versions 4.0-ubi9 and 4.0-ubi10 to tests - #193
Conversation
Update also compose to RHEL-9.8
📝 WalkthroughWalkthroughThe OpenShift tests workflow job is renamed from "imagestream" to "pytest". The test matrix is updated to use simplified version values ( ChangesOpenShift Pytest Workflow Update
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[test] |
The versions will be skipped by constants.py like here: sclorg/cakephp-ex#166 Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/openshift-tests.yml:
- Line 14: The workflow defines multiple OS variants (rhel8, rhel9, rhel10) in
the matrix at line 14, but the status context updated at line 29 does not
include the OS variant identifier. This causes all three OS jobs to write to the
same PR status context, overwriting each other and masking failures. Modify the
status context construction at line 29 to include the OS matrix variable (such
as the os variable from the matrix) so that each OS variant gets its own unique
status context. This ensures jobs for rhel8, rhel9, and rhel10 update separate
status checks instead of colliding.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 49fb9e50-e58c-4664-950b-03aad7fa7199
📒 Files selected for processing (1)
.github/workflows/openshift-tests.yml
| matrix: | ||
| version: [ "2.5-ubi8", "3.0-ubi9", "3.3-ubi8", "3.3-ubi9", "3.3-ubi10" ] | ||
| version: [ "2.5", "3.0", "3.3", "4.0" ] | ||
| os: [ "rhel8", "rhel9", "rhel10" ] |
There was a problem hiding this comment.
Status context collides across OS matrix entries
Line 14 introduces three OS variants, but Line 29 keys PR status only by version. With update_pull_request_status: true, jobs for rhel8/rhel9/rhel10 will overwrite the same status context per version and can hide failures.
Suggested patch
- pull_request_status_name: "RHEL9-OpenShift-4 - PyTest ${{ matrix.version }}"
+ pull_request_status_name: "RHEL9-OpenShift-4 - PyTest ${{ matrix.os }}-${{ matrix.version }}"Also applies to: 29-29
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.github/workflows/openshift-tests.yml at line 14, The workflow defines
multiple OS variants (rhel8, rhel9, rhel10) in the matrix at line 14, but the
status context updated at line 29 does not include the OS variant identifier.
This causes all three OS jobs to write to the same PR status context,
overwriting each other and masking failures. Modify the status context
construction at line 29 to include the OS matrix variable (such as the os
variable from the matrix) so that each OS variant gets its own unique status
context. This ensures jobs for rhel8, rhel9, and rhel10 update separate status
checks instead of colliding.
Update also compose to RHEL-9.8
Summary by CodeRabbit