Skip to content

Add OpenShift versions 4.0-ubi9 and 4.0-ubi10 to tests - #193

Merged
phracek merged 2 commits into
masterfrom
add_new_version
Jun 16, 2026
Merged

phracek merged 2 commits into
masterfrom
add_new_version

Conversation

@phracek

@phracek phracek commented Jun 16, 2026

Copy link
Copy Markdown
Member

Update also compose to RHEL-9.8

Summary by CodeRabbit

  • Chores
    • Switched OpenShift testing workflow from imagestream to pytest-based testing
    • Expanded test coverage across RHEL 8, 9, and 10 with product versions 2.5, 3.0, 3.3, and 4.0
    • Upgraded testing environment to use RHEL 9.8.0 nightly compose

@coderabbitai

coderabbitai Bot commented Jun 16, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

The OpenShift tests workflow job is renamed from "imagestream" to "pytest". The test matrix is updated to use simplified version values (2.5, 3.0, 3.3, 4.0) across OS targets (rhel8, rhel9, rhel10). The testing-farm action inputs are updated to use RHEL-9.8.0-Nightly, a "PyTest" PR status label, and a dynamic OS=${{ matrix.os }} variable.

Changes

OpenShift Pytest Workflow Update

Layer / File(s) Summary
Job matrix, compose target, and variables update
.github/workflows/openshift-tests.yml
Job renamed to "RHEL9 tests: pytest"; matrix versions changed to 2.5/3.0/3.3/4.0 with OS targets rhel8/rhel9/rhel10; nightly compose bumped to RHEL-9.8.0-Nightly; PR status label changed from "imagestream test" to "PyTest"; variables updated to pass OS=${{ matrix.os }}; tf_scope input removed.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐇 A hop from imagestream days gone by,
Now pytest runs as RHEL versions fly,
rhel8, rhel9, rhel10 in a row,
The matrix expands, watch the pipelines glow,
Dynamic OS, no more hardcoded ways —
The rabbit cheers for these CI-polished days! 🌟

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Title check ⚠️ Warning The PR title mentions adding OpenShift versions 4.0-ubi9 and 4.0-ubi10, but the actual changes show the job was switched from 'imagestream' to 'pytest' test with RHEL-based versions and a different test matrix approach. Revise the title to accurately reflect the main change: switching from imagestream to pytest testing with RHEL versions, or verify if the actual changes align with the stated objective of adding specific OpenShift versions.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch add_new_version

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@phracek

phracek commented Jun 16, 2026

Copy link
Copy Markdown
Member Author

[test]

@jackorp jackorp left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

The versions will be skipped by constants.py like here:
sclorg/cakephp-ex#166

Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/openshift-tests.yml:
- Line 14: The workflow defines multiple OS variants (rhel8, rhel9, rhel10) in
the matrix at line 14, but the status context updated at line 29 does not
include the OS variant identifier. This causes all three OS jobs to write to the
same PR status context, overwriting each other and masking failures. Modify the
status context construction at line 29 to include the OS matrix variable (such
as the os variable from the matrix) so that each OS variant gets its own unique
status context. This ensures jobs for rhel8, rhel9, and rhel10 update separate
status checks instead of colliding.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 49fb9e50-e58c-4664-950b-03aad7fa7199

📥 Commits

Reviewing files that changed from the base of the PR and between 68b2f40 and d04d927.

📒 Files selected for processing (1)
  • .github/workflows/openshift-tests.yml

matrix:
version: [ "2.5-ubi8", "3.0-ubi9", "3.3-ubi8", "3.3-ubi9", "3.3-ubi10" ]
version: [ "2.5", "3.0", "3.3", "4.0" ]
os: [ "rhel8", "rhel9", "rhel10" ]

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major | ⚡ Quick win

Status context collides across OS matrix entries

Line 14 introduces three OS variants, but Line 29 keys PR status only by version. With update_pull_request_status: true, jobs for rhel8/rhel9/rhel10 will overwrite the same status context per version and can hide failures.

Suggested patch
-          pull_request_status_name: "RHEL9-OpenShift-4 - PyTest ${{ matrix.version }}"
+          pull_request_status_name: "RHEL9-OpenShift-4 - PyTest ${{ matrix.os }}-${{ matrix.version }}"

Also applies to: 29-29

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.github/workflows/openshift-tests.yml at line 14, The workflow defines
multiple OS variants (rhel8, rhel9, rhel10) in the matrix at line 14, but the
status context updated at line 29 does not include the OS variant identifier.
This causes all three OS jobs to write to the same PR status context,
overwriting each other and masking failures. Modify the status context
construction at line 29 to include the OS matrix variable (such as the os
variable from the matrix) so that each OS variant gets its own unique status
context. This ensures jobs for rhel8, rhel9, and rhel10 update separate status
checks instead of colliding.

@phracek
phracek merged commit b443eff into master Jun 16, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants