Skip to content

Refactored cameras that are operated using SHM keywords between control and framegrabbing processes. #29

@DasVinch

Description

@DasVinch

Refactored code used by cameras that leverage the SHM keyword struct to pass commands between the python control and the acquisition process.
Did that as I was integrating the Andor CB2 (and, more broadly, for any silly GenICam that would want the command passed by string).

This affects DCAM and PVCAM.

Now, the camera class composes with a CommandTransport subclass which defines:

  • what type are the api keys (int for dcam, pvcam - str or Prop class for CB2)
  • What the protocol for encoding/decoding into (key, value, comment) is
  • How to take a SHM return value into something for fits headers and something for python code.

Notifying in case this causes a regression on OrcaQuest @mileslucas :).

See 4484f7e

Metadata

Metadata

Assignees

No one assigned

    Labels

    questionFurther information is requested

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions