Skip to content

Commit ed1855d

Browse files
committed
fix: remove built-in debug middleware
1 parent 32cfe5a commit ed1855d

File tree

2 files changed

+2
-25
lines changed

2 files changed

+2
-25
lines changed

router.go

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -76,17 +76,8 @@ func (r *Router) buildMiddlewares(m Middlewares) Middlewares {
7676
m2.Skip = append(m2.Skip, m.Skip...)
7777
m2.Skip = append(m2.Skip, r.middlewares.Skip...)
7878

79-
switch {
80-
case r.parent != nil:
79+
if r.parent != nil {
8180
return r.parent.buildMiddlewares(m2)
82-
case r.cfg.debug:
83-
debugMiddleware := func(ctx *RequestCtx) error {
84-
r.cfg.logger.Printf("%s %s", ctx.Method(), ctx.URI())
85-
86-
return ctx.Next()
87-
}
88-
89-
m2.Before = append([]Middleware{debugMiddleware}, m2.Before...)
9081
}
9182

9283
m2.Before = appendMiddlewares(m2.Before[:0], m2.Before, m2.Skip...)
@@ -130,7 +121,6 @@ func (r *Router) handler(fn View, middle Middlewares) fasthttp.RequestHandler {
130121
statusCode = fasthttp.StatusInternalServerError
131122
}
132123

133-
r.cfg.logger.Printf("error view: %s", err)
134124
r.cfg.errorView(actx, err, statusCode)
135125

136126
break

router_test.go

Lines changed: 1 addition & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -204,19 +204,10 @@ func TestRouter_buildMiddlewares(t *testing.T) {
204204
t.Errorf("Middlewares.Skip length == %d, want %d", len(result.Skip), wantSkipLen)
205205
}
206206

207-
wantBeforeLen := len(middle.Before) - len(m.Skip)
208-
if s.cfg.Debug {
209-
wantBeforeLen++
210-
}
211-
212-
if len(result.Before) != wantBeforeLen {
207+
if wantBeforeLen := len(middle.Before) - len(m.Skip); len(result.Before) != wantBeforeLen {
213208
t.Errorf("Middlewares.Before length == %d, want %d", len(result.Before), wantBeforeLen)
214209
}
215210

216-
if s.cfg.Debug && isEqual(result.Before[0], middle.Before[1]) {
217-
t.Error("First before middleware must be the logger middleware")
218-
}
219-
220211
wantAfterLen := len(middle.After)
221212
if len(result.After) != wantAfterLen {
222213
t.Errorf("Middlewares.After length == %d, want %d", len(result.After), wantAfterLen)
@@ -703,10 +694,6 @@ func TestRouter_handler(t *testing.T) { //nolint:funlen,maintidx
703694
t.Errorf("After view call counter = %v, want %v", handlerCounter.afterViewMiddlewares,
704695
tt.want.counter.afterViewMiddlewares)
705696
}
706-
707-
if logOutput.Len() == 0 {
708-
t.Errorf("Debug trace has not been write in log when logger 'debug' is enabled")
709-
}
710697
})
711698
}
712699
}

0 commit comments

Comments
 (0)