Keyring warning in vagrant-spk init should reference relevant file to back up

[fixermark]

When running vagrant-spk init, the following warning is emitted:

Calling 'vagrant' 'ssh' '-c' 'spk init -p 8000 --keyring=/host-dot-sandstorm/sandstorm-keyring --output=/opt/app/.sandstorm/sandstorm-pkgdef.capnp  -- /bin/bash /opt/app/.sandstorm/launcher.sh' in $REDACTED_PRIVACY/.sandstorm
** WARNING: Keys are being added to:
**   /host-dot-sandstorm/sandstorm-keyring
** Please make a backup of this file and keep it safe. If you lose your keys,
** you won't be able to update your app. If someone steals your keys, they
** will be able to post updates for your app. (Use -q to quiet this warning.)
wrote: /opt/app/.sandstorm/sandstorm-pkgdef.capnp

It is unclear from context what file should be backed up. It appears it's referring to the keyring file at $HOME/.sandstorm/sandstorm-keyring.

[ocdtrekkie]

Would it be more clear if we changed "this file" to "the above file"? The warning only lists one file, but I'm guessing you're finding the fact that after the warning it mentions the pkgdef as an additional factor.

[fixermark]

I'm not sure how to get from the above text to the notion that the file to be backed up is the one at $HOME/.sandstorm/sandstorm-keyring. Is that the same file as /host-dot-sandstorm/sandstorm-keyring, and if so, how is the user supposed to know that is the case (or where /host-dot-sandstorm is)?

[ocdtrekkie]

Ahhhh, yeah, we aren't telling you it's in your home directory here. And unfortunately this is another case where this message is generated by Sandstorm, not vagrant-spk, and Sandstorm in this case only sees the VM. So we probably could put a separate warning... but I don't know if we can suppress the warning from spk being printed. Hmm.