Don't drop in-flight decode jobs when seeking in cram_next_slice() #1973
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cram_next_slice() with a region set tries to skip over containers with contents that don't overlap the region of interest. For files with a mixture of read lengths, it's possible that some decode jobs have been queued before a later container is skipped. This makes calling cram_seek() hazardous as it drops any in-flight jobs before updating the file position. Instead, call hseek() directly so already-queued decode jobs are retained.
The test creates a CRAM file with records in lots of containers, many of which should be skipped when making a region query that expects to return the first and last two records in the file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cram_next_slice()with a region set tries to skip over containers with contents that don't overlap the region of interest. For files with a mixture of read lengths, it's possible that some decode jobs have been queued before a later container is skipped. This makes callingcram_seek()hazardous as it drops any in-flight jobs before updating the file position. Instead, callhseek()directly so already-queued decode jobs are retained.Fixes samtools/samtools#2285 (CRAM region queries miss reads when using additional threads)