env_vars in pip_state vs. env in cmd

[dhs-rec]

Description of Issue/Question

Why is there a difference in the way environment variables are specified in pip.installed and cmd.run state methods?

Examples from the documentation:

django:
  pip.installed:
    - name: django_app
    - env_vars:
        CUSTOM_PATH: /opt/django_app
        VERBOSE: True

vs.

script-foo:
  cmd.run:
    - env:
      - BATCH: 'yes'

Differences are:

1. env vs. env_vars
2. dict vs. array

Could this be streamlined, please, so that there's only one unique way of specifying environment variables (and everywhere else where I didn't spot it, of course)?

See also:

https://docs.saltstack.com/en/latest/ref/states/all/salt.states.cmd.html#salt.states.cmd.run
https://docs.saltstack.com/en/latest/ref/states/all/salt.states.pip_state.html#salt.states.pip_state.installed

[Ch3LL]

I think this would be a good improvement. We would just need to make sure we properly deprecate the argument we do not choose.

[dhs-rec]

Any news on this?

[Ch3LL]

this is not currently assigned out to anyone due to other higher priority issues. Please feel free to try to send in a PR for this if you feel so inclined :)

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

If this issue is closed prematurely, please leave a comment and we will gladly reopen the issue.

[dhs-rec]

Yep.

[stale[bot]]

Thank you for updating this issue. It is no longer marked as stale.

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

If this issue is closed prematurely, please leave a comment and we will gladly reopen the issue.

[dhs-rec]

And again.

[stale[bot]]

Thank you for updating this issue. It is no longer marked as stale.