Adding exit for missing calibrations#4181
Merged
pinkenburg merged 1 commit intosPHENIX-Collaboration:masterfrom Feb 18, 2026
Merged
Adding exit for missing calibrations#4181pinkenburg merged 1 commit intosPHENIX-Collaboration:masterfrom
pinkenburg merged 1 commit intosPHENIX-Collaboration:masterfrom
Conversation
Contributor
📝 WalkthroughWalkthroughThe changes add configurable abort-on-missing-calibration flags to CaloTowerCalib and CaloTowerStatus classes. When critical calibrations (energy, time, ZS-cross, chi2, or hot-map) are unavailable during InitRun, the detector can now halt with an error message if the corresponding abort flag is enabled, or continue with defaults if disabled. Changes
✨ Finishing touches
Tip Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Comment on lines
+160
to
165
| if (m_doAbortNoTimeCalib) | ||
| { | ||
| std::cout << "CaloTowerCalib::InitRun: No time calibration found for " << m_calibName_time << " and abort mode is set. Exiting." << std::endl; | ||
| gSystem->Exit(1); | ||
| } | ||
| m_dotimecalib = false; |
Contributor
There was a problem hiding this comment.
m_doAbortNoTimeCalib fires even when time calibration is intentionally disabled.
The ZS calibration block (line 178) is wrapped in if (m_doZScrosscalib), so its abort check is never reached when ZS is disabled. The time calibration block has no equivalent guard. If a user calls set_doCalibOnly(true) (which sets m_dotimecalib = false) and then set_doAbortMissingCalib(true), InitRun will still enter the time calibration block, find an empty CDB URL, and hit gSystem->Exit(1) — even though the time calibration was intentionally turned off.
🐛 Proposed fix: guard the time calibration block analogously to the ZS block
- if (m_giveDirectURL_time)
+ if (m_dotimecalib && m_giveDirectURL_time)
{
calibdir = m_directURL_time;
std::cout << "CaloTowerCalib::InitRun: Using setted url " << calibdir << std::endl;
cdbttree_time = new CDBTTree(calibdir);
}
- else
+ else if (m_dotimecalib)
{
calibdir = CDBInterface::instance()->getUrl(m_calibName_time);
if (!calibdir.empty())
{
cdbttree_time = new CDBTTree(calibdir);
...
}
else
{
if (m_doAbortNoTimeCalib)
{
...
}
m_dotimecalib = false;
...
}
}
Build & test reportReport for commit 09e88174e67d2280cc6f3c24d625cf746782791c:
Automatically generated by sPHENIX Jenkins continuous integration |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Types of changes
What kind of change does this PR introduce? (Bug fix, feature, ...)
TODOs (if applicable)
Links to other PRs in macros and calibration repositories (if applicable)
Summary
This PR adds optional abort-on-missing-calibration functionality to the calorimeter tower calibration and status modules (
CaloTowerCalibandCaloTowerStatus). When enabled, jobs will exit immediately if required calibration data cannot be loaded, providing early detection of configuration issues.Motivation
Previously, when calibrations were unavailable, the reconstruction code would silently continue with default values or skip certain processing steps. This PR allows operators to explicitly require calibrations to be present and configured correctly before processing begins, preventing silent failures or unintended behavior.
Key Changes
CaloTowerCalib (
CaloTowerCalib.h/cc):set_doAbortNoEnergyCalib(),set_doAbortNoTimeCalib(),set_doAbortNoZSCalib()set_doAbortMissingCalib()to enable all three simultaneouslyfalse) for each abort conditionInitRun()to callgSystem->Exit(1)when a calibration is unavailable and its corresponding abort flag is enabledCaloTowerStatus (
CaloTowerStatus.h/cc):set_doAbortNoChi2(),set_doAbortNoTime(),set_doAbortMissingCalib()set_doAbortMissingCalib()sets all three flags at onceInitRun()to callgSystem->Exit(1)when required calibrations are unavailable and abort flags are enabledPotential Risk Areas
false, so existing behavior is preserved unless explicitly enabled. However, if these flags are enabled in macro configurations, jobs will now fail hard if calibrations are missing rather than attempting recovery with defaults.gSystem->Exit(1)will terminate the job immediately. No graceful shutdown or error recovery is possible once triggered.Notes
Future Improvements