fix mime type variables (#11)

jaschultz · web-flow · commit 68ef528d0098 · 2017-06-13T12:25:24.000-07:00
diff --git a/python_testspace_xml/testspace_xml.py b/python_testspace_xml/testspace_xml.py
@@ -33,7 +33,7 @@ def __init__(self, name='unknown', level='info', description=''):
         self.name = name
         self.level = level
         self.description = description
-        self.mimeType = None
+        self.mime_type = None
         self.file_path = None
         self.link_file = False
         self.gzip_data = None
@@ -45,7 +45,7 @@ def add_comment(self, name, comment):
 
     def set_file_annotation(self, file_path=None, mime_type='text/plain', string_buffer=None):
         self.file_path = file_path
-        self.mimeType = mime_type
+        self.mime_type = mime_type
         if file_path is not None:
             if not os.path.isfile(self.file_path):
                 self.level = 'error'
@@ -91,7 +91,7 @@ def write_xml(self, parent_element, dom):
 
         if self.gzip_data is not None:
                     annotation.setAttribute("link_file", "false")
-                    annotation.setAttribute("mime_type", self.mimeType)
+                    annotation.setAttribute("mime_type", self.mime_type)
                     b64_data = base64.b64encode(self.gzip_data)
                     b64_data_string = b64_data.decode()
                     cdata = dom.createCDATASection(b64_data_string)
@@ -157,7 +157,7 @@ def add_file_annotation(self, name, level='info', description='',
     def add_string_buffer_annotation(self, name, level='info', description='',
                                      string_buffer=None, mime_type='text/plain'):
         fa = Annotation(name, level, description)
-        fa.set_file_annotation(string_buffer=string_buffer, mime_type='text/plain')
+        fa.set_file_annotation(string_buffer=string_buffer, mime_type=mime_type)
         self.annotations.append(fa)
         return fa
 
@@ -226,7 +226,7 @@ def add_file_annotation(self, name, level='info', description='',
     def add_string_buffer_annotation(self, name, level='info', description='',
                                      string_buffer=None, mime_type='text/plain'):
         fa = Annotation(name, level, description)
-        fa.set_file_annotation(string_buffer=string_buffer, mime_type='text/plain')
+        fa.set_file_annotation(string_buffer=string_buffer, mime_type=mime_type)
         self.annotations.append(fa)
         return fa
 
diff --git a/tests/test_testspace_report.py b/tests/test_testspace_report.py
@@ -14,6 +14,9 @@ def create_simple_testspace_xml(self):
     string_buffer = 'Text content to be displayed in Testspace\n' \
                     'Additional line of content'
 
+    string_buffer_html = '<!DOCTYPE html><html><head><title>Page Title</title></head>' \
+                         '<body><h1>This is a Heading</h1><p>This is a paragraph.</p></body></html>'
+
     test_annotation = testspace_xml.Annotation('annotation with comment')
     test_annotation.add_comment("comment", "annotation comment")
 
@@ -23,6 +26,8 @@ def create_simple_testspace_xml(self):
     example_suite.add_link_annotation(path='https://help.testspace.com')
     example_suite.add_string_buffer_annotation(
         'Suite string annotation as file', string_buffer=string_buffer)
+    example_suite.add_string_buffer_annotation(
+        'Suite string annotation as html', string_buffer=string_buffer_html, mime_type='text/html')
     example_suite.add_text_annotation(
         'Suite Text Annotation', description='This is a string annotation only')
     example_suite.add_file_annotation('tests/report_v1.xsd', file_path='tests/report_v1.xsd')
@@ -79,7 +84,7 @@ def test_number_testsuites(self):
 
     def test_number_testsuite_annotations(self):
         test_cases = self.testspace_xml_root.xpath("//test_suite/annotation")
-        assert len(test_cases) is 5
+        assert len(test_cases) is 6
 
     def test_number_testcases(self):
         test_cases = self.testspace_xml_root.xpath("//test_suite/test_case")
