State in Rocket 0.5.1 and Rust 2024 edition

[raif-s-naffah]

hi there,

i'm trying to make my server work w/ Rust 1.85.0 (2024 edition) but i'm having trouble when a handler is expected to return something like...

Result<EitherOr<impl Stream<Item = MultipartSection<'static>>>, Status>

the code in question is here and the compiler's hint is as follows...

borrowed data escapes outside of function
`__req` escapes the function body hererustcClick for full compiler diagnostic
statement.rs(611, 1): `__req` is a reference that is only valid in the function body
statement.rs(611, 1): lifetime `'__r` defined here
borrowed data escapes outside of function
argument requires that `'__r` must outlive `'static`rustcClick for full compiler diagnostic
statement.rs(611, 1): `__req` is a reference that is only valid in the function body
statement.rs(611, 1): lifetime `'__r` defined here
borrowed data escapes outside of function
argument requires that `'1` must outlive `'static`rustcClick for full compiler diagnostic
statement.rs(611, 1): `__req` is a reference that is only valid in the function body
statement.rs(611, 1): has type `&rocket::Request<'1>`

the diagnostic message for the last hint shows

error[E0521]: borrowed data escapes outside of function
   --> src/lrs/resources/statement.rs:621:9
    |
611 | #[get("/more?<sid>&<count>&<offset>&<limit>&<format>&<attachments>")]
    | ---------------------------------------------------------------------
    | |
    | `__req` is a reference that is only valid in the function body
    | has type `&rocket::Request<'1>`
...
621 |     db: &State<DB>,
    |         ^
    |         |
    |         `__req` escapes the function body here
    |         argument requires that `'1` must outlive `'static`

at first i thought it's due to my use of MultipartSection<'static> in the handler's return type. however, changing to

  Result<EitherOr<impl Stream<Item = MultipartSection<'r>>>, Status>

and assigning a lifetime to the handler like so

  async fn get_more<r>(...)

does not solve the issue most likely b/c State is defined as...

rocket::state
pub struct State<T>(T)
where
    T: Send + Sync + 'static,

if that makes sense, any suggestions on how to migrate this handler to the 2024 edition is appreciated.

TIA + cheers;
rsn

[raif-s-naffah]

Following up on my initial post, it looks like it's too early to switch my server to the 2024 edition.

The best i can do for now is to add #![warn(rust_2024_compatibility)] to the lib.rs and fix the warnings that are emitted. Specifically for the handler i mentioned in my initial post changing the return type to...

Result<EitherOr<impl Stream<Item = MultipartSection<'static>> + use<>>, Status> {

solves the issue.