Move triagebot.toml validation handler to check commits super-handler
#2084
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kobzol
approved these changes
Jun 17, 2025
|
It looks like no-one actually set the config (https://github.com/search?type=code&q=org%3Arust-lang+validate_config), so should be safe to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves our
triagebot.tomlvalidation handler (with fake config) to our recently new check commits super-handler.That way it can share all the benefits of our super-handler, like draft/rollup handling, as well as pre-fetching of the diffs.
I also took the opportunity to simply the logic and remove the fake config.
Best reviewed commits and commits.