Skip to content

Commit d5a7580

Browse files
lqdlqd
authored
Merge pull request #2237 from Kobzol/triage-2025-09-02
Add 2025-09-02 triage
2 parents 84c87ed + 27c0869 commit d5a7580

File tree

1 file changed

+152
-0
lines changed

1 file changed

+152
-0
lines changed

‎triage/2025/2025-09-02.md

Lines changed: 152 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,152 @@
1+
# 2025-09-02 Triage Log
2+
3+
A relatively quiet week. [#144841](https://github.com/rust-lang/rust/pull/144841) added an
4+
optimization for incremental builds that provided a very nice win for the `nalgebra` crate. [#143290](https://github.com/rust-lang/rust/pull/143290) should help avoid instantiating async functions repeatedly in
5+
downstream crates.
6+
7+
Triage done by **@kobzol**..-
8+
Revision range: [ee361e8f..75ee9ffd](https://perf.rust-lang.org/?start=ee361e8fca1c30e13e7a31cc82b64c045339d3a8&end=75ee9ffd5ed3649c0a09493057adaa8feebb2035&absolute=false&stat=instructions%3Au)
9+
10+
**Summary**:
11+
12+
| (instructions:u) | mean | range | count |
13+
|:----------------------------------:|:-----:|:--------------:|:-----:|
14+
| Regressions ❌ <br /> (primary) | 0.3% | [0.2%, 0.4%] | 7 |
15+
| Regressions ❌ <br /> (secondary) | 2.0% | [0.1%, 13.6%] | 30 |
16+
| Improvements ✅ <br /> (primary) | -1.9% | [-7.0%, -0.3%] | 17 |
17+
| Improvements ✅ <br /> (secondary) | -0.7% | [-1.7%, -0.1%] | 23 |
18+
| All ❌✅ (primary) | -1.2% | [-7.0%, 0.4%] | 24 |
19+
20+
21+
1 Regression, 3 Improvements, 6 Mixed; 5 of them in rollups
22+
45 artifact comparisons made in total
23+
24+
#### Regressions
25+
26+
pub async fn impl is monomorphized when func itself is monomorphized [#143290](https://github.com/rust-lang/rust/pull/143290) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=84a17470220e7adf249b18d7c0178dfbede89462&end=c0bb3b98bb7aac24a37635e5d36d961e0b14f435&stat=instructions:u)
27+
28+
| (instructions:u) | mean | range | count |
29+
|:----------------------------------:|:----:|:-------------:|:-----:|
30+
| Regressions ❌ <br /> (primary) | - | - | 0 |
31+
| Regressions ❌ <br /> (secondary) | 6.1% | [0.9%, 13.5%] | 6 |
32+
| Improvements ✅ <br /> (primary) | - | - | 0 |
33+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
34+
| All ❌✅ (primary) | - | - | 0 |
35+
36+
- The regression is expected, as we now do more work for async fns in their crate, with the hope of reducing the amount of work required in downstream crates.
37+
- Marked as triaged.
38+
39+
#### Improvements
40+
41+
Rollup of 6 pull requests [#145916](https://github.com/rust-lang/rust/pull/145916) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=269d5b56bcfdf2be82213e72ef9a2e4c592a8c6b&end=4f808ba6bf9f1c8dde30d009e73386d984491587&stat=instructions:u)
42+
43+
| (instructions:u) | mean | range | count |
44+
|:----------------------------------:|:-----:|:--------------:|:-----:|
45+
| Regressions ❌ <br /> (primary) | - | - | 0 |
46+
| Regressions ❌ <br /> (secondary) | 0.3% | [0.3%, 0.3%] | 1 |
47+
| Improvements ✅ <br /> (primary) | -0.2% | [-0.2%, -0.2%] | 1 |
48+
| Improvements ✅ <br /> (secondary) | -2.7% | [-2.9%, -2.5%] | 6 |
49+
| All ❌✅ (primary) | -0.2% | [-0.2%, -0.2%] | 1 |
50+
51+
52+
Rollup of 6 pull requests [#145970](https://github.com/rust-lang/rust/pull/145970) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=35d55b34bffd51384ac430cc20852b7d16dd5a90&end=f2824da98d44c4a4e17bf39eb45103c8fc249117&stat=instructions:u)
53+
54+
| (instructions:u) | mean | range | count |
55+
|:----------------------------------:|:-----:|:--------------:|:-----:|
56+
| Regressions ❌ <br /> (primary) | - | - | 0 |
57+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
58+
| Improvements ✅ <br /> (primary) | -0.4% | [-0.9%, -0.1%] | 32 |
59+
| Improvements ✅ <br /> (secondary) | -0.5% | [-0.9%, -0.1%] | 10 |
60+
| All ❌✅ (primary) | -0.4% | [-0.9%, -0.1%] | 32 |
61+
62+
63+
Rollup of 6 pull requests [#146072](https://github.com/rust-lang/rust/pull/146072) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=828e45ad11ce4ab56dd64e93f1fb5dd8f0c0ae93&end=be4e9b77ab5502b7beda0b787fb3c978a7b4db79&stat=instructions:u)
64+
65+
| (instructions:u) | mean | range | count |
66+
|:----------------------------------:|:-----:|:--------------:|:-----:|
67+
| Regressions ❌ <br /> (primary) | - | - | 0 |
68+
| Regressions ❌ <br /> (secondary) | 0.0% | [0.0%, 0.0%] | 1 |
69+
| Improvements ✅ <br /> (primary) | -0.2% | [-0.2%, -0.1%] | 3 |
70+
| Improvements ✅ <br /> (secondary) | -0.2% | [-0.2%, -0.1%] | 8 |
71+
| All ❌✅ (primary) | -0.2% | [-0.2%, -0.1%] | 3 |
72+
73+
74+
#### Mixed
75+
76+
Rollup of 9 pull requests [#145906](https://github.com/rust-lang/rust/pull/145906) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=160e7623e8cbbf1feab2b6e2a24733a98c7bde9c&end=176d8dbce6a7a7a4541d1c980d4a85dfb76ce1f1&stat=instructions:u)
77+
78+
| (instructions:u) | mean | range | count |
79+
|:----------------------------------:|:-----:|:--------------:|:-----:|
80+
| Regressions ❌ <br /> (primary) | - | - | 0 |
81+
| Regressions ❌ <br /> (secondary) | 0.4% | [0.4%, 0.4%] | 2 |
82+
| Improvements ✅ <br /> (primary) | -0.3% | [-0.5%, -0.2%] | 10 |
83+
| Improvements ✅ <br /> (secondary) | -0.3% | [-0.3%, -0.3%] | 1 |
84+
| All ❌✅ (primary) | -0.3% | [-0.5%, -0.2%] | 10 |
85+
86+
- More wins than regressions, and the two regressions are small, in `incr-unchanged` and in secondary benchmarks.
87+
- Marked as triaged.
88+
89+
Access less HIR attributes from typeck [#144841](https://github.com/rust-lang/rust/pull/144841) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=176d8dbce6a7a7a4541d1c980d4a85dfb76ce1f1&end=269d5b56bcfdf2be82213e72ef9a2e4c592a8c6b&stat=instructions:u)
90+
91+
| (instructions:u) | mean | range | count |
92+
|:----------------------------------:|:-----:|:--------------:|:-----:|
93+
| Regressions ❌ <br /> (primary) | 0.3% | [0.2%, 0.4%] | 4 |
94+
| Regressions ❌ <br /> (secondary) | 2.8% | [2.6%, 3.0%] | 6 |
95+
| Improvements ✅ <br /> (primary) | -1.7% | [-7.0%, -0.2%] | 17 |
96+
| Improvements ✅ <br /> (secondary) | -0.4% | [-0.6%, -0.2%] | 15 |
97+
| All ❌✅ (primary) | -1.3% | [-7.0%, 0.4%] | 21 |
98+
99+
- More improvements than regressions, and a very nice incremental win on nalgebra.
100+
- Marked as triaged.
101+
102+
Region inference: Use outlives-static constraints in constraint search [#140737](https://github.com/rust-lang/rust/pull/140737) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=4f808ba6bf9f1c8dde30d009e73386d984491587&end=b2dd217dd0a099fb87601657ec480bf3e92b30a6&stat=instructions:u)
103+
104+
| (instructions:u) | mean | range | count |
105+
|:----------------------------------:|:-----:|:--------------:|:-----:|
106+
| Regressions ❌ <br /> (primary) | 0.2% | [0.1%, 0.4%] | 13 |
107+
| Regressions ❌ <br /> (secondary) | 0.2% | [0.1%, 0.3%] | 9 |
108+
| Improvements ✅ <br /> (primary) | - | - | 0 |
109+
| Improvements ✅ <br /> (secondary) | -0.3% | [-0.3%, -0.3%] | 6 |
110+
| All ❌✅ (primary) | 0.2% | [0.1%, 0.4%] | 13 |
111+
112+
- Looks like a small number of real regressions.
113+
- Not marking as triaged yet, following up on the PR.
114+
115+
Use captures(address) instead of captures(none) for indirect args [#145877](https://github.com/rust-lang/rust/pull/145877) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=cdb45c87e2cd43495379f7e867e3cc15dcee9f93&end=d36f964125163c2e698de5559efefb8217b8b7f0&stat=instructions:u)
116+
117+
| (instructions:u) | mean | range | count |
118+
|:----------------------------------:|:-----:|:--------------:|:-----:|
119+
| Regressions ❌ <br /> (primary) | 0.8% | [0.1%, 1.5%] | 2 |
120+
| Regressions ❌ <br /> (secondary) | 0.4% | [0.2%, 1.5%] | 14 |
121+
| Improvements ✅ <br /> (primary) | -0.2% | [-0.2%, -0.2%] | 1 |
122+
| Improvements ✅ <br /> (secondary) | -0.5% | [-0.6%, -0.4%] | 3 |
123+
| All ❌✅ (primary) | 0.5% | [-0.2%, 1.5%] | 3 |
124+
125+
- The syn results are noise.
126+
- This is a correctness fix, marked as triaged.
127+
128+
Rollup of 9 pull requests [#145958](https://github.com/rust-lang/rust/pull/145958) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=b41634205b549a62cfa55363d1e00c4143d30033&end=1f7dcc878d73c45cc40018aac6e5c767446df110&stat=instructions:u)
129+
130+
| (instructions:u) | mean | range | count |
131+
|:----------------------------------:|:-----:|:--------------:|:-----:|
132+
| Regressions ❌ <br /> (primary) | 0.2% | [0.2%, 0.2%] | 3 |
133+
| Regressions ❌ <br /> (secondary) | 2.4% | [0.2%, 3.0%] | 7 |
134+
| Improvements ✅ <br /> (primary) | - | - | 0 |
135+
| Improvements ✅ <br /> (secondary) | -0.8% | [-1.4%, -0.0%] | 11 |
136+
| All ❌✅ (primary) | 0.2% | [0.2%, 0.2%] | 3 |
137+
138+
- The match-stress results are noise, the externs wins look real, and then there's one tiny regression on unicode-normalization.
139+
- Marked as triaged.
140+
141+
`-Znext-solver`: support non-defining uses in closures [#145925](https://github.com/rust-lang/rust/pull/145925) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=7aef4bec4bec16cb6204d51eb633873e23b18771&end=75ee9ffd5ed3649c0a09493057adaa8feebb2035&stat=instructions:u)
142+
143+
| (instructions:u) | mean | range | count |
144+
|:----------------------------------:|:-----:|:--------------:|:-----:|
145+
| Regressions ❌ <br /> (primary) | 0.2% | [0.1%, 0.6%] | 33 |
146+
| Regressions ❌ <br /> (secondary) | 0.3% | [0.0%, 0.8%] | 29 |
147+
| Improvements ✅ <br /> (primary) | -0.3% | [-0.3%, -0.2%] | 3 |
148+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
149+
| All ❌✅ (primary) | 0.2% | [-0.3%, 0.6%] | 36 |
150+
151+
- The regressions look real, following up on the PR.
152+
- Not marking as triaged yet.

0 commit comments

Comments
 (0)